Attention is currently required from: Furquan Shaikh, Maulik V Vaghela, Meera Ravindranath.
Hello build bot (Jenkins), Furquan Shaikh, Maulik V Vaghela, Subrata Banik,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/56881
to look at the new patch set (#5).
Change subject: mb/intel/adlrvp: Add support for DDR5 MR SKU
......................................................................
mb/intel/adlrvp: Add support for DDR5 MR SKU
DDR5 Maple ridge SKU (Board ID 0x16) uses a Memory down DIMM
configuration. This CL adds support for the same.
TEST=Boot DDR5 MR SKU to OS.
Signed-off-by: Meera Ravindranath <meera.ravindranath(a)intel.com>
Change-Id: I0b7a96b5534d8b80776aa7578ce7c13181af7882
---
M src/mainboard/intel/adlrvp/romstage_fsp_params.c
M src/mainboard/intel/adlrvp/spd/Makefile.inc
A src/mainboard/intel/adlrvp/spd/adlrvp_ddr5_mr.spd.hex
3 files changed, 34 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/81/56881/5
--
To view, visit https://review.coreboot.org/c/coreboot/+/56881
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I0b7a96b5534d8b80776aa7578ce7c13181af7882
Gerrit-Change-Number: 56881
Gerrit-PatchSet: 5
Gerrit-Owner: Meera Ravindranath <meera.ravindranath(a)intel.com>
Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com>
Gerrit-Reviewer: Maulik V Vaghela <maulik.v.vaghela(a)intel.com>
Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Furquan Shaikh <furquan(a)google.com>
Gerrit-Attention: Maulik V Vaghela <maulik.v.vaghela(a)intel.com>
Gerrit-Attention: Meera Ravindranath <meera.ravindranath(a)intel.com>
Gerrit-MessageType: newpatchset
Attention is currently required from: Furquan Shaikh, Maulik V Vaghela, Tim Wawrzynczak, Angel Pons.
Meera Ravindranath has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56899 )
Change subject: mb/intel/adlrvp: Rename spd_info struct based on memory topology
......................................................................
Patch Set 2:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/56899/comment/9852fb65_e2922ad1
PS1, Line 10: code.
> nit: if you could add what all variables that you have renamed here ? […]
Done
--
To view, visit https://review.coreboot.org/c/coreboot/+/56899
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I0b7a66b5524d8b80776ab7578ce7b13181af7882
Gerrit-Change-Number: 56899
Gerrit-PatchSet: 2
Gerrit-Owner: Meera Ravindranath <meera.ravindranath(a)intel.com>
Gerrit-Reviewer: Angel Pons <angel.pons(a)9elements.com>
Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com>
Gerrit-Reviewer: Maulik V Vaghela <maulik.v.vaghela(a)intel.com>
Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Furquan Shaikh <furquan(a)google.com>
Gerrit-Attention: Maulik V Vaghela <maulik.v.vaghela(a)intel.com>
Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Attention: Angel Pons <angel.pons(a)9elements.com>
Gerrit-Comment-Date: Tue, 10 Aug 2021 15:52:48 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Subrata Banik <subrata.banik(a)intel.com>
Gerrit-MessageType: comment
Attention is currently required from: Furquan Shaikh, Maulik V Vaghela, Meera Ravindranath.
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56881 )
Change subject: mb/intel/adlrvp: Add support for DDR5 MR SKU
......................................................................
Patch Set 4:
(1 comment)
File src/mainboard/intel/adlrvp/romstage_fsp_params.c:
https://review.coreboot.org/c/coreboot/+/56881/comment/61249454_b6d128d6
PS4, Line 58: case ADL_P_DDR5_2:
shouldn't this go to https://review.coreboot.org/c/coreboot/+/56881/4/src/mainboard/intel/adlrvp… so that you don't need to add memcfg_init again ? just add board_id?
--
To view, visit https://review.coreboot.org/c/coreboot/+/56881
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I0b7a96b5534d8b80776aa7578ce7c13181af7882
Gerrit-Change-Number: 56881
Gerrit-PatchSet: 4
Gerrit-Owner: Meera Ravindranath <meera.ravindranath(a)intel.com>
Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com>
Gerrit-Reviewer: Maulik V Vaghela <maulik.v.vaghela(a)intel.com>
Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Furquan Shaikh <furquan(a)google.com>
Gerrit-Attention: Maulik V Vaghela <maulik.v.vaghela(a)intel.com>
Gerrit-Attention: Meera Ravindranath <meera.ravindranath(a)intel.com>
Gerrit-Comment-Date: Tue, 10 Aug 2021 15:45:56 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Furquan Shaikh, Maulik V Vaghela, Tim Wawrzynczak, Meera Ravindranath, Angel Pons.
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56899 )
Change subject: mb/intel/adlrvp: Rename spd_info struct based on memory topology
......................................................................
Patch Set 1: Code-Review+2
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/56899/comment/1e5369ec_d873a0c9
PS1, Line 10: code.
nit: if you could add what all variables that you have renamed here ?
lp4_lp5_spd_info -> memory_down_spd_info
ddr4_ddr5_spd_info -> dimm_module_spd_info
--
To view, visit https://review.coreboot.org/c/coreboot/+/56899
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I0b7a66b5524d8b80776ab7578ce7b13181af7882
Gerrit-Change-Number: 56899
Gerrit-PatchSet: 1
Gerrit-Owner: Meera Ravindranath <meera.ravindranath(a)intel.com>
Gerrit-Reviewer: Angel Pons <angel.pons(a)9elements.com>
Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com>
Gerrit-Reviewer: Maulik V Vaghela <maulik.v.vaghela(a)intel.com>
Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Attention: Furquan Shaikh <furquan(a)google.com>
Gerrit-Attention: Maulik V Vaghela <maulik.v.vaghela(a)intel.com>
Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Attention: Meera Ravindranath <meera.ravindranath(a)intel.com>
Gerrit-Attention: Angel Pons <angel.pons(a)9elements.com>
Gerrit-Comment-Date: Tue, 10 Aug 2021 15:43:19 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Chen Wisley, Paul Menzel, Angel Pons.
Wisley Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56893 )
Change subject: mb/google/brya/variants/redrix: add mipi camera support
......................................................................
Patch Set 3:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/56893/comment/7f99183b_88981351
PS2, Line 9: Add mipi camera support
> … by selecting the Kconfig symbols and adding it to the devicetree with ACPI UID 0x50000 and name IP […]
Done
https://review.coreboot.org/c/coreboot/+/56893/comment/31264e2d_5f91dc32
PS2, Line 12: can work normally
> works
Done
--
To view, visit https://review.coreboot.org/c/coreboot/+/56893
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I69281f36ddbc1abf9905c8db9287500f9aa995c6
Gerrit-Change-Number: 56893
Gerrit-PatchSet: 3
Gerrit-Owner: Chen Wisley <wisley.chen(a)quantatw.com>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: Wisley Chen <wisley.chen(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Chen Wisley <wisley.chen(a)quantatw.com>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Comment-Date: Tue, 10 Aug 2021 15:39:58 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-MessageType: comment