Attention is currently required from: Maxim Polyakov, Jonathan Zhang.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56886 )
Change subject: MAINTAINERS: Add myself as maintainer for intelp2m
......................................................................
Patch Set 2: Code-Review+1
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/56886/comment/6cd731b7_b4235bae
PS2, Line 7: myself
Nit: If the author is not shown, maybe even:
> Add Maxim Polyakov as intelp2m maintainer
--
To view, visit https://review.coreboot.org/c/coreboot/+/56886
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I85835712926ca456b108b1d80e6a55f75e604591
Gerrit-Change-Number: 56886
Gerrit-PatchSet: 2
Gerrit-Owner: Maxim Polyakov <max.senia.poliak(a)gmail.com>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Jonathan Zhang <jonzhang(a)fb.com>
Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Maxim Polyakov <max.senia.poliak(a)gmail.com>
Gerrit-Attention: Jonathan Zhang <jonzhang(a)fb.com>
Gerrit-Comment-Date: Tue, 10 Aug 2021 10:12:00 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Chen Wisley, Tim Wawrzynczak, Wisley Chen.
Wisley Chen has uploaded a new patch set (#3) to the change originally created by Chen Wisley. ( https://review.coreboot.org/c/coreboot/+/56893 )
Change subject: mb/google/brya/variants/redrix: add mipi camera support
......................................................................
mb/google/brya/variants/redrix: add mipi camera support
Add mipi camera support by selecting the Kconfig symbols and adding it
to the devicetree with ACPI UID 0x50000 and name IPU0.
BUG=b:192052098
TEST=checked mipi camera works
Signed-off-by: Wisley Chen <wisley.chen(a)quanta.corp-partner.google.com>
Change-Id: I69281f36ddbc1abf9905c8db9287500f9aa995c6
---
M src/mainboard/google/brya/Kconfig.name
M src/mainboard/google/brya/variants/redrix/overridetree.cb
2 files changed, 73 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/93/56893/3
--
To view, visit https://review.coreboot.org/c/coreboot/+/56893
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I69281f36ddbc1abf9905c8db9287500f9aa995c6
Gerrit-Change-Number: 56893
Gerrit-PatchSet: 3
Gerrit-Owner: Chen Wisley <wisley.chen(a)quantatw.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: Wisley Chen <wisley.chen(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Chen Wisley <wisley.chen(a)quantatw.com>
Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Attention: Wisley Chen <wisley.chen(a)quanta.corp-partner.google.com>
Gerrit-MessageType: newpatchset
Attention is currently required from: Tim Crawford.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56861 )
Change subject: 3rdparty/intel-microcode: Update submodule to 20210608 release
......................................................................
Patch Set 2:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/56861/comment/920e4139_c23b9a55
PS1, Line 10:
> Well, coreboot reports a microcode revision that doesn't exist, at least on my CFL-H and CML-H board […]
Thank you for testing. It’d be great if you documented this in the commit message.
--
To view, visit https://review.coreboot.org/c/coreboot/+/56861
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I084ba67e8eaf7383f1c05fa5589b63c92ff900b1
Gerrit-Change-Number: 56861
Gerrit-PatchSet: 2
Gerrit-Owner: Tim Crawford <tcrawford(a)system76.com>
Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Tim Crawford <tcrawford(a)system76.com>
Gerrit-Comment-Date: Tue, 10 Aug 2021 10:11:05 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Tim Crawford <tcrawford(a)system76.com>
Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-MessageType: comment
Attention is currently required from: Tim Crawford, Jeremy Soller, Arthur Heymans.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56888 )
Change subject: mb/system76/*: Add CMOS option table
......................................................................
Patch Set 1:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/56888/comment/e9ec561e_30f812ef
PS1, Line 10: providing a generic layout.
… with the defaults:
boot_option=Fallback
debug_level=Debug
power_on_after_fail=Enable
--
To view, visit https://review.coreboot.org/c/coreboot/+/56888
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie57b0e5713bba8ad46e1a4123a3ddd43e0eea964
Gerrit-Change-Number: 56888
Gerrit-PatchSet: 1
Gerrit-Owner: Tim Crawford <tcrawford(a)system76.com>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Jeremy Soller <jeremy(a)system76.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Tim Crawford <tcrawford(a)system76.com>
Gerrit-Attention: Jeremy Soller <jeremy(a)system76.com>
Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Comment-Date: Tue, 10 Aug 2021 10:09:24 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Chen Wisley, Tim Wawrzynczak, Wisley Chen.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56893 )
Change subject: mb/google/brya/variants/redrix: add mipi camera support
......................................................................
Patch Set 2:
(3 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/56893/comment/32b40b21_a690d845
PS2, Line 9: Add mipi camera support
… by selecting the Kconfig symbols and adding it to the devicetree with ACPI UID 0x50000 and name IPU0.
https://review.coreboot.org/c/coreboot/+/56893/comment/9341fe68_d53da57c
PS2, Line 12: can work normally
works
File src/mainboard/google/brya/variants/redrix/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/56893/comment/16baa623_24922f00
PS2, Line 128: register "acpi_uid" = "0x50000"
: register "acpi_name" = ""IPU0""
: register "device_type" = "INTEL_ACPI_CAMERA_CIO2"
Off-topic: This seems to be the same for all mipi_camera entries. Can this somehow be refactored to avoid duplication?
--
To view, visit https://review.coreboot.org/c/coreboot/+/56893
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I69281f36ddbc1abf9905c8db9287500f9aa995c6
Gerrit-Change-Number: 56893
Gerrit-PatchSet: 2
Gerrit-Owner: Chen Wisley <wisley.chen(a)quantatw.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: Wisley Chen <wisley.chen(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Chen Wisley <wisley.chen(a)quantatw.com>
Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Attention: Wisley Chen <wisley.chen(a)quanta.corp-partner.google.com>
Gerrit-Comment-Date: Tue, 10 Aug 2021 10:07:53 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Matt DeVillier, Benjamin Doron, Angel Pons, Michael Niewöhner.
Maxim Polyakov has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56887 )
Change subject: util/intelp2m: Remove non-DWx register analysis support
......................................................................
Patch Set 3:
(1 comment)
File util/intelp2m/parser/parser.go:
https://review.coreboot.org/c/coreboot/+/56887/comment/6949ecbd_054f108b
PS1, Line 94: township
> own*er*ship
Sorry for my inattention. This happens when I try to do several things at the same time :)
--
To view, visit https://review.coreboot.org/c/coreboot/+/56887
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If5c77ff942a620897c085be4135cb879a0d40a00
Gerrit-Change-Number: 56887
Gerrit-PatchSet: 3
Gerrit-Owner: Maxim Polyakov <max.senia.poliak(a)gmail.com>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Benjamin Doron <benjamin.doron00(a)gmail.com>
Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-Reviewer: Michael Niewöhner <foss(a)mniewoehner.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Johnny Lin <Johnny_Lin(a)wiwynn.com>
Gerrit-CC: Jonathan Zhang <jonzhang(a)fb.com>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-Attention: Benjamin Doron <benjamin.doron00(a)gmail.com>
Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Attention: Michael Niewöhner <foss(a)mniewoehner.de>
Gerrit-Comment-Date: Tue, 10 Aug 2021 10:01:23 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Maxim Polyakov <max.senia.poliak(a)gmail.com>
Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-MessageType: comment
Attention is currently required from: Maxim Polyakov, Matt DeVillier, Benjamin Doron, Michael Niewöhner.
Hello build bot (Jenkins), Matt DeVillier, Benjamin Doron, Angel Pons, Michael Niewöhner,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/56887
to look at the new patch set (#3).
Change subject: util/intelp2m: Remove non-DWx register analysis support
......................................................................
util/intelp2m: Remove non-DWx register analysis support
The utility can parse the value of non-DWx registers, if they are
present in the inteltool dump. However, the functions that allow the
inteltool utility to print the value of such registers have not been
added to the master, and it makes no sense to support such functions
in intelp2m, besides, their implementation is far from ideal. Remove
this unused functionality. This will be restored or added in a new
implementation as soon as similar functionality is added to inteltool.
TEST: ./intelp2m -file inteltool-asrock-h110m-dvs.log
generate/gpio.h before and after the patch is the same.
Change-Id: If5c77ff942a620897c085be4135cb879a0d40a00
Signed-off-by: Maxim Polyakov <max.senia.poliak(a)gmail.com>
---
M util/intelp2m/parser/parser.go
M util/intelp2m/parser/template.go
M util/intelp2m/platforms/apl/template.go
M util/intelp2m/platforms/cnl/template.go
M util/intelp2m/platforms/lbg/template.go
M util/intelp2m/platforms/snr/template.go
6 files changed, 4 insertions(+), 120 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/87/56887/3
--
To view, visit https://review.coreboot.org/c/coreboot/+/56887
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If5c77ff942a620897c085be4135cb879a0d40a00
Gerrit-Change-Number: 56887
Gerrit-PatchSet: 3
Gerrit-Owner: Maxim Polyakov <max.senia.poliak(a)gmail.com>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Benjamin Doron <benjamin.doron00(a)gmail.com>
Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-Reviewer: Michael Niewöhner <foss(a)mniewoehner.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Johnny Lin <Johnny_Lin(a)wiwynn.com>
Gerrit-CC: Jonathan Zhang <jonzhang(a)fb.com>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Maxim Polyakov <max.senia.poliak(a)gmail.com>
Gerrit-Attention: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-Attention: Benjamin Doron <benjamin.doron00(a)gmail.com>
Gerrit-Attention: Michael Niewöhner <foss(a)mniewoehner.de>
Gerrit-MessageType: newpatchset