Attention is currently required from: Bora Guvendik, Anil Kumar K, Selma Bensaid, Tim Wawrzynczak, Patrick Rudolph.
Sumeet R Pawnikar has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56846 )
Change subject: soc/intel/adl: Update PCI ID for ADL-M SKU
......................................................................
Patch Set 2:
(2 comments)
File src/include/device/pci_ids.h:
PS1:
> Wait, what's going on here? Was this MCHID incorrect in the first place? If so, this is definitely f […]
Ack
File src/soc/intel/alderlake/chipset.cb:
https://review.coreboot.org/c/coreboot/+/56846/comment/cedab0bf_480f7b62
PS1, Line 28:
> extra blank line not needed
Done
--
To view, visit https://review.coreboot.org/c/coreboot/+/56846
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia2c5ce270bc421d8a41cc4bc6ce0b51987d2aaec
Gerrit-Change-Number: 56846
Gerrit-PatchSet: 2
Gerrit-Owner: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com>
Gerrit-Reviewer: Anil Kumar K <anil.kumar.k(a)intel.com>
Gerrit-Reviewer: Bora Guvendik <bora.guvendik(a)intel.com>
Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Reviewer: Selma Bensaid <selma.bensaid(a)intel.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Bora Guvendik <bora.guvendik(a)intel.com>
Gerrit-Attention: Anil Kumar K <anil.kumar.k(a)intel.com>
Gerrit-Attention: Selma Bensaid <selma.bensaid(a)intel.com>
Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Comment-Date: Sat, 14 Aug 2021 06:40:11 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-MessageType: comment
Attention is currently required from: Bora Guvendik, Anil Kumar K, Selma Bensaid, Sumeet R Pawnikar, Patrick Rudolph.
Hello Bora Guvendik, build bot (Jenkins), Anil Kumar K, Selma Bensaid, Tim Wawrzynczak, Patrick Rudolph,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/56846
to look at the new patch set (#2).
Change subject: soc/intel/adl: Update PCI ID for ADL-M SKU
......................................................................
soc/intel/adl: Update PCI ID for ADL-M SKU
Update PCI ID for ADL-M as per document 643775.
BUG=None
BRANCH=None
Change-Id: Ia2c5ce270bc421d8a41cc4bc6ce0b51987d2aaec
Signed-off-by: Sumeet Pawnikar <sumeet.r.pawnikar(a)intel.com>
---
M src/include/device/pci_ids.h
M src/soc/intel/alderlake/bootblock/report_platform.c
M src/soc/intel/common/block/systemagent/systemagent.c
3 files changed, 3 insertions(+), 3 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/46/56846/2
--
To view, visit https://review.coreboot.org/c/coreboot/+/56846
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia2c5ce270bc421d8a41cc4bc6ce0b51987d2aaec
Gerrit-Change-Number: 56846
Gerrit-PatchSet: 2
Gerrit-Owner: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com>
Gerrit-Reviewer: Anil Kumar K <anil.kumar.k(a)intel.com>
Gerrit-Reviewer: Bora Guvendik <bora.guvendik(a)intel.com>
Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Reviewer: Selma Bensaid <selma.bensaid(a)intel.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Bora Guvendik <bora.guvendik(a)intel.com>
Gerrit-Attention: Anil Kumar K <anil.kumar.k(a)intel.com>
Gerrit-Attention: Selma Bensaid <selma.bensaid(a)intel.com>
Gerrit-Attention: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com>
Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-MessageType: newpatchset
Attention is currently required from: Paul Menzel.
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/56635
to look at the new patch set (#4).
Change subject: util/testing: Add script building roms reproducible
......................................................................
util/testing: Add script building roms reproducible
Testing a patch series for reproducibility might take a lot of time if
it is done by hand. Thus, add `repbuild.sh` trying to simplify that
process.
`repbuild.sh` requires a config that should be tested and git HEAD
pointing to the patch that serves as start. It builds the current
coreboot config with `BUILD_TIMELESS=1`, moves the coreboot.rom to a
subdirectory and it moves the HEAD pointer forward by one. This is
done until git reaches the last patch of that branch.
Then, the coreboot.rom files can be easily verified by comparing their
checksums, e.g.:
b9ce4a1e3589b727541769e1a8372176 roms/coreboot-4.14-1193-g8905ecbcfa.rom
b9ce4a1e3589b727541769e1a8372176 roms/coreboot-4.14-1194-g75be324524.rom
b9ce4a1e3589b727541769e1a8372176 roms/coreboot-4.14-1195-gee3d09b48e.rom
Change-Id: I989c54cd4c39c966b5f60bda15512591e800285c
Signed-off-by: Felix Singer <felix.singer(a)secunet.com>
---
A util/testing/repbuild.sh
1 file changed, 20 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/35/56635/4
--
To view, visit https://review.coreboot.org/c/coreboot/+/56635
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I989c54cd4c39c966b5f60bda15512591e800285c
Gerrit-Change-Number: 56635
Gerrit-PatchSet: 4
Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-MessageType: newpatchset
Attention is currently required from: Paul Menzel.
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/56635
to look at the new patch set (#3).
Change subject: util/testing: Add script simplifying reproducible builds
......................................................................
util/testing: Add script simplifying reproducible builds
Testing a patch series for reproducibility might take a lot of time if
it is done by hand. Thus, add `repbuild.sh` trying to simplify that
process.
`repbuild.sh` requires a config that should be tested and git HEAD
pointing to the patch that serves as start. It builds the current
coreboot config with `BUILD_TIMELESS=1`, moves the coreboot.rom to a
subdirectory and it moves the HEAD pointer forward by one. This is
done until git reaches the last patch of that branch.
Then, the coreboot.rom files can be easily verified by comparing their
checksums, e.g.:
b9ce4a1e3589b727541769e1a8372176 roms/coreboot-4.14-1193-g8905ecbcfa.rom
b9ce4a1e3589b727541769e1a8372176 roms/coreboot-4.14-1194-g75be324524.rom
b9ce4a1e3589b727541769e1a8372176 roms/coreboot-4.14-1195-gee3d09b48e.rom
Change-Id: I989c54cd4c39c966b5f60bda15512591e800285c
Signed-off-by: Felix Singer <felix.singer(a)secunet.com>
---
A util/testing/repbuild.sh
1 file changed, 20 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/35/56635/3
--
To view, visit https://review.coreboot.org/c/coreboot/+/56635
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I989c54cd4c39c966b5f60bda15512591e800285c
Gerrit-Change-Number: 56635
Gerrit-PatchSet: 3
Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-MessageType: newpatchset
Attention is currently required from: Paul Menzel.
Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56635 )
Change subject: util/testing: Add script simplifying reproducible builds
......................................................................
Patch Set 2:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/56635/comment/1ac7ba9a_4d5942cd
PS1, Line 8:
> Please elaborate.
Done
--
To view, visit https://review.coreboot.org/c/coreboot/+/56635
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I989c54cd4c39c966b5f60bda15512591e800285c
Gerrit-Change-Number: 56635
Gerrit-PatchSet: 2
Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Comment-Date: Sat, 14 Aug 2021 05:53:33 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-MessageType: comment
Attention is currently required from: Felix Singer.
Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56635 )
Change subject: util/testing: Add script simplifying reproducible builds
......................................................................
Set Ready For Review
--
To view, visit https://review.coreboot.org/c/coreboot/+/56635
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I989c54cd4c39c966b5f60bda15512591e800285c
Gerrit-Change-Number: 56635
Gerrit-PatchSet: 2
Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Comment-Date: Sat, 14 Aug 2021 05:53:17 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Furquan Shaikh, Tim Wawrzynczak, Karthik Ramasubramanian.
Sumeet R Pawnikar has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56915 )
Change subject: mb/google/brya: set PL4 value dynamically for thermal
......................................................................
Patch Set 4:
(1 comment)
Patchset:
PS3:
> Conflicts with master
It was conflict with this CL https://review.coreboot.org/c/coreboot/+/56916 which got merged.
I have uploaded patch set 4 and fixed this conflict.
--
To view, visit https://review.coreboot.org/c/coreboot/+/56915
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I20b98ccd8493ed238de647cda8ceb25f62029133
Gerrit-Change-Number: 56915
Gerrit-PatchSet: 4
Gerrit-Owner: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com>
Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com>
Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Furquan Shaikh <furquan(a)google.com>
Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Comment-Date: Sat, 14 Aug 2021 03:05:46 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-MessageType: comment
Attention is currently required from: Furquan Shaikh, Sumeet R Pawnikar, Karthik Ramasubramanian.
Hello build bot (Jenkins), Furquan Shaikh, Tim Wawrzynczak, Karthik Ramasubramanian,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/56915
to look at the new patch set (#4).
Change subject: mb/google/brya: set PL4 value dynamically for thermal
......................................................................
mb/google/brya: set PL4 value dynamically for thermal
Set PL4 value dynamically for brya board based on CPU SKUs
which is detectable at runtime.
BUG=b:194745919
BRANCH=None
TEST=Build FW and test on brya0 with below messages,
On brya (282):
Overriding DPTF power limits PL1 (3000, 15000) PL2 (39000, 39000) PL4 (100000)
On brya (482):
Overriding DPTF power limits PL1 (4000, 28000) PL2 (43000, 43000) PL4 (105000)
Change-Id: I20b98ccd8493ed238de647cda8ceb25f62029133
Signed-off-by: Sumeet Pawnikar <sumeet.r.pawnikar(a)intel.com>
---
M src/mainboard/google/brya/variants/baseboard/brya/ramstage.c
M src/mainboard/google/brya/variants/baseboard/include/baseboard/variants.h
2 files changed, 8 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/15/56915/4
--
To view, visit https://review.coreboot.org/c/coreboot/+/56915
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I20b98ccd8493ed238de647cda8ceb25f62029133
Gerrit-Change-Number: 56915
Gerrit-PatchSet: 4
Gerrit-Owner: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com>
Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com>
Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Furquan Shaikh <furquan(a)google.com>
Gerrit-Attention: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com>
Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-MessageType: newpatchset
Attention is currently required from: Jeremy Soller.
Hello build bot (Jenkins), Jeremy Soller,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/52349
to look at the new patch set (#10).
Change subject: mb/system76/darp7: Add System76 Darter Pro 7
......................................................................
mb/system76/darp7: Add System76 Darter Pro 7
https://tech-docs.system76.com/models/darp7/README.html
Tested with TianoCore (UefiPayloadPkg).
Working:
- PS/2 keyboard, touchpad
- Both DIMM slots
- M.2 NVMe SSD
- M.2 SATA SSD
- All USB ports
- USB-PD
- Webcam
- Ethernet
- WiFi/Bluetooth
- Integrated graphics using Intel GOP driver
- HDMI output
- DP over USB-C output
- Internal microphone
- Internal speakers
- Combined headphone + mic 3.5mm jack
- Booting to Ubuntu Linux 21.04 and Windows 10
Not working:
- S0ix (no PC10 residency)
- Flashing with flashrom (chipset not supported)
Not tested:
- Thunderbolt functionality
Change-Id: I80e5c5375f9d3881fc89a45a91ba68ed2e104a93
Signed-off-by: Jeremy Soller <jeremy(a)system76.com>
Signed-off-by: Tim Crawford <tcrawford(a)system76.com>
---
M Documentation/mainboard/index.md
A Documentation/mainboard/system76/darp7.md
A src/mainboard/system76/darp7/Kconfig
A src/mainboard/system76/darp7/Kconfig.name
A src/mainboard/system76/darp7/Makefile.inc
A src/mainboard/system76/darp7/acpi/mainboard.asl
A src/mainboard/system76/darp7/acpi/sleep.asl
A src/mainboard/system76/darp7/board_info.txt
A src/mainboard/system76/darp7/bootblock.c
A src/mainboard/system76/darp7/cmos.default
A src/mainboard/system76/darp7/cmos.layout
A src/mainboard/system76/darp7/data.vbt
A src/mainboard/system76/darp7/devicetree.cb
A src/mainboard/system76/darp7/dsdt.asl
A src/mainboard/system76/darp7/gpio.h
A src/mainboard/system76/darp7/hda_verb.c
A src/mainboard/system76/darp7/ramstage.c
A src/mainboard/system76/darp7/romstage.c
18 files changed, 926 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/49/52349/10
--
To view, visit https://review.coreboot.org/c/coreboot/+/52349
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I80e5c5375f9d3881fc89a45a91ba68ed2e104a93
Gerrit-Change-Number: 52349
Gerrit-PatchSet: 10
Gerrit-Owner: Tim Crawford <tcrawford(a)system76.com>
Gerrit-Reviewer: Jeremy Soller <jeremy(a)system76.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Jeremy Soller <jeremy(a)system76.com>
Gerrit-MessageType: newpatchset