Attention is currently required from: Caveh Jalali, Sumeet R Pawnikar, Boris Mittelberg.
EricR Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/54724 )
Change subject: mb/google/brya: Add two sensors for DPTF functionality
......................................................................
Patch Set 2:
(1 comment)
Patchset:
PS2:
Have you check kernel and EC log, there are no errors about those sensor?
--
To view, visit https://review.coreboot.org/c/coreboot/+/54724
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Idc9bd6040c9bb316ec7e314f5e9c937c75cfc95a
Gerrit-Change-Number: 54724
Gerrit-PatchSet: 2
Gerrit-Owner: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com>
Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org>
Gerrit-Reviewer: Boris Mittelberg <bmbm(a)google.com>
Gerrit-Reviewer: Caveh Jalali <caveh(a)chromium.org>
Gerrit-Reviewer: EricR Lai <ericr_lai(a)compal.corp-partner.google.com>
Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com>
Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Caveh Jalali <caveh(a)chromium.org>
Gerrit-Attention: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com>
Gerrit-Attention: Boris Mittelberg <bmbm(a)google.com>
Gerrit-Comment-Date: Fri, 20 Aug 2021 04:39:32 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Caveh Jalali, EricR Lai.
Sumeet R Pawnikar has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/54724 )
Change subject: mb/google/brya: Add two sensors for DPTF functionality
......................................................................
Patch Set 2:
(1 comment)
File src/mainboard/google/brya/variants/brya0/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/54724/comment/9394072a_90e7f724
PS2, Line 72: TEMP_SENSOR_0
> isn't this the same as CPU?
As per b:181271666 comment#20, there are total 4 on-board thermal sensors. This TEMP_SENSOR_0 is for Memory. Above line 71, CPU sensor is for SoC temperature reporting and thermal control.
--
To view, visit https://review.coreboot.org/c/coreboot/+/54724
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Idc9bd6040c9bb316ec7e314f5e9c937c75cfc95a
Gerrit-Change-Number: 54724
Gerrit-PatchSet: 2
Gerrit-Owner: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com>
Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org>
Gerrit-Reviewer: Caveh Jalali <caveh(a)chromium.org>
Gerrit-Reviewer: EricR Lai <ericr_lai(a)compal.corp-partner.google.com>
Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com>
Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Caveh Jalali <caveh(a)chromium.org>
Gerrit-Attention: EricR Lai <ericr_lai(a)compal.corp-partner.google.com>
Gerrit-Comment-Date: Fri, 20 Aug 2021 04:25:27 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Caveh Jalali <caveh(a)chromium.org>
Gerrit-MessageType: comment
Attention is currently required from: Ricardo Quesada.
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56987 )
Change subject: cbfstool: add buffer_get() to common.h
......................................................................
Patch Set 2:
(3 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/56987/comment/cf6a3326_95e5d91a
PS2, Line 7: buffer_get
buffer_end
https://review.coreboot.org/c/coreboot/+/56987/comment/d0472b8c_5862621a
PS2, Line 9: buffer_get
buffer_end
https://review.coreboot.org/c/coreboot/+/56987/comment/9e522b22_b72d51ae
PS2, Line 10: .
(exclusive).
to indicate that the end address is exclusive.
--
To view, visit https://review.coreboot.org/c/coreboot/+/56987
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I380eecbc89c13f5fe5ab4c31d7a4fef97690a791
Gerrit-Change-Number: 56987
Gerrit-PatchSet: 2
Gerrit-Owner: Ricardo Quesada <ricardoq(a)google.com>
Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com>
Gerrit-Reviewer: Jack Rosenthal <jrosenth(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Ricardo Quesada <ricardoq(a)google.com>
Gerrit-Comment-Date: Fri, 20 Aug 2021 04:23:54 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Ricardo Quesada, Paul Menzel.
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56986 )
Change subject: elog: Define constant for RW region name
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/56986
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie8d31204e65fd67d52b0f8ced7b8c1ffdcf5b539
Gerrit-Change-Number: 56986
Gerrit-PatchSet: 2
Gerrit-Owner: Ricardo Quesada <ricardoq(a)google.com>
Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com>
Gerrit-Reviewer: Jack Rosenthal <jrosenth(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Ricardo Quesada <ricardoq(a)google.com>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Comment-Date: Fri, 20 Aug 2021 04:10:35 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Paul Menzel, Karthik Ramasubramanian.
Stanley Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56858 )
Change subject: mb/google/dedede: add gooey variant
......................................................................
Patch Set 11:
(1 comment)
Patchset:
PS11:
Already remove the I2C tuning information from this CL and add back after tuning on the hardware.
--
To view, visit https://review.coreboot.org/c/coreboot/+/56858
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I2a54f872a7d5c0bee76a9e6e309613d9357b380b
Gerrit-Change-Number: 56858
Gerrit-PatchSet: 11
Gerrit-Owner: Stanley Wu <stanley1.wu(a)lcfc.corp-partner.google.com>
Gerrit-Reviewer: Aseda Aboagye <aaboagye(a)google.com>
Gerrit-Reviewer: Henry Sun <henrysun(a)google.com>
Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Jerry2 Huang <jerry2.huang(a)lcfc.corp-partner.google.com>
Gerrit-CC: Joey Peng <joey.peng(a)lcfc.corp-partner.google.com>
Gerrit-CC: Kevin Chang <kevin.chang(a)lcfc.corp-partner.google.com>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-CC: Sunshine Chao <sunshine.chao(a)lcfc.corp-partner.google.com>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Comment-Date: Fri, 20 Aug 2021 03:42:10 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Hung-Te Lin, Chun-Jie Chen, Rex-BC Chen.
Hello Hung-Te Lin, build bot (Jenkins), Chun-Jie Chen, Yu-Ping Wu,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/57043
to look at the new patch set (#2).
Change subject: soc/mediatek/mt8195: Update clock square setting
......................................................................
soc/mediatek/mt8195: Update clock square setting
To reduce suspend power consumption,
1. Disable unused CLKSQ2.
2. Set CLKSQ_EN to sleep control for SPM 26M sleep control.
No bus clock when enter 26m sleep control, and only control
clock square by side band.
Signed-off-by: Chun-Jie Chen <chun-jie.chen(a)mediatek.com>
Change-Id: Ia9a1735d6f508ce35b9af2d67831a3474255198b
---
M src/soc/mediatek/mt8195/pll.c
1 file changed, 8 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/43/57043/2
--
To view, visit https://review.coreboot.org/c/coreboot/+/57043
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia9a1735d6f508ce35b9af2d67831a3474255198b
Gerrit-Change-Number: 57043
Gerrit-PatchSet: 2
Gerrit-Owner: Rex-BC Chen <rex-bc.chen(a)mediatek.corp-partner.google.com>
Gerrit-Reviewer: Chun-Jie Chen <chun-jie.chen(a)mediatek.corp-partner.google.com>
Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Attention: Chun-Jie Chen <chun-jie.chen(a)mediatek.corp-partner.google.com>
Gerrit-Attention: Rex-BC Chen <rex-bc.chen(a)mediatek.corp-partner.google.com>
Gerrit-MessageType: newpatchset