Attention is currently required from: Nico Huber, Tim Wawrzynczak, Angel Pons, Felix Held.
Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/57046 )
Change subject: [RFC] PCI: Introduce `enable_mmconf()` function
......................................................................
Patch Set 1:
(1 comment)
File src/lib/bootblock.c:
https://review.coreboot.org/c/coreboot/+/57046/comment/318bbcaa_ff87dc30
PS1, Line 45: if (CONFIG(MMCONF_SUPPORT))
: enable_mmconf();
> I think this is pretty reasonable; bootblock_soc_early_init() is a common place to initialize MMCONF […]
For AMD, the configuration registers is per-core MSR so the call cannot be removed from the non-BSP execution path.
--
To view, visit https://review.coreboot.org/c/coreboot/+/57046
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3f573f1c0d9a4cc3c25fe907d12778cd5d93241d
Gerrit-Change-Number: 57046
Gerrit-PatchSet: 1
Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Nico Huber <nico.h(a)gmx.de>
Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Comment-Date: Mon, 23 Aug 2021 08:20:10 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-MessageType: comment
Attention is currently required from: Malik Hsu, Paul Menzel.
Casper Chang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/57038 )
Change subject: mb/google/brya/primus: modify HID to MX98357 to enable audio function
......................................................................
Patch Set 5:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/57038/comment/3562590f_8add0d5e
PS3, Line 10: to MX98360A until the kernel SoF driver has support.
> 1. Please summarize the problem as requested. […]
Ack
--
To view, visit https://review.coreboot.org/c/coreboot/+/57038
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I893d9a31dc2c7726599c150be01b9585fb6c8a47
Gerrit-Change-Number: 57038
Gerrit-PatchSet: 5
Gerrit-Owner: Casper Chang <casper_chang(a)wistron.corp-partner.google.com>
Gerrit-Reviewer: Malik Hsu <malik_hsu(a)wistron.corp-partner.google.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Malik Hsu <malik_hsu(a)wistron.corp-partner.google.com>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Comment-Date: Mon, 23 Aug 2021 08:09:20 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org>
Comment-In-Reply-To: Casper Chang <casper_chang(a)wistron.corp-partner.google.com>
Gerrit-MessageType: comment
Attention is currently required from: Malik Hsu.
Hello build bot (Jenkins), Malik Hsu, Tim Wawrzynczak,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/57038
to look at the new patch set (#5).
Change subject: mb/google/brya/primus: modify HID to MX98357 to enable audio function
......................................................................
mb/google/brya/primus: modify HID to MX98357 to enable audio function
As discussed in b:194749863, Primus will use MX98357 as HID to enable
audio function till next stage that HW will implement BT offload
function. HID will be reverted to MX98360A until the kernel
SoF driver (crrev/c/3070268) has supported with new HW design.
BUG=b:194749863
BRANCH=none
TEST=build coreboot and audio function works
Signed-off-by: Casper Chang <casper_chang(a)wistron.corp-partner.google.com>
Change-Id: I893d9a31dc2c7726599c150be01b9585fb6c8a47
---
M src/mainboard/google/brya/variants/primus/overridetree.cb
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/38/57038/5
--
To view, visit https://review.coreboot.org/c/coreboot/+/57038
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I893d9a31dc2c7726599c150be01b9585fb6c8a47
Gerrit-Change-Number: 57038
Gerrit-PatchSet: 5
Gerrit-Owner: Casper Chang <casper_chang(a)wistron.corp-partner.google.com>
Gerrit-Reviewer: Malik Hsu <malik_hsu(a)wistron.corp-partner.google.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Malik Hsu <malik_hsu(a)wistron.corp-partner.google.com>
Gerrit-MessageType: newpatchset
Attention is currently required from: Malik Hsu, Casper Chang.
Hello build bot (Jenkins), Malik Hsu, Tim Wawrzynczak,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/57038
to look at the new patch set (#4).
Change subject: mb/google/brya/primus: modify HID to MX98357 to enable audio function
......................................................................
mb/google/brya/primus: modify HID to MX98357 to enable audio function
As discussed in b:194749863, Primus will use MX98357 as HID to enable
audio function till next stage that HW will implement BT offload
function. this value will be reverted to MX98360A until the kernel
SoF driver (crrev/c/3070268) has supported with new HW design.
BUG=b:194749863
BRANCH=none
TEST=build coreboot and audio function works
Signed-off-by: Casper Chang <casper_chang(a)wistron.corp-partner.google.com>
Change-Id: I893d9a31dc2c7726599c150be01b9585fb6c8a47
---
M src/mainboard/google/brya/variants/primus/overridetree.cb
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/38/57038/4
--
To view, visit https://review.coreboot.org/c/coreboot/+/57038
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I893d9a31dc2c7726599c150be01b9585fb6c8a47
Gerrit-Change-Number: 57038
Gerrit-PatchSet: 4
Gerrit-Owner: Casper Chang <casper_chang(a)wistron.corp-partner.google.com>
Gerrit-Reviewer: Malik Hsu <malik_hsu(a)wistron.corp-partner.google.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Malik Hsu <malik_hsu(a)wistron.corp-partner.google.com>
Gerrit-Attention: Casper Chang <casper_chang(a)wistron.corp-partner.google.com>
Gerrit-MessageType: newpatchset
Attention is currently required from: Malik Hsu, Casper Chang.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/57038 )
Change subject: mb/google/brya/primus: modify HID to MX98357 to enable audio function
......................................................................
Patch Set 3:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/57038/comment/8ef6dde0_7d8a21f6
PS3, Line 10: to MX98360A until the kernel SoF driver has support.
> Ack
1. Please summarize the problem as requested.
2. > as the Linux kernel patch is under discussion, we might not be able to provide.
Where is it under discussion?
--
To view, visit https://review.coreboot.org/c/coreboot/+/57038
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I893d9a31dc2c7726599c150be01b9585fb6c8a47
Gerrit-Change-Number: 57038
Gerrit-PatchSet: 3
Gerrit-Owner: Casper Chang <casper_chang(a)wistron.corp-partner.google.com>
Gerrit-Reviewer: Malik Hsu <malik_hsu(a)wistron.corp-partner.google.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Malik Hsu <malik_hsu(a)wistron.corp-partner.google.com>
Gerrit-Attention: Casper Chang <casper_chang(a)wistron.corp-partner.google.com>
Gerrit-Comment-Date: Mon, 23 Aug 2021 07:47:38 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org>
Comment-In-Reply-To: Casper Chang <casper_chang(a)wistron.corp-partner.google.com>
Gerrit-MessageType: comment
Attention is currently required from: Paul Menzel, Weimin Wu, Karthik Ramasubramanian.
Hello build bot (Jenkins), Henry Sun, Paul Menzel, Weimin Wu, Karthik Ramasubramanian,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/56804
to look at the new patch set (#15).
Change subject: mb/google/dedede/var/sasukette: Add FW_CONFIG probe for EXT_VR
......................................................................
mb/google/dedede/var/sasukette: Add FW_CONFIG probe for EXT_VR
commit df520855 (soc/intel/jsl: Add disable_external_bypass_vr config)
Add FW_CONFIG probe for don't stuffing ANPEC APW8738BQBI IC.
BUG=b:190727416
BRANCH=dedede
TEST=test for enter S0ix and resume normally by powerd_dbus_suspend
Signed-off-by: Zhi Li <lizhi7(a)huaqin.corp-partner.google.com>
Change-Id: I15ab30f14df9dc02157009091aa8398e2fa75188
---
M src/mainboard/google/dedede/variants/baseboard/devicetree.cb
M src/mainboard/google/dedede/variants/sasukette/ramstage.c
2 files changed, 14 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/04/56804/15
--
To view, visit https://review.coreboot.org/c/coreboot/+/56804
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I15ab30f14df9dc02157009091aa8398e2fa75188
Gerrit-Change-Number: 56804
Gerrit-PatchSet: 15
Gerrit-Owner: Zhi7 Li <lizhi7(a)huaqin.corp-partner.google.com>
Gerrit-Reviewer: Henry Sun <henrysun(a)google.com>
Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Reviewer: Weimin Wu <wuweimin(a)huaqin.corp-partner.google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Echo Huang <huangrui(a)huaqin.corp-partner.google.com>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Weimin Wu <wuweimin(a)huaqin.corp-partner.google.com>
Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-MessageType: newpatchset
Dtrain Hsu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56871 )
Change subject: mb/google/dedede/var/cret: Add new G2Touch touchscreen
......................................................................
Patch Set 3:
This change is ready for review.
--
To view, visit https://review.coreboot.org/c/coreboot/+/56871
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I57638bf8a3eb4efcd819f5433fa54c22b7af3054
Gerrit-Change-Number: 56871
Gerrit-PatchSet: 3
Gerrit-Owner: Dtrain Hsu <dtrain_hsu(a)compal.corp-partner.google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Comment-Date: Mon, 23 Aug 2021 07:40:13 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Henry Sun, Aseda Aboagye, Shou-Chieh Hsu, Karthik Ramasubramanian, EricR Lai.
Frank Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56996 )
Change subject: mb/google/dedede/var/driblee: Configure GPIO settings
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
Hi Google,
Would you help to review the CLs of the firmware modification for Driblee?
Thank you.
--
To view, visit https://review.coreboot.org/c/coreboot/+/56996
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I20baeb6b13c8c0a70c7555aa8f7f5557768c0083
Gerrit-Change-Number: 56996
Gerrit-PatchSet: 1
Gerrit-Owner: Frank Wu <frank_wu(a)compal.corp-partner.google.com>
Gerrit-Reviewer: Aseda Aboagye <aaboagye(a)google.com>
Gerrit-Reviewer: EricR Lai <ericr_lai(a)compal.corp-partner.google.com>
Gerrit-Reviewer: Henry Sun <henrysun(a)google.com>
Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Reviewer: Shou-Chieh Hsu <shouchieh(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Alan Lee <alan_lee(a)compal.corp-partner.google.com>
Gerrit-CC: Dtrain Hsu <dtrain_hsu(a)compal.corp-partner.google.com>
Gerrit-CC: Ian Feng <ian_feng(a)compal.corp-partner.google.com>
Gerrit-CC: John Su <john_su(a)compal.corp-partner.google.com>
Gerrit-Attention: Henry Sun <henrysun(a)google.com>
Gerrit-Attention: Aseda Aboagye <aaboagye(a)google.com>
Gerrit-Attention: Shou-Chieh Hsu <shouchieh(a)google.com>
Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Attention: EricR Lai <ericr_lai(a)compal.corp-partner.google.com>
Gerrit-Comment-Date: Mon, 23 Aug 2021 07:35:52 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Malik Hsu, Paul Menzel.
Casper Chang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/57038 )
Change subject: mb/google/brya/primus: modify HID to MX98357 to enable audio function
......................................................................
Patch Set 3:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/57038/comment/19497e0f_f3ee4ace
PS3, Line 10: to MX98360A until the kernel SoF driver has support.
> as the Linux kernel patch is under discussion, we might not be able to provide.
Ack
--
To view, visit https://review.coreboot.org/c/coreboot/+/57038
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I893d9a31dc2c7726599c150be01b9585fb6c8a47
Gerrit-Change-Number: 57038
Gerrit-PatchSet: 3
Gerrit-Owner: Casper Chang <casper_chang(a)wistron.corp-partner.google.com>
Gerrit-Reviewer: Malik Hsu <malik_hsu(a)wistron.corp-partner.google.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Malik Hsu <malik_hsu(a)wistron.corp-partner.google.com>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Comment-Date: Mon, 23 Aug 2021 07:28:44 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org>
Comment-In-Reply-To: Casper Chang <casper_chang(a)wistron.corp-partner.google.com>
Gerrit-MessageType: comment
Attention is currently required from: V Sowmya, Tim Wawrzynczak, Balaji Manigandan.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/54646 )
Change subject: mb/google/brya: Enable SaGv support
......................................................................
Patch Set 2:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/54646/comment/60c725f9_306d66fb
PS2, Line 7: mb/google/brya: Enable SaGv support
Mention brya0 somewhere?
--
To view, visit https://review.coreboot.org/c/coreboot/+/54646
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I2a71e159fa49f677660af8279f2b582a3916eee2
Gerrit-Change-Number: 54646
Gerrit-PatchSet: 2
Gerrit-Owner: V Sowmya <v.sowmya(a)intel.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: V Sowmya <v.sowmya(a)intel.com>
Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Attention: Balaji Manigandan <balaji.manigandan(a)intel.com>
Gerrit-Comment-Date: Mon, 23 Aug 2021 07:23:02 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment