Attention is currently required from: Sunwei Li, Henry Sun, Paul Menzel, Bob Moragues.
Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56687 )
Change subject: mb/google/dedede/var/cappy2: Disable external bypass VR
......................................................................
Patch Set 4: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/56687
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ieb4182a989459db629e3b69757c293ca26e8b0cd
Gerrit-Change-Number: 56687
Gerrit-PatchSet: 4
Gerrit-Owner: Sunwei Li <lisunwei(a)huaqin.corp-partner.google.com>
Gerrit-Reviewer: Aseda Aboagye <aaboagye(a)google.com>
Gerrit-Reviewer: Bob Moragues <moragues(a)google.com>
Gerrit-Reviewer: Henry Sun <henrysun(a)google.com>
Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Reviewer: Weimin Wu <wuweimin(a)huaqin.corp-partner.google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-CC: Tao Xia <xiatao5(a)huaqin.corp-partner.google.com>
Gerrit-Attention: Sunwei Li <lisunwei(a)huaqin.corp-partner.google.com>
Gerrit-Attention: Henry Sun <henrysun(a)google.com>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Bob Moragues <moragues(a)google.com>
Gerrit-Comment-Date: Sat, 31 Jul 2021 20:55:50 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Varshit B Pandya, Tim Wawrzynczak, Paul Menzel.
EricR Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56621 )
Change subject: mb/google/brya: Update entries for UFC to support IMX208
......................................................................
Patch Set 10: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/56621
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I6a3bf13ec844fb46e11ce58382057fcc7187c135
Gerrit-Change-Number: 56621
Gerrit-PatchSet: 10
Gerrit-Owner: Varshit B Pandya <varshit.b.pandya(a)intel.com>
Gerrit-Reviewer: EricR Lai <ericr_lai(a)compal.corp-partner.google.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Maulik V Vaghela <maulik.v.vaghela(a)intel.com>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Varshit B Pandya <varshit.b.pandya(a)intel.com>
Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Comment-Date: Sat, 31 Jul 2021 16:22:31 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Furquan Shaikh, Tim Wawrzynczak.
Scott Chao has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56710 )
Change subject: ec/google/chromeec: Add code for KEY_MICMUTE and KEY_KBDILLUMTOGGLE
......................................................................
Patch Set 4:
(1 comment)
File src/ec/google/chromeec/ec_commands.h:
https://review.coreboot.org/c/coreboot/+/56710/comment/739c06b9_2db2eade
PS1, Line 6334: TK_KBDILLUMTOGGLE = 18,
: TK_MICMUTE = 19,
> The enum values here and in the EC CL do not match.
Done. chromeec/ec_commands.h and platform/ec/include/ec_commands.h are aligned now.
--
To view, visit https://review.coreboot.org/c/coreboot/+/56710
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie4fa3e627f448265f72279704d258b2d3fe8fc17
Gerrit-Change-Number: 56710
Gerrit-PatchSet: 4
Gerrit-Owner: Scott Chao <scott_chao(a)wistron.corp-partner.google.com>
Gerrit-Reviewer: Rajat Jain <rajatja(a)google.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Furquan Shaikh <furquan(a)google.com>
Gerrit-Attention: Furquan Shaikh <furquan(a)google.com>
Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Comment-Date: Sat, 31 Jul 2021 13:05:21 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Furquan Shaikh <furquan(a)google.com>
Gerrit-MessageType: comment
Attention is currently required from: Tim Wawrzynczak, Scott Chao.
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56710 )
Change subject: ec/google/chromeec: Add code for KEY_MICMUTE and KEY_KBDILLUMTOGGLE
......................................................................
Patch Set 1:
(1 comment)
File src/ec/google/chromeec/ec_commands.h:
https://review.coreboot.org/c/coreboot/+/56710/comment/1cd423c1_575b2d3f
PS1, Line 6334: TK_KBDILLUMTOGGLE = 18,
: TK_MICMUTE = 19,
The enum values here and in the EC CL do not match.
--
To view, visit https://review.coreboot.org/c/coreboot/+/56710
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie4fa3e627f448265f72279704d258b2d3fe8fc17
Gerrit-Change-Number: 56710
Gerrit-PatchSet: 1
Gerrit-Owner: Scott Chao <scott_chao(a)wistron.corp-partner.google.com>
Gerrit-Reviewer: Rajat Jain <rajatja(a)google.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Furquan Shaikh <furquan(a)google.com>
Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Attention: Scott Chao <scott_chao(a)wistron.corp-partner.google.com>
Gerrit-Comment-Date: Sat, 31 Jul 2021 12:21:24 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Martin Roth, Arthur Heymans.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56593 )
Change subject: util/lint/lint-stable: Add forbidden Kconfig check
......................................................................
Patch Set 2:
(1 comment)
File util/lint/lint-stable-028-forbidden-config-c:
https://review.coreboot.org/c/coreboot/+/56593/comment/4c665238_346db01a
PS2, Line 23: -I %
> We should probably use both methods, similar to what's done in the whitespace linter. […]
I was refering to the `-I` specifically. Generally, there is nothing
wrong with using xargs. It's a good idea to do so. xargs is only slow
if it creates too many subprocesses, but it tries to minimize that by
default.
The problem that CB:28429 tries to avoid is when we use the stdout of
one program directly as command line for another. This can always
overflow, I'd even expect it to on Linux at some point. We should use
xargs instead whenever possible.
When it comes to grepping in the repository, we often don't have to
use multiple programs, though (see above example).
--
To view, visit https://review.coreboot.org/c/coreboot/+/56593
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I38c6062f62d28b4d54746bc6179643e675004093
Gerrit-Change-Number: 56593
Gerrit-PatchSet: 2
Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Nico Huber <nico.h(a)gmx.de>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Martin Roth <martinroth(a)google.com>
Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Comment-Date: Sat, 31 Jul 2021 11:36:46 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de>
Comment-In-Reply-To: Martin Roth <martinroth(a)google.com>
Gerrit-MessageType: comment
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/56689 )
Change subject: mb/google/dedede/var/boten: Set the xHCI LFPS period sampling off time to 0ms
......................................................................
mb/google/dedede/var/boten: Set the xHCI LFPS period sampling off time to 0ms
LTE module L850-GL may encounter U3 wakeup race condition with the host.
Setting xHCI LFPS periodic sampling off time to 0ms so that the host would not
miss the device-initiated U3 wakeup thus avoid the race condition.
BUG=b:187801363
BRANCH=dedede
TEST=flash the image to the device. Run following command to check the bits[7:4] is 0x0:
iotools mmio_read32 "XHCI MMIO BAR + 0x80A4"
Signed-off-by: stanley.wu <stanley1.wu(a)lcfc.corp-partner.google.com>
Change-Id: I9328e758ed92389e44b25ff4daf6ec19b37ae7d6
Reviewed-on: https://review.coreboot.org/c/coreboot/+/56689
Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org>
Reviewed-by: Karthik Ramasubramanian <kramasub(a)google.com>
Reviewed-by: Ben Kao <ben.kao(a)intel.corp-partner.google.com>
---
M src/mainboard/google/dedede/variants/boten/overridetree.cb
1 file changed, 3 insertions(+), 0 deletions(-)
Approvals:
build bot (Jenkins): Verified
Karthik Ramasubramanian: Looks good to me, approved
Ben Kao: Looks good to me, but someone else must approve
diff --git a/src/mainboard/google/dedede/variants/boten/overridetree.cb b/src/mainboard/google/dedede/variants/boten/overridetree.cb
index 8c68f7e..d310f91 100644
--- a/src/mainboard/google/dedede/variants/boten/overridetree.cb
+++ b/src/mainboard/google/dedede/variants/boten/overridetree.cb
@@ -80,6 +80,9 @@
register "SlowSlewRate" = "SlewRateFastBy8"
register "FastPkgCRampDisable" = "1"
+ # Set xHCI LFPS period sampling off time to 0 ms
+ register "xhci_lfps_sampling_offtime_ms" = "0"
+
device domain 0 on
device pci 04.0 on
chip drivers/intel/dptf
--
To view, visit https://review.coreboot.org/c/coreboot/+/56689
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I9328e758ed92389e44b25ff4daf6ec19b37ae7d6
Gerrit-Change-Number: 56689
Gerrit-PatchSet: 2
Gerrit-Owner: Stanley Wu <stanley1.wu(a)lcfc.corp-partner.google.com>
Gerrit-Reviewer: Ben Kao <ben.kao(a)intel.corp-partner.google.com>
Gerrit-Reviewer: Henry Sun <henrysun(a)google.com>
Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com>
Gerrit-Reviewer: Paul Fagerburg <pfagerburg(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Melo Chuang <melo.chuang(a)lcfc.corp-partner.google.com>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-CC: Rasheed Hsueh <rasheed.hsueh(a)lcfc.corp-partner.google.com>
Gerrit-CC: Sunshine Chao <sunshine.chao(a)lcfc.corp-partner.google.com>
Gerrit-MessageType: merged
Attention is currently required from: Tim Wawrzynczak, Paul Menzel.
Varshit B Pandya has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56621 )
Change subject: mb/google/brya: Update entries for UFC to support IMX208
......................................................................
Patch Set 10:
(2 comments)
File src/mainboard/google/brya/variants/brya0/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/56621/comment/2ab35211_27505f31
PS9, Line 437: 360
> Update the comment?
Done
https://review.coreboot.org/c/coreboot/+/56621/comment/091f55f6_34cff1b4
PS9, Line 438: 180 MHz
> Update the comment?
Done
--
To view, visit https://review.coreboot.org/c/coreboot/+/56621
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I6a3bf13ec844fb46e11ce58382057fcc7187c135
Gerrit-Change-Number: 56621
Gerrit-PatchSet: 10
Gerrit-Owner: Varshit B Pandya <varshit.b.pandya(a)intel.com>
Gerrit-Reviewer: EricR Lai <ericr_lai(a)compal.corp-partner.google.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Maulik V Vaghela <maulik.v.vaghela(a)intel.com>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Comment-Date: Sat, 31 Jul 2021 07:16:27 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-MessageType: comment
Attention is currently required from: Varshit B Pandya, Paul Menzel.
Hello build bot (Jenkins), Tim Wawrzynczak, EricR Lai,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/56621
to look at the new patch set (#10).
Change subject: mb/google/brya: Update entries for UFC to support IMX208
......................................................................
mb/google/brya: Update entries for UFC to support IMX208
1. Replace OV5675 ACPI entries with IMX208
2. Replace FW_CONFIG name
3. Add support for NVM inside UFC
BUG=b:190674542
TEST=Build and boot to OS on Brya, raw capture on UFC
Signed-off-by: Varshit B Pandya <varshit.b.pandya(a)intel.com>
Change-Id: I6a3bf13ec844fb46e11ce58382057fcc7187c135
---
M src/mainboard/google/brya/variants/brya0/overridetree.cb
1 file changed, 30 insertions(+), 15 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/21/56621/10
--
To view, visit https://review.coreboot.org/c/coreboot/+/56621
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I6a3bf13ec844fb46e11ce58382057fcc7187c135
Gerrit-Change-Number: 56621
Gerrit-PatchSet: 10
Gerrit-Owner: Varshit B Pandya <varshit.b.pandya(a)intel.com>
Gerrit-Reviewer: EricR Lai <ericr_lai(a)compal.corp-partner.google.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Maulik V Vaghela <maulik.v.vaghela(a)intel.com>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Varshit B Pandya <varshit.b.pandya(a)intel.com>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-MessageType: newpatchset