coreboot-gerrit July 2021

coreboot-gerrit@coreboot.org

1 participants
5824 discussions

Change in coreboot[master]: lib/future: Implement Futures API
by Martin Roth (Code Review) 07 Jul '21

07 Jul '21

Attention is currently required from: Raul Rangel, Aaron Durbin, Furquan Shaikh, Marshall Dawson, Julius Werner, Eric Peers. Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56048 ) Change subject: lib/future: Implement Futures API ...................................................................... Patch Set 4: (1 comment) File src/lib/future.c: https://review.coreboot.org/c/coreboot/+/56048/comment/513fac40_994a6bea PS2, Line 68: state = futures[i]->poll(futures[i], false); > So I was tempted to add a bunch of debug style information in the the futures object. […] I'll leave it up to you - i think it might be useful to print something when a task actually gets executed, but not when it just checks to see if anything needs to happen. I'd be good with this happening later too, so we can actually decide whether or not it's needed. -- To view, visit https://review.coreboot.org/c/coreboot/+/56048 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I350aebcd07024a00b90495bf937f8bca5193d02f Gerrit-Change-Number: 56048 Gerrit-PatchSet: 4 Gerrit-Owner: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: Aaron Durbin <adurbin(a)gmail.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Eric Peers <epeers(a)google.com> Gerrit-CC: Martin Roth <martinroth(a)google.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org> Gerrit-Attention: Aaron Durbin <adurbin(a)gmail.com> Gerrit-Attention: Furquan Shaikh <furquan(a)google.com> Gerrit-Attention: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Attention: Eric Peers <epeers(a)google.com> Gerrit-Comment-Date: Wed, 07 Jul 2021 18:11:58 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Raul Rangel <rrangel(a)chromium.org> Comment-In-Reply-To: Martin Roth <martinroth(a)google.com> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: commonlib/region: Add support for asynchronous readat
by build bot (Jenkins) (Code Review) 07 Jul '21

07 Jul '21

Attention is currently required from: Raul Rangel, Furquan Shaikh, Marshall Dawson, Julius Werner, Angel Pons. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/55856 ) Change subject: commonlib/region: Add support for asynchronous readat ...................................................................... Patch Set 6: (6 comments) File src/commonlib/include/commonlib/region.h: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-123584): https://review.coreboot.org/c/coreboot/+/55856/comment/4858bcde_c280d6e5 PS6, Line 98: cb_err_t (*readat_async)(const struct region_device *, function definition argument 'const struct region_device *' should also have an identifier name Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-123584): https://review.coreboot.org/c/coreboot/+/55856/comment/15480fb9_2b2f1ee7 PS6, Line 98: cb_err_t (*readat_async)(const struct region_device *, function definition argument 'struct rdev_readat_async_context *' should also have an identifier name Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-123584): https://review.coreboot.org/c/coreboot/+/55856/comment/ec67aef3_6d80363c PS6, Line 98: cb_err_t (*readat_async)(const struct region_device *, function definition argument 'void *' should also have an identifier name Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-123584): https://review.coreboot.org/c/coreboot/+/55856/comment/e256d8c2_d1296569 PS6, Line 98: cb_err_t (*readat_async)(const struct region_device *, function definition argument 'size_t' should also have an identifier name Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-123584): https://review.coreboot.org/c/coreboot/+/55856/comment/40380a99_af073cfc PS6, Line 98: cb_err_t (*readat_async)(const struct region_device *, function definition argument 'size_t' should also have an identifier name File src/commonlib/region.c: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-123584): https://review.coreboot.org/c/coreboot/+/55856/comment/8d46befb_fdbd576d PS6, Line 136: cb_err_t rdev_readat_async(const struct region_device *rd, struct rdev_readat_async_context *context, line over 96 characters -- To view, visit https://review.coreboot.org/c/coreboot/+/55856 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I9702c9e6abe992ea401fa08ba71e5080c3c29d9a Gerrit-Change-Number: 55856 Gerrit-PatchSet: 6 Gerrit-Owner: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org> Gerrit-Attention: Furquan Shaikh <furquan(a)google.com> Gerrit-Attention: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Comment-Date: Wed, 07 Jul 2021 18:08:08 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/volteer/var/voema: Remove stop delay time for ELAN TS
by Nick Vaccaro (Code Review) 07 Jul '21

07 Jul '21

Attention is currently required from: David Wu. Nick Vaccaro has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56087 ) Change subject: mb/google/volteer/var/voema: Remove stop delay time for ELAN TS ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/56087 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id326fd4d9d71eef171580b1c6001505e698b40a3 Gerrit-Change-Number: 56087 Gerrit-PatchSet: 2 Gerrit-Owner: David Wu <david_wu(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: YH Lin <yueherngl(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: David Wu <david_wu(a)quanta.corp-partner.google.com> Gerrit-Comment-Date: Wed, 07 Jul 2021 18:00:31 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: soc/amd/{common,cezanne}: Implement HAVE_PAYLOAD_PRELOAD_CACHE
by Raul Rangel (Code Review) 07 Jul '21

07 Jul '21

1 0

Change in coreboot[master]: WIP: soc/amd/common/block/lpc: Don't disable the HOG bit
by Raul Rangel (Code Review) 07 Jul '21

07 Jul '21

Attention is currently required from: Jason Glenesk, Raul Rangel, Marshall Dawson, Felix Held. Hello build bot (Jenkins), Jason Glenesk, Marshall Dawson, Felix Held, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/56052 to look at the new patch set (#5). Change subject: WIP: soc/amd/common/block/lpc: Don't disable the HOG bit ...................................................................... WIP: soc/amd/common/block/lpc: Don't disable the HOG bit This bit breaks SPI DMA. BUG=b:179699789 TEST=Boot guybrush and see SPI DMA working Signed-off-by: Raul E Rangel <rrangel(a)chromium.org> Change-Id: If015869657f36d3533f4ab9ebd1f54b0d4eb283b --- M src/soc/amd/common/block/lpc/lpc.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/52/56052/5 -- To view, visit https://review.coreboot.org/c/coreboot/+/56052 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: If015869657f36d3533f4ab9ebd1f54b0d4eb283b Gerrit-Change-Number: 56052 Gerrit-PatchSet: 5 Gerrit-Owner: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org> Gerrit-Attention: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: lib/prog_loaders: Add payload_preload
by Raul Rangel (Code Review) 07 Jul '21

07 Jul '21

Attention is currently required from: Raul Rangel. Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/56051 to look at the new patch set (#5). Change subject: lib/prog_loaders: Add payload_preload ...................................................................... lib/prog_loaders: Add payload_preload This method will allow the SoC code to start loading the payload before it is required. BUG=b:177909625 TEST=Boot guybrush and see read/decompress drop by 23 ms. Signed-off-by: Raul E Rangel <rrangel(a)chromium.org> Change-Id: Ifa8f30a0f4f931ece803c2e8e022e4d33d3fe581 --- M src/include/program_loading.h M src/include/symbols.h M src/lib/Kconfig M src/lib/prog_loaders.c 4 files changed, 63 insertions(+), 4 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/51/56051/5 -- To view, visit https://review.coreboot.org/c/coreboot/+/56051 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ifa8f30a0f4f931ece803c2e8e022e4d33d3fe581 Gerrit-Change-Number: 56051 Gerrit-PatchSet: 5 Gerrit-Owner: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: lib/hardwaremain: Call poll_futures
by Raul Rangel (Code Review) 07 Jul '21

07 Jul '21

Attention is currently required from: Raul Rangel. Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/56050 to look at the new patch set (#5). Change subject: lib/hardwaremain: Call poll_futures ...................................................................... lib/hardwaremain: Call poll_futures This CL makes the ramstage state machine poll the futures after each callback and during stage transitions. This will keep the futures progressing throughout the boot process. This is a no-op for platforms that don't set FUTURES_EXECUTOR. BUG=b:177909625 TEST=Boot guybrush and see payload read/decompress drop by 23 ms. Signed-off-by: Raul E Rangel <rrangel(a)chromium.org> Change-Id: I15e17ecb1094a4bfb7bf5cabe8c847b9e697ebf2 --- M src/lib/hardwaremain.c 1 file changed, 7 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/50/56050/5 -- To view, visit https://review.coreboot.org/c/coreboot/+/56050 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I15e17ecb1094a4bfb7bf5cabe8c847b9e697ebf2 Gerrit-Change-Number: 56050 Gerrit-PatchSet: 5 Gerrit-Owner: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: cbfs: Introduce and implement cbfs_load_async
by Raul Rangel (Code Review) 07 Jul '21

07 Jul '21

Attention is currently required from: Furquan Shaikh, Marshall Dawson, Julius Werner. Hello build bot (Jenkins), Furquan Shaikh, Marshall Dawson, Julius Werner, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/56049 to look at the new patch set (#5). Change subject: cbfs: Introduce and implement cbfs_load_async ...................................................................... cbfs: Introduce and implement cbfs_load_async This CL adds support for the Futures API to cbfs. This allows loading a file from CBFS asynchronously. It currently only supports uncompressed files. More APIs will be added as I start to load stages, oproms, etc asynchronously. BUG=b:179699789 TEST=Boot guybrush and see payload read/decompress drop by 23 ms. Signed-off-by: Raul E Rangel <rrangel(a)chromium.org> Change-Id: Idf4cee8a7094a9470aff997e4b06e823cb4811c0 --- M src/include/cbfs.h M src/lib/cbfs.c 2 files changed, 184 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/49/56049/5 -- To view, visit https://review.coreboot.org/c/coreboot/+/56049 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Idf4cee8a7094a9470aff997e4b06e823cb4811c0 Gerrit-Change-Number: 56049 Gerrit-PatchSet: 5 Gerrit-Owner: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Furquan Shaikh <furquan(a)google.com> Gerrit-Attention: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: soc/amd/cezanne: Start loading APOB asynchronously while FSP-M executes
by Raul Rangel (Code Review) 07 Jul '21

07 Jul '21

Attention is currently required from: Jason Glenesk, Marshall Dawson, Felix Held. Hello build bot (Jenkins), Jason Glenesk, Marshall Dawson, Felix Held, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/55859 to look at the new patch set (#7). Change subject: soc/amd/cezanne: Start loading APOB asynchronously while FSP-M executes ...................................................................... soc/amd/cezanne: Start loading APOB asynchronously while FSP-M executes In the S3 resume case we will block in `soc_fill_apob_cache` until the whole buffer has been read since the PSP has not placed the APOB contents into RAM. In the non-S3 case, the PSP has placed the APOB contents into RAM, so `soc_fill_apob_cache` uses that for FSP-M. By reading the SPI contents while FSP-M is executing, the data will be ready by the time `soc_update_apob_cache` executes. We currently get lucky that the APOB is only 64 KiB since the SPI DMA controller can perform this transaction in one shot. In order to support larger payloads, or multiple transactions while FSP-M executes, we will need FSP-M to call `poll_futures` periodically. BUG=b:179699789 TEST=Boot guybrush and verify APOB read timestamp has dropped from 10ms to a few uS. FMAP: area RW_MRC_CACHE found @ 0 (65536 bytes) spi_dma_readat_async: dest: 0x020935c0, offset: 0x0, size: 65536 spi_dma_async_poll: current_transaction: 0x020a3620 start_spi_dma_transaction: dest: 0x020935c0, offset: 0x0, remaining: 65536 <FSP-M executes> wait_for_promise: waiting for promise spi_dma_async_poll: current_transaction: 0x020a3620 continue_spi_dma_transaction: dest: 0x020935c0, offset: 0x0, remaining: 65536 spi_dma_async_poll: transaction complete spi_dma_async_poll: current_transaction: 0x00000000 wait_for_promise: took 12 us APOB valid copy is already in flash Signed-off-by: Raul E Rangel <rrangel(a)chromium.org> Change-Id: I4b5c1ef4cad571d1cbca33b1aff017a3cedc1be8 --- M src/soc/amd/cezanne/fsp_m_params.c 1 file changed, 14 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/59/55859/7 -- To view, visit https://review.coreboot.org/c/coreboot/+/55859 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I4b5c1ef4cad571d1cbca33b1aff017a3cedc1be8 Gerrit-Change-Number: 55859 Gerrit-PatchSet: 7 Gerrit-Owner: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Attention: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: soc/amd/common/apob: Add support for asynchronously reading APOB
by Raul Rangel (Code Review) 07 Jul '21

07 Jul '21

Attention is currently required from: Jason Glenesk, Marshall Dawson, Felix Held. Hello build bot (Jenkins), Jason Glenesk, Marshall Dawson, Felix Held, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/55858 to look at the new patch set (#7). Change subject: soc/amd/common/apob: Add support for asynchronously reading APOB ...................................................................... soc/amd/common/apob: Add support for asynchronously reading APOB This CL adds a method that can starts the processes of reading the APOB from SPI. It does take more RAM in romstage since we no longer mmap the buffer in the async happy path. This will allow us to reduce our boot time by 10ms. We don't register the future with the executor since it's not currently getting called in romstage, and the transfer completes in a single transaction. BUG=b:179699789 TEST=With this and the FSP patch above I can see a 10 ms reduction in boot time on guybrush. Signed-off-by: Raul E Rangel <rrangel(a)chromium.org> Change-Id: I930d58b76eb4558bc4f48ed928c4d6538fefbde7 --- M src/soc/amd/common/block/apob/apob_cache.c M src/soc/amd/common/block/include/amdblocks/apob_cache.h 2 files changed, 33 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/58/55858/7 -- To view, visit https://review.coreboot.org/c/coreboot/+/55858 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I930d58b76eb4558bc4f48ed928c4d6538fefbde7 Gerrit-Change-Number: 55858 Gerrit-PatchSet: 7 Gerrit-Owner: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Attention: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-MessageType: newpatchset

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit July 2021