coreboot-gerrit July 2021

coreboot-gerrit@coreboot.org

1 participants
5824 discussions

Change in coreboot[master]: mb/google/volteer/baseboard: Configure chipset_lockdown separately
by Felix Singer (Code Review) 14 Jul '21

14 Jul '21

Attention is currently required from: Tim Wawrzynczak, Angel Pons. Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56209 ) Change subject: mb/google/volteer/baseboard: Configure chipset_lockdown separately ...................................................................... Patch Set 3: (2 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/56209/comment/9103dd78_3bdc8043 PS2, Line 7: seperately > sep*a*rately Done https://review.coreboot.org/c/coreboot/+/56209/comment/39e18c1b_e3c6032d PS2, Line 12: seperetaly > separately Done -- To view, visit https://review.coreboot.org/c/coreboot/+/56209 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I595c042cf62680d61f60965710d382bfdcd81671 Gerrit-Change-Number: 56209 Gerrit-PatchSet: 3 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Furquan Shaikh <furquan(a)google.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Comment-Date: Tue, 13 Jul 2021 21:05:24 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/volteer: Deduplicate lockdown config
by Felix Singer (Code Review) 14 Jul '21

14 Jul '21

Attention is currently required from: Michael Niewöhner. Hello build bot (Jenkins), Tim Wawrzynczak, Michael Niewöhner, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/56199 to look at the new patch set (#8). Change subject: mb/google/volteer: Deduplicate lockdown config ...................................................................... mb/google/volteer: Deduplicate lockdown config The setting `chipset_lockdown` has the same configuration for all variants and they also match with the baseboard configuration. Thus, remove it from the variant overridetrees. Built google/delbin with `BUILD_TIMELESS=1` and coreboot.rom remains the same. Change-Id: I597e4487e7a0e1848d2a2f2c8f8ebd552994aac2 Signed-off-by: Felix Singer <felixsinger(a)posteo.net> --- M src/mainboard/google/volteer/variants/chronicler/overridetree.cb M src/mainboard/google/volteer/variants/collis/overridetree.cb M src/mainboard/google/volteer/variants/copano/overridetree.cb M src/mainboard/google/volteer/variants/delbin/overridetree.cb M src/mainboard/google/volteer/variants/drobit/overridetree.cb M src/mainboard/google/volteer/variants/eldrid/overridetree.cb M src/mainboard/google/volteer/variants/elemi/overridetree.cb M src/mainboard/google/volteer/variants/lindar/overridetree.cb M src/mainboard/google/volteer/variants/volteer/overridetree.cb M src/mainboard/google/volteer/variants/volteer2/overridetree.cb 10 files changed, 0 insertions(+), 20 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/99/56199/8 -- To view, visit https://review.coreboot.org/c/coreboot/+/56199 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I597e4487e7a0e1848d2a2f2c8f8ebd552994aac2 Gerrit-Change-Number: 56199 Gerrit-PatchSet: 8 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: mb/google/volteer/baseboard: Configure chipset_lockdown separately
by Felix Singer (Code Review) 14 Jul '21

14 Jul '21

Attention is currently required from: Felix Singer, Tim Wawrzynczak, Angel Pons. Hello build bot (Jenkins), Tim Wawrzynczak, Angel Pons, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/56209 to look at the new patch set (#3). Change subject: mb/google/volteer/baseboard: Configure chipset_lockdown separately ...................................................................... mb/google/volteer/baseboard: Configure chipset_lockdown separately The configuration of the setting `chipset_lockdown` doesn't have any effect for most of the variants since their configuration of `common_soc_config` overwrites the configuration of the baseboard's devicetree. If `chipset_lockdown` is configured separataly in the baseboard devicetree, the variant overridetrees reuse its configuration. Thus, move `chipset_lockdown` out of `common_soc_config` in the baseboard devicetree and configure it separately. Change-Id: I595c042cf62680d61f60965710d382bfdcd81671 Signed-off-by: Felix Singer <felixsinger(a)posteo.net> --- M src/mainboard/google/volteer/variants/baseboard/devicetree.cb 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/09/56209/3 -- To view, visit https://review.coreboot.org/c/coreboot/+/56209 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I595c042cf62680d61f60965710d382bfdcd81671 Gerrit-Change-Number: 56209 Gerrit-PatchSet: 3 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Furquan Shaikh <furquan(a)google.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: soc/amd/picasso: implement and use mca_get_bank_name
by Raul Rangel (Code Review) 14 Jul '21

14 Jul '21

Attention is currently required from: Jason Glenesk, Marshall Dawson, Felix Held. Raul Rangel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56276 ) Change subject: soc/amd/picasso: implement and use mca_get_bank_name ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/56276 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I42abff5efcd7c85d2932a7aaacc736d0376cfaa0 Gerrit-Change-Number: 56276 Gerrit-PatchSet: 1 Gerrit-Owner: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Attention: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Tue, 13 Jul 2021 21:03:50 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/siemens/chili: Replace `def_bool` with `bool`
by Felix Singer (Code Review) 13 Jul '21

13 Jul '21

Hello build bot (Jenkins), Nico Huber, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/52807 to look at the new patch set (#3). Change subject: mb/siemens/chili: Replace `def_bool` with `bool` ...................................................................... mb/siemens/chili: Replace `def_bool` with `bool` No need to use `def_bool`. Use `bool` to be consistent with the rest of the Kconfig file. Change-Id: Ib7fdd04e3ea282afb67b4d7a326a36f15f0e0cac Signed-off-by: Felix Singer <felixsinger(a)posteo.net> --- M src/mainboard/siemens/chili/Kconfig 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/07/52807/3 -- To view, visit https://review.coreboot.org/c/coreboot/+/52807 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib7fdd04e3ea282afb67b4d7a326a36f15f0e0cac Gerrit-Change-Number: 52807 Gerrit-PatchSet: 3 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: mb/kontron/bsl6: Replace `def_bool` with `bool`
by Felix Singer (Code Review) 13 Jul '21

13 Jul '21

Hello build bot (Jenkins), Nico Huber, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/52806 to look at the new patch set (#3). Change subject: mb/kontron/bsl6: Replace `def_bool` with `bool` ...................................................................... mb/kontron/bsl6: Replace `def_bool` with `bool` No need to use `def_bool`. Use `bool` to be consistent with the rest of the Kconfig file. Change-Id: I475c56464cd9e194c575d120b6ce15c8445103b6 Signed-off-by: Felix Singer <felixsinger(a)posteo.net> --- M src/mainboard/kontron/bsl6/Kconfig 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/06/52806/3 -- To view, visit https://review.coreboot.org/c/coreboot/+/52806 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I475c56464cd9e194c575d120b6ce15c8445103b6 Gerrit-Change-Number: 52806 Gerrit-PatchSet: 3 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: mb/clevo: Replace `def_bool` with `bool`
by Felix Singer (Code Review) 13 Jul '21

13 Jul '21

Hello build bot (Jenkins), Michael Niewöhner, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/52805 to look at the new patch set (#3). Change subject: mb/clevo: Replace `def_bool` with `bool` ...................................................................... mb/clevo: Replace `def_bool` with `bool` No need to use `def_bool`. Use `bool` to be consistent with the rest of the Kconfig file. Change-Id: I3558820ae45090b5f3cf494badde9e37ca2721bb Signed-off-by: Felix Singer <felixsinger(a)posteo.net> --- M src/mainboard/clevo/cml-u/Kconfig M src/mainboard/clevo/kbl-u/Kconfig 2 files changed, 2 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/05/52805/3 -- To view, visit https://review.coreboot.org/c/coreboot/+/52805 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I3558820ae45090b5f3cf494badde9e37ca2721bb Gerrit-Change-Number: 52805 Gerrit-PatchSet: 3 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: mb/siemens/chili: Replace `def_bool` with `bool`
by Felix Singer (Code Review) 13 Jul '21

13 Jul '21

Hello build bot (Jenkins), Nico Huber, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/52807 to look at the new patch set (#2). Change subject: mb/siemens/chili: Replace `def_bool` with `bool` ...................................................................... mb/siemens/chili: Replace `def_bool` with `bool` Not need to use `def_bool`. Use `bool` to be consistent with the rest of the Kconfig file. Change-Id: Ib7fdd04e3ea282afb67b4d7a326a36f15f0e0cac Signed-off-by: Felix Singer <felixsinger(a)posteo.net> --- M src/mainboard/siemens/chili/Kconfig 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/07/52807/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/52807 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib7fdd04e3ea282afb67b4d7a326a36f15f0e0cac Gerrit-Change-Number: 52807 Gerrit-PatchSet: 2 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: mb/kontron/bsl6: Replace `def_bool` with `bool`
by Felix Singer (Code Review) 13 Jul '21

13 Jul '21

Hello build bot (Jenkins), Nico Huber, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/52806 to look at the new patch set (#2). Change subject: mb/kontron/bsl6: Replace `def_bool` with `bool` ...................................................................... mb/kontron/bsl6: Replace `def_bool` with `bool` Not need to use `def_bool`. Use `bool` to be consistent with the rest of the Kconfig file. Change-Id: I475c56464cd9e194c575d120b6ce15c8445103b6 Signed-off-by: Felix Singer <felixsinger(a)posteo.net> --- M src/mainboard/kontron/bsl6/Kconfig 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/06/52806/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/52806 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I475c56464cd9e194c575d120b6ce15c8445103b6 Gerrit-Change-Number: 52806 Gerrit-PatchSet: 2 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: mb/clevo: Replace `def_bool` with `bool`
by Felix Singer (Code Review) 13 Jul '21

13 Jul '21

Hello build bot (Jenkins), Michael Niewöhner, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/52805 to look at the new patch set (#2). Change subject: mb/clevo: Replace `def_bool` with `bool` ...................................................................... mb/clevo: Replace `def_bool` with `bool` Not need to use `def_bool`. Use `bool` to be consistent with the rest of the Kconfig file. Change-Id: I3558820ae45090b5f3cf494badde9e37ca2721bb Signed-off-by: Felix Singer <felixsinger(a)posteo.net> --- M src/mainboard/clevo/cml-u/Kconfig M src/mainboard/clevo/kbl-u/Kconfig 2 files changed, 2 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/05/52805/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/52805 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I3558820ae45090b5f3cf494badde9e37ca2721bb Gerrit-Change-Number: 52805 Gerrit-PatchSet: 2 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: newpatchset

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit July 2021