Attention is currently required from: Kevin Chang.
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52878 )
Change subject: mb/google/octopus: add audio codec into SSFC support for Phaser
......................................................................
Patch Set 2:
(2 comments)
File src/mainboard/google/octopus/variants/phaser/gpio.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118336):
https://review.coreboot.org/c/coreboot/+/52878/comment/d5b0d811_cc88731c
PS2, Line 17: PAD_CFG_GPI_APIC_IOS(GPIO_137, NONE, DEEP,LEVEL, INVERT, HIZCRx1,
space required after that ',' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118336):
https://review.coreboot.org/c/coreboot/+/52878/comment/3150b079_2264cf65
PS2, Line 40: PAD_CFG_GPI_APIC_IOS(GPIO_137,NONE, DEEP, LEVEL, INVERT, HIZCRx1,
space required after that ',' (ctx:VxV)
--
To view, visit https://review.coreboot.org/c/coreboot/+/52878
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I202f71f57ad2db84fb90b52f9ffd7a1fd05494a3
Gerrit-Change-Number: 52878
Gerrit-PatchSet: 2
Gerrit-Owner: Kevin Chang <kevin.chang(a)lcfc.corp-partner.google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Kevin Chang <kevin.chang(a)lcfc.corp-partner.google.com>
Gerrit-Comment-Date: Tue, 04 May 2021 06:48:39 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Kevin Chang.
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/52878
to look at the new patch set (#2).
Change subject: mb/google/octopus: add audio codec into SSFC support for Phaser
......................................................................
mb/google/octopus: add audio codec into SSFC support for Phaser
Add audio codec module RT5682I in project.
BUG=b:182221327
BRANCH=octopus
TEST=adjust SSFC value of CBI to select RT5682I or DA7219 then check whether device tree is updated correspondingly by disabling unselected one.
Signed-off-by: Kevin Chang <kevin.chang(a)lcfc.corp-partner.google.com>
Change-Id: I202f71f57ad2db84fb90b52f9ffd7a1fd05494a3
---
M src/mainboard/google/octopus/Kconfig.name
M src/mainboard/google/octopus/variants/phaser/gpio.c
M src/mainboard/google/octopus/variants/phaser/overridetree.cb
3 files changed, 18 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/78/52878/2
--
To view, visit https://review.coreboot.org/c/coreboot/+/52878
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I202f71f57ad2db84fb90b52f9ffd7a1fd05494a3
Gerrit-Change-Number: 52878
Gerrit-PatchSet: 2
Gerrit-Owner: Kevin Chang <kevin.chang(a)lcfc.corp-partner.google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Kevin Chang <kevin.chang(a)lcfc.corp-partner.google.com>
Gerrit-MessageType: newpatchset
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52878 )
Change subject: mb/google/octopus: add audio codec into SSFC support for Phaser
......................................................................
Patch Set 1:
(4 comments)
File src/mainboard/google/octopus/variants/phaser/gpio.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118335):
https://review.coreboot.org/c/coreboot/+/52878/comment/ccc745a3_7442ecfe
PS1, Line 17: PAD_CFG_GPI_APIC_IOS(GPIO_137, NONE, DEEP,LEVEL, INVERT, HIZCRx1,
space required after that ',' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118335):
https://review.coreboot.org/c/coreboot/+/52878/comment/c0735e15_8b513402
PS1, Line 18: DISPUPD),
code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118335):
https://review.coreboot.org/c/coreboot/+/52878/comment/8c63fca3_ebcd5a30
PS1, Line 40: PAD_CFG_GPI_APIC_IOS(GPIO_137,NONE, DEEP, LEVEL, INVERT, HIZCRx1,
space required after that ',' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118335):
https://review.coreboot.org/c/coreboot/+/52878/comment/35c1764d_37c29d1d
PS1, Line 41: DISPUPD),
code indent should use tabs where possible
--
To view, visit https://review.coreboot.org/c/coreboot/+/52878
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I202f71f57ad2db84fb90b52f9ffd7a1fd05494a3
Gerrit-Change-Number: 52878
Gerrit-PatchSet: 1
Gerrit-Owner: Kevin Chang <kevin.chang(a)lcfc.corp-partner.google.com>
Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Comment-Date: Tue, 04 May 2021 06:42:51 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Patrick Rudolph.
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/52861
to look at the new patch set (#2).
Change subject: x86/exception: Print the offset within the stage that caused the fault
......................................................................
x86/exception: Print the offset within the stage that caused the fault
To ease debugging print the offset if it's within the current stage.
This is more convenient than searching the log for the rmodule loading
address and subtracting it manually from the IP.
Change-Id: I0c44e4ee773ccf4bdd25b551949e02d754681417
Signed-off-by: Patrick Rudolph <patrick.rudolph(a)9elements.com>
---
M src/arch/x86/exception.c
1 file changed, 12 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/61/52861/2
--
To view, visit https://review.coreboot.org/c/coreboot/+/52861
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I0c44e4ee773ccf4bdd25b551949e02d754681417
Gerrit-Change-Number: 52861
Gerrit-PatchSet: 2
Gerrit-Owner: Patrick Rudolph <patrick.rudolph(a)9elements.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Patrick Rudolph <patrick.rudolph(a)9elements.com>
Gerrit-MessageType: newpatchset
Attention is currently required from: Paul Menzel, Tim Wawrzynczak, Patrick Rudolph.
Star Labs has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52800 )
Change subject: soc/intel: Allow enable/disable ME via CMOS
......................................................................
Patch Set 4:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/52800/comment/102d10f5_47b20bd1
PS3, Line 7: Added CMOS option to disable ME
> Please use a prefix, and also [use imperative mood in commit message summaries](https://chris.beams. […]
Is that okay?
Patchset:
PS4:
> just curious, have you seen CB:37115 ?
Yup. By any chance, are you going to suggest hiding the device in the same way?
--
To view, visit https://review.coreboot.org/c/coreboot/+/52800
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I374db3b7c0ded71cdc18f27970252fec7220cc20
Gerrit-Change-Number: 52800
Gerrit-PatchSet: 4
Gerrit-Owner: Star Labs <admin(a)starlabs.systems>
Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Comment-Date: Tue, 04 May 2021 06:16:02 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org>
Comment-In-Reply-To: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-MessageType: comment
Attention is currently required from: Michał Żygowski, Paul Menzel, Andrey Petrov, Patrick Rudolph.
Hello build bot (Jenkins), Andrey Petrov, Patrick Rudolph,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/52850
to look at the new patch set (#3).
Change subject: drivers/intel/fsp2_0: Fix the FSP_T position
......................................................................
drivers/intel/fsp2_0: Fix the FSP_T position
The only use case for FSP-T in coreboot is for 'Intel Bootguard'
support at the moment. Bootguard can do verification FSP-T there is no
verification on whether the FSP found by walkcbfs_asm is the one
actually verified as an IBB by Bootguard. A fixed pointer needs to be
used.
TESTED on OCP/Deltalake, still boots.
Change-Id: I1ec8b238384684dccf39e5da902d426d3a32b9db
Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz>
---
M src/drivers/intel/fsp2_0/Kconfig
M src/drivers/intel/fsp2_0/Makefile.inc
M src/soc/intel/common/block/cpu/car/cache_as_ram_fsp.S
3 files changed, 8 insertions(+), 10 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/50/52850/3
--
To view, visit https://review.coreboot.org/c/coreboot/+/52850
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I1ec8b238384684dccf39e5da902d426d3a32b9db
Gerrit-Change-Number: 52850
Gerrit-PatchSet: 3
Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Andrey Petrov <andrey.petrov(a)gmail.com>
Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Michał Żygowski <michal.zygowski(a)3mdeb.com>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Michał Żygowski <michal.zygowski(a)3mdeb.com>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Andrey Petrov <andrey.petrov(a)gmail.com>
Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-MessageType: newpatchset