coreboot-gerrit May 2021

coreboot-gerrit@coreboot.org

1 participants
6048 discussions

Change in coreboot[master]: mb/siemens/mc_apl1: Move gpio.c from baseboard to mc_apl1
by Michael Niewöhner (Code Review) 27 May '21

27 May '21

Attention is currently required from: Mario Scheithauer. Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/54945 ) Change subject: mb/siemens/mc_apl1: Move gpio.c from baseboard to mc_apl1 ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/54945 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ie2ba8181dfe887df9abbbd648f2cbdc6ffc65530 Gerrit-Change-Number: 54945 Gerrit-PatchSet: 1 Gerrit-Owner: Mario Scheithauer <mario.scheithauer(a)siemens.com> Gerrit-Reviewer: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Mario Scheithauer <mario.scheithauer(a)siemens.com> Gerrit-Comment-Date: Thu, 27 May 2021 13:17:56 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/siemens/{mc_apl2,...,mc_apl6}: Do early UART pad configuration
by Michael Niewöhner (Code Review) 27 May '21

27 May '21

Attention is currently required from: Paul Menzel, Mario Scheithauer, Werner Zeh. Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/54911 ) Change subject: mb/siemens/{mc_apl2,...,mc_apl6}: Do early UART pad configuration ...................................................................... Patch Set 4: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/54911/comment/ab122a2b_20ff970b PS3, Line 9: With commit 405f2296892c10a48db50cd66c2eb364cde0806e the UART pad > At least in the Linux kernel abbreviated hashes with the summary are used: […] Done -- To view, visit https://review.coreboot.org/c/coreboot/+/54911 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: If78726d9b141e4e7580cca3267f49c1a5b95d7fa Gerrit-Change-Number: 54911 Gerrit-PatchSet: 4 Gerrit-Owner: Mario Scheithauer <mario.scheithauer(a)siemens.com> Gerrit-Reviewer: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Mario Scheithauer <mario.scheithauer(a)siemens.com> Gerrit-Attention: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Comment-Date: Thu, 27 May 2021 13:17:27 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: soc/intel/elkhartlake: Update FSP-S UPD related configs part 2
by Lean Sheng Tan (Code Review) 27 May '21

27 May '21

Attention is currently required from: Maulik V Vaghela, Paul Menzel, Mario Scheithauer, Subrata Banik, Werner Zeh, Patrick Rudolph. Lean Sheng Tan has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/54960 ) Change subject: soc/intel/elkhartlake: Update FSP-S UPD related configs part 2 ...................................................................... Patch Set 8: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/54960/comment/d22ff889_3486d941 PS3, Line 17: THis > This Done -- To view, visit https://review.coreboot.org/c/coreboot/+/54960 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I657f44f8506640c23049614b2db9d1837e6d44ed Gerrit-Change-Number: 54960 Gerrit-PatchSet: 8 Gerrit-Owner: Lean Sheng Tan <lean.sheng.tan(a)intel.com> Gerrit-Reviewer: Mario Scheithauer <mario.scheithauer(a)siemens.com> Gerrit-Reviewer: Maulik V Vaghela <maulik.v.vaghela(a)intel.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Maulik V Vaghela <maulik.v.vaghela(a)intel.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Mario Scheithauer <mario.scheithauer(a)siemens.com> Gerrit-Attention: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Attention: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Comment-Date: Thu, 27 May 2021 13:08:45 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: acpi: Add support for reporting CrashLog in BERT table
by Felix Held (Code Review) 27 May '21

27 May '21

Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49799 ) Change subject: acpi: Add support for reporting CrashLog in BERT table ...................................................................... Patch Set 10: (1 comment) Patchset: PS10: hm, ok, since you're putting some raw data into a bert entry, we need to support raw_data_length but also raw_data_offset, since linux will be unhappy if that one is zero and the other one non-zero. still trying to figure out the details though. i don't really need to rush in the patch/hack reverting the raw_data_length writes that made things work again for me, so finding a proper solution that works for all case would be my preferred approach. mostly needed that partial revert to test the other parts of my patch series. on the acpi bert ssdt generation code in acpi/acpi.c: i'd like to move the code added here https://review.coreboot.org/c/coreboot/+/54149/2/src/soc/amd/picasso/agesa_… to the common acpi code and rework how the code added in this patch interacts with the bert ssdt generation to avoid duplicating functionality and to also avoid to have to call into soc code when the common code already has the corresponding functionality -- To view, visit https://review.coreboot.org/c/coreboot/+/49799 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I00e390d735d61beac2e89a726e39119d9b06b3df Gerrit-Change-Number: 49799 Gerrit-PatchSet: 10 Gerrit-Owner: Francois Toguo Fotso <francois.toguo.fotso(a)intel.com> Gerrit-Reviewer: Lance Zhao Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Nikunj Dadhania <nikunj.dadhania(a)intel.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: 9elements QA <hardwaretestrobot(a)gmail.com> Gerrit-CC: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-CC: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Raj Astekar <raj.astekar(a)intel.com> Gerrit-Comment-Date: Thu, 27 May 2021 13:08:16 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/asus/p8z77-series: Add P8Z77-V as a variant of P8Z77 series
by Bill XIE (Code Review) 27 May '21

27 May '21

Attention is currently required from: Angel Pons. Bill XIE has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/54338 ) Change subject: mb/asus/p8z77-series: Add P8Z77-V as a variant of P8Z77 series ...................................................................... Patch Set 15: (2 comments) File Documentation/mainboard/asus/p8z77-v.md: https://review.coreboot.org/c/coreboot/+/54338/comment/8ae0d4fa_c80c943f PS14, Line 30: Internal programming > `How to flash` would be more accurate Done File Documentation/mainboard/asus/wifigo_v1.md: https://review.coreboot.org/c/coreboot/+/54338/comment/5f1c4c49_e2529c4c PS14, Line 1: # Asus Wi-Fi Go! v1 > Add a blank line afterwards? Done -- To view, visit https://review.coreboot.org/c/coreboot/+/54338 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic56ac0e5f93a6e818ef0666e41996718471b1cf6 Gerrit-Change-Number: 54338 Gerrit-PatchSet: 15 Gerrit-Owner: Bill XIE <persmule(a)hardenedlinux.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Comment-Date: Thu, 27 May 2021 12:54:02 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/asus/p8z77-series: Add P8Z77-V as a variant of P8Z77 series
by Bill XIE (Code Review) 27 May '21

27 May '21

Attention is currently required from: Bill XIE. Hello build bot (Jenkins), Paul Menzel, Angel Pons, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/54338 to look at the new patch set (#15). Change subject: mb/asus/p8z77-series: Add P8Z77-V as a variant of P8Z77 series ...................................................................... mb/asus/p8z77-series: Add P8Z77-V as a variant of P8Z77 series Mainboard information can be found in the included documentation. Signed-off-by: Bill XIE <persmule(a)hardenedlinux.org> Change-Id: Ic56ac0e5f93a6e818ef0666e41996718471b1cf6 --- A Documentation/mainboard/asus/p8z77-v.jpg A Documentation/mainboard/asus/p8z77-v.md A Documentation/mainboard/asus/wifigo_v1.md A Documentation/mainboard/asus/wifigo_v1_board.jpg A Documentation/mainboard/asus/wifigo_v1_connector.jpg M Documentation/mainboard/index.md M src/mainboard/asus/p8z77-series/Kconfig M src/mainboard/asus/p8z77-series/Kconfig.name A src/mainboard/asus/p8z77-series/variants/p8z77-v/board_info.txt A src/mainboard/asus/p8z77-series/variants/p8z77-v/cmos.default A src/mainboard/asus/p8z77-series/variants/p8z77-v/cmos.layout A src/mainboard/asus/p8z77-series/variants/p8z77-v/data.vbt A src/mainboard/asus/p8z77-series/variants/p8z77-v/early_init.c A src/mainboard/asus/p8z77-series/variants/p8z77-v/gma-mainboard.ads A src/mainboard/asus/p8z77-series/variants/p8z77-v/gpio.c A src/mainboard/asus/p8z77-series/variants/p8z77-v/hda_verb.c A src/mainboard/asus/p8z77-series/variants/p8z77-v/overridetree.cb 17 files changed, 631 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/38/54338/15 -- To view, visit https://review.coreboot.org/c/coreboot/+/54338 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic56ac0e5f93a6e818ef0666e41996718471b1cf6 Gerrit-Change-Number: 54338 Gerrit-PatchSet: 15 Gerrit-Owner: Bill XIE <persmule(a)hardenedlinux.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Attention: Bill XIE <persmule(a)hardenedlinux.org> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: Documentation: Update real time chat options
by Felix Singer (Code Review) 27 May '21

27 May '21

Attention is currently required from: Angel Pons. Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/55010 ) Change subject: Documentation: Update real time chat options ...................................................................... Patch Set 1: Code-Review+2 (1 comment) File Documentation/community/forums.md: https://review.coreboot.org/c/coreboot/+/55010/comment/f23237f5_d13a9081 PS1, Line 17: # > Should the `#` be percent-encoded? I think this is fine here -- To view, visit https://review.coreboot.org/c/coreboot/+/55010 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I3035266c5e035b954c0d709bd2c09069128c3340 Gerrit-Change-Number: 55010 Gerrit-PatchSet: 1 Gerrit-Owner: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Comment-Date: Thu, 27 May 2021 12:47:41 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: Documentation: Update real time chat options
by Felix Held (Code Review) 27 May '21

27 May '21

Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/55010 ) Change subject: Documentation: Update real time chat options ...................................................................... Patch Set 1: Code-Review+1 (1 comment) Patchset: PS1: i don't see any way around moving away from freenode after the hostile takeover and especially after the new staff took over all channels that mentioned liberachat in the subject. i mean what the ... on discord: i personally found it a bit obnoxious when i had a look at it some time ago, but since i don't have to use it, i don't have strong objections against adding that -- To view, visit https://review.coreboot.org/c/coreboot/+/55010 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I3035266c5e035b954c0d709bd2c09069128c3340 Gerrit-Change-Number: 55010 Gerrit-PatchSet: 1 Gerrit-Owner: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 27 May 2021 12:46:03 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: 3rdparty/intel-sec-tools: Update to support Boot Guard
by Angel Pons (Code Review) 27 May '21

27 May '21

Attention is currently required from: Christopher Meis, Christian Walter. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/55013 ) Change subject: 3rdparty/intel-sec-tools: Update to support Boot Guard ...................................................................... Patch Set 3: Code-Review+1 (2 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/55013/comment/99a6b5d5_49fd9779 PS2, Line 7: U > Change to: 3rdparty/intel-sec-tools: Update to support Boot Guard Done Commit Message: https://review.coreboot.org/c/coreboot/+/55013/comment/a2eb6c48_f6ed5011 PS3, Line 11: arugment typo: argument -- To view, visit https://review.coreboot.org/c/coreboot/+/55013 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iaf34bdb65a5f067d1d632e35d340b8fc49aaf318 Gerrit-Change-Number: 55013 Gerrit-PatchSet: 3 Gerrit-Owner: Christopher Meis Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Christopher Meis Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com> Gerrit-Comment-Date: Thu, 27 May 2021 12:25:12 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Christian Walter <christian.walter(a)9elements.com> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: 3rdparty/intel-sec-tools: Update to support Boot Guard
by Christopher Meis (Code Review) 27 May '21

27 May '21

Attention is currently required from: Christopher Meis. Hello build bot (Jenkins), Christian Walter, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/55013 to look at the new patch set (#3). Change subject: 3rdparty/intel-sec-tools: Update to support Boot Guard ...................................................................... 3rdparty/intel-sec-tools: Update to support Boot Guard Update intel-sec-tools to commit of BootGuard support. Remove --coreboot argument in src/security/intel/cbnt/Makefile.inc: was removed as arugment for cbnt Change-Id: Iaf34bdb65a5f067d1d632e35d340b8fc49aaf318 Signed-off-by: Christopher Meis <christopher.meis(a)9elements.com> --- M 3rdparty/intel-sec-tools M src/security/intel/cbnt/Makefile.inc 2 files changed, 1 insertion(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/13/55013/3 -- To view, visit https://review.coreboot.org/c/coreboot/+/55013 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iaf34bdb65a5f067d1d632e35d340b8fc49aaf318 Gerrit-Change-Number: 55013 Gerrit-PatchSet: 3 Gerrit-Owner: Christopher Meis Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Christopher Meis Gerrit-MessageType: newpatchset

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit May 2021