Attention is currently required from: Anjaneya "Reddy" Chagam, Jonathan Zhang, Johnny Lin, Morgan Jang, Kyösti Mälkki.
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/55046 )
Change subject: arch/x86/bootblock.ld: Align the bottom of the bootblock to 64 bytes
......................................................................
Patch Set 1:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/55046/comment/ed447e4f_f788cdb7
PS1, Line 11: - Bootguard/CBnT requires a 64 byte alignment
> I thought reading comments once that Bootquard needed fixed bootblock size?
I was not correct. The open source Btg/CBnT tooling was quite crude then. The tooling improved and is now coreboot/cbfs aware and can detect bootblock automatically.
https://review.coreboot.org/c/coreboot/+/55046/comment/f370995a_4e072035
PS1, Line 12: - It can reduce the bootblock footprint as the size is aligned upwards
> Is potential of 48 bytes saved worth mentioning?
Not really.
--
To view, visit https://review.coreboot.org/c/coreboot/+/55046
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I69cdacdd15bfca1b91b6f271f2ff76889969fd91
Gerrit-Change-Number: 55046
Gerrit-PatchSet: 1
Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Anjaneya "Reddy" Chagam <anjaneya.chagam(a)intel.com>
Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Johnny Lin <Johnny_Lin(a)wiwynn.com>
Gerrit-Reviewer: Jonathan Zhang <jonzhang(a)fb.com>
Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com>
Gerrit-Reviewer: Morgan Jang <Morgan_Jang(a)wiwynn.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Anjaneya "Reddy" Chagam <anjaneya.chagam(a)intel.com>
Gerrit-Attention: Jonathan Zhang <jonzhang(a)fb.com>
Gerrit-Attention: Johnny Lin <Johnny_Lin(a)wiwynn.com>
Gerrit-Attention: Morgan Jang <Morgan_Jang(a)wiwynn.com>
Gerrit-Attention: Kyösti Mälkki <kyosti.malkki(a)gmail.com>
Gerrit-Comment-Date: Fri, 28 May 2021 13:33:03 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Kyösti Mälkki <kyosti.malkki(a)gmail.com>
Gerrit-MessageType: comment
Attention is currently required from: Maulik V Vaghela, Subrata Banik, Lean Sheng Tan, Patrick Rudolph.
Mario Scheithauer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/54892 )
Change subject: soc/intel/elkhartlake: Update FSP-M UPD related configs
......................................................................
Patch Set 8: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/54892
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If6321064b37535b390cf3dd7c41a719c598a0cd7
Gerrit-Change-Number: 54892
Gerrit-PatchSet: 8
Gerrit-Owner: Lean Sheng Tan <lean.sheng.tan(a)intel.com>
Gerrit-Reviewer: Mario Scheithauer <mario.scheithauer(a)siemens.com>
Gerrit-Reviewer: Maulik V Vaghela <maulik.v.vaghela(a)intel.com>
Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com>
Gerrit-Reviewer: Werner Zeh <werner.zeh(a)siemens.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Maulik V Vaghela <maulik.v.vaghela(a)intel.com>
Gerrit-Attention: Subrata Banik <subrata.banik(a)intel.com>
Gerrit-Attention: Lean Sheng Tan <lean.sheng.tan(a)intel.com>
Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Comment-Date: Fri, 28 May 2021 12:54:41 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: V Sowmya.
Vinay Kumar has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/54055 )
Change subject: soc/intel/alderlake: Configure FIVR, VR, Turbo ratios
......................................................................
Patch Set 4:
(1 comment)
This change is ready for review.
File src/soc/intel/alderlake/fsp_params.c:
https://review.coreboot.org/c/coreboot/+/54055/comment/f17900fd_5e056497
PS4, Line 329: params->PchFivrExtVnnRailSxEnabledStates = 0x3f;
For Brya board, PchFivrExtV1p05RailEnabledStates, PchFivrExtVnnRailEnabledStates and PchFivrExtVnnRailSxEnabledStates should be set to 0x0(disabled). This is because Brya does not have VNN and V1P05 external bypass rails implemented. Other voltage and Iccmax settings for ExtV1p05/Vnn rails are not required for Brya board.
--
To view, visit https://review.coreboot.org/c/coreboot/+/54055
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I8d485872c8bae32f83ebf94bdaa4c6a793976ce7
Gerrit-Change-Number: 54055
Gerrit-PatchSet: 4
Gerrit-Owner: V Sowmya <v.sowmya(a)intel.com>
Gerrit-Reviewer: Baieswara Reddy Sagili <baieswara.reddy.sagili(a)intel.com>
Gerrit-Reviewer: Balaji Manigandan <balaji.manigandan(a)intel.com>
Gerrit-Reviewer: Kedar J. Karanje <kedar.j.karanje(a)intel.com>
Gerrit-Reviewer: Maulik V Vaghela <maulik.v.vaghela(a)intel.com>
Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Reviewer: Sanju Jose Thottan <sanjujose.thottan(a)intel.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: Vinay Kumar <vinay.kumar(a)intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Reviewer: vagdevi.p(a)intel.com
Gerrit-Attention: V Sowmya <v.sowmya(a)intel.com>
Gerrit-Comment-Date: Fri, 28 May 2021 12:49:23 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Varshit B Pandya has removed Varshit B Pandya from this change. ( https://review.coreboot.org/c/coreboot/+/55047 )
Change subject: mb/google/brya: Disable I2C4
......................................................................
Removed reviewer Varshit B Pandya.
--
To view, visit https://review.coreboot.org/c/coreboot/+/55047
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib58bc3f8f66e4296aa1fa299a458f92a8d75aad0
Gerrit-Change-Number: 55047
Gerrit-PatchSet: 1
Gerrit-Owner: Varshit B Pandya <varshit.b.pandya(a)intel.com>
Gerrit-CC: Meera Ravindranath <meera.ravindranath(a)intel.com>
Gerrit-MessageType: deleteReviewer
Attention is currently required from: Furquan Shaikh, Paul Menzel, Sathya Prakash M R, Patrick Rudolph.
Sugnan Prabhu S has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/54716 )
Change subject: mb/google/brya: Add firmware configuration probing for audio
......................................................................
Patch Set 7:
(3 comments)
File src/mainboard/google/brya/variants/brya0/fw_config.c:
https://review.coreboot.org/c/coreboot/+/54716/comment/d6a0d6d0_654a958c
PS6, Line 61: FW config is not provisioned or audio is disabled.
> … disable all pads. […]
Done
https://review.coreboot.org/c/coreboot/+/54716/comment/6e967821_be907e71
PS6, Line 61: printk(BIOS_INFO, "FW config is not provisioned or audio is disabled.\n");
> This sounds like a warning or notice to me.
Ack
https://review.coreboot.org/c/coreboot/+/54716/comment/e5f520f7_4846895a
PS6, Line 69: printk(BIOS_INFO, "Configure GPIOs for SoundWire audio.\n");
> I’d also put the model number into the message.
Done
--
To view, visit https://review.coreboot.org/c/coreboot/+/54716
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I6f159442516830f9d304d78c83f070e4fcff4a37
Gerrit-Change-Number: 54716
Gerrit-PatchSet: 7
Gerrit-Owner: Sugnan Prabhu S <sugnan.prabhu.s(a)intel.com>
Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com>
Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Reviewer: Sathya Prakash M R <sathya.prakash.m.r(a)intel.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Furquan Shaikh <furquan(a)google.com>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Sathya Prakash M R <sathya.prakash.m.r(a)intel.com>
Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Comment-Date: Fri, 28 May 2021 12:10:33 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-MessageType: comment
Attention is currently required from: Furquan Shaikh, Sugnan Prabhu S, Sathya Prakash M R, Patrick Rudolph.
Hello build bot (Jenkins), Furquan Shaikh, Tim Wawrzynczak, Sathya Prakash M R, Patrick Rudolph,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/54716
to look at the new patch set (#7).
Change subject: mb/google/brya: Add firmware configuration probing for audio
......................................................................
mb/google/brya: Add firmware configuration probing for audio
For all of the audio devices in overridetree.cb add the probe matches
that will determine if the device should be enabled or not based on the
selected audio daughter board type.
AUDIO=MAX98357_ALC5682I_I2S: enable max98357, dmic1 and alc5682i
AUDIO=MAX98373_ALC5682_SNDW: enable max98373, dmic2 and alc5682
BUG=b:188696010
TEST=test different audio devices based on fw_config value:
> AUDIO=UNKNOWN
ectool cbi set 6 0x00000000 4 2
> AUDIO=MAX98357_ALC5682I_I2S
ectool cbi set 6 0x00000100 4 2
> AUDIO=MAX98373_ALC5682_SNDW
ectool cbi set 6 0x00000200 4 2
Change-Id: I6f159442516830f9d304d78c83f070e4fcff4a37
Signed-off-by: Sugnan Prabhu S <sugnan.prabhu.s(a)intel.com>
---
M src/mainboard/google/brya/Kconfig
A src/mainboard/google/brya/variants/brya0/Makefile.inc
A src/mainboard/google/brya/variants/brya0/fw_config.c
M src/mainboard/google/brya/variants/brya0/overridetree.cb
4 files changed, 113 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/16/54716/7
--
To view, visit https://review.coreboot.org/c/coreboot/+/54716
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I6f159442516830f9d304d78c83f070e4fcff4a37
Gerrit-Change-Number: 54716
Gerrit-PatchSet: 7
Gerrit-Owner: Sugnan Prabhu S <sugnan.prabhu.s(a)intel.com>
Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com>
Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Reviewer: Sathya Prakash M R <sathya.prakash.m.r(a)intel.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Furquan Shaikh <furquan(a)google.com>
Gerrit-Attention: Sugnan Prabhu S <sugnan.prabhu.s(a)intel.com>
Gerrit-Attention: Sathya Prakash M R <sathya.prakash.m.r(a)intel.com>
Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-MessageType: newpatchset
Attention is currently required from: Anjaneya "Reddy" Chagam, Jonathan Zhang, Johnny Lin, Arthur Heymans, Morgan Jang.
Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/55046 )
Change subject: arch/x86/bootblock.ld: Align the bottom of the bootblock to 64 bytes
......................................................................
Patch Set 1:
(3 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/55046/comment/cf8d23f5_a729670f
PS1, Line 11: - Bootguard/CBnT requires a 64 byte alignment
I thought reading comments once that Bootquard needed fixed bootblock size?
https://review.coreboot.org/c/coreboot/+/55046/comment/dc6c8d11_683dc460
PS1, Line 12: - It can reduce the bootblock footprint as the size is aligned upwards
Is potential of 48 bytes saved worth mentioning?
File src/arch/x86/bootblock.ld:
https://review.coreboot.org/c/coreboot/+/55046/comment/5287a705_50dc614f
PS1, Line 32: PROGRAM_SZ = SIZEOF(.text) + 512;
There is more potential to save size by decreasing from 512. But one value will not work for all platforms.
--
To view, visit https://review.coreboot.org/c/coreboot/+/55046
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I69cdacdd15bfca1b91b6f271f2ff76889969fd91
Gerrit-Change-Number: 55046
Gerrit-PatchSet: 1
Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Anjaneya "Reddy" Chagam <anjaneya.chagam(a)intel.com>
Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Johnny Lin <Johnny_Lin(a)wiwynn.com>
Gerrit-Reviewer: Jonathan Zhang <jonzhang(a)fb.com>
Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com>
Gerrit-Reviewer: Morgan Jang <Morgan_Jang(a)wiwynn.com>
Gerrit-Attention: Anjaneya "Reddy" Chagam <anjaneya.chagam(a)intel.com>
Gerrit-Attention: Jonathan Zhang <jonzhang(a)fb.com>
Gerrit-Attention: Johnny Lin <Johnny_Lin(a)wiwynn.com>
Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Attention: Morgan Jang <Morgan_Jang(a)wiwynn.com>
Gerrit-Comment-Date: Fri, 28 May 2021 11:45:44 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/55010 )
Change subject: Documentation: Update real time chat options
......................................................................
Documentation: Update real time chat options
Change-Id: I3035266c5e035b954c0d709bd2c09069128c3340
Signed-off-by: Patrick Georgi <pgeorgi(a)google.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/55010
Reviewed-by: Felix Singer <felixsinger(a)posteo.net>
Reviewed-by: Swift Geek (Sebastian Grzywna) <swiftgeek(a)gmail.com>
Reviewed-by: Angel Pons <th3fanbus(a)gmail.com>
Reviewed-by: Felix Held <felix-coreboot(a)felixheld.de>
Reviewed-by: Michael Niewöhner <foss(a)mniewoehner.de>
Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org>
---
M Documentation/community/forums.md
1 file changed, 3 insertions(+), 4 deletions(-)
Approvals:
build bot (Jenkins): Verified
Felix Held: Looks good to me, approved
Swift Geek (Sebastian Grzywna): Looks good to me, approved
Felix Singer: Looks good to me, approved
Angel Pons: Looks good to me, approved
Michael Niewöhner: Looks good to me, approved
diff --git a/Documentation/community/forums.md b/Documentation/community/forums.md
index c5558ad..92eb6be 100644
--- a/Documentation/community/forums.md
+++ b/Documentation/community/forums.md
@@ -11,11 +11,10 @@
read its
[archives](https://mail.coreboot.org/hyperkitty/list/coreboot@coreboot.org/).
-## IRC
+## Real time chat
-We also have a
-[real time chat](https://webchat.freenode.net?channels=%23coreboot)
-on the Freenode IRC network's #coreboot channel.
+We also have a real time chat room on [IRC](ircs://irc.libera.chat/#coreboot),
+also bridged to [Matrix](https://matrix.to/#/#coreboot:libera.chat).
## Fortnightly coreboot leadership meeting
--
To view, visit https://review.coreboot.org/c/coreboot/+/55010
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3035266c5e035b954c0d709bd2c09069128c3340
Gerrit-Change-Number: 55010
Gerrit-PatchSet: 3
Gerrit-Owner: Patrick Georgi <pgeorgi(a)google.com>
Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Michael Niewöhner <foss(a)mniewoehner.de>
Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org>
Gerrit-Reviewer: Swift Geek (Sebastian Grzywna) <swiftgeek(a)gmail.com>
Gerrit-Reviewer: Werner Zeh <werner.zeh(a)siemens.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-MessageType: merged
Attention is currently required from: Patrick Rudolph, Christian Walter, Arthur Heymans.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/54731 )
Change subject: mb/prodrive/hermes: Implement option API
......................................................................
Patch Set 1: Code-Review-2
(1 comment)
Patchset:
PS1:
SMBus accesses from within SMM are not a good idea...
--
To view, visit https://review.coreboot.org/c/coreboot/+/54731
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I6473a0a80346f7b7d69653e1cac19cd428a59ba0
Gerrit-Change-Number: 54731
Gerrit-PatchSet: 1
Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com>
Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Patrick Rudolph <patrick.rudolph(a)9elements.com>
Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com>
Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Comment-Date: Fri, 28 May 2021 11:38:14 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Arthur Heymans, Patrick Rudolph.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/54730 )
Change subject: sb/intel/common: Build smbus.c in every stage
......................................................................
Patch Set 1: Code-Review-2
(1 comment)
Patchset:
PS1:
SMBus accesses from within SMM are not a good idea...
--
To view, visit https://review.coreboot.org/c/coreboot/+/54730
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id67f31d28b0566bfe73f48af9f87375f47cb4fe1
Gerrit-Change-Number: 54730
Gerrit-PatchSet: 1
Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Comment-Date: Fri, 28 May 2021 11:38:07 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment