Hello Martin Roth, Patrick Georgi,
I'd like you to do a code review. Please visit
https://review.coreboot.org/c/coreboot/+/48679
to review the following change.
Change subject: util: pull in Kconfiglib
......................................................................
util: pull in Kconfiglib
Pull in Kconfiglib 14.1 release to the util directory.
Signed-off-by: Jack Rosenthal <jrosenth(a)chromium.org>
Change-Id: I118562ff5aaaa23501c329e2e4e98dc6d528f546
---
A util/Kconfiglib/.gitignore
A util/Kconfiglib/LICENSE.txt
A util/Kconfiglib/MANIFEST.in
A util/Kconfiglib/README.rst
A util/Kconfiglib/alldefconfig.py
A util/Kconfiglib/allmodconfig.py
A util/Kconfiglib/allnoconfig.py
A util/Kconfiglib/allyesconfig.py
A util/Kconfiglib/defconfig.py
A util/Kconfiglib/examples/Kmenuconfig
A util/Kconfiglib/examples/allnoconfig_walk.py
A util/Kconfiglib/examples/defconfig_oldconfig.py
A util/Kconfiglib/examples/dumpvars.py
A util/Kconfiglib/examples/eval_expr.py
A util/Kconfiglib/examples/find_symbol.py
A util/Kconfiglib/examples/help_grep.py
A util/Kconfiglib/examples/kconfiglib.py
A util/Kconfiglib/examples/list_undefined.py
A util/Kconfiglib/examples/menuconfig_example.py
A util/Kconfiglib/examples/merge_config.py
A util/Kconfiglib/examples/print_config_tree.py
A util/Kconfiglib/examples/print_sym_info.py
A util/Kconfiglib/examples/print_tree.py
A util/Kconfiglib/genconfig.py
A util/Kconfiglib/guiconfig.py
A util/Kconfiglib/kconfiglib.py
A util/Kconfiglib/listnewconfig.py
A util/Kconfiglib/makefile.patch
A util/Kconfiglib/menuconfig.py
A util/Kconfiglib/oldconfig.py
A util/Kconfiglib/olddefconfig.py
A util/Kconfiglib/savedefconfig.py
A util/Kconfiglib/setconfig.py
A util/Kconfiglib/setup.cfg
A util/Kconfiglib/setup.py
A util/Kconfiglib/tests/Kappend
A util/Kconfiglib/tests/Kassignable
A util/Kconfiglib/tests/Kchoice
A util/Kconfiglib/tests/Kdefconfig_existent
A util/Kconfiglib/tests/Kdefconfig_existent_but_n
A util/Kconfiglib/tests/Kdefconfig_nonexistent
A util/Kconfiglib/tests/Kdefconfig_srctree
A util/Kconfiglib/tests/Kdepcopy
A util/Kconfiglib/tests/Kdeploop0
A util/Kconfiglib/tests/Kdeploop1
A util/Kconfiglib/tests/Kdeploop10
A util/Kconfiglib/tests/Kdeploop2
A util/Kconfiglib/tests/Kdeploop3
A util/Kconfiglib/tests/Kdeploop4
A util/Kconfiglib/tests/Kdeploop5
A util/Kconfiglib/tests/Kdeploop6
A util/Kconfiglib/tests/Kdeploop7
A util/Kconfiglib/tests/Kdeploop8
A util/Kconfiglib/tests/Kdeploop9
A util/Kconfiglib/tests/Kdirdep
A util/Kconfiglib/tests/Kescape
A util/Kconfiglib/tests/Keval
A util/Kconfiglib/tests/Kexpr_items
A util/Kconfiglib/tests/Kheader
A util/Kconfiglib/tests/Khelp
A util/Kconfiglib/tests/Kifremoval
A util/Kconfiglib/tests/Kimply
A util/Kconfiglib/tests/Kinclude_path
A util/Kconfiglib/tests/Kinclude_path_sourced_1
A util/Kconfiglib/tests/Kinclude_path_sourced_2
A util/Kconfiglib/tests/Kitemlists
A util/Kconfiglib/tests/Klocation
A util/Kconfiglib/tests/Klocation_sourced
A util/Kconfiglib/tests/Kmainmenu
A util/Kconfiglib/tests/Kmenuconfig
A util/Kconfiglib/tests/Kmisc
A util/Kconfiglib/tests/Kmissingrsource
A util/Kconfiglib/tests/Kmissingsource
A util/Kconfiglib/tests/Korder
A util/Kconfiglib/tests/Kpreprocess
A util/Kconfiglib/tests/Krange
A util/Kconfiglib/tests/Krecursive1
A util/Kconfiglib/tests/Krecursive2
A util/Kconfiglib/tests/Kreferenced
A util/Kconfiglib/tests/Krelation
A util/Kconfiglib/tests/Krepr
A util/Kconfiglib/tests/Kstr
A util/Kconfiglib/tests/Kundef
A util/Kconfiglib/tests/Kuserfunctions
A util/Kconfiglib/tests/Kvisibility
A util/Kconfiglib/tests/config_indented
A util/Kconfiglib/tests/config_set_bool
A util/Kconfiglib/tests/config_set_string
A util/Kconfiglib/tests/defconfig_1
A util/Kconfiglib/tests/defconfig_2
A util/Kconfiglib/tests/empty
A util/Kconfiglib/tests/kconfigfunctions.py
A util/Kconfiglib/tests/reltest
A util/Kconfiglib/tests/sub/Kconfig_symlink_2
A util/Kconfiglib/tests/sub/Kconfig_symlink_3
A util/Kconfiglib/tests/sub/Klocation_grsourced1
A util/Kconfiglib/tests/sub/Klocation_grsourced2
A util/Kconfiglib/tests/sub/Klocation_gsourced1
A util/Kconfiglib/tests/sub/Klocation_gsourced2
A util/Kconfiglib/tests/sub/Klocation_rsourced
A util/Kconfiglib/tests/sub/defconfig_in_sub
A util/Kconfiglib/tests/sub/sub/Kconfig_symlink_1
A util/Kconfiglib/tests/symlink
A util/Kconfiglib/testsuite.py
M util/README.md
105 files changed, 21,873 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/79/48679/1
--
To view, visit https://review.coreboot.org/c/coreboot/+/48679
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I118562ff5aaaa23501c329e2e4e98dc6d528f546
Gerrit-Change-Number: 48679
Gerrit-PatchSet: 1
Gerrit-Owner: Jack Rosenthal <jrosenth(a)chromium.org>
Gerrit-Reviewer: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com>
Gerrit-MessageType: newchange
Hello Martin Roth, Patrick Georgi,
I'd like you to do a code review. Please visit
https://review.coreboot.org/c/coreboot/+/48678
to review the following change.
Change subject: kconfig: remove evaluation of hex values as a boolean
......................................................................
kconfig: remove evaluation of hex values as a boolean
In kconfig, hex values when evaluated as a boolean will always be "n".
Kconfiglib warns about this, whereas the C implementation just quitely
treated it as "n".
Remove the evaluation of hex values as a boolean to clear up the
warnings.
Signed-off-by: Jack Rosenthal <jrosenth(a)chromium.org>
Change-Id: I96fde326976cd338dab1846e3a18bd8d247b1639
---
M src/security/intel/stm/Kconfig
1 file changed, 2 insertions(+), 3 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/78/48678/1
diff --git a/src/security/intel/stm/Kconfig b/src/security/intel/stm/Kconfig
index 5286354..962f9ef 100644
--- a/src/security/intel/stm/Kconfig
+++ b/src/security/intel/stm/Kconfig
@@ -87,8 +87,7 @@
config STM_TTYS0_BASE
hex "stm uart"
- default TTYS0_BASE if TTYS0_BASE
- default 0x000
+ default TTYS0_BASE
help
Defines the serial port for STM console output. 0x000 indicates
no serial port.
@@ -105,7 +104,7 @@
config STM_CONSOLE_DEBUG
bool "Debug output"
- depends on STM_CBMEM_CONSOLE || STM_TTYS0_BASE
+ depends on STM_CBMEM_CONSOLE
help
"Produces all STM console output"
--
To view, visit https://review.coreboot.org/c/coreboot/+/48678
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I96fde326976cd338dab1846e3a18bd8d247b1639
Gerrit-Change-Number: 48678
Gerrit-PatchSet: 1
Gerrit-Owner: Jack Rosenthal <jrosenth(a)chromium.org>
Gerrit-Reviewer: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com>
Gerrit-MessageType: newchange
Jack Rosenthal has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/48720 )
Change subject: kconfig: use "osource" for site-local/Kconfig
......................................................................
kconfig: use "osource" for site-local/Kconfig
This file is optional. Using osource, which was added in the parent
commit (see the parent commit message for a bit more explanation).
Signed-off-by: Jack Rosenthal <jrosenth(a)chromium.org>
Change-Id: I624d5f28746a5acc6725bc34adf5e262130219fc
---
M src/Kconfig
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/20/48720/1
diff --git a/src/Kconfig b/src/Kconfig
index 33065cb..61f976e 100644
--- a/src/Kconfig
+++ b/src/Kconfig
@@ -489,7 +489,7 @@
endmenu
# load site-local kconfig to allow user specific defaults and overrides
-source "site-local/Kconfig"
+osource "site-local/Kconfig"
config SYSTEM_TYPE_LAPTOP
default n
--
To view, visit https://review.coreboot.org/c/coreboot/+/48720
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I624d5f28746a5acc6725bc34adf5e262130219fc
Gerrit-Change-Number: 48720
Gerrit-PatchSet: 1
Gerrit-Owner: Jack Rosenthal <jrosenth(a)chromium.org>
Gerrit-MessageType: newchange
Arthur Heymans has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/35409 )
Change subject: [WIP]arch/arm: Allow program loading of Linux kernels
......................................................................
[WIP]arch/arm: Allow program loading of Linux kernels
On ARM the linux kernel takes 3 arguments:
r0 = 0
r1 = machine_type (0xffffffff if using FDT)
r2 = &fdt
To allow this, a function with a different signature needs to be used
when using a FIT payload.
Change-Id: Ie0dcc26d647941de71669345911ba288341b834b
Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz>
---
M src/arch/arm/boot.c
1 file changed, 16 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/09/35409/1
diff --git a/src/arch/arm/boot.c b/src/arch/arm/boot.c
index 9d1e4cd..fd7ba68 100644
--- a/src/arch/arm/boot.c
+++ b/src/arch/arm/boot.c
@@ -11,15 +11,29 @@
* GNU General Public License for more details.
*/
+#include <cbfs.h>
#include <arch/cache.h>
#include <program_loading.h>
void arch_prog_run(struct prog *prog)
{
void (*doit)(void *);
+ void (*doit_3)(void *, void *, void *);
+ char *program_arg = prog_entry_arg(prog);
cache_sync_instructions();
- doit = prog_entry(prog);
- doit(prog_entry_arg(prog));
+ /* The Linux kernel takes 3 dword's as argument */
+ switch (prog_cbfs_type(prog)) {
+ case CBFS_TYPE_FIT: /* Flattened image tree */
+ if (CONFIG(PAYLOAD_FIT_SUPPORT)) {
+ doit_3 = prog_entry(prog);
+ doit_3((void *)program_arg, (void *)(program_arg + sizeof(void *)),
+ (void *)(program_arg + 2 * sizeof(void *)));
+ break;
+ } /* else fall-through */
+ default:
+ doit = prog_entry(prog);
+ doit((void *)program_arg);
+ }
}
--
To view, visit https://review.coreboot.org/c/coreboot/+/35409
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie0dcc26d647941de71669345911ba288341b834b
Gerrit-Change-Number: 35409
Gerrit-PatchSet: 1
Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-MessageType: newchange