Rizwan Qureshi has uploaded this change for review. ( https://review.coreboot.org/c/vboot/+/32679
Change subject: vboot: Fix build error related to VB2_SHARED_DATA_VERSION_MINOR
......................................................................
vboot: Fix build error related to VB2_SHARED_DATA_VERSION_MINOR
vboot fails to compile with the error
"error: comparison is always false due to limited range
of data type [-Werror=type-limits]"
since struct_version_minor is uint16_t and can never be less than
VB2_SHARED_DATA_VERSION_MINOR (0)
Signed-off-by: Rizwan Qureshi <rizwan.qureshi(a)intel.com>
Change-Id: I0e68981fbecafe7ba40e00ee657e82c024a89325
---
M firmware/2lib/2misc.c
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/vboot refs/changes/79/32679/1
diff --git a/firmware/2lib/2misc.c b/firmware/2lib/2misc.c
index 95cbae3..195a0f9 100644
--- a/firmware/2lib/2misc.c
+++ b/firmware/2lib/2misc.c
@@ -128,7 +128,7 @@
return VB2_ERROR_SHARED_DATA_MAGIC;
if (sd->struct_version_major != VB2_SHARED_DATA_VERSION_MAJOR ||
- sd->struct_version_minor < VB2_SHARED_DATA_VERSION_MINOR)
+ sd->struct_version_minor != VB2_SHARED_DATA_VERSION_MINOR)
return VB2_ERROR_SHARED_DATA_VERSION;
return VB2_SUCCESS;
--
To view, visit https://review.coreboot.org/c/vboot/+/32679
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: vboot
Gerrit-Branch: master
Gerrit-Change-Id: I0e68981fbecafe7ba40e00ee657e82c024a89325
Gerrit-Change-Number: 32679
Gerrit-PatchSet: 1
Gerrit-Owner: Rizwan Qureshi <rizwan.qureshi(a)intel.com>
Gerrit-MessageType: newchange
Pablo Moyano has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/34105 )
Change subject: payloads/external/GRUB2/Makefile: Add ./bootstrap to fix build
......................................................................
payloads/external/GRUB2/Makefile: Add ./bootstrap to fix build
At some point between Grub 2.02 and 2.04, something was added
and it refuses to build without it.
Change-Id: Ia8fca13fe58be55aa4569ff58bbfd76ab7a67cdd
Signed-off-by: Pablo <42.pablo.ms(a)gmail.com>
---
M payloads/external/GRUB2/Makefile
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/05/34105/1
diff --git a/payloads/external/GRUB2/Makefile b/payloads/external/GRUB2/Makefile
index 31c4066..b036aeb 100644
--- a/payloads/external/GRUB2/Makefile
+++ b/payloads/external/GRUB2/Makefile
@@ -28,7 +28,7 @@
echo " CONFIG GRUB2 $(NAME-y)"
rm -rf grub2/build
mkdir grub2/build
- cd grub2 && ./autogen.sh
+ cd grub2 && ./bootstrap && ./autogen.sh
cd grub2/build && ../configure CC="$(HOSTCC)" LD="$(LD)" \
FREETYPE="pkg-config freetype2" BUILD_FREETYPE="pkg-config freetype2" \
TARGET_CC="$(CC)" TARGET_OBJCOPY="$(OBJCOPY)" TARGET_STRIP="$(STRIP)" \
--
To view, visit https://review.coreboot.org/c/coreboot/+/34105
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia8fca13fe58be55aa4569ff58bbfd76ab7a67cdd
Gerrit-Change-Number: 34105
Gerrit-PatchSet: 1
Gerrit-Owner: Pablo Moyano <42.pablo.ms(a)gmail.com>
Gerrit-MessageType: newchange