coreboot-gerrit December 2021

coreboot-gerrit@coreboot.org

1 participants
5525 discussions

Change in coreboot[master]: Makefile: Add util/kconfig/Makefile.real to nocompile list
by Patrick Georgi (Code Review) 08 Dec '21

08 Dec '21

Attention is currently required from: Martin Roth. Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59607 ) Change subject: Makefile: Add util/kconfig/Makefile.real to nocompile list ...................................................................... Patch Set 3: Code-Review+2 (1 comment) File Makefile: https://review.coreboot.org/c/coreboot/+/59607/comment/f8bcd86a_2efdf789 PS2, Line 110: and the make target tools > Correct. Thanks. Done -- To view, visit https://review.coreboot.org/c/coreboot/+/59607 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: If29c3a84c7c82ea099ef9610f4ecaa599f0d8649 Gerrit-Change-Number: 59607 Gerrit-PatchSet: 3 Gerrit-Owner: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Patrick Georgi <patrick(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Martin Roth <martinroth(a)google.com> Gerrit-Comment-Date: Wed, 08 Dec 2021 21:14:42 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Martin Roth <martinroth(a)google.com> Comment-In-Reply-To: Patrick Georgi <patrick(a)coreboot.org> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: Makefile: Add util/kconfig/Makefile.real to nocompile list
by Patrick Georgi (Code Review) 08 Dec '21

08 Dec '21

Patrick Georgi has uploaded a new patch set (#3) to the change originally created by Martin Roth. ( https://review.coreboot.org/c/coreboot/+/59607 ) Change subject: Makefile: Add util/kconfig/Makefile.real to nocompile list ...................................................................... Makefile: Add util/kconfig/Makefile.real to nocompile list Messages shown with the $(info Make command could be shown twice because the entire Makefile stack was evaluated twice at MAKELEVEL 0. The first time was to generate the build/util/kconfig/Makefile.real file. The second time was to do the rest of the build. Adding the kconfig Makefile.real file to the nocompile list prevents all the rest of the coreboot makefiles from being read in during that first step, which prevents the messages from being printed twice. You can see this behavior by running "make clean; make -d" and searching for the text: "Successfully remade target file 'build/util/kconfig/Makefile.real'." This breaks when the build target is 'tools', so add an exception for just that target. Signed-off-by: Martin Roth <gaumless(a)gmail.com> Change-Id: If29c3a84c7c82ea099ef9610f4ecaa599f0d8649 --- M Makefile 1 file changed, 11 insertions(+), 3 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/07/59607/3 -- To view, visit https://review.coreboot.org/c/coreboot/+/59607 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: If29c3a84c7c82ea099ef9610f4ecaa599f0d8649 Gerrit-Change-Number: 59607 Gerrit-PatchSet: 3 Gerrit-Owner: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Patrick Georgi <patrick(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: vendorcode/intel: Rework UDK binding Kconfig
by Subrata Banik (Code Review) 08 Dec '21

08 Dec '21

Subrata Banik has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/59985 ) Change subject: vendorcode/intel: Rework UDK binding Kconfig ...................................................................... vendorcode/intel: Rework UDK binding Kconfig coreboot code currently supports different UDK binding as per underlying FSP requirement, example: ICL and TGL uses UDK_2017_BINDING while ADL uses UDK_202005_BINDING Kconfig. These UDK binding Kconfigs are being used to choose the correct UDK_VERSION. This patch introduces `UDK_BASE` Kconfig option so UDK_VERSION if clause don't need to add specific UDK binding Kconfig everytime with introduction of newer UDK bindings in future. Tested with BUILD_TIMELESS=1, Hatch remains identical. Change-Id: I64c51aa06a14f0ce541537363870ac3925b79a68 Signed-off-by: Subrata Banik <subi.banik(a)gmail.com> --- M src/vendorcode/intel/Kconfig 1 file changed, 8 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/85/59985/1 diff --git a/src/vendorcode/intel/Kconfig b/src/vendorcode/intel/Kconfig index 6b7e495..87ef04e 100644 --- a/src/vendorcode/intel/Kconfig +++ b/src/vendorcode/intel/Kconfig @@ -1,18 +1,25 @@ ## SPDX-License-Identifier: GPL-2.0-only +config UEFI_BINDING_BASE + def_bool n + config UEFI_2_4_BINDING def_bool n + select UEFI_BINDING_BASE config UDK_2015_BINDING def_bool n + select UEFI_BINDING_BASE config UDK_2017_BINDING def_bool n + select UEFI_BINDING_BASE config UDK_202005_BINDING def_bool n + select UEFI_BINDING_BASE -if (UEFI_2_4_BINDING || UDK_2015_BINDING || UDK_2017_BINDING || UDK_202005_BINDING) +if UEFI_BINDING_BASE config UDK_2013_VERSION int default 2013 -- To view, visit https://review.coreboot.org/c/coreboot/+/59985 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I64c51aa06a14f0ce541537363870ac3925b79a68 Gerrit-Change-Number: 59985 Gerrit-PatchSet: 1 Gerrit-Owner: Subrata Banik <subi.banik(a)gmail.com> Gerrit-MessageType: newchange

1 0

Change in coreboot[master]: mb/google/brya4es: sync change from brya0 (CB:58374)
by YH Lin (Code Review) 08 Dec '21

08 Dec '21

Attention is currently required from: Felix Held. YH Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59935 ) Change subject: mb/google/brya4es: sync change from brya0 (CB:58374) ...................................................................... Patch Set 2: (1 comment) Patchset: PS2: Hopefully this looks better and clearer? Thanks. -- To view, visit https://review.coreboot.org/c/coreboot/+/59935 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I97489343b8f7a5b9457cd6f4a61cc37cd10ab450 Gerrit-Change-Number: 59935 Gerrit-PatchSet: 2 Gerrit-Owner: YH Lin <yueherngl(a)google.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Wed, 08 Dec 2021 20:47:52 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/brya4es: sync change from brya0 (CB:58374)
by YH Lin (Code Review) 08 Dec '21

08 Dec '21

Attention is currently required from: Felix Held. YH Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59935 ) Change subject: mb/google/brya4es: sync change from brya0 (CB:58374) ...................................................................... Patch Set 2: (1 comment) Patchset: PS1: > That is better 👍 […] Done -- To view, visit https://review.coreboot.org/c/coreboot/+/59935 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I97489343b8f7a5b9457cd6f4a61cc37cd10ab450 Gerrit-Change-Number: 59935 Gerrit-PatchSet: 2 Gerrit-Owner: YH Lin <yueherngl(a)google.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Wed, 08 Dec 2021 20:47:16 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Comment-In-Reply-To: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/brya4es: sync change from brya0 (CB:58374)
by YH Lin (Code Review) 08 Dec '21

08 Dec '21

Attention is currently required from: YH Lin, Felix Held. Hello build bot (Jenkins), Tim Wawrzynczak, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/59935 to look at the new patch set (#2). Change subject: mb/google/brya4es: sync change from brya0 (CB:58374) ...................................................................... mb/google/brya4es: sync change from brya0 (CB:58374) CB:58374 (for mb/google/brya0) was merged before brya4es is available (CB:59728). And since brya4es is forked from brya0, brya0's change need to be brought into brya4es as well. BUG=None TEST=build Signed-off-by: YH Lin <yueherngl(a)google.com> Change-Id: I97489343b8f7a5b9457cd6f4a61cc37cd10ab450 --- M src/mainboard/google/brya/variants/brya4es/overridetree.cb 1 file changed, 4 insertions(+), 3 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/35/59935/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/59935 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I97489343b8f7a5b9457cd6f4a61cc37cd10ab450 Gerrit-Change-Number: 59935 Gerrit-PatchSet: 2 Gerrit-Owner: YH Lin <yueherngl(a)google.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Attention: YH Lin <yueherngl(a)google.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: brya4es: sync CB:58374 from brya0
by Tim Wawrzynczak (Code Review) 08 Dec '21

08 Dec '21

Attention is currently required from: YH Lin, Felix Held. Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59935 ) Change subject: brya4es: sync CB:58374 from brya0 ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > forgot to mark this as not resolved That is better 👍 could also add that the original change was made before brya4es existed -- To view, visit https://review.coreboot.org/c/coreboot/+/59935 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I97489343b8f7a5b9457cd6f4a61cc37cd10ab450 Gerrit-Change-Number: 59935 Gerrit-PatchSet: 1 Gerrit-Owner: YH Lin <yueherngl(a)google.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Attention: YH Lin <yueherngl(a)google.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Wed, 08 Dec 2021 20:38:29 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: brya4es: sync CB:58374 from brya0
by Felix Held (Code Review) 08 Dec '21

08 Dec '21

Attention is currently required from: YH Lin. Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59935 ) Change subject: brya4es: sync CB:58374 from brya0 ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > would be good to improve the commit message; right now it doesn't really say what the patch is doing […] forgot to mark this as not resolved -- To view, visit https://review.coreboot.org/c/coreboot/+/59935 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I97489343b8f7a5b9457cd6f4a61cc37cd10ab450 Gerrit-Change-Number: 59935 Gerrit-PatchSet: 1 Gerrit-Owner: YH Lin <yueherngl(a)google.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Attention: YH Lin <yueherngl(a)google.com> Gerrit-Comment-Date: Wed, 08 Dec 2021 20:36:36 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: brya4es: sync CB:58374 from brya0
by Felix Held (Code Review) 08 Dec '21

08 Dec '21

Attention is currently required from: YH Lin. Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59935 ) Change subject: brya4es: sync CB:58374 from brya0 ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: would be good to improve the commit message; right now it doesn't really say what the patch is doing without having to look up the other patch. Here in Gerrit it's just a click away, but in the git history it's not as easy to find that. maybe something like this: mb/google/brya4es: Update camera NVM parameters A similar change for mb/google/brya0 was done in CB:58374. -- To view, visit https://review.coreboot.org/c/coreboot/+/59935 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I97489343b8f7a5b9457cd6f4a61cc37cd10ab450 Gerrit-Change-Number: 59935 Gerrit-PatchSet: 1 Gerrit-Owner: YH Lin <yueherngl(a)google.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Attention: YH Lin <yueherngl(a)google.com> Gerrit-Comment-Date: Wed, 08 Dec 2021 20:36:09 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/dedede/var/magolor: Add fw_config probe for multi codec and...
by Felix Held (Code Review) 08 Dec '21

08 Dec '21

Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/59865 ) Change subject: mb/google/dedede/var/magolor: Add fw_config probe for multi codec and amplifier ...................................................................... mb/google/dedede/var/magolor: Add fw_config probe for multi codec and amplifier Compatible headphone codec "ALC5682I-VS" and speaker amplifier "ALC1015Q-VB" BUG=b:208912135 TEST=ALC5682I-VD and ALC1015Q-VB can work normally Signed-off-by: Tyler Wang <tyler.wang(a)quanta.corp-partner.google.com> Change-Id: Id661280061ede3fbb63c962dee8fb18a2053ad66 Reviewed-on: https://review.coreboot.org/c/coreboot/+/59865 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Paul Menzel <paulepanter(a)mailbox.org> Reviewed-by: Karthik Ramasubramanian <kramasub(a)google.com> --- M src/mainboard/google/dedede/variants/magolor/overridetree.cb 1 file changed, 30 insertions(+), 3 deletions(-) Approvals: build bot (Jenkins): Verified Paul Menzel: Looks good to me, but someone else must approve Karthik Ramasubramanian: Looks good to me, approved diff --git a/src/mainboard/google/dedede/variants/magolor/overridetree.cb b/src/mainboard/google/dedede/variants/magolor/overridetree.cb index 24b32db..e5d75b1 100644 --- a/src/mainboard/google/dedede/variants/magolor/overridetree.cb +++ b/src/mainboard/google/dedede/variants/magolor/overridetree.cb @@ -25,6 +25,7 @@ option AUDIO_CODEC_UNPROVISIONED 0 option AUDIO_CODEC_DA7219 1 option AUDIO_CODEC_RT5682 2 + option AUDIO_CODEC_ALC5682I_VS 3 end end @@ -472,19 +473,45 @@ end end chip drivers/i2c/generic + register "hid" = ""RTL5682"" + register "name" = ""RT58"" + register "desc" = ""Realtek RT5682"" + register "irq_gpio" = "ACPI_GPIO_IRQ_EDGE_BOTH(GPP_D16)" + register "property_count" = "1" + register "property_list[0].type" = "ACPI_DP_TYPE_INTEGER" + register "property_list[0].name" = ""realtek,jd-src"" + register "property_list[0].integer" = "1" + device i2c 1a on + probe AUDIO_CODEC_SOURCE AUDIO_CODEC_ALC5682I_VS + end + end + chip drivers/i2c/generic register "hid" = ""10EC1015"" register "desc" = ""Realtek SPK AMP L"" register "uid" = "0" - device i2c 28 on end + device i2c 28 on + probe AUDIO_AMP UNPROVISIONED + probe AUDIO_AMP RT1015_I2C + end end chip drivers/i2c/generic register "hid" = ""10EC1015"" register "desc" = ""Realtek SPK AMP R"" register "uid" = "1" - device i2c 29 on end + device i2c 29 on + probe AUDIO_AMP UNPROVISIONED + probe AUDIO_AMP RT1015_I2C + end end end - device pci 1f.3 on end # Intel HDA + device pci 1f.3 on + chip drivers/generic/alc1015 + register "sdb" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPP_D17)" + device generic 0 on + probe AUDIO_AMP RT1015P_AUTO + end + end + end # Intel HDA device pci 1c.7 on chip drivers/wifi/generic register "wake" = "GPE0_DW2_03" -- To view, visit https://review.coreboot.org/c/coreboot/+/59865 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id661280061ede3fbb63c962dee8fb18a2053ad66 Gerrit-Change-Number: 59865 Gerrit-PatchSet: 3 Gerrit-Owner: Tyler Wang <tyler.wang(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Henry Sun <henrysun(a)google.com> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Paul Fagerburg <pfagerburg(a)chromium.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: Shou-Chieh Hsu <shouchieh(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: David Wu <david_wu(a)quanta.corp-partner.google.com> Gerrit-CC: Ren Kuo <ren.kuo(a)quanta.corp-partner.google.com> Gerrit-MessageType: merged

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit December 2021