Attention is currently required from: Paul Menzel, Ren Kuo, Karthik Ramasubramanian, Karthikeyan Ramasubramanian.
Kenneth Chan has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59975 )
Change subject: mb/google/guybrush/var/dewatt: Add Elan touchscreen
......................................................................
Patch Set 6:
(1 comment)
File src/mainboard/google/guybrush/variants/dewatt/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/59975/comment/8e4d8464_01b04570
PS2, Line 67: register "generic.stop_delay_ms" = "280"
> This is an extremely large delay that is going to show up in Resume time. […]
that's ok.
--
To view, visit https://review.coreboot.org/c/coreboot/+/59975
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I28a7f5891e09ffa393c93881be68641d955efdf8
Gerrit-Change-Number: 59975
Gerrit-PatchSet: 6
Gerrit-Owner: Kenneth Chan <kenneth.chan(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: Bhanu Prakash Maiya <bhanumaiya(a)google.com>
Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Reviewer: Karthikeyan Ramasubramanian <kramasub(a)chromium.org>
Gerrit-Reviewer: Ren Kuo <ren.kuo(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: Rob Barnes <robbarnes(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Ren Kuo <ren.kuo(a)quanta.corp-partner.google.com>
Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Attention: Karthikeyan Ramasubramanian <kramasub(a)chromium.org>
Gerrit-Comment-Date: Fri, 10 Dec 2021 10:56:29 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-MessageType: comment
Attention is currently required from: Felix Singer, Michał Żygowski, Frans Hendriks, Julius Werner, Arthur Heymans, Wim Vervoorn.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52025 )
Change subject: vc/eltan/security/verified_boot/vboot_check.c: Add cbfs_map_compressed()
......................................................................
Patch Set 3:
(1 comment)
File src/vendorcode/eltan/security/verified_boot/vboot_check.c:
https://review.coreboot.org/c/coreboot/+/52025/comment/4f52ba7d_bcdbe0a8
PS3, Line 6: #include <cbfs_private.h>
Is this needed?
--
To view, visit https://review.coreboot.org/c/coreboot/+/52025
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Idc799f49ee198100deab1ecf66336831d9aed415
Gerrit-Change-Number: 52025
Gerrit-PatchSet: 3
Gerrit-Owner: Frans Hendriks <fhendriks(a)eltan.com>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org>
Gerrit-Reviewer: Michał Żygowski <michal.zygowski(a)3mdeb.com>
Gerrit-Reviewer: Wim Vervoorn <wvervoorn(a)eltan.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Attention: Michał Żygowski <michal.zygowski(a)3mdeb.com>
Gerrit-Attention: Frans Hendriks <fhendriks(a)eltan.com>
Gerrit-Attention: Julius Werner <jwerner(a)chromium.org>
Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Attention: Wim Vervoorn <wvervoorn(a)eltan.com>
Gerrit-Comment-Date: Fri, 10 Dec 2021 10:37:35 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Ravindra has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59895 )
Change subject: soc/intel/cse: config to enable oem key manifest
......................................................................
Patch Set 8:
(1 comment)
File src/soc/intel/common/block/cse/Kconfig:
https://review.coreboot.org/c/coreboot/+/59895/comment/7f36f7a6_004db656
PS8, Line 184: KM file
> What is the KM file? Please send a follow-up patch adding a help text, explaining what the KM file i […]
i have uploaded the follow up patch
https://review.coreboot.org/c/coreboot/+/60020
--
To view, visit https://review.coreboot.org/c/coreboot/+/59895
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3620adb2898efc002104e0ba8b2afd219c31f230
Gerrit-Change-Number: 59895
Gerrit-PatchSet: 8
Gerrit-Owner: Ravindra <ravindra(a)intel.com>
Gerrit-Reviewer: Krishna P Bhat D <krishna.p.bhat.d(a)intel.com>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com>
Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Reviewer: Ravindra N <ravindra(a)intel.corp-partner.google.com>
Gerrit-Reviewer: Sridhar Siricilla <sridhar.siricilla(a)intel.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: 9elements QA <hardwaretestrobot(a)gmail.com>
Gerrit-CC: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Comment-Date: Fri, 10 Dec 2021 10:27:27 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-MessageType: comment