coreboot-gerrit December 2021

coreboot-gerrit@coreboot.org

1 participants
5525 discussions

Change in coreboot[master]: mb/google/guybrush/var/dewatt: Add Elan touchscreen
by Rob Barnes (Code Review) 10 Dec '21

10 Dec '21

Attention is currently required from: Paul Menzel, Ren Kuo, Kenneth Chan, Karthik Ramasubramanian, Karthikeyan Ramasubramanian. Rob Barnes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59975 ) Change subject: mb/google/guybrush/var/dewatt: Add Elan touchscreen ...................................................................... Patch Set 6: (1 comment) File src/mainboard/google/guybrush/variants/dewatt/overridetree.cb: https://review.coreboot.org/c/coreboot/+/59975/comment/66370fc1_10476d0b PS2, Line 67: register "generic.stop_delay_ms" = "280" > that's ok. Long resume time is not OK. Please measure resume time impact of this touchscreen. I suggest also reviewing these delays with ELAN to determine if they can be reduced. -- To view, visit https://review.coreboot.org/c/coreboot/+/59975 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I28a7f5891e09ffa393c93881be68641d955efdf8 Gerrit-Change-Number: 59975 Gerrit-PatchSet: 6 Gerrit-Owner: Kenneth Chan <kenneth.chan(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Bhanu Prakash Maiya <bhanumaiya(a)google.com> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Karthikeyan Ramasubramanian <kramasub(a)chromium.org> Gerrit-Reviewer: Kenneth Chan <kenneth.chan(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Ren Kuo <ren.kuo(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Rob Barnes <robbarnes(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Ren Kuo <ren.kuo(a)quanta.corp-partner.google.com> Gerrit-Attention: Kenneth Chan <kenneth.chan(a)quanta.corp-partner.google.com> Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Attention: Karthikeyan Ramasubramanian <kramasub(a)chromium.org> Gerrit-Comment-Date: Fri, 10 Dec 2021 18:23:38 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Kenneth Chan <kenneth.chan(a)quanta.corp-partner.google.com> Comment-In-Reply-To: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: cbfstool: Do host space address conversion earlier when adding files
by Tim Wawrzynczak (Code Review) 10 Dec '21

10 Dec '21

Attention is currently required from: Patrick Georgi, Paul Menzel, Julius Werner. Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60018 ) Change subject: cbfstool: Do host space address conversion earlier when adding files ...................................................................... Patch Set 4: Code-Review+2 (1 comment) File util/cbfstool/cbfstool.c: https://review.coreboot.org/c/coreboot/+/60018/comment/3c5d4d29_96498744 PS3, Line 1052: offset > Well, |offset| is how it's called in all these functions (except for convert_region_offset() which i […] I agree with Julius, it's probably something that needs fixing wholesale or not, otherwise it may just makes things more confusing 😞 -- To view, visit https://review.coreboot.org/c/coreboot/+/60018 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Idf4721c5b0700789ddb81c1618d740b3e7f486cb Gerrit-Change-Number: 60018 Gerrit-PatchSet: 4 Gerrit-Owner: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Patrick Georgi <patrick(a)coreboot.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Patrick Georgi <patrick(a)coreboot.org> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Comment-Date: Fri, 10 Dec 2021 18:16:51 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Raul Rangel <rrangel(a)chromium.org> Comment-In-Reply-To: Julius Werner <jwerner(a)chromium.org> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/dedede/var/lantis: Add fw_config probe for ALC5682-VD/ALC56...
by Karthik Ramasubramanian (Code Review) 10 Dec '21

10 Dec '21

Attention is currently required from: Henry Sun, Chen Wisley, Wisley Chen. Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59353 ) Change subject: mb/google/dedede/var/lantis: Add fw_config probe for ALC5682-VD/ALC5682-VS ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/59353 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ie73dc376078c0836edd980e09629399c5cc19594 Gerrit-Change-Number: 59353 Gerrit-PatchSet: 2 Gerrit-Owner: Chen Wisley <wisley.chen(a)quantatw.com> Gerrit-Reviewer: Henry Sun <henrysun(a)google.com> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Wisley Chen <wisley.chen(a)quanta.corp-partner.google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Henry Sun <henrysun(a)google.com> Gerrit-Attention: Chen Wisley <wisley.chen(a)quantatw.com> Gerrit-Attention: Wisley Chen <wisley.chen(a)quanta.corp-partner.google.com> Gerrit-Comment-Date: Fri, 10 Dec 2021 18:08:25 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/guybrush/var/nipperkin: Override SPI fast speed
by Karthik Ramasubramanian (Code Review) 10 Dec '21

10 Dec '21

Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59983 ) Change subject: mb/google/guybrush/var/nipperkin: Override SPI fast speed ...................................................................... Patch Set 2: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/59983/comment/503f7ea0_0ee80bca PS2, Line 14: iterations of warm and cold reset each. > How much was the boottime improved? Same as in Guybrush - ~60 ms. This CL was just waiting for the signal integrity to be checked. -- To view, visit https://review.coreboot.org/c/coreboot/+/59983 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id973acb939b69e0beda26252e57a278892f2f57d Gerrit-Change-Number: 59983 Gerrit-PatchSet: 2 Gerrit-Owner: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Jon Murphy <jpmurphy(a)google.com> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: Rob Barnes <robbarnes(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: 9elements QA <hardwaretestrobot(a)gmail.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Comment-Date: Fri, 10 Dec 2021 18:06:43 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: libpayload: Add boot_device_read() function
by Julius Werner (Code Review) 10 Dec '21

10 Dec '21

Julius Werner has submitted this change. ( https://review.coreboot.org/c/coreboot/+/59492 ) Change subject: libpayload: Add boot_device_read() function ...................................................................... libpayload: Add boot_device_read() function This patch adds a new way of implementing flash access for libpayload. Until now all reads had to be performed using cbfs_media, which is obsolete. From now on all reads should be performed using boot_device_read(). This patch also provides a default implementation of boot_device_read() for x86 architecture. Change-Id: I1babd2a8414ed9de3ca49903fcb4f036997b5ff3 Signed-off-by: Jakub Czapiga <jacz(a)semihalf.com> Reviewed-on: https://review.coreboot.org/c/coreboot/+/59492 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Julius Werner <jwerner(a)chromium.org> --- A payloads/libpayload/arch/x86/boot_media.c A payloads/libpayload/include/boot_device.h 2 files changed, 39 insertions(+), 0 deletions(-) Approvals: build bot (Jenkins): Verified Julius Werner: Looks good to me, approved diff --git a/payloads/libpayload/arch/x86/boot_media.c b/payloads/libpayload/arch/x86/boot_media.c new file mode 100644 index 0000000..ce02832 --- /dev/null +++ b/payloads/libpayload/arch/x86/boot_media.c @@ -0,0 +1,17 @@ +/* SPDX-License-Identifier: BSD-3-Clause */ + +#include <boot_device.h> +#include <commonlib/bsd/cb_err.h> +#include <stddef.h> +#include <string.h> +#include <sysinfo.h> + +__attribute__((weak)) ssize_t boot_device_read(void *buf, size_t offset, size_t size) +{ + /* Memory-mapping usually only works for the top 16MB. */ + if (!lib_sysinfo.boot_media_size || lib_sysinfo.boot_media_size - offset > 16 * MiB) + return CB_ERR_ARG; + void *ptr = (void *)(uintptr_t)(0 - lib_sysinfo.boot_media_size + offset); + memcpy(buf, ptr, size); + return size; +} diff --git a/payloads/libpayload/include/boot_device.h b/payloads/libpayload/include/boot_device.h new file mode 100644 index 0000000..a946545 --- /dev/null +++ b/payloads/libpayload/include/boot_device.h @@ -0,0 +1,22 @@ +/* SPDX-License-Identifier: BSD-3-Clause */ + +#ifndef _BOOT_DEVICE_H +#define _BOOT_DEVICE_H + +#include <stddef.h> + +/** + * This is a boot device access function, which is used by libpayload to read data from + * the flash memory (or other boot device). It has to be implemented by payloads that want + * to use FMAP or libcbfs. + * + * @param buf The output buffer to which the data should be written to. + * @param offset Absolute offset in bytes of the requested boot device memory area. Not aligned. + * @param size Size in bytes of the requested boot device memory area. Not aligned. + * + * @returns Number of bytes returned to the buffer, or negative value on error. Typically should + * be equal to the `size`, and not aligned forcefully. + */ +ssize_t boot_device_read(void *buf, size_t offset, size_t size); + +#endif /* _BOOT_DEVICE_H */ 6 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. -- To view, visit https://review.coreboot.org/c/coreboot/+/59492 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1babd2a8414ed9de3ca49903fcb4f036997b5ff3 Gerrit-Change-Number: 59492 Gerrit-PatchSet: 9 Gerrit-Owner: Jakub Czapiga <jacz(a)semihalf.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Patrick Georgi <patrick(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: merged

1 0

Change in coreboot[master]: cbfstool: Do host space address conversion earlier when adding files
by Julius Werner (Code Review) 10 Dec '21

10 Dec '21

Attention is currently required from: Patrick Georgi, Paul Menzel, Tim Wawrzynczak. Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60018 ) Change subject: cbfstool: Do host space address conversion earlier when adding files ...................................................................... Patch Set 3: (4 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/60018/comment/f65a8bef_36a77181 PS3, Line 11: but > by? Done https://review.coreboot.org/c/coreboot/+/60018/comment/8aa54a65_8d21cd85 PS3, Line 21: CB:59877 > Could you please also use the commit hash and summary? ...why? I thought this is what we have the CB:xxx shorthand for? I find it nice that citing another patch (especially when it's more than one) doesn't always take up multiple lines in the commit message. File util/cbfstool/cbfstool.c: https://review.coreboot.org/c/coreboot/+/60018/comment/48c3e1dd_beae3c93 PS3, Line 813: offset > If I'm reading this right, this assumes a flash_offset is always passed in right? I don't see anythi […] No, this is actually the function where |offset| is treated purely as an out parameter (don't confuse convert_region_offset() with convert_addr_space()... some of the naming in here could probably use some cleaning up). It doesn't matter what you pass in here (and on passing back out I believe(?) it's always flash address space, but just to be sure I left the initial conversion after this point in the code flow. https://review.coreboot.org/c/coreboot/+/60018/comment/567513dc_e9f79f88 PS3, Line 1052: offset > One thing you could do to make this easier to read is rename `offset` to `flash_offset`, and `addres […] Well, |offset| is how it's called in all these functions (except for convert_region_offset() which is also super confusing), I wouldn't want to change it here without changing it everywhere -- To view, visit https://review.coreboot.org/c/coreboot/+/60018 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Idf4721c5b0700789ddb81c1618d740b3e7f486cb Gerrit-Change-Number: 60018 Gerrit-PatchSet: 3 Gerrit-Owner: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Patrick Georgi <patrick(a)coreboot.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Patrick Georgi <patrick(a)coreboot.org> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Comment-Date: Fri, 10 Dec 2021 17:47:13 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Raul Rangel <rrangel(a)chromium.org> Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: cbfstool: Do host space address conversion earlier when adding files
by Julius Werner (Code Review) 10 Dec '21

10 Dec '21

Attention is currently required from: Patrick Georgi, Tim Wawrzynczak, Julius Werner. Hello build bot (Jenkins), Raul Rangel, Patrick Georgi, Paul Menzel, Tim Wawrzynczak, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/60018 to look at the new patch set (#4). Change subject: cbfstool: Do host space address conversion earlier when adding files ...................................................................... cbfstool: Do host space address conversion earlier when adding files In cbfs_add_component(), the |offset| variable confusingly jumps back and forth between host address space and flash address space in some cases. This patch tries to clean that logic up a bit by converting it to flash address space very early in the function, and then keeping it that way afterwards. convert() implementations that need the host address space value should store it in a different variable to reduce the risk of confusion. This should also fix a tiny issue where --gen-attribute might have previously encoded the base address as given in CBFS -- it probably makes more sense to always have it store a consistent format (i.e. always flash address). Also revert the unnecessary check for --base-address in add_topswap_bootblock() that was added in CB:59877. On closer inspection, the function actually doesn't use the passed in *offset at all and uses it purely as an out-parameter. So while our current Makefile does pass --base-address when adding the bootblock, it actually has no effect and is redundant for the topswap case. Signed-off-by: Julius Werner <jwerner(a)chromium.org> Change-Id: Idf4721c5b0700789ddb81c1618d740b3e7f486cb --- M util/cbfstool/cbfstool.c 1 file changed, 16 insertions(+), 24 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/18/60018/4 -- To view, visit https://review.coreboot.org/c/coreboot/+/60018 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Idf4721c5b0700789ddb81c1618d740b3e7f486cb Gerrit-Change-Number: 60018 Gerrit-PatchSet: 4 Gerrit-Owner: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Patrick Georgi <patrick(a)coreboot.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Patrick Georgi <patrick(a)coreboot.org> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: cbfstool: Do host space address conversion earlier when adding files
by Raul Rangel (Code Review) 10 Dec '21

10 Dec '21

Attention is currently required from: Patrick Georgi, Tim Wawrzynczak, Julius Werner. Raul Rangel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60018 ) Change subject: cbfstool: Do host space address conversion earlier when adding files ...................................................................... Patch Set 3: Code-Review+2 (3 comments) File util/cbfstool/cbfstool.c: https://review.coreboot.org/c/coreboot/+/60018/comment/b6783895_eaba3329 PS2, Line 1078: offset > Fixed, thank you! I commented on this part in your previous CL because I misread the intention. Guessing that's what sparked this CL. File util/cbfstool/cbfstool.c: https://review.coreboot.org/c/coreboot/+/60018/comment/03e7ce7b_a8009ccc PS3, Line 813: offset If I'm reading this right, this assumes a flash_offset is always passed in right? I don't see anything validating this assumption. https://review.coreboot.org/c/coreboot/+/60018/comment/23f6c724_722b7a98 PS3, Line 1052: offset One thing you could do to make this easier to read is rename `offset` to `flash_offset`, and `address` to `host_address`. That way there is no confusing the two values. -- To view, visit https://review.coreboot.org/c/coreboot/+/60018 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Idf4721c5b0700789ddb81c1618d740b3e7f486cb Gerrit-Change-Number: 60018 Gerrit-PatchSet: 3 Gerrit-Owner: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Patrick Georgi <patrick(a)coreboot.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Patrick Georgi <patrick(a)coreboot.org> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Comment-Date: Fri, 10 Dec 2021 16:24:29 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Raul Rangel <rrangel(a)chromium.org> Comment-In-Reply-To: Julius Werner <jwerner(a)chromium.org> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/facebook/fbg1701: Remove ONBOARD_SAMSUNG_MEM
by Felix Held (Code Review) 10 Dec '21

10 Dec '21

Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59754 ) Change subject: mb/facebook/fbg1701: Remove ONBOARD_SAMSUNG_MEM ...................................................................... Patch Set 4: (1 comment) Patchset: PS4: oh, between revision 2 and 3 the part f the change that removed the now unused ONBOARD_SAMSUNG_MEM Kconfig option got dropped; would be good if you can remove the unused option in a follow-up patch -- To view, visit https://review.coreboot.org/c/coreboot/+/59754 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I21b5ddc430410a1e8b3e9012d0c07d278880ff47 Gerrit-Change-Number: 59754 Gerrit-PatchSet: 4 Gerrit-Owner: Frans Hendriks <fhendriks(a)eltan.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: Wim Vervoorn <wvervoorn(a)eltan.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: 9elements QA <hardwaretestrobot(a)gmail.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Comment-Date: Fri, 10 Dec 2021 16:11:18 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: cpu/x86/mp_init.c: Make it work for !CONFIG_SMP
by Felix Held (Code Review) 10 Dec '21

10 Dec '21

Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/59692 ) Change subject: cpu/x86/mp_init.c: Make it work for !CONFIG_SMP ...................................................................... cpu/x86/mp_init.c: Make it work for !CONFIG_SMP With very little changes this code can be used to initialize systems without SMP. The linker will remove most of the code. Change-Id: Ia0e8fdf8ed7bc2e0e4ff01be8d3e3c3cb837e6c7 Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz> Reviewed-on: https://review.coreboot.org/c/coreboot/+/59692 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Paul Menzel <paulepanter(a)mailbox.org> Reviewed-by: Angel Pons <th3fanbus(a)gmail.com> --- M src/cpu/x86/Kconfig M src/cpu/x86/mp_init.c 2 files changed, 6 insertions(+), 1 deletion(-) Approvals: build bot (Jenkins): Verified Paul Menzel: Looks good to me, but someone else must approve Angel Pons: Looks good to me, approved diff --git a/src/cpu/x86/Kconfig b/src/cpu/x86/Kconfig index 693b802..13ff65d 100644 --- a/src/cpu/x86/Kconfig +++ b/src/cpu/x86/Kconfig @@ -1,12 +1,13 @@ config PARALLEL_MP def_bool y depends on !LEGACY_SMP_INIT - depends on SMP select CPU_INFO_V2 help This option uses common MP infrastructure for bringing up APs in parallel. It additionally provides a more flexible mechanism for sequencing the steps of bringing up the APs. + The code also works for just initialising the BSP in case there + are no APs. config PARALLEL_MP_AP_WORK def_bool n diff --git a/src/cpu/x86/mp_init.c b/src/cpu/x86/mp_init.c index 507b5fe..acbe579 100644 --- a/src/cpu/x86/mp_init.c +++ b/src/cpu/x86/mp_init.c @@ -593,6 +593,10 @@ return CB_ERR; } + /* We just need to run things on the BSP */ + if (!CONFIG(SMP)) + return bsp_do_flight_plan(p); + /* Default to currently running CPU. */ num_cpus = allocate_cpu_devices(cpu_bus, p); -- To view, visit https://review.coreboot.org/c/coreboot/+/59692 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia0e8fdf8ed7bc2e0e4ff01be8d3e3c3cb837e6c7 Gerrit-Change-Number: 59692 Gerrit-PatchSet: 4 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Arthur Heymans <arthur.heymans(a)9elements.com> Gerrit-CC: Branden Waldner <scruffy99(a)gmail.com> Gerrit-CC: Keith Hui <buurin(a)gmail.com> Gerrit-MessageType: merged

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit December 2021