coreboot-gerrit December 2021

coreboot-gerrit@coreboot.org

1 participants
5525 discussions

Change in coreboot[master]: mb/google/volteer/var/collis: Add fw_config probe for ALC5682-VD & VS
by Frank Chu (Code Review) 28 Dec '21

28 Dec '21

Frank Chu has removed build bot (Jenkins) from this change. ( https://review.coreboot.org/c/coreboot/+/60415 ) Change subject: mb/google/volteer/var/collis: Add fw_config probe for ALC5682-VD & VS ...................................................................... Removed cc build bot (Jenkins). -- To view, visit https://review.coreboot.org/c/coreboot/+/60415 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia6089441dc1ba04c3f7427dda065b85bd295af0d Gerrit-Change-Number: 60415 Gerrit-PatchSet: 1 Gerrit-Owner: Frank Chu <frank_chu(a)pegatron.corp-partner.google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-CC: Daniel Peng <daniel_peng(a)pegatron.corp-partner.google.com> Gerrit-CC: Hank Lin <hank2_lin(a)pegatron.corp-partner.google.com> Gerrit-CC: Ken Lu <ken_lu(a)pegatron.corp-partner.google.com> Gerrit-MessageType: deleteReviewer

1 0

Change in coreboot[master]: mb/google/volteer/var/collis: Add fw_config probe for ALC5682-VD & VS
by build bot (Jenkins) (Code Review) 28 Dec '21

28 Dec '21

Attention is currently required from: Tim Wawrzynczak, Nick Vaccaro. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60415 ) Change subject: mb/google/volteer/var/collis: Add fw_config probe for ALC5682-VD & VS ...................................................................... Patch Set 1: (7 comments) File src/mainboard/google/volteer/variants/collis/overridetree.cb: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136372): https://review.coreboot.org/c/coreboot/+/60415/comment/3d306a56_9beefc8c PS1, Line 201: probe AUDIO MAX98373_ALC5682IVS_I2S_UP4 trailing whitespace File src/mainboard/google/volteer/variants/collis/variant.c: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136372): https://review.coreboot.org/c/coreboot/+/60415/comment/5cebc0cc_a6e73082 PS1, Line 8: struct device *codec = DEV_PTR(audio_codec); code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136372): https://review.coreboot.org/c/coreboot/+/60415/comment/deba3080_35346cb7 PS1, Line 8: struct device *codec = DEV_PTR(audio_codec); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136372): https://review.coreboot.org/c/coreboot/+/60415/comment/79c671f1_a28e63c8 PS1, Line 9: struct drivers_i2c_generic_config *config; code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136372): https://review.coreboot.org/c/coreboot/+/60415/comment/790e7c52_4f9e5513 PS1, Line 9: struct drivers_i2c_generic_config *config; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136372): https://review.coreboot.org/c/coreboot/+/60415/comment/7a20c074_6c75648a PS1, Line 11: config = codec->chip_info; code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136372): https://review.coreboot.org/c/coreboot/+/60415/comment/2e8cb843_508fcdc7 PS1, Line 11: config = codec->chip_info; please, no spaces at the start of a line -- To view, visit https://review.coreboot.org/c/coreboot/+/60415 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia6089441dc1ba04c3f7427dda065b85bd295af0d Gerrit-Change-Number: 60415 Gerrit-PatchSet: 1 Gerrit-Owner: Frank Chu <frank_chu(a)pegatron.corp-partner.google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Comment-Date: Tue, 28 Dec 2021 08:04:47 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/volteer/var/collis: Add fw_config probe for ALC5682-VD & VS
by Frank Chu (Code Review) 28 Dec '21

28 Dec '21

Frank Chu has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/60415 ) Change subject: mb/google/volteer/var/collis: Add fw_config probe for ALC5682-VD & VS ...................................................................... mb/google/volteer/var/collis: Add fw_config probe for ALC5682-VD & VS ALC5682-VD/ALC5682I-VS load different kernel driver by different hid name. Update hid name depending on the AUDIO_CODEC_SOURCE field of fw_config. Define FW_CONFIG bits 41 - 43 (SSFC bits 9 - 11) for codec selection. ALC5682-VD: _HID = "10EC5682" ALC5682I-VS: _HID = "RTL5682" BUG=b:192535692 TEST=ALC5682-VD/ALC5682I-VS audio codec can work Signed-off-by: FrankChu <frank_chu(a)pegatron.corp-partner.google.com> Change-Id: Ia6089441dc1ba04c3f7427dda065b85bd295af0d --- M src/mainboard/google/volteer/Kconfig M src/mainboard/google/volteer/variants/collis/Makefile.inc M src/mainboard/google/volteer/variants/collis/overridetree.cb A src/mainboard/google/volteer/variants/collis/variant.c 4 files changed, 35 insertions(+), 3 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/15/60415/1 diff --git a/src/mainboard/google/volteer/Kconfig b/src/mainboard/google/volteer/Kconfig index 0c77a79..d3f48640 100644 --- a/src/mainboard/google/volteer/Kconfig +++ b/src/mainboard/google/volteer/Kconfig @@ -18,6 +18,7 @@ select DRIVERS_USB_ACPI select EC_GOOGLE_CHROMEEC select EC_GOOGLE_CHROMEEC_BOARDID + select EC_GOOGLE_CHROMEEC_INCLUDE_SSFC_IN_FW_CONFIG select EC_GOOGLE_CHROMEEC_SKUID select EC_GOOGLE_CHROMEEC_LPC select FW_CONFIG diff --git a/src/mainboard/google/volteer/variants/collis/Makefile.inc b/src/mainboard/google/volteer/variants/collis/Makefile.inc index 343c7db..2af91aa 100644 --- a/src/mainboard/google/volteer/variants/collis/Makefile.inc +++ b/src/mainboard/google/volteer/variants/collis/Makefile.inc @@ -5,3 +5,5 @@ bootblock-y += gpio.c ramstage-y += gpio.c + +ramstage-y += variant.c diff --git a/src/mainboard/google/volteer/variants/collis/overridetree.cb b/src/mainboard/google/volteer/variants/collis/overridetree.cb index 3323bdf..d89e526 100644 --- a/src/mainboard/google/volteer/variants/collis/overridetree.cb +++ b/src/mainboard/google/volteer/variants/collis/overridetree.cb @@ -1,3 +1,10 @@ +fw_config + field AUDIO_CODEC_SOURCE 41 43 + option AUDIO_CODEC_UNPROVISIONED 0 + option AUDIO_CODEC_ALC5682 1 + option AUDIO_CODEC_ALC5682I_VS 2 + end +end chip soc/intel/tigerlake # BitMask where bits [3:0] are Controller 0 Channel [3:0] and # bits [7:4] are Controller 1 Channel [3:0]. @@ -93,7 +100,7 @@ end device ref i2c0 on chip drivers/i2c/generic - register "hid" = ""10EC5682"" + # register "hid" is set in variants.c because of FW_CONFIG register "name" = ""RT58"" register "desc" = ""Headset Codec"" register "irq_gpio" = "ACPI_GPIO_IRQ_EDGE_BOTH(GPP_R5)" @@ -102,8 +109,7 @@ register "property_list[0].type" = "ACPI_DP_TYPE_INTEGER" register "property_list[0].name" = ""realtek,jd-src"" register "property_list[0].integer" = "1" - device i2c 1a on - end + device i2c 1a alias audio_codec on end end chip drivers/i2c/max98373 register "vmon_slot_no" = "0" @@ -113,6 +119,7 @@ register "name" = ""MAXR"" device i2c 31 on probe AUDIO MAX98373_ALC5682I_I2S_UP4 + probe AUDIO MAX98373_ALC5682IVS_I2S_UP4 end end chip drivers/i2c/max98373 @@ -123,6 +130,7 @@ register "name" = ""MAXL"" device i2c 32 on probe AUDIO MAX98373_ALC5682I_I2S_UP4 + probe AUDIO MAX98373_ALC5682IVS_I2S_UP4 end end end @@ -190,6 +198,7 @@ probe AUDIO MAX98373_ALC5682_SNDW probe AUDIO MAX98373_ALC5682I_I2S_UP4 probe AUDIO MAX98360_ALC5682I_I2S + probe AUDIO MAX98373_ALC5682IVS_I2S_UP4 end device ref pcie_rp9 on chip soc/intel/common/block/pcie/rtd3 diff --git a/src/mainboard/google/volteer/variants/collis/variant.c b/src/mainboard/google/volteer/variants/collis/variant.c new file mode 100644 index 0000000..6b06cba --- /dev/null +++ b/src/mainboard/google/volteer/variants/collis/variant.c @@ -0,0 +1,20 @@ +#include <baseboard/variants.h> +#include <fw_config.h> +#include <drivers/i2c/hid/chip.h> +#include <device/device.h> + +static void audio_codec_update(void) +{ + struct device *codec = DEV_PTR(audio_codec); + struct drivers_i2c_generic_config *config; + + config = codec->chip_info; + if (fw_config_probe(FW_CONFIG(AUDIO_CODEC_SOURCE, AUDIO_CODEC_ALC5682))) + config->hid = "10EC5682"; + else + config->hid = "RTL5682"; +} +void variant_devtree_update(void) +{ + audio_codec_update(); +} -- To view, visit https://review.coreboot.org/c/coreboot/+/60415 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia6089441dc1ba04c3f7427dda065b85bd295af0d Gerrit-Change-Number: 60415 Gerrit-PatchSet: 1 Gerrit-Owner: Frank Chu <frank_chu(a)pegatron.corp-partner.google.com> Gerrit-MessageType: newchange

1 0

Change in coreboot[master]: [TEST-ONLY] Uprev vboot to verify Jenkins will pass
by Hsuan-ting Chen (Code Review) 28 Dec '21

28 Dec '21

Hsuan-ting Chen has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/60414 ) Change subject: [TEST-ONLY] Uprev vboot to verify Jenkins will pass ...................................................................... Abandoned The experiment is failed and we do not need it anymore. -- To view, visit https://review.coreboot.org/c/coreboot/+/60414 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I9ca90d08bf9a5e2c871724260234c80471f11651 Gerrit-Change-Number: 60414 Gerrit-PatchSet: 1 Gerrit-Owner: Hsuan-ting Chen <roccochen(a)google.com> Gerrit-Reviewer: Hsuan Ting Chen <roccochen(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: abandon

1 0

Change in coreboot[master]: [TEST-ONLY] Uprev vboot to verify Jenkins will pass
by Hsuan-ting Chen (Code Review) 28 Dec '21

28 Dec '21

Attention is currently required from: Hsuan Ting Chen. Hello Hsuan Ting Chen, I'd like you to do a code review. Please visit https://review.coreboot.org/c/coreboot/+/60414 to review the following change. Change subject: [TEST-ONLY] Uprev vboot to verify Jenkins will pass ...................................................................... [TEST-ONLY] Uprev vboot to verify Jenkins will pass Since crrev.com/c/3350299 is blocked by unstable CV, uprev to it first to verify if Jenkins will pass building coreboot with the fix in advance. Signed-off-by: Hsuan Ting Chen <roccochen(a)chromium.org> Change-Id: I9ca90d08bf9a5e2c871724260234c80471f11651 --- M 3rdparty/vboot 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/14/60414/1 diff --git a/3rdparty/vboot b/3rdparty/vboot index 13f601f..5ac127c 160000 --- a/3rdparty/vboot +++ b/3rdparty/vboot @@ -1 +1 @@ -Subproject commit 13f601fbd4c1b128f333391e4552082594f0ff25 +Subproject commit 5ac127c3bac6b8782eb70458d378c51c6d3060d6 -- To view, visit https://review.coreboot.org/c/coreboot/+/60414 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I9ca90d08bf9a5e2c871724260234c80471f11651 Gerrit-Change-Number: 60414 Gerrit-PatchSet: 1 Gerrit-Owner: Hsuan-ting Chen <roccochen(a)google.com> Gerrit-Reviewer: Hsuan Ting Chen <roccochen(a)chromium.org> Gerrit-Attention: Hsuan Ting Chen <roccochen(a)chromium.org> Gerrit-MessageType: newchange

1 0

Change in coreboot[master]: mb/google/volteer: Add fw confing MAX98373_ALC5682IVS_I2S_UP4 for cod...
by Frank Chu (Code Review) 28 Dec '21

28 Dec '21

Frank Chu has removed Nick Vaccaro from this change. ( https://review.coreboot.org/c/coreboot/+/60413 ) Change subject: mb/google/volteer: Add fw confing MAX98373_ALC5682IVS_I2S_UP4 for codec 2nd source ...................................................................... Removed reviewer Nick Vaccaro. -- To view, visit https://review.coreboot.org/c/coreboot/+/60413 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I6d857101a8143ae4b074666d8ed478cc188a0435 Gerrit-Change-Number: 60413 Gerrit-PatchSet: 2 Gerrit-Owner: Frank Chu <frank_chu(a)pegatron.corp-partner.google.com> Gerrit-CC: Daniel Peng <daniel_peng(a)pegatron.corp-partner.google.com> Gerrit-CC: Hank Lin <hank2_lin(a)pegatron.corp-partner.google.com> Gerrit-CC: Ken Lu <ken_lu(a)pegatron.corp-partner.google.com> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: deleteReviewer

1 0

Change in coreboot[master]: mb/google/volteer: Add fw confing MAX98373_ALC5682IVS_I2S_UP4 for cod...
by Frank Chu (Code Review) 28 Dec '21

28 Dec '21

Frank Chu has removed build bot (Jenkins) from this change. ( https://review.coreboot.org/c/coreboot/+/60413 ) Change subject: mb/google/volteer: Add fw confing MAX98373_ALC5682IVS_I2S_UP4 for codec 2nd source ...................................................................... Removed cc build bot (Jenkins). -- To view, visit https://review.coreboot.org/c/coreboot/+/60413 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I6d857101a8143ae4b074666d8ed478cc188a0435 Gerrit-Change-Number: 60413 Gerrit-PatchSet: 2 Gerrit-Owner: Frank Chu <frank_chu(a)pegatron.corp-partner.google.com> Gerrit-CC: Daniel Peng <daniel_peng(a)pegatron.corp-partner.google.com> Gerrit-CC: Hank Lin <hank2_lin(a)pegatron.corp-partner.google.com> Gerrit-CC: Ken Lu <ken_lu(a)pegatron.corp-partner.google.com> Gerrit-MessageType: deleteReviewer

1 0

Change in coreboot[master]: mb/google/volteer: Add fw confing MAX98373_ALC5682IVS_I2S_UP4 for cod...
by Frank Chu (Code Review) 28 Dec '21

28 Dec '21

Frank Chu has removed Tim Wawrzynczak from this change. ( https://review.coreboot.org/c/coreboot/+/60413 ) Change subject: mb/google/volteer: Add fw confing MAX98373_ALC5682IVS_I2S_UP4 for codec 2nd source ...................................................................... Removed reviewer Tim Wawrzynczak. -- To view, visit https://review.coreboot.org/c/coreboot/+/60413 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I6d857101a8143ae4b074666d8ed478cc188a0435 Gerrit-Change-Number: 60413 Gerrit-PatchSet: 2 Gerrit-Owner: Frank Chu <frank_chu(a)pegatron.corp-partner.google.com> Gerrit-CC: Daniel Peng <daniel_peng(a)pegatron.corp-partner.google.com> Gerrit-CC: Hank Lin <hank2_lin(a)pegatron.corp-partner.google.com> Gerrit-CC: Ken Lu <ken_lu(a)pegatron.corp-partner.google.com> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: deleteReviewer

1 0

Change in coreboot[master]: mb/google/volteer: Add fw confing MAX98373_ALC5682IVS_I2S_UP4 for cod...
by build bot (Jenkins) (Code Review) 28 Dec '21

28 Dec '21

1 0

Change in coreboot[master]: mb/google/volteer: Add fw confing MAX98373_ALC5682IVS_I2S_UP4 for cod...
by Frank Chu (Code Review) 28 Dec '21

28 Dec '21

Frank Chu has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/60413 ) Change subject: mb/google/volteer: Add fw confing MAX98373_ALC5682IVS_I2S_UP4 for codec 2nd source ...................................................................... mb/google/volteer: Add fw confing MAX98373_ALC5682IVS_I2S_UP4 for codec 2nd source Add MAX98373_ALC5682IVS_I2S_UP4 fw confing option and configure GPIOs properly for UP4 design. BUG=b:192535692 TEST=./gen_config config.star Local build image and test function correctly on DUT. Signed-off-by: FrankChu <frank_chu(a)pegatron.corp-partner.google.com> Change-Id: I6d857101a8143ae4b074666d8ed478cc188a0435 --- M src/mainboard/google/volteer/fw_config.c M src/mainboard/google/volteer/variants/baseboard/devicetree.cb 2 files changed, 3 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/13/60413/1 diff --git a/src/mainboard/google/volteer/fw_config.c b/src/mainboard/google/volteer/fw_config.c index 1025119..474c4e1 100644 --- a/src/mainboard/google/volteer/fw_config.c +++ b/src/mainboard/google/volteer/fw_config.c @@ -100,7 +100,8 @@ gpio_configure_pads(dmic_enable_pads, ARRAY_SIZE(dmic_enable_pads)); gpio_configure_pads(sndw_disable_pads, ARRAY_SIZE(sndw_disable_pads)); } - if (fw_config_probe(FW_CONFIG(AUDIO, MAX98373_ALC5682I_I2S_UP4))) { + if (fw_config_probe(FW_CONFIG(AUDIO, MAX98373_ALC5682I_I2S_UP4)) || + fw_config_probe(FW_CONFIG(AUDIO, MAX98373_ALC5682IVS_I2S_UP4))) { printk(BIOS_INFO, "Configure GPIOs for I2S audio on UP4.\n"); gpio_configure_pads(i2s_up4_enable_pads, ARRAY_SIZE(i2s_up4_enable_pads)); gpio_configure_pads(dmic_enable_pads, ARRAY_SIZE(dmic_enable_pads)); diff --git a/src/mainboard/google/volteer/variants/baseboard/devicetree.cb b/src/mainboard/google/volteer/variants/baseboard/devicetree.cb index a93a38a..d985a60 100644 --- a/src/mainboard/google/volteer/variants/baseboard/devicetree.cb +++ b/src/mainboard/google/volteer/variants/baseboard/devicetree.cb @@ -20,6 +20,7 @@ option MAX98373_ALC5682I_I2S_UP4 4 option MAX98360_ALC5682I_I2S 5 option RT1011_ALC5682I_I2S 6 + option MAX98373_ALC5682IVS_I2S_UP4 7 end field TABLETMODE 11 option TABLETMODE_DISABLED 0 -- To view, visit https://review.coreboot.org/c/coreboot/+/60413 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I6d857101a8143ae4b074666d8ed478cc188a0435 Gerrit-Change-Number: 60413 Gerrit-PatchSet: 1 Gerrit-Owner: Frank Chu <frank_chu(a)pegatron.corp-partner.google.com> Gerrit-MessageType: newchange

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit December 2021