coreboot-gerrit December 2021

coreboot-gerrit@coreboot.org

1 participants
5525 discussions

Change in coreboot[master]: mb/google/slippy/Kconfig: Reorder selects alphabetically
by Felix Singer (Code Review) 28 Dec '21

28 Dec '21

Felix Singer has submitted this change. ( https://review.coreboot.org/c/coreboot/+/60351 ) Change subject: mb/google/slippy/Kconfig: Reorder selects alphabetically ...................................................................... mb/google/slippy/Kconfig: Reorder selects alphabetically Change-Id: I7691cf37da03e6a689efcb84527ba519fe661258 Signed-off-by: Felix Singer <felixsinger(a)posteo.net> Reviewed-on: https://review.coreboot.org/c/coreboot/+/60351 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Kyösti Mälkki <kyosti.malkki(a)gmail.com> --- M src/mainboard/google/slippy/Kconfig 1 file changed, 10 insertions(+), 10 deletions(-) Approvals: build bot (Jenkins): Verified Kyösti Mälkki: Looks good to me, approved diff --git a/src/mainboard/google/slippy/Kconfig b/src/mainboard/google/slippy/Kconfig index e8963f7..866038c 100644 --- a/src/mainboard/google/slippy/Kconfig +++ b/src/mainboard/google/slippy/Kconfig @@ -1,23 +1,23 @@ config BOARD_GOOGLE_BASEBOARD_SLIPPY def_bool n - select SYSTEM_TYPE_LAPTOP - select NORTHBRIDGE_INTEL_HASWELL - select SOUTHBRIDGE_INTEL_LYNXPOINT - select INTEL_LYNXPOINT_LP select BOARD_ROMSIZE_KB_8192 + select DRIVERS_I2C_RTD2132 if BOARD_GOOGLE_LEON select EC_GOOGLE_CHROMEEC select EC_GOOGLE_CHROMEEC_LPC + select HAVE_ACPI_RESUME select HAVE_ACPI_TABLES select HAVE_OPTION_TABLE - select HAVE_ACPI_RESUME + select HAVE_SPD_IN_CBFS + select INTEL_GMA_HAVE_VBT + select INTEL_INT15 + select INTEL_LYNXPOINT_LP select MAINBOARD_HAS_CHROMEOS + select MAINBOARD_HAS_LIBGFXINIT select MAINBOARD_HAS_LPC_TPM select MAINBOARD_HAS_TPM1 - select INTEL_INT15 - select MAINBOARD_HAS_LIBGFXINIT - select INTEL_GMA_HAVE_VBT - select DRIVERS_I2C_RTD2132 if BOARD_GOOGLE_LEON - select HAVE_SPD_IN_CBFS + select NORTHBRIDGE_INTEL_HASWELL + select SOUTHBRIDGE_INTEL_LYNXPOINT + select SYSTEM_TYPE_LAPTOP if BOARD_GOOGLE_BASEBOARD_SLIPPY -- To view, visit https://review.coreboot.org/c/coreboot/+/60351 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I7691cf37da03e6a689efcb84527ba519fe661258 Gerrit-Change-Number: 60351 Gerrit-PatchSet: 4 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: merged

1 0

Change in coreboot[master]: mb/google/butterfly/Kconfig: Reorder selects alphabetically
by Felix Singer (Code Review) 28 Dec '21

28 Dec '21

Felix Singer has submitted this change. ( https://review.coreboot.org/c/coreboot/+/60350 ) Change subject: mb/google/butterfly/Kconfig: Reorder selects alphabetically ...................................................................... mb/google/butterfly/Kconfig: Reorder selects alphabetically Change-Id: Ifc6708c2e864e5dcba12d53af24993dc173fca7f Signed-off-by: Felix Singer <felixsinger(a)posteo.net> Reviewed-on: https://review.coreboot.org/c/coreboot/+/60350 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Kyösti Mälkki <kyosti.malkki(a)gmail.com> --- M src/mainboard/google/butterfly/Kconfig 1 file changed, 13 insertions(+), 13 deletions(-) Approvals: build bot (Jenkins): Verified Kyösti Mälkki: Looks good to me, approved diff --git a/src/mainboard/google/butterfly/Kconfig b/src/mainboard/google/butterfly/Kconfig index 4eb151e..f8897ac 100644 --- a/src/mainboard/google/butterfly/Kconfig +++ b/src/mainboard/google/butterfly/Kconfig @@ -2,25 +2,25 @@ config BOARD_SPECIFIC_OPTIONS def_bool y - select SYSTEM_TYPE_LAPTOP - select NORTHBRIDGE_INTEL_SANDYBRIDGE - select SOUTHBRIDGE_INTEL_C216 - select EC_QUANTA_ENE_KB3940Q select BOARD_ROMSIZE_KB_8192 - select HAVE_ACPI_TABLES - select HAVE_OPTION_TABLE - select HAVE_CMOS_DEFAULT + select EC_QUANTA_ENE_KB3940Q + select GFX_GMA_PANEL_1_ON_LVDS select HAVE_ACPI_RESUME - select MAINBOARD_HAS_CHROMEOS - select MAINBOARD_HAS_LPC_TPM - select MAINBOARD_HAS_TPM1 - select INTEL_INT15 - select SERIRQ_CONTINUOUS_MODE # Workaround for EC/KBC IRQ1. + select HAVE_ACPI_TABLES + select HAVE_CMOS_DEFAULT select HAVE_IFD_BIN select HAVE_ME_BIN - select GFX_GMA_PANEL_1_ON_LVDS + select HAVE_OPTION_TABLE + select INTEL_INT15 + select MAINBOARD_HAS_CHROMEOS select MAINBOARD_HAS_LIBGFXINIT + select MAINBOARD_HAS_LPC_TPM + select MAINBOARD_HAS_TPM1 + select NORTHBRIDGE_INTEL_SANDYBRIDGE select SANDYBRIDGE_VBOOT_IN_ROMSTAGE + select SERIRQ_CONTINUOUS_MODE # Workaround for EC/KBC IRQ1. + select SOUTHBRIDGE_INTEL_C216 + select SYSTEM_TYPE_LAPTOP config VBOOT select VBOOT_VBNV_CMOS -- To view, visit https://review.coreboot.org/c/coreboot/+/60350 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ifc6708c2e864e5dcba12d53af24993dc173fca7f Gerrit-Change-Number: 60350 Gerrit-PatchSet: 4 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: merged

1 0

Change in coreboot[master]: mb/google/link/Kconfig: Reorder selects alphabetically
by Felix Singer (Code Review) 28 Dec '21

28 Dec '21

Felix Singer has submitted this change. ( https://review.coreboot.org/c/coreboot/+/60349 ) Change subject: mb/google/link/Kconfig: Reorder selects alphabetically ...................................................................... mb/google/link/Kconfig: Reorder selects alphabetically Change-Id: I019ba38015b245f69c9663fd93775409c7d9cb1b Signed-off-by: Felix Singer <felixsinger(a)posteo.net> Reviewed-on: https://review.coreboot.org/c/coreboot/+/60349 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Kyösti Mälkki <kyosti.malkki(a)gmail.com> --- M src/mainboard/google/link/Kconfig 1 file changed, 11 insertions(+), 11 deletions(-) Approvals: build bot (Jenkins): Verified Kyösti Mälkki: Looks good to me, approved diff --git a/src/mainboard/google/link/Kconfig b/src/mainboard/google/link/Kconfig index ee68e46..e08ced9 100644 --- a/src/mainboard/google/link/Kconfig +++ b/src/mainboard/google/link/Kconfig @@ -2,23 +2,23 @@ config BOARD_SPECIFIC_OPTIONS def_bool y - select SYSTEM_TYPE_LAPTOP - select NORTHBRIDGE_INTEL_SANDYBRIDGE - select SOUTHBRIDGE_INTEL_C216 select BOARD_ROMSIZE_KB_8192 select EC_GOOGLE_CHROMEEC select EC_GOOGLE_CHROMEEC_LPC - select HAVE_SPD_IN_CBFS - select HAVE_ACPI_TABLES - select HAVE_OPTION_TABLE select HAVE_ACPI_RESUME - select MAINBOARD_HAS_CHROMEOS - select MAINBOARD_HAS_LPC_TPM - select MAINBOARD_HAS_TPM1 - select SERIRQ_CONTINUOUS_MODE - select MAINBOARD_HAS_LIBGFXINIT + select HAVE_ACPI_TABLES select HAVE_IFD_BIN select HAVE_ME_BIN + select HAVE_OPTION_TABLE + select HAVE_SPD_IN_CBFS + select MAINBOARD_HAS_CHROMEOS + select MAINBOARD_HAS_LIBGFXINIT + select MAINBOARD_HAS_LPC_TPM + select MAINBOARD_HAS_TPM1 + select NORTHBRIDGE_INTEL_SANDYBRIDGE + select SERIRQ_CONTINUOUS_MODE + select SOUTHBRIDGE_INTEL_C216 + select SYSTEM_TYPE_LAPTOP config VBOOT select EC_GOOGLE_CHROMEEC_SWITCHES -- To view, visit https://review.coreboot.org/c/coreboot/+/60349 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I019ba38015b245f69c9663fd93775409c7d9cb1b Gerrit-Change-Number: 60349 Gerrit-PatchSet: 4 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: merged

1 0

Change in coreboot[master]: mb/google/parrot/Kconfig: Reorder selects alphabetically
by Felix Singer (Code Review) 28 Dec '21

28 Dec '21

Felix Singer has submitted this change. ( https://review.coreboot.org/c/coreboot/+/60348 ) Change subject: mb/google/parrot/Kconfig: Reorder selects alphabetically ...................................................................... mb/google/parrot/Kconfig: Reorder selects alphabetically Change-Id: I7e99a44dcb512f0eb4355663cdc8dac690211dab Signed-off-by: Felix Singer <felixsinger(a)posteo.net> Reviewed-on: https://review.coreboot.org/c/coreboot/+/60348 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Kyösti Mälkki <kyosti.malkki(a)gmail.com> --- M src/mainboard/google/parrot/Kconfig 1 file changed, 15 insertions(+), 15 deletions(-) Approvals: build bot (Jenkins): Verified Kyösti Mälkki: Looks good to me, approved diff --git a/src/mainboard/google/parrot/Kconfig b/src/mainboard/google/parrot/Kconfig index 5fffcc1..c06da09 100644 --- a/src/mainboard/google/parrot/Kconfig +++ b/src/mainboard/google/parrot/Kconfig @@ -2,26 +2,26 @@ config BOARD_SPECIFIC_OPTIONS def_bool y - select SYSTEM_TYPE_LAPTOP - select NORTHBRIDGE_INTEL_SANDYBRIDGE - select SOUTHBRIDGE_INTEL_C216 - select EC_COMPAL_ENE932 select BOARD_ROMSIZE_KB_8192 - select HAVE_ACPI_TABLES - select HAVE_OPTION_TABLE - select HAVE_ACPI_RESUME - select MAINBOARD_HAS_CHROMEOS - select MAINBOARD_HAS_LPC_TPM - select MAINBOARD_HAS_TPM1 - select INTEL_INT15 - select HAVE_IFD_BIN - select HAVE_ME_BIN - # Workaround for EC/KBC IRQ1. - select SERIRQ_CONTINUOUS_MODE + select EC_COMPAL_ENE932 # This board also feature sandy-bridge CPU's so must have LVDS select GFX_GMA_PANEL_1_ON_LVDS + select HAVE_ACPI_RESUME + select HAVE_ACPI_TABLES + select HAVE_IFD_BIN + select HAVE_ME_BIN + select HAVE_OPTION_TABLE + select INTEL_INT15 + select MAINBOARD_HAS_CHROMEOS select MAINBOARD_HAS_LIBGFXINIT + select MAINBOARD_HAS_LPC_TPM + select MAINBOARD_HAS_TPM1 + select NORTHBRIDGE_INTEL_SANDYBRIDGE select SANDYBRIDGE_VBOOT_IN_ROMSTAGE + # Workaround for EC/KBC IRQ1. + select SERIRQ_CONTINUOUS_MODE + select SOUTHBRIDGE_INTEL_C216 + select SYSTEM_TYPE_LAPTOP config VBOOT select VBOOT_VBNV_CMOS -- To view, visit https://review.coreboot.org/c/coreboot/+/60348 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I7e99a44dcb512f0eb4355663cdc8dac690211dab Gerrit-Change-Number: 60348 Gerrit-PatchSet: 4 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: merged

1 0

Change in coreboot[master]: mb/google/stout/Kconfig: Reorder selects alphabetically
by Felix Singer (Code Review) 28 Dec '21

28 Dec '21

Felix Singer has submitted this change. ( https://review.coreboot.org/c/coreboot/+/60347 ) Change subject: mb/google/stout/Kconfig: Reorder selects alphabetically ...................................................................... mb/google/stout/Kconfig: Reorder selects alphabetically Change-Id: Icd58cd466c8e85625170bb14e66fc068758883f5 Signed-off-by: Felix Singer <felixsinger(a)posteo.net> Reviewed-on: https://review.coreboot.org/c/coreboot/+/60347 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Kyösti Mälkki <kyosti.malkki(a)gmail.com> --- M src/mainboard/google/stout/Kconfig 1 file changed, 13 insertions(+), 13 deletions(-) Approvals: build bot (Jenkins): Verified Kyösti Mälkki: Looks good to me, approved diff --git a/src/mainboard/google/stout/Kconfig b/src/mainboard/google/stout/Kconfig index 69cfdcc..d26d5b9 100644 --- a/src/mainboard/google/stout/Kconfig +++ b/src/mainboard/google/stout/Kconfig @@ -2,24 +2,24 @@ config BOARD_SPECIFIC_OPTIONS def_bool y - select SYSTEM_TYPE_LAPTOP - select NORTHBRIDGE_INTEL_SANDYBRIDGE - select SOUTHBRIDGE_INTEL_C216 - select EC_QUANTA_IT8518 select BOARD_ROMSIZE_KB_8192 - select HAVE_ACPI_TABLES - select HAVE_OPTION_TABLE - select HAVE_CMOS_DEFAULT - select HAVE_ACPI_RESUME - select MAINBOARD_HAS_CHROMEOS - select MAINBOARD_HAS_LPC_TPM - select MAINBOARD_HAS_TPM1 - select INTEL_INT15 - select MAINBOARD_HAS_LIBGFXINIT + select EC_QUANTA_IT8518 select GFX_GMA_PANEL_1_ON_LVDS + select HAVE_ACPI_RESUME + select HAVE_ACPI_TABLES + select HAVE_CMOS_DEFAULT select HAVE_IFD_BIN select HAVE_ME_BIN + select HAVE_OPTION_TABLE + select INTEL_INT15 + select MAINBOARD_HAS_CHROMEOS + select MAINBOARD_HAS_LIBGFXINIT + select MAINBOARD_HAS_LPC_TPM + select MAINBOARD_HAS_TPM1 + select NORTHBRIDGE_INTEL_SANDYBRIDGE select SANDYBRIDGE_VBOOT_IN_ROMSTAGE + select SOUTHBRIDGE_INTEL_C216 + select SYSTEM_TYPE_LAPTOP config VBOOT select VBOOT_VBNV_CMOS -- To view, visit https://review.coreboot.org/c/coreboot/+/60347 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Icd58cd466c8e85625170bb14e66fc068758883f5 Gerrit-Change-Number: 60347 Gerrit-PatchSet: 4 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: merged

1 0

Change in coreboot[master]: mb/google/rambi/Kconfig: Reorder selects alphabetically
by Felix Singer (Code Review) 28 Dec '21

28 Dec '21

Felix Singer has submitted this change. ( https://review.coreboot.org/c/coreboot/+/60346 ) Change subject: mb/google/rambi/Kconfig: Reorder selects alphabetically ...................................................................... mb/google/rambi/Kconfig: Reorder selects alphabetically Change-Id: I22e189dfa9b8944341aafcafe4e97dca65558937 Signed-off-by: Felix Singer <felixsinger(a)posteo.net> Reviewed-on: https://review.coreboot.org/c/coreboot/+/60346 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Kyösti Mälkki <kyosti.malkki(a)gmail.com> --- M src/mainboard/google/rambi/Kconfig 1 file changed, 4 insertions(+), 4 deletions(-) Approvals: build bot (Jenkins): Verified Kyösti Mälkki: Looks good to me, approved diff --git a/src/mainboard/google/rambi/Kconfig b/src/mainboard/google/rambi/Kconfig index 983ca49..69fb843 100644 --- a/src/mainboard/google/rambi/Kconfig +++ b/src/mainboard/google/rambi/Kconfig @@ -1,20 +1,20 @@ config BOARD_GOOGLE_BASEBOARD_RAMBI def_bool n - select SOC_INTEL_BAYTRAIL + select BOARD_ROMSIZE_KB_8192 select EC_GOOGLE_CHROMEEC select EC_GOOGLE_CHROMEEC_LPC select ENABLE_BUILTIN_COM1 if CONSOLE_SERIAL - select BOARD_ROMSIZE_KB_8192 + select HAVE_ACPI_RESUME select HAVE_ACPI_TABLES select HAVE_OPTION_TABLE - select HAVE_ACPI_RESUME + select HAVE_SPD_IN_CBFS select INTEL_GMA_HAVE_VBT if !BOARD_GOOGLE_RAMBI select MAINBOARD_HAS_CHROMEOS select MAINBOARD_HAS_LPC_TPM select MAINBOARD_HAS_TPM1 + select SOC_INTEL_BAYTRAIL select SYSTEM_TYPE_LAPTOP if !BOARD_GOOGLE_NINJA && !BOARD_GOOGLE_SUMO - select HAVE_SPD_IN_CBFS if BOARD_GOOGLE_BASEBOARD_RAMBI -- To view, visit https://review.coreboot.org/c/coreboot/+/60346 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I22e189dfa9b8944341aafcafe4e97dca65558937 Gerrit-Change-Number: 60346 Gerrit-PatchSet: 3 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: merged

1 0

Change in coreboot[master]: mb/google/brya: Reorder selects alphabetically
by Kyösti Mälkki (Code Review) 28 Dec '21

28 Dec '21

Attention is currently required from: Felix Singer, Tim Wawrzynczak. Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60371 ) Change subject: mb/google/brya: Reorder selects alphabetically ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/60371 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ie03f7049b013648372b002ce9b731589b1fffabd Gerrit-Change-Number: 60371 Gerrit-PatchSet: 2 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Comment-Date: Tue, 28 Dec 2021 10:43:26 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/octopus/Kconfig: Reorder selects alphabetically
by Felix Singer (Code Review) 28 Dec '21

28 Dec '21

Felix Singer has submitted this change. ( https://review.coreboot.org/c/coreboot/+/60343 ) Change subject: mb/google/octopus/Kconfig: Reorder selects alphabetically ...................................................................... mb/google/octopus/Kconfig: Reorder selects alphabetically Change-Id: I545a1111e24f45f732f1c325c808737dfb6bcae6 Signed-off-by: Felix Singer <felixsinger(a)posteo.net> Reviewed-on: https://review.coreboot.org/c/coreboot/+/60343 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Kyösti Mälkki <kyosti.malkki(a)gmail.com> --- M src/mainboard/google/octopus/Kconfig 1 file changed, 6 insertions(+), 6 deletions(-) Approvals: build bot (Jenkins): Verified Kyösti Mälkki: Looks good to me, approved diff --git a/src/mainboard/google/octopus/Kconfig b/src/mainboard/google/octopus/Kconfig index 25d08eb8..1aac8b6 100644 --- a/src/mainboard/google/octopus/Kconfig +++ b/src/mainboard/google/octopus/Kconfig @@ -1,7 +1,6 @@ config BOARD_GOOGLE_BASEBOARD_OCTOPUS def_bool n - select SOC_INTEL_GEMINILAKE select BOARD_ROMSIZE_KB_16384 select DRIVERS_GENERIC_GPIO_KEYS select DRIVERS_GENERIC_MAX98357A @@ -14,19 +13,20 @@ select DRIVERS_USB_ACPI select EC_GOOGLE_CHROMEEC select EC_GOOGLE_CHROMEEC_BOARDID - select EC_GOOGLE_CHROMEEC_SKUID select EC_GOOGLE_CHROMEEC_ESPI + select EC_GOOGLE_CHROMEEC_SKUID + select GOOGLE_SMBIOS_MAINBOARD_VERSION select HAVE_ACPI_RESUME select HAVE_ACPI_TABLES select INTEL_LPSS_UART_FOR_CONSOLE select MAINBOARD_HAS_CHROMEOS - select SOC_ESPI select MAINBOARD_HAS_SPI_TPM_CR50 select MAINBOARD_HAS_TPM2 - select GOOGLE_SMBIOS_MAINBOARD_VERSION select NO_BOOTBLOCK_CONSOLE - select NO_FMAP_CACHE select NO_CBFS_MCACHE + select NO_FMAP_CACHE + select SOC_ESPI + select SOC_INTEL_GEMINILAKE if BOARD_GOOGLE_BASEBOARD_OCTOPUS @@ -34,9 +34,9 @@ bool default y if CHROMEOS select DSAR_ENABLE + select GEO_SAR_ENABLE select SAR_ENABLE select USE_SAR - select GEO_SAR_ENABLE config BASEBOARD_OCTOPUS_LAPTOP def_bool n -- To view, visit https://review.coreboot.org/c/coreboot/+/60343 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I545a1111e24f45f732f1c325c808737dfb6bcae6 Gerrit-Change-Number: 60343 Gerrit-PatchSet: 3 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: merged

1 0

Change in coreboot[master]: mb/google/volteer: Select board-specific options per board
by Kyösti Mälkki (Code Review) 28 Dec '21

28 Dec '21

Attention is currently required from: Felix Singer, Tim Wawrzynczak, Nick Vaccaro. Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60370 ) Change subject: mb/google/volteer: Select board-specific options per board ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/60370 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I6c5305a764b7a362f9f381580a1cd2c20a8f2e9d Gerrit-Change-Number: 60370 Gerrit-PatchSet: 1 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Comment-Date: Tue, 28 Dec 2021 10:40:19 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/volteer: Move selects from Kconfig.name to Kconfig
by Kyösti Mälkki (Code Review) 28 Dec '21

28 Dec '21

Attention is currently required from: Felix Singer, Tim Wawrzynczak, Nick Vaccaro. Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60369 ) Change subject: mb/google/volteer: Move selects from Kconfig.name to Kconfig ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/60369 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I72c0e0c3968cb2e92b35381691762148f4c270e4 Gerrit-Change-Number: 60369 Gerrit-PatchSet: 1 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Comment-Date: Tue, 28 Dec 2021 10:39:49 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit December 2021