coreboot-gerrit December 2021

coreboot-gerrit@coreboot.org

1 participants
5525 discussions

Change in coreboot[master]: mb/google/brya/var/brask: Change I2C/DDC signals
by Rory Liu (Code Review) 30 Dec '21

30 Dec '21

Attention is currently required from: Tim Wawrzynczak, Alan Huang. Hello build bot (Jenkins), Tim Wawrzynczak, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/60530 to look at the new patch set (#3). Change subject: mb/google/brya/var/brask: Change I2C/DDC signals ...................................................................... mb/google/brya/var/brask: Change I2C/DDC signals The latest schematics changes the EN_PP3300_SSD from GPP_D11 to GPP_F14, I2C/DDC signals from GPP_E22/E23 to GPP_D11/D12. BUG=b:206602609 TEST=build pass Signed-off-by: Rory Liu <rory.liu(a)quanta.corp-partner.google.com> Change-Id: I1e4aa6c540806c34b4a642f7813de0a64c6ea2b0 --- M src/mainboard/google/brya/variants/baseboard/brask/gpio.c M src/mainboard/google/brya/variants/brask/gpio.c 2 files changed, 14 insertions(+), 14 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/30/60530/3 -- To view, visit https://review.coreboot.org/c/coreboot/+/60530 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1e4aa6c540806c34b4a642f7813de0a64c6ea2b0 Gerrit-Change-Number: 60530 Gerrit-PatchSet: 3 Gerrit-Owner: Rory Liu <rory.liu(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Alan Huang <alan-huang(a)quanta.corp-partner.google.com> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Alan Huang <alan-huang(a)quanta.corp-partner.google.com> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: Update vboot submodule to upstream master
by Hsuan-ting Chen (Code Review) 30 Dec '21

30 Dec '21

Attention is currently required from: Hsuan Ting Chen, Edward O'Callaghan, Julius Werner. Hsuan-ting Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60078 ) Change subject: Update vboot submodule to upstream master ...................................................................... Patch Set 4: (1 comment) File 3rdparty/vboot: https://review.coreboot.org/c/coreboot/+/60078/comment/46f2cea8_b0092ddb PS2, Line 1: 8028cac33c9c408f90de9ceffc714a1a0ca9d583 > 25b9493525325dfb5bc2c36321c43ec7665060fa […] Done It is great to hear that CL finally landed! -- To view, visit https://review.coreboot.org/c/coreboot/+/60078 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ife75d21ddfa0b956fdf7a638cd53b55b11f6cb7d Gerrit-Change-Number: 60078 Gerrit-PatchSet: 4 Gerrit-Owner: Hsuan-ting Chen <roccochen(a)google.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Hsuan Ting Chen <roccochen(a)chromium.org> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Hsuan Ting Chen <roccochen(a)chromium.org> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Comment-Date: Thu, 30 Dec 2021 05:48:38 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/brya/var/brask: Change I2C/DDC signals
by Rory Liu (Code Review) 30 Dec '21

30 Dec '21

Attention is currently required from: Tim Wawrzynczak, Alan Huang. Rory Liu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60530 ) Change subject: mb/google/brya/var/brask: Change I2C/DDC signals ...................................................................... Patch Set 2: (1 comment) This change is ready for review. File src/mainboard/google/brya/variants/baseboard/brask/gpio.c: https://review.coreboot.org/c/coreboot/+/60530/comment/1af71842_d0253e70 PS1, Line 145: PAD_CFG_NF(GPP_D12, NONE, DEEP, NF1), > NF2 Ack -- To view, visit https://review.coreboot.org/c/coreboot/+/60530 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1e4aa6c540806c34b4a642f7813de0a64c6ea2b0 Gerrit-Change-Number: 60530 Gerrit-PatchSet: 2 Gerrit-Owner: Rory Liu <rory.liu(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Alan Huang <alan-huang(a)quanta.corp-partner.google.com> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Alan Huang <alan-huang(a)quanta.corp-partner.google.com> Gerrit-Comment-Date: Thu, 30 Dec 2021 05:43:08 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Alan Huang <alan-huang(a)quanta.corp-partner.google.com> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/guybrush/var/dewatt: Update for RT1019 amp dev id was changed
by Kenneth Chan (Code Review) 30 Dec '21

30 Dec '21

Attention is currently required from: Bhanu Prakash Maiya, Rob Barnes, Karthik Ramasubramanian. Kenneth Chan has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60442 ) Change subject: mb/google/guybrush/var/dewatt: Update for RT1019 amp dev id was changed ...................................................................... Patch Set 4: (2 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/60442/comment/4386864a_737007b6 PS4, Line 11: 1019 id changed to 10EC1019:0/10EC1019:1 from 10EC1019:1/10EC1019:2. > New id is 10EC1019:1/10EC1019:2 right? So 10EC1019:1/10EC1019:2 from 10EC1019:0/10EC1019:1? Original code is referring to guybrush , using I2C 0x28, 0x29, 0x2a for 1019. 0x28 (1019:0) can't be mapped (dewatt using 0x29, 0x2a), so the 1019 works will with id 1019:1 and 1019:2 before this changed. Now we can remove 0x28 and mapping id to 1019:0 and 1019:1 for audio works well. (It's failed before, w/o 0x28) File src/mainboard/google/guybrush/variants/dewatt/overridetree.cb: https://review.coreboot.org/c/coreboot/+/60442/comment/97a7d805_59f12333 PS4, Line 151: register "uid" = "1" > "probed" = "1"? I refer to guybrush CRB codes, 0x29 w/o probed=1 and 0x2a with probed=1 -- To view, visit https://review.coreboot.org/c/coreboot/+/60442 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I542f886fe63205777837d7146169177b043cc5f2 Gerrit-Change-Number: 60442 Gerrit-PatchSet: 4 Gerrit-Owner: Kenneth Chan <kenneth.chan(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Bhanu Prakash Maiya <bhanumaiya(a)google.com> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Rob Barnes <robbarnes(a)google.com> Gerrit-Reviewer: Yu-hsuan Hsu <yuhsuan(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Bhanu Prakash Maiya <bhanumaiya(a)google.com> Gerrit-Attention: Rob Barnes <robbarnes(a)google.com> Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Comment-Date: Thu, 30 Dec 2021 04:47:23 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Rob Barnes <robbarnes(a)google.com> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: nb/intel/sandybridge: Populate meminfo when using MRC
by xin hua wang (Code Review) 30 Dec '21

30 Dec '21

xin hua wang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58188 ) Change subject: nb/intel/sandybridge: Populate meminfo when using MRC ...................................................................... Patch Set 6: (1 comment) Patchset: PS6: What is the cause of this? ft232h log with raminit debug enabled https://pastebin.com/kHC0bXLs Read MPR training failed: 1, 2, 0 raminit failed ---- If I remove the patches in here it boots fine ft232h log with raminit debug enabled https://pastebin.com/e8xhet1V Any ideas? Thx If I need more debugging options please tell me how to enable it, thx -- To view, visit https://review.coreboot.org/c/coreboot/+/58188 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I15e00a01121150b778cfa684b9147d0cac97beb8 Gerrit-Change-Number: 58188 Gerrit-PatchSet: 6 Gerrit-Owner: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: xin hua wang <xinhuawang0101(a)gmail.com> Gerrit-Comment-Date: Thu, 30 Dec 2021 04:37:21 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: ec/lenovo/h8/acpi: Replace Add(a,b,c) with ASL 2.0 syntax
by HAOUAS Elyes (Code Review) 30 Dec '21

30 Dec '21

Attention is currently required from: Felix Singer, Alexander Couzens. HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60492 ) Change subject: ec/lenovo/h8/acpi: Replace Add(a,b,c) with ASL 2.0 syntax ...................................................................... Patch Set 1: (2 comments) Patchset: PS1: Why don't you convert the files to ASL 2.0 in one go? ( https://review.coreboot.org/q/topic:ASL_2 ) File src/ec/lenovo/h8/acpi/thermal.asl: https://review.coreboot.org/c/coreboot/+/60492/comment/946ee138_4dd1181b PS1, Line 15: Local0 = Local0 + 2732 Local0 += 2732 -- To view, visit https://review.coreboot.org/c/coreboot/+/60492 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ibbc0831e688b62d7ed0dec5e4b7224688ed0ae6d Gerrit-Change-Number: 60492 Gerrit-PatchSet: 1 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Comment-Date: Thu, 30 Dec 2021 04:32:12 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/dedede/var/magolor: Set core display clock to 172.8 MHz
by Ren Kuo (Code Review) 30 Dec '21

30 Dec '21

Attention is currently required from: Nico Huber, Henry Sun, Paul Menzel, Simon Yang, Angel Pons, Kane Chen, Karthik Ramasubramanian. Ren Kuo has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60301 ) Change subject: mb/google/dedede/var/magolor: Set core display clock to 172.8 MHz ...................................................................... Patch Set 10: (1 comment) File src/mainboard/google/dedede/variants/magolor/overridetree.cb: https://review.coreboot.org/c/coreboot/+/60301/comment/79558f00_ca185297 PS9, Line 111: register "CdClock" = "0x0" > Based on the latest code change in CL#60009, you may need to change the setting to […] fixed. -- To view, visit https://review.coreboot.org/c/coreboot/+/60301 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I5a0ad2bed79b37775184f0bd0a0ef024900cbe34 Gerrit-Change-Number: 60301 Gerrit-PatchSet: 10 Gerrit-Owner: Ren Kuo <ren.kuo(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Henry Sun <henrysun(a)google.com> Gerrit-Reviewer: Kane Chen <kane.chen(a)intel.com> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Simon Yang <simon1.yang(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Nico Huber <nico.h(a)gmx.de> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Henry Sun <henrysun(a)google.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Simon Yang <simon1.yang(a)intel.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Kane Chen <kane.chen(a)intel.com> Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Comment-Date: Thu, 30 Dec 2021 04:21:38 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Simon Yang <simon1.yang(a)intel.com> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/dedede/var/magolor: Set core display clock to 172.8 MHz
by Ren Kuo (Code Review) 30 Dec '21

30 Dec '21

Attention is currently required from: Nico Huber, Henry Sun, Paul Menzel, Simon Yang, Angel Pons, Kane Chen, Karthik Ramasubramanian. Hello build bot (Jenkins), Henry Sun, Angel Pons, Simon Yang, Kane Chen, Karthik Ramasubramanian, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/60301 to look at the new patch set (#10). Change subject: mb/google/dedede/var/magolor: Set core display clock to 172.8 MHz ...................................................................... mb/google/dedede/var/magolor: Set core display clock to 172.8 MHz When using the default initial core display clock frequency, Magolor has a rare stability issue where the startup of Chrome OS in secure mode may hang. Slowing the initial core display clock frequency down to 172.8 MHz as per Intel recommendation avoids this problem. Depend on CL: https://review.coreboot.org/c/coreboot/+/60009 The CdClock=0xff is set in dedede baseboard,and we overwrite it as 0x0 (172.8 MHz) for magolor. BUG=b:206557434 BRANCH=dedede TEST=Build firmware and verify on fail DUTs. Check the DUTs can boot up in secure mode well. Change-Id: I5a0ad2bed79b37775184f0bd0a0ef024900cbe34 Signed-off-by: Ren Kuo <ren.kuo(a)quanta.corp-partner.google.com> --- M src/mainboard/google/dedede/variants/magolor/overridetree.cb 1 file changed, 3 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/01/60301/10 -- To view, visit https://review.coreboot.org/c/coreboot/+/60301 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I5a0ad2bed79b37775184f0bd0a0ef024900cbe34 Gerrit-Change-Number: 60301 Gerrit-PatchSet: 10 Gerrit-Owner: Ren Kuo <ren.kuo(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Henry Sun <henrysun(a)google.com> Gerrit-Reviewer: Kane Chen <kane.chen(a)intel.com> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Simon Yang <simon1.yang(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Nico Huber <nico.h(a)gmx.de> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Henry Sun <henrysun(a)google.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Simon Yang <simon1.yang(a)intel.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Kane Chen <kane.chen(a)intel.com> Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: sb/intel/bd82x6x/acpi: Replace Add(a,b,c) with ASL 2.0 syntax
by HAOUAS Elyes (Code Review) 30 Dec '21

30 Dec '21

Attention is currently required from: Felix Singer, Patrick Rudolph. HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60512 ) Change subject: sb/intel/bd82x6x/acpi: Replace Add(a,b,c) with ASL 2.0 syntax ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/60512 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I17ab35629b5545052c214e3cb2d57788b6a5b7ad Gerrit-Change-Number: 60512 Gerrit-PatchSet: 1 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Comment-Date: Thu, 30 Dec 2021 04:15:45 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: arch/x86/acpi: Replace Add(a,b,c) with ASL 2.0 syntax
by HAOUAS Elyes (Code Review) 30 Dec '21

30 Dec '21

Attention is currently required from: Felix Singer, Lance Zhao, Tim Wawrzynczak. HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60495 ) Change subject: arch/x86/acpi: Replace Add(a,b,c) with ASL 2.0 syntax ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/60495 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I10a94406aa7e66eed4fec22f56b7a8802252e781 Gerrit-Change-Number: 60495 Gerrit-PatchSet: 1 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-Reviewer: Lance Zhao Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Lance Zhao Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Comment-Date: Thu, 30 Dec 2021 04:14:48 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit December 2021