Attention is currently required from: Rex-BC Chen, Yu-Ping Wu.
Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60447 )
Change subject: mb/google/corsola: Initialize krabby display
......................................................................
Patch Set 5:
(2 comments)
File src/mainboard/google/corsola/display.c:
https://review.coreboot.org/c/coreboot/+/60447/comment/4c96f95f_4a1d0beb
PS5, Line 97: NULL
what about putting a place holder function? then we don't need to check NULL pointers.
https://review.coreboot.org/c/coreboot/+/60447/comment/8ce140f6_d05b3825
PS5, Line 124: if (bridge->get_edid) {
: if (bridge->get_edid(i2c_bus, &edid) < 0) {
I'd rather always provide the implementation and do:
assert(bridge->get_edid);
if (bridge->get_edid(...))
--
To view, visit https://review.coreboot.org/c/coreboot/+/60447
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I314d5407c40429bb7bc50f36fece58e396b27548
Gerrit-Change-Number: 60447
Gerrit-PatchSet: 5
Gerrit-Owner: Rex-BC Chen <rex-bc.chen(a)mediatek.com>
Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Rex-BC Chen <rex-bc.chen(a)mediatek.com>
Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Comment-Date: Thu, 30 Dec 2021 08:02:54 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Rex-BC Chen, Yu-Ping Wu.
Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60515 )
Change subject: mb/google/corsola: Remove corsola as a coreboot board
......................................................................
Patch Set 3:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/60515/comment/36cdd5df_8775b646
PS3, Line 7: Remove corsola as a coreboot board
Remove 'corsola' from Kconfig board names
https://review.coreboot.org/c/coreboot/+/60515/comment/3d33e2a7_7ce4d948
PS3, Line 9: We just have referenced boards as kingler and krabby for corsola
: project, so we don't need to have a configuration for corsola board.
Try this:
The 'Corsola' (MT8186 Chromebooks) family has two reference
designs (Krabby and Kingler) and all real implementations
should follow either one of the two. To prevent confusion,
we should remove the 'corsola' configuration from Kconfig
board names.
--
To view, visit https://review.coreboot.org/c/coreboot/+/60515
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib354054e358c0783f6221c2e2a1730b5c6ddba33
Gerrit-Change-Number: 60515
Gerrit-PatchSet: 3
Gerrit-Owner: Rex-BC Chen <rex-bc.chen(a)mediatek.com>
Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Rex-BC Chen <rex-bc.chen(a)mediatek.com>
Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Comment-Date: Thu, 30 Dec 2021 07:58:48 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Rory Liu, Tim Wawrzynczak, Nick Vaccaro.
David Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60530 )
Change subject: mb/google/brya/var/brask: Change I2C/DDC signals
......................................................................
Patch Set 3: Code-Review+1
--
To view, visit https://review.coreboot.org/c/coreboot/+/60530
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I1e4aa6c540806c34b4a642f7813de0a64c6ea2b0
Gerrit-Change-Number: 60530
Gerrit-PatchSet: 3
Gerrit-Owner: Rory Liu <rory.liu(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: David Wu <david_wu(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: Zhuohao Lee <zhuohao(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Alan Huang <alan-huang(a)quanta.corp-partner.google.com>
Gerrit-Attention: Rory Liu <rory.liu(a)quanta.corp-partner.google.com>
Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-Comment-Date: Thu, 30 Dec 2021 07:37:54 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Henry Sun, Aseda Aboagye, Teddy Shih, Paul Fagerburg, Felix Held.
Raymond Chung has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60242 )
Change subject: mb/google/dedede/var/beadrix: Add memory part and generate DRAM ID
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit https://review.coreboot.org/c/coreboot/+/60242
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ibff150bb4e742f32641da661cfca6594d18c52e9
Gerrit-Change-Number: 60242
Gerrit-PatchSet: 1
Gerrit-Owner: Teddy Shih <teddyshih(a)ami.corp-partner.google.com>
Gerrit-Reviewer: Aseda Aboagye <aaboagye(a)google.com>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Henry Sun <henrysun(a)google.com>
Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Reviewer: Paul Fagerburg <pfagerburg(a)google.com>
Gerrit-Reviewer: Raymond Chung <raymondchung(a)ami.corp-partner.google.com>
Gerrit-Reviewer: Teddy Shih <teddyshih(a)ami.corp-partner.google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: 9elements QA <hardwaretestrobot(a)gmail.com>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Henry Sun <henrysun(a)google.com>
Gerrit-Attention: Aseda Aboagye <aaboagye(a)google.com>
Gerrit-Attention: Teddy Shih <teddyshih(a)ami.corp-partner.google.com>
Gerrit-Attention: Paul Fagerburg <pfagerburg(a)google.com>
Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Comment-Date: Thu, 30 Dec 2021 07:29:45 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Tim Wawrzynczak, Robert Chen.
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60331 )
Change subject: mb/google/brya/var/vell: Add AMP driver setting
......................................................................
Patch Set 7:
(8 comments)
File src/drivers/i2c/cs35l53/cs35l53.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136609):
https://review.coreboot.org/c/coreboot/+/60331/comment/f7d883a9_387e9bd8
PS7, Line 72: (config->boost_peak_milliamp % 50)){
space required before the open brace '{'
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136609):
https://review.coreboot.org/c/coreboot/+/60331/comment/5e541b27_f1efbb6c
PS7, Line 82: acpi_dp_add_integer(dsd, "cirrus,gpio1-polarity-invert", config->gpio1_polarity_invert ? 1 : 0);
line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136609):
https://review.coreboot.org/c/coreboot/+/60331/comment/f384abbb_49aa2248
PS7, Line 83: acpi_dp_add_integer(dsd, "cirrus,gpio1-output-enable", config->gpio1_output_enable ? 1 : 0);
line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136609):
https://review.coreboot.org/c/coreboot/+/60331/comment/2e447e2d_acf80385
PS7, Line 85: acpi_dp_add_integer(dsd, "cirrus,gpio2-polarity-invert", config->gpio2_polarity_invert ? 1 : 0);
line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136609):
https://review.coreboot.org/c/coreboot/+/60331/comment/8ac3d413_5e3ddf2e
PS7, Line 86: acpi_dp_add_integer(dsd, "cirrus,gpio2-output-enable", config->gpio2_output_enable ? 1 : 0);
line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136609):
https://review.coreboot.org/c/coreboot/+/60331/comment/904cd0f3_3b41acd8
PS7, Line 108: if (config->name){
suspect code indent for conditional statements (0, 0)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136609):
https://review.coreboot.org/c/coreboot/+/60331/comment/f2be7c1a_d7fa2f16
PS7, Line 108: if (config->name){
space required before the open brace '{'
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136609):
https://review.coreboot.org/c/coreboot/+/60331/comment/a255c018_e286746b
PS7, Line 108: if (config->name){
braces {} are not necessary for single statement blocks
--
To view, visit https://review.coreboot.org/c/coreboot/+/60331
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I96d49bd1a2ba061c4fd52b450b31d0885f49552c
Gerrit-Change-Number: 60331
Gerrit-PatchSet: 7
Gerrit-Owner: Shon Wang <shon.wang(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Attention: Robert Chen <robert.chen(a)quanta.corp-partner.google.com>
Gerrit-Comment-Date: Thu, 30 Dec 2021 07:25:25 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Tim Wawrzynczak, Robert Chen.
Robert Chen has uploaded a new patch set (#7) to the change originally created by Shon Wang. ( https://review.coreboot.org/c/coreboot/+/60331 )
Change subject: mb/google/brya/var/vell: Add AMP driver setting
......................................................................
mb/google/brya/var/vell: Add AMP driver setting
update overridetree.cb
update Kconfig.name
update i2c/C35l53
Signed-off-by: Shon Wang <shon.wang(a)quanta.corp-partner.google.com>
Change-Id: I96d49bd1a2ba061c4fd52b450b31d0885f49552c
---
A src/drivers/i2c/cs35l53/Kconfig
A src/drivers/i2c/cs35l53/Makefile.inc
A src/drivers/i2c/cs35l53/chip.h
A src/drivers/i2c/cs35l53/cs35l53.c
M src/mainboard/google/brya/Kconfig.name
M src/mainboard/google/brya/variants/vell/gpio.c
M src/mainboard/google/brya/variants/vell/overridetree.cb
7 files changed, 292 insertions(+), 30 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/31/60331/7
--
To view, visit https://review.coreboot.org/c/coreboot/+/60331
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I96d49bd1a2ba061c4fd52b450b31d0885f49552c
Gerrit-Change-Number: 60331
Gerrit-PatchSet: 7
Gerrit-Owner: Shon Wang <shon.wang(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Attention: Robert Chen <robert.chen(a)quanta.corp-partner.google.com>
Gerrit-MessageType: newpatchset
Attention is currently required from: Rory Liu, Tim Wawrzynczak.
Zhuohao Lee has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60530 )
Change subject: mb/google/brya/var/brask: Change I2C/DDC signals
......................................................................
Patch Set 3: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/60530
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I1e4aa6c540806c34b4a642f7813de0a64c6ea2b0
Gerrit-Change-Number: 60530
Gerrit-PatchSet: 3
Gerrit-Owner: Rory Liu <rory.liu(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: Zhuohao Lee <zhuohao(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Alan Huang <alan-huang(a)quanta.corp-partner.google.com>
Gerrit-CC: David Wu <david_wu(a)quanta.corp-partner.google.com>
Gerrit-Attention: Rory Liu <rory.liu(a)quanta.corp-partner.google.com>
Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Comment-Date: Thu, 30 Dec 2021 07:20:04 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Tim Wawrzynczak, Robert Chen.
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60331 )
Change subject: mb/google/brya/var/vell: Add AMP driver setting
......................................................................
Patch Set 6: Verified+1
(6 comments)
File src/drivers/i2c/cs35l53/cs35l53.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136607):
https://review.coreboot.org/c/coreboot/+/60331/comment/39e0bc0b_a6c0d961
PS6, Line 70: if ((config->boost_peak_milliamp > 4500) ||
that open brace { should be on the previous line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136607):
https://review.coreboot.org/c/coreboot/+/60331/comment/ffe1eea4_4215773a
PS6, Line 83: acpi_dp_add_integer(dsd, "cirrus,gpio1-polarity-invert", config->gpio1_polarity_invert ? 1 : 0);
line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136607):
https://review.coreboot.org/c/coreboot/+/60331/comment/b17daf97_16fb7aa5
PS6, Line 84: acpi_dp_add_integer(dsd, "cirrus,gpio1-output-enable", config->gpio1_output_enable ? 1 : 0);
line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136607):
https://review.coreboot.org/c/coreboot/+/60331/comment/6a0a4351_464d972f
PS6, Line 86: acpi_dp_add_integer(dsd, "cirrus,gpio2-polarity-invert", config->gpio2_polarity_invert ? 1 : 0);
line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136607):
https://review.coreboot.org/c/coreboot/+/60331/comment/7d0f0715_774cf97b
PS6, Line 87: acpi_dp_add_integer(dsd, "cirrus,gpio2-output-enable", config->gpio2_output_enable ? 1 : 0);
line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136607):
https://review.coreboot.org/c/coreboot/+/60331/comment/59ffa01d_ef22669b
PS6, Line 109: if (config->name)
suspect code indent for conditional statements (0, 0)
--
To view, visit https://review.coreboot.org/c/coreboot/+/60331
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I96d49bd1a2ba061c4fd52b450b31d0885f49552c
Gerrit-Change-Number: 60331
Gerrit-PatchSet: 6
Gerrit-Owner: Shon Wang <shon.wang(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Attention: Robert Chen <robert.chen(a)quanta.corp-partner.google.com>
Gerrit-Comment-Date: Thu, 30 Dec 2021 07:17:08 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Kevin Chiu, Jimmy Su, Robert Chen, Wisley Chen.
Robert Chen has uploaded a new patch set (#12) to the change originally created by Shon Wang. ( https://review.coreboot.org/c/coreboot/+/60276 )
Change subject: mb/google/brya/var/vell: Correct MIPI camera info
......................................................................
mb/google/brya/var/vell: Correct MIPI camera info
Correct OVTI8856 information for vell:
BUG=b:210801553
TEST=Build and boot on vell
Change-Id: I43de859cd0cdd9fe21c16cabfad511ed0b368ee3
Signed-off-by: Shon Wang <shon.wang(a)quanta.corp-partner.google.com>
---
M src/mainboard/google/brya/variants/vell/gpio.c
M src/mainboard/google/brya/variants/vell/overridetree.cb
2 files changed, 23 insertions(+), 20 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/76/60276/12
--
To view, visit https://review.coreboot.org/c/coreboot/+/60276
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I43de859cd0cdd9fe21c16cabfad511ed0b368ee3
Gerrit-Change-Number: 60276
Gerrit-PatchSet: 12
Gerrit-Owner: Shon Wang <shon.wang(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: Kevin Chiu <Kevin.Chiu(a)quantatw.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: Wisley Chen <wisley.chen(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Jimmy Su <jimmy.su(a)intel.corp-partner.google.com>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-CC: Robert Chen <robert.chen(a)quanta.corp-partner.google.com>
Gerrit-Attention: Kevin Chiu <Kevin.Chiu(a)quantatw.com>
Gerrit-Attention: Jimmy Su <jimmy.su(a)intel.corp-partner.google.com>
Gerrit-Attention: Robert Chen <robert.chen(a)quanta.corp-partner.google.com>
Gerrit-Attention: Wisley Chen <wisley.chen(a)quanta.corp-partner.google.com>
Gerrit-MessageType: newpatchset
Attention is currently required from: Tim Wawrzynczak, Kevin Chiu, Jimmy Su, Robert Chen, Wisley Chen.
Robert Chen has uploaded a new patch set (#7) to the change originally created by Shon Wang. ( https://review.coreboot.org/c/coreboot/+/60275 )
Change subject: mb/google/brya/var/vell: Add MIPI camera support
......................................................................
mb/google/brya/var/vell: Add MIPI camera support
Add MIPI camera support for OVTI2740
BUG=b:210801553
TEST=Build and boot on vell
Signed-off-by: Shon Wang <shon.wang(a)quanta.corp-partner.google.com>
Change-Id: I0fa77b07c52541446e83c479ff9a409a99175622
---
M src/mainboard/google/brya/Kconfig.name
M src/mainboard/google/brya/variants/vell/overridetree.cb
2 files changed, 70 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/75/60275/7
--
To view, visit https://review.coreboot.org/c/coreboot/+/60275
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I0fa77b07c52541446e83c479ff9a409a99175622
Gerrit-Change-Number: 60275
Gerrit-PatchSet: 7
Gerrit-Owner: Shon Wang <shon.wang(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: Kevin Chiu <Kevin.Chiu(a)quantatw.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: Wisley Chen <wisley.chen(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Jimmy Su <jimmy.su(a)intel.corp-partner.google.com>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-CC: Robert Chen <robert.chen(a)quanta.corp-partner.google.com>
Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Attention: Kevin Chiu <Kevin.Chiu(a)quantatw.com>
Gerrit-Attention: Jimmy Su <jimmy.su(a)intel.corp-partner.google.com>
Gerrit-Attention: Robert Chen <robert.chen(a)quanta.corp-partner.google.com>
Gerrit-Attention: Wisley Chen <wisley.chen(a)quanta.corp-partner.google.com>
Gerrit-MessageType: newpatchset