Attention is currently required from: Kevin Chiu, YH Lin, Paul Menzel, Nick Vaccaro, Shon Wang, Patrick Rudolph.
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59334 )
Change subject: mb/google/brya/var/vell: update memory settings
......................................................................
Patch Set 12:
(2 comments)
File src/mainboard/google/brya/variants/vell/memory.c:
https://review.coreboot.org/c/coreboot/+/59334/comment/1f9ac47d_806bca3c
PS12, Line 67: 1
> Done
Sorry I don't see any changes?
https://review.coreboot.org/c/coreboot/+/59334/comment/5fc020a1_bfce33d1
PS12, Line 68:
> Done
Sorry I don't see any changes?
--
To view, visit https://review.coreboot.org/c/coreboot/+/59334
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic0bbac5eaebc77639be6c1bc399658ac90e72fbb
Gerrit-Change-Number: 59334
Gerrit-PatchSet: 12
Gerrit-Owner: Shon Wang <shon.wang(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com>
Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: YH Lin <yueherngl(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Kevin Chiu <Kevin.Chiu(a)quantatw.com>
Gerrit-CC: Kevin Chiu <kevin.chiu.17802(a)gmail.com>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-CC: Robert Chen <robert.chen(a)quanta.corp-partner.google.com>
Gerrit-CC: Wisley Chen <wisley.chen(a)quanta.corp-partner.google.com>
Gerrit-Attention: Kevin Chiu <kevin.chiu.17802(a)gmail.com>
Gerrit-Attention: YH Lin <yueherngl(a)google.com>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-Attention: Nick Vaccaro <nvaccaro(a)google.com>
Gerrit-Attention: Shon Wang <shon.wang(a)quanta.corp-partner.google.com>
Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Comment-Date: Tue, 30 Nov 2021 16:43:56 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Comment-In-Reply-To: Shon Wang <shon.wang(a)quanta.corp-partner.google.com>
Gerrit-MessageType: comment
Attention is currently required from: Arthur Heymans.
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59660 )
Change subject: oprom/realmode/x86.c: Fix building for ENV_X86_64
......................................................................
Patch Set 2: Code-Review+1
--
To view, visit https://review.coreboot.org/c/coreboot/+/59660
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I8ce8d56da326aeff5ff9b400ded02d4309372519
Gerrit-Change-Number: 59660
Gerrit-PatchSet: 2
Gerrit-Owner: Arthur Heymans <arthur.heymans(a)9elements.com>
Gerrit-Reviewer: Subrata Banik <subi.banik(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Attention: Arthur Heymans <arthur.heymans(a)9elements.com>
Gerrit-Comment-Date: Tue, 30 Nov 2021 16:40:44 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Arthur Heymans.
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59660 )
Change subject: oprom/realmode/x86.c: Fix building for ENV_X86_64
......................................................................
Patch Set 2:
(1 comment)
File src/device/oprom/realmode/x86.c:
https://review.coreboot.org/c/coreboot/+/59660/comment/8a5946de_09e3d9b8
PS2, Line 98: .cs=X86_CS,
if you move this a line above then a single #if/#endif can manage this x86_64 support addition
--
To view, visit https://review.coreboot.org/c/coreboot/+/59660
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I8ce8d56da326aeff5ff9b400ded02d4309372519
Gerrit-Change-Number: 59660
Gerrit-PatchSet: 2
Gerrit-Owner: Arthur Heymans <arthur.heymans(a)9elements.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-CC: Subrata Banik <subi.banik(a)gmail.com>
Gerrit-Attention: Arthur Heymans <arthur.heymans(a)9elements.com>
Gerrit-Comment-Date: Tue, 30 Nov 2021 16:40:22 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Kevin Chiu, Paul Menzel, Wisley Chen, Shon Wang.
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59304 )
Change subject: mb/google/brya/var/vell: update overridetree
......................................................................
Patch Set 6: Code-Review+1
(1 comment)
File src/mainboard/google/brya/variants/vell/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/59304/comment/edae718e_bbeee172
PS6, Line 75: # Internal panel on the first port of the graphics chip
FYI we are adding a _HID to this device for our 5.10 kernel (for brya), so you will also have to add
`register "hid" = ""GOOG0010""`
see CB:59731 for an example
--
To view, visit https://review.coreboot.org/c/coreboot/+/59304
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ibaa910eb1c5584197907963781258035c668298e
Gerrit-Change-Number: 59304
Gerrit-PatchSet: 6
Gerrit-Owner: Kevin Chiu <kevin.chiu.17802(a)gmail.com>
Gerrit-Reviewer: Kevin Chiu <Kevin.Chiu(a)quantatw.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: Wisley Chen <wisley.chen(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-CC: Shon Wang <shon.wang(a)quanta.corp-partner.google.com>
Gerrit-Attention: Kevin Chiu <kevin.chiu.17802(a)gmail.com>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Kevin Chiu <Kevin.Chiu(a)quantatw.com>
Gerrit-Attention: Wisley Chen <wisley.chen(a)quanta.corp-partner.google.com>
Gerrit-Attention: Shon Wang <shon.wang(a)quanta.corp-partner.google.com>
Gerrit-Comment-Date: Tue, 30 Nov 2021 16:38:44 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Adam Liu.
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59610 )
Change subject: mainboard/google/brya/variants/brask: Enable audio driver option in bios-stage for brask
......................................................................
Patch Set 2:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/59610/comment/817b0537_ce7119cb
PS2, Line 7: mainboard/google/brya/variants/brask: Enable audio driver option in bios-stage for brask
72 characters wide in commit messages please
suggestion:
```
mb/google/brya/brask: Add probe for audio driver
Add a FW_CONFIG field for the audio codec used, and add the
appropriate probe statement to the existing driver.
```
--
To view, visit https://review.coreboot.org/c/coreboot/+/59610
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I05c5d734ab9cd9a894084398decb5e3bac45ddf2
Gerrit-Change-Number: 59610
Gerrit-PatchSet: 2
Gerrit-Owner: Adam Liu <adam.liu(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: Zhuohao Lee <zhuohao(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Alan Huang <alan-huang(a)quanta.corp-partner.google.com>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Adam Liu <adam.liu(a)quanta.corp-partner.google.com>
Gerrit-Comment-Date: Tue, 30 Nov 2021 16:34:02 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Curtis Chen.
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59726 )
Change subject: mb/google/brya/var/brask: Set vGPIO reset type
......................................................................
Patch Set 4: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/59726
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I20cdd1650d1ca774065a6c051006dfd0b7a3fd79
Gerrit-Change-Number: 59726
Gerrit-PatchSet: 4
Gerrit-Owner: Curtis Chen <curtis.chen(a)intel.com>
Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: Zhuohao Lee <zhuohao(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Kane Chen <kane.chen(a)intel.corp-partner.google.com>
Gerrit-Attention: Curtis Chen <curtis.chen(a)intel.com>
Gerrit-Comment-Date: Tue, 30 Nov 2021 16:24:42 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment