Attention is currently required from: Patrick Rudolph.
Hello build bot (Jenkins), Arthur Heymans, Patrick Rudolph,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/59760
to look at the new patch set (#2).
Change subject: src/soc/intel/skylake/Kconfig: Enable x86_64 support
......................................................................
src/soc/intel/skylake/Kconfig: Enable x86_64 support
Add support for experimantal x86_64 mode.
Build test x86_64 on skylake.
Tested on Supermicro X11SSH-TF:
- Boots into payload using FSP-M and FSP-S.
- FSP MPinit and non FSP MPinit path are working.
Change-Id: I3605853e3e15957ea56bd8a1ce7d8a9b87a1a9e1
Signed-off-by: Patrick Rudolph <patrick.rudolph(a)9elements.com>
---
A configs/config.supermicro_x11ssh_tf.x86_64
M src/soc/intel/skylake/Kconfig
2 files changed, 4 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/60/59760/2
--
To view, visit https://review.coreboot.org/c/coreboot/+/59760
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3605853e3e15957ea56bd8a1ce7d8a9b87a1a9e1
Gerrit-Change-Number: 59760
Gerrit-PatchSet: 2
Gerrit-Owner: Patrick Rudolph <patrick.rudolph(a)9elements.com>
Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Attention: Patrick Rudolph <patrick.rudolph(a)9elements.com>
Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-MessageType: newpatchset
Attention is currently required from: YH Lin, Marco Chen, Mark Hsieh, Felix Held.
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59580 )
Change subject: mb/google/brya/var/gimble: Swap TPM I2C with touchscreen I2C
......................................................................
Patch Set 7: Code-Review+2
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/59580/comment/61a5654f_f6f6510e
PS7, Line 13: 207613972
`b:207613972`
--
To view, visit https://review.coreboot.org/c/coreboot/+/59580
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I26d059a7ea5a3fdf00de260214c00d3bba9aa7f7
Gerrit-Change-Number: 59580
Gerrit-PatchSet: 7
Gerrit-Owner: Mark Hsieh <mark_hsieh(a)wistron.corp-partner.google.com>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Marco Chen <marcochen(a)google.com>
Gerrit-Reviewer: Mark Hsieh <mark_hsieh(a)wistron.corp-partner.google.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: YH Lin <yueherngl(a)google.com>
Gerrit-Reviewer: Zhuohao Lee <zhuohao(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Anfernee Chen <anfernee_chen(a)wistron.corp-partner.google.com>
Gerrit-CC: Ariel Fang <ariel_fang(a)wistron.corp-partner.google.com>
Gerrit-CC: Casper Chang <casper_chang(a)wistron.corp-partner.google.com>
Gerrit-CC: Malik Hsu <malik_hsu(a)wistron.corp-partner.google.com>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-CC: Scott Chao <scott_chao(a)wistron.corp-partner.google.com>
Gerrit-CC: Terry Chen <terry_chen(a)wistron.corp-partner.google.com>
Gerrit-CC: Will Tsai <will_tsai(a)wistron.corp-partner.google.com>
Gerrit-Attention: YH Lin <yueherngl(a)google.com>
Gerrit-Attention: Marco Chen <marcochen(a)google.com>
Gerrit-Attention: Mark Hsieh <mark_hsieh(a)wistron.corp-partner.google.com>
Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Comment-Date: Tue, 30 Nov 2021 17:31:22 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Patrick Georgi, Julius Werner, Jan Dabros, Yu-Ping Wu.
Jakub Czapiga has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59697 )
Change subject: libpayload: Add coreboot commonlib/bsd include path
......................................................................
Patch Set 1:
(1 comment)
File payloads/libpayload/Makefile:
https://review.coreboot.org/c/coreboot/+/59697/comment/0b8ffe0d_f8e06542
PS1, Line 37: :=
> I'd propose "?=" here so it _can_ be overridden by people crazy enough for building libpayload witho […]
Sure. Do not merge it yet. I will upload changed patch tomorrow morning :)
--
To view, visit https://review.coreboot.org/c/coreboot/+/59697
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I09f475d399ab785f3d3ffdb4b42950d2b397845e
Gerrit-Change-Number: 59697
Gerrit-PatchSet: 1
Gerrit-Owner: Jakub Czapiga <jacz(a)semihalf.com>
Gerrit-Reviewer: Jan Dabros <jsd(a)semihalf.com>
Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org>
Gerrit-Reviewer: Patrick Georgi <patrick(a)coreboot.org>
Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Patrick Georgi <patrick(a)coreboot.org>
Gerrit-Attention: Julius Werner <jwerner(a)chromium.org>
Gerrit-Attention: Jan Dabros <jsd(a)semihalf.com>
Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Comment-Date: Tue, 30 Nov 2021 17:21:34 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Patrick Georgi <patrick(a)coreboot.org>
Gerrit-MessageType: comment
Attention is currently required from: Jakub Czapiga, Julius Werner.
Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59492 )
Change subject: libpayload: Add libpayload_boot_device_read function
......................................................................
Patch Set 2:
(2 comments)
File payloads/libpayload/include/boot_device.h:
https://review.coreboot.org/c/coreboot/+/59492/comment/146a63d6_35e29390
PS2, Line 1: GPS
GPL?
https://review.coreboot.org/c/coreboot/+/59492/comment/ddcd00d3_13699b8e
PS2, Line 20: libpayload_boot_device_read
I'm not that happy with the name, especially since it has to be implemented by payloads. callback_boot_device_read(), perhaps? (also not too happy about that idea)
--
To view, visit https://review.coreboot.org/c/coreboot/+/59492
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I1babd2a8414ed9de3ca49903fcb4f036997b5ff3
Gerrit-Change-Number: 59492
Gerrit-PatchSet: 2
Gerrit-Owner: Jakub Czapiga <jacz(a)semihalf.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Julius Werner <jwerner(a)chromium.org>
Gerrit-CC: Patrick Georgi <patrick(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Jakub Czapiga <jacz(a)semihalf.com>
Gerrit-Attention: Julius Werner <jwerner(a)chromium.org>
Gerrit-Comment-Date: Tue, 30 Nov 2021 17:21:34 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Jakub Czapiga, Julius Werner, Jan Dabros, Yu-Ping Wu.
Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59697 )
Change subject: libpayload: Add coreboot commonlib/bsd include path
......................................................................
Patch Set 1: Code-Review+2
(1 comment)
File payloads/libpayload/Makefile:
https://review.coreboot.org/c/coreboot/+/59697/comment/67bebc89_d5a06593
PS1, Line 37: :=
I'd propose "?=" here so it _can_ be overridden by people crazy enough for building libpayload without everything else around ;-)
--
To view, visit https://review.coreboot.org/c/coreboot/+/59697
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I09f475d399ab785f3d3ffdb4b42950d2b397845e
Gerrit-Change-Number: 59697
Gerrit-PatchSet: 1
Gerrit-Owner: Jakub Czapiga <jacz(a)semihalf.com>
Gerrit-Reviewer: Jan Dabros <jsd(a)semihalf.com>
Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org>
Gerrit-Reviewer: Patrick Georgi <patrick(a)coreboot.org>
Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Jakub Czapiga <jacz(a)semihalf.com>
Gerrit-Attention: Julius Werner <jwerner(a)chromium.org>
Gerrit-Attention: Jan Dabros <jsd(a)semihalf.com>
Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Comment-Date: Tue, 30 Nov 2021 17:14:56 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Jakub Czapiga, Julius Werner, Jan Dabros, Yu-Ping Wu.
Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59696 )
Change subject: commonlib: Move commonlib/cbmem_id.h to commonlib/bsd/
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/59696
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I97c080e34ebdbcdf14fe3a3c9515b1dea8ede179
Gerrit-Change-Number: 59696
Gerrit-PatchSet: 1
Gerrit-Owner: Jakub Czapiga <jacz(a)semihalf.com>
Gerrit-Reviewer: Jan Dabros <jsd(a)semihalf.com>
Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org>
Gerrit-Reviewer: Patrick Georgi <patrick(a)coreboot.org>
Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Jakub Czapiga <jacz(a)semihalf.com>
Gerrit-Attention: Julius Werner <jwerner(a)chromium.org>
Gerrit-Attention: Jan Dabros <jsd(a)semihalf.com>
Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Comment-Date: Tue, 30 Nov 2021 17:13:37 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment