Attention is currently required from: Felix Singer, Nico Huber, Tim Wawrzynczak, Angel Pons, Patrick Rudolph, Felix Held.
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58901 )
Change subject: device/azalia_device.h: Rewrite verb macros
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/58901
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I5b2418f6d2faf6d5ab424949d18784ca6d519799
Gerrit-Change-Number: 58901
Gerrit-PatchSet: 1
Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Attention: Nico Huber <nico.h(a)gmx.de>
Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Comment-Date: Wed, 03 Nov 2021 12:27:38 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Tim Wawrzynczak, Nick Vaccaro.
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58899 )
Change subject: [RFC] ChromeOS: Add DECLARE_x_CROS_GPIOS()
......................................................................
Patch Set 2:
(8 comments)
File src/vendorcode/google/chromeos/chromeos.h:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132173):
https://review.coreboot.org/c/coreboot/+/58899/comment/2b0a1929_6e622436
PS2, Line 110: #define DECLARE_CROS_GPIOS(x) \
please, no space before tabs
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132173):
https://review.coreboot.org/c/coreboot/+/58899/comment/7025e4bf_3f692b1c
PS2, Line 110: #define DECLARE_CROS_GPIOS(x) \
Macros with flow control statements should be avoided
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132173):
https://review.coreboot.org/c/coreboot/+/58899/comment/537be0d4_690a3ae0
PS2, Line 111: const struct cros_gpio *variant_cros_gpios(size_t *num) \
please, no space before tabs
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132173):
https://review.coreboot.org/c/coreboot/+/58899/comment/932da853_118059f6
PS2, Line 112: { \
please, no space before tabs
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132173):
https://review.coreboot.org/c/coreboot/+/58899/comment/93ed3d72_9889000d
PS2, Line 117: #define DECLARE_WEAK_CROS_GPIOS(x) \
please, no space before tabs
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132173):
https://review.coreboot.org/c/coreboot/+/58899/comment/e2cb07e8_88af9b39
PS2, Line 117: #define DECLARE_WEAK_CROS_GPIOS(x) \
Macros with flow control statements should be avoided
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132173):
https://review.coreboot.org/c/coreboot/+/58899/comment/2d1ec48a_d946e693
PS2, Line 118: const struct cros_gpio *__weak variant_cros_gpios(size_t *num) \
please, no space before tabs
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132173):
https://review.coreboot.org/c/coreboot/+/58899/comment/bb6a2935_e185db59
PS2, Line 119: { \
please, no space before tabs
--
To view, visit https://review.coreboot.org/c/coreboot/+/58899
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I88406fa1b54312616e6717af3d924436dc4ff1a6
Gerrit-Change-Number: 58899
Gerrit-PatchSet: 2
Gerrit-Owner: Kyösti Mälkki <kyosti.malkki(a)gmail.com>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-Comment-Date: Wed, 03 Nov 2021 12:24:32 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Jason Glenesk, Marshall Dawson, Tim Wawrzynczak, Nick Vaccaro, Kyösti Mälkki, Felix Held.
Hello build bot (Jenkins), Jason Glenesk, Marshall Dawson, Tim Wawrzynczak, Nick Vaccaro, Felix Held,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/58897
to look at the new patch set (#2).
Change subject: [RFC] ChromeOS: Promote variant_cros_gpio()
......................................................................
[RFC] ChromeOS: Promote variant_cros_gpio()
The only purpose of mainboard_chromeos_acpi_generate()
was to pass cros_gpio array for ACPI \\OIPG package
generation.
Promote variant_cros_gpio() from baseboards to ChromeOS
declaration.
Change-Id: I5c2ac1dcea35f1f00dea401528404bc6ca0ab53c
Signed-off-by: Kyösti Mälkki <kyosti.malkki(a)gmail.com>
---
M src/mainboard/amd/majolica/chromeos.c
M src/mainboard/emulation/qemu-q35/chromeos.c
M src/mainboard/google/auron/chromeos.c
M src/mainboard/google/beltino/chromeos.c
M src/mainboard/google/brya/chromeos.c
M src/mainboard/google/brya/variants/baseboard/include/baseboard/variants.h
M src/mainboard/google/butterfly/chromeos.c
M src/mainboard/google/cyan/chromeos.c
M src/mainboard/google/dedede/chromeos.c
M src/mainboard/google/dedede/variants/baseboard/include/baseboard/variants.h
M src/mainboard/google/deltaur/chromeos.c
M src/mainboard/google/deltaur/variants/baseboard/include/baseboard/variants.h
M src/mainboard/google/drallion/chromeos.c
M src/mainboard/google/drallion/variants/drallion/include/variant/gpio.h
M src/mainboard/google/eve/chromeos.c
M src/mainboard/google/fizz/chromeos.c
M src/mainboard/google/fizz/variants/baseboard/include/baseboard/variants.h
M src/mainboard/google/glados/chromeos.c
M src/mainboard/google/guybrush/chromeos.c
M src/mainboard/google/hatch/chromeos.c
M src/mainboard/google/hatch/variants/baseboard/include/baseboard/variants.h
M src/mainboard/google/jecht/chromeos.c
M src/mainboard/google/kahlee/chromeos.c
M src/mainboard/google/link/chromeos.c
M src/mainboard/google/octopus/chromeos.c
M src/mainboard/google/octopus/variants/baseboard/include/baseboard/variants.h
M src/mainboard/google/parrot/chromeos.c
M src/mainboard/google/poppy/chromeos.c
M src/mainboard/google/poppy/variants/baseboard/include/baseboard/variants.h
M src/mainboard/google/rambi/chromeos.c
M src/mainboard/google/reef/chromeos.c
M src/mainboard/google/reef/variants/baseboard/include/baseboard/variants.h
M src/mainboard/google/sarien/chromeos.c
M src/mainboard/google/sarien/variants/arcada/include/variant/gpio.h
M src/mainboard/google/sarien/variants/sarien/include/variant/gpio.h
M src/mainboard/google/slippy/chromeos.c
M src/mainboard/google/stout/chromeos.c
M src/mainboard/google/volteer/chromeos.c
M src/mainboard/google/volteer/variants/baseboard/include/baseboard/variants.h
M src/mainboard/google/zork/chromeos.c
M src/mainboard/intel/adlrvp/chromeos.c
M src/mainboard/intel/adlrvp/include/baseboard/variants.h
M src/mainboard/intel/baskingridge/chromeos.c
M src/mainboard/intel/coffeelake_rvp/chromeos.c
M src/mainboard/intel/coffeelake_rvp/variants/baseboard/include/baseboard/variants.h
M src/mainboard/intel/emeraldlake2/chromeos.c
M src/mainboard/intel/glkrvp/chromeos.c
M src/mainboard/intel/glkrvp/variants/baseboard/include/baseboard/variants.h
M src/mainboard/intel/icelake_rvp/chromeos.c
M src/mainboard/intel/icelake_rvp/variants/baseboard/include/baseboard/variants.h
M src/mainboard/intel/jasperlake_rvp/chromeos.c
M src/mainboard/intel/jasperlake_rvp/variants/baseboard/include/baseboard/variants.h
M src/mainboard/intel/kblrvp/chromeos.c
M src/mainboard/intel/kunimitsu/chromeos.c
M src/mainboard/intel/shadowmountain/chromeos.c
M src/mainboard/intel/shadowmountain/variants/baseboard/include/baseboard/variants.h
M src/mainboard/intel/strago/chromeos.c
M src/mainboard/intel/tglrvp/chromeos.c
M src/mainboard/intel/tglrvp/variants/baseboard/include/baseboard/variants.h
M src/mainboard/intel/wtm2/chromeos.c
M src/mainboard/samsung/lumpy/chromeos.c
M src/mainboard/samsung/stumpy/chromeos.c
M src/vendorcode/google/chromeos/acpi.c
M src/vendorcode/google/chromeos/chromeos.h
M src/vendorcode/google/chromeos/gnvs.c
65 files changed, 87 insertions(+), 280 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/97/58897/2
--
To view, visit https://review.coreboot.org/c/coreboot/+/58897
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I5c2ac1dcea35f1f00dea401528404bc6ca0ab53c
Gerrit-Change-Number: 58897
Gerrit-PatchSet: 2
Gerrit-Owner: Kyösti Mälkki <kyosti.malkki(a)gmail.com>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com>
Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com>
Gerrit-Attention: Marshall Dawson <marshalldawson3rd(a)gmail.com>
Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-Attention: Kyösti Mälkki <kyosti.malkki(a)gmail.com>
Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-MessageType: newpatchset
Attention is currently required from: Arthur Heymans.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58621 )
Change subject: mb: Move hda_verb to .c files
......................................................................
Patch Set 2:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/58621/comment/8f6f9180_694b1ca6
PS2, Line 7: mb: Move hda_verb to .c files
Can you please do one commit for each mainboard?
--
To view, visit https://review.coreboot.org/c/coreboot/+/58621
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I591bbfe8735e79d2322d191c7b99a5fc73cabe80
Gerrit-Change-Number: 58621
Gerrit-PatchSet: 2
Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Comment-Date: Wed, 03 Nov 2021 12:03:46 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Justin van Son, Christian Walter, Arthur Heymans.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58879 )
Change subject: mb/prodrive/hermes: Configure pink rear vref based on eeprom
......................................................................
Patch Set 1:
(1 comment)
File src/mainboard/prodrive/hermes/variants/r04/hda_verb.c:
https://review.coreboot.org/c/coreboot/+/58879/comment/d24749f7_7963bd54
PS1, Line 89: get_port_c_vref_cfg(board_cfg->blue_rear_vref),
> Ack, thanks for confirming
Ah, looking further into the ALC888 datasheet, I understand it now. These two commands use a 4-bit verb ID. They're "Set Coefficient Index" (0x5) and Set Processing Coefficient (0x4). They use NID 0x20, "Realtek Defined Registers".
--
To view, visit https://review.coreboot.org/c/coreboot/+/58879
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iaa11ba9c74f643e94046d4983fbce65dbedd1025
Gerrit-Change-Number: 58879
Gerrit-PatchSet: 1
Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com>
Gerrit-Reviewer: Justin van Son <justin.van.son(a)prodrive-technologies.com>
Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Justin van Son <justin.van.son(a)prodrive-technologies.com>
Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com>
Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Comment-Date: Wed, 03 Nov 2021 11:56:30 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Justin van Son <justin.van.son(a)prodrive-technologies.com>
Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-MessageType: comment