coreboot-gerrit November 2021

coreboot-gerrit@coreboot.org

1 participants
6394 discussions

Change in coreboot[master]: modify foo
by Rory Liu (Code Review) 17 Nov '21

17 Nov '21

Rory Liu has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/59378 ) Change subject: modify foo ...................................................................... modify foo Signed-off-by: Rory Liu <rory.liu(a)quanta.corp-partner.google.com> Change-Id: I717b75514d337ec72424c9e8d2c6271561c281fb --- A src/drivers/net/voo 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/78/59378/1 diff --git a/src/drivers/net/voo b/src/drivers/net/voo new file mode 100644 index 0000000..12399fc --- /dev/null +++ b/src/drivers/net/voo @@ -0,0 +1 @@ +qoo is the best -- To view, visit https://review.coreboot.org/c/coreboot/+/59378 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I717b75514d337ec72424c9e8d2c6271561c281fb Gerrit-Change-Number: 59378 Gerrit-PatchSet: 1 Gerrit-Owner: Rory Liu <rory.liu(a)quanta.corp-partner.google.com> Gerrit-MessageType: newchange

1 0

Change in coreboot[master]: test
by Rory Liu (Code Review) 17 Nov '21

17 Nov '21

Rory Liu has removed Tim Wawrzynczak from this change. ( https://review.coreboot.org/c/coreboot/+/59376 ) Change subject: test ...................................................................... Removed reviewer Tim Wawrzynczak. -- To view, visit https://review.coreboot.org/c/coreboot/+/59376 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I0028e9ee3f65365e99d94328c42d048c05d2031b Gerrit-Change-Number: 59376 Gerrit-PatchSet: 1 Gerrit-Owner: Rory Liu <rory.liu(a)quanta.corp-partner.google.com> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: deleteReviewer

1 0

Change in coreboot[master]: mb/google/brya/var/redrix: Configure _DSC for CAM devices to ACPI_DEV...
by Arec (Code Review) 17 Nov '21

17 Nov '21

Attention is currently required from: Varshit B Pandya, Chen Wisley, Tim Wawrzynczak. Arec has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59260 ) Change subject: mb/google/brya/var/redrix: Configure _DSC for CAM devices to ACPI_DEVICE_SLEEP_D3_COLD ...................................................................... Patch Set 2: (1 comment) Patchset: PS2: As far as I know, the camera sensor needs to read NVM data while camera is ON so how can we make sure the NVM is always ON before camera app is launched for these changes? -- To view, visit https://review.coreboot.org/c/coreboot/+/59260 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I88ea1b87698c63e1bd69367ee857fba3f25c84ea Gerrit-Change-Number: 59260 Gerrit-PatchSet: 2 Gerrit-Owner: Varshit B Pandya <varshit.b.pandya(a)intel.com> Gerrit-Reviewer: Chen Wisley <wisley.chen(a)quantatw.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Arec <arec.kao(a)intel.com> Gerrit-CC: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Attention: Varshit B Pandya <varshit.b.pandya(a)intel.com> Gerrit-Attention: Chen Wisley <wisley.chen(a)quantatw.com> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Comment-Date: Wed, 17 Nov 2021 03:33:41 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: test2
by Rory Liu (Code Review) 17 Nov '21

17 Nov '21

Rory Liu has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/59377 ) Change subject: test2 ...................................................................... test2 Signed-off-by: Rory Liu <rory.liu(a)quanta.corp-partner.google.com> Change-Id: I5b852d5c6ade21ff3d5f4e3de5bd057ad65ea514 --- A src/drivers/net/foo 1 file changed, 0 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/77/59377/1 diff --git a/src/drivers/net/foo b/src/drivers/net/foo new file mode 100644 index 0000000..e69de29 --- /dev/null +++ b/src/drivers/net/foo -- To view, visit https://review.coreboot.org/c/coreboot/+/59377 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I5b852d5c6ade21ff3d5f4e3de5bd057ad65ea514 Gerrit-Change-Number: 59377 Gerrit-PatchSet: 1 Gerrit-Owner: Rory Liu <rory.liu(a)quanta.corp-partner.google.com> Gerrit-MessageType: newchange

1 0

Change in coreboot[master]: test
by Rory Liu (Code Review) 17 Nov '21

17 Nov '21

Rory Liu has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/59376 ) Change subject: test ...................................................................... test Change-Id: I0028e9ee3f65365e99d94328c42d048c05d2031b Signed-off-by: Rory Liu <rory.liu(a)quanta.corp-partner.google.com> --- A src/mainboard/google/brya/variants/baseboard/brask/test 1 file changed, 0 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/76/59376/1 diff --git a/src/mainboard/google/brya/variants/baseboard/brask/test b/src/mainboard/google/brya/variants/baseboard/brask/test new file mode 100644 index 0000000..e69de29 --- /dev/null +++ b/src/mainboard/google/brya/variants/baseboard/brask/test -- To view, visit https://review.coreboot.org/c/coreboot/+/59376 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I0028e9ee3f65365e99d94328c42d048c05d2031b Gerrit-Change-Number: 59376 Gerrit-PatchSet: 1 Gerrit-Owner: Rory Liu <rory.liu(a)quanta.corp-partner.google.com> Gerrit-MessageType: newchange

1 0

Change in coreboot[master]: mb/google/volteer/var/chronicler: set DdrMemoryDown enable
by Sheng-Liang Pan (Code Review) 17 Nov '21

17 Nov '21

Attention is currently required from: Tim Wawrzynczak, Nick Vaccaro, Derek Huang. Sheng-Liang Pan has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59373 ) Change subject: mb/google/volteer/var/chronicler: set DdrMemoryDown enable ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/59373 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: If7ead2d0bb2955a4f1b81d012ee2e2518b2a82e4 Gerrit-Change-Number: 59373 Gerrit-PatchSet: 1 Gerrit-Owner: Sheng-Liang Pan <sheng-liang.pan(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Derek Huang <derek.huang(a)intel.corp-partner.google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Sheng-Liang Pan <sheng-liang.pan(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Attention: Derek Huang <derek.huang(a)intel.corp-partner.google.com> Gerrit-Comment-Date: Wed, 17 Nov 2021 03:28:14 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/volteer/var/chronicler: set DdrMemoryDown enable
by Sheng-Liang Pan (Code Review) 17 Nov '21

17 Nov '21

Attention is currently required from: Tim Wawrzynczak, Nick Vaccaro. Sheng-Liang Pan has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59373 ) Change subject: mb/google/volteer/var/chronicler: set DdrMemoryDown enable ...................................................................... Set Ready For Review -- To view, visit https://review.coreboot.org/c/coreboot/+/59373 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: If7ead2d0bb2955a4f1b81d012ee2e2518b2a82e4 Gerrit-Change-Number: 59373 Gerrit-PatchSet: 1 Gerrit-Owner: Sheng-Liang Pan <sheng-liang.pan(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Comment-Date: Wed, 17 Nov 2021 03:28:01 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: test2
by Rory Liu (Code Review) 17 Nov '21

17 Nov '21

Rory Liu has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/59375 ) Change subject: test2 ...................................................................... test2 Signed-off-by: Rory Liu <rory.liu(a)quanta.corp-partner.google.com> Change-Id: I5b852d5c6ade21ff3d5f4e3de5bd057ad65ea514 --- A src/drivers/net/foo 1 file changed, 0 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/75/59375/1 diff --git a/src/drivers/net/foo b/src/drivers/net/foo new file mode 100644 index 0000000..e69de29 --- /dev/null +++ b/src/drivers/net/foo -- To view, visit https://review.coreboot.org/c/coreboot/+/59375 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I5b852d5c6ade21ff3d5f4e3de5bd057ad65ea514 Gerrit-Change-Number: 59375 Gerrit-PatchSet: 1 Gerrit-Owner: Rory Liu <rory.liu(a)quanta.corp-partner.google.com> Gerrit-MessageType: newchange

1 0

Change in coreboot[master]: test
by Rory Liu (Code Review) 17 Nov '21

17 Nov '21

Rory Liu has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/59374 ) Change subject: test ...................................................................... test Change-Id: I0028e9ee3f65365e99d94328c42d048c05d2031b Signed-off-by: Rory Liu <rory.liu(a)quanta.corp-partner.google.com> --- A src/mainboard/google/brya/variants/baseboard/brask/test 1 file changed, 0 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/74/59374/1 diff --git a/src/mainboard/google/brya/variants/baseboard/brask/test b/src/mainboard/google/brya/variants/baseboard/brask/test new file mode 100644 index 0000000..e69de29 --- /dev/null +++ b/src/mainboard/google/brya/variants/baseboard/brask/test -- To view, visit https://review.coreboot.org/c/coreboot/+/59374 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I0028e9ee3f65365e99d94328c42d048c05d2031b Gerrit-Change-Number: 59374 Gerrit-PatchSet: 1 Gerrit-Owner: Rory Liu <rory.liu(a)quanta.corp-partner.google.com> Gerrit-MessageType: newchange

1 0

Change in coreboot[master]: mb/google/volteer/var/chronicler: set DdrMemoryDown enable
by Sheng-Liang Pan (Code Review) 17 Nov '21

17 Nov '21

Sheng-Liang Pan has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/59373 ) Change subject: mb/google/volteer/var/chronicler: set DdrMemoryDown enable ...................................................................... mb/google/volteer/var/chronicler: set DdrMemoryDown enable as doc #632048, there is a fix in MRC for this sighting but DdrMemoryDown need to be set to 1. BUG=b:192478111 BRANCH=volteer TEST=FW_NAME=chronicler emerge-volteer coreboot chromeos-bootimage Signed-off-by: Sheng-Liang Pan <sheng-liang.pan(a)quanta.corp-partner.google.com> Change-Id: If7ead2d0bb2955a4f1b81d012ee2e2518b2a82e4 --- M src/mainboard/google/volteer/variants/chronicler/memory.c 1 file changed, 6 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/73/59373/1 diff --git a/src/mainboard/google/volteer/variants/chronicler/memory.c b/src/mainboard/google/volteer/variants/chronicler/memory.c index 8ec6996..8c67a2d 100644 --- a/src/mainboard/google/volteer/variants/chronicler/memory.c +++ b/src/mainboard/google/volteer/variants/chronicler/memory.c @@ -24,3 +24,9 @@ return gpio_base2_value(spd_gpios, ARRAY_SIZE(spd_gpios)); } + +void memcfg_variant_init(FSPM_UPD *mupd) +{ + FSP_M_CONFIG *mem_cfg = &mupd->FspmConfig; + mem_cfg->DdrMemoryDown = 1; +} -- To view, visit https://review.coreboot.org/c/coreboot/+/59373 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: If7ead2d0bb2955a4f1b81d012ee2e2518b2a82e4 Gerrit-Change-Number: 59373 Gerrit-PatchSet: 1 Gerrit-Owner: Sheng-Liang Pan <sheng-liang.pan(a)quanta.corp-partner.google.com> Gerrit-MessageType: newchange

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit November 2021