coreboot-gerrit November 2021

coreboot-gerrit@coreboot.org

1 participants
6394 discussions

Change in coreboot[master]: mb/intel/adlrvp: Enable CPU PCIe RP 2
by Meera Ravindranath (Code Review) 17 Nov '21

17 Nov '21

Attention is currently required from: Meera Ravindranath. Hello build bot (Jenkins), Subrata Banik, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/59392 to look at the new patch set (#2). Change subject: mb/intel/adlrvp: Enable CPU PCIe RP 2 ...................................................................... mb/intel/adlrvp: Enable CPU PCIe RP 2 Disabling CPU PCIe RP 2 (commit:3fd39467b Fix S0ix regression) causes regression in NVMe boot on ADL-P RVP boards. Signed-off-by: Meera Ravindranath <meera.ravindranath(a)intel.com> Change-Id: I0b8b76a5537d8b80777cb7588ce6b22281af7882 --- M src/mainboard/intel/adlrvp/devicetree.cb 1 file changed, 6 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/92/59392/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/59392 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I0b8b76a5537d8b80777cb7588ce6b22281af7882 Gerrit-Change-Number: 59392 Gerrit-PatchSet: 2 Gerrit-Owner: Meera Ravindranath <meera.ravindranath(a)intel.com> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Meera Ravindranath <meera.ravindranath(a)intel.com> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: mb/google/brya/var/gimble: Include 2 new SPDs
by Angel Pons (Code Review) 17 Nov '21

17 Nov '21

Attention is currently required from: YH Lin, Furquan Shaikh, Caveh Jalali, Nick Vaccaro, Mark Hsieh, Zhuohao Lee. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59299 ) Change subject: mb/google/brya/var/gimble: Include 2 new SPDs ...................................................................... Patch Set 6: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/59299 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id3fc35605675b953bf993a29f35140f7721eedab Gerrit-Change-Number: 59299 Gerrit-PatchSet: 6 Gerrit-Owner: Mark Hsieh <mark_hsieh(a)wistron.corp-partner.google.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Caveh Jalali <caveh(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan.m.shaikh(a)gmail.com> Gerrit-Reviewer: Mark Hsieh <mark_hsieh(a)wistron.corp-partner.google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: YH Lin <yueherngl(a)google.com> Gerrit-Reviewer: Zhuohao Lee <zhuohao(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Anfernee Chen <anfernee_chen(a)wistron.corp-partner.google.com> Gerrit-CC: Ariel Fang <ariel_fang(a)wistron.corp-partner.google.com> Gerrit-CC: Casper Chang <casper_chang(a)wistron.corp-partner.google.com> Gerrit-CC: Malik Hsu <malik_hsu(a)wistron.corp-partner.google.com> Gerrit-CC: Scott Chao <scott_chao(a)wistron.corp-partner.google.com> Gerrit-CC: Terry Chen <terry_chen(a)wistron.corp-partner.google.com> Gerrit-CC: Will Tsai <will_tsai(a)wistron.corp-partner.google.com> Gerrit-Attention: YH Lin <yueherngl(a)google.com> Gerrit-Attention: Furquan Shaikh <furquan.m.shaikh(a)gmail.com> Gerrit-Attention: Caveh Jalali <caveh(a)chromium.org> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Attention: Mark Hsieh <mark_hsieh(a)wistron.corp-partner.google.com> Gerrit-Attention: Zhuohao Lee <zhuohao(a)google.com> Gerrit-Comment-Date: Wed, 17 Nov 2021 14:54:51 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: soc/intel/../thermal: Drop unused `dev` variable in pch_get_ltt_value()
by Angel Pons (Code Review) 17 Nov '21

17 Nov '21

Attention is currently required from: Maulik V Vaghela, Tim Wawrzynczak, Subrata Banik, Patrick Rudolph. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59390 ) Change subject: soc/intel/../thermal: Drop unused `dev` variable in pch_get_ltt_value() ...................................................................... Patch Set 1: Code-Review+2 (3 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/59390/comment/f3f51cd5_8e6d2580 PS1, Line 7: variable parameter https://review.coreboot.org/c/coreboot/+/59390/comment/4aaffd27_ceef72e8 PS1, Line 9: being nit: move to next line https://review.coreboot.org/c/coreboot/+/59390/comment/7b216c8e_81d66438 PS1, Line 10: replaced present tense (no final `d`): `replace` -- To view, visit https://review.coreboot.org/c/coreboot/+/59390 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iecdf6f6c3023f896a27e212d7c59b2030a3fd116 Gerrit-Change-Number: 59390 Gerrit-PatchSet: 1 Gerrit-Owner: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: EricR Lai <ericr_lai(a)compal.corp-partner.google.com> Gerrit-Reviewer: Maulik V Vaghela <maulik.v.vaghela(a)intel.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Maulik V Vaghela <maulik.v.vaghela(a)intel.com> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Comment-Date: Wed, 17 Nov 2021 14:53:24 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: soc/intel/../thermal: Compile IA common thermal block in romstage
by Angel Pons (Code Review) 17 Nov '21

17 Nov '21

Attention is currently required from: Maulik V Vaghela, Tim Wawrzynczak, Subrata Banik, Patrick Rudolph. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59391 ) Change subject: soc/intel/../thermal: Compile IA common thermal block in romstage ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/59391 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I3279f55436977ab9a47e04455d8469e50b5c33c8 Gerrit-Change-Number: 59391 Gerrit-PatchSet: 1 Gerrit-Owner: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: EricR Lai <ericr_lai(a)compal.corp-partner.google.com> Gerrit-Reviewer: Maulik V Vaghela <maulik.v.vaghela(a)intel.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Maulik V Vaghela <maulik.v.vaghela(a)intel.com> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Comment-Date: Wed, 17 Nov 2021 14:52:24 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/guybrush: Add variant_tpm_gpio_table
by Felix Held (Code Review) 17 Nov '21

17 Nov '21

Attention is currently required from: Rob Barnes, Karthik Ramasubramanian. Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59083 ) Change subject: mb/google/guybrush: Add variant_tpm_gpio_table ...................................................................... Patch Set 7: (1 comment) Patchset: PS7: seems that this patch needs a manual rebase -- To view, visit https://review.coreboot.org/c/coreboot/+/59083 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I51d087087b166ec3bb3762bc1150b34db5b22f2f Gerrit-Change-Number: 59083 Gerrit-PatchSet: 7 Gerrit-Owner: Rob Barnes <robbarnes(a)google.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Kangheui Won <khwon(a)chromium.org> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Rob Barnes <robbarnes(a)google.com> Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Comment-Date: Wed, 17 Nov 2021 14:33:26 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/brya/variants/primus: Correct SSD power sequence
by Felix Held (Code Review) 17 Nov '21

17 Nov '21

Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/59303 ) Change subject: mb/google/brya/variants/primus: Correct SSD power sequence ...................................................................... mb/google/brya/variants/primus: Correct SSD power sequence SSD sometimes can't be detected in in warm/cold boot stress. M.2 spec describes SSD_PERST# should be sequenced after power enable. BUG=b:199967106 TEST=SSD was always discovered in warm/cold boot stress. Signed-off-by: Casper Chang <casper_chang(a)wistron.corp-partner.google.com> Change-Id: I74c21cd96cf1c4518c4ed7c0b3b39e915b6b1ff7 Reviewed-on: https://review.coreboot.org/c/coreboot/+/59303 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Tim Wawrzynczak <twawrzynczak(a)chromium.org> --- M src/mainboard/google/brya/variants/primus/gpio.c 1 file changed, 4 insertions(+), 5 deletions(-) Approvals: build bot (Jenkins): Verified Tim Wawrzynczak: Looks good to me, approved diff --git a/src/mainboard/google/brya/variants/primus/gpio.c b/src/mainboard/google/brya/variants/primus/gpio.c index a324fa3..df0930c 100644 --- a/src/mainboard/google/brya/variants/primus/gpio.c +++ b/src/mainboard/google/brya/variants/primus/gpio.c @@ -78,6 +78,8 @@ PAD_CFG_GPO(GPP_A12, 1, DEEP), /* A13 : PMC_I2C_SCL ==> GSC_PCH_INT_ODL */ PAD_CFG_GPI_APIC(GPP_A13, NONE, PLTRST, LEVEL, INVERT), + /* B4 : PROC_GP3 ==> SSD_PERST_L */ + PAD_CFG_GPO(GPP_B4, 0, DEEP), /* B7 : ISH_12C1_SDA ==> PCH_I2C_TPM_SDA */ PAD_CFG_NF(GPP_B7, NONE, DEEP, NF2), /* B8 : ISH_12C1_SCL ==> PCH_I2C_TPM_SCL */ @@ -117,16 +119,13 @@ PAD_CFG_NF(GPP_H11, NONE, DEEP, NF2), /* H13 : I2C7_SCL ==> EN_PP3300_SD */ PAD_CFG_GPO(GPP_H13, 1, PLTRST), - /* B4 : PROC_GP3 ==> SSD_PERST_L - * SSD_PERST_L is released after EN_PP3300_SSD is asserted; the - * power rails take some time to come up. - */ - PAD_CFG_GPO(GPP_B4, 1, DEEP), }; static const struct pad_config romstage_gpio_table[] = { /* A12 : SATAXPCIE1 ==> EN_PPVAR_WWAN (set here for correct power sequencing) */ PAD_CFG_GPO(GPP_A12, 1, DEEP), + /* B4 : PROC_GP3 ==> SSD_PERST_L */ + PAD_CFG_GPO(GPP_B4, 1, DEEP), /* F21 : EXT_PWR_GATE2# ==> WWAN_FCPO_L (set here for correct power sequencing) */ PAD_CFG_GPO(GPP_F21, 1, DEEP), }; 2 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. -- To view, visit https://review.coreboot.org/c/coreboot/+/59303 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I74c21cd96cf1c4518c4ed7c0b3b39e915b6b1ff7 Gerrit-Change-Number: 59303 Gerrit-PatchSet: 4 Gerrit-Owner: Casper Chang <casper_chang(a)wistron.corp-partner.google.com> Gerrit-Reviewer: Ariel Fang <ariel_fang(a)wistron.corp-partner.google.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Malik Hsu <malik_hsu(a)wistron.corp-partner.google.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Terry Chen <terry_chen(a)wistron.corp-partner.google.com> Gerrit-MessageType: merged

1 0

Change in coreboot[master]: mb/google/brya: Enable early EC sync
by Felix Held (Code Review) 17 Nov '21

17 Nov '21

Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/59274 ) Change subject: mb/google/brya: Enable early EC sync ...................................................................... mb/google/brya: Enable early EC sync Enable VBOOT_EARLY_EC_SYNC in corebot BUG=b:201356952 BRANCH=None TEST=Tested on Brya id 2 Signed-off-by: Boris Mittelberg <bmbm(a)google.com> Change-Id: I6e480d64a5d90d5bb9cf59ed60b7b53af9edf46a Reviewed-on: https://review.coreboot.org/c/coreboot/+/59274 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Tim Wawrzynczak <twawrzynczak(a)chromium.org> --- M src/mainboard/google/brya/Kconfig 1 file changed, 4 insertions(+), 1 deletion(-) Approvals: build bot (Jenkins): Verified Tim Wawrzynczak: Looks good to me, approved diff --git a/src/mainboard/google/brya/Kconfig b/src/mainboard/google/brya/Kconfig index 70729c9..136bde6 100644 --- a/src/mainboard/google/brya/Kconfig +++ b/src/mainboard/google/brya/Kconfig @@ -57,7 +57,6 @@ config CHROMEOS select EC_GOOGLE_CHROMEEC_SWITCHES select HAS_RECOVERY_MRC_CACHE - select VBOOT_LID_SWITCH config CHROMEOS_WIFI_SAR bool "Enable SAR options for Chrome OS build" @@ -117,6 +116,10 @@ default "anahera" if BOARD_GOOGLE_ANAHERA default "vell" if BOARD_GOOGLE_VELL +config VBOOT + select VBOOT_EARLY_EC_SYNC + select VBOOT_LID_SWITCH + config DIMM_SPD_SIZE default 512 -- To view, visit https://review.coreboot.org/c/coreboot/+/59274 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I6e480d64a5d90d5bb9cf59ed60b7b53af9edf46a Gerrit-Change-Number: 59274 Gerrit-PatchSet: 2 Gerrit-Owner: Boris Mittelberg <bmbm(a)google.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: merged

1 0

Change in coreboot[master]: mb/google/hatch: Add VBTs for variants
by Felix Held (Code Review) 17 Nov '21

17 Nov '21

Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/59329 ) Change subject: mb/google/hatch: Add VBTs for variants ...................................................................... mb/google/hatch: Add VBTs for variants Add VBTs for all hatch variants currently supported by ChromeOS recovery images. For variants which use multiple VBTs and select at runtime, ensure these are added directly to CBFS. Change-Id: I3c62ce204e3272e778ba0a34f7a47a65d8125f53 Signed-off-by: Matt DeVillier <matt.devillier(a)gmail.com> Reviewed-on: https://review.coreboot.org/c/coreboot/+/59329 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Tim Wawrzynczak <twawrzynczak(a)chromium.org> --- M src/mainboard/google/hatch/Kconfig.name A src/mainboard/google/hatch/variants/akemi/data.vbt A src/mainboard/google/hatch/variants/dooly/data.vbt A src/mainboard/google/hatch/variants/dratini/data.vbt A src/mainboard/google/hatch/variants/duffy/data.vbt A src/mainboard/google/hatch/variants/faffy/data.vbt A src/mainboard/google/hatch/variants/hatch/data.vbt A src/mainboard/google/hatch/variants/helios/data.vbt A src/mainboard/google/hatch/variants/helios_diskswap/data.vbt A src/mainboard/google/hatch/variants/jinlon/data.vbt A src/mainboard/google/hatch/variants/kaisa/data.vbt M src/mainboard/google/hatch/variants/kindred/Makefile.inc A src/mainboard/google/hatch/variants/kindred/data.vbt A src/mainboard/google/hatch/variants/kindred/kled-data.vbt A src/mainboard/google/hatch/variants/kohaku/data.vbt M src/mainboard/google/hatch/variants/nightfury/Makefile.inc A src/mainboard/google/hatch/variants/nightfury/data.vbt A src/mainboard/google/hatch/variants/nightfury/nightfury-qled-data.vbt A src/mainboard/google/hatch/variants/noibat/data.vbt A src/mainboard/google/hatch/variants/puff/data.vbt A src/mainboard/google/hatch/variants/wyvern/data.vbt 21 files changed, 22 insertions(+), 0 deletions(-) Approvals: build bot (Jenkins): Verified Tim Wawrzynczak: Looks good to me, approved diff --git a/src/mainboard/google/hatch/Kconfig.name b/src/mainboard/google/hatch/Kconfig.name index be69a54..59e2b69 100644 --- a/src/mainboard/google/hatch/Kconfig.name +++ b/src/mainboard/google/hatch/Kconfig.name @@ -3,6 +3,7 @@ config BOARD_GOOGLE_AKEMI bool "-> Akemi (IdeaPad Flex 5/5i Chromebook)" select BOARD_GOOGLE_BASEBOARD_HATCH + select INTEL_GMA_HAVE_VBT config BOARD_GOOGLE_AMBASSADOR bool "-> Ambassador" @@ -11,23 +12,28 @@ config BOARD_GOOGLE_DOOLY bool "-> Dooly" select BOARD_GOOGLE_BASEBOARD_PUFF + select INTEL_GMA_HAVE_VBT config BOARD_GOOGLE_DRATINI bool "-> Dratini (HP Pro c640 Chromebook)" select BOARD_GOOGLE_BASEBOARD_HATCH + select INTEL_GMA_HAVE_VBT config BOARD_GOOGLE_DUFFY_LEGACY bool "-> Duffy Legacy (32MB)" select BOARD_GOOGLE_BASEBOARD_PUFF select BOARD_ROMSIZE_KB_32768 + select INTEL_GMA_HAVE_VBT config BOARD_GOOGLE_DUFFY bool "-> Duffy (ASUS Chromebox 4)" select BOARD_GOOGLE_BASEBOARD_PUFF + select INTEL_GMA_HAVE_VBT config BOARD_GOOGLE_FAFFY bool "-> Faffy (ASUS Fanless Chromebox)" select BOARD_GOOGLE_BASEBOARD_PUFF + select INTEL_GMA_HAVE_VBT config BOARD_GOOGLE_GENESIS bool "-> Genesis" @@ -37,41 +43,49 @@ bool "-> Hatch" select BOARD_GOOGLE_BASEBOARD_HATCH select BOARD_ROMSIZE_KB_32768 + select INTEL_GMA_HAVE_VBT config BOARD_GOOGLE_HELIOS bool "-> Helios (ASUS Chromebook Flip C436FA)" select BOARD_GOOGLE_BASEBOARD_HATCH select CHROMEOS_DSM_CALIB if CHROMEOS select DRIVERS_I2C_RT1011 + select INTEL_GMA_HAVE_VBT config BOARD_GOOGLE_HELIOS_DISKSWAP bool "-> Helios_Diskswap" select BOARD_GOOGLE_BASEBOARD_HATCH select CHROMEOS_DSM_CALIB if CHROMEOS select DRIVERS_I2C_RT1011 + select INTEL_GMA_HAVE_VBT config BOARD_GOOGLE_JINLON bool "-> Jinlon (HP Elite c1030 Chromebook)" select BOARD_GOOGLE_BASEBOARD_HATCH select DRIVERS_GFX_GENERIC + select INTEL_GMA_HAVE_VBT config BOARD_GOOGLE_KAISA_LEGACY bool "-> Kaisa Legacy (32MB)" select BOARD_GOOGLE_BASEBOARD_PUFF select BOARD_ROMSIZE_KB_32768 + select INTEL_GMA_HAVE_VBT config BOARD_GOOGLE_KAISA bool "-> Kaisa (Acer Chromebox CXI4)" select BOARD_GOOGLE_BASEBOARD_PUFF + select INTEL_GMA_HAVE_VBT config BOARD_GOOGLE_KINDRED bool "-> Kindred (Acer Chromebook 712)" select BOARD_GOOGLE_BASEBOARD_HATCH + select INTEL_GMA_HAVE_VBT select SOC_INTEL_COMMON_MMC_OVERRIDE config BOARD_GOOGLE_KOHAKU bool "-> Kohaku (Samsung Galaxy Chromebook)" select BOARD_GOOGLE_BASEBOARD_HATCH + select INTEL_GMA_HAVE_VBT config BOARD_GOOGLE_MOONBUGGY bool "-> Moonbuggy" @@ -86,10 +100,12 @@ select BOARD_GOOGLE_BASEBOARD_HATCH select CHROMEOS_DSM_CALIB if CHROMEOS select DRIVERS_I2C_MAX98390 + select INTEL_GMA_HAVE_VBT config BOARD_GOOGLE_NOIBAT bool "-> Noibat (HP Chromebox G3)" select BOARD_GOOGLE_BASEBOARD_PUFF + select INTEL_GMA_HAVE_VBT config BOARD_GOOGLE_PALKIA bool "-> Palkia" @@ -101,6 +117,7 @@ bool "-> Puff" select BOARD_GOOGLE_BASEBOARD_PUFF select BOARD_ROMSIZE_KB_32768 + select INTEL_GMA_HAVE_VBT config BOARD_GOOGLE_SCOUT bool "-> Scout" @@ -113,3 +130,4 @@ config BOARD_GOOGLE_WYVERN bool "-> Wyvern (CTL Chromebox CBx2)" select BOARD_GOOGLE_BASEBOARD_PUFF + select INTEL_GMA_HAVE_VBT diff --git a/src/mainboard/google/hatch/variants/akemi/data.vbt b/src/mainboard/google/hatch/variants/akemi/data.vbt new file mode 100644 index 0000000..a972fa2 --- /dev/null +++ b/src/mainboard/google/hatch/variants/akemi/data.vbt Binary files differ diff --git a/src/mainboard/google/hatch/variants/dooly/data.vbt b/src/mainboard/google/hatch/variants/dooly/data.vbt new file mode 100644 index 0000000..42fc269 --- /dev/null +++ b/src/mainboard/google/hatch/variants/dooly/data.vbt Binary files differ diff --git a/src/mainboard/google/hatch/variants/dratini/data.vbt b/src/mainboard/google/hatch/variants/dratini/data.vbt new file mode 100644 index 0000000..a8a028c --- /dev/null +++ b/src/mainboard/google/hatch/variants/dratini/data.vbt Binary files differ diff --git a/src/mainboard/google/hatch/variants/duffy/data.vbt b/src/mainboard/google/hatch/variants/duffy/data.vbt new file mode 100644 index 0000000..cda1c25 --- /dev/null +++ b/src/mainboard/google/hatch/variants/duffy/data.vbt Binary files differ diff --git a/src/mainboard/google/hatch/variants/faffy/data.vbt b/src/mainboard/google/hatch/variants/faffy/data.vbt new file mode 100644 index 0000000..cda1c25 --- /dev/null +++ b/src/mainboard/google/hatch/variants/faffy/data.vbt Binary files differ diff --git a/src/mainboard/google/hatch/variants/hatch/data.vbt b/src/mainboard/google/hatch/variants/hatch/data.vbt new file mode 100644 index 0000000..72ef315 --- /dev/null +++ b/src/mainboard/google/hatch/variants/hatch/data.vbt Binary files differ diff --git a/src/mainboard/google/hatch/variants/helios/data.vbt b/src/mainboard/google/hatch/variants/helios/data.vbt new file mode 100644 index 0000000..a972fa2 --- /dev/null +++ b/src/mainboard/google/hatch/variants/helios/data.vbt Binary files differ diff --git a/src/mainboard/google/hatch/variants/helios_diskswap/data.vbt b/src/mainboard/google/hatch/variants/helios_diskswap/data.vbt new file mode 100644 index 0000000..a972fa2 --- /dev/null +++ b/src/mainboard/google/hatch/variants/helios_diskswap/data.vbt Binary files differ diff --git a/src/mainboard/google/hatch/variants/jinlon/data.vbt b/src/mainboard/google/hatch/variants/jinlon/data.vbt new file mode 100644 index 0000000..a8a028c --- /dev/null +++ b/src/mainboard/google/hatch/variants/jinlon/data.vbt Binary files differ diff --git a/src/mainboard/google/hatch/variants/kaisa/data.vbt b/src/mainboard/google/hatch/variants/kaisa/data.vbt new file mode 100644 index 0000000..cda1c25 --- /dev/null +++ b/src/mainboard/google/hatch/variants/kaisa/data.vbt Binary files differ diff --git a/src/mainboard/google/hatch/variants/kindred/Makefile.inc b/src/mainboard/google/hatch/variants/kindred/Makefile.inc index 1676fd9..767e119 100644 --- a/src/mainboard/google/hatch/variants/kindred/Makefile.inc +++ b/src/mainboard/google/hatch/variants/kindred/Makefile.inc @@ -12,3 +12,5 @@ bootblock-y += gpio.c ramstage-y += gpio.c ramstage-y += variant.c + +$(call add_vbt_to_cbfs, vbt-kled.bin, kled-data.vbt) diff --git a/src/mainboard/google/hatch/variants/kindred/data.vbt b/src/mainboard/google/hatch/variants/kindred/data.vbt new file mode 100644 index 0000000..a972fa2 --- /dev/null +++ b/src/mainboard/google/hatch/variants/kindred/data.vbt Binary files differ diff --git a/src/mainboard/google/hatch/variants/kindred/kled-data.vbt b/src/mainboard/google/hatch/variants/kindred/kled-data.vbt new file mode 100644 index 0000000..f07cb69 --- /dev/null +++ b/src/mainboard/google/hatch/variants/kindred/kled-data.vbt Binary files differ diff --git a/src/mainboard/google/hatch/variants/kohaku/data.vbt b/src/mainboard/google/hatch/variants/kohaku/data.vbt new file mode 100644 index 0000000..31fcd1e --- /dev/null +++ b/src/mainboard/google/hatch/variants/kohaku/data.vbt Binary files differ diff --git a/src/mainboard/google/hatch/variants/nightfury/Makefile.inc b/src/mainboard/google/hatch/variants/nightfury/Makefile.inc index c0a68a8..a856f44 100644 --- a/src/mainboard/google/hatch/variants/nightfury/Makefile.inc +++ b/src/mainboard/google/hatch/variants/nightfury/Makefile.inc @@ -11,3 +11,5 @@ ramstage-y += gpio.c ramstage-y += ramstage.c ramstage-y += variant.c + +$(call add_vbt_to_cbfs, vbt-nightfury-qled.bin, nightfury-qled-data.vbt) diff --git a/src/mainboard/google/hatch/variants/nightfury/data.vbt b/src/mainboard/google/hatch/variants/nightfury/data.vbt new file mode 100644 index 0000000..31fcd1e --- /dev/null +++ b/src/mainboard/google/hatch/variants/nightfury/data.vbt Binary files differ diff --git a/src/mainboard/google/hatch/variants/nightfury/nightfury-qled-data.vbt b/src/mainboard/google/hatch/variants/nightfury/nightfury-qled-data.vbt new file mode 100644 index 0000000..a972fa2 --- /dev/null +++ b/src/mainboard/google/hatch/variants/nightfury/nightfury-qled-data.vbt Binary files differ diff --git a/src/mainboard/google/hatch/variants/noibat/data.vbt b/src/mainboard/google/hatch/variants/noibat/data.vbt new file mode 100644 index 0000000..cda1c25 --- /dev/null +++ b/src/mainboard/google/hatch/variants/noibat/data.vbt Binary files differ diff --git a/src/mainboard/google/hatch/variants/puff/data.vbt b/src/mainboard/google/hatch/variants/puff/data.vbt new file mode 100644 index 0000000..cda1c25 --- /dev/null +++ b/src/mainboard/google/hatch/variants/puff/data.vbt Binary files differ diff --git a/src/mainboard/google/hatch/variants/wyvern/data.vbt b/src/mainboard/google/hatch/variants/wyvern/data.vbt new file mode 100644 index 0000000..cda1c25 --- /dev/null +++ b/src/mainboard/google/hatch/variants/wyvern/data.vbt Binary files differ -- To view, visit https://review.coreboot.org/c/coreboot/+/59329 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I3c62ce204e3272e778ba0a34f7a47a65d8125f53 Gerrit-Change-Number: 59329 Gerrit-PatchSet: 2 Gerrit-Owner: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: merged

1 0

Change in coreboot[master]: mb/google/hatch: Alphabetize variants in Kconfig.name
by Felix Held (Code Review) 17 Nov '21

17 Nov '21

Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/59328 ) Change subject: mb/google/hatch: Alphabetize variants in Kconfig.name ...................................................................... mb/google/hatch: Alphabetize variants in Kconfig.name Change-Id: Ie29242e635bae1e2754bc1109754a64cb496af29 Signed-off-by: Matt DeVillier <matt.devillier(a)gmail.com> Reviewed-on: https://review.coreboot.org/c/coreboot/+/59328 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Tim Wawrzynczak <twawrzynczak(a)chromium.org> --- M src/mainboard/google/hatch/Kconfig.name 1 file changed, 39 insertions(+), 39 deletions(-) Approvals: build bot (Jenkins): Verified Tim Wawrzynczak: Looks good to me, approved diff --git a/src/mainboard/google/hatch/Kconfig.name b/src/mainboard/google/hatch/Kconfig.name index 9102d03..be69a54 100644 --- a/src/mainboard/google/hatch/Kconfig.name +++ b/src/mainboard/google/hatch/Kconfig.name @@ -4,6 +4,14 @@ bool "-> Akemi (IdeaPad Flex 5/5i Chromebook)" select BOARD_GOOGLE_BASEBOARD_HATCH +config BOARD_GOOGLE_AMBASSADOR + bool "-> Ambassador" + select BOARD_GOOGLE_BASEBOARD_PUFF + +config BOARD_GOOGLE_DOOLY + bool "-> Dooly" + select BOARD_GOOGLE_BASEBOARD_PUFF + config BOARD_GOOGLE_DRATINI bool "-> Dratini (HP Pro c640 Chromebook)" select BOARD_GOOGLE_BASEBOARD_HATCH @@ -21,11 +29,27 @@ bool "-> Faffy (ASUS Fanless Chromebox)" select BOARD_GOOGLE_BASEBOARD_PUFF +config BOARD_GOOGLE_GENESIS + bool "-> Genesis" + select BOARD_GOOGLE_BASEBOARD_PUFF + config BOARD_GOOGLE_HATCH bool "-> Hatch" select BOARD_GOOGLE_BASEBOARD_HATCH select BOARD_ROMSIZE_KB_32768 +config BOARD_GOOGLE_HELIOS + bool "-> Helios (ASUS Chromebook Flip C436FA)" + select BOARD_GOOGLE_BASEBOARD_HATCH + select CHROMEOS_DSM_CALIB if CHROMEOS + select DRIVERS_I2C_RT1011 + +config BOARD_GOOGLE_HELIOS_DISKSWAP + bool "-> Helios_Diskswap" + select BOARD_GOOGLE_BASEBOARD_HATCH + select CHROMEOS_DSM_CALIB if CHROMEOS + select DRIVERS_I2C_RT1011 + config BOARD_GOOGLE_JINLON bool "-> Jinlon (HP Elite c1030 Chromebook)" select BOARD_GOOGLE_BASEBOARD_HATCH @@ -40,31 +64,23 @@ bool "-> Kaisa (Acer Chromebox CXI4)" select BOARD_GOOGLE_BASEBOARD_PUFF -config BOARD_GOOGLE_KOHAKU - bool "-> Kohaku (Samsung Galaxy Chromebook)" - select BOARD_GOOGLE_BASEBOARD_HATCH - config BOARD_GOOGLE_KINDRED bool "-> Kindred (Acer Chromebook 712)" select BOARD_GOOGLE_BASEBOARD_HATCH select SOC_INTEL_COMMON_MMC_OVERRIDE -config BOARD_GOOGLE_HELIOS - bool "-> Helios (ASUS Chromebook Flip C436FA)" +config BOARD_GOOGLE_KOHAKU + bool "-> Kohaku (Samsung Galaxy Chromebook)" select BOARD_GOOGLE_BASEBOARD_HATCH - select CHROMEOS_DSM_CALIB if CHROMEOS - select DRIVERS_I2C_RT1011 + +config BOARD_GOOGLE_MOONBUGGY + bool "-> Moonbuggy" + select BOARD_GOOGLE_BASEBOARD_PUFF config BOARD_GOOGLE_MUSHU bool "-> Mushu" select BOARD_GOOGLE_BASEBOARD_HATCH -config BOARD_GOOGLE_PALKIA - bool "-> Palkia" - select BOARD_GOOGLE_BASEBOARD_HATCH - select CHROMEOS_DSM_CALIB if CHROMEOS - select DRIVERS_I2C_RT1011 - config BOARD_GOOGLE_NIGHTFURY bool "-> Nightfury (Samsung Galaxy Chromebook 2)" select BOARD_GOOGLE_BASEBOARD_HATCH @@ -75,16 +91,20 @@ bool "-> Noibat (HP Chromebox G3)" select BOARD_GOOGLE_BASEBOARD_PUFF +config BOARD_GOOGLE_PALKIA + bool "-> Palkia" + select BOARD_GOOGLE_BASEBOARD_HATCH + select CHROMEOS_DSM_CALIB if CHROMEOS + select DRIVERS_I2C_RT1011 + config BOARD_GOOGLE_PUFF bool "-> Puff" select BOARD_GOOGLE_BASEBOARD_PUFF select BOARD_ROMSIZE_KB_32768 -config BOARD_GOOGLE_HELIOS_DISKSWAP - bool "-> Helios_Diskswap" - select BOARD_GOOGLE_BASEBOARD_HATCH - select CHROMEOS_DSM_CALIB if CHROMEOS - select DRIVERS_I2C_RT1011 +config BOARD_GOOGLE_SCOUT + bool "-> Scout" + select BOARD_GOOGLE_BASEBOARD_PUFF config BOARD_GOOGLE_STRYKE bool "-> Stryke" @@ -93,23 +113,3 @@ config BOARD_GOOGLE_WYVERN bool "-> Wyvern (CTL Chromebox CBx2)" select BOARD_GOOGLE_BASEBOARD_PUFF - -config BOARD_GOOGLE_DOOLY - bool "-> Dooly" - select BOARD_GOOGLE_BASEBOARD_PUFF - -config BOARD_GOOGLE_AMBASSADOR - bool "-> Ambassador" - select BOARD_GOOGLE_BASEBOARD_PUFF - -config BOARD_GOOGLE_GENESIS - bool "-> Genesis" - select BOARD_GOOGLE_BASEBOARD_PUFF - -config BOARD_GOOGLE_SCOUT - bool "-> Scout" - select BOARD_GOOGLE_BASEBOARD_PUFF - -config BOARD_GOOGLE_MOONBUGGY - bool "-> Moonbuggy" - select BOARD_GOOGLE_BASEBOARD_PUFF -- To view, visit https://review.coreboot.org/c/coreboot/+/59328 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ie29242e635bae1e2754bc1109754a64cb496af29 Gerrit-Change-Number: 59328 Gerrit-PatchSet: 2 Gerrit-Owner: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: merged

1 0

Change in coreboot[master]: mb/google/brya: Move typeC AUX configuration to variant
by Felix Held (Code Review) 17 Nov '21

17 Nov '21

Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/59290 ) Change subject: mb/google/brya: Move typeC AUX configuration to variant ...................................................................... mb/google/brya: Move typeC AUX configuration to variant TypeC AUX configuration is variant specific. So move into variant level. BUG=b:205235144 TEST=No typeC port 0 AUX in felwinter. Signed-off-by: Eric Lai <ericr_lai(a)compal.corp-partner.google.com> Change-Id: I02bfea462cf4c6359fd8d5cca4368786ee03bc8b Reviewed-on: https://review.coreboot.org/c/coreboot/+/59290 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Tim Wawrzynczak <twawrzynczak(a)chromium.org> --- M src/mainboard/google/brya/variants/baseboard/brya/devicetree.cb M src/mainboard/google/brya/variants/brya0/overridetree.cb 2 files changed, 2 insertions(+), 2 deletions(-) Approvals: build bot (Jenkins): Verified Tim Wawrzynczak: Looks good to me, approved diff --git a/src/mainboard/google/brya/variants/baseboard/brya/devicetree.cb b/src/mainboard/google/brya/variants/baseboard/brya/devicetree.cb index c89f24f..2204a71 100644 --- a/src/mainboard/google/brya/variants/baseboard/brya/devicetree.cb +++ b/src/mainboard/google/brya/variants/baseboard/brya/devicetree.cb @@ -1,7 +1,5 @@ chip soc/intel/alderlake - register "typec_aux_bias_pads[0]" = "{.pad_auxp_dc = GPP_E22, .pad_auxn_dc = GPP_E23}" - # GPE configuration register "pmc_gpe0_dw0" = "GPP_A" register "pmc_gpe0_dw1" = "GPP_E" diff --git a/src/mainboard/google/brya/variants/brya0/overridetree.cb b/src/mainboard/google/brya/variants/brya0/overridetree.cb index 0052d90..bbba955 100644 --- a/src/mainboard/google/brya/variants/brya0/overridetree.cb +++ b/src/mainboard/google/brya/variants/brya0/overridetree.cb @@ -43,6 +43,8 @@ register "usb3_ports[1]" = "USB3_PORT_DEFAULT(OC_SKIP)" # USB3/2 Type A MLB port + register "typec_aux_bias_pads[0]" = "{.pad_auxp_dc = GPP_E22, .pad_auxn_dc = GPP_E23}" + # FIVR configurations for brya are disabled since the board doesn't have V1p05 and Vnn # bypass rails implemented. register "ext_fivr_settings" = "{ -- To view, visit https://review.coreboot.org/c/coreboot/+/59290 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I02bfea462cf4c6359fd8d5cca4368786ee03bc8b Gerrit-Change-Number: 59290 Gerrit-PatchSet: 2 Gerrit-Owner: EricR Lai <ericr_lai(a)compal.corp-partner.google.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: merged

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit November 2021