coreboot-gerrit November 2021

coreboot-gerrit@coreboot.org

1 participants
6394 discussions

Change in coreboot[master]: drivers/genesyslogic/gl9750: Add driver for Genesys Logic GL9750
by Ben Chuang (Code Review) 18 Nov '21

18 Nov '21

Ben Chuang has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/59429 ) Change subject: drivers/genesyslogic/gl9750: Add driver for Genesys Logic GL9750 ...................................................................... drivers/genesyslogic/gl9750: Add driver for Genesys Logic GL9750 The device is a PCIe Gen1 to SD 3.0 card reader controller to be used in the Chromebook. The datasheet name is GL9750S and the revision is 01. The patch disables ASPM L0s. Signed-off-by: Ben Chuang <benchuanggli(a)gmail.com> Change-Id: I6d60cef41baade7457a159d3ce2f8d2e6b66e71c --- A src/drivers/genesyslogic/gl9750/Kconfig A src/drivers/genesyslogic/gl9750/Makefile.inc A src/drivers/genesyslogic/gl9750/gl9750.c A src/drivers/genesyslogic/gl9750/gl9750.h M src/include/device/pci_ids.h 5 files changed, 71 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/29/59429/1 diff --git a/src/drivers/genesyslogic/gl9750/Kconfig b/src/drivers/genesyslogic/gl9750/Kconfig new file mode 100644 index 0000000..8c1154d --- /dev/null +++ b/src/drivers/genesyslogic/gl9750/Kconfig @@ -0,0 +1,6 @@ +config DRIVERS_GENESYSLOGIC_GL9750 + bool "Genesys Logic GL9750" + help + GL9750 is a PCI Express Rev. 1.1 compliant card reader controller + which integrates PCI Express PHY, memory card access interface, + regulators (3.3V-to-1.2V) and card power switch. diff --git a/src/drivers/genesyslogic/gl9750/Makefile.inc b/src/drivers/genesyslogic/gl9750/Makefile.inc new file mode 100644 index 0000000..0f771cc --- /dev/null +++ b/src/drivers/genesyslogic/gl9750/Makefile.inc @@ -0,0 +1 @@ +ramstage-$(CONFIG_DRIVERS_GENESYSLOGIC_GL9750) += gl9750.c diff --git a/src/drivers/genesyslogic/gl9750/gl9750.c b/src/drivers/genesyslogic/gl9750/gl9750.c new file mode 100644 index 0000000..576000e --- /dev/null +++ b/src/drivers/genesyslogic/gl9750/gl9750.c @@ -0,0 +1,50 @@ +/* SPDX-License-Identifier: GPL-2.0-only */ + +/* Driver for Genesys Logic GL9750 */ + +#include <console/console.h> +#include <device/device.h> +#include <device/path.h> +#include <device/pci.h> +#include <device/pci_ops.h> +#include <device/pci_ids.h> +#include "gl9750.h" + +static void gl9750_enable(struct device *dev) +{ + uint32_t reg; + + printk(BIOS_INFO, "GL9750: configure ASPM\n"); + + /* Set Vendor Config to be configurable */ + pci_or_config32(dev, CFG, CFG_EN); + + /* Disable ASPM L0s support */ + pci_and_config32(dev, CFG2, ~CFG2_L0S_SUPPORT); + + /* Set Vendor Config to be non-configurable */ + pci_and_config32(dev, CFG, ~CFG_EN); +} + +static struct device_operations gl9750_ops = { + .read_resources = pci_dev_read_resources, + .set_resources = pci_dev_set_resources, + .enable_resources = pci_dev_enable_resources, + .ops_pci = &pci_dev_ops_pci, + .enable = gl9750_enable +}; + +static const unsigned short pci_device_ids[] = { + PCI_DEVICE_ID_GLI_9750, + 0 +}; + +static const struct pci_driver genesyslogic_gl9750 __pci_driver = { + .ops = &gl9750_ops, + .vendor = PCI_VENDOR_ID_GLI, + .devices = pci_device_ids, +}; + +struct chip_operations drivers_generic_genesyslogic_gl9750_ops = { + CHIP_NAME("Genesys Logic GL9750") +}; diff --git a/src/drivers/genesyslogic/gl9750/gl9750.h b/src/drivers/genesyslogic/gl9750/gl9750.h new file mode 100644 index 0000000..e446cae --- /dev/null +++ b/src/drivers/genesyslogic/gl9750/gl9750.h @@ -0,0 +1,13 @@ +/* SPDX-License-Identifier: GPL-2.0-only */ + +#ifndef DRIVERS_GENESYSLOGIC_GL9750_H +#define DRIVERS_GENESYSLOGIC_GL9750_H + +/* Definitions for Genesys Logic GL9750 */ + +#define CFG 0x800 +#define CFG_EN 0x1 +#define CFG2 0x848 +#define CFG2_L0S_SUPPORT (0x1 << 6) + +#endif /* DRIVERS_GENESYSLOGIC_GL9750_H */ diff --git a/src/include/device/pci_ids.h b/src/include/device/pci_ids.h index c6ef121..a5818c6 100644 --- a/src/include/device/pci_ids.h +++ b/src/include/device/pci_ids.h @@ -2066,6 +2066,7 @@ #define PCI_VENDOR_ID_GLI 0x17a0 #define PCI_DEVICE_ID_GLI_9763E 0xe763 #define PCI_DEVICE_ID_GLI_9755 0x9755 +#define PCI_DEVICE_ID_GLI_9750 0x9750 #define PCI_VENDOR_ID_XGI 0x18ca #define PCI_DEVICE_ID_XGI_20 0x0020 -- To view, visit https://review.coreboot.org/c/coreboot/+/59429 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I6d60cef41baade7457a159d3ce2f8d2e6b66e71c Gerrit-Change-Number: 59429 Gerrit-PatchSet: 1 Gerrit-Owner: Ben Chuang <benchuanggli(a)gmail.com> Gerrit-MessageType: newchange

1 0

Change in coreboot[master]: soc/intel/alderlake: Define a method to return a cpu type
by Arthur Heymans (Code Review) 18 Nov '21

18 Nov '21

Attention is currently required from: Tim Wawrzynczak, Sridhar Siricilla, Patrick Rudolph. Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59361 ) Change subject: soc/intel/alderlake: Define a method to return a cpu type ...................................................................... Patch Set 1: (4 comments) File src/soc/intel/alderlake/cpu.c: https://review.coreboot.org/c/coreboot/+/59361/comment/f517e680_ed8dd026 PS1, Line 65: static uint32_t cpu_get_family(void) : { : return cpuid_eax(1) & 0x0FFF0FF0; : } Use get_fms(). This is returning both family and model. https://review.coreboot.org/c/coreboot/+/59361/comment/a953dcbe_9e23ef71 PS1, Line 83: & 0xFF Not needed https://review.coreboot.org/c/coreboot/+/59361/comment/63bb8b9a_2fb693ba PS1, Line 83: UINT8 No UEFI types in coreboot. https://review.coreboot.org/c/coreboot/+/59361/comment/1b3a8063_3252881a PS1, Line 84: ) : return CPUID_CORE_TYPE_INTEL_ATOM; : else : return CPUID_CORE_TYPE_INTEL_CORE; need {} on else statements if it's on the if one; https://doc.coreboot.org/contributing/coding_style.html#placing-braces-and-… -- To view, visit https://review.coreboot.org/c/coreboot/+/59361 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ifecedac822de71ebbdd43afe8431fd8aa1cdba4c Gerrit-Change-Number: 59361 Gerrit-PatchSet: 1 Gerrit-Owner: Sridhar Siricilla <sridhar.siricilla(a)intel.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Sridhar Siricilla <sridhar.siricilla(a)intel.corp-partner.google.com> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Sridhar Siricilla <sridhar.siricilla(a)intel.com> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Comment-Date: Thu, 18 Nov 2021 09:05:51 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: soc/intel: Allow enable/disable ME via CMOS
by Sean Rhodes (Code Review) 18 Nov '21

18 Nov '21

Attention is currently required from: Felix Singer, SRIDHAR SIRICILLA, Furquan Shaikh, Paul Menzel, Rizwan Qureshi, Tim Wawrzynczak, Subrata Banik, Sridhar Siricilla, Arthur Heymans, Evgeny Zinoviev, Patrick Rudolph, Felix Held. Sean Rhodes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52800 ) Change subject: soc/intel: Allow enable/disable ME via CMOS ...................................................................... Patch Set 91: (3 comments) File src/soc/intel/common/block/cse/cse.c: https://review.coreboot.org/c/coreboot/+/52800/comment/2b9cad10_34c7c03e PS88, Line 1067: me_state > That alright? Done https://review.coreboot.org/c/coreboot/+/52800/comment/23a54c73_a5a6ae3a PS88, Line 1085: enable > Slightly inefficient but clear, cool? Done File src/soc/intel/common/block/cse/cse.c: https://review.coreboot.org/c/coreboot/+/52800/comment/488b6b1f_06428fab PS90, Line 991: /* (CS)ME Disable Command */ : struct me_disable_command { : struct mkhi_hdr hdr; : uint32_t rule_id; : uint8_t rule_len; : uint32_t rule_data; : } __packed me_disable = { : .hdr = { : .group_id = MKHI_GROUP_ID_FWCAPS, : .command = MKHI_SET_ME_DISABLE, : }, : .rule_id = ME_DISABLE_RULE_ID, : .rule_len = ME_DISABLE_RULE_LENGTH, : .rule_data = ME_DISABLE_COMMAND, : }; : : struct me_disable_reply { : struct mkhi_hdr hdr; : uint32_t rule_id; : } __packed; : : struct me_disable_reply disable_reply; : : size_t disable_reply_size; : : /* (CS)ME Enable Command */ : struct me_enable_command { : struct mkhi_hdr hdr; : } me_enable = { : .hdr = { : .group_id = MKHI_GROUP_ID_BUP_COMMON, : .command = MKHI_SET_ME_ENABLE, : }, : }; : : struct me_enable_reply { : struct mkhi_hdr hdr; : } __packed; : : struct me_enable_reply enable_reply; : : size_t enable_reply_size; > Is that okay? Done -- To view, visit https://review.coreboot.org/c/coreboot/+/52800 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I374db3b7c0ded71cdc18f27970252fec7220cc20 Gerrit-Change-Number: 52800 Gerrit-PatchSet: 91 Gerrit-Owner: Sean Rhodes <admin(a)starlabs.systems> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Evgeny Zinoviev <me(a)ch1p.io> Gerrit-Reviewer: Furquan Shaikh <furquan.m.shaikh(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Reviewer: SRIDHAR SIRICILLA Gerrit-Reviewer: Sridhar Siricilla <sridhar.siricilla(a)intel.com> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: Tim Crawford <tcrawford(a)system76.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Felix Singer <felixsinger(a)posteo.net> Gerrit-CC: Andy Pont <andy.pont(a)sdcsystems.com> Gerrit-CC: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-CC: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: SRIDHAR SIRICILLA Gerrit-Attention: Furquan Shaikh <furquan.m.shaikh(a)gmail.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Attention: Sridhar Siricilla <sridhar.siricilla(a)intel.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Evgeny Zinoviev <me(a)ch1p.io> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Thu, 18 Nov 2021 08:57:25 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Felix Singer <felixsinger(a)posteo.net> Comment-In-Reply-To: Sean Rhodes <admin(a)starlabs.systems> Comment-In-Reply-To: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: util: Add coreboot-configurator
by Sean Rhodes (Code Review) 18 Nov '21

18 Nov '21

Attention is currently required from: Sean Rhodes, Martin Roth, Matt DeVillier, Tim Wawrzynczak. Hello build bot (Jenkins), Martin Roth, Matt DeVillier, Tim Wawrzynczak, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/59256 to look at the new patch set (#9). Change subject: util: Add coreboot-configurator ...................................................................... util: Add coreboot-configurator A simple GUI to change settings in coreboot's CBFS, via the nvramtool utility. Test on the StarBook Mk IV running coreboot 4.15 with: * Ubuntu 20.04 * Ubuntu 21.10 * MX Linux 21 * elementary OS 6 * Manjaro 21 Signed-off-by: Sean Rhodes <sean(a)starlabs.systems> Change-Id: I491922bf55ed87c2339897099634a38f8d055876 --- A util/coreboot-configurator/README.md A util/coreboot-configurator/images/StarLabs_Logo.png A util/coreboot-configurator/images/coreboot-configurator.gif A util/coreboot-configurator/meson.build A util/coreboot-configurator/meson_options.txt A util/coreboot-configurator/src/README.md A util/coreboot-configurator/src/application/AboutDialog.cpp A util/coreboot-configurator/src/application/AboutDialog.h A util/coreboot-configurator/src/application/AboutDialog.ui A util/coreboot-configurator/src/application/Configuration.cpp A util/coreboot-configurator/src/application/Configuration.h A util/coreboot-configurator/src/application/MainWindow.cpp A util/coreboot-configurator/src/application/MainWindow.h A util/coreboot-configurator/src/application/MainWindow.ui A util/coreboot-configurator/src/application/NvramToolCli.cpp A util/coreboot-configurator/src/application/NvramToolCli.h A util/coreboot-configurator/src/application/ToggleSwitch.cpp A util/coreboot-configurator/src/application/ToggleSwitch.h A util/coreboot-configurator/src/application/Util.h A util/coreboot-configurator/src/application/lang.qrc A util/coreboot-configurator/src/application/main.cpp A util/coreboot-configurator/src/application/meson.build A util/coreboot-configurator/src/application/qrc/categories.yaml A util/coreboot-configurator/src/application/qrc/starlabs-logo.png A util/coreboot-configurator/src/application/qrc/toggle-off.svg A util/coreboot-configurator/src/application/qrc/toggle-on.svg A util/coreboot-configurator/src/application/resources.qrc A util/coreboot-configurator/src/meson.build A util/coreboot-configurator/src/resources/coreboot-configurator.desktop A util/coreboot-configurator/src/resources/coreboot_configurator.svg A util/coreboot-configurator/src/resources/meson.build A util/coreboot-configurator/src/resources/org.coreboot.nvramtool.policy A util/coreboot-configurator/src/resources/org.coreboot.reboot.policy 33 files changed, 2,268 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/56/59256/9 -- To view, visit https://review.coreboot.org/c/coreboot/+/59256 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I491922bf55ed87c2339897099634a38f8d055876 Gerrit-Change-Number: 59256 Gerrit-PatchSet: 9 Gerrit-Owner: Sean Rhodes <admin(a)starlabs.systems> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Andy Pont <andy.pont(a)sdcsystems.com> Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Sean Rhodes <admin(a)starlabs.systems> Gerrit-Attention: Martin Roth <martinroth(a)google.com> Gerrit-Attention: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: soc/intel, soc/common: Add method to determine the cpu type mask
by Arthur Heymans (Code Review) 18 Nov '21

18 Nov '21

Attention is currently required from: Sridhar Siricilla, Tim Wawrzynczak, Patrick Rudolph. Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59360 ) Change subject: soc/intel, soc/common: Add method to determine the cpu type mask ...................................................................... Patch Set 1: (3 comments) File src/soc/intel/common/block/acpi/cpu_hybrid.c: https://review.coreboot.org/c/coreboot/+/59360/comment/ebacbc06_4a7307d2 PS1, Line 18: get_cpu_type this is only implemented in the following patch. Please order them correctly... https://review.coreboot.org/c/coreboot/+/59360/comment/9179ec90_efc0a7de PS1, Line 23: get_cpu_type_bitmask Where is this called? It's very hard to know what the purpose of all this is, as it's not explained in the commit message. https://review.coreboot.org/c/coreboot/+/59360/comment/aefa4919_7194d7ea PS1, Line 25: return global_cpu_type_bitmask; This is not thread safe and probably should only be consume when all AP have run it. -- To view, visit https://review.coreboot.org/c/coreboot/+/59360 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: If4ceb24d9bb1e808750bf618c29b2b9ea6d4191b Gerrit-Change-Number: 59360 Gerrit-PatchSet: 1 Gerrit-Owner: Sridhar Siricilla <sridhar.siricilla(a)intel.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Sridhar Siricilla <sridhar.siricilla(a)intel.corp-partner.google.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Sridhar Siricilla <sridhar.siricilla(a)intel.corp-partner.google.com> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Sridhar Siricilla <sridhar.siricilla(a)intel.com> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Comment-Date: Thu, 18 Nov 2021 08:54:19 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: util/coreboot-configurator: Add contrib files
by Sean Rhodes (Code Review) 18 Nov '21

18 Nov '21

Attention is currently required from: Sean Rhodes. Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/59257 to look at the new patch set (#4). Change subject: util/coreboot-configurator: Add contrib files ...................................................................... util/coreboot-configurator: Add contrib files Add contrib files for: * debian (Tested on Ubuntu 20.04, 21.10, MX Linux 21 and Debian) * PKGBUILD (Tested on Manjaro 21) * flatpak (Untested) Signed-off-by: Sean Rhodes <sean(a)starlabs.systems> Change-Id: Ie9f0193ed28c0842661426204fc88ec00091fbae --- A util/coreboot-configurator/contrib/PKGBUILD A util/coreboot-configurator/contrib/README.md A util/coreboot-configurator/contrib/debian/changelog A util/coreboot-configurator/contrib/debian/compat A util/coreboot-configurator/contrib/debian/control A util/coreboot-configurator/contrib/debian/files A util/coreboot-configurator/contrib/debian/rules A util/coreboot-configurator/contrib/debian/source/format A util/coreboot-configurator/contrib/flatpak/coreboot-configurator.json A util/coreboot-configurator/contrib/flatpak/org.coreboot.coreboot-configurator.json 10 files changed, 175 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/57/59257/4 -- To view, visit https://review.coreboot.org/c/coreboot/+/59257 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ie9f0193ed28c0842661426204fc88ec00091fbae Gerrit-Change-Number: 59257 Gerrit-PatchSet: 4 Gerrit-Owner: Sean Rhodes <admin(a)starlabs.systems> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Sean Rhodes <admin(a)starlabs.systems> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: util: Add coreboot-configurator
by build bot (Jenkins) (Code Review) 18 Nov '21

18 Nov '21

Attention is currently required from: Sean Rhodes, Martin Roth, Matt DeVillier, Tim Wawrzynczak. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59256 ) Change subject: util: Add coreboot-configurator ...................................................................... Patch Set 8: (108 comments) File util/coreboot-configurator/src/README.md: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133701): https://review.coreboot.org/c/coreboot/+/59256/comment/7d78b40c_a8bcbb7e PS8, Line 5: This allows `coreboot-configurator` to display them in a relavant tab, with a nice 'relavant' may be misspelled - perhaps 'relevant'? File util/coreboot-configurator/src/application/AboutDialog.h: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133701): https://review.coreboot.org/c/coreboot/+/59256/comment/9b818a52_c6513f29 PS8, Line 13: Q_OBJECT please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133701): https://review.coreboot.org/c/coreboot/+/59256/comment/bd6b1833_de810609 PS8, Line 15: public: spaces required around that ':' (ctx:VxE) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133701): https://review.coreboot.org/c/coreboot/+/59256/comment/14073f49_0a91659f PS8, Line 16: explicit AboutDialog(QWidget *parent = nullptr); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133701): https://review.coreboot.org/c/coreboot/+/59256/comment/76af28a2_81cf6552 PS8, Line 16: explicit AboutDialog(QWidget *parent = nullptr); need consistent spacing around '*' (ctx:WxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133701): https://review.coreboot.org/c/coreboot/+/59256/comment/75fb7261_b6cfce6b PS8, Line 17: ~AboutDialog(); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133701): https://review.coreboot.org/c/coreboot/+/59256/comment/9184266f_294c97cd PS8, Line 20: Ui::AboutDialog *ui; need consistent spacing around '*' (ctx:WxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133701): https://review.coreboot.org/c/coreboot/+/59256/comment/cd45c66e_ef761517 PS8, Line 20: Ui::AboutDialog *ui; labels should not be indented File util/coreboot-configurator/src/application/Configuration.h: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133701): https://review.coreboot.org/c/coreboot/+/59256/comment/ae281576_977dcd7f PS8, Line 13: using Parameters = QMap<QString,QString>; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133701): https://review.coreboot.org/c/coreboot/+/59256/comment/681869cc_7d2c1ec2 PS8, Line 13: using Parameters = QMap<QString,QString>; space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133701): https://review.coreboot.org/c/coreboot/+/59256/comment/b5a31a62_b6c8fd4b PS8, Line 13: using Parameters = QMap<QString,QString>; spaces required around that '>' (ctx:VxO) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133701): https://review.coreboot.org/c/coreboot/+/59256/comment/b29bb01e_f36530ed PS8, Line 15: Parameters fromFile(const QString& curr_path); need consistent spacing around '&' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133701): https://review.coreboot.org/c/coreboot/+/59256/comment/1259b653_ccdbc1a2 PS8, Line 16: bool toFile(const QString& curr_path, const Parameters& params); need consistent spacing around '&' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133701): https://review.coreboot.org/c/coreboot/+/59256/comment/040980d2_12040f7d PS8, Line 16: bool toFile(const QString& curr_path, const Parameters& params); need consistent spacing around '&' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133701): https://review.coreboot.org/c/coreboot/+/59256/comment/3bf96875_4c1ffbe9 PS8, Line 16: bool toFile(const QString& curr_path, const Parameters& params); function definition argument 'const Parameters' should also have an identifier name File util/coreboot-configurator/src/application/MainWindow.h: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133701): https://review.coreboot.org/c/coreboot/+/59256/comment/6c627ecd_d7c49bb0 PS8, Line 19: Q_OBJECT please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133701): https://review.coreboot.org/c/coreboot/+/59256/comment/f14c0c6b_c35a0f33 PS8, Line 21: public: spaces required around that ':' (ctx:VxE) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133701): https://review.coreboot.org/c/coreboot/+/59256/comment/fabdb8e5_a3de20a0 PS8, Line 22: MainWindow(QWidget *parent = nullptr); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133701): https://review.coreboot.org/c/coreboot/+/59256/comment/77f9c8ea_c061ff53 PS8, Line 22: MainWindow(QWidget *parent = nullptr); need consistent spacing around '*' (ctx:WxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133701): https://review.coreboot.org/c/coreboot/+/59256/comment/84c55720_0797f07e PS8, Line 23: ~MainWindow(); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133701): https://review.coreboot.org/c/coreboot/+/59256/comment/a558c9e1_2ae4e5c7 PS8, Line 26: void updateValue(const QString& key); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133701): https://review.coreboot.org/c/coreboot/+/59256/comment/b793de77_9b89b9cc PS8, Line 26: void updateValue(const QString& key); need consistent spacing around '&' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133701): https://review.coreboot.org/c/coreboot/+/59256/comment/ff9ac612_f7cce52c PS8, Line 29: void on_actionSave_triggered(); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133701): https://review.coreboot.org/c/coreboot/+/59256/comment/25d0687e_08bc7b8c PS8, Line 29: void on_actionSave_triggered(); Bad function definition - void on_actionSave_triggered() should probably be void on_actionSave_triggered(void) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133701): https://review.coreboot.org/c/coreboot/+/59256/comment/7536ab88_431e3f39 PS8, Line 31: void on_actionLoad_triggered(); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133701): https://review.coreboot.org/c/coreboot/+/59256/comment/889471da_74c0c864 PS8, Line 31: void on_actionLoad_triggered(); Bad function definition - void on_actionLoad_triggered() should probably be void on_actionLoad_triggered(void) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133701): https://review.coreboot.org/c/coreboot/+/59256/comment/63cb023a_f52331ea PS8, Line 33: void on_saveButton_clicked(); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133701): https://review.coreboot.org/c/coreboot/+/59256/comment/082840ef_4d93a3a0 PS8, Line 33: void on_saveButton_clicked(); Bad function definition - void on_saveButton_clicked() should probably be void on_saveButton_clicked(void) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133701): https://review.coreboot.org/c/coreboot/+/59256/comment/462b4885_48ff535b PS8, Line 36: void pullSettings(); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133701): https://review.coreboot.org/c/coreboot/+/59256/comment/2dc2cb2f_45bdb4ce PS8, Line 36: void pullSettings(); Bad function definition - void pullSettings() should probably be void pullSettings(void) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133701): https://review.coreboot.org/c/coreboot/+/59256/comment/3ad5580c_5ffc405c PS8, Line 37: void pushSettings(); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133701): https://review.coreboot.org/c/coreboot/+/59256/comment/8cbcd98e_0c45acc6 PS8, Line 37: void pushSettings(); Bad function definition - void pushSettings() should probably be void pushSettings(void) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133701): https://review.coreboot.org/c/coreboot/+/59256/comment/97f5771a_e3e146d2 PS8, Line 39: void generateUi(); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133701): https://review.coreboot.org/c/coreboot/+/59256/comment/991fe9da_bc2ed9ba PS8, Line 39: void generateUi(); Bad function definition - void generateUi() should probably be void generateUi(void) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133701): https://review.coreboot.org/c/coreboot/+/59256/comment/2e3214c8_fd5cd789 PS8, Line 40: void askForReboot(); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133701): https://review.coreboot.org/c/coreboot/+/59256/comment/74aba5a0_5a1846f8 PS8, Line 40: void askForReboot(); Bad function definition - void askForReboot() should probably be void askForReboot(void) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133701): https://review.coreboot.org/c/coreboot/+/59256/comment/6cf1f063_fb84bf37 PS8, Line 42: void readSettings(const QString& fileName); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133701): https://review.coreboot.org/c/coreboot/+/59256/comment/8c93d81e_657951c9 PS8, Line 42: void readSettings(const QString& fileName); need consistent spacing around '&' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133701): https://review.coreboot.org/c/coreboot/+/59256/comment/5fdb0f38_a6123d37 PS8, Line 43: void writeSettings(const QString& fileName); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133701): https://review.coreboot.org/c/coreboot/+/59256/comment/c51e49a6_006b6709 PS8, Line 43: void writeSettings(const QString& fileName); need consistent spacing around '&' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133701): https://review.coreboot.org/c/coreboot/+/59256/comment/17aa73f9_c4d94965 PS8, Line 45: Configuration::Parameters m_parameters; labels should not be indented Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133701): https://review.coreboot.org/c/coreboot/+/59256/comment/fb118726_915ea134 PS8, Line 46: YAML::Node m_categories; labels should not be indented Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133701): https://review.coreboot.org/c/coreboot/+/59256/comment/79d6159d_0d6eaffe PS8, Line 48: Ui::MainWindow *ui; need consistent spacing around '*' (ctx:WxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133701): https://review.coreboot.org/c/coreboot/+/59256/comment/895178cb_880f6c8b PS8, Line 48: Ui::MainWindow *ui; labels should not be indented Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133701): https://review.coreboot.org/c/coreboot/+/59256/comment/afa10dc6_22e76f36 PS8, Line 50: QComboBox *createComboBox(const QString &key); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133701): https://review.coreboot.org/c/coreboot/+/59256/comment/a32a92b7_a2edf7ec PS8, Line 50: QComboBox *createComboBox(const QString &key); need consistent spacing around '&' (ctx:WxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133701): https://review.coreboot.org/c/coreboot/+/59256/comment/887d2129_02c56b69 PS8, Line 51: QCheckBox *createCheckBox(const QString &key); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133701): https://review.coreboot.org/c/coreboot/+/59256/comment/2676299e_e9c003da PS8, Line 51: QCheckBox *createCheckBox(const QString &key); need consistent spacing around '&' (ctx:WxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133701): https://review.coreboot.org/c/coreboot/+/59256/comment/baaa018e_561b6113 PS8, Line 53: QTableWidget *createRawTable(); please, no spaces at the start of a line File util/coreboot-configurator/src/application/MainWindow.cpp: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133701): https://review.coreboot.org/c/coreboot/+/59256/comment/23ba0131_cfbf913e PS8, Line 17: static auto s_errorWindowTitle = MainWindow::tr("Error Occured"); 'Occured' may be misspelled - perhaps 'Occurred'? Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133701): https://review.coreboot.org/c/coreboot/+/59256/comment/935353fd_54f4f8a2 PS8, Line 355: QMessageBox::critical(this, tr("Error Occured"), tr("Can't open file to write")); 'Occured' may be misspelled - perhaps 'Occurred'? File util/coreboot-configurator/src/application/NvramToolCli.h: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133701): https://review.coreboot.org/c/coreboot/+/59256/comment/cb00a120_27c70042 PS8, Line 12: * Namespace for convinient functions to work with nvramtool CLI utility 'convinient' may be misspelled - perhaps 'convenient'? Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133701): https://review.coreboot.org/c/coreboot/+/59256/comment/ba383a85_0e6d47f8 PS8, Line 16: Configuration::Parameters readParameters(QString* error = nullptr); need consistent spacing around '*' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133701): https://review.coreboot.org/c/coreboot/+/59256/comment/dcff08bb_0528c8dc PS8, Line 17: QStringList readOptions(const QString& parameter, QString* error = nullptr); need consistent spacing around '&' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133701): https://review.coreboot.org/c/coreboot/+/59256/comment/e23bc161_1648b0cc PS8, Line 17: QStringList readOptions(const QString& parameter, QString* error = nullptr); need consistent spacing around '*' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133701): https://review.coreboot.org/c/coreboot/+/59256/comment/0ddf2909_0f69b3d7 PS8, Line 18: bool writeParameters(const Configuration::Parameters& parameters, QString* error = nullptr); need consistent spacing around '&' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133701): https://review.coreboot.org/c/coreboot/+/59256/comment/2d261f75_2e48795d PS8, Line 18: bool writeParameters(const Configuration::Parameters& parameters, QString* error = nullptr); need consistent spacing around '*' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133701): https://review.coreboot.org/c/coreboot/+/59256/comment/85313b37_e8417381 PS8, Line 18: bool writeParameters(const Configuration::Parameters& parameters, QString* error = nullptr); function definition argument 'Parameters' should also have an identifier name Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133701): https://review.coreboot.org/c/coreboot/+/59256/comment/3da589b2_678bdea8 PS8, Line 19: QString version(); Bad function definition - QString version() should probably be QString version(void) File util/coreboot-configurator/src/application/ToggleSwitch.h: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133701): https://review.coreboot.org/c/coreboot/+/59256/comment/3eac1c76_80ab09a6 PS8, Line 12: * The ToggleSwitch class represents Toggle Switch widget based on QCheckBox and toggles svg with colorscheme support line over 96 characters Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133701): https://review.coreboot.org/c/coreboot/+/59256/comment/de4540ca_1cdf2716 PS8, Line 15: Q_OBJECT please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133701): https://review.coreboot.org/c/coreboot/+/59256/comment/eda8eaf3_e7bfa123 PS8, Line 16: public: spaces required around that ':' (ctx:VxE) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133701): https://review.coreboot.org/c/coreboot/+/59256/comment/87238e23_2f2e2738 PS8, Line 17: explicit ToggleSwitch(QWidget* parent = nullptr); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133701): https://review.coreboot.org/c/coreboot/+/59256/comment/84c8ac2c_e1e617d9 PS8, Line 17: explicit ToggleSwitch(QWidget* parent = nullptr); need consistent spacing around '*' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133701): https://review.coreboot.org/c/coreboot/+/59256/comment/eaec35ea_64691db2 PS8, Line 20: QSvgRenderer m_svgr; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133701): https://review.coreboot.org/c/coreboot/+/59256/comment/e403afa8_8cfe7b29 PS8, Line 22: static const QByteArray s_toggleOnSvgContent; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133701): https://review.coreboot.org/c/coreboot/+/59256/comment/277f1b7b_b30a7866 PS8, Line 23: static const QByteArray s_toggleOffSvgContent; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133701): https://review.coreboot.org/c/coreboot/+/59256/comment/99a2dcbb_1db125e9 PS8, Line 24: static const int s_colorPosInToggleOn; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133701): https://review.coreboot.org/c/coreboot/+/59256/comment/a9868fc5_c879b37c PS8, Line 26: QByteArray m_toggleOnSvgContentColored; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133701): https://review.coreboot.org/c/coreboot/+/59256/comment/a8232df8_b0cb3a2b PS8, Line 30: void paintEvent(QPaintEvent *event) override; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133701): https://review.coreboot.org/c/coreboot/+/59256/comment/d64286de_ad872d63 PS8, Line 30: void paintEvent(QPaintEvent *event) override; need consistent spacing around '*' (ctx:WxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133701): https://review.coreboot.org/c/coreboot/+/59256/comment/6d4a806b_3bc7de0f PS8, Line 34: bool hitButton(const QPoint &pos) const override please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133701): https://review.coreboot.org/c/coreboot/+/59256/comment/7d141306_c52224b8 PS8, Line 34: bool hitButton(const QPoint &pos) const override need consistent spacing around '&' (ctx:WxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133701): https://review.coreboot.org/c/coreboot/+/59256/comment/a0060211_3f6db550 PS8, Line 35: { please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133701): https://review.coreboot.org/c/coreboot/+/59256/comment/06bf9bda_2458f7c3 PS8, Line 36: /* needs to be clickable on */ code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133701): https://review.coreboot.org/c/coreboot/+/59256/comment/06a86fea_7a50df3b PS8, Line 37: return rect().contains(pos); code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133701): https://review.coreboot.org/c/coreboot/+/59256/comment/d5cf4922_f5f46009 PS8, Line 37: return rect().contains(pos); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133701): https://review.coreboot.org/c/coreboot/+/59256/comment/46c96531_36e1eaa9 PS8, Line 38: } please, no spaces at the start of a line File util/coreboot-configurator/src/application/Util.h: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133701): https://review.coreboot.org/c/coreboot/+/59256/comment/d9d0ee7f_e867a18e PS8, Line 11: inline QMap<QString,QString> parseParameters(QIODevice& dev){ spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133701): https://review.coreboot.org/c/coreboot/+/59256/comment/541fca4e_d11847f0 PS8, Line 11: inline QMap<QString,QString> parseParameters(QIODevice& dev){ space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133701): https://review.coreboot.org/c/coreboot/+/59256/comment/e03010ed_64d260f5 PS8, Line 11: inline QMap<QString,QString> parseParameters(QIODevice& dev){ spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133701): https://review.coreboot.org/c/coreboot/+/59256/comment/9c26fe15_adf8e62b PS8, Line 11: inline QMap<QString,QString> parseParameters(QIODevice& dev){ need consistent spacing around '&' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133701): https://review.coreboot.org/c/coreboot/+/59256/comment/955cb995_fb8c1c9a PS8, Line 11: inline QMap<QString,QString> parseParameters(QIODevice& dev){ space required before the open brace '{' Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133701): https://review.coreboot.org/c/coreboot/+/59256/comment/ef47092c_3a8cd142 PS8, Line 12: QString curr_line; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133701): https://review.coreboot.org/c/coreboot/+/59256/comment/e651500e_d3d427d8 PS8, Line 13: QMap<QString, QString> result; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133701): https://review.coreboot.org/c/coreboot/+/59256/comment/93204019_b0d7264c PS8, Line 13: QMap<QString, QString> result; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133701): https://review.coreboot.org/c/coreboot/+/59256/comment/9d7b185e_27e6730b PS8, Line 13: QMap<QString, QString> result; spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133701): https://review.coreboot.org/c/coreboot/+/59256/comment/ca78804e_1eb89c9a PS8, Line 15: while (!dev.atEnd()) { please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133701): https://review.coreboot.org/c/coreboot/+/59256/comment/cd72861f_1b03b526 PS8, Line 16: curr_line = dev.readLine().trimmed(); code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133701): https://review.coreboot.org/c/coreboot/+/59256/comment/77a2168e_0ecd1ddd PS8, Line 16: curr_line = dev.readLine().trimmed(); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133701): https://review.coreboot.org/c/coreboot/+/59256/comment/e8f91578_21b73e3f PS8, Line 18: auto split = curr_line.split('='); code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133701): https://review.coreboot.org/c/coreboot/+/59256/comment/0f36371e_071ff477 PS8, Line 18: auto split = curr_line.split('='); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133701): https://review.coreboot.org/c/coreboot/+/59256/comment/2fb4a9c5_1739666e PS8, Line 19: if(split.size()!=2){ code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133701): https://review.coreboot.org/c/coreboot/+/59256/comment/8d6ba755_7f46bf02 PS8, Line 19: if(split.size()!=2){ please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133701): https://review.coreboot.org/c/coreboot/+/59256/comment/4fe9d2a3_d00f426b PS8, Line 19: if(split.size()!=2){ suspect code indent for conditional statements (8, 12) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133701): https://review.coreboot.org/c/coreboot/+/59256/comment/8318a453_5c924d7f PS8, Line 19: if(split.size()!=2){ spaces required around that '!=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133701): https://review.coreboot.org/c/coreboot/+/59256/comment/e18748b1_4493b396 PS8, Line 19: if(split.size()!=2){ space required before the open brace '{' Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133701): https://review.coreboot.org/c/coreboot/+/59256/comment/2e178636_63afeb10 PS8, Line 19: if(split.size()!=2){ space required before the open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133701): https://review.coreboot.org/c/coreboot/+/59256/comment/2b2738d1_90a2db42 PS8, Line 19: if(split.size()!=2){ braces {} are not necessary for single statement blocks Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133701): https://review.coreboot.org/c/coreboot/+/59256/comment/db64af76_dba6ded9 PS8, Line 20: continue; code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133701): https://review.coreboot.org/c/coreboot/+/59256/comment/27c91d03_2e7a22f3 PS8, Line 20: continue; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133701): https://review.coreboot.org/c/coreboot/+/59256/comment/6ace55cd_51235e94 PS8, Line 21: } code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133701): https://review.coreboot.org/c/coreboot/+/59256/comment/19d45384_7237b3b3 PS8, Line 21: } please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133701): https://review.coreboot.org/c/coreboot/+/59256/comment/24a415c5_4b8126a5 PS8, Line 23: result.insert(split[0].trimmed(), split[1].trimmed()); code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133701): https://review.coreboot.org/c/coreboot/+/59256/comment/ab46093d_f504cd31 PS8, Line 23: result.insert(split[0].trimmed(), split[1].trimmed()); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133701): https://review.coreboot.org/c/coreboot/+/59256/comment/00262586_a81621ad PS8, Line 24: } please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133701): https://review.coreboot.org/c/coreboot/+/59256/comment/e2db14a9_1dfe2f8d PS8, Line 25: return result; please, no spaces at the start of a line File util/coreboot-configurator/src/application/qrc/categories.yaml: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133701): https://review.coreboot.org/c/coreboot/+/59256/comment/7fa6660b_ad0a1c21 PS8, Line 84: help: Adjust the amout of time before the keyboard backlight turns off when un-used 'amout' may be misspelled - perhaps 'amount'? -- To view, visit https://review.coreboot.org/c/coreboot/+/59256 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I491922bf55ed87c2339897099634a38f8d055876 Gerrit-Change-Number: 59256 Gerrit-PatchSet: 8 Gerrit-Owner: Sean Rhodes <admin(a)starlabs.systems> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Andy Pont <andy.pont(a)sdcsystems.com> Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Sean Rhodes <admin(a)starlabs.systems> Gerrit-Attention: Martin Roth <martinroth(a)google.com> Gerrit-Attention: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Comment-Date: Thu, 18 Nov 2021 08:53:33 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: util: Add coreboot-configurator
by Sean Rhodes (Code Review) 18 Nov '21

18 Nov '21

Attention is currently required from: Sean Rhodes, Martin Roth, Matt DeVillier, Tim Wawrzynczak. Hello build bot (Jenkins), Martin Roth, Matt DeVillier, Tim Wawrzynczak, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/59256 to look at the new patch set (#8). Change subject: util: Add coreboot-configurator ...................................................................... util: Add coreboot-configurator A simple GUI to change settings in coreboot's CBFS, via the nvramtool utility. Signed-off-by: Sean Rhodes <sean(a)starlabs.systems> Change-Id: I491922bf55ed87c2339897099634a38f8d055876 --- A util/coreboot-configurator/README.md A util/coreboot-configurator/images/StarLabs_Logo.png A util/coreboot-configurator/images/coreboot-configurator.gif A util/coreboot-configurator/meson.build A util/coreboot-configurator/meson_options.txt A util/coreboot-configurator/src/README.md A util/coreboot-configurator/src/application/AboutDialog.cpp A util/coreboot-configurator/src/application/AboutDialog.h A util/coreboot-configurator/src/application/AboutDialog.ui A util/coreboot-configurator/src/application/Configuration.cpp A util/coreboot-configurator/src/application/Configuration.h A util/coreboot-configurator/src/application/MainWindow.cpp A util/coreboot-configurator/src/application/MainWindow.h A util/coreboot-configurator/src/application/MainWindow.ui A util/coreboot-configurator/src/application/NvramToolCli.cpp A util/coreboot-configurator/src/application/NvramToolCli.h A util/coreboot-configurator/src/application/ToggleSwitch.cpp A util/coreboot-configurator/src/application/ToggleSwitch.h A util/coreboot-configurator/src/application/Util.h A util/coreboot-configurator/src/application/lang.qrc A util/coreboot-configurator/src/application/main.cpp A util/coreboot-configurator/src/application/meson.build A util/coreboot-configurator/src/application/qrc/categories.yaml A util/coreboot-configurator/src/application/qrc/starlabs-logo.png A util/coreboot-configurator/src/application/qrc/toggle-off.svg A util/coreboot-configurator/src/application/qrc/toggle-on.svg A util/coreboot-configurator/src/application/resources.qrc A util/coreboot-configurator/src/meson.build A util/coreboot-configurator/src/resources/coreboot-configurator.desktop A util/coreboot-configurator/src/resources/coreboot_configurator.svg A util/coreboot-configurator/src/resources/meson.build A util/coreboot-configurator/src/resources/org.coreboot.nvramtool.policy A util/coreboot-configurator/src/resources/org.coreboot.reboot.policy 33 files changed, 2,268 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/56/59256/8 -- To view, visit https://review.coreboot.org/c/coreboot/+/59256 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I491922bf55ed87c2339897099634a38f8d055876 Gerrit-Change-Number: 59256 Gerrit-PatchSet: 8 Gerrit-Owner: Sean Rhodes <admin(a)starlabs.systems> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Andy Pont <andy.pont(a)sdcsystems.com> Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Sean Rhodes <admin(a)starlabs.systems> Gerrit-Attention: Martin Roth <martinroth(a)google.com> Gerrit-Attention: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: mb/google/brya/variants/gimble: Fix GL9750S SD card reader power sequ...
by Scott Chao (Code Review) 18 Nov '21

18 Nov '21

Attention is currently required from: Paul Menzel, Tim Wawrzynczak. Scott Chao has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56898 ) Change subject: mb/google/brya/variants/gimble: Fix GL9750S SD card reader power sequence ...................................................................... Patch Set 8: Code-Review+1 This change is ready for review. -- To view, visit https://review.coreboot.org/c/coreboot/+/56898 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I7d2fe8512696879936347fa8391aac21d7c17e31 Gerrit-Change-Number: 56898 Gerrit-PatchSet: 8 Gerrit-Owner: Scott Chao <scott_chao(a)wistron.corp-partner.google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: Scott Chao <scott_chao(a)wistron.corp-partner.google.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Comment-Date: Thu, 18 Nov 2021 08:50:17 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mainboard/google/brya: Enable dev screen in bios-stage for Brask
by Adam Liu (Code Review) 18 Nov '21

18 Nov '21

Attention is currently required from: Tim Wawrzynczak. Hello Tim Wawrzynczak, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/59414 to look at the new patch set (#2). Change subject: mainboard/google/brya: Enable dev screen in bios-stage for Brask ...................................................................... mainboard/google/brya: Enable dev screen in bios-stage for Brask Add Kconfig item ENABLE_TCSS_DISPLAY_DETECTION. TEST=Build with the VBT provided in issue b:199490251. Check the dev screen in bios-stage. BUG=b:199490251, b:206014054 Signed-off-by: Adam Liu <adam.liu(a)quanta.corp-partner.google.com> Change-Id: I5f34be030a6d819a0e93a2d479c4ff41bb14cfe2 --- M src/mainboard/google/brya/Kconfig 1 file changed, 2 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/14/59414/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/59414 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I5f34be030a6d819a0e93a2d479c4ff41bb14cfe2 Gerrit-Change-Number: 59414 Gerrit-PatchSet: 2 Gerrit-Owner: Adam Liu <adam.liu(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-MessageType: newpatchset

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit November 2021