coreboot-gerrit November 2021

coreboot-gerrit@coreboot.org

1 participants
6394 discussions

Change in coreboot[master]: [TEST] Updating FSP Binary repo path
by Balaji Manigandan (Code Review) 18 Nov '21

18 Nov '21

Balaji Manigandan has removed build bot (Jenkins) from this change. ( https://review.coreboot.org/c/coreboot/+/59470 ) Change subject: [TEST] Updating FSP Binary repo path ...................................................................... Removed cc build bot (Jenkins). -- To view, visit https://review.coreboot.org/c/coreboot/+/59470 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I68d57f039ec81bd9a42861984660764258b63ef8 Gerrit-Change-Number: 59470 Gerrit-PatchSet: 1 Gerrit-Owner: Balaji Manigandan <balaji.manigandan(a)intel.com> Gerrit-MessageType: deleteReviewer

1 0

Change in coreboot[master]: [TEST] Updating FSP Binary repo path
by Balaji Manigandan (Code Review) 18 Nov '21

18 Nov '21

Balaji Manigandan has removed Tim Wawrzynczak from this change. ( https://review.coreboot.org/c/coreboot/+/59470 ) Change subject: [TEST] Updating FSP Binary repo path ...................................................................... Removed reviewer Tim Wawrzynczak. -- To view, visit https://review.coreboot.org/c/coreboot/+/59470 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I68d57f039ec81bd9a42861984660764258b63ef8 Gerrit-Change-Number: 59470 Gerrit-PatchSet: 1 Gerrit-Owner: Balaji Manigandan <balaji.manigandan(a)intel.com> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: deleteReviewer

1 0

Change in coreboot[master]: [TEST] Updating FSP Binary repo path
by Balaji Manigandan (Code Review) 18 Nov '21

18 Nov '21

Attention is currently required from: Tim Wawrzynczak. Balaji Manigandan has removed Patrick Rudolph from this change. ( https://review.coreboot.org/c/coreboot/+/59470 ) Change subject: [TEST] Updating FSP Binary repo path ...................................................................... Removed reviewer Patrick Rudolph. -- To view, visit https://review.coreboot.org/c/coreboot/+/59470 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I68d57f039ec81bd9a42861984660764258b63ef8 Gerrit-Change-Number: 59470 Gerrit-PatchSet: 1 Gerrit-Owner: Balaji Manigandan <balaji.manigandan(a)intel.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-MessageType: deleteReviewer

1 0

Change in coreboot[master]: [TEST] Updating FSP Binary repo path
by Balaji Manigandan (Code Review) 18 Nov '21

18 Nov '21

Balaji Manigandan has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/59470 ) Change subject: [TEST] Updating FSP Binary repo path ...................................................................... [TEST] Updating FSP Binary repo path Signed-off-by: Balaji Manigandan B <balaji.manigandan(a)intel.com> Change-Id: I68d57f039ec81bd9a42861984660764258b63ef8 --- M src/soc/intel/alderlake/Kconfig 1 file changed, 2 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/70/59470/1 diff --git a/src/soc/intel/alderlake/Kconfig b/src/soc/intel/alderlake/Kconfig index 58b9051..89a9fb4 100644 --- a/src/soc/intel/alderlake/Kconfig +++ b/src/soc/intel/alderlake/Kconfig @@ -1,5 +1,6 @@ config SOC_INTEL_ALDERLAKE bool + select HAVE_INTEL_FSP_REPO help Intel Alderlake support @@ -277,6 +278,7 @@ config FSP_HEADER_PATH string "Location of FSP headers" + default "3rdparty/blobs/intel/adl/fsp/Include/" if HAVE_INTEL_FSP_REPO default "src/vendorcode/intel/fsp/fsp2_0/alderlake/" config FSP_FD_PATH -- To view, visit https://review.coreboot.org/c/coreboot/+/59470 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I68d57f039ec81bd9a42861984660764258b63ef8 Gerrit-Change-Number: 59470 Gerrit-PatchSet: 1 Gerrit-Owner: Balaji Manigandan <balaji.manigandan(a)intel.com> Gerrit-MessageType: newchange

1 0

Change in coreboot[master]: doc/mb/ocp: update Delta Lake documentation
by Arthur Heymans (Code Review) 18 Nov '21

18 Nov '21

Arthur Heymans has submitted this change. ( https://review.coreboot.org/c/coreboot/+/58979 ) Change subject: doc/mb/ocp: update Delta Lake documentation ...................................................................... doc/mb/ocp: update Delta Lake documentation Update Delta Lake document following the publish of OCP blog and the Wiwynn press release. Signed-off-by: Jonathan Zhang <jonzhang(a)fb.com> Change-Id: I3eaa765bf9918988b4b5cb01e8607a5c27b9bd17 Reviewed-on: https://review.coreboot.org/c/coreboot/+/58979 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Johnny Lin <Johnny_Lin(a)wiwynn.com> Reviewed-by: Christian Walter <christian.walter(a)9elements.com> Reviewed-by: Arthur Heymans <arthur(a)aheymans.xyz> --- M Documentation/mainboard/ocp/deltalake.md 1 file changed, 14 insertions(+), 2 deletions(-) Approvals: build bot (Jenkins): Verified Arthur Heymans: Looks good to me, approved Christian Walter: Looks good to me, approved Johnny Lin: Looks good to me, but someone else must approve diff --git a/Documentation/mainboard/ocp/deltalake.md b/Documentation/mainboard/ocp/deltalake.md index 8906ad8..3f80538 100644 --- a/Documentation/mainboard/ocp/deltalake.md +++ b/Documentation/mainboard/ocp/deltalake.md @@ -7,7 +7,16 @@ OCP Delta Lake server platform is a component of multi-host server system Yosemite-V3. Both [Delta Lake server design spec] and [Yosemite-V3 design -spec] were contributed to [OCP]. +spec] were [OCP] accepted. + +On the other hand, Wiwynn's Yosemite-V3 system and Delta Lake server product +along with its OSF implementation, which is based on FSP/coreboot/LinuxBoot +stack, was [OCP] accepted; For details, check: +- [The OCP blog] +- [The Wiwynn Press Release] +- [The Wiwynn's Yosemite-V3 product in OCP market place] +Wiwynn and 9Elements formed a partnership to offer the Wiwynn's Yosemite-V3 +product and OSF for it. Delta Lake server is a single socket Cooper Lake Scalable Processor (CPX-SP) server. Intel Cooper Lake Scalable Processor was launched in Q2 2020. @@ -15,7 +24,7 @@ Yosemite-V3 has multiple configurations. Depending on configurations, it may host up to 4 Delta Lake servers (blades) in one sled. -The Yosemite-V3 system is in mass production. Facebook, Intel and partners +The Yosemite-V3 system is in mass production. Meta, Intel and partners jointly develop Open System Firmware (OSF) solution on Delta Lake as an alternative solution. The OSF solution is based on FSP/coreboot/LinuxBoot stack. The OSF solution reached production quality for some use cases in July, 2021. @@ -187,6 +196,9 @@ [OCP]: https://www.opencompute.org [Delta Lake server design spec]: https://www.opencompute.org/documents/delta-lake-1s-server-design-specifica… [Yosemite-V3 design spec]: https://www.opencompute.org/documents/ocp-yosemite-v3-platform-design-speci… +[The OCP blog]: https://www.opencompute.org/blog/open-system-firmware-for-ocp-server-deltal… +[The Wiwynn Press Release]: https://www.prnewswire.com/news-releases/wiwynn-successfully-implemented-op… +[The Wiwynn's Yosemite-V3 product in OCP market place]: https://www.opencompute.org/products/423/wiwynn-yosemite-v3-server [osf-builder]: https://github.com/facebookincubator/osf-builder [OCP virtual summit 2020]: https://www.opencompute.org/summit/virtual-summit/schedule [flashrom]: https://flashrom.org/Flashrom -- To view, visit https://review.coreboot.org/c/coreboot/+/58979 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I3eaa765bf9918988b4b5cb01e8607a5c27b9bd17 Gerrit-Change-Number: 58979 Gerrit-PatchSet: 3 Gerrit-Owner: Jonathan Zhang <jonzhang(a)fb.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: merged

1 0

Change in coreboot[master]: doc/mb/ocp: update Delta Lake documentation
by Arthur Heymans (Code Review) 18 Nov '21

18 Nov '21

Attention is currently required from: Jonathan Zhang, Paul Menzel. Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58979 ) Change subject: doc/mb/ocp: update Delta Lake documentation ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/58979 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I3eaa765bf9918988b4b5cb01e8607a5c27b9bd17 Gerrit-Change-Number: 58979 Gerrit-PatchSet: 2 Gerrit-Owner: Jonathan Zhang <jonzhang(a)fb.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Jonathan Zhang <jonzhang(a)fb.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Comment-Date: Thu, 18 Nov 2021 12:30:57 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/teleplatforms/D4E4S16P8: Add new CRB teleplatforms/D4E4S16P8
by Kyösti Mälkki (Code Review) 18 Nov '21

18 Nov '21

Attention is currently required from: Дмитрий Понаморев, Mariusz Szafrański, Paul Menzel, Suresh Bellampalli, Vanessa Eusebio, Michal Motyl, Patrick Rudolph, King Sumo. Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/57194 ) Change subject: mb/teleplatforms/D4E4S16P8: Add new CRB teleplatforms/D4E4S16P8 ...................................................................... Patch Set 19: (6 comments) File src/mainboard/teleplatforms/D4E4S16P8/Kconfig: https://review.coreboot.org/c/coreboot/+/57194/comment/d151c591_4c33f0c0 PS17, Line 14: ## > I'll adjust the licenses to one-liners. Done File src/mainboard/teleplatforms/D4E4S16P8/Kconfig: https://review.coreboot.org/c/coreboot/+/57194/comment/a1a67915_13f2e5fd PS19, Line 31: default "1.0.12" This should be explicitly set only for a release to avoid mistaking development builds as releases. Seems like src/Kconfig:config LOCALVERSION will achieve the same thing. File src/mainboard/teleplatforms/D4E4S16P8/gpio.h: https://review.coreboot.org/c/coreboot/+/57194/comment/fb54c321_d29a2e7f PS18, Line 9: const struct dnv_pad_config D4E4S16P8_gpio_table[] = { > No data, only prototypes and defines in .h files. Done File src/mainboard/teleplatforms/D4E4S16P8/hsio.h: https://review.coreboot.org/c/coreboot/+/57194/comment/e902a849_7d0e4b09 PS18, Line 9: const BL_HSIO_INFORMATION D4E4S16P8_hsio_config[] = { > No data, only prototypes and defines in .h files. Done File src/mainboard/teleplatforms/D4E4S16P8/ramstage.c: https://review.coreboot.org/c/coreboot/+/57194/comment/ddcbf45f_0d129759 PS18, Line 28: if (tmp == 0x3f/*?*/ || (tmp < 0x20 || tmp > 0x7f)) { > I'll recude this to BIOS_SPEW. […] Done File src/mainboard/teleplatforms/D4E4S16P8/smbus.c: https://review.coreboot.org/c/coreboot/+/57194/comment/2e709a89_ce4d6f5c PS17, Line 81: .device = 0x19df, /* Denverton SMBus0 "Legacy" device id */ > This file is not specific to your board, I'll remove it here. […] Done -- To view, visit https://review.coreboot.org/c/coreboot/+/57194 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: If654fc7a391643b50f2e52755fd7c11a37bfd188 Gerrit-Change-Number: 57194 Gerrit-PatchSet: 19 Gerrit-Owner: Дмитрий Понаморев <dponamorev(a)gmail.com> Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Mariusz Szafrański <mariuszx.szafranski(a)intel.com> Gerrit-Reviewer: Michal Motyl <michalx.motyl(a)intel.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Suresh Bellampalli <suresh.bellampalli(a)intel.com> Gerrit-Reviewer: Vanessa Eusebio <vanessa.f.eusebio(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: Дмитрий Понаморев <dponamorev(a)gmail.com> Gerrit-CC: King Sumo <kingsumos(a)gmail.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Дмитрий Понаморев <dponamorev(a)gmail.com> Gerrit-Attention: Mariusz Szafrański <mariuszx.szafranski(a)intel.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Suresh Bellampalli <suresh.bellampalli(a)intel.com> Gerrit-Attention: Vanessa Eusebio <vanessa.f.eusebio(a)intel.com> Gerrit-Attention: Michal Motyl <michalx.motyl(a)intel.com> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Attention: King Sumo <kingsumos(a)gmail.com> Gerrit-Comment-Date: Thu, 18 Nov 2021 12:28:48 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: [WIP] teleplatforms/D4E4S16P8: Configure ast25xx bootstraps
by build bot (Jenkins) (Code Review) 18 Nov '21

18 Nov '21

Attention is currently required from: Suresh Bellampalli, Vanessa Eusebio, Michal Motyl, Patrick Rudolph. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36607 ) Change subject: [WIP] teleplatforms/D4E4S16P8: Configure ast25xx bootstraps ...................................................................... Patch Set 12: (3 comments) File src/mainboard/teleplatforms/D4E4S16P8/ast25xx.c: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133711): https://review.coreboot.org/c/coreboot/+/36607/comment/7dd39c20_1e01d4c6 PS12, Line 44: printk(BIOS_INFO, "ast25xx: disable protection status: @ 0x%p 0x%08x\n", scu_protection, locks); line over 96 characters Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133711): https://review.coreboot.org/c/coreboot/+/36607/comment/4ed542f9_735e5c23 PS12, Line 47: printk(BIOS_INFO, "ast25xx: scu70_hwtrap current bits: @ 0x%p 0x%08x\n", scu_hwtrap, straps); line over 96 characters Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133711): https://review.coreboot.org/c/coreboot/+/36607/comment/e6f1238c_cc65acc3 PS12, Line 76: printk(BIOS_INFO, "ast25xx: p2p_bridge0: 0x%x; p2p_bridge1: 0x%x\n", p2p_bridge0, p2p_bridge1); line over 96 characters -- To view, visit https://review.coreboot.org/c/coreboot/+/36607 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I92195969419f9c38845cb67f294fdab33fb481af Gerrit-Change-Number: 36607 Gerrit-PatchSet: 12 Gerrit-Owner: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Mariusz Szafrański <mariuszx.szafranski(a)intel.com> Gerrit-Reviewer: Michal Motyl <michalx.motyl(a)intel.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Suresh Bellampalli <suresh.bellampalli(a)intel.com> Gerrit-Reviewer: Vanessa Eusebio <vanessa.f.eusebio(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: Дмитрий Понаморев <dponamorev(a)gmail.com> Gerrit-CC: David Guckian <d.guckian20(a)gmail.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Suresh Bellampalli <suresh.bellampalli(a)intel.com> Gerrit-Attention: Vanessa Eusebio <vanessa.f.eusebio(a)intel.com> Gerrit-Attention: Michal Motyl <michalx.motyl(a)intel.com> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Comment-Date: Thu, 18 Nov 2021 12:14:03 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: [WIP] soc/intel/denverton_ns: Use common SMBus support code
by Kyösti Mälkki (Code Review) 18 Nov '21

18 Nov '21

Attention is currently required from: Mariusz Szafrański, Suresh Bellampalli, Vanessa Eusebio, Michal Motyl, Patrick Rudolph. Kyösti Mälkki has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/59469 ) Change subject: [WIP] soc/intel/denverton_ns: Use common SMBus support code ...................................................................... [WIP] soc/intel/denverton_ns: Use common SMBus support code Change-Id: I233d198b894f10fbf0042a5023ae8a9c14136513 Signed-off-by: Kyösti Mälkki <kyosti.malkki(a)gmail.com> --- M src/soc/intel/common/block/smbus/smbus.c M src/soc/intel/denverton_ns/Kconfig M src/soc/intel/denverton_ns/include/soc/pci_devs.h M src/soc/intel/denverton_ns/include/soc/smbus.h 4 files changed, 6 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/69/59469/1 diff --git a/src/soc/intel/common/block/smbus/smbus.c b/src/soc/intel/common/block/smbus/smbus.c index 4a46143..d0eb9ce 100644 --- a/src/soc/intel/common/block/smbus/smbus.c +++ b/src/soc/intel/common/block/smbus/smbus.c @@ -91,6 +91,7 @@ PCI_DEVICE_ID_INTEL_ADP_P_SMBUS, PCI_DEVICE_ID_INTEL_ADP_S_SMBUS, PCI_DEVICE_ID_INTEL_ADP_M_SMBUS, + PCI_DEVICE_ID_INTEL_DENVERTON_SMBUS_LEGACY, 0 }; diff --git a/src/soc/intel/denverton_ns/Kconfig b/src/soc/intel/denverton_ns/Kconfig index 0643384..37d6ee5 100644 --- a/src/soc/intel/denverton_ns/Kconfig +++ b/src/soc/intel/denverton_ns/Kconfig @@ -34,6 +34,7 @@ select SOC_INTEL_COMMON_BLOCK_FAST_SPI select SOC_INTEL_COMMON_BLOCK_GPIO select SOC_INTEL_COMMON_BLOCK_PCR + select SOC_INTEL_COMMON_BLOCK_SMBUS select TSC_MONOTONIC_TIMER select TSC_SYNC_MFENCE select UDELAY_TSC diff --git a/src/soc/intel/denverton_ns/include/soc/pci_devs.h b/src/soc/intel/denverton_ns/include/soc/pci_devs.h index 0cb4c98..9fa38e4 100644 --- a/src/soc/intel/denverton_ns/include/soc/pci_devs.h +++ b/src/soc/intel/denverton_ns/include/soc/pci_devs.h @@ -139,9 +139,11 @@ #define PCH_DEV_SLOT_LPC 0x1f #define PCH_DEVFN_LPC _PCH_DEVFN(LPC, 0) #define PCH_DEVFN_PMC _PCH_DEVFN(LPC, 2) +#define PCH_DEVFN_SMBUS _PCH_DEVFN(LPC, 4) #define PCH_DEVFN_SPI _PCH_DEVFN(LPC, 5) #define PCH_DEV_LPC _PCH_DEV(LPC, 0) #define PCH_DEV_SPI _PCH_DEV(LPC, 5) +#define PCH_DEV_SMBUS _PCH_DEV(LPC, 4) /* VT-d support value to match FSP settings */ /* "PCH IOAPIC Config" */ diff --git a/src/soc/intel/denverton_ns/include/soc/smbus.h b/src/soc/intel/denverton_ns/include/soc/smbus.h index e51d8a7..240a0e9 100644 --- a/src/soc/intel/denverton_ns/include/soc/smbus.h +++ b/src/soc/intel/denverton_ns/include/soc/smbus.h @@ -41,6 +41,8 @@ #define SMLINK_PIN_CTL 0xe #define SMBUS_PIN_CTL 0xf +#define SMBUS_SLAVE_ADDR 0x24 + /* * SMBus Private Config Registers (PID:SMB) */ -- To view, visit https://review.coreboot.org/c/coreboot/+/59469 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I233d198b894f10fbf0042a5023ae8a9c14136513 Gerrit-Change-Number: 59469 Gerrit-PatchSet: 1 Gerrit-Owner: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Mariusz Szafrański <mariuszx.szafranski(a)intel.com> Gerrit-Reviewer: Michal Motyl <michalx.motyl(a)intel.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Suresh Bellampalli <suresh.bellampalli(a)intel.com> Gerrit-Reviewer: Vanessa Eusebio <vanessa.f.eusebio(a)intel.com> Gerrit-Attention: Mariusz Szafrański <mariuszx.szafranski(a)intel.com> Gerrit-Attention: Suresh Bellampalli <suresh.bellampalli(a)intel.com> Gerrit-Attention: Vanessa Eusebio <vanessa.f.eusebio(a)intel.com> Gerrit-Attention: Michal Motyl <michalx.motyl(a)intel.com> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-MessageType: newchange

1 0

Change in coreboot[master]: [WIP] teleplatforms/D4E4S16P8: Configure ast25xx bootstraps
by Kyösti Mälkki (Code Review) 18 Nov '21

18 Nov '21

Attention is currently required from: Suresh Bellampalli, Vanessa Eusebio, Michal Motyl, Patrick Rudolph. Hello build bot (Jenkins), Дмитрий Понаморев, Mariusz Szafrański, Suresh Bellampalli, Vanessa Eusebio, Michal Motyl, Patrick Rudolph, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/36607 to look at the new patch set (#12). Change subject: [WIP] teleplatforms/D4E4S16P8: Configure ast25xx bootstraps ...................................................................... [WIP] teleplatforms/D4E4S16P8: Configure ast25xx bootstraps Configure graphics PCI device as VGA using software bootstrap bits. TBD: Can we delay this to be done as a common PCI driver. TBD: Add Kconfig guard. Change-Id: I92195969419f9c38845cb67f294fdab33fb481af Signed-off-by: Kyösti Mälkki <kyosti.malkki(a)gmail.com> --- M src/mainboard/teleplatforms/D4E4S16P8/Makefile.inc A src/mainboard/teleplatforms/D4E4S16P8/ast25xx.c M src/soc/intel/denverton_ns/chip.c M src/soc/intel/denverton_ns/include/soc/ramstage.h 4 files changed, 208 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/07/36607/12 -- To view, visit https://review.coreboot.org/c/coreboot/+/36607 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I92195969419f9c38845cb67f294fdab33fb481af Gerrit-Change-Number: 36607 Gerrit-PatchSet: 12 Gerrit-Owner: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Mariusz Szafrański <mariuszx.szafranski(a)intel.com> Gerrit-Reviewer: Michal Motyl <michalx.motyl(a)intel.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Suresh Bellampalli <suresh.bellampalli(a)intel.com> Gerrit-Reviewer: Vanessa Eusebio <vanessa.f.eusebio(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: Дмитрий Понаморев <dponamorev(a)gmail.com> Gerrit-CC: David Guckian <d.guckian20(a)gmail.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Suresh Bellampalli <suresh.bellampalli(a)intel.com> Gerrit-Attention: Vanessa Eusebio <vanessa.f.eusebio(a)intel.com> Gerrit-Attention: Michal Motyl <michalx.motyl(a)intel.com> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-MessageType: newpatchset

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit November 2021