coreboot-gerrit November 2021

coreboot-gerrit@coreboot.org

1 participants
6394 discussions

Change in coreboot[master]: google/trogdor: Update the power on sequence of ps8640
by Xuxin Xiong (Code Review) 24 Nov '21

24 Nov '21

Xuxin Xiong has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58994 ) Change subject: google/trogdor: Update the power on sequence of ps8640 ...................................................................... Patch Set 3: (2 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/58994/comment/6eb84be5_48dd6325 PS3, Line 2: xuxinxiong > Got it, Thanks! Done https://review.coreboot.org/c/coreboot/+/58994/comment/f090995a_ea332b0c PS3, Line 17: xuxinxiong > Got it, Thanks! Done -- To view, visit https://review.coreboot.org/c/coreboot/+/58994 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia378aafa49ec462c990501ce48721e330d9648b0 Gerrit-Change-Number: 58994 Gerrit-PatchSet: 3 Gerrit-Owner: Xuxin Xiong <xuxinxiong(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: Douglas Anderson <dianders(a)chromium.org> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Wentao Qin <qinwentao(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: 9elements QA <hardwaretestrobot(a)gmail.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Comment-Date: Wed, 24 Nov 2021 02:38:56 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org> Comment-In-Reply-To: Xuxin Xiong <xuxinxiong(a)huaqin.corp-partner.google.com> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/brya/var/brask: Set PL and PsysPL
by Hou-hsun Lee (Code Review) 24 Nov '21

24 Nov '21

Attention is currently required from: David Wu, Zhuohao Lee, Alan Huang. Hou-hsun Lee has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59576 ) Change subject: mb/google/brya/var/brask: Set PL and PsysPL ...................................................................... Patch Set 1: (2 comments) File src/mainboard/google/brya/variants/brask/ramstage.c: https://review.coreboot.org/c/coreboot/+/59576/comment/afc7e4b3_2d2449d1 PS1, Line 18: { PCI_DEVICE_ID_INTEL_ADL_P_ID_1, 45, 5000, 45000, 80000, 80000, 159000 }, Those PL2/PL4 values look like coming from baseline config. Have you decided to use baseline or performance line config for Brask? Btw, from ADL MoW WW46 (doc#626774), the 442 45W SKU (which maps to PCI_DEVICE_ID_INTEL_ADL_P_ID_1) had some PD optimization relaxation. The PL2 is down to 95W, and PL4 is down to 125W, please update the settings for this SKU accordingly. https://review.coreboot.org/c/coreboot/+/59576/comment/71ad9937_f9f45700 PS1, Line 23: { PCI_DEVICE_ID_INTEL_ADL_P_ID_7, 15, 135, 257 }, If the psys_pmax_power is not used at all, I think it's better to remove it to avoid confusion. The psys_pmax calculation is done by psys_imax_ma * volts_mv in variant_update_psys_power_limits(). Is my understanding correct? -- To view, visit https://review.coreboot.org/c/coreboot/+/59576 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I9261902b8c892d0b866f326b24988039c1d30b56 Gerrit-Change-Number: 59576 Gerrit-PatchSet: 1 Gerrit-Owner: Alan Huang <alan-huang(a)quanta.corp-partner.google.com> Gerrit-Reviewer: David Wu <david_wu(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Hou-hsun Lee <hou-hsun.lee(a)intel.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: Zhuohao Lee <zhuohao(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: David Wu <david_wu(a)quanta.corp-partner.google.com> Gerrit-Attention: Zhuohao Lee <zhuohao(a)google.com> Gerrit-Attention: Alan Huang <alan-huang(a)quanta.corp-partner.google.com> Gerrit-Comment-Date: Wed, 24 Nov 2021 02:19:11 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/brya/var/vell: update memory settings
by Kevin Chiu (Code Review) 24 Nov '21

24 Nov '21

Attention is currently required from: YH Lin, Nick Vaccaro, Shon Wang. Kevin Chiu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59334 ) Change subject: mb/google/brya/var/vell: update memory settings ...................................................................... Patch Set 5: (2 comments) File src/mainboard/google/brya/variants/vell/memory.c: https://review.coreboot.org/c/coreboot/+/59334/comment/5b9fd38b_cf723c13 PS5, Line 7: __weak remove if you want to override https://review.coreboot.org/c/coreboot/+/59334/comment/dfd315dc_a8cc96db PS5, Line 26: __weak remove if you want to override -- To view, visit https://review.coreboot.org/c/coreboot/+/59334 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic0bbac5eaebc77639be6c1bc399658ac90e72fbb Gerrit-Change-Number: 59334 Gerrit-PatchSet: 5 Gerrit-Owner: Shon Wang <shon.wang(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: YH Lin <yueherngl(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Kevin Chiu <Kevin.Chiu(a)quantatw.com> Gerrit-CC: Kevin Chiu <kevin.chiu.17802(a)gmail.com> Gerrit-CC: Robert Chen <robert.chen(a)quanta.corp-partner.google.com> Gerrit-CC: Wisley Chen <wisley.chen(a)quanta.corp-partner.google.com> Gerrit-Attention: YH Lin <yueherngl(a)google.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Attention: Shon Wang <shon.wang(a)quanta.corp-partner.google.com> Gerrit-Comment-Date: Wed, 24 Nov 2021 02:12:35 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/brya/variants/primus: update gpios for power consumption
by Malik Hsu (Code Review) 24 Nov '21

24 Nov '21

Attention is currently required from: Tim Wawrzynczak. Malik Hsu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59563 ) Change subject: mb/google/brya/variants/primus: update gpios for power consumption ...................................................................... Patch Set 5: (2 comments) File src/mainboard/google/brya/variants/primus/variant.c: https://review.coreboot.org/c/coreboot/+/59563/comment/9f9f37a0_c202f324 PS4, Line 46: get_sku_and_set_gpio > suggestion: […] Done https://review.coreboot.org/c/coreboot/+/59563/comment/cb729f30_c9d6a709 PS4, Line 48: int sku = gpio_get(GPP_T2); : : if (sku == 1) > nit: as fars as I can tell, this GPIO is just stuffed on boards with the eMMC, so let's avoid the te […] Done -- To view, visit https://review.coreboot.org/c/coreboot/+/59563 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I753e41dec1825299e6cd437b5f67e2d957bc6148 Gerrit-Change-Number: 59563 Gerrit-PatchSet: 5 Gerrit-Owner: Malik Hsu <malik_hsu(a)wistron.corp-partner.google.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Casper Chang <casper_chang(a)wistron.corp-partner.google.com> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Comment-Date: Wed, 24 Nov 2021 01:29:14 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: amdfwtool: merge lookup table to psp fw table
by Kangheui Won (Code Review) 24 Nov '21

24 Nov '21

Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/59584 to look at the new patch set (#2). Change subject: amdfwtool: merge lookup table to psp fw table ...................................................................... amdfwtool: merge lookup table to psp fw table Merge psp_dir_valid_entries into amd_psp_fw_table. PSPBTLDR_WL_FILE and PSPBTLDR_AB_FILE needs additional logic since both points to the same firmware entry and which one to include depends on commandline option. BUG=b:206909680 TEST=build guybrush and confirm amdfw and coreboot.rom are identical Signed-off-by: Kangheui Won <khwon(a)chromium.org> Change-Id: I552240e53fa0e2f8bef5026e007c8b54458bd656 --- M util/amdfwtool/amdfwtool.c M util/amdfwtool/amdfwtool.h M util/amdfwtool/data_parse.c 3 files changed, 116 insertions(+), 127 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/84/59584/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/59584 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I552240e53fa0e2f8bef5026e007c8b54458bd656 Gerrit-Change-Number: 59584 Gerrit-PatchSet: 2 Gerrit-Owner: Kangheui Won <khwon(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: amdfwtool: replace strcmp to switch-case
by Kangheui Won (Code Review) 24 Nov '21

24 Nov '21

Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/59583 to look at the new patch set (#2). Change subject: amdfwtool: replace strcmp to switch-case ...................................................................... amdfwtool: replace strcmp to switch-case Since we have separate function for filename to fw_type conversion, when we determine whether we should include the firmware or not we have fw_type. Replace strcmp in if-else to switch-case so it looks more clear. However PSPBTLDR_WL_FILE and PSPBTLDR_AB_FILE have same fw_type so we should use strmp for them. BUG=b:206909680 TEST=build guybrush and confirm amdfw and coreboot.rom are identical Signed-off-by: Kangheui Won <khwon(a)chromium.org> Change-Id: Icf9f3465a36d83cf79f9f4bd1ec824b546a71aaf --- M util/amdfwtool/data_parse.c 1 file changed, 29 insertions(+), 34 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/83/59583/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/59583 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Icf9f3465a36d83cf79f9f4bd1ec824b546a71aaf Gerrit-Change-Number: 59583 Gerrit-PatchSet: 2 Gerrit-Owner: Kangheui Won <khwon(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: guybrush: add RO_GSCVD area to FMAP
by Vadim Bendebury (Code Review) 24 Nov '21

24 Nov '21

Attention is currently required from: Hung-Te Lin, Furquan Shaikh, Mathew King, Paul Menzel, Julius Werner, Karthik Ramasubramanian. Vadim Bendebury has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/57864 ) Change subject: guybrush: add RO_GSCVD area to FMAP ...................................................................... Patch Set 2: (1 comment) Patchset: PS2: > Guybrush leads should give the +2, but looks good to me now. (Not sure who that is... […] yes, I think we should add these to all boards in dev, it won't hurt to allocate 8K in megabytes of flash. -- To view, visit https://review.coreboot.org/c/coreboot/+/57864 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ifa24d5a6271a8bcbf737d4580ec85b9cfdd9af01 Gerrit-Change-Number: 57864 Gerrit-PatchSet: 2 Gerrit-Owner: Vadim Bendebury <vbendeb(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan.m.shaikh(a)gmail.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Mathew King <mathewk(a)chromium.org> Gerrit-Reviewer: Vadim Bendebury <vbendeb(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Furquan Shaikh <furquan.m.shaikh(a)gmail.com> Gerrit-Attention: Mathew King <mathewk(a)chromium.org> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Comment-Date: Wed, 24 Nov 2021 00:59:36 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Julius Werner <jwerner(a)chromium.org> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: src/mb/brya: Enable crashlog on brya0
by Kane Chen (Code Review) 24 Nov '21

24 Nov '21

Attention is currently required from: Gaggery Tsai, Francois Toguo Fotso, Tim Wawrzynczak. Kane Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59486 ) Change subject: src/mb/brya: Enable crashlog on brya0 ...................................................................... Patch Set 7: (1 comment) File src/mainboard/google/brya/Kconfig: https://review.coreboot.org/c/coreboot/+/59486/comment/92140bcf_d87f1dd2 PS6, Line 51: SOC_INTEL_CRASHLOG > Hi Tim, […] Done -- To view, visit https://review.coreboot.org/c/coreboot/+/59486 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib4bbe5d7cece0c6c5fc170460d55ac820054abb9 Gerrit-Change-Number: 59486 Gerrit-PatchSet: 7 Gerrit-Owner: Kane Chen <kane.chen(a)intel.corp-partner.google.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Francois Toguo Fotso <francois.toguo.fotso(a)intel.com> Gerrit-Reviewer: Gaggery Tsai <gaggery.tsai(a)intel.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Gaggery Tsai <gaggery.tsai(a)intel.com> Gerrit-Attention: Francois Toguo Fotso <francois.toguo.fotso(a)intel.com> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Comment-Date: Wed, 24 Nov 2021 00:51:23 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Kane Chen <kane.chen(a)intel.corp-partner.google.com> Comment-In-Reply-To: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: src/mb/brya: Enable crashlog on brya0
by Kane Chen (Code Review) 24 Nov '21

24 Nov '21

Attention is currently required from: Gaggery Tsai, Francois Toguo Fotso, Tim Wawrzynczak. Hello Gaggery Tsai, build bot (Jenkins), Francois Toguo Fotso, Tim Wawrzynczak, Arthur Heymans, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/59486 to look at the new patch set (#7). Change subject: src/mb/brya: Enable crashlog on brya0 ...................................................................... src/mb/brya: Enable crashlog on brya0 Enabling crashlog helps partners to debug hang issues efficiently. BUG=b:195327879 TEST=Found BERT table is created and the tcss function is ok in depthcharge. Warm/cold/suspend_stress test pass 50 cycles on gimble Change-Id: Ib4bbe5d7cece0c6c5fc170460d55ac820054abb9 Signed-off-by: Kane Chen <kane.chen(a)intel.corp-partner.google.com> --- M src/mainboard/google/brya/Kconfig.name 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/86/59486/7 -- To view, visit https://review.coreboot.org/c/coreboot/+/59486 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib4bbe5d7cece0c6c5fc170460d55ac820054abb9 Gerrit-Change-Number: 59486 Gerrit-PatchSet: 7 Gerrit-Owner: Kane Chen <kane.chen(a)intel.corp-partner.google.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Francois Toguo Fotso <francois.toguo.fotso(a)intel.com> Gerrit-Reviewer: Gaggery Tsai <gaggery.tsai(a)intel.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Gaggery Tsai <gaggery.tsai(a)intel.com> Gerrit-Attention: Francois Toguo Fotso <francois.toguo.fotso(a)intel.com> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: mb/google/brya/var/primus: Update thermal table for primus
by Ariel Fang (Code Review) 24 Nov '21

24 Nov '21

Attention is currently required from: Tim Wawrzynczak. Ariel Fang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59182 ) Change subject: mb/google/brya/var/primus: Update thermal table for primus ...................................................................... Patch Set 9: (1 comment) File src/mainboard/google/brya/variants/primus/overridetree.cb: https://review.coreboot.org/c/coreboot/+/59182/comment/e05f6455_d05ab2f1 PS8, Line 79: [0] = DPTF_PASSIVE(CPU, CPU, 95, 5000), : [1] = DPTF_PASSIVE(CPU, TEMP_SENSOR_0, 90, 5000), : [2] = DPTF_PASSIVE(CHARGER, TEMP_SENSOR_1, 90, 5000), : [3] = DPTF_PASSIVE(CPU, TEMP_SENSOR_2, 90, 5000), : [4] = DPTF_PASSIVE(CPU, TEMP_SENSOR_3, 90, 5000), > can you line up each column? done -- To view, visit https://review.coreboot.org/c/coreboot/+/59182 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id4d8dbe678b7f0870aeffa0a0118e65de9d5c22d Gerrit-Change-Number: 59182 Gerrit-PatchSet: 9 Gerrit-Owner: Ariel Fang <ariel_fang(a)wistron.corp-partner.google.com> Gerrit-Reviewer: Ariel Fang <ariel_fang(a)wistron.corp-partner.google.com> Gerrit-Reviewer: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Casper Chang <casper_chang(a)wistron.corp-partner.google.com> Gerrit-CC: Malik Hsu <malik_hsu(a)wistron.corp-partner.google.com> Gerrit-CC: Mark Hsieh <mark_hsieh(a)wistron.corp-partner.google.com> Gerrit-CC: Scott Chao <scott_chao(a)wistron.corp-partner.google.com> Gerrit-CC: Terry Chen <terry_chen(a)wistron.corp-partner.google.com> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Comment-Date: Wed, 24 Nov 2021 00:15:44 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-MessageType: comment

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit November 2021