coreboot-gerrit November 2021

coreboot-gerrit@coreboot.org

1 participants
6394 discussions

Change in coreboot[master]: mb/google/brya/var/vell: update gpio override
by Kevin Chiu (Code Review) 24 Nov '21

24 Nov '21

Attention is currently required from: Tim Wawrzynczak, Kevin Chiu, Shon Wang. Kevin Chiu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59305 ) Change subject: mb/google/brya/var/vell: update gpio override ...................................................................... Set Ready For Review -- To view, visit https://review.coreboot.org/c/coreboot/+/59305 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Icc91866f7555c294af7eed9e5d1550e73d8059d0 Gerrit-Change-Number: 59305 Gerrit-PatchSet: 8 Gerrit-Owner: Kevin Chiu <kevin.chiu.17802(a)gmail.com> Gerrit-Reviewer: Kevin Chiu <Kevin.Chiu(a)quantatw.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Kevin Chiu <Kevin.Chiu(a)quantatw.com> Gerrit-Attention: Shon Wang <shon.wang(a)quanta.corp-partner.google.com> Gerrit-Comment-Date: Wed, 24 Nov 2021 07:30:20 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: soc/intel/elkhartlake: Update SA DIDs Table
by Werner Zeh (Code Review) 24 Nov '21

24 Nov '21

Attention is currently required from: akino.liao(a)intel.com, Rick Lee, Mario Scheithauer, Lean Sheng Tan, Patrick Rudolph. Werner Zeh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59559 ) Change subject: soc/intel/elkhartlake: Update SA DIDs Table ...................................................................... Patch Set 2: Code-Review+2 (2 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/59559/comment/fede7de5_2767dd97 PS1, Line 7: & IGD > remove this. only SA table updated. Done https://review.coreboot.org/c/coreboot/+/59559/comment/cc94977c_06447d2d PS1, Line 8: Update SA table as per latest EDS (Doc no: 601458). > please add a line before this. Done -- To view, visit https://review.coreboot.org/c/coreboot/+/59559 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia2bb9e54456dbea634c2b8e192f9fe813b9e6706 Gerrit-Change-Number: 59559 Gerrit-PatchSet: 2 Gerrit-Owner: Rick Lee <rick.lee(a)intel.com> Gerrit-Reviewer: Lean Sheng Tan <tanleansheng(a)outlook.com> Gerrit-Reviewer: Mario Scheithauer <mario.scheithauer(a)siemens.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Praveen HP <praveen.hodagatta.pranesh(a)intel.com> Gerrit-Reviewer: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Reviewer: akino.liao(a)intel.com Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: akino.liao(a)intel.com Gerrit-Attention: Rick Lee <rick.lee(a)intel.com> Gerrit-Attention: Mario Scheithauer <mario.scheithauer(a)siemens.com> Gerrit-Attention: Lean Sheng Tan <tanleansheng(a)outlook.com> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Comment-Date: Wed, 24 Nov 2021 07:30:20 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Lean Sheng Tan <tanleansheng(a)outlook.com> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/brya/variants/primus: add fw config probe for speaker amp
by Malik Hsu (Code Review) 24 Nov '21

24 Nov '21

Malik Hsu has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/59613 ) Change subject: mb/google/brya/variants/primus: add fw config probe for speaker amp ...................................................................... mb/google/brya/variants/primus: add fw config probe for speaker amp Added fw config probe for MX98360A. BUG=b:205883511 TEST=emerge-brya coreboot chromeos-bootimage and check audio function Signed-off-by: Malik_Hsu <malik_hsu(a)wistron.corp-partner.google.com> Change-Id: I2452b752ce58a5d0f1008cf187fb79ace6c4285f --- M src/mainboard/google/brya/variants/primus/overridetree.cb 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/13/59613/1 diff --git a/src/mainboard/google/brya/variants/primus/overridetree.cb b/src/mainboard/google/brya/variants/primus/overridetree.cb index 6a064a7..9bd3aac 100644 --- a/src/mainboard/google/brya/variants/primus/overridetree.cb +++ b/src/mainboard/google/brya/variants/primus/overridetree.cb @@ -259,6 +259,7 @@ register "sdmode_delay" = "5" device generic 0 on probe AUDIO MAX98360_ALC5682I_I2S + probe AUDIO MAX98360_ALC5682I_VS_I2S end end end -- To view, visit https://review.coreboot.org/c/coreboot/+/59613 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I2452b752ce58a5d0f1008cf187fb79ace6c4285f Gerrit-Change-Number: 59613 Gerrit-PatchSet: 1 Gerrit-Owner: Malik Hsu <malik_hsu(a)wistron.corp-partner.google.com> Gerrit-MessageType: newchange

1 0

Change in coreboot[master]: soc/intel/elkhartlake: Update SA DIDs Table
by Rick Lee (Code Review) 24 Nov '21

24 Nov '21

Attention is currently required from: akino.liao(a)intel.com, Rick Lee, Mario Scheithauer, Werner Zeh, Patrick Rudolph. Hello Praveen HP, akino.liao(a)intel.com, build bot (Jenkins), Mario Scheithauer, Lean Sheng Tan, Werner Zeh, Patrick Rudolph, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/59559 to look at the new patch set (#2). Change subject: soc/intel/elkhartlake: Update SA DIDs Table ...................................................................... soc/intel/elkhartlake: Update SA DIDs Table Update SA table as per latest EDS (Doc no: 601458). Add extra SKUs accordingly. Signed-off-by: Rick Lee <rick.lee(a)intel.com> Change-Id: Ia2bb9e54456dbea634c2b8e192f9fe813b9e6706 --- M src/include/device/pci_ids.h M src/soc/intel/common/block/systemagent/systemagent.c M src/soc/intel/elkhartlake/bootblock/report_platform.c 3 files changed, 6 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/59/59559/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/59559 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia2bb9e54456dbea634c2b8e192f9fe813b9e6706 Gerrit-Change-Number: 59559 Gerrit-PatchSet: 2 Gerrit-Owner: Rick Lee <rick.lee(a)intel.com> Gerrit-Reviewer: Lean Sheng Tan <tanleansheng(a)outlook.com> Gerrit-Reviewer: Mario Scheithauer <mario.scheithauer(a)siemens.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Praveen HP <praveen.hodagatta.pranesh(a)intel.com> Gerrit-Reviewer: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Reviewer: akino.liao(a)intel.com Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: akino.liao(a)intel.com Gerrit-Attention: Rick Lee <rick.lee(a)intel.com> Gerrit-Attention: Mario Scheithauer <mario.scheithauer(a)siemens.com> Gerrit-Attention: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: mb/google/dedede/var/beetley: Enable Wifi SAR for beetley
by Weimin Wu (Code Review) 24 Nov '21

24 Nov '21

Attention is currently required from: Henry Sun, Karthik Ramasubramanian, Wizard Shen. Weimin Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59544 ) Change subject: mb/google/dedede/var/beetley: Enable Wifi SAR for beetley ...................................................................... Patch Set 2: Code-Review-1 (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/59544/comment/d9c16b0c_eb27d8bb PS2, Line 7: Enable Wifi SAR This change only enable GEO_SAR_ENABLE. Please confirm whether enabled CHROMEOS_WIFI_SAR. -- To view, visit https://review.coreboot.org/c/coreboot/+/59544 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib1682cdafe1b6ed7cc0cf23624f83d2e5bbfb92e Gerrit-Change-Number: 59544 Gerrit-PatchSet: 2 Gerrit-Owner: Wizard Shen <shenhu5(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: Henry Sun <henrysun(a)google.com> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Weimin Wu <wuweimin(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: zanxi chen <chenzanxi(a)huaqin.corp-partner.google.com> Gerrit-CC: Krystal Han <hanlijing(a)huaqin.corp-partner.google.com> Gerrit-Attention: Henry Sun <henrysun(a)google.com> Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Attention: Wizard Shen <shenhu5(a)huaqin.corp-partner.google.com> Gerrit-Comment-Date: Wed, 24 Nov 2021 06:48:54 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/brya/var/vell: update overridetree
by Kevin Chiu (Code Review) 24 Nov '21

24 Nov '21

Attention is currently required from: Tim Wawrzynczak, Kevin Chiu, Shon Wang. Kevin Chiu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59304 ) Change subject: mb/google/brya/var/vell: update overridetree ...................................................................... Patch Set 3: (1 comment) File src/mainboard/google/brya/Kconfig.name: https://review.coreboot.org/c/coreboot/+/59304/comment/f0e83851_4f4a8344 PS2, Line 73: BOARD_GOOGLE_BASEBOARD_BRY > `BOARD_GOOGLE_BASEBOARD_BRYA` Done -- To view, visit https://review.coreboot.org/c/coreboot/+/59304 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ibaa910eb1c5584197907963781258035c668298e Gerrit-Change-Number: 59304 Gerrit-PatchSet: 3 Gerrit-Owner: Kevin Chiu <kevin.chiu.17802(a)gmail.com> Gerrit-Reviewer: Kevin Chiu <Kevin.Chiu(a)quantatw.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Kevin Chiu <Kevin.Chiu(a)quantatw.com> Gerrit-Attention: Shon Wang <shon.wang(a)quanta.corp-partner.google.com> Gerrit-Comment-Date: Wed, 24 Nov 2021 06:35:53 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/brya/var/vell: update overridetree
by Kevin Chiu (Code Review) 24 Nov '21

24 Nov '21

Attention is currently required from: Kevin Chiu, Tim Wawrzynczak, Shon Wang. Kevin Chiu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59304 ) Change subject: mb/google/brya/var/vell: update overridetree ...................................................................... Set Ready For Review -- To view, visit https://review.coreboot.org/c/coreboot/+/59304 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ibaa910eb1c5584197907963781258035c668298e Gerrit-Change-Number: 59304 Gerrit-PatchSet: 3 Gerrit-Owner: Kevin Chiu <kevin.chiu.17802(a)gmail.com> Gerrit-Reviewer: Kevin Chiu <Kevin.Chiu(a)quantatw.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Kevin Chiu <kevin.chiu.17802(a)gmail.com> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Kevin Chiu <Kevin.Chiu(a)quantatw.com> Gerrit-Attention: Shon Wang <shon.wang(a)quanta.corp-partner.google.com> Gerrit-Comment-Date: Wed, 24 Nov 2021 06:32:51 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/brya/var/vell: update gpio override
by Kevin Chiu (Code Review) 24 Nov '21

24 Nov '21

Attention is currently required from: Kevin Chiu, Tim Wawrzynczak, Shon Wang. Kevin Chiu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59305 ) Change subject: mb/google/brya/var/vell: update gpio override ...................................................................... Set Ready For Review -- To view, visit https://review.coreboot.org/c/coreboot/+/59305 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Icc91866f7555c294af7eed9e5d1550e73d8059d0 Gerrit-Change-Number: 59305 Gerrit-PatchSet: 8 Gerrit-Owner: Kevin Chiu <kevin.chiu.17802(a)gmail.com> Gerrit-Reviewer: Kevin Chiu <Kevin.Chiu(a)quantatw.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Kevin Chiu <kevin.chiu.17802(a)gmail.com> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Kevin Chiu <Kevin.Chiu(a)quantatw.com> Gerrit-Attention: Shon Wang <shon.wang(a)quanta.corp-partner.google.com> Gerrit-Comment-Date: Wed, 24 Nov 2021 06:32:27 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: sc7280: Add support for edp driver & mdp driver
by build bot (Jenkins) (Code Review) 24 Nov '21

24 Nov '21

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59612 ) Change subject: sc7280: Add support for edp driver & mdp driver ...................................................................... Patch Set 1: (118 comments) File src/mainboard/google/herobrine/mainboard.c: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134173): https://review.coreboot.org/c/coreboot/+/59612/comment/bc38b545_ba4a3c69 PS1, Line 62: if (display_init_required()) { suspect code indent for conditional statements (8, 24) File src/soc/qualcomm/sc7280/display/edp_aux.c: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134173): https://review.coreboot.org/c/coreboot/+/59612/comment/bdb51664_45280cd5 PS1, Line 99: printk(BIOS_ERR,"%s: invalid size or buffer \n",__func__); space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134173): https://review.coreboot.org/c/coreboot/+/59612/comment/a978c86c_f267bc93 PS1, Line 99: printk(BIOS_ERR,"%s: invalid size or buffer \n",__func__); space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134173): https://review.coreboot.org/c/coreboot/+/59612/comment/14cadae6_50889836 PS1, Line 99: printk(BIOS_ERR,"%s: invalid size or buffer \n",__func__); unnecessary whitespace before a quoted newline Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134173): https://review.coreboot.org/c/coreboot/+/59612/comment/c6037785_7a80f759 PS1, Line 106: printk(BIOS_ERR,"%s: invalid msg: size(%zu), request(%x)\n", space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134173): https://review.coreboot.org/c/coreboot/+/59612/comment/1645edd5_2fd68337 PS1, Line 113: printk(BIOS_ERR,"edp aux transfer tx failed\n"); space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134173): https://review.coreboot.org/c/coreboot/+/59612/comment/da00b417_59945284 PS1, Line 115: if (read) { suspect code indent for conditional statements (8, 24) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134173): https://review.coreboot.org/c/coreboot/+/59612/comment/ea5d2e0c_87349a0d PS1, Line 118: printk(BIOS_ERR,"edp aux transfer rx failed\n"); space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134173): https://review.coreboot.org/c/coreboot/+/59612/comment/0ed3452c_35e70c55 PS1, Line 138: if (err <EDID_LENGTH) { spaces required around that '<' (ctx:WxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134173): https://review.coreboot.org/c/coreboot/+/59612/comment/49c6ed6b_653c5209 PS1, Line 139: printk(BIOS_ERR, "ERROR: Failed to read EDID. :0x%x\n",err); space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134173): https://review.coreboot.org/c/coreboot/+/59612/comment/53d62856_30251243 PS1, Line 148: if (err>0) spaces required around that '>' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134173): https://review.coreboot.org/c/coreboot/+/59612/comment/3c55658c_a316f458 PS1, Line 149: err = edp_aux_transfer(EDID_I2C_ADDR, DP_AUX_I2C_READ, &edid[EDID_LENGTH], line over 96 characters Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134173): https://review.coreboot.org/c/coreboot/+/59612/comment/e0557807_fc9a7cdf PS1, Line 151: if (err<EDID_LENGTH) { spaces required around that '<' (ctx:VxV) File src/soc/qualcomm/sc7280/display/edp_ctrl.c: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134173): https://review.coreboot.org/c/coreboot/+/59612/comment/ecfd9dd9_cc78072e PS1, Line 405: static void edp_link_train_clock_recovery_delay(const uint8_t dpcd[DP_RECEIVER_CAP_SIZE]) { open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134173): https://review.coreboot.org/c/coreboot/+/59612/comment/3fb6607c_d47492fc PS1, Line 409: printk(BIOS_ERR,"AUX interval %d, out of range (max 4)\n", space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134173): https://review.coreboot.org/c/coreboot/+/59612/comment/99bd0a7f_c990b1c3 PS1, Line 426: if ((lane_status & DP_LANE_CR_DONE) == 0) that open brace { should be on the previous line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134173): https://review.coreboot.org/c/coreboot/+/59612/comment/06b7c353_37f67c65 PS1, Line 428: printk(BIOS_ERR,"clock recovery ok failed : %x\n", lane_status); space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134173): https://review.coreboot.org/c/coreboot/+/59612/comment/f84301ec_f84249ee PS1, Line 435: static void edp_link_train_channel_eq_delay(const uint8_t dpcd[DP_RECEIVER_CAP_SIZE]) { open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134173): https://review.coreboot.org/c/coreboot/+/59612/comment/b88f8930_6246fbc4 PS1, Line 440: printk(BIOS_INFO,"AUX interval %d, out of range (max 4)\n", space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134173): https://review.coreboot.org/c/coreboot/+/59612/comment/aa5d376b_415b3feb PS1, Line 471: write32(&edp_ahbclk->interrupt_status,EDP_INTERRUPT_STATUS1_MASK); space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134173): https://review.coreboot.org/c/coreboot/+/59612/comment/85d06cef_3062705c PS1, Line 490: if (dpcd[DP_EDP_CONFIGURATION_CAP] & DP_ALTERNATE_SCRAMBLER_RESET_CAP) suspect code indent for conditional statements (8, 10) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134173): https://review.coreboot.org/c/coreboot/+/59612/comment/c4f63b62_40d10387 PS1, Line 539: if (edp_aux_transfer(DP_TRAINING_LANE0_SET, DP_AUX_NATIVE_WRITE, buf, 2) <2) { spaces required around that '<' (ctx:WxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134173): https://review.coreboot.org/c/coreboot/+/59612/comment/686d814c_05c359d1 PS1, Line 540: printk(BIOS_ERR,"%s: Set sw/pe to panel failed\n", __func__); space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134173): https://review.coreboot.org/c/coreboot/+/59612/comment/d6d87e7a_2a80173a PS1, Line 551: printk(BIOS_INFO,"pattern=%x\n", p); space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134173): https://review.coreboot.org/c/coreboot/+/59612/comment/8048fb2f_efdd9a71 PS1, Line 553: printk(BIOS_ERR,"%s: Set training pattern to panel failed\n", __func__); space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134173): https://review.coreboot.org/c/coreboot/+/59612/comment/226cf980_8a462c56 PS1, Line 570: printk(BIOS_INFO,"lane=%d req_voltage_swing=0x%x\n", i, data); space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134173): https://review.coreboot.org/c/coreboot/+/59612/comment/df090fc2_3577898e PS1, Line 581: printk(BIOS_INFO,"lane=%d req_pre_emphasis=0x%x\n", i, data); space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134173): https://review.coreboot.org/c/coreboot/+/59612/comment/aa29f767_fa9cb8c3 PS1, Line 587: printk(BIOS_INFO,"v_level=%d, p_level=%d\n", ctrl->v_level, ctrl->p_level); space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134173): https://review.coreboot.org/c/coreboot/+/59612/comment/1985b091_10c36c94 PS1, Line 596: printk(BIOS_INFO,"train=%d", train); space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134173): https://review.coreboot.org/c/coreboot/+/59612/comment/b6b4989a_fbb21d3d PS1, Line 606: printk(BIOS_INFO,"%s: set link_train=%u failed\n", __func__, data); space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134173): https://review.coreboot.org/c/coreboot/+/59612/comment/e10dcb22_bc61d79b PS1, Line 611: printk(BIOS_INFO,"v=%d p=%d\n", ctrl->v_level, ctrl->p_level); space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134173): https://review.coreboot.org/c/coreboot/+/59612/comment/fea5e958_2b264661 PS1, Line 643: printk(BIOS_ERR,"%s: read link status failed\n", __func__); space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134173): https://review.coreboot.org/c/coreboot/+/59612/comment/28a0c824_29e243a7 PS1, Line 698: printk(BIOS_ERR,"%s: read link status failed\n", __func__); space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134173): https://review.coreboot.org/c/coreboot/+/59612/comment/4c5735f6_2fd6d9b2 PS1, Line 746: printk(BIOS_INFO,"new rate=0x%x\n", ctrl->link_rate_khz); space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134173): https://review.coreboot.org/c/coreboot/+/59612/comment/4e6d5795_7f882eef PS1, Line 809: if (edp_aux_transfer(DP_LINK_BW_SET, DP_AUX_NATIVE_WRITE, &values[0], 1)< 0) spaces required around that '<' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134173): https://review.coreboot.org/c/coreboot/+/59612/comment/3557366c_2f82f444 PS1, Line 830: printk(BIOS_ERR,"%s: read link status failed\n", __func__); space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134173): https://review.coreboot.org/c/coreboot/+/59612/comment/c75edf11_59ff9473 PS1, Line 836: printk(BIOS_ERR,"link reconfig\n"); space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134173): https://review.coreboot.org/c/coreboot/+/59612/comment/4c478a43_2298e8dd PS1, Line 839: if (edp_clock_recovery_reduced_lanes(link_status, ctrl->lane_cnt) == 0) { line over 96 characters Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134173): https://review.coreboot.org/c/coreboot/+/59612/comment/61c06480_343ff16e PS1, Line 841: printk(BIOS_ERR,"%s: Training 1 failed\n", __func__); space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134173): https://review.coreboot.org/c/coreboot/+/59612/comment/17af4df9_924343a1 PS1, Line 844: printk(BIOS_ERR,"link reconfig\n"); space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134173): https://review.coreboot.org/c/coreboot/+/59612/comment/a5e917dd_10cd3913 PS1, Line 848: printk(BIOS_ERR,"%s: Training 1 failed\n", __func__); space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134173): https://review.coreboot.org/c/coreboot/+/59612/comment/7361556e_ba055a0b PS1, Line 855: printk(BIOS_INFO,"Training 1 completed successfully\n"); space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134173): https://review.coreboot.org/c/coreboot/+/59612/comment/0995f315_f9a26652 PS1, Line 858: if (edp_clear_training_pattern(dpcd)) suspect code indent for conditional statements (8, 10) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134173): https://review.coreboot.org/c/coreboot/+/59612/comment/4097f4f6_171949d7 PS1, Line 859: return EDP_TRAIN_FAIL; Statements should start on a tabstop Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134173): https://review.coreboot.org/c/coreboot/+/59612/comment/4e8bbc91_2354a14c PS1, Line 861: ret = edp_start_link_train_2(ctrl,dpcd); space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134173): https://review.coreboot.org/c/coreboot/+/59612/comment/d2f70df2_dfc4386b PS1, Line 866: printk(BIOS_ERR,"%s: read link status failed\n", __func__); space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134173): https://review.coreboot.org/c/coreboot/+/59612/comment/7531e34c_9a3c95c3 PS1, Line 872: printk(BIOS_ERR,"link reconfig\n"); space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134173): https://review.coreboot.org/c/coreboot/+/59612/comment/175cf329_7fb5d324 PS1, Line 875: printk(BIOS_ERR,"%s: Training 2 failed\n", __func__); space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134173): https://review.coreboot.org/c/coreboot/+/59612/comment/4da88770_9f388967 PS1, Line 880: printk(BIOS_ERR,"%s: Training 1 failed\n", __func__); space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134173): https://review.coreboot.org/c/coreboot/+/59612/comment/773ef48d_0d7cc929 PS1, Line 883: printk(BIOS_ERR,"link reconfig\n"); space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134173): https://review.coreboot.org/c/coreboot/+/59612/comment/b07f9264_5d5c052a PS1, Line 892: printk(BIOS_INFO,"Training 2 completed successfully\n"); space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134173): https://review.coreboot.org/c/coreboot/+/59612/comment/e3be4a5f_5a2ca1fd PS1, Line 971: printk(BIOS_ERR,"Invalid pixel mux divider\n"); space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134173): https://review.coreboot.org/c/coreboot/+/59612/comment/6ea5ed2f_a385025c PS1, Line 982: printk(BIOS_INFO,"num=0x%x, den=0x%x\n", *pixel_m, *pixel_n); space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134173): https://review.coreboot.org/c/coreboot/+/59612/comment/65e52ac3_e04da65b PS1, Line 997: if (DP_LINK_BW_5_4 == rate) Comparisons should place the constant on the right side of the test Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134173): https://review.coreboot.org/c/coreboot/+/59612/comment/714711a0_69b124e7 PS1, Line 1000: if (DP_LINK_BW_8_1 == rate) Comparisons should place the constant on the right side of the test Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134173): https://review.coreboot.org/c/coreboot/+/59612/comment/a03a0b74_c96027e2 PS1, Line 1003: printk(BIOS_INFO,"mvid=0x%x, nvid=0x%x\n", mvid, nvid); space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134173): https://review.coreboot.org/c/coreboot/+/59612/comment/0a90a252_43a0c834 PS1, Line 1020: tu->last_partial_tu_fp =(tu->n_remainder_symbols_per_lane_fp / tu->tu_size); spaces required around that '=' (ctx:WxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134173): https://review.coreboot.org/c/coreboot/+/59612/comment/0d958ec3_2bd3c973 PS1, Line 1098: if (tu->new_err_fp <tu->diff_abs_fp) spaces required around that '<' (ctx:WxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134173): https://review.coreboot.org/c/coreboot/+/59612/comment/67ad7298_ed8dd30f PS1, Line 1115: int64_t temp =0; spaces required around that '=' (ctx:WxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134173): https://review.coreboot.org/c/coreboot/+/59612/comment/a1afb910_192556ab PS1, Line 1116: int64_t temp_fp =0; spaces required around that '=' (ctx:WxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134173): https://review.coreboot.org/c/coreboot/+/59612/comment/1f4ba365_2a719f36 PS1, Line 1136: if (((tu->lwidth % tu->nlanes) != 0) && (tu->ratio_fp < f)) that open brace { should be on the previous line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134173): https://review.coreboot.org/c/coreboot/+/59612/comment/d77aed0f_dc016328 PS1, Line 1142: tu->err_fp = 1000 * f ; space prohibited before semicolon Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134173): https://review.coreboot.org/c/coreboot/+/59612/comment/a0e82168_0bab7a91 PS1, Line 1143: if (tu->ratio_fp > f) { braces {} are not necessary for single statement blocks Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134173): https://review.coreboot.org/c/coreboot/+/59612/comment/11a81046_e6720ae9 PS1, Line 1147: for (tu->tu_size = 32; tu->tu_size <= 64; tu->tu_size++) that open brace { should be on the previous line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134173): https://review.coreboot.org/c/coreboot/+/59612/comment/51e32cd1_f2ce123e PS1, Line 1154: if(tu->new_err_fp < tu->err_fp) that open brace { should be on the previous line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134173): https://review.coreboot.org/c/coreboot/+/59612/comment/e58c4469_1820dfa0 PS1, Line 1154: if(tu->new_err_fp < tu->err_fp) space required before the open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134173): https://review.coreboot.org/c/coreboot/+/59612/comment/8efcbbc5_8b4b1615 PS1, Line 1256: printk(BIOS_ERR,"TU: valid_boundary_link: %d\n", space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134173): https://review.coreboot.org/c/coreboot/+/59612/comment/8369ef34_f63e2037 PS1, Line 1258: printk(BIOS_ERR,"TU: delay_start_link: %d\n", space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134173): https://review.coreboot.org/c/coreboot/+/59612/comment/3f734ad0_b21bf6d8 PS1, Line 1260: printk(BIOS_ERR,"TU: boundary_moderation_en: %d\n", space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134173): https://review.coreboot.org/c/coreboot/+/59612/comment/3ed68a0d_1053cd4e PS1, Line 1262: printk(BIOS_ERR,"TU: valid_lower_boundary_link: %d\n", space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134173): https://review.coreboot.org/c/coreboot/+/59612/comment/ec4c02d3_87c37ab1 PS1, Line 1264: printk(BIOS_ERR,"TU: upper_boundary_count: %d\n", space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134173): https://review.coreboot.org/c/coreboot/+/59612/comment/3bcae2ef_290ae527 PS1, Line 1266: printk(BIOS_ERR,"TU: lower_boundary_count: %d\n", space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134173): https://review.coreboot.org/c/coreboot/+/59612/comment/eae645eb_f5383543 PS1, Line 1268: printk(BIOS_ERR,"TU: tu_size_minus1: %d\n", tu_table->tu_size_minus1); space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134173): https://review.coreboot.org/c/coreboot/+/59612/comment/ccc88dce_3e3d4d7f PS1, Line 1275: edp_ctrl_calc_tu( ctrl, edid, &tu_config); space prohibited after that open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134173): https://review.coreboot.org/c/coreboot/+/59612/comment/f29c6dfe_e7aeebcb PS1, Line 1320: data |= (0x1) ; space prohibited before semicolon Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134173): https://review.coreboot.org/c/coreboot/+/59612/comment/f5b88bcc_219bdb78 PS1, Line 1346: static void edp_ctrl_link_enable(struct edp_ctrl* ctrl, "foo* bar" should be "foo *bar" Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134173): https://review.coreboot.org/c/coreboot/+/59612/comment/8af3f103_0976c4d2 PS1, Line 1366: mdss_clock_configure(MDSS_CLK_EDP_LINK,0,1,0,0,0,0); space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134173): https://review.coreboot.org/c/coreboot/+/59612/comment/71f18a20_1d87e93d PS1, Line 1366: mdss_clock_configure(MDSS_CLK_EDP_LINK,0,1,0,0,0,0); space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134173): https://review.coreboot.org/c/coreboot/+/59612/comment/62440d9c_4c38e7f7 PS1, Line 1366: mdss_clock_configure(MDSS_CLK_EDP_LINK,0,1,0,0,0,0); space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134173): https://review.coreboot.org/c/coreboot/+/59612/comment/a986e9ed_8e33d289 PS1, Line 1366: mdss_clock_configure(MDSS_CLK_EDP_LINK,0,1,0,0,0,0); space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134173): https://review.coreboot.org/c/coreboot/+/59612/comment/020bf528_4da32c56 PS1, Line 1366: mdss_clock_configure(MDSS_CLK_EDP_LINK,0,1,0,0,0,0); space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134173): https://review.coreboot.org/c/coreboot/+/59612/comment/73b4ef47_df73a9d6 PS1, Line 1366: mdss_clock_configure(MDSS_CLK_EDP_LINK,0,1,0,0,0,0); space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134173): https://review.coreboot.org/c/coreboot/+/59612/comment/1630ae86_75dae8b5 PS1, Line 1368: if(ret !=0) spaces required around that '!=' (ctx:WxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134173): https://review.coreboot.org/c/coreboot/+/59612/comment/ddc49d27_0c03c95e PS1, Line 1368: if(ret !=0) space required before the open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134173): https://review.coreboot.org/c/coreboot/+/59612/comment/4f758878_457251ce PS1, Line 1371: mdss_clock_configure(MDSS_CLK_EDP_LINK_INTF,0,1,0,0,0,0); space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134173): https://review.coreboot.org/c/coreboot/+/59612/comment/13a6f965_733ca30f PS1, Line 1371: mdss_clock_configure(MDSS_CLK_EDP_LINK_INTF,0,1,0,0,0,0); space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134173): https://review.coreboot.org/c/coreboot/+/59612/comment/ee78f59e_c6a0aefc PS1, Line 1371: mdss_clock_configure(MDSS_CLK_EDP_LINK_INTF,0,1,0,0,0,0); space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134173): https://review.coreboot.org/c/coreboot/+/59612/comment/f939f51f_40216ac1 PS1, Line 1371: mdss_clock_configure(MDSS_CLK_EDP_LINK_INTF,0,1,0,0,0,0); space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134173): https://review.coreboot.org/c/coreboot/+/59612/comment/8cfd813c_77ee1ba4 PS1, Line 1371: mdss_clock_configure(MDSS_CLK_EDP_LINK_INTF,0,1,0,0,0,0); space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134173): https://review.coreboot.org/c/coreboot/+/59612/comment/a100bf23_1b61e924 PS1, Line 1371: mdss_clock_configure(MDSS_CLK_EDP_LINK_INTF,0,1,0,0,0,0); space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134173): https://review.coreboot.org/c/coreboot/+/59612/comment/6de3275d_a6ae183f PS1, Line 1373: if(ret !=0) spaces required around that '!=' (ctx:WxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134173): https://review.coreboot.org/c/coreboot/+/59612/comment/38dcb76c_dbee773e PS1, Line 1373: if(ret !=0) space required before the open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134173): https://review.coreboot.org/c/coreboot/+/59612/comment/6374d3ed_61091ed9 PS1, Line 1379: if(ret !=0) spaces required around that '!=' (ctx:WxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134173): https://review.coreboot.org/c/coreboot/+/59612/comment/c7ec7aca_2a2bbcbc PS1, Line 1379: if(ret !=0) space required before the open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134173): https://review.coreboot.org/c/coreboot/+/59612/comment/9474e612_259a496b PS1, Line 1394: while(ret == EDP_TRAIN_RECONFIG) { space required before the open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134173): https://review.coreboot.org/c/coreboot/+/59612/comment/8492bbb5_f44ca197 PS1, Line 1396: edp_ctrl_irq_enable( 0); space prohibited after that open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134173): https://review.coreboot.org/c/coreboot/+/59612/comment/82aca6a4_1218923b PS1, Line 1400: edp_ctrl_irq_enable( 1); space prohibited after that open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134173): https://review.coreboot.org/c/coreboot/+/59612/comment/9d7602d0_256feb6a PS1, Line 1417: printk(BIOS_ERR,"ERROR: edp native read failure\n"); space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134173): https://review.coreboot.org/c/coreboot/+/59612/comment/e576e701_3de859a5 PS1, Line 1424: printk(BIOS_ERR,"ERROR: edp native read failure\n"); space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134173): https://review.coreboot.org/c/coreboot/+/59612/comment/08c00c12_6071638b PS1, Line 1434: edp_ctrl_irq_enable( 1); space prohibited after that open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134173): https://review.coreboot.org/c/coreboot/+/59612/comment/9a880175_ba9bc3c8 PS1, Line 1439: printk(BIOS_ERR,"ERROR: edp training failure\n"); space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134173): https://review.coreboot.org/c/coreboot/+/59612/comment/80c413aa_79defb3a PS1, Line 1466: printk(BIOS_ERR,"%s: AUX channel is NOT ready\n", __func__); space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134173): https://review.coreboot.org/c/coreboot/+/59612/comment/f00eef5c_4cd5c79e PS1, Line 1477: int ret =0; spaces required around that '=' (ctx:WxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134173): https://review.coreboot.org/c/coreboot/+/59612/comment/ed6a1972_adc443ae PS1, Line 1485: if(edp_read_edid(edid) == 0) that open brace { should be on the previous line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134173): https://review.coreboot.org/c/coreboot/+/59612/comment/d7c9714f_113841a3 PS1, Line 1485: if(edp_read_edid(edid) == 0) space required before the open parenthesis '(' File src/soc/qualcomm/sc7280/display/edp_phy_7nm.c: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134173): https://review.coreboot.org/c/coreboot/+/59612/comment/4dea49b4_281bbc2c PS1, Line 45: printk(BIOS_ERR,"%s: refgen not ready : 0x%x\n", __func__,read32(&edp_phy_pll->qserdes_com_cmn_status)); line over 96 characters Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134173): https://review.coreboot.org/c/coreboot/+/59612/comment/d731b956_1f507796 PS1, Line 45: printk(BIOS_ERR,"%s: refgen not ready : 0x%x\n", __func__,read32(&edp_phy_pll->qserdes_com_cmn_status)); space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134173): https://review.coreboot.org/c/coreboot/+/59612/comment/af286fb2_9215b8fc PS1, Line 45: printk(BIOS_ERR,"%s: refgen not ready : 0x%x\n", __func__,read32(&edp_phy_pll->qserdes_com_cmn_status)); space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134173): https://review.coreboot.org/c/coreboot/+/59612/comment/6e28d4bf_e8f1bec2 PS1, Line 214: printk(BIOS_ERR,"%s: Invalid link rate. rate = %u\n", __func__, space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134173): https://review.coreboot.org/c/coreboot/+/59612/comment/155fca56_844c270b PS1, Line 281: printk(BIOS_ERR,"%s: Invalid link rate. rate = %u\n", __func__, space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134173): https://review.coreboot.org/c/coreboot/+/59612/comment/5d98f92f_b6d8a5ab PS1, Line 293: printk(BIOS_ERR,"%s: PLL not locked. Status\n", __func__); space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134173): https://review.coreboot.org/c/coreboot/+/59612/comment/20b8611b_d121fd75 PS1, Line 301: printk(BIOS_ERR,"%s: PHY not ready. Status\n", __func__); space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134173): https://review.coreboot.org/c/coreboot/+/59612/comment/69962b3a_ad884210 PS1, Line 309: printk(BIOS_ERR,"%s: PLL not locked. Status\n", __func__); space required after that ',' (ctx:VxV) File src/soc/qualcomm/sc7280/display/mdss.c: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134173): https://review.coreboot.org/c/coreboot/+/59612/comment/57ebf48f_d5d147b8 PS1, Line 55: printk(BIOS_ERR,"%s: \n", __func__); space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134173): https://review.coreboot.org/c/coreboot/+/59612/comment/8884749b_23f84d7c PS1, Line 55: printk(BIOS_ERR,"%s: \n", __func__); unnecessary whitespace before a quoted newline Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134173): https://review.coreboot.org/c/coreboot/+/59612/comment/6ceb0361_2b1201e1 PS1, Line 213: mdss_clock_configure(MDSS_CLK_MDP, 300 * MHz, 0, 0, 0 , 0 , 0 ); space prohibited before that ',' (ctx:WxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134173): https://review.coreboot.org/c/coreboot/+/59612/comment/2877f86a_7918d4d5 PS1, Line 213: mdss_clock_configure(MDSS_CLK_MDP, 300 * MHz, 0, 0, 0 , 0 , 0 ); space prohibited before that ',' (ctx:WxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134173): https://review.coreboot.org/c/coreboot/+/59612/comment/fb0e200a_e656b276 PS1, Line 213: mdss_clock_configure(MDSS_CLK_MDP, 300 * MHz, 0, 0, 0 , 0 , 0 ); space prohibited before that close parenthesis ')' -- To view, visit https://review.coreboot.org/c/coreboot/+/59612 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I388bce93a4d174ca51a02add1fd9b04c46899fa6 Gerrit-Change-Number: 59612 Gerrit-PatchSet: 1 Gerrit-Owner: Ravi kumar <rbokka(a)codeaurora.org> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 24 Nov 2021 06:16:41 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: HACK: Herobrine: Reinit TPM INT gpio after qclib executes
by build bot (Jenkins) (Code Review) 24 Nov '21

24 Nov '21

Attention is currently required from: Ravi kumar, Shelley Chen, Sudheer Amrabadi, mturney mturney. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/57025 ) Change subject: HACK: Herobrine: Reinit TPM INT gpio after qclib executes ...................................................................... Patch Set 34: Verified-1 (2 comments) File src/soc/qualcomm/common/qclib.c: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134169): https://review.coreboot.org/c/coreboot/+/57025/comment/5374eff4_179c19dd PS34, Line 254: mainboard_blob_fix(); code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134169): https://review.coreboot.org/c/coreboot/+/57025/comment/e8bef10c_bdaa6f73 PS34, Line 254: mainboard_blob_fix(); please, no spaces at the start of a line -- To view, visit https://review.coreboot.org/c/coreboot/+/57025 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I4c43d120ebb49800c82aec263ff8c215b60c5201 Gerrit-Change-Number: 57025 Gerrit-PatchSet: 34 Gerrit-Owner: Shelley Chen <shchen(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Ravi kumar <rbokka(a)codeaurora.org> Gerrit-Attention: Ravi kumar <rbokka(a)codeaurora.org> Gerrit-Attention: Shelley Chen <shchen(a)google.com> Gerrit-Attention: Sudheer Amrabadi <samrabad(a)codeaurora.org> Gerrit-Attention: mturney mturney <quic_mturney(a)quicinc.com> Gerrit-Comment-Date: Wed, 24 Nov 2021 06:15:10 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit November 2021