Attention is currently required from: Furquan Shaikh, Tim Wawrzynczak, Nick Vaccaro.
EricR Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58180 )
Change subject: mb/google/brya: Clear SLP_S0_GATE_L on ACPI sleep entry
......................................................................
Patch Set 2:
(1 comment)
Patchset:
PS2:
My DUT with this patch S0->S3->S5->S0->S3->S5->G3, type poweroff under VT2.
--
To view, visit https://review.coreboot.org/c/coreboot/+/58180
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I5500e701ac8731d141b51dc381609c80047dc1f8
Gerrit-Change-Number: 58180
Gerrit-PatchSet: 2
Gerrit-Owner: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: Caveh Jalali <caveh(a)chromium.org>
Gerrit-Reviewer: EricR Lai <ericr_lai(a)compal.corp-partner.google.com>
Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Boris Mittelberg <bmbm(a)google.com>
Gerrit-Attention: Furquan Shaikh <furquan(a)google.com>
Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Attention: Nick Vaccaro <nvaccaro(a)google.com>
Gerrit-Comment-Date: Fri, 08 Oct 2021 03:27:21 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Anil Kumar K.
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/58189
to look at the new patch set (#2).
Change subject: [Test] mb/adlrvp: Update mainboard smbios name and SKU ID
......................................................................
[Test] mb/adlrvp: Update mainboard smbios name and SKU ID
Change-Id: I2b70f65f4467232015c2dc167beb3bfa91870fcb
---
M src/mainboard/intel/adlrvp/Kconfig
M src/mainboard/intel/adlrvp/mainboard.c
2 files changed, 6 insertions(+), 3 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/89/58189/2
--
To view, visit https://review.coreboot.org/c/coreboot/+/58189
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I2b70f65f4467232015c2dc167beb3bfa91870fcb
Gerrit-Change-Number: 58189
Gerrit-PatchSet: 2
Gerrit-Owner: Anil Kumar K <anil.kumar.k(a)intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Anil Kumar K <anil.kumar.k(a)intel.com>
Gerrit-MessageType: newpatchset
Attention is currently required from: Hsuan-ting Chen, Tim Wawrzynczak, Nick Vaccaro.
EricR Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58183 )
Change subject: mb/google/brya: Add GPIO_IN_RW to all variants' early GPIO tables
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/58183
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I6b1af50f257dc7b627c4c00d7480ba7732c3d1a0
Gerrit-Change-Number: 58183
Gerrit-PatchSet: 2
Gerrit-Owner: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: EricR Lai <ericr_lai(a)compal.corp-partner.google.com>
Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com>
Gerrit-Reviewer: Hsuan-ting Chen <roccochen(a)google.com>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Hsuan-ting Chen <roccochen(a)google.com>
Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Attention: Nick Vaccaro <nvaccaro(a)google.com>
Gerrit-Comment-Date: Fri, 08 Oct 2021 03:06:25 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Furquan Shaikh, Tim Wawrzynczak, Nick Vaccaro.
EricR Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58180 )
Change subject: mb/google/brya: Clear SLP_S0_GATE_L on ACPI sleep entry
......................................................................
Patch Set 2: Code-Review+2
(1 comment)
Patchset:
PS2:
The patch seems fine, this should worked. Let try some.
--
To view, visit https://review.coreboot.org/c/coreboot/+/58180
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I5500e701ac8731d141b51dc381609c80047dc1f8
Gerrit-Change-Number: 58180
Gerrit-PatchSet: 2
Gerrit-Owner: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: Caveh Jalali <caveh(a)chromium.org>
Gerrit-Reviewer: EricR Lai <ericr_lai(a)compal.corp-partner.google.com>
Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Boris Mittelberg <bmbm(a)google.com>
Gerrit-Attention: Furquan Shaikh <furquan(a)google.com>
Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Attention: Nick Vaccaro <nvaccaro(a)google.com>
Gerrit-Comment-Date: Fri, 08 Oct 2021 03:03:24 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: David Wu, Paul Menzel, Tim Wawrzynczak.
Alan Huang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58165 )
Change subject: mb/google/brya/variants/brask: Init overridetree
......................................................................
Patch Set 2:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/58165/comment/999a0544_b843b824
PS1, Line 7: Init the overridetree
> Init overridetree
Ack
https://review.coreboot.org/c/coreboot/+/58165/comment/da2af5e5_4f5b1a32
PS1, Line 9: Init the overridetree
> same here
Ack
--
To view, visit https://review.coreboot.org/c/coreboot/+/58165
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I30d26a47fe93736c63b578c9180b148ef73e8b9f
Gerrit-Change-Number: 58165
Gerrit-PatchSet: 2
Gerrit-Owner: Alan Huang <alan-huang(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: David Wu <david_wu(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: David Wu <david_wu(a)quanta.corp-partner.google.com>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Comment-Date: Fri, 08 Oct 2021 02:04:11 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org>
Comment-In-Reply-To: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-MessageType: comment
Attention is currently required from: David Wu, Alan Huang.
Hello build bot (Jenkins), David Wu, Tim Wawrzynczak,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/58165
to look at the new patch set (#2).
Change subject: mb/google/brya/variants/brask: Init overridetree
......................................................................
mb/google/brya/variants/brask: Init overridetree
Init overridetree based on the schematics.
Refer to bray0/overridetree.cb to update the settings of the devices
including DPTF, WIFI, NAU8825 and etc.
Refer to kano/overridetree.cb to update the SSD settings (pcie4_0).
TODO: DPTF and USB positions will be further updated later.
BUG=none
TEST=Build Pass
Signed-off-by: Alan Huang <alan-huang(a)quanta.corp-partner.google.com>
Change-Id: I30d26a47fe93736c63b578c9180b148ef73e8b9f
---
M src/mainboard/google/brya/variants/brask/overridetree.cb
1 file changed, 286 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/65/58165/2
--
To view, visit https://review.coreboot.org/c/coreboot/+/58165
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I30d26a47fe93736c63b578c9180b148ef73e8b9f
Gerrit-Change-Number: 58165
Gerrit-PatchSet: 2
Gerrit-Owner: Alan Huang <alan-huang(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: David Wu <david_wu(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: David Wu <david_wu(a)quanta.corp-partner.google.com>
Gerrit-Attention: Alan Huang <alan-huang(a)quanta.corp-partner.google.com>
Gerrit-MessageType: newpatchset
Attention is currently required from: Frank Chu, Karthik Ramasubramanian.
Henry Sun has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58162 )
Change subject: mb/google/dedede/var/galtic: Add fw_config probe for ALC5682-VD & VS
......................................................................
Patch Set 1: Code-Review+1
(1 comment)
Patchset:
PS1:
LGTM
--
To view, visit https://review.coreboot.org/c/coreboot/+/58162
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iaba136a836b89f42411474ae733380e345cce687
Gerrit-Change-Number: 58162
Gerrit-PatchSet: 1
Gerrit-Owner: Frank Chu <frank_chu(a)pegatron.corp-partner.google.com>
Gerrit-Reviewer: Frank Chu <frank_chu(a)pegatron.corp-partner.google.com>
Gerrit-Reviewer: Henry Sun <henrysun(a)google.com>
Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Daniel Peng <daniel_peng(a)pegatron.corp-partner.google.com>
Gerrit-CC: Hank Lin <hank2_lin(a)pegatron.corp-partner.google.com>
Gerrit-CC: Kane Chen <kane_chen(a)pegatron.corp-partner.google.com>
Gerrit-CC: Ken Lu <ken_lu(a)pegatron.corp-partner.google.com>
Gerrit-Attention: Frank Chu <frank_chu(a)pegatron.corp-partner.google.com>
Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Comment-Date: Fri, 08 Oct 2021 01:53:02 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment