coreboot-gerrit January 2021

coreboot-gerrit@coreboot.org

1 participants
6507 discussions

Change in coreboot[master]: {soc,vc,mb}/intel: Remove support for Cannon Lake SoC
by Christian Walter (Code Review) 02 Jan '21

02 Jan '21

Christian Walter has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48775 ) Change subject: {soc,vc,mb}/intel: Remove support for Cannon Lake SoC ...................................................................... Patch Set 10: Code-Review-1 What's the downsite to have this in the tree? Skylake-SP FSP Binaries are also not available publicly (and most likely never will) - however this should also stay in the tree. I am a friend of having broad support here. -- To view, visit https://review.coreboot.org/c/coreboot/+/48775 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I8f698e16099acb45444b2bc675642d161ff8c237 Gerrit-Change-Number: 48775 Gerrit-PatchSet: 10 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Duncan Laurie <dlaurie(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Gaggery Tsai <gaggery.tsai(a)intel.com> Gerrit-Reviewer: Lijian Zhao <lijian.zhao(a)intel.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Pratikkumar V Prajapati <pratikkumar.v.prajapati(a)intel.com> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Comment-Date: Sat, 02 Jan 2021 16:50:27 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: device/pnp,util/sconfig: introduce and use `REG8` resource type
by Michael Niewöhner (Code Review) 02 Jan '21

02 Jan '21

Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48925 ) Change subject: device/pnp,util/sconfig: introduce and use `REG8` resource type ...................................................................... Patch Set 8: > Patch Set 8: > > since MSC0-MSCE only cover a few possible registers that might need to be written, I don't see much reason to have special cases for MSC0-MSCE. not sure if the sio driver providing a mask of possible writable registers provides any value, it might however create some confusion that some register writes have some special handling in the sio driver and some not that's what I actually mean, yes. there's no mask, we would need to implement/define them all -- To view, visit https://review.coreboot.org/c/coreboot/+/48925 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I36679148cbfdbd1e38b3c4ce092562769f9806ab Gerrit-Change-Number: 48925 Gerrit-PatchSet: 8 Gerrit-Owner: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Damien Zammit Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Tristan Corrick <tristan(a)corrick.kiwi> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sat, 02 Jan 2021 16:28:44 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: device/pnp,util/sconfig: introduce and use `REG8` resource type
by Felix Held (Code Review) 02 Jan '21

02 Jan '21

Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48925 ) Change subject: device/pnp,util/sconfig: introduce and use `REG8` resource type ...................................................................... Patch Set 8: since MSC0-MSCE only cover a few possible registers that might need to be written, I don't see much reason to have special cases for MSC0-MSCE. not sure if the sio driver providing a mask of possible writable registers provides any value, it might however create some confusion that some register writes have some special handling in the sio driver and some not -- To view, visit https://review.coreboot.org/c/coreboot/+/48925 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I36679148cbfdbd1e38b3c4ce092562769f9806ab Gerrit-Change-Number: 48925 Gerrit-PatchSet: 8 Gerrit-Owner: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Damien Zammit Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Tristan Corrick <tristan(a)corrick.kiwi> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sat, 02 Jan 2021 16:19:10 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: drivers/intel/gma: add macro for one internal panel in gfx struct
by Nico Huber (Code Review) 02 Jan '21

02 Jan '21

Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49054 ) Change subject: drivers/intel/gma: add macro for one internal panel in gfx struct ...................................................................... Patch Set 1: (1 comment) https://review.coreboot.org/c/coreboot/+/49054/1/src/drivers/intel/gma/gma.h File src/drivers/intel/gma/gma.h: https://review.coreboot.org/c/coreboot/+/49054/1/src/drivers/intel/gma/gma.… PS1, Line 33: at port A Actually, I'm not sure if/how Intel really uses the port encoding. -- To view, visit https://review.coreboot.org/c/coreboot/+/49054 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I5308b53667657d0b255ae5bc543f1a00431f5818 Gerrit-Change-Number: 49054 Gerrit-PatchSet: 1 Gerrit-Owner: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Comment-Date: Sat, 02 Jan 2021 14:04:20 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: drivers/intel/gma: add macro for one internal panel in gfx struct
by Nico Huber (Code Review) 02 Jan '21

02 Jan '21

Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49054 ) Change subject: drivers/intel/gma: add macro for one internal panel in gfx struct ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/49054 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I5308b53667657d0b255ae5bc543f1a00431f5818 Gerrit-Change-Number: 49054 Gerrit-PatchSet: 1 Gerrit-Owner: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Comment-Date: Sat, 02 Jan 2021 13:57:36 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: soc/intel/tigerlake: Hook up FSP repository
by Nico Huber (Code Review) 02 Jan '21

02 Jan '21

Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48713 ) Change subject: soc/intel/tigerlake: Hook up FSP repository ...................................................................... Patch Set 7: > > I can only give a +1 because there's a Tigerlake UP3 reference board in the tree, which would need the IOT version of FSP. > > > > For reference, UP3: IOT, UP4: Client. > > Oh, yes. Thanks! I am not sure if UP4 is the Client version (the FSP repo doesn't mention UP4 anywhere), but some news sites are saying so. > > So I would just add another Kconfig option for differentiation UP3 / UP4. > > What should I use for the extension? UP3 / UP4 or IOT / CLIENT? _IOT vs _CLIENT sounds good. -- To view, visit https://review.coreboot.org/c/coreboot/+/48713 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I5e694b91be7734dd98665051a6a3d9eccab7dac7 Gerrit-Change-Number: 48713 Gerrit-PatchSet: 7 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Duncan Laurie <dlaurie(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Reviewer: Nathaniel L Desimone <nathaniel.l.desimone(a)intel.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Raj Astekar <raj.astekar(a)intel.corp-partner.google.com> Gerrit-Reviewer: Ravishankar Sarawadi <ravishankar.sarawadi(a)intel.com> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Nico Huber <nico.h(a)gmx.de> Gerrit-CC: Raj Astekar <raj.astekar(a)intel.com> Gerrit-Comment-Date: Sat, 02 Jan 2021 13:54:58 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: MAINTAINERS: Add maintainer for ACPI
by Felix Singer (Code Review) 02 Jan '21

02 Jan '21

Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48970 ) Change subject: MAINTAINERS: Add maintainer for ACPI ...................................................................... Patch Set 4: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/48970 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I65fdee350273c58e027a002dba1f97a56115e195 Gerrit-Change-Number: 48970 Gerrit-PatchSet: 4 Gerrit-Owner: Lance Zhao Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-Reviewer: John Zhao <john.zhao(a)intel.com> Gerrit-Reviewer: Lijian Zhao <lijian.zhao(a)intel.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Comment-Date: Sat, 02 Jan 2021 13:43:29 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: drivers/intel/gma: add macro for one internal panel in gfx struct
by Angel Pons (Code Review) 02 Jan '21

02 Jan '21

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49054 ) Change subject: drivers/intel/gma: add macro for one internal panel in gfx struct ...................................................................... Patch Set 1: (1 comment) https://review.coreboot.org/c/coreboot/+/49054/1/src/drivers/intel/gma/gma.h File src/drivers/intel/gma/gma.h: https://review.coreboot.org/c/coreboot/+/49054/1/src/drivers/intel/gma/gma.… PS1, Line 33: /* Shortcut for one internal panel at port A */ > it doesn't; 4 means 'Internal/Integrated Digital Flat Panel' (from ACPI 6. […] Ah, well -- To view, visit https://review.coreboot.org/c/coreboot/+/49054 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I5308b53667657d0b255ae5bc543f1a00431f5818 Gerrit-Change-Number: 49054 Gerrit-PatchSet: 1 Gerrit-Owner: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Comment-Date: Sat, 02 Jan 2021 13:40:39 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com> Comment-In-Reply-To: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/clevo/l140cu: add panel settings to the dt and hook up GMA ACPI
by Michael Niewöhner (Code Review) 02 Jan '21

02 Jan '21

Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48750 ) Change subject: mb/clevo/l140cu: add panel settings to the dt and hook up GMA ACPI ...................................................................... Patch Set 39: (1 comment) https://review.coreboot.org/c/coreboot/+/48750/39//COMMIT_MSG Commit Message: https://review.coreboot.org/c/coreboot/+/48750/39//COMMIT_MSG@15 PS39, Line 15: Test: Panel gets enabled when the payload starts on Clevo L141CU. for unknown reasons this suddenly stopped working... need to debug this. some abstract art: https://paste.xinu.at/jLQkqYJJgm0dgu8nJ/ -- To view, visit https://review.coreboot.org/c/coreboot/+/48750 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I7977a2271da72c142b025b4631318d1a39adfb13 Gerrit-Change-Number: 48750 Gerrit-PatchSet: 39 Gerrit-Owner: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Comment-Date: Sat, 02 Jan 2021 13:29:35 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/clevo/l140cu: add panel settings to the dt and hook up GMA ACPI
by Michael Niewöhner (Code Review) 02 Jan '21

02 Jan '21

Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48750 ) Change subject: mb/clevo/l140cu: add panel settings to the dt and hook up GMA ACPI ...................................................................... Patch Set 39: (1 comment) https://review.coreboot.org/c/coreboot/+/48750/34//COMMIT_MSG Commit Message: https://review.coreboot.org/c/coreboot/+/48750/34//COMMIT_MSG@12 PS34, Line 12: Brightness control still requires ACPI code to link the EC events to it. : This will be done in a separate change later. > I'm confused. […] Keyboard events come from the ec; they need to be recognized as brightness keys by the os, which requires EC ACPI code -- To view, visit https://review.coreboot.org/c/coreboot/+/48750 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I7977a2271da72c142b025b4631318d1a39adfb13 Gerrit-Change-Number: 48750 Gerrit-PatchSet: 39 Gerrit-Owner: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Comment-Date: Sat, 02 Jan 2021 13:25:50 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de> Comment-In-Reply-To: Matt DeVillier <matt.devillier(a)gmail.com> Comment-In-Reply-To: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-MessageType: comment

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit January 2021