coreboot-gerrit June 2020

coreboot-gerrit@coreboot.org

1 participants
2826 discussions

Change in coreboot[master]: soc/intel/tigerlake: Select PLATFORM_USES_FSP2_2
by Subrata Banik (Code Review) 01 Jun '20

01 Jun '20

Hello build bot (Jenkins), Furquan Shaikh, Wonkyu Kim, Maulik V Vaghela, Duncan Laurie, Aamir Bohra, Patrick Rudolph, Aaron Durbin, Nathaniel L Desimone, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/41729 to look at the new patch set (#2). Change subject: soc/intel/tigerlake: Select PLATFORM_USES_FSP2_2 ...................................................................... soc/intel/tigerlake: Select PLATFORM_USES_FSP2_2 This patch performs below operations 1. Add support for FSP2.2 2. Set EnableMultiPhaseSiliconInit to ensure bootloader can call FspMultiPhaseSiInit() API. 3. Provide placeholder to perform require chipset programming (example TCSS) before calling FspMultiPhaseSiInit() API. Change-Id: I15252d2db3f8e75d430b84e86cc5141225a3f981 Signed-off-by: Subrata Banik <subrata.banik(a)intel.com> --- M src/soc/intel/tigerlake/Kconfig M src/soc/intel/tigerlake/fsp_params.c 2 files changed, 22 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/29/41729/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/41729 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I15252d2db3f8e75d430b84e86cc5141225a3f981 Gerrit-Change-Number: 41729 Gerrit-PatchSet: 2 Gerrit-Owner: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: Aamir Bohra <aamir.bohra(a)intel.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Duncan Laurie <dlaurie(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Maulik V Vaghela <maulik.v.vaghela(a)intel.com> Gerrit-Reviewer: Nathaniel L Desimone <nathaniel.l.desimone(a)intel.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Wonkyu Kim <wonkyu.kim(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: drivers/intel/fsp2_0: Add FSP 2.2 specific support
by Subrata Banik (Code Review) 01 Jun '20

01 Jun '20

Hello build bot (Jenkins), Furquan Shaikh, Wonkyu Kim, Maulik V Vaghela, Duncan Laurie, Sridhar Siricilla, Aamir Bohra, Srinidhi N Kaushik, Andrey Petrov, Aaron Durbin, Patrick Rudolph, Nathaniel L Desimone, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/41728 to look at the new patch set (#3). Change subject: drivers/intel/fsp2_0: Add FSP 2.2 specific support ...................................................................... drivers/intel/fsp2_0: Add FSP 2.2 specific support • Based on FSP EAS v2.1 – Backward compatibility is retained. • Added multi-phase silicon initialization to increase the modularity of the FspSiliconInit() API. • Added FspMultiPhaseSiInit() API • FSP_INFO_HEADER changes o Added FspMultiPhaseSiInitEntryOffset • Added FSPS_ARCH_UPD o Added EnableMultiPhaseSiliconInit, bootloaders designed for FSP 2.0/2.1 can disable the FspMultiPhaseSiInit() API and continue to use FspSiliconInit() without change. FSP 2.2 Specification: https://www.intel.com/content/www/us/en/intelligent-systems/intel-firmware-… Change-Id: If7177a267f3a9b4cbb60a639f1c737b9a3341913 Signed-off-by: Subrata Banik <subrata.banik(a)intel.com> --- M src/commonlib/include/commonlib/timestamp_serialized.h M src/drivers/intel/fsp2_0/Kconfig M src/drivers/intel/fsp2_0/include/fsp/api.h M src/drivers/intel/fsp2_0/include/fsp/info_header.h M src/drivers/intel/fsp2_0/include/fsp/upd.h M src/drivers/intel/fsp2_0/include/fsp/util.h M src/drivers/intel/fsp2_0/silicon_init.c M src/drivers/intel/fsp2_0/util.c M src/include/console/post_codes.h 9 files changed, 198 insertions(+), 13 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/28/41728/3 -- To view, visit https://review.coreboot.org/c/coreboot/+/41728 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: If7177a267f3a9b4cbb60a639f1c737b9a3341913 Gerrit-Change-Number: 41728 Gerrit-PatchSet: 3 Gerrit-Owner: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: Aamir Bohra <aamir.bohra(a)intel.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Andrey Petrov <andrey.petrov(a)gmail.com> Gerrit-Reviewer: Duncan Laurie <dlaurie(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Maulik V Vaghela <maulik.v.vaghela(a)intel.com> Gerrit-Reviewer: Nathaniel L Desimone <nathaniel.l.desimone(a)intel.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Sridhar Siricilla <sridhar.siricilla(a)intel.com> Gerrit-Reviewer: Srinidhi N Kaushik <srinidhi.n.kaushik(a)intel.com> Gerrit-Reviewer: Wonkyu Kim <wonkyu.kim(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: soc/intel/tigerlake: Select PLATFORM_USES_FSP2_2
by Subrata Banik (Code Review) 01 Jun '20

01 Jun '20

Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41729 ) Change subject: soc/intel/tigerlake: Select PLATFORM_USES_FSP2_2 ...................................................................... Patch Set 1: (1 comment) https://review.coreboot.org/c/coreboot/+/41729/1/src/soc/intel/tigerlake/fs… File src/soc/intel/tigerlake/fsp_params.c: https://review.coreboot.org/c/coreboot/+/41729/1/src/soc/intel/tigerlake/fs… PS1, Line 239: * 1 | After TCSS initilization completed | for TCSS specific init > 'initilization' may be misspelled - perhaps 'initialization'? Ack -- To view, visit https://review.coreboot.org/c/coreboot/+/41729 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I15252d2db3f8e75d430b84e86cc5141225a3f981 Gerrit-Change-Number: 41729 Gerrit-PatchSet: 1 Gerrit-Owner: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: Aamir Bohra <aamir.bohra(a)intel.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Duncan Laurie <dlaurie(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Maulik V Vaghela <maulik.v.vaghela(a)intel.com> Gerrit-Reviewer: Nathaniel L Desimone <nathaniel.l.desimone(a)intel.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Wonkyu Kim <wonkyu.kim(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Comment-Date: Mon, 01 Jun 2020 19:36:45 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/hatch: Modify the puff fmd files to support CSE Lite SKU
by Furquan Shaikh (Code Review) 01 Jun '20

01 Jun '20

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41198 ) Change subject: mb/google/hatch: Modify the puff fmd files to support CSE Lite SKU ...................................................................... Patch Set 10: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/41198 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I4d39a1bdeabf48fc740da67539f48a9ff72c442c Gerrit-Change-Number: 41198 Gerrit-PatchSet: 10 Gerrit-Owner: V Sowmya <v.sowmya(a)intel.com> Gerrit-Reviewer: Balaji Manigandan <balaji.manigandan(a)intel.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Jamie Chen <jamie.chen(a)intel.com> Gerrit-Reviewer: Kane Chen <kane.chen(a)intel.com> Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Reviewer: Sridhar Siricilla <sridhar.siricilla(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-CC: Sam McNally <sammc(a)google.com> Gerrit-Comment-Date: Mon, 01 Jun 2020 19:30:09 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/hatch: Enable the CSE Lite SKU for Puff variants
by Furquan Shaikh (Code Review) 01 Jun '20

01 Jun '20

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41199 ) Change subject: mb/google/hatch: Enable the CSE Lite SKU for Puff variants ...................................................................... Patch Set 7: Code-Review+2 (1 comment) https://review.coreboot.org/c/coreboot/+/41199/7//COMMIT_MSG Commit Message: https://review.coreboot.org/c/coreboot/+/41199/7//COMMIT_MSG@14 PS7, Line 14: 3046770 Just a few comments on 3046770 that need to be addressed. But this change looks good to me. We need to ensure that the changes land in sync. -- To view, visit https://review.coreboot.org/c/coreboot/+/41199 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I0de6bca162b01870ca554ae97bc4a41cf66fef18 Gerrit-Change-Number: 41199 Gerrit-PatchSet: 7 Gerrit-Owner: V Sowmya <v.sowmya(a)intel.com> Gerrit-Reviewer: Balaji Manigandan <balaji.manigandan(a)intel.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Jamie Chen <jamie.chen(a)intel.com> Gerrit-Reviewer: Kane Chen <kane.chen(a)intel.com> Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Reviewer: Sridhar Siricilla <sridhar.siricilla(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Comment-Date: Mon, 01 Jun 2020 19:29:05 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: soc/intel/common: Implement recovery mode for CSE run time errors
by Sridhar Siricilla (Code Review) 01 Jun '20

01 Jun '20

Sridhar Siricilla has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/40563 ) Change subject: soc/intel/common: Implement recovery mode for CSE run time errors ...................................................................... soc/intel/common: Implement recovery mode for CSE run time errors Implement triggering recovery mode for runtime errors which may occur during CSE firmware update flow. Also, define recovery sub-errors for various possible runtime errors. Signed-off-by: Sridhar Siricilla <sridhar.siricilla(a)intel.com> Change-Id: Ib7744fc4fd0e41804d9b45079bf706b300220c62 --- M src/soc/intel/common/block/cse/custom_bp.c 1 file changed, 39 insertions(+), 3 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/63/40563/1 diff --git a/src/soc/intel/common/block/cse/custom_bp.c b/src/soc/intel/common/block/cse/custom_bp.c index 379eb03..8d4f436 100644 --- a/src/soc/intel/common/block/cse/custom_bp.c +++ b/src/soc/intel/common/block/cse/custom_bp.c @@ -11,6 +11,7 @@ #include <intelblocks/cse.h> #include <lib.h> #include <security/vboot/vboot_common.h> +#include <security/vboot/misc.h> #include <commonlib/region.h> #include <soc/intel/common/reset.h> #include <soc/me.h> @@ -49,6 +50,24 @@ */ #define CSE_MAX_BOOT_PARTITIONS 3 +/* CSE recovery sub-error codes */ +enum csme_failure_reason { + /* Unspecified error */ + CSME_FAILURE_UNSPECIFIED, + + /* CSE fails to boot from RW */ + CSME_FAILURE_RW_JUMP_ERROR, + + /* CSE firmware update failure */ + CSME_FAILURE_FW_UPDATE_ERROR, + + /* Fails to communicate with CSE */ + CSME_FAILURE_COMMUNICATION_ERROR, + + /* Fails to wipe CSE runtime data */ + CSME_FAILURE_DATA_WIPE_ERROR +}; + /* CSE's Boot Partition Ids */ enum boot_partition_id { /* RO(BP1) contains recovery/minimal boot FW, and it's a valid bootable partition. */ @@ -256,6 +275,15 @@ return true; } +static void cse_request_recovery(uint8_t rec_sub_code) +{ + struct vb2_context *ctx; + ctx = vboot_get_context(); + vb2api_fail(ctx, VB2_RECOVERY_CSME_FAILURE, rec_sub_code); + vboot_save_data(ctx); + do_global_reset(); +} + static uint8_t cse_get_current_bp(struct cse_bp_info *cse_bp_info) { return cse_bp_info->current_bp; @@ -728,6 +756,7 @@ void cse_fw_sync(void *unused) { static struct get_bp_info_rsp cse_bp_info; + uint8_t rec_sub_code; /* If CSE SKU type is not Custom, skip enabling CSE Custom SKU */ if (!cse_is_hfs3_fw_sku_custom()) { @@ -737,6 +766,7 @@ if (!cse_get_bp_info(&cse_bp_info)) { printk(BIOS_ERR, "cse_bp: Failed to switch to CSE RO\n"); + rec_sub_code = CSME_FAILURE_COMMUNICATION_ERROR; goto failed; } @@ -754,28 +784,34 @@ return; } - if (!cse_fix_data_mismatch_err(&cse_bp_info.bp_info)) + if (!cse_fix_data_mismatch_err(&cse_bp_info.bp_info)) { + rec_sub_code = CSME_FAILURE_DATA_WIPE_ERROR; goto failed; + } struct region_device target_rdev; struct region_device source_rw_n_ver_rdev; if (!cse_is_rw_info_valid(&cse_bp_info.bp_info, &target_rdev, &source_rw_n_ver_rdev)) { + rec_sub_code = CSME_FAILURE_RW_JUMP_ERROR; printk(BIOS_ERR, "cse_bp: CSE RW partition is not valid\n"); goto failed; } uint32_t rst_req = 0; if (!cse_update_rw(&cse_bp_info.bp_info, &target_rdev, &source_rw_n_ver_rdev, - &rst_req)) + &rst_req)) { + rec_sub_code = CSME_FAILURE_FW_UPDATE_ERROR; goto failed; + } if (!cse_boot_to_rw(&cse_bp_info.bp_info, rst_req)) { printk(BIOS_ERR, "cse_bp: Failed to switch to RW\n"); + rec_sub_code = CSME_FAILURE_UNSPECIFIED; goto failed; } return; failed: - do_global_reset(); + cse_request_recovery(rec_sub_code); } -- To view, visit https://review.coreboot.org/c/coreboot/+/40563 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib7744fc4fd0e41804d9b45079bf706b300220c62 Gerrit-Change-Number: 40563 Gerrit-PatchSet: 1 Gerrit-Owner: Sridhar Siricilla <sridhar.siricilla(a)intel.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-MessageType: newchange

8 39

Change in coreboot[master]: mb/asrock/b85m_pro4/cmos.layout: Remove copyright notices
by Angel Pons (Code Review) 01 Jun '20

01 Jun '20

Angel Pons has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/41834 ) Change subject: mb/asrock/b85m_pro4/cmos.layout: Remove copyright notices ...................................................................... mb/asrock/b85m_pro4/cmos.layout: Remove copyright notices Change-Id: I2aaabec17073c0a2ccd40de068223a9215186db3 Signed-off-by: Angel Pons <th3fanbus(a)gmail.com> --- M src/mainboard/asrock/b85m_pro4/cmos.layout 1 file changed, 0 insertions(+), 3 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/34/41834/1 diff --git a/src/mainboard/asrock/b85m_pro4/cmos.layout b/src/mainboard/asrock/b85m_pro4/cmos.layout index b104a96..ed02233 100644 --- a/src/mainboard/asrock/b85m_pro4/cmos.layout +++ b/src/mainboard/asrock/b85m_pro4/cmos.layout @@ -1,6 +1,3 @@ -## Copyright (C) 2007-2008 coresystems GmbH -## Copyright (C) 2014 Vladimir Serbinenko -## ## SPDX-License-Identifier: GPL-2.0-only # ----------------------------------------------------------------- -- To view, visit https://review.coreboot.org/c/coreboot/+/41834 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I2aaabec17073c0a2ccd40de068223a9215186db3 Gerrit-Change-Number: 41834 Gerrit-PatchSet: 1 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: newchange

4 6

Change in coreboot[master]: src: Fix up #-commented SPDX headers
by Angel Pons (Code Review) 01 Jun '20

01 Jun '20

Angel Pons has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/41838 ) Change subject: src: Fix up #-commented SPDX headers ...................................................................... src: Fix up #-commented SPDX headers Delete leading empty comment lines. Change-Id: I8e14a0ad1e1e2227e4fb201f5d157f56f289f286 Signed-off-by: Angel Pons <th3fanbus(a)gmail.com> --- M src/mainboard/amd/inagua/cmos.layout M src/mainboard/amd/olivehill/cmos.layout M src/mainboard/amd/parmer/cmos.layout M src/mainboard/amd/persimmon/cmos.layout M src/mainboard/amd/south_station/cmos.layout M src/mainboard/amd/thatcher/cmos.layout M src/mainboard/amd/union_station/cmos.layout M src/mainboard/asrock/e350m1/cmos.layout M src/mainboard/asrock/imb-a180/cmos.layout M src/mainboard/asus/am1i-a/cmos.layout M src/mainboard/asus/f2a85-m/cmos.layout M src/mainboard/bap/ode_e20XX/cmos.layout M src/mainboard/bap/ode_e21XX/cmos.layout M src/mainboard/biostar/a68n_5200/cmos.layout M src/mainboard/biostar/am1ml/cmos.layout M src/mainboard/elmex/pcm205400/cmos.layout M src/mainboard/gizmosphere/gizmo/cmos.layout M src/mainboard/gizmosphere/gizmo2/cmos.layout M src/mainboard/google/foster/bct/cfg2inc.sh M src/mainboard/google/nyan/bct/cfg2inc.sh M src/mainboard/google/smaug/bct/cfg2inc.sh M src/mainboard/hp/abm/cmos.layout M src/mainboard/jetway/nf81-t56n-lf/cmos.layout M src/mainboard/lenovo/g505s/cmos.layout M src/mainboard/lippert/frontrunner-af/cmos.layout M src/mainboard/lippert/toucan-af/cmos.layout M src/mainboard/msi/ms7721/cmos.layout M src/mainboard/pcengines/apu2/cmos.layout M src/vendorcode/amd/Kconfig M src/vendorcode/amd/cimx/sb800/Makefile.inc M src/vendorcode/amd/cimx/sb900/Makefile.inc M src/vendorcode/eltan/Makefile.inc 32 files changed, 0 insertions(+), 94 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/38/41838/1 diff --git a/src/mainboard/amd/inagua/cmos.layout b/src/mainboard/amd/inagua/cmos.layout index 19efc38..beedaa7 100644 --- a/src/mainboard/amd/inagua/cmos.layout +++ b/src/mainboard/amd/inagua/cmos.layout @@ -1,7 +1,4 @@ #***************************************************************************** -# -# -# # SPDX-License-Identifier: GPL-2.0-only #***************************************************************************** diff --git a/src/mainboard/amd/olivehill/cmos.layout b/src/mainboard/amd/olivehill/cmos.layout index d450f6c..ade4c04 100644 --- a/src/mainboard/amd/olivehill/cmos.layout +++ b/src/mainboard/amd/olivehill/cmos.layout @@ -1,7 +1,4 @@ #***************************************************************************** -# -# -# # SPDX-License-Identifier: GPL-2.0-only #***************************************************************************** diff --git a/src/mainboard/amd/parmer/cmos.layout b/src/mainboard/amd/parmer/cmos.layout index d450f6c..ade4c04 100644 --- a/src/mainboard/amd/parmer/cmos.layout +++ b/src/mainboard/amd/parmer/cmos.layout @@ -1,7 +1,4 @@ #***************************************************************************** -# -# -# # SPDX-License-Identifier: GPL-2.0-only #***************************************************************************** diff --git a/src/mainboard/amd/persimmon/cmos.layout b/src/mainboard/amd/persimmon/cmos.layout index 19efc38..beedaa7 100644 --- a/src/mainboard/amd/persimmon/cmos.layout +++ b/src/mainboard/amd/persimmon/cmos.layout @@ -1,7 +1,4 @@ #***************************************************************************** -# -# -# # SPDX-License-Identifier: GPL-2.0-only #***************************************************************************** diff --git a/src/mainboard/amd/south_station/cmos.layout b/src/mainboard/amd/south_station/cmos.layout index 19efc38..beedaa7 100644 --- a/src/mainboard/amd/south_station/cmos.layout +++ b/src/mainboard/amd/south_station/cmos.layout @@ -1,7 +1,4 @@ #***************************************************************************** -# -# -# # SPDX-License-Identifier: GPL-2.0-only #***************************************************************************** diff --git a/src/mainboard/amd/thatcher/cmos.layout b/src/mainboard/amd/thatcher/cmos.layout index d450f6c..ade4c04 100644 --- a/src/mainboard/amd/thatcher/cmos.layout +++ b/src/mainboard/amd/thatcher/cmos.layout @@ -1,7 +1,4 @@ #***************************************************************************** -# -# -# # SPDX-License-Identifier: GPL-2.0-only #***************************************************************************** diff --git a/src/mainboard/amd/union_station/cmos.layout b/src/mainboard/amd/union_station/cmos.layout index 19efc38..beedaa7 100644 --- a/src/mainboard/amd/union_station/cmos.layout +++ b/src/mainboard/amd/union_station/cmos.layout @@ -1,7 +1,4 @@ #***************************************************************************** -# -# -# # SPDX-License-Identifier: GPL-2.0-only #***************************************************************************** diff --git a/src/mainboard/asrock/e350m1/cmos.layout b/src/mainboard/asrock/e350m1/cmos.layout index 390c94c3..75526c6 100644 --- a/src/mainboard/asrock/e350m1/cmos.layout +++ b/src/mainboard/asrock/e350m1/cmos.layout @@ -1,7 +1,4 @@ #***************************************************************************** -# -# -# # SPDX-License-Identifier: GPL-2.0-only #***************************************************************************** diff --git a/src/mainboard/asrock/imb-a180/cmos.layout b/src/mainboard/asrock/imb-a180/cmos.layout index d450f6c..ade4c04 100644 --- a/src/mainboard/asrock/imb-a180/cmos.layout +++ b/src/mainboard/asrock/imb-a180/cmos.layout @@ -1,7 +1,4 @@ #***************************************************************************** -# -# -# # SPDX-License-Identifier: GPL-2.0-only #***************************************************************************** diff --git a/src/mainboard/asus/am1i-a/cmos.layout b/src/mainboard/asus/am1i-a/cmos.layout index 7dcd798..9f9ee80 100644 --- a/src/mainboard/asus/am1i-a/cmos.layout +++ b/src/mainboard/asus/am1i-a/cmos.layout @@ -1,7 +1,4 @@ #***************************************************************************** -# -# -# # SPDX-License-Identifier: GPL-2.0-only #***************************************************************************** diff --git a/src/mainboard/asus/f2a85-m/cmos.layout b/src/mainboard/asus/f2a85-m/cmos.layout index d450f6c..ade4c04 100644 --- a/src/mainboard/asus/f2a85-m/cmos.layout +++ b/src/mainboard/asus/f2a85-m/cmos.layout @@ -1,7 +1,4 @@ #***************************************************************************** -# -# -# # SPDX-License-Identifier: GPL-2.0-only #***************************************************************************** diff --git a/src/mainboard/bap/ode_e20XX/cmos.layout b/src/mainboard/bap/ode_e20XX/cmos.layout index d450f6c..ade4c04 100644 --- a/src/mainboard/bap/ode_e20XX/cmos.layout +++ b/src/mainboard/bap/ode_e20XX/cmos.layout @@ -1,7 +1,4 @@ #***************************************************************************** -# -# -# # SPDX-License-Identifier: GPL-2.0-only #***************************************************************************** diff --git a/src/mainboard/bap/ode_e21XX/cmos.layout b/src/mainboard/bap/ode_e21XX/cmos.layout index d450f6c..ade4c04 100644 --- a/src/mainboard/bap/ode_e21XX/cmos.layout +++ b/src/mainboard/bap/ode_e21XX/cmos.layout @@ -1,7 +1,4 @@ #***************************************************************************** -# -# -# # SPDX-License-Identifier: GPL-2.0-only #***************************************************************************** diff --git a/src/mainboard/biostar/a68n_5200/cmos.layout b/src/mainboard/biostar/a68n_5200/cmos.layout index d450f6c..ade4c04 100644 --- a/src/mainboard/biostar/a68n_5200/cmos.layout +++ b/src/mainboard/biostar/a68n_5200/cmos.layout @@ -1,7 +1,4 @@ #***************************************************************************** -# -# -# # SPDX-License-Identifier: GPL-2.0-only #***************************************************************************** diff --git a/src/mainboard/biostar/am1ml/cmos.layout b/src/mainboard/biostar/am1ml/cmos.layout index c42e3b0..0cf4ede 100644 --- a/src/mainboard/biostar/am1ml/cmos.layout +++ b/src/mainboard/biostar/am1ml/cmos.layout @@ -1,7 +1,4 @@ #***************************************************************************** -# -# -# # SPDX-License-Identifier: GPL-2.0-only #***************************************************************************** diff --git a/src/mainboard/elmex/pcm205400/cmos.layout b/src/mainboard/elmex/pcm205400/cmos.layout index 138b75d..bc5b428 100644 --- a/src/mainboard/elmex/pcm205400/cmos.layout +++ b/src/mainboard/elmex/pcm205400/cmos.layout @@ -1,7 +1,4 @@ #***************************************************************************** -# -# -# # SPDX-License-Identifier: GPL-2.0-only #***************************************************************************** diff --git a/src/mainboard/gizmosphere/gizmo/cmos.layout b/src/mainboard/gizmosphere/gizmo/cmos.layout index 19efc38..beedaa7 100644 --- a/src/mainboard/gizmosphere/gizmo/cmos.layout +++ b/src/mainboard/gizmosphere/gizmo/cmos.layout @@ -1,7 +1,4 @@ #***************************************************************************** -# -# -# # SPDX-License-Identifier: GPL-2.0-only #***************************************************************************** diff --git a/src/mainboard/gizmosphere/gizmo2/cmos.layout b/src/mainboard/gizmosphere/gizmo2/cmos.layout index d450f6c..ade4c04 100644 --- a/src/mainboard/gizmosphere/gizmo2/cmos.layout +++ b/src/mainboard/gizmosphere/gizmo2/cmos.layout @@ -1,7 +1,4 @@ #***************************************************************************** -# -# -# # SPDX-License-Identifier: GPL-2.0-only #***************************************************************************** diff --git a/src/mainboard/google/foster/bct/cfg2inc.sh b/src/mainboard/google/foster/bct/cfg2inc.sh index 6fd8d2f..46c4922 100644 --- a/src/mainboard/google/foster/bct/cfg2inc.sh +++ b/src/mainboard/google/foster/bct/cfg2inc.sh @@ -1,7 +1,4 @@ #!/bin/sh -# -# -# # SPDX-License-Identifier: GPL-2.0-only bct_cfg2inc() { diff --git a/src/mainboard/google/nyan/bct/cfg2inc.sh b/src/mainboard/google/nyan/bct/cfg2inc.sh index 6fd8d2f..46c4922 100755 --- a/src/mainboard/google/nyan/bct/cfg2inc.sh +++ b/src/mainboard/google/nyan/bct/cfg2inc.sh @@ -1,7 +1,4 @@ #!/bin/sh -# -# -# # SPDX-License-Identifier: GPL-2.0-only bct_cfg2inc() { diff --git a/src/mainboard/google/smaug/bct/cfg2inc.sh b/src/mainboard/google/smaug/bct/cfg2inc.sh index 6fd8d2f..46c4922 100644 --- a/src/mainboard/google/smaug/bct/cfg2inc.sh +++ b/src/mainboard/google/smaug/bct/cfg2inc.sh @@ -1,7 +1,4 @@ #!/bin/sh -# -# -# # SPDX-License-Identifier: GPL-2.0-only bct_cfg2inc() { diff --git a/src/mainboard/hp/abm/cmos.layout b/src/mainboard/hp/abm/cmos.layout index d450f6c..ade4c04 100644 --- a/src/mainboard/hp/abm/cmos.layout +++ b/src/mainboard/hp/abm/cmos.layout @@ -1,7 +1,4 @@ #***************************************************************************** -# -# -# # SPDX-License-Identifier: GPL-2.0-only #***************************************************************************** diff --git a/src/mainboard/jetway/nf81-t56n-lf/cmos.layout b/src/mainboard/jetway/nf81-t56n-lf/cmos.layout index 19efc38..beedaa7 100644 --- a/src/mainboard/jetway/nf81-t56n-lf/cmos.layout +++ b/src/mainboard/jetway/nf81-t56n-lf/cmos.layout @@ -1,7 +1,4 @@ #***************************************************************************** -# -# -# # SPDX-License-Identifier: GPL-2.0-only #***************************************************************************** diff --git a/src/mainboard/lenovo/g505s/cmos.layout b/src/mainboard/lenovo/g505s/cmos.layout index 1b3363a..fa4f10b 100644 --- a/src/mainboard/lenovo/g505s/cmos.layout +++ b/src/mainboard/lenovo/g505s/cmos.layout @@ -1,7 +1,4 @@ #***************************************************************************** -# -# -# # SPDX-License-Identifier: GPL-2.0-only #***************************************************************************** diff --git a/src/mainboard/lippert/frontrunner-af/cmos.layout b/src/mainboard/lippert/frontrunner-af/cmos.layout index 19efc38..beedaa7 100644 --- a/src/mainboard/lippert/frontrunner-af/cmos.layout +++ b/src/mainboard/lippert/frontrunner-af/cmos.layout @@ -1,7 +1,4 @@ #***************************************************************************** -# -# -# # SPDX-License-Identifier: GPL-2.0-only #***************************************************************************** diff --git a/src/mainboard/lippert/toucan-af/cmos.layout b/src/mainboard/lippert/toucan-af/cmos.layout index 19efc38..beedaa7 100644 --- a/src/mainboard/lippert/toucan-af/cmos.layout +++ b/src/mainboard/lippert/toucan-af/cmos.layout @@ -1,7 +1,4 @@ #***************************************************************************** -# -# -# # SPDX-License-Identifier: GPL-2.0-only #***************************************************************************** diff --git a/src/mainboard/msi/ms7721/cmos.layout b/src/mainboard/msi/ms7721/cmos.layout index d450f6c..ade4c04 100644 --- a/src/mainboard/msi/ms7721/cmos.layout +++ b/src/mainboard/msi/ms7721/cmos.layout @@ -1,7 +1,4 @@ #***************************************************************************** -# -# -# # SPDX-License-Identifier: GPL-2.0-only #***************************************************************************** diff --git a/src/mainboard/pcengines/apu2/cmos.layout b/src/mainboard/pcengines/apu2/cmos.layout index 98b5c09..8663fcc 100644 --- a/src/mainboard/pcengines/apu2/cmos.layout +++ b/src/mainboard/pcengines/apu2/cmos.layout @@ -1,7 +1,4 @@ #***************************************************************************** -# -# -# # SPDX-License-Identifier: GPL-2.0-only #***************************************************************************** diff --git a/src/vendorcode/amd/Kconfig b/src/vendorcode/amd/Kconfig index 812217c..e080170 100644 --- a/src/vendorcode/amd/Kconfig +++ b/src/vendorcode/amd/Kconfig @@ -1,6 +1,3 @@ -# -# -# # SPDX-License-Identifier: GPL-2.0-only if CPU_AMD_AGESA || CPU_AMD_PI || SOC_AMD_PI diff --git a/src/vendorcode/amd/cimx/sb800/Makefile.inc b/src/vendorcode/amd/cimx/sb800/Makefile.inc index 5e95ac8..8eb72fa 100644 --- a/src/vendorcode/amd/cimx/sb800/Makefile.inc +++ b/src/vendorcode/amd/cimx/sb800/Makefile.inc @@ -1,5 +1,3 @@ -# -# # SPDX-License-Identifier: GPL-2.0-only CPPFLAGS_x86_32 += -I$(src)/southbridge/amd/cimx/sb800 diff --git a/src/vendorcode/amd/cimx/sb900/Makefile.inc b/src/vendorcode/amd/cimx/sb900/Makefile.inc index f7dedaa..416df7e 100644 --- a/src/vendorcode/amd/cimx/sb900/Makefile.inc +++ b/src/vendorcode/amd/cimx/sb900/Makefile.inc @@ -1,5 +1,3 @@ -# -# # SPDX-License-Identifier: GPL-2.0-only CPPFLAGS_x86_32 += -I$(src)/southbridge/amd/cimx/sb900 diff --git a/src/vendorcode/eltan/Makefile.inc b/src/vendorcode/eltan/Makefile.inc index 1cc43a2..4195d95 100644 --- a/src/vendorcode/eltan/Makefile.inc +++ b/src/vendorcode/eltan/Makefile.inc @@ -1,6 +1,3 @@ -# -# -# # SPDX-License-Identifier: GPL-2.0-only subdirs-y += security -- To view, visit https://review.coreboot.org/c/coreboot/+/41838 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I8e14a0ad1e1e2227e4fb201f5d157f56f289f286 Gerrit-Change-Number: 41838 Gerrit-PatchSet: 1 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Piotr Król <piotr.krol(a)3mdeb.com> Gerrit-MessageType: newchange

4 5

Change in coreboot[master]: soc/intel/common/block: Remove unused headers
by Angel Pons (Code Review) 01 Jun '20

01 Jun '20

Angel Pons has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/41926 ) Change subject: soc/intel/common/block: Remove unused headers ...................................................................... soc/intel/common/block: Remove unused headers Change-Id: I8877a70661cacc57ea893da172d9a4b6d19ba06a Signed-off-by: Angel Pons <th3fanbus(a)gmail.com> --- M src/soc/intel/common/block/cpu/cpulib.c M src/soc/intel/common/block/power_limit/power_limit.c 2 files changed, 0 insertions(+), 5 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/26/41926/1 diff --git a/src/soc/intel/common/block/cpu/cpulib.c b/src/soc/intel/common/block/cpu/cpulib.c index c39b453..7201432 100644 --- a/src/soc/intel/common/block/cpu/cpulib.c +++ b/src/soc/intel/common/block/cpu/cpulib.c @@ -9,10 +9,6 @@ #include <intelblocks/cpulib.h> #include <intelblocks/fast_spi.h> #include <intelblocks/msr.h> -#include <soc/cpu.h> -#include <soc/iomap.h> -#include <soc/pm.h> -#include <soc/pci_devs.h> #include <stdint.h> /* diff --git a/src/soc/intel/common/block/power_limit/power_limit.c b/src/soc/intel/common/block/power_limit/power_limit.c index 2ac82b3..e6c65c3 100644 --- a/src/soc/intel/common/block/power_limit/power_limit.c +++ b/src/soc/intel/common/block/power_limit/power_limit.c @@ -5,7 +5,6 @@ #include <intelblocks/cpulib.h> #include <intelblocks/power_limit.h> #include <soc/msr.h> -#include <soc/soc_chip.h> #include <soc/systemagent.h> /* Convert time in seconds to POWER_LIMIT_1_TIME MSR value */ -- To view, visit https://review.coreboot.org/c/coreboot/+/41926 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I8877a70661cacc57ea893da172d9a4b6d19ba06a Gerrit-Change-Number: 41926 Gerrit-PatchSet: 1 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: newchange

4 5

Change in coreboot[master]: drivers/intel/fsp2_0: Add FSP 2.2 specific support
by Subrata Banik (Code Review) 01 Jun '20

01 Jun '20

Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41728 ) Change subject: drivers/intel/fsp2_0: Add FSP 2.2 specific support ...................................................................... Patch Set 1: (1 comment) https://review.coreboot.org/c/coreboot/+/41728/1/src/drivers/intel/fsp2_0/s… File src/drivers/intel/fsp2_0/silicon_init.c: https://review.coreboot.org/c/coreboot/+/41728/1/src/drivers/intel/fsp2_0/s… PS1, Line 100: multi_phase_params = xmalloc(sizeof(struct fsp_multi_phase_params)); : multi_phase_get_number = : xmalloc(sizeof(struct fsp_multi_phase_get_number_of_phase_params)); > Do we really need to allocate heap for these? Seems like they could be local variables on the stack. Ack -- To view, visit https://review.coreboot.org/c/coreboot/+/41728 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: If7177a267f3a9b4cbb60a639f1c737b9a3341913 Gerrit-Change-Number: 41728 Gerrit-PatchSet: 1 Gerrit-Owner: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: Aamir Bohra <aamir.bohra(a)intel.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Andrey Petrov <andrey.petrov(a)gmail.com> Gerrit-Reviewer: Duncan Laurie <dlaurie(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Maulik V Vaghela <maulik.v.vaghela(a)intel.com> Gerrit-Reviewer: Nathaniel L Desimone <nathaniel.l.desimone(a)intel.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Sridhar Siricilla <sridhar.siricilla(a)intel.com> Gerrit-Reviewer: Srinidhi N Kaushik <srinidhi.n.kaushik(a)intel.com> Gerrit-Reviewer: Wonkyu Kim <wonkyu.kim(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Comment-Date: Mon, 01 Jun 2020 17:55:02 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Nathaniel L Desimone <nathaniel.l.desimone(a)intel.com> Gerrit-MessageType: comment

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit June 2020