Felix Held has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/42433 )
Change subject: amd/mandolin: unbreak SeaBIOS VBIOS support
......................................................................
amd/mandolin: unbreak SeaBIOS VBIOS support
This is a workaround and not a clean solution, but avoids breakage.
Change-Id: I4d9042615965b6a2d9255c194cf23368264ffe54
Signed-off-by: Felix Held <felix-coreboot(a)felixheld.de>
---
M src/mainboard/amd/mandolin/Kconfig
1 file changed, 12 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/33/42433/1
diff --git a/src/mainboard/amd/mandolin/Kconfig b/src/mainboard/amd/mandolin/Kconfig
index c93bc34..bd01dec 100644
--- a/src/mainboard/amd/mandolin/Kconfig
+++ b/src/mainboard/amd/mandolin/Kconfig
@@ -104,4 +104,16 @@
Picasso's LPC bus signals are MUXed with some of the EMMC signals.
Select this option if LPC signals are required.
+#TODO: remove this hack to not break graphics in combination with SeaBIOS
+config VGA_BIOS_DGPU_ID
+ string
+ default "1002,15d8"
+ help
+ The default VGA BIOS PCI vendor/device ID should be set to the
+ result of the map_oprom_vendev() function in northbridge.c.
+
+config VGA_BIOS_DGPU_FILE
+ string
+ default "3rdparty/amd_blobs/picasso/PicassoGenericVbios.bin"
+
endif # BOARD_AMD_MANDOLIN
--
To view, visit https://review.coreboot.org/c/coreboot/+/42433
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I4d9042615965b6a2d9255c194cf23368264ffe54
Gerrit-Change-Number: 42433
Gerrit-PatchSet: 1
Gerrit-Owner: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-MessageType: newchange
Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42423 )
Change subject: ACPI: Add framework for GNVS initialisation
......................................................................
Patch Set 5:
(1 comment)
https://review.coreboot.org/c/coreboot/+/42423/5/src/acpi/gnvs.c
File src/acpi/gnvs.c:
https://review.coreboot.org/c/coreboot/+/42423/5/src/acpi/gnvs.c@55
PS5, Line 55: gnvs_assign_chromeos();
Does it matter if we call this twice until CB:42493 lands? I have it here in case there was a need to split CB:42493 into platforms.
--
To view, visit https://review.coreboot.org/c/coreboot/+/42423
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iccad533c3824d70f6cbae52cc8dd79f142ece944
Gerrit-Change-Number: 42423
Gerrit-PatchSet: 5
Gerrit-Owner: Kyösti Mälkki <kyosti.malkki(a)gmail.com>
Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com>
Gerrit-Reviewer: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Comment-Date: Sat, 20 Jun 2020 23:21:33 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42618 )
Change subject: sb/intel/lynxpoint: Drop stale code paths
......................................................................
Patch Set 1: Code-Review+2
> Patch Set 1:
>
> > Patch Set 1: Code-Review+1
> >
> > Rebase this so that CB:42617 is done after?
>
> Too lazy to messup gerrit with complete rebuild on the branch.
Ack
--
To view, visit https://review.coreboot.org/c/coreboot/+/42618
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I689bee55943b29990f54cb798b999940eae180bc
Gerrit-Change-Number: 42618
Gerrit-PatchSet: 1
Gerrit-Owner: Kyösti Mälkki <kyosti.malkki(a)gmail.com>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Comment-Date: Sat, 20 Jun 2020 22:51:33 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42618 )
Change subject: sb/intel/lynxpoint: Drop stale code paths
......................................................................
Patch Set 1:
> Patch Set 1: Code-Review+1
>
> Rebase this so that CB:42617 is done after?
Too lazy to messup gerrit with complete rebuild on the branch.
--
To view, visit https://review.coreboot.org/c/coreboot/+/42618
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I689bee55943b29990f54cb798b999940eae180bc
Gerrit-Change-Number: 42618
Gerrit-PatchSet: 1
Gerrit-Owner: Kyösti Mälkki <kyosti.malkki(a)gmail.com>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Comment-Date: Sat, 20 Jun 2020 22:34:33 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment