coreboot-gerrit April 2020

coreboot-gerrit@coreboot.org

1 participants
2294 discussions

Change in coreboot[master]: mb/ocp/tiogapass: Update UPD IIO bifurcation at run-time
by Johnny Lin (Code Review) 31 Mar '20

31 Mar '20

Johnny Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39895 ) Change subject: mb/ocp/tiogapass: Update UPD IIO bifurcation at run-time ...................................................................... Patch Set 6: (20 comments) https://review.coreboot.org/c/coreboot/+/39895/5/src/mainboard/ocp/tiogapas… File src/mainboard/ocp/tiogapass/skxsp_tp_iio.h: https://review.coreboot.org/c/coreboot/+/39895/5/src/mainboard/ocp/tiogapas… PS5, Line 23: Socket0_Iou0 = 0, > please, no spaces at the start of a line Done https://review.coreboot.org/c/coreboot/+/39895/5/src/mainboard/ocp/tiogapas… PS5, Line 23: Socket0_Iou0 = 0, > code indent should use tabs where possible Done https://review.coreboot.org/c/coreboot/+/39895/5/src/mainboard/ocp/tiogapas… PS5, Line 24: Socket0_Iou1, > please, no spaces at the start of a line Done https://review.coreboot.org/c/coreboot/+/39895/5/src/mainboard/ocp/tiogapas… PS5, Line 24: Socket0_Iou1, > code indent should use tabs where possible Done https://review.coreboot.org/c/coreboot/+/39895/5/src/mainboard/ocp/tiogapas… PS5, Line 25: Socket0_Iou2, > please, no spaces at the start of a line Done https://review.coreboot.org/c/coreboot/+/39895/5/src/mainboard/ocp/tiogapas… PS5, Line 25: Socket0_Iou2, > code indent should use tabs where possible Done https://review.coreboot.org/c/coreboot/+/39895/5/src/mainboard/ocp/tiogapas… PS5, Line 26: Socket0_Mcp0, > please, no spaces at the start of a line Done https://review.coreboot.org/c/coreboot/+/39895/5/src/mainboard/ocp/tiogapas… PS5, Line 26: Socket0_Mcp0, > code indent should use tabs where possible Done https://review.coreboot.org/c/coreboot/+/39895/5/src/mainboard/ocp/tiogapas… PS5, Line 27: Socket0_Mcp1, > please, no spaces at the start of a line Done https://review.coreboot.org/c/coreboot/+/39895/5/src/mainboard/ocp/tiogapas… PS5, Line 27: Socket0_Mcp1, > code indent should use tabs where possible Done https://review.coreboot.org/c/coreboot/+/39895/5/src/mainboard/ocp/tiogapas… PS5, Line 28: Socket1_Iou0, > please, no spaces at the start of a line Done https://review.coreboot.org/c/coreboot/+/39895/5/src/mainboard/ocp/tiogapas… PS5, Line 28: Socket1_Iou0, > code indent should use tabs where possible Done https://review.coreboot.org/c/coreboot/+/39895/5/src/mainboard/ocp/tiogapas… PS5, Line 29: Socket1_Iou1, > code indent should use tabs where possible Done https://review.coreboot.org/c/coreboot/+/39895/5/src/mainboard/ocp/tiogapas… PS5, Line 29: Socket1_Iou1, > please, no spaces at the start of a line Done https://review.coreboot.org/c/coreboot/+/39895/5/src/mainboard/ocp/tiogapas… PS5, Line 30: Socket1_Iou2, > code indent should use tabs where possible Done https://review.coreboot.org/c/coreboot/+/39895/5/src/mainboard/ocp/tiogapas… PS5, Line 30: Socket1_Iou2, > please, no spaces at the start of a line Done https://review.coreboot.org/c/coreboot/+/39895/5/src/mainboard/ocp/tiogapas… PS5, Line 31: Socket1_Mcp0, > code indent should use tabs where possible Done https://review.coreboot.org/c/coreboot/+/39895/5/src/mainboard/ocp/tiogapas… PS5, Line 31: Socket1_Mcp0, > please, no spaces at the start of a line Done https://review.coreboot.org/c/coreboot/+/39895/5/src/mainboard/ocp/tiogapas… PS5, Line 32: Socket1_Mcp1 > please, no spaces at the start of a line Done https://review.coreboot.org/c/coreboot/+/39895/5/src/mainboard/ocp/tiogapas… PS5, Line 32: Socket1_Mcp1 > code indent should use tabs where possible Done -- To view, visit https://review.coreboot.org/c/coreboot/+/39895 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I8e63a233a2235cd45b14b20542e6efab3de17899 Gerrit-Change-Number: 39895 Gerrit-PatchSet: 6 Gerrit-Owner: Johnny Lin Gerrit-Reviewer: Andrey Petrov <andrey.petrov(a)gmail.com> Gerrit-Reviewer: Anjaneya "Reddy" Chagam <anjaneya.chagam(a)intel.com> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Jingle Hsu Gerrit-Reviewer: Jonathan Zhang <jonzhang(a)fb.com> Gerrit-Reviewer: Morgan Jang Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 01 Apr 2020 01:05:36 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/ocp/tiogapass: Update UPD IIO bifurcation at run-time
by Johnny Lin (Code Review) 31 Mar '20

31 Mar '20

Hello build bot (Jenkins), Anjaneya "Reddy" Chagam, Jonathan Zhang, David Hendricks, Jingle Hsu, Morgan Jang, Andrey Petrov, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/39895 to look at the new patch set (#6). Change subject: mb/ocp/tiogapass: Update UPD IIO bifurcation at run-time ...................................................................... mb/ocp/tiogapass: Update UPD IIO bifurcation at run-time Update UPD IIO bifurcation at run-time accroding to different hardware configurations such as different Riser cards. With the engineering build FSP, it can only configure IIO for one socket so my local test need to remove all socket1 elements from tp_iio_bifur_table. Tested=OCP Tioga Pass can see socket0 IIO being updated with an engineering build FSP. Change-Id: I8e63a233a2235cd45b14b20542e6efab3de17899 Signed-off-by: Johnny Lin <johnny_lin(a)wiwynn.com> --- M src/mainboard/ocp/tiogapass/romstage.c M src/mainboard/ocp/tiogapass/skxsp_tp_iio.h 2 files changed, 30 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/95/39895/6 -- To view, visit https://review.coreboot.org/c/coreboot/+/39895 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I8e63a233a2235cd45b14b20542e6efab3de17899 Gerrit-Change-Number: 39895 Gerrit-PatchSet: 6 Gerrit-Owner: Johnny Lin Gerrit-Reviewer: Andrey Petrov <andrey.petrov(a)gmail.com> Gerrit-Reviewer: Anjaneya "Reddy" Chagam <anjaneya.chagam(a)intel.com> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Jingle Hsu Gerrit-Reviewer: Jonathan Zhang <jonzhang(a)fb.com> Gerrit-Reviewer: Morgan Jang Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: mb/ocp/tiogapass: Update UPD IIO bifurcation at run-time
by Johnny Lin (Code Review) 31 Mar '20

31 Mar '20

1 0

Change in coreboot[master]: [WIP] mainboard: Add Acer ES1-572
by Benjamin Doron (Code Review) 31 Mar '20

31 Mar '20

Benjamin Doron has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38978 ) Change subject: [WIP] mainboard: Add Acer ES1-572 ...................................................................... Patch Set 5: (2 comments) https://review.coreboot.org/c/coreboot/+/38978/5//COMMIT_MSG Commit Message: https://review.coreboot.org/c/coreboot/+/38978/5//COMMIT_MSG@31 PS5, Line 31: - Battery. I have it somewhere. > yes but no. […] ACPI code needs to be added to communicate with the EC. Check the vendor's DSDT https://review.coreboot.org/c/coreboot/+/38978/5/src/mainboard/acer/es1-572… File src/mainboard/acer/es1-572/devicetree.cb: https://review.coreboot.org/c/coreboot/+/38978/5/src/mainboard/acer/es1-572… PS5, Line 266: device pci 1f.5 off end # PCH SPI > breaks rom console, too Off-topic, but presently, lpc_set_lock_enable in the common code locks BIOS write-enable=1. Is there any reason why this is the case, or should we fix it (preferably with a check against a lockdown related config, CONFIG_DO_NOT_TOUCH_DESCRIPTOR_REGION or CB:32704)? -- To view, visit https://review.coreboot.org/c/coreboot/+/38978 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id98788a2c5e54f70fd1cacbd70d636f5e63b2619 Gerrit-Change-Number: 38978 Gerrit-PatchSet: 5 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Michael Niewöhner Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Felix Singer <felixsinger(a)posteo.net> Gerrit-CC: Benjamin Doron <benjamin.doron00(a)gmail.com> Gerrit-Comment-Date: Wed, 01 Apr 2020 00:12:29 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Michael Niewöhner Gerrit-MessageType: comment

1 0

Jump to page:

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit April 2020