coreboot-gerrit March 2020

coreboot-gerrit@coreboot.org

1 participants
3326 discussions

Change in coreboot[master]: soc/intel/common/block/smm: add case intrusion to SMI handler
by Aaron Durbin (Code Review) 11 Mar '20

11 Mar '20

Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39265 ) Change subject: soc/intel/common/block/smm: add case intrusion to SMI handler ...................................................................... Patch Set 8: (1 comment) https://review.coreboot.org/c/coreboot/+/39265/6/src/soc/intel/common/block… File src/soc/intel/common/block/smm/smihandler.c: https://review.coreboot.org/c/coreboot/+/39265/6/src/soc/intel/common/block… PS6, Line 434: if (!tco_sts) > Note: if we agree that this code should be eliminated by an #if in the southbridge_smi array, that p […] Ya. I guess I was going for reducing the code footprint. Otherwise it sits around -- even while not being used. I like your #if idea on the handler array. -- To view, visit https://review.coreboot.org/c/coreboot/+/39265 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ifad675bb09215ada760efebdcd915958febf5778 Gerrit-Change-Number: 39265 Gerrit-PatchSet: 8 Gerrit-Owner: Michael Niewöhner Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 11 Mar 2020 15:19:31 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Patrick Georgi <pgeorgi(a)google.com> Comment-In-Reply-To: Michael Niewöhner Comment-In-Reply-To: Aaron Durbin <adurbin(a)chromium.org> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: nb/intel/i945: Programm CxODT value for each channel
by HAOUAS Elyes (Code Review) 11 Mar '20

11 Mar '20

HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/18548 ) Change subject: nb/intel/i945: Programm CxODT value for each channel ...................................................................... Patch Set 26: please don't merge it now. Maybe it needs more works. The main problem still the documentation ... -- To view, visit https://review.coreboot.org/c/coreboot/+/18548 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I7aec35f45250da554ddc5a68f5add157c313399c Gerrit-Change-Number: 18548 Gerrit-PatchSet: 26 Gerrit-Owner: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Patrick Georgi <pgeorgi(a)google.com> Gerrit-CC: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Comment-Date: Wed, 11 Mar 2020 15:18:44 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: superio/nuvoton/nct5539d: Update documentation and remove DSDT
by Patrick Rudolph (Code Review) 11 Mar '20

11 Mar '20

Patrick Rudolph has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/38864 ) Change subject: superio/nuvoton/nct5539d: Update documentation and remove DSDT ...................................................................... superio/nuvoton/nct5539d: Update documentation and remove DSDT There seems to be no board using this, but some currently under review. Remove the DSDT, which doesn't work together with the SSDT ACPI code generation. Also update the documentation pointing to the SSDT generator. Change-Id: I8b7daeadaaac93d74ee2fc9eb18f0eff5ef50eb3 Signed-off-by: Patrick Rudolph <patrick.rudolph(a)9elements.com> --- M Documentation/superio/index.md A Documentation/superio/nuvoton/nct5539d.md D src/superio/nuvoton/nct5539d/acpi/superio.asl 3 files changed, 10 insertions(+), 157 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/64/38864/1 diff --git a/Documentation/superio/index.md b/Documentation/superio/index.md index 053663b..81287bb 100644 --- a/Documentation/superio/index.md +++ b/Documentation/superio/index.md @@ -5,6 +5,7 @@ ## Nuvoton - [NPCD378](nuvoton/npcd378.md) +- [NCT5539D](nuvoton/nct5539d.md) ## Common - [PNP devices](common/pnp.md) diff --git a/Documentation/superio/nuvoton/nct5539d.md b/Documentation/superio/nuvoton/nct5539d.md new file mode 100644 index 0000000..e91ebc3 --- /dev/null +++ b/Documentation/superio/nuvoton/nct5539d.md @@ -0,0 +1,9 @@ +# NCT5539D SuperIO + +The SuperIO has the ID `0xd121` and the source can be found in +`src/superio/nuvoton/nct5539d/`. + +## For developers + +The SuperIO generates ACPI using the +[SSDT generator for generic SuperIOs](../common/ssdt.md). diff --git a/src/superio/nuvoton/nct5539d/acpi/superio.asl b/src/superio/nuvoton/nct5539d/acpi/superio.asl deleted file mode 100644 index 6f49421..0000000 --- a/src/superio/nuvoton/nct5539d/acpi/superio.asl +++ /dev/null @@ -1,157 +0,0 @@ -/* SPDX-License-Identifier: GPL-2.0-only */ -/* This file is part of the coreboot project. */ - -/* - * Include this file into a mainboard's DSDT _SB device tree and it will - * expose the NCT5539D SuperIO and some of its functionality. - * - * It allows the change of IO ports, IRQs and DMA settings on logical - * devices, disabling and reenabling logical devices. - * - * LDN State - * 0x2 SP1 Implemented, untested - * 0x5 KBC Implemented, untested - * 0x8 GPIO Implemented, untested - * 0xb HWM Implemented, untested - * - * Controllable through preprocessor defines: - * SUPERIO_DEV Device identifier for this SIO (e.g. SIO0) - * SUPERIO_PNP_BASE I/O address of the first PnP configuration register - * NCT5539D_SHOW_SP1 If defined, Serial Port 1 will be exposed. - * NCT5539D_SHOW_KBC If defined, the Keyboard Controller will be exposed. - * NCT5539D_SHOW_GPIO If defined, GPIO support will be exposed. - * NCT5539D_SHOW_HWM If defined, the Environment Controller will be exposed. - */ - -#undef SUPERIO_CHIP_NAME -#define SUPERIO_CHIP_NAME NCT5539D -#include <superio/acpi/pnp.asl> - -#undef PNP_DEFAULT_PSC -#define PNP_DEFAULT_PSC Return (0) /* no power management */ - -Device(SUPERIO_DEV) { - Name (_HID, EisaId("PNP0A05")) - Name (_STR, Unicode("Nuvoton NCT5539D Super I/O")) - Name (_UID, SUPERIO_UID(SUPERIO_DEV,)) - - /* SuperIO configuration ports */ - OperationRegion (CREG, SystemIO, SUPERIO_PNP_BASE, 0x02) - Field (CREG, ByteAcc, NoLock, Preserve) - { - PNP_ADDR_REG, 8, - PNP_DATA_REG, 8, - } - IndexField (PNP_ADDR_REG, PNP_DATA_REG, ByteAcc, NoLock, Preserve) - { - Offset (0x07), - PNP_LOGICAL_DEVICE, 8, /* Logical device selector */ - - Offset (0x30), - PNP_DEVICE_ACTIVE, 1, /* Logical device activation */ - ACT1, 1, /* Logical device activation */ - ACT2, 1, /* Logical device activation */ - ACT3, 1, /* Logical device activation */ - ACT4, 1, /* Logical device activation */ - ACT5, 1, /* Logical device activation */ - ACT6, 1, /* Logical device activation */ - ACT7, 1, /* Logical device activation */ - - Offset (0x60), - PNP_IO0_HIGH_BYTE, 8, /* First I/O port base - high byte */ - PNP_IO0_LOW_BYTE, 8, /* First I/O port base - low byte */ - Offset (0x62), - PNP_IO1_HIGH_BYTE, 8, /* Second I/O port base - high byte */ - PNP_IO1_LOW_BYTE, 8, /* Second I/O port base - low byte */ - Offset (0x64), - PNP_IO2_HIGH_BYTE, 8, /* Third I/O port base - high byte */ - PNP_IO2_LOW_BYTE, 8, /* Third I/O port base - low byte */ - - Offset (0x70), - PNP_IRQ0, 8, /* First IRQ */ - Offset (0x72), - PNP_IRQ1, 8, /* Second IRQ */ - Offset (0x74), - PNP_DMA0, 8, /* DRQ */ - } - - Method (_CRS) - { - /* Announce the used I/O ports to the OS */ - Return (ResourceTemplate () { - IO (Decode16, SUPERIO_PNP_BASE, SUPERIO_PNP_BASE, 0x01, 0x02) - }) - } - - #undef PNP_ENTER_MAGIC_1ST - #undef PNP_ENTER_MAGIC_2ND - #undef PNP_ENTER_MAGIC_3RD - #undef PNP_ENTER_MAGIC_4TH - #undef PNP_EXIT_MAGIC_1ST - #undef PNP_EXIT_SPECIAL_REG - #undef PNP_EXIT_SPECIAL_VAL - #define PNP_ENTER_MAGIC_1ST 0x87 - #define PNP_ENTER_MAGIC_2ND 0x87 - #define PNP_EXIT_MAGIC_1ST 0xaa - #include <superio/acpi/pnp_config.asl> - - -#ifdef NCT5539D_SHOW_SP1 - #undef SUPERIO_UART_LDN - #undef SUPERIO_UART_DDN - #undef SUPERIO_UART_PM_REG - #undef SUPERIO_UART_PM_VAL - #undef SUPERIO_UART_PM_LDN - #define SUPERIO_UART_LDN 2 - #include <superio/acpi/pnp_uart.asl> -#endif - -#ifdef NCT5539D_SHOW_KBC - #undef SUPERIO_KBC_LDN - #undef SUPERIO_KBC_PS2M - #undef SUPERIO_KBC_PS2LDN - #define SUPERIO_KBC_LDN 5 - #define SUPERIO_KBC_PS2M - #include <superio/acpi/pnp_kbc.asl> -#endif - -#ifdef NCT5539D_SHOW_HWM - #undef SUPERIO_PNP_HID - #undef SUPERIO_PNP_LDN - #undef SUPERIO_PNP_DDN - #undef SUPERIO_PNP_PM_REG - #undef SUPERIO_PNP_PM_VAL - #undef SUPERIO_PNP_PM_LDN - #undef SUPERIO_PNP_IO0 - #undef SUPERIO_PNP_IO1 - #undef SUPERIO_PNP_IO2 - #undef SUPERIO_PNP_IRQ0 - #undef SUPERIO_PNP_IRQ1 - #undef SUPERIO_PNP_DMA - #define SUPERIO_PNP_LDN 11 - #define SUPERIO_PNP_IO0 0x08, 0x08 - #define SUPERIO_PNP_IO1 0x08, 0x08 - #define SUPERIO_PNP_IRQ0 - #include <superio/acpi/pnp_generic.asl> -#endif - -#ifdef NCT5539D_SHOW_GPIO - #undef SUPERIO_PNP_HID - #undef SUPERIO_PNP_LDN - #undef SUPERIO_PNP_DDN - #undef SUPERIO_PNP_PM_REG - #undef SUPERIO_PNP_PM_VAL - #undef SUPERIO_PNP_PM_LDN - #undef SUPERIO_PNP_IO0 - #undef SUPERIO_PNP_IO1 - #undef SUPERIO_PNP_IO2 - #undef SUPERIO_PNP_IRQ0 - #undef SUPERIO_PNP_IRQ1 - #undef SUPERIO_PNP_DMA - #undef PNP_DEVICE_ACTIVE - #define PNP_DEVICE_ACTIVE ACT3 - #define SUPERIO_PNP_LDN 8 - #define SUPERIO_PNP_IO0 0x08, 0x08 - #include <superio/acpi/pnp_generic.asl> -#endif -} -- To view, visit https://review.coreboot.org/c/coreboot/+/38864 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I8b7daeadaaac93d74ee2fc9eb18f0eff5ef50eb3 Gerrit-Change-Number: 38864 Gerrit-PatchSet: 1 Gerrit-Owner: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-MessageType: newchange

7 14

Change in coreboot[master]: drivers/intel/gma/acpi: Prevent DivideByZero error
by Patrick Rudolph (Code Review) 11 Mar '20

11 Mar '20

Patrick Rudolph has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/39158 ) Change subject: drivers/intel/gma/acpi: Prevent DivideByZero error ...................................................................... drivers/intel/gma/acpi: Prevent DivideByZero error In case backlight control isn't enabled the register is zero. Return early instead of running into a DivideByZero error. This is seen on devices that doesn't have backlight control, like desktops and servers. The proper fix is to not include those ACPI methods, but that requires a much bigger refactoring. Change-Id: Ie9bdb00949d6d44fd99321db556d6008d2d12a7f Signed-off-by: Patrick Rudolph <patrick.rudolph(a)9elements.com> --- M src/drivers/intel/gma/acpi/configure_brightness_levels.asl 1 file changed, 5 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/58/39158/1 diff --git a/src/drivers/intel/gma/acpi/configure_brightness_levels.asl b/src/drivers/intel/gma/acpi/configure_brightness_levels.asl index 3ec7411..21f0b23 100644 --- a/src/drivers/intel/gma/acpi/configure_brightness_levels.asl +++ b/src/drivers/intel/gma/acpi/configure_brightness_levels.asl @@ -122,6 +122,11 @@ /* Find value closest to BCLV in BRIG (which must be ordered) */ Method (XBQC, 0, NotSerialized) { + /* Prevent DivideByZero if backlight control isn't enabled */ + If (BCLM == 0) + { + Return (Zero) + } /* Local0: current percentage */ Store (DRCL (Multiply (BCLV, 100), BCLM), Local0) -- To view, visit https://review.coreboot.org/c/coreboot/+/39158 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ie9bdb00949d6d44fd99321db556d6008d2d12a7f Gerrit-Change-Number: 39158 Gerrit-PatchSet: 1 Gerrit-Owner: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-MessageType: newchange

4 5

Change in coreboot[master]: payloads/cbui: Add new payload CBUI
by build bot (Jenkins) (Code Review) 11 Mar '20

11 Mar '20

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/23586 ) Change subject: payloads/cbui: Add new payload CBUI ...................................................................... Patch Set 8: (298 comments) https://review.coreboot.org/c/coreboot/+/23586/8/payloads/cbui/Kconfig File payloads/cbui/Kconfig: https://review.coreboot.org/c/coreboot/+/23586/8/payloads/cbui/Kconfig@37 PS8, Line 37: config LANG_PREFERED 'PREFERED' may be misspelled - perhaps 'PREFERRED'? https://review.coreboot.org/c/coreboot/+/23586/8/payloads/cbui/Kconfig@38 PS8, Line 38: string "Prefered UI language" 'Prefered' may be misspelled - perhaps 'Preferred'? https://review.coreboot.org/c/coreboot/+/23586/8/payloads/cbui/NuklearUI/Nu… File payloads/cbui/NuklearUI/NuklearCombo.h: https://review.coreboot.org/c/coreboot/+/23586/8/payloads/cbui/NuklearUI/Nu… PS8, Line 23: { open brace '{' following struct go on the same line https://review.coreboot.org/c/coreboot/+/23586/8/payloads/cbui/NuklearUI/Nu… File payloads/cbui/NuklearUI/NuklearDatePicker.h: https://review.coreboot.org/c/coreboot/+/23586/8/payloads/cbui/NuklearUI/Nu… PS8, Line 24: { open brace '{' following struct go on the same line https://review.coreboot.org/c/coreboot/+/23586/8/payloads/cbui/NuklearUI/Nu… File payloads/cbui/NuklearUI/NuklearDatePicker.c: https://review.coreboot.org/c/coreboot/+/23586/8/payloads/cbui/NuklearUI/Nu… PS8, Line 32: switch (month) { switch and case should be at the same indent https://review.coreboot.org/c/coreboot/+/23586/8/payloads/cbui/NuklearUI/Nu… PS8, Line 278: struct nuklear_datepicker* obj; "foo* bar" should be "foo *bar" https://review.coreboot.org/c/coreboot/+/23586/8/payloads/cbui/NuklearUI/Nu… File payloads/cbui/NuklearUI/NuklearGroup.h: https://review.coreboot.org/c/coreboot/+/23586/8/payloads/cbui/NuklearUI/Nu… PS8, Line 23: { open brace '{' following struct go on the same line https://review.coreboot.org/c/coreboot/+/23586/8/payloads/cbui/NuklearUI/Nu… File payloads/cbui/NuklearUI/NuklearIntegerRange.h: https://review.coreboot.org/c/coreboot/+/23586/8/payloads/cbui/NuklearUI/Nu… PS8, Line 23: { open brace '{' following struct go on the same line https://review.coreboot.org/c/coreboot/+/23586/8/payloads/cbui/NuklearUI/Nu… File payloads/cbui/NuklearUI/NuklearLabel.h: https://review.coreboot.org/c/coreboot/+/23586/8/payloads/cbui/NuklearUI/Nu… PS8, Line 23: { open brace '{' following struct go on the same line https://review.coreboot.org/c/coreboot/+/23586/8/payloads/cbui/NuklearUI/Nu… PS8, Line 34: void NuklearLabel_dtor(void* obj); "foo* bar" should be "foo *bar" https://review.coreboot.org/c/coreboot/+/23586/8/payloads/cbui/NuklearUI/Nu… File payloads/cbui/NuklearUI/NuklearLabel.c: https://review.coreboot.org/c/coreboot/+/23586/8/payloads/cbui/NuklearUI/Nu… PS8, Line 81: void NuklearLabel_dtor(void* obj) "foo* bar" should be "foo *bar" https://review.coreboot.org/c/coreboot/+/23586/8/payloads/cbui/NuklearUI/Nu… File payloads/cbui/NuklearUI/NuklearObject.h: https://review.coreboot.org/c/coreboot/+/23586/8/payloads/cbui/NuklearUI/Nu… PS8, Line 21: { open brace '{' following struct go on the same line https://review.coreboot.org/c/coreboot/+/23586/8/payloads/cbui/NuklearUI/Nu… PS8, Line 44: void NuklearObject_ctor(struct nuklear_object* obj, "foo* bar" should be "foo *bar" https://review.coreboot.org/c/coreboot/+/23586/8/payloads/cbui/NuklearUI/Nu… PS8, Line 49: void NuklearObject_dtor(void* obj); "foo* bar" should be "foo *bar" https://review.coreboot.org/c/coreboot/+/23586/8/payloads/cbui/NuklearUI/Nu… File payloads/cbui/NuklearUI/NuklearRoot.c: https://review.coreboot.org/c/coreboot/+/23586/8/payloads/cbui/NuklearUI/Nu… PS8, Line 24: { open brace '{' following struct go on the same line https://review.coreboot.org/c/coreboot/+/23586/8/payloads/cbui/NuklearUI/Nu… PS8, Line 100: } else { else is not generally useful after a break or return https://review.coreboot.org/c/coreboot/+/23586/8/payloads/cbui/NuklearUI/Nu… PS8, Line 219: struct nuklear_root* NuklearRoot_ctor(void) "foo* bar" should be "foo *bar" https://review.coreboot.org/c/coreboot/+/23586/8/payloads/cbui/NuklearUI/Nu… File payloads/cbui/NuklearUI/NuklearTabView.c: https://review.coreboot.org/c/coreboot/+/23586/8/payloads/cbui/NuklearUI/Nu… PS8, Line 25: { open brace '{' following struct go on the same line https://review.coreboot.org/c/coreboot/+/23586/8/payloads/cbui/NuklearUI/Nu… PS8, Line 31: { open brace '{' following struct go on the same line https://review.coreboot.org/c/coreboot/+/23586/8/payloads/cbui/NuklearUI/Nu… PS8, Line 43: struct nuklear_tabview_map* map = NULL; "foo* bar" should be "foo *bar" https://review.coreboot.org/c/coreboot/+/23586/8/payloads/cbui/NuklearUI/Nu… PS8, Line 126: NuklearTabView_set_focus(this, +1); need consistent spacing around '+' (ctx:WxV) https://review.coreboot.org/c/coreboot/+/23586/8/payloads/cbui/NuklearUI/Nu… PS8, Line 220: struct nk_context *ctx, struct nuklear_vector* modules) "foo* bar" should be "foo *bar" https://review.coreboot.org/c/coreboot/+/23586/8/payloads/cbui/NuklearUI/Nu… PS8, Line 324: struct nuklear_tabview_map* map = "foo* bar" should be "foo *bar" https://review.coreboot.org/c/coreboot/+/23586/8/payloads/cbui/NuklearUI/Nu… PS8, Line 355: for (size_t i = 1; i < NKUI_KEY_LAST; i<<=1) { spaces required around that '<<=' (ctx:VxV) https://review.coreboot.org/c/coreboot/+/23586/8/payloads/cbui/NuklearUI/Nu… File payloads/cbui/NuklearUI/NuklearTextView.h: https://review.coreboot.org/c/coreboot/+/23586/8/payloads/cbui/NuklearUI/Nu… PS8, Line 24: { open brace '{' following struct go on the same line https://review.coreboot.org/c/coreboot/+/23586/8/payloads/cbui/NuklearUI/Nu… File payloads/cbui/NuklearUI/NuklearTextView.c: https://review.coreboot.org/c/coreboot/+/23586/8/payloads/cbui/NuklearUI/Nu… PS8, Line 76: if (nk_input_is_key_pressed(i, NK_KEY_UP)) { braces {} are not necessary for any arm of this statement https://review.coreboot.org/c/coreboot/+/23586/8/payloads/cbui/NuklearUI/Nu… File payloads/cbui/NuklearUI/NuklearTextfield.h: https://review.coreboot.org/c/coreboot/+/23586/8/payloads/cbui/NuklearUI/Nu… PS8, Line 23: { open brace '{' following struct go on the same line https://review.coreboot.org/c/coreboot/+/23586/8/payloads/cbui/NuklearUI/Nu… File payloads/cbui/NuklearUI/NuklearTextfield.c: https://review.coreboot.org/c/coreboot/+/23586/8/payloads/cbui/NuklearUI/Nu… PS8, Line 121: void NuklearTextfield_dtor(void* obj) "foo* bar" should be "foo *bar" https://review.coreboot.org/c/coreboot/+/23586/8/payloads/cbui/NuklearUI/Nu… PS8, Line 165: struct nuklear_textfield* obj; "foo* bar" should be "foo *bar" https://review.coreboot.org/c/coreboot/+/23586/8/payloads/cbui/NuklearUI/Nu… File payloads/cbui/NuklearUI/NuklearTimePicker.h: https://review.coreboot.org/c/coreboot/+/23586/8/payloads/cbui/NuklearUI/Nu… PS8, Line 25: { open brace '{' following struct go on the same line https://review.coreboot.org/c/coreboot/+/23586/8/payloads/cbui/NuklearUI/Nu… File payloads/cbui/NuklearUI/NuklearTimePicker.c: https://review.coreboot.org/c/coreboot/+/23586/8/payloads/cbui/NuklearUI/Nu… PS8, Line 180: struct nuklear_timepicker* obj; "foo* bar" should be "foo *bar" https://review.coreboot.org/c/coreboot/+/23586/8/payloads/cbui/NuklearUI/Nu… File payloads/cbui/NuklearUI/NuklearUI.h: https://review.coreboot.org/c/coreboot/+/23586/8/payloads/cbui/NuklearUI/Nu… PS8, Line 76: struct nuklear_root* NuklearRoot_ctor(void); "foo* bar" should be "foo *bar" https://review.coreboot.org/c/coreboot/+/23586/8/payloads/cbui/NuklearUI/Nu… PS8, Line 298: struct nuklear_root* root; "foo* bar" should be "foo *bar" https://review.coreboot.org/c/coreboot/+/23586/8/payloads/cbui/NuklearUI/Nu… PS8, Line 319: struct nuklear_tabview* NuklearTabView_new(const struct nuklear_desc *desc); "foo* bar" should be "foo *bar" https://review.coreboot.org/c/coreboot/+/23586/8/payloads/cbui/NuklearUI/Nu… File payloads/cbui/NuklearUI/NuklearVector.h: https://review.coreboot.org/c/coreboot/+/23586/8/payloads/cbui/NuklearUI/Nu… PS8, Line 20: { open brace '{' following struct go on the same line https://review.coreboot.org/c/coreboot/+/23586/8/payloads/cbui/NuklearUI/Nu… PS8, Line 26: struct nuklear_vector* NuklearVector_ctor(void); "foo* bar" should be "foo *bar" https://review.coreboot.org/c/coreboot/+/23586/8/payloads/cbui/NuklearUI/Nu… PS8, Line 37: struct { struct nuklear_vector *vecptr; t *y; } it = \ need consistent spacing around '*' (ctx:WxV) https://review.coreboot.org/c/coreboot/+/23586/8/payloads/cbui/NuklearUI/Nu… File payloads/cbui/NuklearUI/NuklearVector.c: https://review.coreboot.org/c/coreboot/+/23586/8/payloads/cbui/NuklearUI/Nu… PS8, Line 59: for (;i > 0 && base; i--) space required after that ';' (ctx:BxV) https://review.coreboot.org/c/coreboot/+/23586/8/payloads/cbui/NuklearUI/Nu… PS8, Line 90: for (;i > 0 && base; i--) space required after that ';' (ctx:BxV) https://review.coreboot.org/c/coreboot/+/23586/8/payloads/cbui/arch/x86/int… File payloads/cbui/arch/x86/int32.h: https://review.coreboot.org/c/coreboot/+/23586/8/payloads/cbui/arch/x86/int… PS8, Line 21: unsigned short di, si, bp, sp, bx, dx, cx, ax; please, no spaces at the start of a line https://review.coreboot.org/c/coreboot/+/23586/8/payloads/cbui/arch/x86/int… PS8, Line 22: unsigned short gs, fs, es, ds, eflags; please, no spaces at the start of a line https://review.coreboot.org/c/coreboot/+/23586/8/payloads/cbui/arch/x86/int… File payloads/cbui/arch/x86/int32.nasm: https://review.coreboot.org/c/coreboot/+/23586/8/payloads/cbui/arch/x86/int… PS8, Line 38: struc regs16_t 'struc' may be misspelled - perhaps 'struct'? https://review.coreboot.org/c/coreboot/+/23586/8/payloads/cbui/arch/x86/int… PS8, Line 80: mov [REBASE(ib)], al ; set intrrupt immediate byte from our arguments 'intrrupt' may be misspelled - perhaps 'interrupt'? https://review.coreboot.org/c/coreboot/+/23586/8/payloads/cbui/cbui.h File payloads/cbui/cbui.h: https://review.coreboot.org/c/coreboot/+/23586/8/payloads/cbui/cbui.h@35 PS8, Line 35: } while(0) space required before the open parenthesis '(' https://review.coreboot.org/c/coreboot/+/23586/8/payloads/cbui/cbui.h@37 PS8, Line 37: #define NK_ASSERT(x) do {} while(0) space required before the open parenthesis '(' https://review.coreboot.org/c/coreboot/+/23586/8/payloads/cbui/cbui.h@41 PS8, Line 41: #define assert(x) do {} while(0); space required before the open parenthesis '(' https://review.coreboot.org/c/coreboot/+/23586/8/payloads/cbui/cbui.h@41 PS8, Line 41: #define assert(x) do {} while(0); do {} while (0) macros should not be semicolon terminated https://review.coreboot.org/c/coreboot/+/23586/8/payloads/cbui/cbui.h@46 PS8, Line 46: extern void usb_poll (void); space prohibited between function name and open parenthesis '(' https://review.coreboot.org/c/coreboot/+/23586/8/payloads/cbui/cbui.c File payloads/cbui/cbui.c: https://review.coreboot.org/c/coreboot/+/23586/8/payloads/cbui/cbui.c@63 PS8, Line 63: switch(rawfb->font_tex.format) { space required before the open parenthesis '(' https://review.coreboot.org/c/coreboot/+/23586/8/payloads/cbui/cbui.c@163 PS8, Line 163: switch(key) { space required before the open parenthesis '(' https://review.coreboot.org/c/coreboot/+/23586/8/payloads/cbui/cbui.c@318 PS8, Line 318: struct nuklear_tabview* nktv; "foo* bar" should be "foo *bar" https://review.coreboot.org/c/coreboot/+/23586/8/payloads/cbui/cbui.c@325 PS8, Line 325: lang_set_country(CONFIG_LANG_PREFERED); 'PREFERED' may be misspelled - perhaps 'PREFERRED'? https://review.coreboot.org/c/coreboot/+/23586/8/payloads/cbui/gfx/splash.c File payloads/cbui/gfx/splash.c: https://review.coreboot.org/c/coreboot/+/23586/8/payloads/cbui/gfx/splash.c… PS8, Line 22: unsigned width; Prefer 'unsigned int' to bare use of 'unsigned' https://review.coreboot.org/c/coreboot/+/23586/8/payloads/cbui/gfx/splash.c… PS8, Line 23: unsigned heigth; 'heigth' may be misspelled - perhaps 'height'? https://review.coreboot.org/c/coreboot/+/23586/8/payloads/cbui/gfx/splash.c… PS8, Line 23: unsigned heigth; Prefer 'unsigned int' to bare use of 'unsigned' https://review.coreboot.org/c/coreboot/+/23586/8/payloads/cbui/gfx/splash.c… PS8, Line 24: unsigned first_pixel_c; Prefer 'unsigned int' to bare use of 'unsigned' https://review.coreboot.org/c/coreboot/+/23586/8/payloads/cbui/gfx/splash.c… PS8, Line 37: .heigth = 370, 'heigth' may be misspelled - perhaps 'height'? https://review.coreboot.org/c/coreboot/+/23586/8/payloads/cbui/gfx/splash.c… PS8, Line 40: 0x83, 0xa6, 0x03, 0x81, 0x8e, 0x06, 0x81, 0x8b, 0x08, 0x81, 0x89, 0x0a, 0x81, 0x88, 0x0b, 0x81, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/8/payloads/cbui/gfx/splash.c… PS8, Line 41: 0x86, 0x0d, 0x81, 0x84, 0x0f, 0x81, 0x82, 0x11, 0x81, 0x80, 0x12, 0x81, 0x80, 0x13, 0x81, 0x7e, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/8/payloads/cbui/gfx/splash.c… PS8, Line 42: 0x14, 0x81, 0x7d, 0x15, 0x81, 0x7c, 0x17, 0x81, 0x7b, 0x17, 0x81, 0x7a, 0x18, 0x81, 0x79, 0x19, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/8/payloads/cbui/gfx/splash.c… PS8, Line 43: 0x81, 0x78, 0x1a, 0x81, 0x78, 0x1a, 0x81, 0x77, 0x1b, 0x81, 0x76, 0x1c, 0x81, 0x75, 0x1d, 0x81, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/8/payloads/cbui/gfx/splash.c… PS8, Line 44: 0x46, 0x0c, 0x21, 0x1d, 0x81, 0x40, 0x19, 0x19, 0x1e, 0x81, 0x3d, 0x20, 0x14, 0x1f, 0x81, 0x3b, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/8/payloads/cbui/gfx/splash.c… PS8, Line 45: 0x24, 0x11, 0x1f, 0x81, 0x3a, 0x29, 0x0e, 0x1f, 0x81, 0x38, 0x2c, 0x0c, 0x20, 0x81, 0x36, 0x30, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/8/payloads/cbui/gfx/splash.c… PS8, Line 46: 0x09, 0x21, 0x81, 0x35, 0x32, 0x07, 0x21, 0x81, 0x35, 0x34, 0x06, 0x21, 0x81, 0x34, 0x36, 0x04, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/8/payloads/cbui/gfx/splash.c… PS8, Line 47: 0x22, 0x81, 0x32, 0x39, 0x01, 0x23, 0x81, 0x32, 0x60, 0x81, 0x31, 0x61, 0x81, 0x30, 0x61, 0x81, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/8/payloads/cbui/gfx/splash.c… PS8, Line 48: 0x30, 0x62, 0x81, 0x2f, 0x62, 0x81, 0x2f, 0x63, 0x81, 0x2e, 0x63, 0x81, 0x2e, 0x64, 0x81, 0x2d, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/8/payloads/cbui/gfx/splash.c… PS8, Line 49: 0x65, 0x81, 0x2c, 0x65, 0x81, 0x2c, 0x66, 0x81, 0x2b, 0x66, 0x81, 0x2b, 0x67, 0x81, 0x2a, 0x67, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/8/payloads/cbui/gfx/splash.c… PS8, Line 50: 0x81, 0x2a, 0x67, 0x81, 0x2a, 0x68, 0x81, 0x29, 0x68, 0x81, 0x29, 0x69, 0x81, 0x29, 0x68, 0x81, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/8/payloads/cbui/gfx/splash.c… PS8, Line 51: 0x29, 0x69, 0x81, 0x28, 0x69, 0x81, 0x28, 0x69, 0x81, 0x29, 0x69, 0x81, 0x28, 0x69, 0x81, 0x28, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/8/payloads/cbui/gfx/splash.c… PS8, Line 52: 0x6a, 0x81, 0x27, 0x6a, 0x81, 0x28, 0x69, 0x81, 0x28, 0x6a, 0x81, 0x28, 0x69, 0x81, 0x28, 0x69, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/8/payloads/cbui/gfx/splash.c… PS8, Line 53: 0x81, 0x28, 0x6a, 0x81, 0x28, 0x69, 0x81, 0x28, 0x69, 0x81, 0x29, 0x69, 0x81, 0x28, 0x69, 0x81, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/8/payloads/cbui/gfx/splash.c… PS8, Line 54: 0x29, 0x68, 0x81, 0x2a, 0x68, 0x81, 0x29, 0x68, 0x81, 0x2a, 0x67, 0x81, 0x2b, 0x66, 0x81, 0x2b, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/8/payloads/cbui/gfx/splash.c… PS8, Line 55: 0x67, 0x81, 0x2b, 0x66, 0x81, 0x2c, 0x65, 0x81, 0x2d, 0x65, 0x81, 0x2c, 0x65, 0x81, 0x2d, 0x64, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/8/payloads/cbui/gfx/splash.c… PS8, Line 56: 0x81, 0x2e, 0x63, 0x81, 0x2f, 0x63, 0x81, 0x2f, 0x62, 0x81, 0x30, 0x61, 0x81, 0x30, 0x62, 0x81, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/8/payloads/cbui/gfx/splash.c… PS8, Line 57: 0x30, 0x61, 0x81, 0x31, 0x60, 0x81, 0x32, 0x5f, 0x81, 0x06, 0x0d, 0x1e, 0x5f, 0x80, 0xfa, 0x1f, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/8/payloads/cbui/gfx/splash.c… PS8, Line 58: 0x18, 0x5e, 0x80, 0xf3, 0x29, 0x16, 0x5d, 0x80, 0xed, 0x31, 0x15, 0x5c, 0x80, 0xe8, 0x38, 0x14, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/8/payloads/cbui/gfx/splash.c… PS8, Line 59: 0x5c, 0x80, 0xe2, 0x3e, 0x14, 0x5b, 0x80, 0xde, 0x43, 0x14, 0x5a, 0x80, 0xdb, 0x47, 0x13, 0x5b, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/8/payloads/cbui/gfx/splash.c… PS8, Line 60: 0x80, 0xd7, 0x4a, 0x14, 0x5a, 0x80, 0xd3, 0x4f, 0x14, 0x5a, 0x80, 0xcf, 0x53, 0x14, 0x59, 0x80, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/8/payloads/cbui/gfx/splash.c… PS8, Line 61: 0xcc, 0x56, 0x15, 0x59, 0x80, 0xc9, 0x58, 0x16, 0x59, 0x80, 0xc5, 0x5c, 0x16, 0x58, 0x80, 0xc2, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/8/payloads/cbui/gfx/splash.c… PS8, Line 62: 0x5f, 0x18, 0x57, 0x80, 0xbf, 0x61, 0x19, 0x57, 0x80, 0xbb, 0x64, 0x1a, 0x58, 0x80, 0xb7, 0x66, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/8/payloads/cbui/gfx/splash.c… PS8, Line 63: 0x1b, 0x58, 0x80, 0xb3, 0x6a, 0x1b, 0x58, 0x80, 0xb0, 0x6c, 0x1c, 0x59, 0x80, 0xab, 0x6f, 0x1d, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/8/payloads/cbui/gfx/splash.c… PS8, Line 64: 0x5a, 0x80, 0xa7, 0x71, 0x1e, 0x5a, 0x80, 0xa4, 0x73, 0x1f, 0x5b, 0x80, 0x9f, 0x76, 0x20, 0x5c, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/8/payloads/cbui/gfx/splash.c… PS8, Line 65: 0x80, 0x9b, 0x78, 0x21, 0x5d, 0x80, 0x97, 0x7a, 0x22, 0x5d, 0x80, 0x94, 0x4e, 0x11, 0x1b, 0x24, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/8/payloads/cbui/gfx/splash.c… PS8, Line 66: 0x5d, 0x80, 0x8f, 0x48, 0x1f, 0x16, 0x25, 0x5d, 0x80, 0x8c, 0x44, 0x28, 0x13, 0x26, 0x5d, 0x80, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/8/payloads/cbui/gfx/splash.c… PS8, Line 67: 0x89, 0x41, 0x2f, 0x11, 0x27, 0x5d, 0x80, 0x86, 0x3e, 0x35, 0x10, 0x28, 0x5d, 0x80, 0x83, 0x3c, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/8/payloads/cbui/gfx/splash.c… PS8, Line 68: 0x3b, 0x0e, 0x29, 0x5d, 0x80, 0x80, 0x3a, 0x3f, 0x0d, 0x2b, 0x5d, 0x50, 0x00, 0x2b, 0x38, 0x44, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/8/payloads/cbui/gfx/splash.c… PS8, Line 69: 0x0c, 0x2d, 0x5c, 0x4d, 0x02, 0x29, 0x36, 0x48, 0x0c, 0x2e, 0x5c, 0x4b, 0x03, 0x27, 0x35, 0x4c, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/8/payloads/cbui/gfx/splash.c… PS8, Line 70: 0x0b, 0x2f, 0x5b, 0x49, 0x04, 0x26, 0x33, 0x1c, 0x0d, 0x25, 0x0b, 0x30, 0x5b, 0x46, 0x06, 0x24, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/8/payloads/cbui/gfx/splash.c… PS8, Line 71: 0x32, 0x18, 0x18, 0x21, 0x0b, 0x31, 0x5b, 0x44, 0x06, 0x23, 0x31, 0x16, 0x1e, 0x20, 0x0b, 0x33, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/8/payloads/cbui/gfx/splash.c… PS8, Line 72: 0x59, 0x42, 0x08, 0x21, 0x30, 0x14, 0x24, 0x1e, 0x0c, 0x34, 0x59, 0x40, 0x08, 0x20, 0x2f, 0x13, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/8/payloads/cbui/gfx/splash.c… PS8, Line 73: 0x29, 0x1d, 0x0c, 0x35, 0x58, 0x3e, 0x0a, 0x1e, 0x2e, 0x12, 0x2d, 0x1d, 0x0c, 0x36, 0x58, 0x3b, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/8/payloads/cbui/gfx/splash.c… PS8, Line 74: 0x0b, 0x1d, 0x2d, 0x11, 0x31, 0x1c, 0x0d, 0x37, 0x57, 0x3a, 0x0c, 0x1b, 0x2d, 0x10, 0x34, 0x1c, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/8/payloads/cbui/gfx/splash.c… PS8, Line 75: 0x0c, 0x38, 0x58, 0x37, 0x0d, 0x1a, 0x2c, 0x0f, 0x38, 0x1b, 0x0d, 0x39, 0x57, 0x36, 0x0d, 0x19, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/8/payloads/cbui/gfx/splash.c… PS8, Line 76: 0x2b, 0x0f, 0x3a, 0x1b, 0x0e, 0x39, 0x57, 0x34, 0x0f, 0x17, 0x2b, 0x0e, 0x3d, 0x1b, 0x0e, 0x3a, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/8/payloads/cbui/gfx/splash.c… PS8, Line 77: 0x57, 0x31, 0x10, 0x16, 0x2a, 0x0e, 0x40, 0x1a, 0x0f, 0x3a, 0x57, 0x30, 0x10, 0x15, 0x2a, 0x0c, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/8/payloads/cbui/gfx/splash.c… PS8, Line 78: 0x43, 0x1a, 0x10, 0x3a, 0x57, 0x2e, 0x11, 0x14, 0x29, 0x0c, 0x45, 0x1a, 0x11, 0x3b, 0x57, 0x2c, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/8/payloads/cbui/gfx/splash.c… PS8, Line 79: 0x11, 0x13, 0x29, 0x0b, 0x48, 0x19, 0x12, 0x3b, 0x57, 0x2a, 0x13, 0x12, 0x28, 0x0a, 0x4a, 0x19, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/8/payloads/cbui/gfx/splash.c… PS8, Line 80: 0x12, 0x3c, 0x57, 0x29, 0x13, 0x11, 0x27, 0x0b, 0x4b, 0x19, 0x13, 0x3c, 0x57, 0x27, 0x14, 0x10, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/8/payloads/cbui/gfx/splash.c… PS8, Line 81: 0x27, 0x0a, 0x4d, 0x19, 0x14, 0x3c, 0x57, 0x26, 0x14, 0x0f, 0x27, 0x09, 0x50, 0x18, 0x15, 0x3b, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/8/payloads/cbui/gfx/splash.c… PS8, Line 82: 0x58, 0x25, 0x14, 0x0f, 0x25, 0x09, 0x52, 0x18, 0x16, 0x3b, 0x58, 0x23, 0x15, 0x0e, 0x25, 0x08, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/8/payloads/cbui/gfx/splash.c… PS8, Line 83: 0x54, 0x17, 0x18, 0x3b, 0x58, 0x22, 0x15, 0x0d, 0x25, 0x08, 0x55, 0x17, 0x19, 0x3a, 0x59, 0x20, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/8/payloads/cbui/gfx/splash.c… PS8, Line 84: 0x16, 0x0c, 0x25, 0x07, 0x57, 0x17, 0x1a, 0x3a, 0x59, 0x1f, 0x16, 0x0c, 0x24, 0x06, 0x59, 0x17, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/8/payloads/cbui/gfx/splash.c… PS8, Line 85: 0x1a, 0x3a, 0x5a, 0x1d, 0x17, 0x0b, 0x24, 0x06, 0x5a, 0x16, 0x1c, 0x39, 0x5b, 0x1c, 0x17, 0x0a, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/8/payloads/cbui/gfx/splash.c… PS8, Line 86: 0x25, 0x04, 0x5c, 0x16, 0x1d, 0x39, 0x5b, 0x1b, 0x17, 0x0a, 0x26, 0x00, 0x5f, 0x16, 0x1e, 0x38, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/8/payloads/cbui/gfx/splash.c… PS8, Line 87: 0x5c, 0x19, 0x18, 0x09, 0x80, 0x88, 0x15, 0x20, 0x37, 0x5d, 0x18, 0x18, 0x09, 0x80, 0x87, 0x16, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/8/payloads/cbui/gfx/splash.c… PS8, Line 88: 0x21, 0x36, 0x5e, 0x16, 0x19, 0x08, 0x80, 0x88, 0x15, 0x23, 0x35, 0x5f, 0x15, 0x19, 0x07, 0x80, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/8/payloads/cbui/gfx/splash.c… PS8, Line 89: 0x89, 0x15, 0x24, 0x34, 0x60, 0x14, 0x19, 0x07, 0x80, 0x89, 0x15, 0x25, 0x33, 0x61, 0x12, 0x1a, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/8/payloads/cbui/gfx/splash.c… PS8, Line 90: 0x06, 0x80, 0x8a, 0x14, 0x27, 0x31, 0x62, 0x12, 0x19, 0x07, 0x80, 0x8a, 0x14, 0x28, 0x30, 0x63, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/8/payloads/cbui/gfx/splash.c… PS8, Line 91: 0x11, 0x19, 0x06, 0x80, 0x8a, 0x14, 0x2a, 0x2f, 0x64, 0x10, 0x19, 0x06, 0x80, 0x8a, 0x14, 0x2b, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/8/payloads/cbui/gfx/splash.c… PS8, Line 92: 0x2d, 0x66, 0x0e, 0x1a, 0x05, 0x80, 0x8b, 0x13, 0x2d, 0x2b, 0x68, 0x0d, 0x1a, 0x05, 0x80, 0x8b, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/8/payloads/cbui/gfx/splash.c… PS8, Line 93: 0x13, 0x2f, 0x29, 0x68, 0x0d, 0x1a, 0x04, 0x80, 0x8b, 0x13, 0x31, 0x27, 0x6a, 0x0c, 0x19, 0x05, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/8/payloads/cbui/gfx/splash.c… PS8, Line 94: 0x80, 0x8b, 0x13, 0x32, 0x25, 0x6c, 0x0a, 0x1a, 0x04, 0x80, 0x8c, 0x12, 0x17, 0x06, 0x16, 0x22, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/8/payloads/cbui/gfx/splash.c… PS8, Line 95: 0x6d, 0x0a, 0x1a, 0x04, 0x80, 0x8b, 0x13, 0x15, 0x0b, 0x15, 0x1f, 0x6f, 0x09, 0x1a, 0x04, 0x80, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/8/payloads/cbui/gfx/splash.c… PS8, Line 96: 0x8b, 0x12, 0x14, 0x0f, 0x15, 0x1b, 0x72, 0x08, 0x1a, 0x03, 0x80, 0x8c, 0x12, 0x12, 0x13, 0x15, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/8/payloads/cbui/gfx/splash.c… PS8, Line 97: 0x17, 0x74, 0x08, 0x1a, 0x03, 0x80, 0x8b, 0x12, 0x11, 0x16, 0x18, 0x10, 0x78, 0x06, 0x1a, 0x04, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/8/payloads/cbui/gfx/splash.c… PS8, Line 98: 0x80, 0x8b, 0x12, 0x10, 0x19, 0x1b, 0x07, 0x7d, 0x05, 0x1a, 0x03, 0x80, 0x8b, 0x12, 0x10, 0x1b, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/8/payloads/cbui/gfx/splash.c… PS8, Line 99: 0x80, 0xa0, 0x05, 0x1a, 0x03, 0x80, 0x8b, 0x12, 0x0e, 0x1e, 0x80, 0xa0, 0x04, 0x1a, 0x03, 0x80, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/8/payloads/cbui/gfx/splash.c… PS8, Line 100: 0x8b, 0x11, 0x0e, 0x20, 0x80, 0x9f, 0x04, 0x1a, 0x02, 0x80, 0x8b, 0x11, 0x0e, 0x22, 0x80, 0x9d, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/8/payloads/cbui/gfx/splash.c… PS8, Line 101: 0x05, 0x1a, 0x02, 0x80, 0x8b, 0x11, 0x0d, 0x24, 0x80, 0x9b, 0x06, 0x1a, 0x02, 0x80, 0x8a, 0x11, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/8/payloads/cbui/gfx/splash.c… PS8, Line 102: 0x0c, 0x26, 0x80, 0x9b, 0x05, 0x1b, 0x02, 0x80, 0x8a, 0x11, 0x0b, 0x28, 0x80, 0x99, 0x06, 0x1b, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/8/payloads/cbui/gfx/splash.c… PS8, Line 103: 0x02, 0x80, 0x8a, 0x10, 0x0b, 0x2a, 0x80, 0x97, 0x07, 0x1b, 0x01, 0x80, 0x8a, 0x10, 0x0b, 0x2c, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/8/payloads/cbui/gfx/splash.c… PS8, Line 104: 0x80, 0x95, 0x08, 0x1b, 0x01, 0x80, 0x8a, 0x10, 0x0a, 0x2d, 0x80, 0x95, 0x08, 0x1c, 0x00, 0x80, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/8/payloads/cbui/gfx/splash.c… PS8, Line 105: 0x89, 0x10, 0x0a, 0x2f, 0x80, 0x93, 0x09, 0x1c, 0x00, 0x80, 0x89, 0x10, 0x09, 0x12, 0x06, 0x16, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/8/payloads/cbui/gfx/splash.c… PS8, Line 106: 0x80, 0x91, 0x0b, 0x1c, 0x00, 0x80, 0x88, 0x10, 0x09, 0x10, 0x0b, 0x15, 0x80, 0x8f, 0x0c, 0x80, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/8/payloads/cbui/gfx/splash.c… PS8, Line 107: 0xa6, 0x0f, 0x09, 0x0f, 0x0f, 0x13, 0x80, 0x8e, 0x0d, 0x80, 0xa6, 0x0f, 0x08, 0x0f, 0x11, 0x13, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/8/payloads/cbui/gfx/splash.c… PS8, Line 108: 0x80, 0x8b, 0x0f, 0x80, 0xa5, 0x0f, 0x08, 0x0e, 0x14, 0x12, 0x7b, 0x02, 0x0a, 0x11, 0x80, 0xa5, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/8/payloads/cbui/gfx/splash.c… PS8, Line 109: 0x0e, 0x08, 0x0e, 0x16, 0x12, 0x78, 0x21, 0x80, 0xa4, 0x0f, 0x07, 0x0e, 0x18, 0x11, 0x76, 0x23, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/8/payloads/cbui/gfx/splash.c… PS8, Line 110: 0x80, 0xa4, 0x0e, 0x07, 0x0e, 0x1a, 0x11, 0x71, 0x27, 0x80, 0xa4, 0x0d, 0x07, 0x0e, 0x1c, 0x10, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/8/payloads/cbui/gfx/splash.c… PS8, Line 111: 0x6d, 0x2b, 0x80, 0xa3, 0x0e, 0x06, 0x0e, 0x1d, 0x10, 0x68, 0x30, 0x80, 0xa3, 0x0d, 0x06, 0x0e, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/8/payloads/cbui/gfx/splash.c… PS8, Line 112: 0x1f, 0x10, 0x5e, 0x39, 0x80, 0xa2, 0x0d, 0x06, 0x0e, 0x20, 0x10, 0x4d, 0x4a, 0x80, 0xa2, 0x0d, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/8/payloads/cbui/gfx/splash.c… PS8, Line 113: 0x05, 0x0e, 0x22, 0x0f, 0x44, 0x54, 0x80, 0xa1, 0x0c, 0x05, 0x0d, 0x25, 0x0d, 0x43, 0x56, 0x80, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/8/payloads/cbui/gfx/splash.c… PS8, Line 114: 0xa0, 0x0c, 0x05, 0x0d, 0x26, 0x0c, 0x43, 0x57, 0x80, 0xa0, 0x0c, 0x04, 0x0d, 0x26, 0x0c, 0x42, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/8/payloads/cbui/gfx/splash.c… PS8, Line 115: 0x59, 0x80, 0x9f, 0x0c, 0x05, 0x0c, 0x26, 0x0c, 0x42, 0x5a, 0x80, 0x9f, 0x0b, 0x05, 0x0c, 0x26, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/8/payloads/cbui/gfx/splash.c… PS8, Line 116: 0x0c, 0x42, 0x5b, 0x80, 0x9f, 0x0b, 0x04, 0x0c, 0x26, 0x0c, 0x42, 0x5d, 0x80, 0x9d, 0x0b, 0x04, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/8/payloads/cbui/gfx/splash.c… PS8, Line 117: 0x0c, 0x26, 0x0b, 0x44, 0x5d, 0x80, 0x9d, 0x0a, 0x04, 0x0c, 0x26, 0x0b, 0x44, 0x5e, 0x80, 0x9c, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/8/payloads/cbui/gfx/splash.c… PS8, Line 118: 0x0b, 0x03, 0x0c, 0x26, 0x0b, 0x44, 0x5f, 0x80, 0x9c, 0x0a, 0x03, 0x0c, 0x26, 0x0b, 0x44, 0x60, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/8/payloads/cbui/gfx/splash.c… PS8, Line 119: 0x80, 0x9c, 0x09, 0x03, 0x0c, 0x26, 0x0b, 0x45, 0x61, 0x80, 0x9a, 0x09, 0x04, 0x0b, 0x26, 0x0b, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/8/payloads/cbui/gfx/splash.c… PS8, Line 120: 0x45, 0x62, 0x80, 0x9a, 0x09, 0x03, 0x0b, 0x26, 0x0b, 0x45, 0x63, 0x80, 0x99, 0x09, 0x03, 0x0b, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/8/payloads/cbui/gfx/splash.c… PS8, Line 121: 0x26, 0x0b, 0x46, 0x64, 0x80, 0x98, 0x08, 0x03, 0x0b, 0x26, 0x0b, 0x46, 0x65, 0x80, 0x98, 0x08, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/8/payloads/cbui/gfx/splash.c… PS8, Line 122: 0x02, 0x0b, 0x26, 0x0b, 0x47, 0x65, 0x80, 0x97, 0x08, 0x02, 0x0c, 0x25, 0x0a, 0x48, 0x67, 0x80, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/8/payloads/cbui/gfx/splash.c… PS8, Line 123: 0x96, 0x07, 0x03, 0x0b, 0x25, 0x0a, 0x48, 0x68, 0x80, 0x96, 0x07, 0x02, 0x0b, 0x25, 0x0a, 0x49, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/8/payloads/cbui/gfx/splash.c… PS8, Line 124: 0x33, 0x01, 0x32, 0x80, 0x95, 0x07, 0x02, 0x0b, 0x25, 0x0a, 0x49, 0x34, 0x07, 0x2d, 0x80, 0x94, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/8/payloads/cbui/gfx/splash.c… PS8, Line 125: 0x06, 0x02, 0x0b, 0x25, 0x0a, 0x49, 0x34, 0x0b, 0x2a, 0x80, 0x94, 0x06, 0x02, 0x0a, 0x25, 0x0a, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/8/payloads/cbui/gfx/splash.c… PS8, Line 126: 0x4a, 0x1b, 0x00, 0x17, 0x0f, 0x27, 0x80, 0x92, 0x06, 0x02, 0x0a, 0x25, 0x0a, 0x4a, 0x1b, 0x02, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/8/payloads/cbui/gfx/splash.c… PS8, Line 127: 0x16, 0x0f, 0x27, 0x80, 0x92, 0x13, 0x25, 0x0a, 0x4a, 0x19, 0x05, 0x15, 0x10, 0x28, 0x80, 0x91, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/8/payloads/cbui/gfx/splash.c… PS8, Line 128: 0x12, 0x25, 0x0a, 0x4b, 0x18, 0x07, 0x14, 0x10, 0x28, 0x80, 0x90, 0x12, 0x25, 0x0a, 0x4b, 0x17, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/8/payloads/cbui/gfx/splash.c… PS8, Line 129: 0x0a, 0x12, 0x11, 0x29, 0x80, 0x8f, 0x11, 0x25, 0x09, 0x4c, 0x17, 0x0b, 0x12, 0x11, 0x29, 0x80, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/8/payloads/cbui/gfx/splash.c… PS8, Line 130: 0x8f, 0x10, 0x25, 0x09, 0x4d, 0x15, 0x0e, 0x11, 0x11, 0x2a, 0x6d, 0x00, 0x1e, 0x10, 0x24, 0x0a, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/8/payloads/cbui/gfx/splash.c… PS8, Line 131: 0x4d, 0x15, 0x10, 0x0f, 0x12, 0x2b, 0x6b, 0x01, 0x1e, 0x0f, 0x24, 0x0a, 0x4d, 0x15, 0x12, 0x0e, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/8/payloads/cbui/gfx/splash.c… PS8, Line 132: 0x11, 0x2c, 0x6a, 0x01, 0x1f, 0x0e, 0x24, 0x0a, 0x4e, 0x15, 0x12, 0x0e, 0x11, 0x2d, 0x68, 0x02, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/8/payloads/cbui/gfx/splash.c… PS8, Line 133: 0x1f, 0x0d, 0x24, 0x0a, 0x4e, 0x16, 0x13, 0x04, 0x1a, 0x2d, 0x67, 0x02, 0x1f, 0x0d, 0x24, 0x0a, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/8/payloads/cbui/gfx/splash.c… PS8, Line 134: 0x4e, 0x17, 0x14, 0x00, 0x1d, 0x2e, 0x65, 0x03, 0x1f, 0x0c, 0x24, 0x0a, 0x4e, 0x19, 0x32, 0x2f, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/8/payloads/cbui/gfx/splash.c… PS8, Line 135: 0x63, 0x03, 0x20, 0x0b, 0x24, 0x0a, 0x4f, 0x1a, 0x30, 0x31, 0x60, 0x05, 0x20, 0x0a, 0x24, 0x09, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/8/payloads/cbui/gfx/splash.c… PS8, Line 136: 0x50, 0x1b, 0x31, 0x31, 0x5e, 0x06, 0x20, 0x09, 0x24, 0x09, 0x50, 0x1c, 0x32, 0x30, 0x5d, 0x06, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/8/payloads/cbui/gfx/splash.c… PS8, Line 137: 0x21, 0x07, 0x25, 0x09, 0x50, 0x1e, 0x32, 0x12, 0x00, 0x1c, 0x5b, 0x07, 0x22, 0x05, 0x25, 0x09, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/8/payloads/cbui/gfx/splash.c… PS8, Line 138: 0x51, 0x1e, 0x34, 0x0e, 0x03, 0x1c, 0x59, 0x07, 0x24, 0x01, 0x27, 0x09, 0x51, 0x20, 0x34, 0x0b, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/8/payloads/cbui/gfx/splash.c… PS8, Line 139: 0x05, 0x1d, 0x56, 0x09, 0x4d, 0x09, 0x51, 0x21, 0x36, 0x07, 0x08, 0x1d, 0x54, 0x0a, 0x4c, 0x09, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/8/payloads/cbui/gfx/splash.c… PS8, Line 140: 0x51, 0x23, 0x36, 0x04, 0x0b, 0x1d, 0x52, 0x0a, 0x4b, 0x0a, 0x51, 0x23, 0x38, 0x00, 0x0e, 0x1e, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/8/payloads/cbui/gfx/splash.c… PS8, Line 141: 0x4f, 0x0c, 0x4a, 0x0a, 0x52, 0x23, 0x49, 0x1f, 0x4c, 0x0c, 0x4a, 0x0a, 0x52, 0x23, 0x4a, 0x20, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/8/payloads/cbui/gfx/splash.c… PS8, Line 142: 0x49, 0x0e, 0x49, 0x09, 0x53, 0x23, 0x4c, 0x20, 0x47, 0x0f, 0x48, 0x09, 0x53, 0x23, 0x4e, 0x21, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/8/payloads/cbui/gfx/splash.c… PS8, Line 143: 0x43, 0x10, 0x48, 0x09, 0x53, 0x23, 0x4f, 0x22, 0x40, 0x12, 0x47, 0x09, 0x53, 0x24, 0x50, 0x23, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/8/payloads/cbui/gfx/splash.c… PS8, Line 144: 0x3c, 0x13, 0x47, 0x09, 0x54, 0x23, 0x51, 0x24, 0x39, 0x15, 0x46, 0x09, 0x54, 0x15, 0x06, 0x06, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/8/payloads/cbui/gfx/splash.c… PS8, Line 145: 0x53, 0x25, 0x35, 0x17, 0x45, 0x09, 0x54, 0x15, 0x0c, 0x01, 0x20, 0x01, 0x2f, 0x28, 0x31, 0x18, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/8/payloads/cbui/gfx/splash.c… PS8, Line 146: 0x44, 0x0a, 0x54, 0x16, 0x2a, 0x0c, 0x27, 0x2d, 0x2b, 0x1b, 0x43, 0x0a, 0x54, 0x17, 0x28, 0x10, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/8/payloads/cbui/gfx/splash.c… PS8, Line 147: 0x24, 0x30, 0x26, 0x1e, 0x42, 0x0a, 0x54, 0x17, 0x27, 0x06, 0x06, 0x06, 0x21, 0x35, 0x1f, 0x20, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/8/payloads/cbui/gfx/splash.c… PS8, Line 148: 0x42, 0x09, 0x55, 0x18, 0x25, 0x05, 0x0b, 0x05, 0x1e, 0x3b, 0x16, 0x25, 0x41, 0x09, 0x55, 0x19, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/8/payloads/cbui/gfx/splash.c… PS8, Line 149: 0x24, 0x04, 0x10, 0x03, 0x1c, 0x44, 0x05, 0x2e, 0x40, 0x09, 0x55, 0x19, 0x24, 0x03, 0x13, 0x03, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/8/payloads/cbui/gfx/splash.c… PS8, Line 150: 0x1a, 0x79, 0x40, 0x09, 0x56, 0x19, 0x23, 0x03, 0x08, 0x03, 0x08, 0x03, 0x17, 0x7b, 0x3f, 0x09, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/8/payloads/cbui/gfx/splash.c… PS8, Line 151: 0x56, 0x1a, 0x22, 0x03, 0x06, 0x09, 0x06, 0x03, 0x16, 0x7a, 0x3e, 0x0a, 0x56, 0x1b, 0x22, 0x02, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/8/payloads/cbui/gfx/splash.c… PS8, Line 152: 0x05, 0x0d, 0x05, 0x03, 0x15, 0x7a, 0x3d, 0x0a, 0x56, 0x1c, 0x21, 0x02, 0x05, 0x0f, 0x05, 0x02, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/8/payloads/cbui/gfx/splash.c… PS8, Line 153: 0x15, 0x7a, 0x3c, 0x0e, 0x52, 0x1d, 0x21, 0x02, 0x04, 0x11, 0x05, 0x02, 0x15, 0x78, 0x3c, 0x14, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/8/payloads/cbui/gfx/splash.c… PS8, Line 154: 0x4c, 0x1d, 0x21, 0x02, 0x04, 0x13, 0x04, 0x02, 0x15, 0x78, 0x3b, 0x1a, 0x46, 0x1e, 0x21, 0x02, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/8/payloads/cbui/gfx/splash.c… PS8, Line 155: 0x04, 0x14, 0x04, 0x02, 0x14, 0x78, 0x3a, 0x23, 0x3d, 0x21, 0x1f, 0x01, 0x04, 0x15, 0x04, 0x02, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/8/payloads/cbui/gfx/splash.c… PS8, Line 156: 0x14, 0x77, 0x3a, 0x3b, 0x25, 0x25, 0x1c, 0x01, 0x03, 0x17, 0x03, 0x02, 0x14, 0x77, 0x38, 0x3b, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/8/payloads/cbui/gfx/splash.c… PS8, Line 157: 0x26, 0x28, 0x19, 0x02, 0x03, 0x17, 0x04, 0x01, 0x14, 0x77, 0x37, 0x3b, 0x26, 0x2c, 0x16, 0x02, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/8/payloads/cbui/gfx/splash.c… PS8, Line 158: 0x03, 0x17, 0x04, 0x02, 0x13, 0x76, 0x37, 0x3a, 0x27, 0x30, 0x13, 0x02, 0x03, 0x18, 0x03, 0x02, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/8/payloads/cbui/gfx/splash.c… PS8, Line 159: 0x13, 0x76, 0x36, 0x3a, 0x27, 0x31, 0x13, 0x02, 0x03, 0x18, 0x03, 0x02, 0x13, 0x76, 0x35, 0x39, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/8/payloads/cbui/gfx/splash.c… PS8, Line 160: 0x28, 0x32, 0x13, 0x02, 0x03, 0x18, 0x03, 0x02, 0x13, 0x76, 0x33, 0x39, 0x28, 0x34, 0x13, 0x02, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/8/payloads/cbui/gfx/splash.c… PS8, Line 161: 0x03, 0x18, 0x03, 0x02, 0x16, 0x72, 0x33, 0x39, 0x28, 0x35, 0x13, 0x02, 0x03, 0x17, 0x04, 0x01, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/8/payloads/cbui/gfx/splash.c… PS8, Line 162: 0x19, 0x70, 0x32, 0x38, 0x29, 0x36, 0x13, 0x02, 0x03, 0x17, 0x03, 0x02, 0x1c, 0x6d, 0x31, 0x37, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/8/payloads/cbui/gfx/splash.c… PS8, Line 163: 0x2a, 0x37, 0x14, 0x01, 0x04, 0x16, 0x03, 0x02, 0x1e, 0x6a, 0x30, 0x37, 0x2b, 0x38, 0x14, 0x02, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/8/payloads/cbui/gfx/splash.c… PS8, Line 164: 0x03, 0x15, 0x04, 0x02, 0x21, 0x67, 0x2f, 0x36, 0x2c, 0x3a, 0x13, 0x02, 0x04, 0x14, 0x03, 0x03, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/8/payloads/cbui/gfx/splash.c… PS8, Line 165: 0x21, 0x67, 0x2e, 0x35, 0x2d, 0x3b, 0x14, 0x02, 0x04, 0x12, 0x04, 0x02, 0x22, 0x67, 0x2d, 0x34, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/8/payloads/cbui/gfx/splash.c… PS8, Line 166: 0x2e, 0x3c, 0x14, 0x02, 0x04, 0x11, 0x04, 0x03, 0x21, 0x67, 0x2c, 0x33, 0x2f, 0x3e, 0x15, 0x02, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/8/payloads/cbui/gfx/splash.c… PS8, Line 167: 0x05, 0x0e, 0x05, 0x02, 0x22, 0x67, 0x2b, 0x32, 0x30, 0x40, 0x14, 0x03, 0x05, 0x0b, 0x06, 0x03, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/8/payloads/cbui/gfx/splash.c… PS8, Line 168: 0x22, 0x67, 0x2a, 0x30, 0x32, 0x40, 0x16, 0x02, 0x07, 0x07, 0x07, 0x03, 0x23, 0x67, 0x28, 0x2f, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/8/payloads/cbui/gfx/splash.c… PS8, Line 169: 0x34, 0x3f, 0x19, 0x03, 0x14, 0x03, 0x24, 0x67, 0x27, 0x2d, 0x35, 0x40, 0x1b, 0x03, 0x12, 0x03, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/8/payloads/cbui/gfx/splash.c… PS8, Line 170: 0x25, 0x67, 0x29, 0x28, 0x37, 0x40, 0x1d, 0x04, 0x0e, 0x04, 0x26, 0x66, 0x2d, 0x21, 0x3a, 0x3f, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/8/payloads/cbui/gfx/splash.c… PS8, Line 171: 0x20, 0x05, 0x0a, 0x05, 0x26, 0x67, 0x31, 0x18, 0x3e, 0x3f, 0x23, 0x12, 0x28, 0x67, 0x39, 0x07, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/8/payloads/cbui/gfx/splash.c… PS8, Line 172: 0x45, 0x40, 0x25, 0x0f, 0x29, 0x68, 0x80, 0x86, 0x3f, 0x2b, 0x08, 0x2c, 0x68, 0x80, 0x85, 0x3f, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/8/payloads/cbui/gfx/splash.c… PS8, Line 173: 0x53, 0x05, 0x08, 0x68, 0x80, 0x83, 0x42, 0x51, 0x0d, 0x00, 0x69, 0x80, 0x82, 0x43, 0x51, 0x78, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/8/payloads/cbui/gfx/splash.c… PS8, Line 174: 0x80, 0x80, 0x46, 0x4f, 0x78, 0x80, 0x80, 0x3d, 0x04, 0x04, 0x4e, 0x77, 0x80, 0x80, 0x3b, 0x0c, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/8/payloads/cbui/gfx/splash.c… PS8, Line 175: 0x01, 0x4d, 0x75, 0x80, 0x81, 0x3c, 0x0c, 0x02, 0x4b, 0x75, 0x80, 0x80, 0x3e, 0x0c, 0x02, 0x4a, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/8/payloads/cbui/gfx/splash.c… PS8, Line 176: 0x75, 0x80, 0x80, 0x3f, 0x0c, 0x03, 0x0e, 0x00, 0x38, 0x75, 0x7f, 0x41, 0x0c, 0x03, 0x0b, 0x04, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/8/payloads/cbui/gfx/splash.c… PS8, Line 177: 0x36, 0x76, 0x7e, 0x42, 0x0c, 0x04, 0x09, 0x06, 0x35, 0x75, 0x7d, 0x44, 0x0c, 0x05, 0x05, 0x0b, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/8/payloads/cbui/gfx/splash.c… PS8, Line 178: 0x34, 0x74, 0x7b, 0x46, 0x0c, 0x06, 0x02, 0x06, 0x00, 0x06, 0x33, 0x74, 0x7a, 0x34, 0x01, 0x10, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/8/payloads/cbui/gfx/splash.c… PS8, Line 179: 0x0d, 0x0e, 0x03, 0x05, 0x33, 0x73, 0x78, 0x35, 0x04, 0x0e, 0x0d, 0x0d, 0x04, 0x07, 0x31, 0x73, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/8/payloads/cbui/gfx/splash.c… PS8, Line 180: 0x76, 0x36, 0x06, 0x0c, 0x0f, 0x0a, 0x08, 0x06, 0x31, 0x72, 0x74, 0x37, 0x08, 0x08, 0x15, 0x06, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/8/payloads/cbui/gfx/splash.c… PS8, Line 181: 0x0a, 0x05, 0x31, 0x72, 0x73, 0x37, 0x0a, 0x04, 0x1a, 0x03, 0x0c, 0x04, 0x32, 0x72, 0x70, 0x38, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/8/payloads/cbui/gfx/splash.c… PS8, Line 182: 0x0d, 0x01, 0x1d, 0x00, 0x0d, 0x04, 0x32, 0x72, 0x6e, 0x39, 0x3e, 0x03, 0x1a, 0x04, 0x13, 0x72, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/8/payloads/cbui/gfx/splash.c… PS8, Line 183: 0x6b, 0x3a, 0x40, 0x01, 0x12, 0x0d, 0x13, 0x73, 0x68, 0x3c, 0x40, 0x01, 0x12, 0x0e, 0x12, 0x73, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/8/payloads/cbui/gfx/splash.c… PS8, Line 184: 0x66, 0x3f, 0x3e, 0x02, 0x11, 0x10, 0x11, 0x74, 0x62, 0x42, 0x3d, 0x03, 0x11, 0x10, 0x10, 0x76, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/8/payloads/cbui/gfx/splash.c… PS8, Line 185: 0x5f, 0x45, 0x3b, 0x04, 0x11, 0x11, 0x0d, 0x79, 0x5c, 0x48, 0x39, 0x05, 0x10, 0x13, 0x0b, 0x7b, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/8/payloads/cbui/gfx/splash.c… PS8, Line 186: 0x59, 0x4b, 0x38, 0x05, 0x10, 0x13, 0x09, 0x7f, 0x54, 0x4f, 0x36, 0x06, 0x10, 0x14, 0x06, 0x80, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/8/payloads/cbui/gfx/splash.c… PS8, Line 187: 0x82, 0x50, 0x53, 0x34, 0x06, 0x10, 0x16, 0x03, 0x80, 0x86, 0x4c, 0x55, 0x34, 0x07, 0x0f, 0x17, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/8/payloads/cbui/gfx/splash.c… PS8, Line 188: 0x00, 0x80, 0x89, 0x47, 0x59, 0x17, 0x04, 0x18, 0x09, 0x0b, 0x80, 0xa5, 0x42, 0x5b, 0x15, 0x0a, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/8/payloads/cbui/gfx/splash.c… PS8, Line 189: 0x15, 0x0c, 0x08, 0x80, 0xa8, 0x3b, 0x5f, 0x13, 0x05, 0x02, 0x05, 0x14, 0x0f, 0x04, 0x80, 0xaa, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/8/payloads/cbui/gfx/splash.c… PS8, Line 190: 0x35, 0x62, 0x12, 0x04, 0x08, 0x04, 0x12, 0x80, 0xc3, 0x2c, 0x67, 0x11, 0x03, 0x0c, 0x03, 0x11, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/8/payloads/cbui/gfx/splash.c… PS8, Line 191: 0x80, 0xc8, 0x20, 0x6e, 0x10, 0x02, 0x10, 0x02, 0x11, 0x80, 0xd1, 0x0b, 0x78, 0x10, 0x02, 0x04, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/8/payloads/cbui/gfx/splash.c… PS8, Line 192: 0x07, 0x05, 0x02, 0x10, 0x81, 0x56, 0x10, 0x01, 0x04, 0x0a, 0x03, 0x02, 0x11, 0x81, 0x4e, 0x16, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/8/payloads/cbui/gfx/splash.c… PS8, Line 193: 0x02, 0x03, 0x0c, 0x03, 0x02, 0x14, 0x81, 0x46, 0x1a, 0x01, 0x03, 0x0e, 0x03, 0x01, 0x1a, 0x81, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/8/payloads/cbui/gfx/splash.c… PS8, Line 194: 0x40, 0x19, 0x01, 0x03, 0x10, 0x02, 0x02, 0x19, 0x81, 0x40, 0x19, 0x01, 0x03, 0x10, 0x03, 0x01, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/8/payloads/cbui/gfx/splash.c… PS8, Line 195: 0x19, 0x81, 0x40, 0x19, 0x01, 0x02, 0x12, 0x02, 0x01, 0x19, 0x81, 0x40, 0x19, 0x01, 0x02, 0x12, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/8/payloads/cbui/gfx/splash.c… PS8, Line 196: 0x02, 0x01, 0x19, 0x81, 0x40, 0x19, 0x01, 0x02, 0x12, 0x02, 0x01, 0x19, 0x81, 0x40, 0x19, 0x01, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/8/payloads/cbui/gfx/splash.c… PS8, Line 197: 0x02, 0x12, 0x02, 0x02, 0x18, 0x81, 0x40, 0x19, 0x01, 0x02, 0x12, 0x02, 0x01, 0x19, 0x81, 0x40, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/8/payloads/cbui/gfx/splash.c… PS8, Line 198: 0x19, 0x01, 0x02, 0x12, 0x02, 0x01, 0x19, 0x81, 0x40, 0x19, 0x01, 0x02, 0x11, 0x03, 0x01, 0x19, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/8/payloads/cbui/gfx/splash.c… PS8, Line 199: 0x81, 0x40, 0x19, 0x01, 0x03, 0x10, 0x02, 0x02, 0x19, 0x81, 0x40, 0x19, 0x02, 0x02, 0x0f, 0x03, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/8/payloads/cbui/gfx/splash.c… PS8, Line 200: 0x02, 0x19, 0x81, 0x41, 0x19, 0x01, 0x03, 0x0e, 0x03, 0x01, 0x18, 0x81, 0x4d, 0x0f, 0x02, 0x03, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/8/payloads/cbui/gfx/splash.c… PS8, Line 201: 0x0c, 0x03, 0x02, 0x10, 0x81, 0x55, 0x10, 0x01, 0x04, 0x0a, 0x03, 0x02, 0x10, 0x81, 0x57, 0x10, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/8/payloads/cbui/gfx/splash.c… PS8, Line 202: 0x02, 0x05, 0x04, 0x05, 0x02, 0x11, 0x81, 0x57, 0x11, 0x02, 0x0e, 0x03, 0x11, 0x81, 0x57, 0x12, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/8/payloads/cbui/gfx/splash.c… PS8, Line 203: 0x02, 0x0c, 0x02, 0x12, 0x81, 0x59, 0x12, 0x03, 0x08, 0x03, 0x13, 0x81, 0x59, 0x13, 0x0e, 0x13, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/8/payloads/cbui/gfx/splash.c… PS8, Line 204: 0x81, 0x5b, 0x14, 0x0a, 0x15, 0x81, 0x5b, 0x34, 0x81, 0x5c, 0x34, 0x81, 0x5c, 0x35, 0x81, 0x5a, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/8/payloads/cbui/gfx/splash.c… PS8, Line 205: 0x37, 0x81, 0x58, 0x39, 0x81, 0x56, 0x3a, 0x81, 0x55, 0x3c, 0x81, 0x53, 0x3e, 0x81, 0x52, 0x3f, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/8/payloads/cbui/gfx/splash.c… PS8, Line 206: 0x81, 0x50, 0x40, 0x81, 0x51, 0x3f, 0x81, 0x51, 0x0e, 0x00, 0x1e, 0x00, 0x0e, 0x81, 0x53, 0x0c, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/8/payloads/cbui/gfx/splash.c… PS8, Line 207: 0x03, 0x1b, 0x02, 0x0c, 0x81, 0x55, 0x0a, 0x06, 0x16, 0x07, 0x09, 0x81, 0x57, 0x08, 0x0a, 0x11, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/8/payloads/cbui/gfx/splash.c… PS8, Line 208: 0x0a, 0x07, 0x81, 0x5a, 0x05, 0x0c, 0x0e, 0x0d, 0x05, 0x81, 0x5c, 0x03, 0x0e, 0x0c, 0x0f, 0x03, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/8/payloads/cbui/gfx/splash.c… PS8, Line 209: 0x81, 0x5e, 0x00, 0x10, 0x0c, 0x10, 0x01, 0x81, 0x71, 0x0c, 0x81, 0x84, 0x0c, 0x81, 0x84, 0x0c, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/8/payloads/cbui/gfx/splash.c… PS8, Line 210: 0x81, 0x84, 0x0c, 0x81, 0x84, 0x0c, 0x81, 0x84, 0x0c, 0x81, 0x84, 0x0c, 0x81, 0x85, 0x0a, 0x65,}, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/8/payloads/cbui/gfx/splash.c… PS8, Line 216: unsigned ret; Prefer 'unsigned int' to bare use of 'unsigned' https://review.coreboot.org/c/coreboot/+/23586/8/payloads/cbui/gfx/splash.c… PS8, Line 244: (cbui_logo.heigth > fbinfo->y_resolution)) 'heigth' may be misspelled - perhaps 'height'? https://review.coreboot.org/c/coreboot/+/23586/8/payloads/cbui/gfx/splash.c… PS8, Line 248: offset_y = fbinfo->y_resolution / 2 - cbui_logo.heigth / 2; 'heigth' may be misspelled - perhaps 'height'? https://review.coreboot.org/c/coreboot/+/23586/8/payloads/cbui/gfx/splash.c… PS8, Line 259: for (y = 0; y < cbui_logo.heigth; y ++) { 'heigth' may be misspelled - perhaps 'height'? https://review.coreboot.org/c/coreboot/+/23586/8/payloads/cbui/gfx/splash.c… PS8, Line 259: for (y = 0; y < cbui_logo.heigth; y ++) { space prohibited before that '++' (ctx:WxB) https://review.coreboot.org/c/coreboot/+/23586/8/payloads/cbui/gfx/splash.c… PS8, Line 260: for (x = 0; x < cbui_logo.width; x ++) { space prohibited before that '++' (ctx:WxB) https://review.coreboot.org/c/coreboot/+/23586/8/payloads/cbui/gfx/splash.c… PS8, Line 288: (cbui_logo.heigth > fbinfo->y_resolution)) 'heigth' may be misspelled - perhaps 'height'? https://review.coreboot.org/c/coreboot/+/23586/8/payloads/cbui/gfx/splash.c… PS8, Line 293: offset_y = fbinfo->y_resolution / 2 + cbui_logo.heigth / 2 + height * 2; 'heigth' may be misspelled - perhaps 'height'? https://review.coreboot.org/c/coreboot/+/23586/8/payloads/cbui/gfx/splash.c… PS8, Line 299: for (x = 0; x < cbui_logo.width; x ++) { space prohibited before that '++' (ctx:WxB) https://review.coreboot.org/c/coreboot/+/23586/8/payloads/cbui/gfx/splash.c… PS8, Line 301: for (y = 0; y < height; y ++) { space prohibited before that '++' (ctx:WxB) https://review.coreboot.org/c/coreboot/+/23586/8/payloads/cbui/gfx/vbe.h File payloads/cbui/gfx/vbe.h: https://review.coreboot.org/c/coreboot/+/23586/8/payloads/cbui/gfx/vbe.h@28 PS8, Line 28: { open brace '{' following struct go on the same line https://review.coreboot.org/c/coreboot/+/23586/8/payloads/cbui/gfx/vbe.c File payloads/cbui/gfx/vbe.c: https://review.coreboot.org/c/coreboot/+/23586/8/payloads/cbui/gfx/vbe.c@24 PS8, Line 24: static u8 low_mem[0x1000] __attribute__ ((section (".lowmem"))); space prohibited between function name and open parenthesis '(' https://review.coreboot.org/c/coreboot/+/23586/8/payloads/cbui/gfx/vbe.c@32 PS8, Line 32: memset (vbe, 0, sizeof(*vbe)); space prohibited between function name and open parenthesis '(' https://review.coreboot.org/c/coreboot/+/23586/8/payloads/cbui/gfx/vbe.c@33 PS8, Line 33: memcpy (vbe->signature, "VBE2", 4); space prohibited between function name and open parenthesis '(' https://review.coreboot.org/c/coreboot/+/23586/8/payloads/cbui/lang/de.c File payloads/cbui/lang/de.c: https://review.coreboot.org/c/coreboot/+/23586/8/payloads/cbui/lang/de.c@39 PS8, Line 39: "Kein Framebuffer gefunden. CBUI funktioniert nicht" \ Avoid unnecessary line continuations https://review.coreboot.org/c/coreboot/+/23586/8/payloads/cbui/lang/de.c@44 PS8, Line 44: "Der coreboot framebuffer hat keine physikalische " \ Avoid unnecessary line continuations https://review.coreboot.org/c/coreboot/+/23586/8/payloads/cbui/lang/de.c@47 PS8, Line 47: "Kein Platz auf dem Heap.\nBitte vergrößere den" \ Avoid unnecessary line continuations https://review.coreboot.org/c/coreboot/+/23586/8/payloads/cbui/lang/de.c@50 PS8, Line 50: "Konnte die nuklear Bibliothek nicht intitialisieren.\nBitte" \ Avoid unnecessary line continuations https://review.coreboot.org/c/coreboot/+/23586/8/payloads/cbui/lang/de.c@52 PS8, Line 52: "stelle sicher, das der Framebuffer entweder das RGBX8 oder " \ Avoid unnecessary line continuations https://review.coreboot.org/c/coreboot/+/23586/8/payloads/cbui/lang/de.c@65 PS8, Line 65: "Fehler: Keine CMOS Einträge gefunden. Bitte schalte die " \ Avoid unnecessary line continuations https://review.coreboot.org/c/coreboot/+/23586/8/payloads/cbui/lang/de.c@86 PS8, Line 86: "Fehler: Keine Zeitstempel gefunden. Bitte schalte die " \ Avoid unnecessary line continuations https://review.coreboot.org/c/coreboot/+/23586/8/payloads/cbui/lang/de.c@89 PS8, Line 89: "Fehler: Bootlog nicht gefunden. Bitte schalte die Kconfig " \ Avoid unnecessary line continuations https://review.coreboot.org/c/coreboot/+/23586/8/payloads/cbui/lang/en.c File payloads/cbui/lang/en.c: https://review.coreboot.org/c/coreboot/+/23586/8/payloads/cbui/lang/en.c@38 PS8, Line 38: "No framebuffer found. CBUI doesn't work in text mode.\n" \ Avoid unnecessary line continuations https://review.coreboot.org/c/coreboot/+/23586/8/payloads/cbui/lang/en.c@46 PS8, Line 46: "Failed to init nuklear library.\nMake sure you have enough " \ Avoid unnecessary line continuations https://review.coreboot.org/c/coreboot/+/23586/8/payloads/cbui/lang/en.c@60 PS8, Line 60: "ERROR: No CMOS options found. Please make sure to enable " \ Avoid unnecessary line continuations https://review.coreboot.org/c/coreboot/+/23586/8/payloads/cbui/lang/en.c@81 PS8, Line 81: "ERROR: No timestamps found. Please make sure to enable " \ Avoid unnecessary line continuations https://review.coreboot.org/c/coreboot/+/23586/8/payloads/cbui/lang/en.c@84 PS8, Line 84: "ERROR: Bootlog not found. Please make sure to enable " \ Avoid unnecessary line continuations https://review.coreboot.org/c/coreboot/+/23586/8/payloads/cbui/lang/lang.c File payloads/cbui/lang/lang.c: https://review.coreboot.org/c/coreboot/+/23586/8/payloads/cbui/lang/lang.c@… PS8, Line 50: * To be used for untranslateable items. */ 'untranslateable' may be misspelled - perhaps 'untranslatable'? https://review.coreboot.org/c/coreboot/+/23586/8/payloads/cbui/modules/boot… File payloads/cbui/modules/bootlog_module.c: https://review.coreboot.org/c/coreboot/+/23586/8/payloads/cbui/modules/boot… PS8, Line 66: if (buffer[i] == '\n') { braces {} are not necessary for any arm of this statement https://review.coreboot.org/c/coreboot/+/23586/8/payloads/cbui/modules/boot… PS8, Line 79: } void function return statements are not generally useful https://review.coreboot.org/c/coreboot/+/23586/8/payloads/cbui/modules/cbfs… File payloads/cbui/modules/cbfs_module.c: https://review.coreboot.org/c/coreboot/+/23586/8/payloads/cbui/modules/cbfs… PS8, Line 91: switch (ntohl(type)) { switch and case should be at the same indent https://review.coreboot.org/c/coreboot/+/23586/8/payloads/cbui/modules/cbfs… PS8, Line 140: struct nuklear_group* group = NuklearGroup_new(this->root, "foo* bar" should be "foo *bar" https://review.coreboot.org/c/coreboot/+/23586/8/payloads/cbui/modules/core… File payloads/cbui/modules/coreboot_module.c: https://review.coreboot.org/c/coreboot/+/23586/8/payloads/cbui/modules/core… PS8, Line 262: if (cb_info.framebuffer.tag != 0 ) { space prohibited before that close parenthesis ')' https://review.coreboot.org/c/coreboot/+/23586/8/payloads/cbui/modules/cpui… File payloads/cbui/modules/cpuinfo_module.c: https://review.coreboot.org/c/coreboot/+/23586/8/payloads/cbui/modules/cpui… PS8, Line 35: static const char *intel_cap_edx_flags[] = { static const char * array should probably be static const char * const https://review.coreboot.org/c/coreboot/+/23586/8/payloads/cbui/modules/cpui… PS8, Line 43: static const char *amd_cap_edx_flags[] = { static const char * array should probably be static const char * const https://review.coreboot.org/c/coreboot/+/23586/8/payloads/cbui/modules/cpui… PS8, Line 51: static const char *intel_cap_ecx_flags[] = { static const char * array should probably be static const char * const https://review.coreboot.org/c/coreboot/+/23586/8/payloads/cbui/modules/cpui… PS8, Line 59: static const char *amd_cap_ecx_flags[] = { static const char * array should probably be static const char * const https://review.coreboot.org/c/coreboot/+/23586/8/payloads/cbui/modules/cpui… PS8, Line 67: static const char *intel_cap_extended_edx_flags[] = { static const char * array should probably be static const char * const https://review.coreboot.org/c/coreboot/+/23586/8/payloads/cbui/modules/cpui… PS8, Line 75: static const char *intel_cap_extended_ecx_flags[] = { static const char * array should probably be static const char * const https://review.coreboot.org/c/coreboot/+/23586/8/payloads/cbui/modules/cpui… PS8, Line 83: static const char *amd_cap_extended_edx_flags[] = { static const char * array should probably be static const char * const https://review.coreboot.org/c/coreboot/+/23586/8/payloads/cbui/modules/cpui… PS8, Line 92: static const char *amd_cap_extended_ecx_flags[] = { static const char * array should probably be static const char * const https://review.coreboot.org/c/coreboot/+/23586/8/payloads/cbui/modules/cpui… PS8, Line 100: static void mod_add_cpu_feature(struct nuklear_group* group, "foo* bar" should be "foo *bar" https://review.coreboot.org/c/coreboot/+/23586/8/payloads/cbui/modules/cpui… PS8, Line 119: static void mod_open(struct nuklear_module* this) "foo* bar" should be "foo *bar" https://review.coreboot.org/c/coreboot/+/23586/8/payloads/cbui/modules/cpui… PS8, Line 128: struct nuklear_group* group1 = NuklearGroup_new(this->root, "foo* bar" should be "foo *bar" https://review.coreboot.org/c/coreboot/+/23586/8/payloads/cbui/modules/cpui… PS8, Line 189: struct nuklear_group* group2 = NuklearGroup_new(this->root, "foo* bar" should be "foo *bar" https://review.coreboot.org/c/coreboot/+/23586/8/payloads/cbui/modules/cpui… PS8, Line 192: struct nuklear_group* group3 = NuklearGroup_new(this->root, "foo* bar" should be "foo *bar" https://review.coreboot.org/c/coreboot/+/23586/8/payloads/cbui/modules/cpui… PS8, Line 195: struct nuklear_group* group4 = NuklearGroup_new(this->root, "foo* bar" should be "foo *bar" https://review.coreboot.org/c/coreboot/+/23586/8/payloads/cbui/modules/cpui… PS8, Line 198: struct nuklear_group* group5 = NuklearGroup_new(this->root, "foo* bar" should be "foo *bar" https://review.coreboot.org/c/coreboot/+/23586/8/payloads/cbui/modules/cpui… PS8, Line 232: static void mod_close(struct nuklear_module* this, bool save) "foo* bar" should be "foo *bar" https://review.coreboot.org/c/coreboot/+/23586/8/payloads/cbui/modules/cpui… PS8, Line 237: static bool mod_update(struct nuklear_module* this) "foo* bar" should be "foo *bar" https://review.coreboot.org/c/coreboot/+/23586/8/payloads/cbui/modules/cpui… PS8, Line 242: static void mod_draw(struct nuklear_module* this, struct nk_context *ctx) "foo* bar" should be "foo *bar" https://review.coreboot.org/c/coreboot/+/23586/8/payloads/cbui/modules/cpui… PS8, Line 247: static bool mod_handlekey(struct nuklear_module* this, struct nk_context *ctx) "foo* bar" should be "foo *bar" https://review.coreboot.org/c/coreboot/+/23586/8/payloads/cbui/modules/lice… File payloads/cbui/modules/license_module.c: https://review.coreboot.org/c/coreboot/+/23586/8/payloads/cbui/modules/lice… PS8, Line 24: struct nuklear_group* group1 = NuklearGroup_new(this->root, "foo* bar" should be "foo *bar" https://review.coreboot.org/c/coreboot/+/23586/8/payloads/cbui/modules/lice… PS8, Line 65: struct nuklear_group* group2 = NuklearGroup_new(this->root, "foo* bar" should be "foo *bar" https://review.coreboot.org/c/coreboot/+/23586/8/payloads/cbui/modules/lice… PS8, Line 77: "along with this program; if not, write to the Free Software\n" Do not include the paragraph about writing to the Free Software Foundation's mailing address from the sample GPL notice. The FSF has changed addresses in the past, and may do so again. Linux already includes a copy of the GPL. https://review.coreboot.org/c/coreboot/+/23586/8/payloads/cbui/modules/lice… PS8, Line 78: "Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA " Do not include the paragraph about writing to the Free Software Foundation's mailing address from the sample GPL notice. The FSF has changed addresses in the past, and may do so again. Linux already includes a copy of the GPL. https://review.coreboot.org/c/coreboot/+/23586/8/payloads/cbui/modules/lice… PS8, Line 83: struct nuklear_group* group3 = NuklearGroup_new(this->root, "foo* bar" should be "foo *bar" https://review.coreboot.org/c/coreboot/+/23586/8/payloads/cbui/modules/pci_… File payloads/cbui/modules/pci_module.c: https://review.coreboot.org/c/coreboot/+/23586/8/payloads/cbui/modules/pci_… PS8, Line 75: switch (class) { switch and case should be at the same indent https://review.coreboot.org/c/coreboot/+/23586/8/payloads/cbui/modules/pci_… PS8, Line 93: case 0x11: return "Data Acquisition and Signal Processing" \ Avoid unnecessary line continuations https://review.coreboot.org/c/coreboot/+/23586/8/payloads/cbui/modules/pci_… PS8, Line 96: if (class == 0xff) return ""; trailing statements should be on next line https://review.coreboot.org/c/coreboot/+/23586/8/payloads/cbui/modules/pci_… PS8, Line 204: struct nuklear_group* group1 = NuklearGroup_new(this->root, "foo* bar" should be "foo *bar" https://review.coreboot.org/c/coreboot/+/23586/8/payloads/cbui/modules/rtc_… File payloads/cbui/modules/rtc_module.c: https://review.coreboot.org/c/coreboot/+/23586/8/payloads/cbui/modules/rtc_… PS8, Line 27: static struct nuklear_timepicker* tp; "foo* bar" should be "foo *bar" https://review.coreboot.org/c/coreboot/+/23586/8/payloads/cbui/modules/rtc_… PS8, Line 28: static struct nuklear_datepicker* dp; "foo* bar" should be "foo *bar" https://review.coreboot.org/c/coreboot/+/23586/8/payloads/cbui/modules/time… File payloads/cbui/modules/timestamps_module.c: https://review.coreboot.org/c/coreboot/+/23586/8/payloads/cbui/modules/time… PS8, Line 63: struct nuklear_group* group1 = NuklearGroup_new(this->root, "foo* bar" should be "foo *bar" https://review.coreboot.org/c/coreboot/+/23586/8/payloads/cbui/modules/time… PS8, Line 121: } void function return statements are not generally useful https://review.coreboot.org/c/coreboot/+/23586/8/payloads/cbui/modules/usb_… File payloads/cbui/modules/usb_module.c: https://review.coreboot.org/c/coreboot/+/23586/8/payloads/cbui/modules/usb_… PS8, Line 37: struct nuklear_group* group1 = NuklearGroup_new(this->root, "foo* bar" should be "foo *bar" https://review.coreboot.org/c/coreboot/+/23586/8/payloads/cbui/modules/usb_… PS8, Line 56: switch(controller->type) { space required before the open parenthesis '(' https://review.coreboot.org/c/coreboot/+/23586/8/payloads/cbui/modules/usb_… PS8, Line 96: switch(controller->type) { space required before the open parenthesis '(' https://review.coreboot.org/c/coreboot/+/23586/8/payloads/cbui/modules/usb_… PS8, Line 126: struct nuklear_group* group = NuklearGroup_new(this->root, "foo* bar" should be "foo *bar" https://review.coreboot.org/c/coreboot/+/23586/8/payloads/cbui/modules/usb_… PS8, Line 147: switch(controller->devices[i]->speed) { space required before the open parenthesis '(' -- To view, visit https://review.coreboot.org/c/coreboot/+/23586 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib9a1a07c1065880aa675380625021750d5cab7d1 Gerrit-Change-Number: 23586 Gerrit-PatchSet: 8 Gerrit-Owner: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Comment-Date: Wed, 11 Mar 2020 15:10:09 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: libpayload/drivers/nvram: Add function to write RTC
by Patrick Georgi (Code Review) 11 Mar '20

11 Mar '20

Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/23585 ) Change subject: libpayload/drivers/nvram: Add function to write RTC ...................................................................... Patch Set 5: (2 comments) https://review.coreboot.org/c/coreboot/+/23585/3/payloads/libpayload/driver… File payloads/libpayload/drivers/nvram.c: https://review.coreboot.org/c/coreboot/+/23585/3/payloads/libpayload/driver… PS3, Line 185: 0x04 > Use the new constant? Done https://review.coreboot.org/c/coreboot/+/23585/3/payloads/libpayload/driver… PS3, Line 190: 0x02 > Ditto Done -- To view, visit https://review.coreboot.org/c/coreboot/+/23585 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I17b4c1ee0dcc649738ac6a7400b087d07213eaf0 Gerrit-Change-Number: 23585 Gerrit-PatchSet: 5 Gerrit-Owner: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 11 Mar 2020 15:09:37 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: libpayload/drivers/nvram: Add function to write RTC
by Patrick Georgi (Code Review) 11 Mar '20

11 Mar '20

Patrick Georgi has uploaded a new patch set (#6) to the change originally created by Patrick Rudolph. ( https://review.coreboot.org/c/coreboot/+/23585 ) Change subject: libpayload/drivers/nvram: Add function to write RTC ...................................................................... libpayload/drivers/nvram: Add function to write RTC Add a function to set the RTC to provided struct tm. Change-Id: I17b4c1ee0dcc649738ac6a7400b087d07213eaf0 Signed-off-by: Patrick Rudolph <siro(a)das-labor.org> --- M payloads/libpayload/drivers/nvram.c M payloads/libpayload/include/libpayload.h 2 files changed, 53 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/85/23585/6 -- To view, visit https://review.coreboot.org/c/coreboot/+/23585 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I17b4c1ee0dcc649738ac6a7400b087d07213eaf0 Gerrit-Change-Number: 23585 Gerrit-PatchSet: 6 Gerrit-Owner: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: payloads/cbui: Add new payload CBUI
by build bot (Jenkins) (Code Review) 11 Mar '20

11 Mar '20

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/23586 ) Change subject: payloads/cbui: Add new payload CBUI ...................................................................... Patch Set 7: (298 comments) https://review.coreboot.org/c/coreboot/+/23586/7/payloads/cbui/Kconfig File payloads/cbui/Kconfig: https://review.coreboot.org/c/coreboot/+/23586/7/payloads/cbui/Kconfig@37 PS7, Line 37: config LANG_PREFERED 'PREFERED' may be misspelled - perhaps 'PREFERRED'? https://review.coreboot.org/c/coreboot/+/23586/7/payloads/cbui/Kconfig@38 PS7, Line 38: string "Prefered UI language" 'Prefered' may be misspelled - perhaps 'Preferred'? https://review.coreboot.org/c/coreboot/+/23586/7/payloads/cbui/NuklearUI/Nu… File payloads/cbui/NuklearUI/NuklearCombo.h: https://review.coreboot.org/c/coreboot/+/23586/7/payloads/cbui/NuklearUI/Nu… PS7, Line 23: { open brace '{' following struct go on the same line https://review.coreboot.org/c/coreboot/+/23586/7/payloads/cbui/NuklearUI/Nu… File payloads/cbui/NuklearUI/NuklearDatePicker.h: https://review.coreboot.org/c/coreboot/+/23586/7/payloads/cbui/NuklearUI/Nu… PS7, Line 24: { open brace '{' following struct go on the same line https://review.coreboot.org/c/coreboot/+/23586/7/payloads/cbui/NuklearUI/Nu… File payloads/cbui/NuklearUI/NuklearDatePicker.c: https://review.coreboot.org/c/coreboot/+/23586/7/payloads/cbui/NuklearUI/Nu… PS7, Line 32: switch (month) { switch and case should be at the same indent https://review.coreboot.org/c/coreboot/+/23586/7/payloads/cbui/NuklearUI/Nu… PS7, Line 278: struct nuklear_datepicker* obj; "foo* bar" should be "foo *bar" https://review.coreboot.org/c/coreboot/+/23586/7/payloads/cbui/NuklearUI/Nu… File payloads/cbui/NuklearUI/NuklearGroup.h: https://review.coreboot.org/c/coreboot/+/23586/7/payloads/cbui/NuklearUI/Nu… PS7, Line 23: { open brace '{' following struct go on the same line https://review.coreboot.org/c/coreboot/+/23586/7/payloads/cbui/NuklearUI/Nu… File payloads/cbui/NuklearUI/NuklearIntegerRange.h: https://review.coreboot.org/c/coreboot/+/23586/7/payloads/cbui/NuklearUI/Nu… PS7, Line 23: { open brace '{' following struct go on the same line https://review.coreboot.org/c/coreboot/+/23586/7/payloads/cbui/NuklearUI/Nu… File payloads/cbui/NuklearUI/NuklearLabel.h: https://review.coreboot.org/c/coreboot/+/23586/7/payloads/cbui/NuklearUI/Nu… PS7, Line 23: { open brace '{' following struct go on the same line https://review.coreboot.org/c/coreboot/+/23586/7/payloads/cbui/NuklearUI/Nu… PS7, Line 34: void NuklearLabel_dtor(void* obj); "foo* bar" should be "foo *bar" https://review.coreboot.org/c/coreboot/+/23586/7/payloads/cbui/NuklearUI/Nu… File payloads/cbui/NuklearUI/NuklearLabel.c: https://review.coreboot.org/c/coreboot/+/23586/7/payloads/cbui/NuklearUI/Nu… PS7, Line 81: void NuklearLabel_dtor(void* obj) "foo* bar" should be "foo *bar" https://review.coreboot.org/c/coreboot/+/23586/7/payloads/cbui/NuklearUI/Nu… File payloads/cbui/NuklearUI/NuklearObject.h: https://review.coreboot.org/c/coreboot/+/23586/7/payloads/cbui/NuklearUI/Nu… PS7, Line 21: { open brace '{' following struct go on the same line https://review.coreboot.org/c/coreboot/+/23586/7/payloads/cbui/NuklearUI/Nu… PS7, Line 44: void NuklearObject_ctor(struct nuklear_object* obj, "foo* bar" should be "foo *bar" https://review.coreboot.org/c/coreboot/+/23586/7/payloads/cbui/NuklearUI/Nu… PS7, Line 49: void NuklearObject_dtor(void* obj); "foo* bar" should be "foo *bar" https://review.coreboot.org/c/coreboot/+/23586/7/payloads/cbui/NuklearUI/Nu… File payloads/cbui/NuklearUI/NuklearRoot.c: https://review.coreboot.org/c/coreboot/+/23586/7/payloads/cbui/NuklearUI/Nu… PS7, Line 24: { open brace '{' following struct go on the same line https://review.coreboot.org/c/coreboot/+/23586/7/payloads/cbui/NuklearUI/Nu… PS7, Line 100: } else { else is not generally useful after a break or return https://review.coreboot.org/c/coreboot/+/23586/7/payloads/cbui/NuklearUI/Nu… PS7, Line 219: struct nuklear_root* NuklearRoot_ctor(void) "foo* bar" should be "foo *bar" https://review.coreboot.org/c/coreboot/+/23586/7/payloads/cbui/NuklearUI/Nu… File payloads/cbui/NuklearUI/NuklearTabView.c: https://review.coreboot.org/c/coreboot/+/23586/7/payloads/cbui/NuklearUI/Nu… PS7, Line 25: { open brace '{' following struct go on the same line https://review.coreboot.org/c/coreboot/+/23586/7/payloads/cbui/NuklearUI/Nu… PS7, Line 31: { open brace '{' following struct go on the same line https://review.coreboot.org/c/coreboot/+/23586/7/payloads/cbui/NuklearUI/Nu… PS7, Line 43: struct nuklear_tabview_map* map = NULL; "foo* bar" should be "foo *bar" https://review.coreboot.org/c/coreboot/+/23586/7/payloads/cbui/NuklearUI/Nu… PS7, Line 126: NuklearTabView_set_focus(this, +1); need consistent spacing around '+' (ctx:WxV) https://review.coreboot.org/c/coreboot/+/23586/7/payloads/cbui/NuklearUI/Nu… PS7, Line 220: struct nk_context *ctx, struct nuklear_vector* modules) "foo* bar" should be "foo *bar" https://review.coreboot.org/c/coreboot/+/23586/7/payloads/cbui/NuklearUI/Nu… PS7, Line 324: struct nuklear_tabview_map* map = "foo* bar" should be "foo *bar" https://review.coreboot.org/c/coreboot/+/23586/7/payloads/cbui/NuklearUI/Nu… PS7, Line 355: for (size_t i = 1; i < NKUI_KEY_LAST; i<<=1) { spaces required around that '<<=' (ctx:VxV) https://review.coreboot.org/c/coreboot/+/23586/7/payloads/cbui/NuklearUI/Nu… File payloads/cbui/NuklearUI/NuklearTextView.h: https://review.coreboot.org/c/coreboot/+/23586/7/payloads/cbui/NuklearUI/Nu… PS7, Line 24: { open brace '{' following struct go on the same line https://review.coreboot.org/c/coreboot/+/23586/7/payloads/cbui/NuklearUI/Nu… File payloads/cbui/NuklearUI/NuklearTextView.c: https://review.coreboot.org/c/coreboot/+/23586/7/payloads/cbui/NuklearUI/Nu… PS7, Line 76: if (nk_input_is_key_pressed(i, NK_KEY_UP)) { braces {} are not necessary for any arm of this statement https://review.coreboot.org/c/coreboot/+/23586/7/payloads/cbui/NuklearUI/Nu… File payloads/cbui/NuklearUI/NuklearTextfield.h: https://review.coreboot.org/c/coreboot/+/23586/7/payloads/cbui/NuklearUI/Nu… PS7, Line 23: { open brace '{' following struct go on the same line https://review.coreboot.org/c/coreboot/+/23586/7/payloads/cbui/NuklearUI/Nu… File payloads/cbui/NuklearUI/NuklearTextfield.c: https://review.coreboot.org/c/coreboot/+/23586/7/payloads/cbui/NuklearUI/Nu… PS7, Line 121: void NuklearTextfield_dtor(void* obj) "foo* bar" should be "foo *bar" https://review.coreboot.org/c/coreboot/+/23586/7/payloads/cbui/NuklearUI/Nu… PS7, Line 165: struct nuklear_textfield* obj; "foo* bar" should be "foo *bar" https://review.coreboot.org/c/coreboot/+/23586/7/payloads/cbui/NuklearUI/Nu… File payloads/cbui/NuklearUI/NuklearTimePicker.h: https://review.coreboot.org/c/coreboot/+/23586/7/payloads/cbui/NuklearUI/Nu… PS7, Line 25: { open brace '{' following struct go on the same line https://review.coreboot.org/c/coreboot/+/23586/7/payloads/cbui/NuklearUI/Nu… File payloads/cbui/NuklearUI/NuklearTimePicker.c: https://review.coreboot.org/c/coreboot/+/23586/7/payloads/cbui/NuklearUI/Nu… PS7, Line 180: struct nuklear_timepicker* obj; "foo* bar" should be "foo *bar" https://review.coreboot.org/c/coreboot/+/23586/7/payloads/cbui/NuklearUI/Nu… File payloads/cbui/NuklearUI/NuklearUI.h: https://review.coreboot.org/c/coreboot/+/23586/7/payloads/cbui/NuklearUI/Nu… PS7, Line 76: struct nuklear_root* NuklearRoot_ctor(void); "foo* bar" should be "foo *bar" https://review.coreboot.org/c/coreboot/+/23586/7/payloads/cbui/NuklearUI/Nu… PS7, Line 298: struct nuklear_root* root; "foo* bar" should be "foo *bar" https://review.coreboot.org/c/coreboot/+/23586/7/payloads/cbui/NuklearUI/Nu… PS7, Line 319: struct nuklear_tabview* NuklearTabView_new(const struct nuklear_desc *desc); "foo* bar" should be "foo *bar" https://review.coreboot.org/c/coreboot/+/23586/7/payloads/cbui/NuklearUI/Nu… File payloads/cbui/NuklearUI/NuklearVector.h: https://review.coreboot.org/c/coreboot/+/23586/7/payloads/cbui/NuklearUI/Nu… PS7, Line 20: { open brace '{' following struct go on the same line https://review.coreboot.org/c/coreboot/+/23586/7/payloads/cbui/NuklearUI/Nu… PS7, Line 26: struct nuklear_vector* NuklearVector_ctor(void); "foo* bar" should be "foo *bar" https://review.coreboot.org/c/coreboot/+/23586/7/payloads/cbui/NuklearUI/Nu… PS7, Line 37: struct { struct nuklear_vector *vecptr; t *y; } it = \ need consistent spacing around '*' (ctx:WxV) https://review.coreboot.org/c/coreboot/+/23586/7/payloads/cbui/NuklearUI/Nu… File payloads/cbui/NuklearUI/NuklearVector.c: https://review.coreboot.org/c/coreboot/+/23586/7/payloads/cbui/NuklearUI/Nu… PS7, Line 59: for (;i > 0 && base; i--) space required after that ';' (ctx:BxV) https://review.coreboot.org/c/coreboot/+/23586/7/payloads/cbui/NuklearUI/Nu… PS7, Line 90: for (;i > 0 && base; i--) space required after that ';' (ctx:BxV) https://review.coreboot.org/c/coreboot/+/23586/7/payloads/cbui/arch/x86/int… File payloads/cbui/arch/x86/int32.h: https://review.coreboot.org/c/coreboot/+/23586/7/payloads/cbui/arch/x86/int… PS7, Line 21: unsigned short di, si, bp, sp, bx, dx, cx, ax; please, no spaces at the start of a line https://review.coreboot.org/c/coreboot/+/23586/7/payloads/cbui/arch/x86/int… PS7, Line 22: unsigned short gs, fs, es, ds, eflags; please, no spaces at the start of a line https://review.coreboot.org/c/coreboot/+/23586/7/payloads/cbui/arch/x86/int… File payloads/cbui/arch/x86/int32.nasm: https://review.coreboot.org/c/coreboot/+/23586/7/payloads/cbui/arch/x86/int… PS7, Line 38: struc regs16_t 'struc' may be misspelled - perhaps 'struct'? https://review.coreboot.org/c/coreboot/+/23586/7/payloads/cbui/arch/x86/int… PS7, Line 80: mov [REBASE(ib)], al ; set intrrupt immediate byte from our arguments 'intrrupt' may be misspelled - perhaps 'interrupt'? https://review.coreboot.org/c/coreboot/+/23586/7/payloads/cbui/cbui.h File payloads/cbui/cbui.h: https://review.coreboot.org/c/coreboot/+/23586/7/payloads/cbui/cbui.h@35 PS7, Line 35: } while(0) space required before the open parenthesis '(' https://review.coreboot.org/c/coreboot/+/23586/7/payloads/cbui/cbui.h@37 PS7, Line 37: #define NK_ASSERT(x) do {} while(0) space required before the open parenthesis '(' https://review.coreboot.org/c/coreboot/+/23586/7/payloads/cbui/cbui.h@41 PS7, Line 41: #define assert(x) do {} while(0); space required before the open parenthesis '(' https://review.coreboot.org/c/coreboot/+/23586/7/payloads/cbui/cbui.h@41 PS7, Line 41: #define assert(x) do {} while(0); do {} while (0) macros should not be semicolon terminated https://review.coreboot.org/c/coreboot/+/23586/7/payloads/cbui/cbui.h@46 PS7, Line 46: extern void usb_poll (void); space prohibited between function name and open parenthesis '(' https://review.coreboot.org/c/coreboot/+/23586/7/payloads/cbui/cbui.c File payloads/cbui/cbui.c: https://review.coreboot.org/c/coreboot/+/23586/7/payloads/cbui/cbui.c@63 PS7, Line 63: switch(rawfb->font_tex.format) { space required before the open parenthesis '(' https://review.coreboot.org/c/coreboot/+/23586/7/payloads/cbui/cbui.c@163 PS7, Line 163: switch(key) { space required before the open parenthesis '(' https://review.coreboot.org/c/coreboot/+/23586/7/payloads/cbui/cbui.c@318 PS7, Line 318: struct nuklear_tabview* nktv; "foo* bar" should be "foo *bar" https://review.coreboot.org/c/coreboot/+/23586/7/payloads/cbui/cbui.c@325 PS7, Line 325: lang_set_country(CONFIG_LANG_PREFERED); 'PREFERED' may be misspelled - perhaps 'PREFERRED'? https://review.coreboot.org/c/coreboot/+/23586/7/payloads/cbui/gfx/splash.c File payloads/cbui/gfx/splash.c: https://review.coreboot.org/c/coreboot/+/23586/7/payloads/cbui/gfx/splash.c… PS7, Line 22: unsigned width; Prefer 'unsigned int' to bare use of 'unsigned' https://review.coreboot.org/c/coreboot/+/23586/7/payloads/cbui/gfx/splash.c… PS7, Line 23: unsigned heigth; 'heigth' may be misspelled - perhaps 'height'? https://review.coreboot.org/c/coreboot/+/23586/7/payloads/cbui/gfx/splash.c… PS7, Line 23: unsigned heigth; Prefer 'unsigned int' to bare use of 'unsigned' https://review.coreboot.org/c/coreboot/+/23586/7/payloads/cbui/gfx/splash.c… PS7, Line 24: unsigned first_pixel_c; Prefer 'unsigned int' to bare use of 'unsigned' https://review.coreboot.org/c/coreboot/+/23586/7/payloads/cbui/gfx/splash.c… PS7, Line 37: .heigth = 370, 'heigth' may be misspelled - perhaps 'height'? https://review.coreboot.org/c/coreboot/+/23586/7/payloads/cbui/gfx/splash.c… PS7, Line 40: 0x83, 0xa6, 0x03, 0x81, 0x8e, 0x06, 0x81, 0x8b, 0x08, 0x81, 0x89, 0x0a, 0x81, 0x88, 0x0b, 0x81, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/7/payloads/cbui/gfx/splash.c… PS7, Line 41: 0x86, 0x0d, 0x81, 0x84, 0x0f, 0x81, 0x82, 0x11, 0x81, 0x80, 0x12, 0x81, 0x80, 0x13, 0x81, 0x7e, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/7/payloads/cbui/gfx/splash.c… PS7, Line 42: 0x14, 0x81, 0x7d, 0x15, 0x81, 0x7c, 0x17, 0x81, 0x7b, 0x17, 0x81, 0x7a, 0x18, 0x81, 0x79, 0x19, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/7/payloads/cbui/gfx/splash.c… PS7, Line 43: 0x81, 0x78, 0x1a, 0x81, 0x78, 0x1a, 0x81, 0x77, 0x1b, 0x81, 0x76, 0x1c, 0x81, 0x75, 0x1d, 0x81, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/7/payloads/cbui/gfx/splash.c… PS7, Line 44: 0x46, 0x0c, 0x21, 0x1d, 0x81, 0x40, 0x19, 0x19, 0x1e, 0x81, 0x3d, 0x20, 0x14, 0x1f, 0x81, 0x3b, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/7/payloads/cbui/gfx/splash.c… PS7, Line 45: 0x24, 0x11, 0x1f, 0x81, 0x3a, 0x29, 0x0e, 0x1f, 0x81, 0x38, 0x2c, 0x0c, 0x20, 0x81, 0x36, 0x30, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/7/payloads/cbui/gfx/splash.c… PS7, Line 46: 0x09, 0x21, 0x81, 0x35, 0x32, 0x07, 0x21, 0x81, 0x35, 0x34, 0x06, 0x21, 0x81, 0x34, 0x36, 0x04, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/7/payloads/cbui/gfx/splash.c… PS7, Line 47: 0x22, 0x81, 0x32, 0x39, 0x01, 0x23, 0x81, 0x32, 0x60, 0x81, 0x31, 0x61, 0x81, 0x30, 0x61, 0x81, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/7/payloads/cbui/gfx/splash.c… PS7, Line 48: 0x30, 0x62, 0x81, 0x2f, 0x62, 0x81, 0x2f, 0x63, 0x81, 0x2e, 0x63, 0x81, 0x2e, 0x64, 0x81, 0x2d, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/7/payloads/cbui/gfx/splash.c… PS7, Line 49: 0x65, 0x81, 0x2c, 0x65, 0x81, 0x2c, 0x66, 0x81, 0x2b, 0x66, 0x81, 0x2b, 0x67, 0x81, 0x2a, 0x67, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/7/payloads/cbui/gfx/splash.c… PS7, Line 50: 0x81, 0x2a, 0x67, 0x81, 0x2a, 0x68, 0x81, 0x29, 0x68, 0x81, 0x29, 0x69, 0x81, 0x29, 0x68, 0x81, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/7/payloads/cbui/gfx/splash.c… PS7, Line 51: 0x29, 0x69, 0x81, 0x28, 0x69, 0x81, 0x28, 0x69, 0x81, 0x29, 0x69, 0x81, 0x28, 0x69, 0x81, 0x28, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/7/payloads/cbui/gfx/splash.c… PS7, Line 52: 0x6a, 0x81, 0x27, 0x6a, 0x81, 0x28, 0x69, 0x81, 0x28, 0x6a, 0x81, 0x28, 0x69, 0x81, 0x28, 0x69, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/7/payloads/cbui/gfx/splash.c… PS7, Line 53: 0x81, 0x28, 0x6a, 0x81, 0x28, 0x69, 0x81, 0x28, 0x69, 0x81, 0x29, 0x69, 0x81, 0x28, 0x69, 0x81, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/7/payloads/cbui/gfx/splash.c… PS7, Line 54: 0x29, 0x68, 0x81, 0x2a, 0x68, 0x81, 0x29, 0x68, 0x81, 0x2a, 0x67, 0x81, 0x2b, 0x66, 0x81, 0x2b, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/7/payloads/cbui/gfx/splash.c… PS7, Line 55: 0x67, 0x81, 0x2b, 0x66, 0x81, 0x2c, 0x65, 0x81, 0x2d, 0x65, 0x81, 0x2c, 0x65, 0x81, 0x2d, 0x64, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/7/payloads/cbui/gfx/splash.c… PS7, Line 56: 0x81, 0x2e, 0x63, 0x81, 0x2f, 0x63, 0x81, 0x2f, 0x62, 0x81, 0x30, 0x61, 0x81, 0x30, 0x62, 0x81, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/7/payloads/cbui/gfx/splash.c… PS7, Line 57: 0x30, 0x61, 0x81, 0x31, 0x60, 0x81, 0x32, 0x5f, 0x81, 0x06, 0x0d, 0x1e, 0x5f, 0x80, 0xfa, 0x1f, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/7/payloads/cbui/gfx/splash.c… PS7, Line 58: 0x18, 0x5e, 0x80, 0xf3, 0x29, 0x16, 0x5d, 0x80, 0xed, 0x31, 0x15, 0x5c, 0x80, 0xe8, 0x38, 0x14, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/7/payloads/cbui/gfx/splash.c… PS7, Line 59: 0x5c, 0x80, 0xe2, 0x3e, 0x14, 0x5b, 0x80, 0xde, 0x43, 0x14, 0x5a, 0x80, 0xdb, 0x47, 0x13, 0x5b, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/7/payloads/cbui/gfx/splash.c… PS7, Line 60: 0x80, 0xd7, 0x4a, 0x14, 0x5a, 0x80, 0xd3, 0x4f, 0x14, 0x5a, 0x80, 0xcf, 0x53, 0x14, 0x59, 0x80, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/7/payloads/cbui/gfx/splash.c… PS7, Line 61: 0xcc, 0x56, 0x15, 0x59, 0x80, 0xc9, 0x58, 0x16, 0x59, 0x80, 0xc5, 0x5c, 0x16, 0x58, 0x80, 0xc2, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/7/payloads/cbui/gfx/splash.c… PS7, Line 62: 0x5f, 0x18, 0x57, 0x80, 0xbf, 0x61, 0x19, 0x57, 0x80, 0xbb, 0x64, 0x1a, 0x58, 0x80, 0xb7, 0x66, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/7/payloads/cbui/gfx/splash.c… PS7, Line 63: 0x1b, 0x58, 0x80, 0xb3, 0x6a, 0x1b, 0x58, 0x80, 0xb0, 0x6c, 0x1c, 0x59, 0x80, 0xab, 0x6f, 0x1d, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/7/payloads/cbui/gfx/splash.c… PS7, Line 64: 0x5a, 0x80, 0xa7, 0x71, 0x1e, 0x5a, 0x80, 0xa4, 0x73, 0x1f, 0x5b, 0x80, 0x9f, 0x76, 0x20, 0x5c, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/7/payloads/cbui/gfx/splash.c… PS7, Line 65: 0x80, 0x9b, 0x78, 0x21, 0x5d, 0x80, 0x97, 0x7a, 0x22, 0x5d, 0x80, 0x94, 0x4e, 0x11, 0x1b, 0x24, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/7/payloads/cbui/gfx/splash.c… PS7, Line 66: 0x5d, 0x80, 0x8f, 0x48, 0x1f, 0x16, 0x25, 0x5d, 0x80, 0x8c, 0x44, 0x28, 0x13, 0x26, 0x5d, 0x80, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/7/payloads/cbui/gfx/splash.c… PS7, Line 67: 0x89, 0x41, 0x2f, 0x11, 0x27, 0x5d, 0x80, 0x86, 0x3e, 0x35, 0x10, 0x28, 0x5d, 0x80, 0x83, 0x3c, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/7/payloads/cbui/gfx/splash.c… PS7, Line 68: 0x3b, 0x0e, 0x29, 0x5d, 0x80, 0x80, 0x3a, 0x3f, 0x0d, 0x2b, 0x5d, 0x50, 0x00, 0x2b, 0x38, 0x44, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/7/payloads/cbui/gfx/splash.c… PS7, Line 69: 0x0c, 0x2d, 0x5c, 0x4d, 0x02, 0x29, 0x36, 0x48, 0x0c, 0x2e, 0x5c, 0x4b, 0x03, 0x27, 0x35, 0x4c, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/7/payloads/cbui/gfx/splash.c… PS7, Line 70: 0x0b, 0x2f, 0x5b, 0x49, 0x04, 0x26, 0x33, 0x1c, 0x0d, 0x25, 0x0b, 0x30, 0x5b, 0x46, 0x06, 0x24, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/7/payloads/cbui/gfx/splash.c… PS7, Line 71: 0x32, 0x18, 0x18, 0x21, 0x0b, 0x31, 0x5b, 0x44, 0x06, 0x23, 0x31, 0x16, 0x1e, 0x20, 0x0b, 0x33, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/7/payloads/cbui/gfx/splash.c… PS7, Line 72: 0x59, 0x42, 0x08, 0x21, 0x30, 0x14, 0x24, 0x1e, 0x0c, 0x34, 0x59, 0x40, 0x08, 0x20, 0x2f, 0x13, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/7/payloads/cbui/gfx/splash.c… PS7, Line 73: 0x29, 0x1d, 0x0c, 0x35, 0x58, 0x3e, 0x0a, 0x1e, 0x2e, 0x12, 0x2d, 0x1d, 0x0c, 0x36, 0x58, 0x3b, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/7/payloads/cbui/gfx/splash.c… PS7, Line 74: 0x0b, 0x1d, 0x2d, 0x11, 0x31, 0x1c, 0x0d, 0x37, 0x57, 0x3a, 0x0c, 0x1b, 0x2d, 0x10, 0x34, 0x1c, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/7/payloads/cbui/gfx/splash.c… PS7, Line 75: 0x0c, 0x38, 0x58, 0x37, 0x0d, 0x1a, 0x2c, 0x0f, 0x38, 0x1b, 0x0d, 0x39, 0x57, 0x36, 0x0d, 0x19, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/7/payloads/cbui/gfx/splash.c… PS7, Line 76: 0x2b, 0x0f, 0x3a, 0x1b, 0x0e, 0x39, 0x57, 0x34, 0x0f, 0x17, 0x2b, 0x0e, 0x3d, 0x1b, 0x0e, 0x3a, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/7/payloads/cbui/gfx/splash.c… PS7, Line 77: 0x57, 0x31, 0x10, 0x16, 0x2a, 0x0e, 0x40, 0x1a, 0x0f, 0x3a, 0x57, 0x30, 0x10, 0x15, 0x2a, 0x0c, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/7/payloads/cbui/gfx/splash.c… PS7, Line 78: 0x43, 0x1a, 0x10, 0x3a, 0x57, 0x2e, 0x11, 0x14, 0x29, 0x0c, 0x45, 0x1a, 0x11, 0x3b, 0x57, 0x2c, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/7/payloads/cbui/gfx/splash.c… PS7, Line 79: 0x11, 0x13, 0x29, 0x0b, 0x48, 0x19, 0x12, 0x3b, 0x57, 0x2a, 0x13, 0x12, 0x28, 0x0a, 0x4a, 0x19, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/7/payloads/cbui/gfx/splash.c… PS7, Line 80: 0x12, 0x3c, 0x57, 0x29, 0x13, 0x11, 0x27, 0x0b, 0x4b, 0x19, 0x13, 0x3c, 0x57, 0x27, 0x14, 0x10, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/7/payloads/cbui/gfx/splash.c… PS7, Line 81: 0x27, 0x0a, 0x4d, 0x19, 0x14, 0x3c, 0x57, 0x26, 0x14, 0x0f, 0x27, 0x09, 0x50, 0x18, 0x15, 0x3b, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/7/payloads/cbui/gfx/splash.c… PS7, Line 82: 0x58, 0x25, 0x14, 0x0f, 0x25, 0x09, 0x52, 0x18, 0x16, 0x3b, 0x58, 0x23, 0x15, 0x0e, 0x25, 0x08, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/7/payloads/cbui/gfx/splash.c… PS7, Line 83: 0x54, 0x17, 0x18, 0x3b, 0x58, 0x22, 0x15, 0x0d, 0x25, 0x08, 0x55, 0x17, 0x19, 0x3a, 0x59, 0x20, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/7/payloads/cbui/gfx/splash.c… PS7, Line 84: 0x16, 0x0c, 0x25, 0x07, 0x57, 0x17, 0x1a, 0x3a, 0x59, 0x1f, 0x16, 0x0c, 0x24, 0x06, 0x59, 0x17, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/7/payloads/cbui/gfx/splash.c… PS7, Line 85: 0x1a, 0x3a, 0x5a, 0x1d, 0x17, 0x0b, 0x24, 0x06, 0x5a, 0x16, 0x1c, 0x39, 0x5b, 0x1c, 0x17, 0x0a, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/7/payloads/cbui/gfx/splash.c… PS7, Line 86: 0x25, 0x04, 0x5c, 0x16, 0x1d, 0x39, 0x5b, 0x1b, 0x17, 0x0a, 0x26, 0x00, 0x5f, 0x16, 0x1e, 0x38, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/7/payloads/cbui/gfx/splash.c… PS7, Line 87: 0x5c, 0x19, 0x18, 0x09, 0x80, 0x88, 0x15, 0x20, 0x37, 0x5d, 0x18, 0x18, 0x09, 0x80, 0x87, 0x16, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/7/payloads/cbui/gfx/splash.c… PS7, Line 88: 0x21, 0x36, 0x5e, 0x16, 0x19, 0x08, 0x80, 0x88, 0x15, 0x23, 0x35, 0x5f, 0x15, 0x19, 0x07, 0x80, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/7/payloads/cbui/gfx/splash.c… PS7, Line 89: 0x89, 0x15, 0x24, 0x34, 0x60, 0x14, 0x19, 0x07, 0x80, 0x89, 0x15, 0x25, 0x33, 0x61, 0x12, 0x1a, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/7/payloads/cbui/gfx/splash.c… PS7, Line 90: 0x06, 0x80, 0x8a, 0x14, 0x27, 0x31, 0x62, 0x12, 0x19, 0x07, 0x80, 0x8a, 0x14, 0x28, 0x30, 0x63, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/7/payloads/cbui/gfx/splash.c… PS7, Line 91: 0x11, 0x19, 0x06, 0x80, 0x8a, 0x14, 0x2a, 0x2f, 0x64, 0x10, 0x19, 0x06, 0x80, 0x8a, 0x14, 0x2b, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/7/payloads/cbui/gfx/splash.c… PS7, Line 92: 0x2d, 0x66, 0x0e, 0x1a, 0x05, 0x80, 0x8b, 0x13, 0x2d, 0x2b, 0x68, 0x0d, 0x1a, 0x05, 0x80, 0x8b, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/7/payloads/cbui/gfx/splash.c… PS7, Line 93: 0x13, 0x2f, 0x29, 0x68, 0x0d, 0x1a, 0x04, 0x80, 0x8b, 0x13, 0x31, 0x27, 0x6a, 0x0c, 0x19, 0x05, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/7/payloads/cbui/gfx/splash.c… PS7, Line 94: 0x80, 0x8b, 0x13, 0x32, 0x25, 0x6c, 0x0a, 0x1a, 0x04, 0x80, 0x8c, 0x12, 0x17, 0x06, 0x16, 0x22, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/7/payloads/cbui/gfx/splash.c… PS7, Line 95: 0x6d, 0x0a, 0x1a, 0x04, 0x80, 0x8b, 0x13, 0x15, 0x0b, 0x15, 0x1f, 0x6f, 0x09, 0x1a, 0x04, 0x80, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/7/payloads/cbui/gfx/splash.c… PS7, Line 96: 0x8b, 0x12, 0x14, 0x0f, 0x15, 0x1b, 0x72, 0x08, 0x1a, 0x03, 0x80, 0x8c, 0x12, 0x12, 0x13, 0x15, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/7/payloads/cbui/gfx/splash.c… PS7, Line 97: 0x17, 0x74, 0x08, 0x1a, 0x03, 0x80, 0x8b, 0x12, 0x11, 0x16, 0x18, 0x10, 0x78, 0x06, 0x1a, 0x04, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/7/payloads/cbui/gfx/splash.c… PS7, Line 98: 0x80, 0x8b, 0x12, 0x10, 0x19, 0x1b, 0x07, 0x7d, 0x05, 0x1a, 0x03, 0x80, 0x8b, 0x12, 0x10, 0x1b, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/7/payloads/cbui/gfx/splash.c… PS7, Line 99: 0x80, 0xa0, 0x05, 0x1a, 0x03, 0x80, 0x8b, 0x12, 0x0e, 0x1e, 0x80, 0xa0, 0x04, 0x1a, 0x03, 0x80, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/7/payloads/cbui/gfx/splash.c… PS7, Line 100: 0x8b, 0x11, 0x0e, 0x20, 0x80, 0x9f, 0x04, 0x1a, 0x02, 0x80, 0x8b, 0x11, 0x0e, 0x22, 0x80, 0x9d, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/7/payloads/cbui/gfx/splash.c… PS7, Line 101: 0x05, 0x1a, 0x02, 0x80, 0x8b, 0x11, 0x0d, 0x24, 0x80, 0x9b, 0x06, 0x1a, 0x02, 0x80, 0x8a, 0x11, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/7/payloads/cbui/gfx/splash.c… PS7, Line 102: 0x0c, 0x26, 0x80, 0x9b, 0x05, 0x1b, 0x02, 0x80, 0x8a, 0x11, 0x0b, 0x28, 0x80, 0x99, 0x06, 0x1b, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/7/payloads/cbui/gfx/splash.c… PS7, Line 103: 0x02, 0x80, 0x8a, 0x10, 0x0b, 0x2a, 0x80, 0x97, 0x07, 0x1b, 0x01, 0x80, 0x8a, 0x10, 0x0b, 0x2c, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/7/payloads/cbui/gfx/splash.c… PS7, Line 104: 0x80, 0x95, 0x08, 0x1b, 0x01, 0x80, 0x8a, 0x10, 0x0a, 0x2d, 0x80, 0x95, 0x08, 0x1c, 0x00, 0x80, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/7/payloads/cbui/gfx/splash.c… PS7, Line 105: 0x89, 0x10, 0x0a, 0x2f, 0x80, 0x93, 0x09, 0x1c, 0x00, 0x80, 0x89, 0x10, 0x09, 0x12, 0x06, 0x16, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/7/payloads/cbui/gfx/splash.c… PS7, Line 106: 0x80, 0x91, 0x0b, 0x1c, 0x00, 0x80, 0x88, 0x10, 0x09, 0x10, 0x0b, 0x15, 0x80, 0x8f, 0x0c, 0x80, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/7/payloads/cbui/gfx/splash.c… PS7, Line 107: 0xa6, 0x0f, 0x09, 0x0f, 0x0f, 0x13, 0x80, 0x8e, 0x0d, 0x80, 0xa6, 0x0f, 0x08, 0x0f, 0x11, 0x13, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/7/payloads/cbui/gfx/splash.c… PS7, Line 108: 0x80, 0x8b, 0x0f, 0x80, 0xa5, 0x0f, 0x08, 0x0e, 0x14, 0x12, 0x7b, 0x02, 0x0a, 0x11, 0x80, 0xa5, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/7/payloads/cbui/gfx/splash.c… PS7, Line 109: 0x0e, 0x08, 0x0e, 0x16, 0x12, 0x78, 0x21, 0x80, 0xa4, 0x0f, 0x07, 0x0e, 0x18, 0x11, 0x76, 0x23, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/7/payloads/cbui/gfx/splash.c… PS7, Line 110: 0x80, 0xa4, 0x0e, 0x07, 0x0e, 0x1a, 0x11, 0x71, 0x27, 0x80, 0xa4, 0x0d, 0x07, 0x0e, 0x1c, 0x10, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/7/payloads/cbui/gfx/splash.c… PS7, Line 111: 0x6d, 0x2b, 0x80, 0xa3, 0x0e, 0x06, 0x0e, 0x1d, 0x10, 0x68, 0x30, 0x80, 0xa3, 0x0d, 0x06, 0x0e, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/7/payloads/cbui/gfx/splash.c… PS7, Line 112: 0x1f, 0x10, 0x5e, 0x39, 0x80, 0xa2, 0x0d, 0x06, 0x0e, 0x20, 0x10, 0x4d, 0x4a, 0x80, 0xa2, 0x0d, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/7/payloads/cbui/gfx/splash.c… PS7, Line 113: 0x05, 0x0e, 0x22, 0x0f, 0x44, 0x54, 0x80, 0xa1, 0x0c, 0x05, 0x0d, 0x25, 0x0d, 0x43, 0x56, 0x80, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/7/payloads/cbui/gfx/splash.c… PS7, Line 114: 0xa0, 0x0c, 0x05, 0x0d, 0x26, 0x0c, 0x43, 0x57, 0x80, 0xa0, 0x0c, 0x04, 0x0d, 0x26, 0x0c, 0x42, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/7/payloads/cbui/gfx/splash.c… PS7, Line 115: 0x59, 0x80, 0x9f, 0x0c, 0x05, 0x0c, 0x26, 0x0c, 0x42, 0x5a, 0x80, 0x9f, 0x0b, 0x05, 0x0c, 0x26, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/7/payloads/cbui/gfx/splash.c… PS7, Line 116: 0x0c, 0x42, 0x5b, 0x80, 0x9f, 0x0b, 0x04, 0x0c, 0x26, 0x0c, 0x42, 0x5d, 0x80, 0x9d, 0x0b, 0x04, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/7/payloads/cbui/gfx/splash.c… PS7, Line 117: 0x0c, 0x26, 0x0b, 0x44, 0x5d, 0x80, 0x9d, 0x0a, 0x04, 0x0c, 0x26, 0x0b, 0x44, 0x5e, 0x80, 0x9c, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/7/payloads/cbui/gfx/splash.c… PS7, Line 118: 0x0b, 0x03, 0x0c, 0x26, 0x0b, 0x44, 0x5f, 0x80, 0x9c, 0x0a, 0x03, 0x0c, 0x26, 0x0b, 0x44, 0x60, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/7/payloads/cbui/gfx/splash.c… PS7, Line 119: 0x80, 0x9c, 0x09, 0x03, 0x0c, 0x26, 0x0b, 0x45, 0x61, 0x80, 0x9a, 0x09, 0x04, 0x0b, 0x26, 0x0b, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/7/payloads/cbui/gfx/splash.c… PS7, Line 120: 0x45, 0x62, 0x80, 0x9a, 0x09, 0x03, 0x0b, 0x26, 0x0b, 0x45, 0x63, 0x80, 0x99, 0x09, 0x03, 0x0b, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/7/payloads/cbui/gfx/splash.c… PS7, Line 121: 0x26, 0x0b, 0x46, 0x64, 0x80, 0x98, 0x08, 0x03, 0x0b, 0x26, 0x0b, 0x46, 0x65, 0x80, 0x98, 0x08, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/7/payloads/cbui/gfx/splash.c… PS7, Line 122: 0x02, 0x0b, 0x26, 0x0b, 0x47, 0x65, 0x80, 0x97, 0x08, 0x02, 0x0c, 0x25, 0x0a, 0x48, 0x67, 0x80, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/7/payloads/cbui/gfx/splash.c… PS7, Line 123: 0x96, 0x07, 0x03, 0x0b, 0x25, 0x0a, 0x48, 0x68, 0x80, 0x96, 0x07, 0x02, 0x0b, 0x25, 0x0a, 0x49, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/7/payloads/cbui/gfx/splash.c… PS7, Line 124: 0x33, 0x01, 0x32, 0x80, 0x95, 0x07, 0x02, 0x0b, 0x25, 0x0a, 0x49, 0x34, 0x07, 0x2d, 0x80, 0x94, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/7/payloads/cbui/gfx/splash.c… PS7, Line 125: 0x06, 0x02, 0x0b, 0x25, 0x0a, 0x49, 0x34, 0x0b, 0x2a, 0x80, 0x94, 0x06, 0x02, 0x0a, 0x25, 0x0a, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/7/payloads/cbui/gfx/splash.c… PS7, Line 126: 0x4a, 0x1b, 0x00, 0x17, 0x0f, 0x27, 0x80, 0x92, 0x06, 0x02, 0x0a, 0x25, 0x0a, 0x4a, 0x1b, 0x02, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/7/payloads/cbui/gfx/splash.c… PS7, Line 127: 0x16, 0x0f, 0x27, 0x80, 0x92, 0x13, 0x25, 0x0a, 0x4a, 0x19, 0x05, 0x15, 0x10, 0x28, 0x80, 0x91, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/7/payloads/cbui/gfx/splash.c… PS7, Line 128: 0x12, 0x25, 0x0a, 0x4b, 0x18, 0x07, 0x14, 0x10, 0x28, 0x80, 0x90, 0x12, 0x25, 0x0a, 0x4b, 0x17, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/7/payloads/cbui/gfx/splash.c… PS7, Line 129: 0x0a, 0x12, 0x11, 0x29, 0x80, 0x8f, 0x11, 0x25, 0x09, 0x4c, 0x17, 0x0b, 0x12, 0x11, 0x29, 0x80, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/7/payloads/cbui/gfx/splash.c… PS7, Line 130: 0x8f, 0x10, 0x25, 0x09, 0x4d, 0x15, 0x0e, 0x11, 0x11, 0x2a, 0x6d, 0x00, 0x1e, 0x10, 0x24, 0x0a, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/7/payloads/cbui/gfx/splash.c… PS7, Line 131: 0x4d, 0x15, 0x10, 0x0f, 0x12, 0x2b, 0x6b, 0x01, 0x1e, 0x0f, 0x24, 0x0a, 0x4d, 0x15, 0x12, 0x0e, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/7/payloads/cbui/gfx/splash.c… PS7, Line 132: 0x11, 0x2c, 0x6a, 0x01, 0x1f, 0x0e, 0x24, 0x0a, 0x4e, 0x15, 0x12, 0x0e, 0x11, 0x2d, 0x68, 0x02, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/7/payloads/cbui/gfx/splash.c… PS7, Line 133: 0x1f, 0x0d, 0x24, 0x0a, 0x4e, 0x16, 0x13, 0x04, 0x1a, 0x2d, 0x67, 0x02, 0x1f, 0x0d, 0x24, 0x0a, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/7/payloads/cbui/gfx/splash.c… PS7, Line 134: 0x4e, 0x17, 0x14, 0x00, 0x1d, 0x2e, 0x65, 0x03, 0x1f, 0x0c, 0x24, 0x0a, 0x4e, 0x19, 0x32, 0x2f, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/7/payloads/cbui/gfx/splash.c… PS7, Line 135: 0x63, 0x03, 0x20, 0x0b, 0x24, 0x0a, 0x4f, 0x1a, 0x30, 0x31, 0x60, 0x05, 0x20, 0x0a, 0x24, 0x09, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/7/payloads/cbui/gfx/splash.c… PS7, Line 136: 0x50, 0x1b, 0x31, 0x31, 0x5e, 0x06, 0x20, 0x09, 0x24, 0x09, 0x50, 0x1c, 0x32, 0x30, 0x5d, 0x06, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/7/payloads/cbui/gfx/splash.c… PS7, Line 137: 0x21, 0x07, 0x25, 0x09, 0x50, 0x1e, 0x32, 0x12, 0x00, 0x1c, 0x5b, 0x07, 0x22, 0x05, 0x25, 0x09, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/7/payloads/cbui/gfx/splash.c… PS7, Line 138: 0x51, 0x1e, 0x34, 0x0e, 0x03, 0x1c, 0x59, 0x07, 0x24, 0x01, 0x27, 0x09, 0x51, 0x20, 0x34, 0x0b, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/7/payloads/cbui/gfx/splash.c… PS7, Line 139: 0x05, 0x1d, 0x56, 0x09, 0x4d, 0x09, 0x51, 0x21, 0x36, 0x07, 0x08, 0x1d, 0x54, 0x0a, 0x4c, 0x09, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/7/payloads/cbui/gfx/splash.c… PS7, Line 140: 0x51, 0x23, 0x36, 0x04, 0x0b, 0x1d, 0x52, 0x0a, 0x4b, 0x0a, 0x51, 0x23, 0x38, 0x00, 0x0e, 0x1e, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/7/payloads/cbui/gfx/splash.c… PS7, Line 141: 0x4f, 0x0c, 0x4a, 0x0a, 0x52, 0x23, 0x49, 0x1f, 0x4c, 0x0c, 0x4a, 0x0a, 0x52, 0x23, 0x4a, 0x20, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/7/payloads/cbui/gfx/splash.c… PS7, Line 142: 0x49, 0x0e, 0x49, 0x09, 0x53, 0x23, 0x4c, 0x20, 0x47, 0x0f, 0x48, 0x09, 0x53, 0x23, 0x4e, 0x21, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/7/payloads/cbui/gfx/splash.c… PS7, Line 143: 0x43, 0x10, 0x48, 0x09, 0x53, 0x23, 0x4f, 0x22, 0x40, 0x12, 0x47, 0x09, 0x53, 0x24, 0x50, 0x23, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/7/payloads/cbui/gfx/splash.c… PS7, Line 144: 0x3c, 0x13, 0x47, 0x09, 0x54, 0x23, 0x51, 0x24, 0x39, 0x15, 0x46, 0x09, 0x54, 0x15, 0x06, 0x06, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/7/payloads/cbui/gfx/splash.c… PS7, Line 145: 0x53, 0x25, 0x35, 0x17, 0x45, 0x09, 0x54, 0x15, 0x0c, 0x01, 0x20, 0x01, 0x2f, 0x28, 0x31, 0x18, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/7/payloads/cbui/gfx/splash.c… PS7, Line 146: 0x44, 0x0a, 0x54, 0x16, 0x2a, 0x0c, 0x27, 0x2d, 0x2b, 0x1b, 0x43, 0x0a, 0x54, 0x17, 0x28, 0x10, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/7/payloads/cbui/gfx/splash.c… PS7, Line 147: 0x24, 0x30, 0x26, 0x1e, 0x42, 0x0a, 0x54, 0x17, 0x27, 0x06, 0x06, 0x06, 0x21, 0x35, 0x1f, 0x20, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/7/payloads/cbui/gfx/splash.c… PS7, Line 148: 0x42, 0x09, 0x55, 0x18, 0x25, 0x05, 0x0b, 0x05, 0x1e, 0x3b, 0x16, 0x25, 0x41, 0x09, 0x55, 0x19, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/7/payloads/cbui/gfx/splash.c… PS7, Line 149: 0x24, 0x04, 0x10, 0x03, 0x1c, 0x44, 0x05, 0x2e, 0x40, 0x09, 0x55, 0x19, 0x24, 0x03, 0x13, 0x03, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/7/payloads/cbui/gfx/splash.c… PS7, Line 150: 0x1a, 0x79, 0x40, 0x09, 0x56, 0x19, 0x23, 0x03, 0x08, 0x03, 0x08, 0x03, 0x17, 0x7b, 0x3f, 0x09, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/7/payloads/cbui/gfx/splash.c… PS7, Line 151: 0x56, 0x1a, 0x22, 0x03, 0x06, 0x09, 0x06, 0x03, 0x16, 0x7a, 0x3e, 0x0a, 0x56, 0x1b, 0x22, 0x02, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/7/payloads/cbui/gfx/splash.c… PS7, Line 152: 0x05, 0x0d, 0x05, 0x03, 0x15, 0x7a, 0x3d, 0x0a, 0x56, 0x1c, 0x21, 0x02, 0x05, 0x0f, 0x05, 0x02, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/7/payloads/cbui/gfx/splash.c… PS7, Line 153: 0x15, 0x7a, 0x3c, 0x0e, 0x52, 0x1d, 0x21, 0x02, 0x04, 0x11, 0x05, 0x02, 0x15, 0x78, 0x3c, 0x14, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/7/payloads/cbui/gfx/splash.c… PS7, Line 154: 0x4c, 0x1d, 0x21, 0x02, 0x04, 0x13, 0x04, 0x02, 0x15, 0x78, 0x3b, 0x1a, 0x46, 0x1e, 0x21, 0x02, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/7/payloads/cbui/gfx/splash.c… PS7, Line 155: 0x04, 0x14, 0x04, 0x02, 0x14, 0x78, 0x3a, 0x23, 0x3d, 0x21, 0x1f, 0x01, 0x04, 0x15, 0x04, 0x02, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/7/payloads/cbui/gfx/splash.c… PS7, Line 156: 0x14, 0x77, 0x3a, 0x3b, 0x25, 0x25, 0x1c, 0x01, 0x03, 0x17, 0x03, 0x02, 0x14, 0x77, 0x38, 0x3b, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/7/payloads/cbui/gfx/splash.c… PS7, Line 157: 0x26, 0x28, 0x19, 0x02, 0x03, 0x17, 0x04, 0x01, 0x14, 0x77, 0x37, 0x3b, 0x26, 0x2c, 0x16, 0x02, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/7/payloads/cbui/gfx/splash.c… PS7, Line 158: 0x03, 0x17, 0x04, 0x02, 0x13, 0x76, 0x37, 0x3a, 0x27, 0x30, 0x13, 0x02, 0x03, 0x18, 0x03, 0x02, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/7/payloads/cbui/gfx/splash.c… PS7, Line 159: 0x13, 0x76, 0x36, 0x3a, 0x27, 0x31, 0x13, 0x02, 0x03, 0x18, 0x03, 0x02, 0x13, 0x76, 0x35, 0x39, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/7/payloads/cbui/gfx/splash.c… PS7, Line 160: 0x28, 0x32, 0x13, 0x02, 0x03, 0x18, 0x03, 0x02, 0x13, 0x76, 0x33, 0x39, 0x28, 0x34, 0x13, 0x02, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/7/payloads/cbui/gfx/splash.c… PS7, Line 161: 0x03, 0x18, 0x03, 0x02, 0x16, 0x72, 0x33, 0x39, 0x28, 0x35, 0x13, 0x02, 0x03, 0x17, 0x04, 0x01, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/7/payloads/cbui/gfx/splash.c… PS7, Line 162: 0x19, 0x70, 0x32, 0x38, 0x29, 0x36, 0x13, 0x02, 0x03, 0x17, 0x03, 0x02, 0x1c, 0x6d, 0x31, 0x37, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/7/payloads/cbui/gfx/splash.c… PS7, Line 163: 0x2a, 0x37, 0x14, 0x01, 0x04, 0x16, 0x03, 0x02, 0x1e, 0x6a, 0x30, 0x37, 0x2b, 0x38, 0x14, 0x02, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/7/payloads/cbui/gfx/splash.c… PS7, Line 164: 0x03, 0x15, 0x04, 0x02, 0x21, 0x67, 0x2f, 0x36, 0x2c, 0x3a, 0x13, 0x02, 0x04, 0x14, 0x03, 0x03, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/7/payloads/cbui/gfx/splash.c… PS7, Line 165: 0x21, 0x67, 0x2e, 0x35, 0x2d, 0x3b, 0x14, 0x02, 0x04, 0x12, 0x04, 0x02, 0x22, 0x67, 0x2d, 0x34, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/7/payloads/cbui/gfx/splash.c… PS7, Line 166: 0x2e, 0x3c, 0x14, 0x02, 0x04, 0x11, 0x04, 0x03, 0x21, 0x67, 0x2c, 0x33, 0x2f, 0x3e, 0x15, 0x02, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/7/payloads/cbui/gfx/splash.c… PS7, Line 167: 0x05, 0x0e, 0x05, 0x02, 0x22, 0x67, 0x2b, 0x32, 0x30, 0x40, 0x14, 0x03, 0x05, 0x0b, 0x06, 0x03, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/7/payloads/cbui/gfx/splash.c… PS7, Line 168: 0x22, 0x67, 0x2a, 0x30, 0x32, 0x40, 0x16, 0x02, 0x07, 0x07, 0x07, 0x03, 0x23, 0x67, 0x28, 0x2f, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/7/payloads/cbui/gfx/splash.c… PS7, Line 169: 0x34, 0x3f, 0x19, 0x03, 0x14, 0x03, 0x24, 0x67, 0x27, 0x2d, 0x35, 0x40, 0x1b, 0x03, 0x12, 0x03, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/7/payloads/cbui/gfx/splash.c… PS7, Line 170: 0x25, 0x67, 0x29, 0x28, 0x37, 0x40, 0x1d, 0x04, 0x0e, 0x04, 0x26, 0x66, 0x2d, 0x21, 0x3a, 0x3f, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/7/payloads/cbui/gfx/splash.c… PS7, Line 171: 0x20, 0x05, 0x0a, 0x05, 0x26, 0x67, 0x31, 0x18, 0x3e, 0x3f, 0x23, 0x12, 0x28, 0x67, 0x39, 0x07, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/7/payloads/cbui/gfx/splash.c… PS7, Line 172: 0x45, 0x40, 0x25, 0x0f, 0x29, 0x68, 0x80, 0x86, 0x3f, 0x2b, 0x08, 0x2c, 0x68, 0x80, 0x85, 0x3f, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/7/payloads/cbui/gfx/splash.c… PS7, Line 173: 0x53, 0x05, 0x08, 0x68, 0x80, 0x83, 0x42, 0x51, 0x0d, 0x00, 0x69, 0x80, 0x82, 0x43, 0x51, 0x78, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/7/payloads/cbui/gfx/splash.c… PS7, Line 174: 0x80, 0x80, 0x46, 0x4f, 0x78, 0x80, 0x80, 0x3d, 0x04, 0x04, 0x4e, 0x77, 0x80, 0x80, 0x3b, 0x0c, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/7/payloads/cbui/gfx/splash.c… PS7, Line 175: 0x01, 0x4d, 0x75, 0x80, 0x81, 0x3c, 0x0c, 0x02, 0x4b, 0x75, 0x80, 0x80, 0x3e, 0x0c, 0x02, 0x4a, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/7/payloads/cbui/gfx/splash.c… PS7, Line 176: 0x75, 0x80, 0x80, 0x3f, 0x0c, 0x03, 0x0e, 0x00, 0x38, 0x75, 0x7f, 0x41, 0x0c, 0x03, 0x0b, 0x04, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/7/payloads/cbui/gfx/splash.c… PS7, Line 177: 0x36, 0x76, 0x7e, 0x42, 0x0c, 0x04, 0x09, 0x06, 0x35, 0x75, 0x7d, 0x44, 0x0c, 0x05, 0x05, 0x0b, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/7/payloads/cbui/gfx/splash.c… PS7, Line 178: 0x34, 0x74, 0x7b, 0x46, 0x0c, 0x06, 0x02, 0x06, 0x00, 0x06, 0x33, 0x74, 0x7a, 0x34, 0x01, 0x10, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/7/payloads/cbui/gfx/splash.c… PS7, Line 179: 0x0d, 0x0e, 0x03, 0x05, 0x33, 0x73, 0x78, 0x35, 0x04, 0x0e, 0x0d, 0x0d, 0x04, 0x07, 0x31, 0x73, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/7/payloads/cbui/gfx/splash.c… PS7, Line 180: 0x76, 0x36, 0x06, 0x0c, 0x0f, 0x0a, 0x08, 0x06, 0x31, 0x72, 0x74, 0x37, 0x08, 0x08, 0x15, 0x06, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/7/payloads/cbui/gfx/splash.c… PS7, Line 181: 0x0a, 0x05, 0x31, 0x72, 0x73, 0x37, 0x0a, 0x04, 0x1a, 0x03, 0x0c, 0x04, 0x32, 0x72, 0x70, 0x38, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/7/payloads/cbui/gfx/splash.c… PS7, Line 182: 0x0d, 0x01, 0x1d, 0x00, 0x0d, 0x04, 0x32, 0x72, 0x6e, 0x39, 0x3e, 0x03, 0x1a, 0x04, 0x13, 0x72, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/7/payloads/cbui/gfx/splash.c… PS7, Line 183: 0x6b, 0x3a, 0x40, 0x01, 0x12, 0x0d, 0x13, 0x73, 0x68, 0x3c, 0x40, 0x01, 0x12, 0x0e, 0x12, 0x73, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/7/payloads/cbui/gfx/splash.c… PS7, Line 184: 0x66, 0x3f, 0x3e, 0x02, 0x11, 0x10, 0x11, 0x74, 0x62, 0x42, 0x3d, 0x03, 0x11, 0x10, 0x10, 0x76, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/7/payloads/cbui/gfx/splash.c… PS7, Line 185: 0x5f, 0x45, 0x3b, 0x04, 0x11, 0x11, 0x0d, 0x79, 0x5c, 0x48, 0x39, 0x05, 0x10, 0x13, 0x0b, 0x7b, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/7/payloads/cbui/gfx/splash.c… PS7, Line 186: 0x59, 0x4b, 0x38, 0x05, 0x10, 0x13, 0x09, 0x7f, 0x54, 0x4f, 0x36, 0x06, 0x10, 0x14, 0x06, 0x80, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/7/payloads/cbui/gfx/splash.c… PS7, Line 187: 0x82, 0x50, 0x53, 0x34, 0x06, 0x10, 0x16, 0x03, 0x80, 0x86, 0x4c, 0x55, 0x34, 0x07, 0x0f, 0x17, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/7/payloads/cbui/gfx/splash.c… PS7, Line 188: 0x00, 0x80, 0x89, 0x47, 0x59, 0x17, 0x04, 0x18, 0x09, 0x0b, 0x80, 0xa5, 0x42, 0x5b, 0x15, 0x0a, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/7/payloads/cbui/gfx/splash.c… PS7, Line 189: 0x15, 0x0c, 0x08, 0x80, 0xa8, 0x3b, 0x5f, 0x13, 0x05, 0x02, 0x05, 0x14, 0x0f, 0x04, 0x80, 0xaa, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/7/payloads/cbui/gfx/splash.c… PS7, Line 190: 0x35, 0x62, 0x12, 0x04, 0x08, 0x04, 0x12, 0x80, 0xc3, 0x2c, 0x67, 0x11, 0x03, 0x0c, 0x03, 0x11, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/7/payloads/cbui/gfx/splash.c… PS7, Line 191: 0x80, 0xc8, 0x20, 0x6e, 0x10, 0x02, 0x10, 0x02, 0x11, 0x80, 0xd1, 0x0b, 0x78, 0x10, 0x02, 0x04, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/7/payloads/cbui/gfx/splash.c… PS7, Line 192: 0x07, 0x05, 0x02, 0x10, 0x81, 0x56, 0x10, 0x01, 0x04, 0x0a, 0x03, 0x02, 0x11, 0x81, 0x4e, 0x16, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/7/payloads/cbui/gfx/splash.c… PS7, Line 193: 0x02, 0x03, 0x0c, 0x03, 0x02, 0x14, 0x81, 0x46, 0x1a, 0x01, 0x03, 0x0e, 0x03, 0x01, 0x1a, 0x81, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/7/payloads/cbui/gfx/splash.c… PS7, Line 194: 0x40, 0x19, 0x01, 0x03, 0x10, 0x02, 0x02, 0x19, 0x81, 0x40, 0x19, 0x01, 0x03, 0x10, 0x03, 0x01, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/7/payloads/cbui/gfx/splash.c… PS7, Line 195: 0x19, 0x81, 0x40, 0x19, 0x01, 0x02, 0x12, 0x02, 0x01, 0x19, 0x81, 0x40, 0x19, 0x01, 0x02, 0x12, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/7/payloads/cbui/gfx/splash.c… PS7, Line 196: 0x02, 0x01, 0x19, 0x81, 0x40, 0x19, 0x01, 0x02, 0x12, 0x02, 0x01, 0x19, 0x81, 0x40, 0x19, 0x01, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/7/payloads/cbui/gfx/splash.c… PS7, Line 197: 0x02, 0x12, 0x02, 0x02, 0x18, 0x81, 0x40, 0x19, 0x01, 0x02, 0x12, 0x02, 0x01, 0x19, 0x81, 0x40, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/7/payloads/cbui/gfx/splash.c… PS7, Line 198: 0x19, 0x01, 0x02, 0x12, 0x02, 0x01, 0x19, 0x81, 0x40, 0x19, 0x01, 0x02, 0x11, 0x03, 0x01, 0x19, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/7/payloads/cbui/gfx/splash.c… PS7, Line 199: 0x81, 0x40, 0x19, 0x01, 0x03, 0x10, 0x02, 0x02, 0x19, 0x81, 0x40, 0x19, 0x02, 0x02, 0x0f, 0x03, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/7/payloads/cbui/gfx/splash.c… PS7, Line 200: 0x02, 0x19, 0x81, 0x41, 0x19, 0x01, 0x03, 0x0e, 0x03, 0x01, 0x18, 0x81, 0x4d, 0x0f, 0x02, 0x03, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/7/payloads/cbui/gfx/splash.c… PS7, Line 201: 0x0c, 0x03, 0x02, 0x10, 0x81, 0x55, 0x10, 0x01, 0x04, 0x0a, 0x03, 0x02, 0x10, 0x81, 0x57, 0x10, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/7/payloads/cbui/gfx/splash.c… PS7, Line 202: 0x02, 0x05, 0x04, 0x05, 0x02, 0x11, 0x81, 0x57, 0x11, 0x02, 0x0e, 0x03, 0x11, 0x81, 0x57, 0x12, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/7/payloads/cbui/gfx/splash.c… PS7, Line 203: 0x02, 0x0c, 0x02, 0x12, 0x81, 0x59, 0x12, 0x03, 0x08, 0x03, 0x13, 0x81, 0x59, 0x13, 0x0e, 0x13, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/7/payloads/cbui/gfx/splash.c… PS7, Line 204: 0x81, 0x5b, 0x14, 0x0a, 0x15, 0x81, 0x5b, 0x34, 0x81, 0x5c, 0x34, 0x81, 0x5c, 0x35, 0x81, 0x5a, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/7/payloads/cbui/gfx/splash.c… PS7, Line 205: 0x37, 0x81, 0x58, 0x39, 0x81, 0x56, 0x3a, 0x81, 0x55, 0x3c, 0x81, 0x53, 0x3e, 0x81, 0x52, 0x3f, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/7/payloads/cbui/gfx/splash.c… PS7, Line 206: 0x81, 0x50, 0x40, 0x81, 0x51, 0x3f, 0x81, 0x51, 0x0e, 0x00, 0x1e, 0x00, 0x0e, 0x81, 0x53, 0x0c, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/7/payloads/cbui/gfx/splash.c… PS7, Line 207: 0x03, 0x1b, 0x02, 0x0c, 0x81, 0x55, 0x0a, 0x06, 0x16, 0x07, 0x09, 0x81, 0x57, 0x08, 0x0a, 0x11, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/7/payloads/cbui/gfx/splash.c… PS7, Line 208: 0x0a, 0x07, 0x81, 0x5a, 0x05, 0x0c, 0x0e, 0x0d, 0x05, 0x81, 0x5c, 0x03, 0x0e, 0x0c, 0x0f, 0x03, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/7/payloads/cbui/gfx/splash.c… PS7, Line 209: 0x81, 0x5e, 0x00, 0x10, 0x0c, 0x10, 0x01, 0x81, 0x71, 0x0c, 0x81, 0x84, 0x0c, 0x81, 0x84, 0x0c, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/7/payloads/cbui/gfx/splash.c… PS7, Line 210: 0x81, 0x84, 0x0c, 0x81, 0x84, 0x0c, 0x81, 0x84, 0x0c, 0x81, 0x84, 0x0c, 0x81, 0x85, 0x0a, 0x65,}, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/7/payloads/cbui/gfx/splash.c… PS7, Line 216: unsigned ret; Prefer 'unsigned int' to bare use of 'unsigned' https://review.coreboot.org/c/coreboot/+/23586/7/payloads/cbui/gfx/splash.c… PS7, Line 244: (cbui_logo.heigth > fbinfo->y_resolution)) 'heigth' may be misspelled - perhaps 'height'? https://review.coreboot.org/c/coreboot/+/23586/7/payloads/cbui/gfx/splash.c… PS7, Line 248: offset_y = fbinfo->y_resolution / 2 - cbui_logo.heigth / 2; 'heigth' may be misspelled - perhaps 'height'? https://review.coreboot.org/c/coreboot/+/23586/7/payloads/cbui/gfx/splash.c… PS7, Line 259: for (y = 0; y < cbui_logo.heigth; y ++) { 'heigth' may be misspelled - perhaps 'height'? https://review.coreboot.org/c/coreboot/+/23586/7/payloads/cbui/gfx/splash.c… PS7, Line 259: for (y = 0; y < cbui_logo.heigth; y ++) { space prohibited before that '++' (ctx:WxB) https://review.coreboot.org/c/coreboot/+/23586/7/payloads/cbui/gfx/splash.c… PS7, Line 260: for (x = 0; x < cbui_logo.width; x ++) { space prohibited before that '++' (ctx:WxB) https://review.coreboot.org/c/coreboot/+/23586/7/payloads/cbui/gfx/splash.c… PS7, Line 288: (cbui_logo.heigth > fbinfo->y_resolution)) 'heigth' may be misspelled - perhaps 'height'? https://review.coreboot.org/c/coreboot/+/23586/7/payloads/cbui/gfx/splash.c… PS7, Line 293: offset_y = fbinfo->y_resolution / 2 + cbui_logo.heigth / 2 + height * 2; 'heigth' may be misspelled - perhaps 'height'? https://review.coreboot.org/c/coreboot/+/23586/7/payloads/cbui/gfx/splash.c… PS7, Line 299: for (x = 0; x < cbui_logo.width; x ++) { space prohibited before that '++' (ctx:WxB) https://review.coreboot.org/c/coreboot/+/23586/7/payloads/cbui/gfx/splash.c… PS7, Line 301: for (y = 0; y < height; y ++) { space prohibited before that '++' (ctx:WxB) https://review.coreboot.org/c/coreboot/+/23586/7/payloads/cbui/gfx/vbe.h File payloads/cbui/gfx/vbe.h: https://review.coreboot.org/c/coreboot/+/23586/7/payloads/cbui/gfx/vbe.h@28 PS7, Line 28: { open brace '{' following struct go on the same line https://review.coreboot.org/c/coreboot/+/23586/7/payloads/cbui/gfx/vbe.c File payloads/cbui/gfx/vbe.c: https://review.coreboot.org/c/coreboot/+/23586/7/payloads/cbui/gfx/vbe.c@24 PS7, Line 24: static u8 low_mem[0x1000] __attribute__ ((section (".lowmem"))); space prohibited between function name and open parenthesis '(' https://review.coreboot.org/c/coreboot/+/23586/7/payloads/cbui/gfx/vbe.c@32 PS7, Line 32: memset (vbe, 0, sizeof(*vbe)); space prohibited between function name and open parenthesis '(' https://review.coreboot.org/c/coreboot/+/23586/7/payloads/cbui/gfx/vbe.c@33 PS7, Line 33: memcpy (vbe->signature, "VBE2", 4); space prohibited between function name and open parenthesis '(' https://review.coreboot.org/c/coreboot/+/23586/7/payloads/cbui/lang/de.c File payloads/cbui/lang/de.c: https://review.coreboot.org/c/coreboot/+/23586/7/payloads/cbui/lang/de.c@39 PS7, Line 39: "Kein Framebuffer gefunden. CBUI funktioniert nicht" \ Avoid unnecessary line continuations https://review.coreboot.org/c/coreboot/+/23586/7/payloads/cbui/lang/de.c@44 PS7, Line 44: "Der coreboot framebuffer hat keine physikalische " \ Avoid unnecessary line continuations https://review.coreboot.org/c/coreboot/+/23586/7/payloads/cbui/lang/de.c@47 PS7, Line 47: "Kein Platz auf dem Heap.\nBitte vergrößere den" \ Avoid unnecessary line continuations https://review.coreboot.org/c/coreboot/+/23586/7/payloads/cbui/lang/de.c@50 PS7, Line 50: "Konnte die nuklear Bibliothek nicht intitialisieren.\nBitte" \ Avoid unnecessary line continuations https://review.coreboot.org/c/coreboot/+/23586/7/payloads/cbui/lang/de.c@52 PS7, Line 52: "stelle sicher, das der Framebuffer entweder das RGBX8 oder " \ Avoid unnecessary line continuations https://review.coreboot.org/c/coreboot/+/23586/7/payloads/cbui/lang/de.c@65 PS7, Line 65: "Fehler: Keine CMOS Einträge gefunden. Bitte schalte die " \ Avoid unnecessary line continuations https://review.coreboot.org/c/coreboot/+/23586/7/payloads/cbui/lang/de.c@86 PS7, Line 86: "Fehler: Keine Zeitstempel gefunden. Bitte schalte die " \ Avoid unnecessary line continuations https://review.coreboot.org/c/coreboot/+/23586/7/payloads/cbui/lang/de.c@89 PS7, Line 89: "Fehler: Bootlog nicht gefunden. Bitte schalte die Kconfig " \ Avoid unnecessary line continuations https://review.coreboot.org/c/coreboot/+/23586/7/payloads/cbui/lang/en.c File payloads/cbui/lang/en.c: https://review.coreboot.org/c/coreboot/+/23586/7/payloads/cbui/lang/en.c@38 PS7, Line 38: "No framebuffer found. CBUI doesn't work in text mode.\n" \ Avoid unnecessary line continuations https://review.coreboot.org/c/coreboot/+/23586/7/payloads/cbui/lang/en.c@46 PS7, Line 46: "Failed to init nuklear library.\nMake sure you have enough " \ Avoid unnecessary line continuations https://review.coreboot.org/c/coreboot/+/23586/7/payloads/cbui/lang/en.c@60 PS7, Line 60: "ERROR: No CMOS options found. Please make sure to enable " \ Avoid unnecessary line continuations https://review.coreboot.org/c/coreboot/+/23586/7/payloads/cbui/lang/en.c@81 PS7, Line 81: "ERROR: No timestamps found. Please make sure to enable " \ Avoid unnecessary line continuations https://review.coreboot.org/c/coreboot/+/23586/7/payloads/cbui/lang/en.c@84 PS7, Line 84: "ERROR: Bootlog not found. Please make sure to enable " \ Avoid unnecessary line continuations https://review.coreboot.org/c/coreboot/+/23586/7/payloads/cbui/lang/lang.c File payloads/cbui/lang/lang.c: https://review.coreboot.org/c/coreboot/+/23586/7/payloads/cbui/lang/lang.c@… PS7, Line 50: * To be used for untranslateable items. */ 'untranslateable' may be misspelled - perhaps 'untranslatable'? https://review.coreboot.org/c/coreboot/+/23586/7/payloads/cbui/modules/boot… File payloads/cbui/modules/bootlog_module.c: https://review.coreboot.org/c/coreboot/+/23586/7/payloads/cbui/modules/boot… PS7, Line 66: if (buffer[i] == '\n') { braces {} are not necessary for any arm of this statement https://review.coreboot.org/c/coreboot/+/23586/7/payloads/cbui/modules/boot… PS7, Line 79: } void function return statements are not generally useful https://review.coreboot.org/c/coreboot/+/23586/7/payloads/cbui/modules/cbfs… File payloads/cbui/modules/cbfs_module.c: https://review.coreboot.org/c/coreboot/+/23586/7/payloads/cbui/modules/cbfs… PS7, Line 91: switch (ntohl(type)) { switch and case should be at the same indent https://review.coreboot.org/c/coreboot/+/23586/7/payloads/cbui/modules/cbfs… PS7, Line 140: struct nuklear_group* group = NuklearGroup_new(this->root, "foo* bar" should be "foo *bar" https://review.coreboot.org/c/coreboot/+/23586/7/payloads/cbui/modules/core… File payloads/cbui/modules/coreboot_module.c: https://review.coreboot.org/c/coreboot/+/23586/7/payloads/cbui/modules/core… PS7, Line 262: if (cb_info.framebuffer.tag != 0 ) { space prohibited before that close parenthesis ')' https://review.coreboot.org/c/coreboot/+/23586/7/payloads/cbui/modules/cpui… File payloads/cbui/modules/cpuinfo_module.c: https://review.coreboot.org/c/coreboot/+/23586/7/payloads/cbui/modules/cpui… PS7, Line 35: static const char *intel_cap_edx_flags[] = { static const char * array should probably be static const char * const https://review.coreboot.org/c/coreboot/+/23586/7/payloads/cbui/modules/cpui… PS7, Line 43: static const char *amd_cap_edx_flags[] = { static const char * array should probably be static const char * const https://review.coreboot.org/c/coreboot/+/23586/7/payloads/cbui/modules/cpui… PS7, Line 51: static const char *intel_cap_ecx_flags[] = { static const char * array should probably be static const char * const https://review.coreboot.org/c/coreboot/+/23586/7/payloads/cbui/modules/cpui… PS7, Line 59: static const char *amd_cap_ecx_flags[] = { static const char * array should probably be static const char * const https://review.coreboot.org/c/coreboot/+/23586/7/payloads/cbui/modules/cpui… PS7, Line 67: static const char *intel_cap_extended_edx_flags[] = { static const char * array should probably be static const char * const https://review.coreboot.org/c/coreboot/+/23586/7/payloads/cbui/modules/cpui… PS7, Line 75: static const char *intel_cap_extended_ecx_flags[] = { static const char * array should probably be static const char * const https://review.coreboot.org/c/coreboot/+/23586/7/payloads/cbui/modules/cpui… PS7, Line 83: static const char *amd_cap_extended_edx_flags[] = { static const char * array should probably be static const char * const https://review.coreboot.org/c/coreboot/+/23586/7/payloads/cbui/modules/cpui… PS7, Line 92: static const char *amd_cap_extended_ecx_flags[] = { static const char * array should probably be static const char * const https://review.coreboot.org/c/coreboot/+/23586/7/payloads/cbui/modules/cpui… PS7, Line 100: static void mod_add_cpu_feature(struct nuklear_group* group, "foo* bar" should be "foo *bar" https://review.coreboot.org/c/coreboot/+/23586/7/payloads/cbui/modules/cpui… PS7, Line 119: static void mod_open(struct nuklear_module* this) "foo* bar" should be "foo *bar" https://review.coreboot.org/c/coreboot/+/23586/7/payloads/cbui/modules/cpui… PS7, Line 128: struct nuklear_group* group1 = NuklearGroup_new(this->root, "foo* bar" should be "foo *bar" https://review.coreboot.org/c/coreboot/+/23586/7/payloads/cbui/modules/cpui… PS7, Line 189: struct nuklear_group* group2 = NuklearGroup_new(this->root, "foo* bar" should be "foo *bar" https://review.coreboot.org/c/coreboot/+/23586/7/payloads/cbui/modules/cpui… PS7, Line 192: struct nuklear_group* group3 = NuklearGroup_new(this->root, "foo* bar" should be "foo *bar" https://review.coreboot.org/c/coreboot/+/23586/7/payloads/cbui/modules/cpui… PS7, Line 195: struct nuklear_group* group4 = NuklearGroup_new(this->root, "foo* bar" should be "foo *bar" https://review.coreboot.org/c/coreboot/+/23586/7/payloads/cbui/modules/cpui… PS7, Line 198: struct nuklear_group* group5 = NuklearGroup_new(this->root, "foo* bar" should be "foo *bar" https://review.coreboot.org/c/coreboot/+/23586/7/payloads/cbui/modules/cpui… PS7, Line 232: static void mod_close(struct nuklear_module* this, bool save) "foo* bar" should be "foo *bar" https://review.coreboot.org/c/coreboot/+/23586/7/payloads/cbui/modules/cpui… PS7, Line 237: static bool mod_update(struct nuklear_module* this) "foo* bar" should be "foo *bar" https://review.coreboot.org/c/coreboot/+/23586/7/payloads/cbui/modules/cpui… PS7, Line 242: static void mod_draw(struct nuklear_module* this, struct nk_context *ctx) "foo* bar" should be "foo *bar" https://review.coreboot.org/c/coreboot/+/23586/7/payloads/cbui/modules/cpui… PS7, Line 247: static bool mod_handlekey(struct nuklear_module* this, struct nk_context *ctx) "foo* bar" should be "foo *bar" https://review.coreboot.org/c/coreboot/+/23586/7/payloads/cbui/modules/lice… File payloads/cbui/modules/license_module.c: https://review.coreboot.org/c/coreboot/+/23586/7/payloads/cbui/modules/lice… PS7, Line 24: struct nuklear_group* group1 = NuklearGroup_new(this->root, "foo* bar" should be "foo *bar" https://review.coreboot.org/c/coreboot/+/23586/7/payloads/cbui/modules/lice… PS7, Line 65: struct nuklear_group* group2 = NuklearGroup_new(this->root, "foo* bar" should be "foo *bar" https://review.coreboot.org/c/coreboot/+/23586/7/payloads/cbui/modules/lice… PS7, Line 77: "along with this program; if not, write to the Free Software\n" Do not include the paragraph about writing to the Free Software Foundation's mailing address from the sample GPL notice. The FSF has changed addresses in the past, and may do so again. Linux already includes a copy of the GPL. https://review.coreboot.org/c/coreboot/+/23586/7/payloads/cbui/modules/lice… PS7, Line 78: "Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA " Do not include the paragraph about writing to the Free Software Foundation's mailing address from the sample GPL notice. The FSF has changed addresses in the past, and may do so again. Linux already includes a copy of the GPL. https://review.coreboot.org/c/coreboot/+/23586/7/payloads/cbui/modules/lice… PS7, Line 83: struct nuklear_group* group3 = NuklearGroup_new(this->root, "foo* bar" should be "foo *bar" https://review.coreboot.org/c/coreboot/+/23586/7/payloads/cbui/modules/pci_… File payloads/cbui/modules/pci_module.c: https://review.coreboot.org/c/coreboot/+/23586/7/payloads/cbui/modules/pci_… PS7, Line 75: switch (class) { switch and case should be at the same indent https://review.coreboot.org/c/coreboot/+/23586/7/payloads/cbui/modules/pci_… PS7, Line 93: case 0x11: return "Data Acquisition and Signal Processing" \ Avoid unnecessary line continuations https://review.coreboot.org/c/coreboot/+/23586/7/payloads/cbui/modules/pci_… PS7, Line 96: if (class == 0xff) return ""; trailing statements should be on next line https://review.coreboot.org/c/coreboot/+/23586/7/payloads/cbui/modules/pci_… PS7, Line 204: struct nuklear_group* group1 = NuklearGroup_new(this->root, "foo* bar" should be "foo *bar" https://review.coreboot.org/c/coreboot/+/23586/7/payloads/cbui/modules/rtc_… File payloads/cbui/modules/rtc_module.c: https://review.coreboot.org/c/coreboot/+/23586/7/payloads/cbui/modules/rtc_… PS7, Line 27: static struct nuklear_timepicker* tp; "foo* bar" should be "foo *bar" https://review.coreboot.org/c/coreboot/+/23586/7/payloads/cbui/modules/rtc_… PS7, Line 28: static struct nuklear_datepicker* dp; "foo* bar" should be "foo *bar" https://review.coreboot.org/c/coreboot/+/23586/7/payloads/cbui/modules/time… File payloads/cbui/modules/timestamps_module.c: https://review.coreboot.org/c/coreboot/+/23586/7/payloads/cbui/modules/time… PS7, Line 63: struct nuklear_group* group1 = NuklearGroup_new(this->root, "foo* bar" should be "foo *bar" https://review.coreboot.org/c/coreboot/+/23586/7/payloads/cbui/modules/time… PS7, Line 121: } void function return statements are not generally useful https://review.coreboot.org/c/coreboot/+/23586/7/payloads/cbui/modules/usb_… File payloads/cbui/modules/usb_module.c: https://review.coreboot.org/c/coreboot/+/23586/7/payloads/cbui/modules/usb_… PS7, Line 37: struct nuklear_group* group1 = NuklearGroup_new(this->root, "foo* bar" should be "foo *bar" https://review.coreboot.org/c/coreboot/+/23586/7/payloads/cbui/modules/usb_… PS7, Line 56: switch(controller->type) { space required before the open parenthesis '(' https://review.coreboot.org/c/coreboot/+/23586/7/payloads/cbui/modules/usb_… PS7, Line 96: switch(controller->type) { space required before the open parenthesis '(' https://review.coreboot.org/c/coreboot/+/23586/7/payloads/cbui/modules/usb_… PS7, Line 126: struct nuklear_group* group = NuklearGroup_new(this->root, "foo* bar" should be "foo *bar" https://review.coreboot.org/c/coreboot/+/23586/7/payloads/cbui/modules/usb_… PS7, Line 147: switch(controller->devices[i]->speed) { space required before the open parenthesis '(' -- To view, visit https://review.coreboot.org/c/coreboot/+/23586 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib9a1a07c1065880aa675380625021750d5cab7d1 Gerrit-Change-Number: 23586 Gerrit-PatchSet: 7 Gerrit-Owner: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Comment-Date: Wed, 11 Mar 2020 15:07:18 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/volteer: Disable WWAN PCIe
by Nick Vaccaro (Code Review) 11 Mar '20

11 Mar '20

Hello Alex Levin, I'd like you to do a code review. Please visit https://review.coreboot.org/c/coreboot/+/39421 to review the following change. Change subject: mb/google/volteer: Disable WWAN PCIe ...................................................................... mb/google/volteer: Disable WWAN PCIe Disable WWAN PCIe to allow WWAN enumerate as USB on Volteer. BUG=b:146226689 BRANCH=none TEST=lsusb shows WWAN device Change-Id: I04e49e3ec989d20ea3469fce06051c475b0ed0c8 Signed-off-by: Nick Vaccaro <nvaccaro(a)google.com> --- M src/mainboard/google/volteer/variants/baseboard/devicetree.cb M src/mainboard/google/volteer/variants/baseboard/gpio.c 2 files changed, 3 insertions(+), 7 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/21/39421/1 diff --git a/src/mainboard/google/volteer/variants/baseboard/devicetree.cb b/src/mainboard/google/volteer/variants/baseboard/devicetree.cb index f7cc1be..f57b9ca 100644 --- a/src/mainboard/google/volteer/variants/baseboard/devicetree.cb +++ b/src/mainboard/google/volteer/variants/baseboard/devicetree.cb @@ -56,12 +56,8 @@ register "PcieClkSrcUsage[1]" = "6" register "PcieClkSrcClkReq[1]" = "1" - # Enable WWAN PCIE 6 using clk 2 - register "PcieRpEnable[5]" = "1" - register "PcieClkSrcUsage[2]" = "5" - register "PcieClkSrcClkReq[2]" = "2" - # Mark SRCCLKREQ pins as unused that are routed for a Non-Clkreq functionality + register "PcieClkSrcUsage[2]" = "0xFF" register "PcieClkSrcUsage[4]" = "0xFF" register "PcieClkSrcUsage[5]" = "0xFF" register "PcieClkSrcUsage[6]" = "0xFF" @@ -323,7 +319,7 @@ device pci 1c.2 off end # RP3 0xA0BA device pci 1c.3 off end # RP4 0xA0BB device pci 1c.4 off end # RP5 0xA0BC - device pci 1c.5 on end # WWAN RP6 0xA0BD + device pci 1c.5 off end # WWAN RP6 0xA0BD device pci 1c.6 on end # RP7 0xA0BE device pci 1c.7 on end # SD Card RP8 0xA0BF diff --git a/src/mainboard/google/volteer/variants/baseboard/gpio.c b/src/mainboard/google/volteer/variants/baseboard/gpio.c index f6dbed0..e9d1028 100644 --- a/src/mainboard/google/volteer/variants/baseboard/gpio.c +++ b/src/mainboard/google/volteer/variants/baseboard/gpio.c @@ -170,7 +170,7 @@ /* D6 : SRCCLKREQ1# ==> WLAN_CLKREQ_ODL */ PAD_CFG_NF(GPP_D6, NONE, DEEP, NF1), /* D7 : SRCCLKREQ2# ==> WWAN_CLKREQ_ODL */ - PAD_CFG_NF(GPP_D7, NONE, DEEP, NF1), + PAD_CFG_NC(GPP_D7, NONE), /* D8 : SRCCLKREQ3# ==> SD_CLKREQ_ODL */ PAD_CFG_NF(GPP_D8, NONE, DEEP, NF1), /* D9 : ISH_SPI_CS# ==> PCH_GSPI2_CVF_CS_L */ -- To view, visit https://review.coreboot.org/c/coreboot/+/39421 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I04e49e3ec989d20ea3469fce06051c475b0ed0c8 Gerrit-Change-Number: 39421 Gerrit-PatchSet: 1 Gerrit-Owner: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Alex Levin <levinale(a)chromium.org> Gerrit-MessageType: newchange

4 7

Change in coreboot[master]: nb/intel/i945: Programm CxODT value for each channel
by Patrick Georgi (Code Review) 11 Mar '20

11 Mar '20

Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/18548 ) Change subject: nb/intel/i945: Programm CxODT value for each channel ...................................................................... Patch Set 26: (8 comments) https://review.coreboot.org/c/coreboot/+/18548/17//COMMIT_MSG Commit Message: https://review.coreboot.org/c/coreboot/+/18548/17//COMMIT_MSG@7 PS17, Line 7: proper > I mean "own" Done https://review.coreboot.org/c/coreboot/+/18548/26//COMMIT_MSG Commit Message: https://review.coreboot.org/c/coreboot/+/18548/26//COMMIT_MSG@10 PS26, Line 10: > no, […] Done https://review.coreboot.org/c/coreboot/+/18548/14/src/northbridge/intel/i94… File src/northbridge/intel/i945/raminit.c: https://review.coreboot.org/c/coreboot/+/18548/14/src/northbridge/intel/i94… PS14, Line 2458: have > Channel 0 […] Done https://review.coreboot.org/c/coreboot/+/18548/14/src/northbridge/intel/i94… PS14, Line 2466: Channel > Channel 0 […] Done https://review.coreboot.org/c/coreboot/+/18548/17/src/northbridge/intel/i94… File src/northbridge/intel/i945/raminit.c: https://review.coreboot.org/c/coreboot/+/18548/17/src/northbridge/intel/i94… PS17, Line 2465: ve > has Done https://review.coreboot.org/c/coreboot/+/18548/22/src/northbridge/intel/i94… File src/northbridge/intel/i945/raminit.c: https://review.coreboot.org/c/coreboot/+/18548/22/src/northbridge/intel/i94… PS22, Line 2452: : for (i = 0; i < (2 * DIMM_SOCKETS); i++) { : if (sysinfo->dimm[i] != SYSINFO_DIMM_NOT_POPULATED) : dimm_mask |= (1 << i); : } > I'm not fond of such arithmetics. Done https://review.coreboot.org/c/coreboot/+/18548/22/src/northbridge/intel/i94… PS22, Line 2463: (dimm_mask & 3) != 3 > It can be written even clearer by pulling the outer ! in: […] Elyes, please consider Nico's proposal, it really is much clearer. https://review.coreboot.org/c/coreboot/+/18548/22/src/northbridge/intel/i94… PS22, Line 2473: MCHBAR32(C1ODT) > Right, ODT is also enabled with a single DIMM. […] So what's the actionable outcome here: is the code okay to go in as is, or do you think there needs to be more work? (I generally agree with Nico's assessment and would put it in, but giving you guys a chance to chime in with how that breaks things) -- To view, visit https://review.coreboot.org/c/coreboot/+/18548 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I7aec35f45250da554ddc5a68f5add157c313399c Gerrit-Change-Number: 18548 Gerrit-PatchSet: 26 Gerrit-Owner: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Patrick Georgi <pgeorgi(a)google.com> Gerrit-CC: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Comment-Date: Wed, 11 Mar 2020 14:58:27 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de> Comment-In-Reply-To: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Comment-In-Reply-To: Paul Menzel <paulepanter(a)users.sourceforge.net> Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com> Comment-In-Reply-To: Arthur Heymans <arthur(a)aheymans.xyz> Comment-In-Reply-To: Patrick Rudolph <siro(a)das-labor.org> Comment-In-Reply-To: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-MessageType: comment

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit March 2020