Harshit Sharma has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/43938 )
Change subject: [DONOTSUBMIT]lib: Introduce memory bugs to help test ASan
......................................................................
[DONOTSUBMIT]lib: Introduce memory bugs to help test ASan
Introduces a few memory bugs into cbfs code to make testing easier
for the ones who are willing to try out ASan on their hardware.
Change-Id: I0839f2fd2863934ec28e2322bab04b9cc33363b4
Signed-off-by: Harshit Sharma <harshitsharmajs(a)gmail.com>
---
M src/lib/cbfs.c
1 file changed, 21 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/38/43938/1
diff --git a/src/lib/cbfs.c b/src/lib/cbfs.c
index cb66f81..839de94 100644
--- a/src/lib/cbfs.c
+++ b/src/lib/cbfs.c
@@ -330,9 +330,30 @@
return 0;
}
+#if ENV_RAMSTAGE
+ int global_array[5] = {-1};
+#endif
+
int cbfs_boot_region_device(struct region_device *rdev)
{
+ int stack_array[5], i, *p;
boot_device_init();
+
+ /* global out-of-bounds */
+#if ENV_RAMSTAGE
+ for (i = 10; i > 0; i--)
+ global_array[i] = i;
+#endif
+ /* stack out-of-bounds */
+ for (i = 10; i > 0; i--)
+ stack_array[i] = i;
+
+ /* use-after-scope */
+ {
+ int x = 5;
+ p = &x;
+ }
+ *p = 10;
return vboot_locate_cbfs(rdev) &&
fmap_locate_area_as_rdev("COREBOOT", rdev);
}
--
To view, visit https://review.coreboot.org/c/coreboot/+/43938
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I0839f2fd2863934ec28e2322bab04b9cc33363b4
Gerrit-Change-Number: 43938
Gerrit-PatchSet: 1
Gerrit-Owner: Harshit Sharma <harshitsharmajs(a)gmail.com>
Gerrit-MessageType: newchange
John Zhao has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/45623 )
Change subject: Fix control flow DEADCODE issue
......................................................................
Fix control flow DEADCODE issue
Coverity detects DEADCODE issue in the control flow. Based on both of
KEMPLD_CLK and KEMPLD_I2C_FREQ_STD definitions, execution cannot reach
this statement "prescale = 0". This change removes the DEADCODE code.
Found-by: Coverity CID 1431154
TEST=None
Signed-off-by: John Zhao <john.zhao(a)intel.com>
Change-Id: Ic002e708636961358969b2c1eaec0fee5bbcb73a
---
M src/ec/kontron/kempld/kempld_i2c.c
1 file changed, 0 insertions(+), 3 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/23/45623/1
diff --git a/src/ec/kontron/kempld/kempld_i2c.c b/src/ec/kontron/kempld/kempld_i2c.c
index 296cf76..165c940 100644
--- a/src/ec/kontron/kempld/kempld_i2c.c
+++ b/src/ec/kontron/kempld/kempld_i2c.c
@@ -250,9 +250,6 @@
else
prescale = KEMPLD_CLK / (KEMPLD_I2C_FREQ_STD * 4) - 3000;
- if (prescale < 0)
- prescale = 0;
-
/* Round to the best matching value */
prescale_corr = prescale / 1000;
if (prescale % 1000 >= 500)
--
To view, visit https://review.coreboot.org/c/coreboot/+/45623
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic002e708636961358969b2c1eaec0fee5bbcb73a
Gerrit-Change-Number: 45623
Gerrit-PatchSet: 1
Gerrit-Owner: John Zhao <john.zhao(a)intel.com>
Gerrit-MessageType: newchange