Hello Furquan Shaikh, Maulik V Vaghela, Rizwan Qureshi, Aamir Bohra, Patrick Rudolph, Karthik Ramasubramanian,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/46882
to look at the new patch set (#3).
Change subject: soc/intel/common/block/cse: Add functions to support setting DAM state
......................................................................
soc/intel/common/block/cse: Add functions to support setting DAM state
This patch adds the following helper functions,
get_dam_state : To get DAM state.
set_dam_state : To set DAM state.
disable_dam : To disable DAM.
To communicate with CSE, BIOS uses read_file_ex, set_file_ex and
commit_file commands over MEI messages. After passing DAM setting to
CSE, BIOS needs to initiate a global reset.
BUG=b:169626786
BRANCH=None
TEST=Build, boot drawlat and check DAM state, set DAM state.
Change-Id: If42eb150577e9f76318e77ae31eb6f5844a4143d
Signed-off-by: Krishna Prasad Bhat <krishna.p.bhat.d(a)intel.com>
---
M src/soc/intel/common/block/cse/cse.c
M src/soc/intel/common/block/include/intelblocks/cse.h
2 files changed, 63 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/82/46882/3
--
To view, visit https://review.coreboot.org/c/coreboot/+/46882
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If42eb150577e9f76318e77ae31eb6f5844a4143d
Gerrit-Change-Number: 46882
Gerrit-PatchSet: 3
Gerrit-Owner: Krishna P Bhat D <krishna.p.bhat.d(a)intel.com>
Gerrit-Reviewer: Aamir Bohra <aamir.bohra(a)intel.com>
Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com>
Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Reviewer: Maulik V Vaghela <maulik.v.vaghela(a)intel.com>
Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi(a)intel.com>
Gerrit-MessageType: newpatchset
Hello Furquan Shaikh, Maulik V Vaghela, Rizwan Qureshi, Aamir Bohra, Patrick Rudolph, Karthik Ramasubramanian,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/46880
to look at the new patch set (#3).
Change subject: soc/intel/common/block/cse: Add MCHI MCA group functions to cse lib
......................................................................
soc/intel/common/block/cse: Add MCHI MCA group functions to cse lib
This patch adds the following,
1. MCHI MCA group command ID.
2. Read File Ex command Id and heci_read_file_ex helper function to read
contents of a file.
3. Set File Ex command Id and heci_set_file_ex helper function to set
file's data for write.
4. Commit Files command Id and heci_commit_files helper function to
commit files previously set by set file command.
BUG=b:169626786
BRANCH=None
TEST=Build and boot drawcia.
Change-Id: I1bdb83daffc291c618f3193b5b4e159c3eff188e
Signed-off-by: Krishna Prasad Bhat <krishna.p.bhat.d(a)intel.com>
---
M src/soc/intel/common/block/cse/cse.c
M src/soc/intel/common/block/include/intelblocks/cse.h
2 files changed, 176 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/80/46880/3
--
To view, visit https://review.coreboot.org/c/coreboot/+/46880
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I1bdb83daffc291c618f3193b5b4e159c3eff188e
Gerrit-Change-Number: 46880
Gerrit-PatchSet: 3
Gerrit-Owner: Krishna P Bhat D <krishna.p.bhat.d(a)intel.com>
Gerrit-Reviewer: Aamir Bohra <aamir.bohra(a)intel.com>
Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com>
Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Reviewer: Maulik V Vaghela <maulik.v.vaghela(a)intel.com>
Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi(a)intel.com>
Gerrit-MessageType: newpatchset
Hello Furquan Shaikh, Maulik V Vaghela, Rizwan Qureshi, Aamir Bohra, Patrick Rudolph, Karthik Ramasubramanian,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/46881
to look at the new patch set (#3).
Change subject: soc/intel/common/block/cse: Modify heci_send_receive to support MCHI address
......................................................................
soc/intel/common/block/cse: Modify heci_send_receive to support MCHI
address
Modify heci_send_receive function to add support to send and receive messages to MCHI Client address.
BUG=b:169626786
BRANCH=None
TEST=Verify send and receive reply HECI message on drawlat.
Change-Id: Ice6f6bb0069080b9ac75a5323475c002e03eb751
Signed-off-by: Krishna Prasad Bhat <krishna.p.bhat.d(a)intel.com>
---
M src/soc/intel/common/block/cse/cse.c
M src/soc/intel/common/block/include/intelblocks/cse.h
2 files changed, 15 insertions(+), 3 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/81/46881/3
--
To view, visit https://review.coreboot.org/c/coreboot/+/46881
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ice6f6bb0069080b9ac75a5323475c002e03eb751
Gerrit-Change-Number: 46881
Gerrit-PatchSet: 3
Gerrit-Owner: Krishna P Bhat D <krishna.p.bhat.d(a)intel.com>
Gerrit-Reviewer: Aamir Bohra <aamir.bohra(a)intel.com>
Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com>
Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Reviewer: Maulik V Vaghela <maulik.v.vaghela(a)intel.com>
Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi(a)intel.com>
Gerrit-MessageType: newpatchset
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45151 )
Change subject: device: Enable bus mastering on system-class devices conditionally
......................................................................
Patch Set 8: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/45151
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia04e83606a0a081c0758ec59e52627aa1dbd2622
Gerrit-Change-Number: 45151
Gerrit-PatchSet: 8
Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Michael Niewöhner <foss(a)mniewoehner.de>
Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Comment-Date: Tue, 10 Nov 2020 14:29:37 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Caveh Jalali has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45025 )
Change subject: libpayload/usb: Add format string checking to usb_debug
......................................................................
Patch Set 2:
This change is ready for review.
--
To view, visit https://review.coreboot.org/c/coreboot/+/45025
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic94ebcbafdde8a5f79278b5635111b99af40f892
Gerrit-Change-Number: 45025
Gerrit-PatchSet: 2
Gerrit-Owner: Caveh Jalali <caveh(a)chromium.org>
Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org>
Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Comment-Date: Tue, 10 Nov 2020 12:39:50 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Caveh Jalali has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45024 )
Change subject: libpayload/usb: Fix printf format string mismatches in debug messages
......................................................................
Patch Set 2:
This change is ready for review.
--
To view, visit https://review.coreboot.org/c/coreboot/+/45024
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I4dc70baefb3cd82fcc915cc2e7f68719cf6870cc
Gerrit-Change-Number: 45024
Gerrit-PatchSet: 2
Gerrit-Owner: Caveh Jalali <caveh(a)chromium.org>
Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org>
Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Comment-Date: Tue, 10 Nov 2020 12:39:34 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46965 )
Change subject: Implementation of crashlog for intel TGL
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/46965/2//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/46965/2//COMMIT_MSG@7
PS2, Line 7: Implementation of crashlog for intel TGL
Please make it a statement by using a verb (in imperative mood).
--
To view, visit https://review.coreboot.org/c/coreboot/+/46965
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I1e084dfb9e50832c4baae969eb87b6d9b0f0401e
Gerrit-Change-Number: 46965
Gerrit-PatchSet: 2
Gerrit-Owner: Francois Toguo Fotso <francois.toguo.fotso(a)intel.com>
Gerrit-Reviewer: Nikunj Dadhania <nikunj.dadhania(a)intel.com>
Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Francois Toguo Fotso <francois.toguo.fotso(a)intel.corp-partner.google.com>
Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Comment-Date: Tue, 10 Nov 2020 12:28:29 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Patrick Georgi has removed Nikunj Dadhania from this change. ( https://review.coreboot.org/c/coreboot/+/46965 )
Change subject: Implementation of crashlog for intel TGL
......................................................................
Removed reviewer Nikunj Dadhania.
--
To view, visit https://review.coreboot.org/c/coreboot/+/46965
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I1e084dfb9e50832c4baae969eb87b6d9b0f0401e
Gerrit-Change-Number: 46965
Gerrit-PatchSet: 2
Gerrit-Owner: Francois Toguo Fotso <francois.toguo.fotso(a)intel.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com>
Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Francois Toguo Fotso <francois.toguo.fotso(a)intel.corp-partner.google.com>
Gerrit-MessageType: deleteReviewer