coreboot-gerrit October 2020

coreboot-gerrit@coreboot.org

1 participants
3474 discussions

Change in coreboot[master]: device: Enable bus mastering on system-class devices conditionally
by Felix Singer (Code Review) 27 Oct '20

27 Oct '20

Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45151 ) Change subject: device: Enable bus mastering on system-class devices conditionally ...................................................................... Patch Set 5: (1 comment) https://review.coreboot.org/c/coreboot/+/45151/4//COMMIT_MSG Commit Message: https://review.coreboot.org/c/coreboot/+/45151/4//COMMIT_MSG@9 PS4, Line 9: Devices of class type "system" are arbitrary devices and it's not clear : which of them need bus mastering. Therefore, enable bus mastering : conditionally based on Kconfig option PCI_ALLOW_BUS_MASTER_ANY_DEVICE. : > hmm. […] If anyone needs this, we can can add that later. I don't think we should invest more time than _really_ necessary into this, since we plan to remove it either. -- To view, visit https://review.coreboot.org/c/coreboot/+/45151 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia04e83606a0a081c0758ec59e52627aa1dbd2622 Gerrit-Change-Number: 45151 Gerrit-PatchSet: 5 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Comment-Date: Tue, 27 Oct 2020 15:30:09 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: util/docker: Update coreboot-sdk to set python2 as default
by Martin Roth (Code Review) 27 Oct '20

27 Oct '20

Martin Roth has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/46800 ) Change subject: util/docker: Update coreboot-sdk to set python2 as default ...................................................................... util/docker: Update coreboot-sdk to set python2 as default Even though both python2 and python3 are now installed to the SDK, the default python program is not. This sets the default to python2. Signed-off-by: Martin Roth <martin(a)coreboot.org> Change-Id: I4220c316df86cb2481143a79fadb70fc734e6879 --- M util/docker/coreboot-sdk/Dockerfile 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/00/46800/1 diff --git a/util/docker/coreboot-sdk/Dockerfile b/util/docker/coreboot-sdk/Dockerfile index 749b543..0ae63c8 100644 --- a/util/docker/coreboot-sdk/Dockerfile +++ b/util/docker/coreboot-sdk/Dockerfile @@ -79,6 +79,7 @@ xz-utils \ zlib1g-dev \ && apt-get clean \ + && update-alternatives --install /usr/bin/python python /usr/bin/python2 1 \ && ln -s /usr/bin/automake /usr/bin/automake-1.15 \ && ln -s /usr/bin/aclocal /usr/bin/aclocal-1.15 -- To view, visit https://review.coreboot.org/c/coreboot/+/46800 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I4220c316df86cb2481143a79fadb70fc734e6879 Gerrit-Change-Number: 46800 Gerrit-PatchSet: 1 Gerrit-Owner: Martin Roth <martinroth(a)google.com> Gerrit-MessageType: newchange

3 3

Change in coreboot[master]: device: Allow configuring bus mastering for PCI bridges conditionally
by Felix Singer (Code Review) 27 Oct '20

27 Oct '20

Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45150 ) Change subject: device: Allow configuring bus mastering for PCI bridges conditionally ...................................................................... Patch Set 4: (1 comment) https://review.coreboot.org/c/coreboot/+/45150/3/src/device/Kconfig File src/device/Kconfig: https://review.coreboot.org/c/coreboot/+/45150/3/src/device/Kconfig@537 PS3, Line 537: ALLOW > Ack. Makes sense to rename it, e.g. […] Done -- To view, visit https://review.coreboot.org/c/coreboot/+/45150 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic7cacce28f473dda76ca203016dbb8e00149a990 Gerrit-Change-Number: 45150 Gerrit-PatchSet: 4 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Comment-Date: Tue, 27 Oct 2020 15:19:43 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de> Comment-In-Reply-To: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: device: Rework bus master option
by Felix Singer (Code Review) 27 Oct '20

27 Oct '20

Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45149 ) Change subject: device: Rework bus master option ...................................................................... Patch Set 4: (1 comment) https://review.coreboot.org/c/coreboot/+/45149/3/src/device/Kconfig File src/device/Kconfig: https://review.coreboot.org/c/coreboot/+/45149/3/src/device/Kconfig@537 PS3, Line 537: config PCI_ALLOW_BUS_MASTER_ANY_DEVICE > I agree. A help text is expected for any user-visible config. Also for the […] Done -- To view, visit https://review.coreboot.org/c/coreboot/+/45149 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I33b37a79022007a16e97350db61575b63fa8256b Gerrit-Change-Number: 45149 Gerrit-PatchSet: 4 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 27 Oct 2020 15:19:29 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de> Comment-In-Reply-To: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: device: Allow configuring bus mastering for PCI bridges conditionally
by Felix Singer (Code Review) 27 Oct '20

27 Oct '20

Hello build bot (Jenkins), Nico Huber, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/45150 to look at the new patch set (#4). Change subject: device: Allow configuring bus mastering for PCI bridges conditionally ...................................................................... device: Allow configuring bus mastering for PCI bridges conditionally Change-Id: Ic7cacce28f473dda76ca203016dbb8e00149a990 Signed-off-by: Felix Singer <felix.singer(a)secunet.com> --- M src/device/Kconfig M src/device/pci_device.c 2 files changed, 9 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/50/45150/4 -- To view, visit https://review.coreboot.org/c/coreboot/+/45150 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic7cacce28f473dda76ca203016dbb8e00149a990 Gerrit-Change-Number: 45150 Gerrit-PatchSet: 4 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: device: Rework bus master option
by Felix Singer (Code Review) 27 Oct '20

27 Oct '20

Hello build bot (Jenkins), Nico Huber, Paul Menzel, Angel Pons, Michael Niewöhner, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/45149 to look at the new patch set (#4). Change subject: device: Rework bus master option ...................................................................... device: Rework bus master option As an intermediate step for CB:45150, add an additional Kconfig option which is used to configure bus mastering for any devices and use PCI_ALLOW_BUS_MASTER to allow coreboot setting the bus mastering bit in general. Change-Id: I33b37a79022007a16e97350db61575b63fa8256b Signed-off-by: Felix Singer <felix.singer(a)secunet.com> --- M src/device/Kconfig M src/include/device/pci.h 2 files changed, 12 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/49/45149/4 -- To view, visit https://review.coreboot.org/c/coreboot/+/45149 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I33b37a79022007a16e97350db61575b63fa8256b Gerrit-Change-Number: 45149 Gerrit-PatchSet: 4 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: console: Allow VPD to disable an otherwise enabled coreboot console
by Patrick Georgi (Code Review) 27 Oct '20

27 Oct '20

Hello build bot (Jenkins), Greg Edelston, Dossym Nurmukhanov, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/45208 to look at the new patch set (#2). Change subject: console: Allow VPD to disable an otherwise enabled coreboot console ...................................................................... console: Allow VPD to disable an otherwise enabled coreboot console With VPD compiled in, no output is sent to the serial console if VPD_RO has an entry `disable_serial` set to 1. This allows using an image for both deployment and testing scenarios with only the VPD entry modified to toggle (the typically slow) serial console. By looking for a positive value in an as-yet undefined VPD entry the change is transparent: the behavior doesn't change at all unless the entry is added. BUG=b:151346403 BRANCH=none TEST=Taking a Chrome OS config for google/eve, it behaves as expected with no entry present and both entry states (1, 0 - everything else falls back to 0) with negligible performance loss. Change-Id: I4f1f5c45e5ea889176d04e0db438ca2aa7c536ee Signed-off-by: Patrick Georgi <pgeorgi(a)google.com> --- M src/console/init.c 1 file changed, 23 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/08/45208/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/45208 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I4f1f5c45e5ea889176d04e0db438ca2aa7c536ee Gerrit-Change-Number: 45208 Gerrit-PatchSet: 2 Gerrit-Owner: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Dossym Nurmukhanov <dossym(a)google.com> Gerrit-Reviewer: Greg Edelston <gredelston(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com> Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: device: Rework bus master option
by Nico Huber (Code Review) 27 Oct '20

27 Oct '20

Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45149 ) Change subject: device: Rework bus master option ...................................................................... Patch Set 3: (2 comments) https://review.coreboot.org/c/coreboot/+/45149/3/src/device/Kconfig File src/device/Kconfig: https://review.coreboot.org/c/coreboot/+/45149/3/src/device/Kconfig@537 PS3, Line 537: config PCI_ALLOW_BUS_MASTER_ANY_DEVICE > could be skipped, assuming this is clear to the user in context of the options in the follow-ups I agree. A help text is expected for any user-visible config. Also for the follow up. e.g. Allow coreboot to enable PCI bus mastering for any device. The actual selection of devices depends on the various PCI drivers in coreboot. https://review.coreboot.org/c/coreboot/+/45149/3/src/device/Kconfig@538 PS3, Line 538: Any devices > ah, reading the follow-up It got it ;) maybe a choice would be better here to select "any device", " […] The currently added configs are necessary anyway, to check them in the code. We can add a choice on top and then make these existing configs invisible and let their defaults depend on the choice e.g. config PCI_SET_BUS_MASTER_PCI_BRIDGES def_bool PCI_BUS_MASTER_CHOICE_BRIDGES || PCI_BUS_MASTER_CHOICE_ANY But that can be done later, I suppose, once the semantics are clear. -- To view, visit https://review.coreboot.org/c/coreboot/+/45149 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I33b37a79022007a16e97350db61575b63fa8256b Gerrit-Change-Number: 45149 Gerrit-PatchSet: 3 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 27 Oct 2020 14:40:24 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: device: Rephrase bus master Kconfig option
by Angel Pons (Code Review) 27 Oct '20

27 Oct '20

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46341 ) Change subject: device: Rephrase bus master Kconfig option ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/46341 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I902915133035fb2adff7edd9c931d4b1d3e7dc40 Gerrit-Change-Number: 46341 Gerrit-PatchSet: 2 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-Reviewer: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 27 Oct 2020 14:38:37 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: device: Allow configuring bus mastering for PCI bridges conditionally
by Nico Huber (Code Review) 27 Oct '20

27 Oct '20

Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45150 ) Change subject: device: Allow configuring bus mastering for PCI bridges conditionally ...................................................................... Patch Set 3: (1 comment) https://review.coreboot.org/c/coreboot/+/45150/3/src/device/Kconfig File src/device/Kconfig: https://review.coreboot.org/c/coreboot/+/45150/3/src/device/Kconfig@537 PS3, Line 537: ALLOW > well, is it really "allow"? the code reads like "set it if the Kconfig is set" Ack. Makes sense to rename it, e.g. config PCI_SET_BUS_MASTER_PCI_BRIDGES -- To view, visit https://review.coreboot.org/c/coreboot/+/45150 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic7cacce28f473dda76ca203016dbb8e00149a990 Gerrit-Change-Number: 45150 Gerrit-PatchSet: 3 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Comment-Date: Tue, 27 Oct 2020 14:24:58 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-MessageType: comment

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit October 2020