Philipp Deppenwiese has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32734 )
Change subject: mb/supermicro/x11ssh: Add Supermicro X11SSH-TF
......................................................................
Patch Set 81:
(4 comments)
https://review.coreboot.org/c/coreboot/+/32734/74/Documentation/mainboard/s…
File Documentation/mainboard/supermicro/x11ssh-tf.md:
https://review.coreboot.org/c/coreboot/+/32734/74/Documentation/mainboard/s…
PS74, Line 30: S5 resume
> S5 or S3 resume?
We will do it in a follow-up.
https://review.coreboot.org/c/coreboot/+/32734/74/Documentation/mainboard/s…
File Documentation/mainboard/supermicro/x11ssh_flash.jpg:
PS74:
> Maybe highlight the SOIC-16 flash chip on the top edge of the mainboard as well, with some text sayi […]
We will do it in a follow-up.
https://review.coreboot.org/c/coreboot/+/32734/74/src/mainboard/supermicro/…
File src/mainboard/supermicro/x11ssh/Kconfig.name:
https://review.coreboot.org/c/coreboot/+/32734/74/src/mainboard/supermicro/…
PS74, Line 1: BOARD_SUPERMICRO_X11SSH_PLUS_TF
: bool "X11SSH+-TF"
> I don't see any 'X11SSH+-TF', so I'd remove the plus sign and "PLUS" from the Kconfig symbol name
We will do it in a follow-up.
https://review.coreboot.org/c/coreboot/+/32734/74/src/mainboard/supermicro/…
File src/mainboard/supermicro/x11ssh/bootblock.c:
https://review.coreboot.org/c/coreboot/+/32734/74/src/mainboard/supermicro/…
PS74, Line 37: garbeled
> garbled
We will do it in a follow-up.
--
To view, visit https://review.coreboot.org/c/coreboot/+/32734
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I2edaa4a928de3a065e517c0f20e3302b4b702323
Gerrit-Change-Number: 32734
Gerrit-PatchSet: 81
Gerrit-Owner: Christian Walter <christian.walter(a)9elements.com>
Gerrit-Reviewer: Alexander Couzens <lynxis(a)fe80.eu>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com>
Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Reviewer: Keno Fischer <keno(a)alumni.harvard.edu>
Gerrit-Reviewer: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: Name of user not set #1002358
Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com>
Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com>
Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com>
Gerrit-Reviewer: T. Hudson <trammell.hudson(a)gmail.com>
Gerrit-Reviewer: Trammell Hudson <hudson(a)trmm.net>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Christoph Pomaska <github(a)aufmachen.jetzt>
Gerrit-CC: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-CC: Maxim Polyakov <max.senia.poliak(a)gmail.com>
Gerrit-CC: Michael Niewöhner
Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Comment-Date: Sun, 01 Sep 2019 22:13:50 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-MessageType: comment
Philipp Deppenwiese has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32734 )
Change subject: mb/supermicro/x11ssh: Add Supermicro X11SSH-TF
......................................................................
Patch Set 81:
(1 comment)
https://review.coreboot.org/c/coreboot/+/32734/81/src/mainboard/supermicro/…
File src/mainboard/supermicro/x11ssh/variants/tf/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/32734/81/src/mainboard/supermicro/…
PS81, Line 12: register "gpe0_dw0" = "GPP_B"
> We will check later. Let's get the stuff into the tree.
Done
--
To view, visit https://review.coreboot.org/c/coreboot/+/32734
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I2edaa4a928de3a065e517c0f20e3302b4b702323
Gerrit-Change-Number: 32734
Gerrit-PatchSet: 81
Gerrit-Owner: Christian Walter <christian.walter(a)9elements.com>
Gerrit-Reviewer: Alexander Couzens <lynxis(a)fe80.eu>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com>
Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Reviewer: Keno Fischer <keno(a)alumni.harvard.edu>
Gerrit-Reviewer: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: Name of user not set #1002358
Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com>
Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com>
Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com>
Gerrit-Reviewer: T. Hudson <trammell.hudson(a)gmail.com>
Gerrit-Reviewer: Trammell Hudson <hudson(a)trmm.net>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Christoph Pomaska <github(a)aufmachen.jetzt>
Gerrit-CC: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-CC: Maxim Polyakov <max.senia.poliak(a)gmail.com>
Gerrit-CC: Michael Niewöhner
Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Comment-Date: Sun, 01 Sep 2019 22:08:23 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Michael Niewöhner
Comment-In-Reply-To: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com>
Gerrit-MessageType: comment
Philipp Deppenwiese has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32734 )
Change subject: mb/supermicro/x11ssh: Add Supermicro X11SSH-TF
......................................................................
Patch Set 81: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/32734
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I2edaa4a928de3a065e517c0f20e3302b4b702323
Gerrit-Change-Number: 32734
Gerrit-PatchSet: 81
Gerrit-Owner: Christian Walter <christian.walter(a)9elements.com>
Gerrit-Reviewer: Alexander Couzens <lynxis(a)fe80.eu>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com>
Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Reviewer: Keno Fischer <keno(a)alumni.harvard.edu>
Gerrit-Reviewer: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: Name of user not set #1002358
Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com>
Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com>
Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com>
Gerrit-Reviewer: T. Hudson <trammell.hudson(a)gmail.com>
Gerrit-Reviewer: Trammell Hudson <hudson(a)trmm.net>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Christoph Pomaska <github(a)aufmachen.jetzt>
Gerrit-CC: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-CC: Maxim Polyakov <max.senia.poliak(a)gmail.com>
Gerrit-CC: Michael Niewöhner
Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Comment-Date: Sun, 01 Sep 2019 22:07:59 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Philipp Deppenwiese has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32734 )
Change subject: mb/supermicro/x11ssh: Add Supermicro X11SSH-TF
......................................................................
Patch Set 81:
(1 comment)
https://review.coreboot.org/c/coreboot/+/32734/81/src/mainboard/supermicro/…
File src/mainboard/supermicro/x11ssh/variants/tf/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/32734/81/src/mainboard/supermicro/…
PS81, Line 12: register "gpe0_dw0" = "GPP_B"
> is this checked against inteltool? on x11ssm this is GPP_G and I wouldn't be surprised if this would […]
We will check later. Let's get the stuff into the tree.
--
To view, visit https://review.coreboot.org/c/coreboot/+/32734
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I2edaa4a928de3a065e517c0f20e3302b4b702323
Gerrit-Change-Number: 32734
Gerrit-PatchSet: 81
Gerrit-Owner: Christian Walter <christian.walter(a)9elements.com>
Gerrit-Reviewer: Alexander Couzens <lynxis(a)fe80.eu>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com>
Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Reviewer: Keno Fischer <keno(a)alumni.harvard.edu>
Gerrit-Reviewer: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: Name of user not set #1002358
Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com>
Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com>
Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com>
Gerrit-Reviewer: T. Hudson <trammell.hudson(a)gmail.com>
Gerrit-Reviewer: Trammell Hudson <hudson(a)trmm.net>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Christoph Pomaska <github(a)aufmachen.jetzt>
Gerrit-CC: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-CC: Maxim Polyakov <max.senia.poliak(a)gmail.com>
Gerrit-CC: Michael Niewöhner
Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Comment-Date: Sun, 01 Sep 2019 22:07:56 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Michael Niewöhner
Gerrit-MessageType: comment
Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32734 )
Change subject: mb/supermicro/x11ssh: Add Supermicro X11SSH-TF
......................................................................
Patch Set 81:
(1 comment)
https://review.coreboot.org/c/coreboot/+/32734/81/src/mainboard/supermicro/…
File src/mainboard/supermicro/x11ssh/variants/tf/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/32734/81/src/mainboard/supermicro/…
PS81, Line 12: register "gpe0_dw0" = "GPP_B"
is this checked against inteltool? on x11ssm this is GPP_G and I wouldn't be surprised if this would match
--
To view, visit https://review.coreboot.org/c/coreboot/+/32734
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I2edaa4a928de3a065e517c0f20e3302b4b702323
Gerrit-Change-Number: 32734
Gerrit-PatchSet: 81
Gerrit-Owner: Christian Walter <christian.walter(a)9elements.com>
Gerrit-Reviewer: Alexander Couzens <lynxis(a)fe80.eu>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com>
Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Reviewer: Keno Fischer <keno(a)alumni.harvard.edu>
Gerrit-Reviewer: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: Name of user not set #1002358
Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com>
Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com>
Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com>
Gerrit-Reviewer: T. Hudson <trammell.hudson(a)gmail.com>
Gerrit-Reviewer: Trammell Hudson <hudson(a)trmm.net>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Christoph Pomaska <github(a)aufmachen.jetzt>
Gerrit-CC: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-CC: Maxim Polyakov <max.senia.poliak(a)gmail.com>
Gerrit-CC: Michael Niewöhner
Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Comment-Date: Sun, 01 Sep 2019 16:08:27 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32734 )
Change subject: mb/supermicro/x11ssh: Add Supermicro X11SSH-TF
......................................................................
Patch Set 81:
(2 comments)
https://review.coreboot.org/c/coreboot/+/32734/68/src/mainboard/supermicro/…
File src/mainboard/supermicro/x11ssh/gpio.h:
https://review.coreboot.org/c/coreboot/+/32734/68/src/mainboard/supermicro/…
PS68, Line 31: static const struct pad_config gpio_table[] = {
> would it be reasonable easy to change this table in a way so that it doesn't just consists of a lot […]
Unfortunately there is no board documentation / schematics publicly available
https://review.coreboot.org/c/coreboot/+/32734/74/src/mainboard/supermicro/…
File src/mainboard/supermicro/x11ssh/variants/tf/board_info.txt:
https://review.coreboot.org/c/coreboot/+/32734/74/src/mainboard/supermicro/…
PS74, Line 5: ROM socketed: n
> They aren't.
The retail ones are, so you don't have a retail board, right?
--
To view, visit https://review.coreboot.org/c/coreboot/+/32734
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I2edaa4a928de3a065e517c0f20e3302b4b702323
Gerrit-Change-Number: 32734
Gerrit-PatchSet: 81
Gerrit-Owner: Christian Walter <christian.walter(a)9elements.com>
Gerrit-Reviewer: Alexander Couzens <lynxis(a)fe80.eu>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com>
Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Reviewer: Keno Fischer <keno(a)alumni.harvard.edu>
Gerrit-Reviewer: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: Name of user not set #1002358
Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com>
Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com>
Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com>
Gerrit-Reviewer: T. Hudson <trammell.hudson(a)gmail.com>
Gerrit-Reviewer: Trammell Hudson <hudson(a)trmm.net>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Christoph Pomaska <github(a)aufmachen.jetzt>
Gerrit-CC: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-CC: Maxim Polyakov <max.senia.poliak(a)gmail.com>
Gerrit-CC: Michael Niewöhner
Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Comment-Date: Sun, 01 Sep 2019 10:36:01 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Felix Held <felix-coreboot(a)felixheld.de>
Comment-In-Reply-To: Michael Niewöhner
Comment-In-Reply-To: Felix Singer <felixsinger(a)posteo.net>
Gerrit-MessageType: comment