Yu-Ping Wu has uploaded a new patch set (#33) to the change originally created by huayang duan. ( https://review.coreboot.org/c/coreboot/+/34990 )
Change subject: mediatek/mt8183: Use different DRAM frequencies for eMCP DDR
......................................................................
mediatek/mt8183: Use different DRAM frequencies for eMCP DDR
Devices using eMCP may run at a high DRAM frequency (e.g., 3600Mbps)
while those with discrete DRAM can only run at 3200Mbps. This patch
enables 3600Mbps for eMCP DDR for better system performance.
BUG=b:80501386
BRANCH=none
TEST=Boots correctly and stress test passes on Kukui
Change-Id: Iab6a9c2c390feeb9497b051a255b29566909e656
Signed-off-by: Huayang Duan <huayang.duan(a)mediatek.com>
---
M src/soc/mediatek/mt8183/emi.c
M src/soc/mediatek/mt8183/include/soc/dramc_common_mt8183.h
2 files changed, 25 insertions(+), 7 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/90/34990/33
--
To view, visit https://review.coreboot.org/c/coreboot/+/34990
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iab6a9c2c390feeb9497b051a255b29566909e656
Gerrit-Change-Number: 34990
Gerrit-PatchSet: 33
Gerrit-Owner: huayang duan <huayangduan(a)gmail.com>
Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org>
Gerrit-Reviewer: SJ Huang <sj.huang(a)mediatek.corp-partner.google.com>
Gerrit-Reviewer: You-Cheng Syu <youcheng(a)google.com>
Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Reviewer: huayang duan <huayangduan(a)gmail.com>
Gerrit-CC: Huayang Duan <huayang.duan(a)mediatek.corp-partner.google.com>
Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-MessageType: newpatchset
Hello Rizwan Qureshi,
I'd like you to do a code review. Please visit
https://review.coreboot.org/c/coreboot/+/35224
to review the following change.
Change subject: soc/intel/common/block/cse: Add helper function heci_send_receive
......................................................................
soc/intel/common/block/cse: Add helper function heci_send_receive
Add a helper function to send a heci message and receive the response.
Change-Id: Ic95239eef8591d3aadf56a857c97f3f1e12b16ac
Signed-off-by: Rizwan Qureshi <rizwan.qureshi(a)intel.com>
Signed-off-by: sridhar <sridhar.siricilla(a)intel.com>
---
M src/soc/intel/common/block/cse/cse.c
M src/soc/intel/common/block/include/intelblocks/cse.h
2 files changed, 30 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/24/35224/1
diff --git a/src/soc/intel/common/block/cse/cse.c b/src/soc/intel/common/block/cse/cse.c
index 7bd46ce..97989f7 100644
--- a/src/soc/intel/common/block/cse/cse.c
+++ b/src/soc/intel/common/block/cse/cse.c
@@ -458,6 +458,27 @@
return 0;
}
+int heci_send_receive(const void *snd_msg, size_t snd_sz, void *rcv_msg,
+ size_t *rcv_sz)
+{
+ if (!heci_send(snd_msg, snd_sz, BIOS_HOST_ADDR, HECI_MKHI_ADDR)) {
+ printk(BIOS_ERR, "Heci Send Failed\n");
+ goto failed;
+ }
+
+ if (rcv_msg != NULL) {
+ if (!heci_receive(rcv_msg, rcv_sz)) {
+ printk(BIOS_ERR, "Heci receive Failed\n");
+ goto failed;
+ }
+ }
+
+ return 1;
+
+failed:
+ return 0;
+}
+
/*
* Attempt to reset the device. This is useful when host and ME are out
* of sync during transmission or ME didn't understand the message.
diff --git a/src/soc/intel/common/block/include/intelblocks/cse.h b/src/soc/intel/common/block/include/intelblocks/cse.h
index d7c4d9f..371a781 100644
--- a/src/soc/intel/common/block/include/intelblocks/cse.h
+++ b/src/soc/intel/common/block/include/intelblocks/cse.h
@@ -37,6 +37,15 @@
*/
int
heci_send(const void *msg, size_t len, uint8_t host_addr, uint8_t cse_addr);
+
+/*
+ * Sends snd_msg of size snd_sz, and reads message into buffer pointed by
+ * rcv_msg of size rcv_sz
+ * Returns 0 on failure a 1 on success.
+ */
+int heci_send_receive(const void *snd_msg, size_t snd_sz, void *rcv_msg,
+ size_t *rcv_sz);
+
/*
* Attempt device reset. This is useful and perhaps only thing left to do when
* CPU and CSE are out of sync or CSE fails to respond.
--
To view, visit https://review.coreboot.org/c/coreboot/+/35224
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic95239eef8591d3aadf56a857c97f3f1e12b16ac
Gerrit-Change-Number: 35224
Gerrit-PatchSet: 1
Gerrit-Owner: Sridhar Siricilla <sridhar.siricilla(a)intel.com>
Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi(a)intel.com>
Gerrit-MessageType: newchange
Michael Niewöhner has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/35458 )
Change subject: mb/supermicro/x11ssh-tf: correct CBFS_SIZE
......................................................................
mb/supermicro/x11ssh-tf: correct CBFS_SIZE
The specified CBFS_SIZE does not make sense.
The boards BIOS region is 0xb00000. Correct the value.
Signed-off-by: Michael Niewöhner <foss(a)mniewoehner.de>
Change-Id: Ia3014c7fd081030607790ced6bb55323086f1161
---
M src/mainboard/supermicro/x11ssh/Kconfig
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/58/35458/1
diff --git a/src/mainboard/supermicro/x11ssh/Kconfig b/src/mainboard/supermicro/x11ssh/Kconfig
index e6f342d..dcf6bb9 100644
--- a/src/mainboard/supermicro/x11ssh/Kconfig
+++ b/src/mainboard/supermicro/x11ssh/Kconfig
@@ -34,7 +34,7 @@
config CBFS_SIZE
hex
- default 0x009aa000 if !VBOOT
+ default 0xb00000
config IRQ_SLOT_COUNT
int
--
To view, visit https://review.coreboot.org/c/coreboot/+/35458
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia3014c7fd081030607790ced6bb55323086f1161
Gerrit-Change-Number: 35458
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Niewöhner
Gerrit-MessageType: newchange
Patrick Rudolph has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/35465 )
Change subject: Documentation: X11SSH-TF update known issues
......................................................................
Documentation: X11SSH-TF update known issues
Change-Id: I5811fb829b45381ac19b2c3f2411c91f85b61d08
Signed-off-by: Patrick Rudolph <patrick.rudolph(a)9elements.com>
---
M Documentation/mainboard/supermicro/x11ssh-tf.md
1 file changed, 1 insertion(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/65/35465/1
diff --git a/Documentation/mainboard/supermicro/x11ssh-tf.md b/Documentation/mainboard/supermicro/x11ssh-tf.md
index a9dc838..16e70d4 100644
--- a/Documentation/mainboard/supermicro/x11ssh-tf.md
+++ b/Documentation/mainboard/supermicro/x11ssh-tf.md
@@ -27,8 +27,7 @@
- Intel SGX causes secondary APs to crash (disabled for now).
- Tianocore doesn't work with Aspeed NGI, as it's text mode only.
-- After S5 resume coreboot detects more DIMMs than installed, causing FSP-M
- to fail.
+- SMBus / I2C does not work (interrupt timeout)
## Tested and working
--
To view, visit https://review.coreboot.org/c/coreboot/+/35465
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I5811fb829b45381ac19b2c3f2411c91f85b61d08
Gerrit-Change-Number: 35465
Gerrit-PatchSet: 1
Gerrit-Owner: Patrick Rudolph <patrick.rudolph(a)9elements.com>
Gerrit-MessageType: newchange
Jacob Garber has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/35464 )
Change subject: soc/qualcomm/ipq40xx: Remove unnecessary allocation
......................................................................
soc/qualcomm/ipq40xx: Remove unnecessary allocation
The bus variable doesn't live outside the scope of this function, and is
only used as a convenient way for passing the pointers to all the
sub-functions, so it doesn't need to be allocated. Put it on the stack
instead. A similar fix for ipq806x was done in 0f33d8c29a
(soc/qualcomm/ipq806x: Remove unnecessary allocation).
Change-Id: Ibb1129b92e38a105e100f59e03d107de340b925c
Signed-off-by: Jacob Garber <jgarber1(a)ualberta.ca>
Found-by: Coverity CID 1294801
---
M src/soc/qualcomm/ipq40xx/lcc.c
1 file changed, 11 insertions(+), 19 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/64/35464/1
diff --git a/src/soc/qualcomm/ipq40xx/lcc.c b/src/soc/qualcomm/ipq40xx/lcc.c
index b2b4c45..3c75620 100644
--- a/src/soc/qualcomm/ipq40xx/lcc.c
+++ b/src/soc/qualcomm/ipq40xx/lcc.c
@@ -287,29 +287,21 @@
int audio_clock_config(unsigned frequency)
{
- IpqLccClocks *bus = malloc(sizeof(*bus));
+ IpqLccClocks bus = {
+ .gcc_apcs_regs = (void *)(MSM_GCC_BASE + GCC_PLL_APCS_REG);
+ .lcc_pll0_regs = (void *)(MSM_LPASS_LCC_BASE + LCC_PLL0_MODE_REG);
+ .lcc_ahbix_regs = (void *)(MSM_LPASS_LCC_BASE + LCC_AHBIX_NS_REG);
+ .lcc_mi2s_regs = (void *)(MSM_LPASS_LCC_BASE + LCC_MI2S_NS_REG);
+ .lcc_pll_regs = (void *)(MSM_LPASS_LCC_BASE + LCC_PLL_PCLK_REG);
+ };
- if (!bus) {
- printk(BIOS_ERR, "%s: failed to allocate bus structure\n",
- __func__);
+ if (lcc_init_enable_pll0(&bus))
return 1;
- }
-
- bus->gcc_apcs_regs = (void *)(MSM_GCC_BASE + GCC_PLL_APCS_REG);
- bus->lcc_pll0_regs = (void *)(MSM_LPASS_LCC_BASE + LCC_PLL0_MODE_REG);
- bus->lcc_ahbix_regs = (void *)(MSM_LPASS_LCC_BASE + LCC_AHBIX_NS_REG);
- bus->lcc_mi2s_regs = (void *)(MSM_LPASS_LCC_BASE + LCC_MI2S_NS_REG);
- bus->lcc_pll_regs = (void *)(MSM_LPASS_LCC_BASE + LCC_PLL_PCLK_REG);
-
-
- if (lcc_init_enable_pll0(bus))
+ if (lcc_init_enable_ahbix(&bus))
return 1;
- if (lcc_init_enable_ahbix(bus))
+ if (lcc_init_mi2s(&bus, frequency))
return 1;
- if (lcc_init_mi2s(bus, frequency))
- return 1;
-
- if (lcc_enable_mi2s(bus))
+ if (lcc_enable_mi2s(&bus))
return 1;
return 0;
--
To view, visit https://review.coreboot.org/c/coreboot/+/35464
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ibb1129b92e38a105e100f59e03d107de340b925c
Gerrit-Change-Number: 35464
Gerrit-PatchSet: 1
Gerrit-Owner: Jacob Garber <jgarber1(a)ualberta.ca>
Gerrit-MessageType: newchange