coreboot-gerrit March 2019

coreboot-gerrit@coreboot.org

1 participants
1542 discussions

Change in ...libgfxinit[master]: gma config, port detection: Scatter Valid_Port initialization
by Arthur Heymans (Code Review) 26 Mar '19

26 Mar '19

Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/libgfxinit/+/27047 ) Change subject: gma config, port detection: Scatter Valid_Port initialization ...................................................................... Patch Set 5: Code-Review+2 -- To view, visit https://review.coreboot.org/c/libgfxinit/+/27047 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: libgfxinit Gerrit-Branch: master Gerrit-Change-Id: I17df08de0aa1ffb303646ea564c100bb702407f5 Gerrit-Change-Number: 27047 Gerrit-PatchSet: 5 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Comment-Date: Tue, 26 Mar 2019 09:33:40 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in ...libgfxinit[master]: gma: Provide `Global` contracts for public procedures
by Arthur Heymans (Code Review) 26 Mar '19

26 Mar '19

Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/libgfxinit/+/26866 ) Change subject: gma: Provide `Global` contracts for public procedures ...................................................................... Patch Set 5: Code-Review+2 -- To view, visit https://review.coreboot.org/c/libgfxinit/+/26866 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: libgfxinit Gerrit-Branch: master Gerrit-Change-Id: I13af0d90ff738e1eea5f8992718e00a6a09c4705 Gerrit-Change-Number: 26866 Gerrit-PatchSet: 5 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Comment-Date: Tue, 26 Mar 2019 09:31:22 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in ...coreboot[master]: soc/intel/cannonlake: enable VMX support
by Ronak Kanabar (Code Review) 26 Mar '19

26 Mar '19

Ronak Kanabar has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31928 ) Change subject: soc/intel/cannonlake: enable VMX support ...................................................................... Patch Set 4: (1 comment) > Patch Set 4: > > Why can’t the generic code be used? As per CB:29683 common/block VMX support will be Reverted https://review.coreboot.org/#/c/31928/4/src/soc/intel/cannonlake/cpu.c File src/soc/intel/cannonlake/cpu.c: https://review.coreboot.org/#/c/31928/4/src/soc/intel/cannonlake/cpu.c@410 PS4, Line 410: VmxEnable is set and VtdDisable > what is supposed to happen for VmxEnable == VtdDisable == 1? It will not configure Vmx as per CB:25118 Vmx should be disabled if Vtd Disabled is set. -- To view, visit https://review.coreboot.org/c/coreboot/+/31928 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I33dbffa6301afabd688080751ba3b85a43e00156 Gerrit-Change-Number: 31928 Gerrit-PatchSet: 4 Gerrit-Owner: Ronak Kanabar <ronak.kanabar(a)intel.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Maulik V Vaghela <maulik.v.vaghela(a)intel.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Reviewer: Ronak Kanabar <ronak.kanabar(a)intel.com> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-CC: RONAK KANABAR <ronak199323(a)gmail.com> Gerrit-CC: Thomas Heijligen <src(a)posteo.de> Gerrit-Comment-Date: Tue, 26 Mar 2019 05:51:38 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Patrick Georgi <pgeorgi(a)google.com> Gerrit-MessageType: comment

1 0

Change in ...coreboot[master]: mb/google/poppy/variants/rammus: Support new onboard Micron memory
by Furquan Shaikh (Code Review) 26 Mar '19

26 Mar '19

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32046 ) Change subject: mb/google/poppy/variants/rammus: Support new onboard Micron memory ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/32046 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iaec4147a64313dcd461affb492805c0453e8703d Gerrit-Change-Number: 32046 Gerrit-PatchSet: 2 Gerrit-Owner: YanRu Chen <kane_chen(a)pegatron.corp-partner.google.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: YanRu Chen <kane_chen(a)pegatron.corp-partner.google.com> Gerrit-Reviewer: Zhuohao Lee <zhuohao(a)chromium.org> Gerrit-CC: Ken Lu <ken_lu(a)pegatron.corp-partner.google.com> Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Comment-Date: Tue, 26 Mar 2019 02:42:08 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in ...coreboot[master]: mb/google/poppy/variants/rammus: Support new onboard Micron memory
by YanRu Chen (Code Review) 26 Mar '19

26 Mar '19

Hello Zhuohao Lee, Patrick Georgi, Martin Roth, Furquan Shaikh, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/32046 to look at the new patch set (#2). Change subject: mb/google/poppy/variants/rammus: Support new onboard Micron memory ...................................................................... mb/google/poppy/variants/rammus: Support new onboard Micron memory Add micron_dimm_MT52L256M32D1PF-107 for new onboard memory support. BUG=none BRANCH=firmware-rammus-11275.B TEST=emerge-rammus coreboot chromeos-ec chromeos-bootimage Flash FW to DUT, and make sure system boots up. Signed-off-by: YanRu Chen <kane_chen(a)pegatron.corp-partner.google.com> Change-Id: Iaec4147a64313dcd461affb492805c0453e8703d --- M src/mainboard/google/poppy/variants/rammus/Makefile.inc 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/46/32046/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/32046 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iaec4147a64313dcd461affb492805c0453e8703d Gerrit-Change-Number: 32046 Gerrit-PatchSet: 2 Gerrit-Owner: YanRu Chen <kane_chen(a)pegatron.corp-partner.google.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: YanRu Chen <kane_chen(a)pegatron.corp-partner.google.com> Gerrit-Reviewer: Zhuohao Lee <zhuohao(a)chromium.org> Gerrit-CC: Ken Lu <ken_lu(a)pegatron.corp-partner.google.com> Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-MessageType: newpatchset

1 0

Change in ...coreboot[master]: soc/intel/common: Move eventlog support into common code
by Lijian Zhao (Code Review) 26 Mar '19

26 Mar '19

Lijian Zhao has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31967 ) Change subject: soc/intel/common: Move eventlog support into common code ...................................................................... Patch Set 2: This change is ready for review. -- To view, visit https://review.coreboot.org/c/coreboot/+/31967 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Idf1f69b15487c9a08f1ddaeab055880eef9c2f24 Gerrit-Change-Number: 31967 Gerrit-PatchSet: 2 Gerrit-Owner: Lijian Zhao <lijian.zhao(a)intel.com> Gerrit-Reviewer: Lijian Zhao <lijian.zhao(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Krzysztof M Sywula <krzysztof.m.sywula(a)intel.com> Gerrit-CC: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Comment-Date: Mon, 25 Mar 2019 23:04:05 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in ...coreboot[master]: vboot: remove VBOOT_EC_SLOW_UPDATE Kconfig option
by Joel Kitching (Code Review) 26 Mar '19

26 Mar '19

Joel Kitching has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/31909 Change subject: vboot: remove VBOOT_EC_SLOW_UPDATE Kconfig option ...................................................................... vboot: remove VBOOT_EC_SLOW_UPDATE Kconfig option This option has been relocated to depthcharge: https://crrev.com/c/1524806 BUG=b:124141368, b:124192753 TEST=Build and deploy to eve TEST=util/lint/checkpatch.pl -g origin/master..HEAD TEST=util/abuild/abuild -B -e -y -c 50 -p none -x TEST=make clean && make test-abuild CQ-DEPEND=CL:1524806 BRANCH=none Change-Id: Ib4a83af2ba143577a064fc0d72c9bc318db56adc Signed-off-by: Joel Kitching <kitching(a)google.com> --- M src/mainboard/google/kahlee/Kconfig M src/mainboard/google/oak/Kconfig M src/security/vboot/Kconfig M src/soc/intel/skylake/Kconfig 4 files changed, 0 insertions(+), 11 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/09/31909/1 diff --git a/src/mainboard/google/kahlee/Kconfig b/src/mainboard/google/kahlee/Kconfig index 1c46625..6364878 100644 --- a/src/mainboard/google/kahlee/Kconfig +++ b/src/mainboard/google/kahlee/Kconfig @@ -101,7 +101,6 @@ config VBOOT select EC_GOOGLE_CHROMEEC_SWITCHES select VBOOT_LID_SWITCH - select VBOOT_EC_SLOW_UPDATE if VBOOT_EC_SOFTWARE_SYNC config VBOOT_VBNV_OFFSET hex diff --git a/src/mainboard/google/oak/Kconfig b/src/mainboard/google/oak/Kconfig index 9d6fa0e..b770944 100644 --- a/src/mainboard/google/oak/Kconfig +++ b/src/mainboard/google/oak/Kconfig @@ -47,7 +47,6 @@ config VBOOT select EC_GOOGLE_CHROMEEC_SWITCHES - select VBOOT_EC_SLOW_UPDATE select VBOOT_VBNV_FLASH config MAINBOARD_DIR diff --git a/src/security/vboot/Kconfig b/src/security/vboot/Kconfig index 8d3d83f..67853ab 100644 --- a/src/security/vboot/Kconfig +++ b/src/security/vboot/Kconfig @@ -185,14 +185,6 @@ firmware similar to how vboot verifies the main system firmware. This option selects whether vboot should support EC software sync. -config VBOOT_EC_SLOW_UPDATE - bool - default n - depends on VBOOT_EC_SOFTWARE_SYNC - help - Whether the EC (or PD) is slow to update and needs to display a - screen that informs the user the update is happening. - config VBOOT_PHYSICAL_DEV_SWITCH bool default n diff --git a/src/soc/intel/skylake/Kconfig b/src/soc/intel/skylake/Kconfig index 53094b1..75d2d62 100644 --- a/src/soc/intel/skylake/Kconfig +++ b/src/soc/intel/skylake/Kconfig @@ -104,7 +104,6 @@ select CHROMEOS_RAMOOPS_DYNAMIC config VBOOT - select VBOOT_EC_SLOW_UPDATE if VBOOT_EC_SOFTWARE_SYNC select VBOOT_SEPARATE_VERSTAGE select VBOOT_OPROM_MATTERS select VBOOT_SAVE_RECOVERY_REASON_ON_REBOOT -- To view, visit https://review.coreboot.org/c/coreboot/+/31909 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib4a83af2ba143577a064fc0d72c9bc318db56adc Gerrit-Change-Number: 31909 Gerrit-PatchSet: 1 Gerrit-Owner: Joel Kitching <kitching(a)google.com> Gerrit-MessageType: newchange

3 12

Change in ...coreboot[master]: soc/apollolake: Add UART0
by Felix Singer (Code Review) 26 Mar '19

26 Mar '19

Felix Singer has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/31864 Change subject: soc/apollolake: Add UART0 ...................................................................... soc/apollolake: Add UART0 Change-Id: Id9a742144eba0f1d1544aafecf44d4730d055b4a Signed-off-by: Felix Singer <felix.singer(a)9elements.com> --- M src/soc/intel/apollolake/uart.c 1 file changed, 7 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/64/31864/1 diff --git a/src/soc/intel/apollolake/uart.c b/src/soc/intel/apollolake/uart.c index 66a1a1a..bda8aec 100644 --- a/src/soc/intel/apollolake/uart.c +++ b/src/soc/intel/apollolake/uart.c @@ -50,6 +50,13 @@ }, #else { + .console_index = 0, + .gpios = { + PAD_CFG_NF(GPIO_38, NATIVE, DEEP, NF1), /* UART0 RX */ + PAD_CFG_NF(GPIO_39, NATIVE, DEEP, NF1), /* UART0 TX */ + }, + }, + { .console_index = 1, .gpios = { PAD_CFG_NF(GPIO_42, NATIVE, DEEP, NF1), /* UART1 RX */ -- To view, visit https://review.coreboot.org/c/coreboot/+/31864 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id9a742144eba0f1d1544aafecf44d4730d055b4a Gerrit-Change-Number: 31864 Gerrit-PatchSet: 1 Gerrit-Owner: Felix Singer <migy(a)darmstadt.ccc.de> Gerrit-MessageType: newchange

2 3

Change in ...coreboot[master]: soc/apl: Add Usb30Mode config option to devicetree
by Felix Singer (Code Review) 26 Mar '19

26 Mar '19

Felix Singer has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/32048 Change subject: soc/apl: Add Usb30Mode config option to devicetree ...................................................................... soc/apl: Add Usb30Mode config option to devicetree Change-Id: Id7c241786e01700f7f5e840e10226f748e46d0d8 Signed-off-by: Felix Singer <felix.singer(a)9elements.com> --- M src/soc/intel/apollolake/chip.c M src/soc/intel/apollolake/chip.h 2 files changed, 4 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/48/32048/1 diff --git a/src/soc/intel/apollolake/chip.c b/src/soc/intel/apollolake/chip.c index 30a537b..e6ce0b5 100644 --- a/src/soc/intel/apollolake/chip.c +++ b/src/soc/intel/apollolake/chip.c @@ -741,6 +741,8 @@ /* Disable FSP from locking access to the RTC NVRAM */ silconfig->RtcLock = 0; + silconfig->Usb30Mode = cfg->usb30_mode; + /* Enable Audio clk gate and power gate */ silconfig->HDAudioClkGate = cfg->hdaudio_clk_gate_enable; silconfig->HDAudioPwrGate = cfg->hdaudio_pwr_gate_enable; diff --git a/src/soc/intel/apollolake/chip.h b/src/soc/intel/apollolake/chip.h index b9e368c..2cbfaff 100644 --- a/src/soc/intel/apollolake/chip.h +++ b/src/soc/intel/apollolake/chip.h @@ -120,6 +120,8 @@ /* PL2 override value in mW for APL */ uint16_t tdp_pl2_override_mw; + uint8_t usb30_mode; + /* Configure Audio clk gate and power gate * IOSF-SB port ID 92 offset 0x530 [5] and [3] */ -- To view, visit https://review.coreboot.org/c/coreboot/+/32048 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id7c241786e01700f7f5e840e10226f748e46d0d8 Gerrit-Change-Number: 32048 Gerrit-PatchSet: 1 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-MessageType: newchange

2 3

Change in ...coreboot[master]: Documentation/soc/intel: Add MP Initialization document
by Subrata Banik (Code Review) 26 Mar '19

26 Mar '19

Hello Patrick Rudolph, Philipp Deppenwiese, build bot (Jenkins), Patrick Georgi, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/31841 to look at the new patch set (#5). Change subject: Documentation/soc/intel: Add MP Initialization document ...................................................................... Documentation/soc/intel: Add MP Initialization document This patch provides documentation for MP initialization option available in coreboot. Change-Id: I055808e2ddf03663e1ec5d3d423054d1caa911cb Signed-off-by: Subrata Banik <subrata.banik(a)intel.com> --- M Documentation/soc/intel/index.md A Documentation/soc/intel/mp_init/mp_init.md 2 files changed, 57 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/41/31841/5 -- To view, visit https://review.coreboot.org/c/coreboot/+/31841 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I055808e2ddf03663e1ec5d3d423054d1caa911cb Gerrit-Change-Number: 31841 Gerrit-PatchSet: 5 Gerrit-Owner: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com> Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-MessageType: newpatchset

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit March 2019