coreboot-gerrit March 2019

coreboot-gerrit@coreboot.org

1 participants
1542 discussions

Change in ...coreboot[master]: qclib: Add qclib support
by Patrick Georgi (Code Review) 06 Mar '19

06 Mar '19

Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/29967 ) Change subject: qclib: Add qclib support ...................................................................... Patch Set 14: (1 comment) https://review.coreboot.org/#/c/29967/14/src/soc/qualcomm/qcs405/qclib_exec… File src/soc/qualcomm/qcs405/qclib_execute.c: https://review.coreboot.org/#/c/29967/14/src/soc/qualcomm/qcs405/qclib_exec… PS14, Line 27: PMIC_NAME "/ In the rpm loader you're directly using the strings in the PROG_INIT() macro. For consistency, please pick one way to handle it for qcs405. I'd have a slight preference for using strings directly (like rpm loader) -- To view, visit https://review.coreboot.org/c/coreboot/+/29967 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I534af71163d034ea04420dda6a94ce31b08c8a07 Gerrit-Change-Number: 29967 Gerrit-PatchSet: 14 Gerrit-Owner: nsekar(a)codeaurora.org Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: nsekar(a)codeaurora.org Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-CC: Sricharan Ramabadhran <srichara(a)qualcomm.corp-partner.google.com> Gerrit-Comment-Date: Wed, 06 Mar 2019 11:32:44 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in ...coreboot[master]: Mistral: QCS405: Added RPM support
by Patrick Georgi (Code Review) 06 Mar '19

06 Mar '19

Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/29970 ) Change subject: Mistral: QCS405: Added RPM support ...................................................................... Patch Set 14: Code-Review+1 (2 comments) https://review.coreboot.org/#/c/29970/14//COMMIT_MSG Commit Message: https://review.coreboot.org/#/c/29970/14//COMMIT_MSG@7 PS14, Line 7: Mistral: while this is for the mistral project, the change itself only touches qcs405, so drop this. https://review.coreboot.org/#/c/29970/14/src/soc/qualcomm/qcs405/rpm_load_r… File src/soc/qualcomm/qcs405/rpm_load_reset.c: https://review.coreboot.org/#/c/29970/14/src/soc/qualcomm/qcs405/rpm_load_r… PS14, Line 46: NIT: what's NIT: supposed to mean here? -- To view, visit https://review.coreboot.org/c/coreboot/+/29970 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I17f491f0a4bd0dce7522b7e80e1bac97ec18b945 Gerrit-Change-Number: 29970 Gerrit-PatchSet: 14 Gerrit-Owner: nsekar(a)codeaurora.org Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: nsekar(a)codeaurora.org Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-CC: Sricharan Ramabadhran <srichara(a)qualcomm.corp-partner.google.com> Gerrit-Comment-Date: Wed, 06 Mar 2019 11:31:36 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in ...coreboot[master]: inteltool: Add multiple device IDs of Intel GPUs
by Felix Singer (Code Review) 06 Mar '19

06 Mar '19

Felix Singer has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/30610 Change subject: inteltool: Add multiple device IDs of Intel GPUs ...................................................................... inteltool: Add multiple device IDs of Intel GPUs * Intel UHD Graphics 615 * Intel UHD Graphics 620 (2x) * Intel UHD Graphics 630 (2x) * Intel Iris Graphics 655 Change-Id: I299a5fc082433b0aab4861a24aecbe83b61a404a Signed-off-by: Felix Singer <migy(a)darmstadt.ccc.de> --- M util/inteltool/inteltool.c M util/inteltool/inteltool.h 2 files changed, 21 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/10/30610/1 diff --git a/util/inteltool/inteltool.c b/util/inteltool/inteltool.c index 9a58ed8..bace49e 100644 --- a/util/inteltool/inteltool.c +++ b/util/inteltool/inteltool.c @@ -347,6 +347,18 @@ "Intel(R) HD 5000 Graphics" }, { PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_HD_5000_2, "Intel(R) HD 5000 Graphics" }, + { PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_UHD_615, + "Intel(R) UHD Graphics 615" }, + { PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_UHD_620_1, + "Intel(R) UHD Graphics 620" }, + { PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_UHD_620_2, + "Intel(R) UHD Graphics 620" }, + { PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_UHD_630_1, + "Intel(R) UHD Graphics 630" }, + { PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_UHD_630_2, + "Intel(R) UHD Graphics 630" }, + { PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_IRIS_PLUS_655, + "Intel(R) Iris Plus Graphics 655" }, }; #ifndef __DARWIN__ diff --git a/util/inteltool/inteltool.h b/util/inteltool/inteltool.h index d86ba35..8a36333 100644 --- a/util/inteltool/inteltool.h +++ b/util/inteltool/inteltool.h @@ -301,6 +301,15 @@ #define PCI_DEVICE_ID_INTEL_HD_5000 0x0422 #define PCI_DEVICE_ID_INTEL_HD_5000_1 0x0426 #define PCI_DEVICE_ID_INTEL_HD_5000_2 0x042A +#define PCI_DEVICE_ID_INTEL_UHD_615 0x591C +#define PCI_DEVICE_ID_INTEL_UHD_620_1 0x5917 +#define PCI_DEVICE_ID_INTEL_UHD_620_2 0x3EA0 +#define PCI_DEVICE_ID_INTEL_UHD_630_1 0x3E92 +#define PCI_DEVICE_ID_INTEL_UHD_630_2 0x3E9B +#define PCI_DEVICE_ID_INTEL_IRIS_PLUS_655 0x3EA5 + + + #if !defined(__DARWIN__) && !defined(__FreeBSD__) typedef struct { uint32_t hi, lo; } msr_t; -- To view, visit https://review.coreboot.org/c/coreboot/+/30610 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I299a5fc082433b0aab4861a24aecbe83b61a404a Gerrit-Change-Number: 30610 Gerrit-PatchSet: 1 Gerrit-Owner: Felix Singer <migy(a)darmstadt.ccc.de> Gerrit-MessageType: newchange

4 8

Change in ...coreboot[master]: util/superiotool/ite.c: add support for IT8613E
by Krystian Hebel (Code Review) 06 Mar '19

06 Mar '19

Krystian Hebel has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/31620 Change subject: util/superiotool/ite.c: add support for IT8613E ...................................................................... util/superiotool/ite.c: add support for IT8613E Based on not publicly available IT8613E Preliminary Specification V0.3. Change-Id: Iec99d4d998f645dbad9c803d6d5477580b0bccc4 Signed-off-by: Krystian Hebel <krystian.hebel(a)3mdeb.com> --- M util/superiotool/ite.c 1 file changed, 65 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/20/31620/1 diff --git a/util/superiotool/ite.c b/util/superiotool/ite.c index 06efc57..eebcc0a 100644 --- a/util/superiotool/ite.c +++ b/util/superiotool/ite.c @@ -328,6 +328,40 @@ {0x19, "Power Channel 5", {0x30,0x60,0x61,0x62,0x63,0x70,0x71,EOT}, {0x00,0x00,0x7a,0x00,0x7c,0x01,0x01,EOT}}, + {0x8613, "IT8613E", { + {NOLDN, NULL, + {0x20,0x21,0x22,0x23,0x24,0x2b,EOT}, + {0x86,0x13,0x05,0x40,0x00,0x48,EOT}}, + {0x1, "COM1", + {0x30,0x60,0x61,0x70,0xf0,EOT}, + {0x00,0x03,0xf8,0x04,0x00,EOT}}, + {0x4, "Environment controller", + {0x30,0x60,0x61,0x62,0x63,0x70,0xf0,0xf1,0xf2,0xf3, + 0xf4,0xf5,0xf6,0xfa,0xfb,0xfc,EOT}, + {0x00,0x02,0x90,0x02,0x30,0x09,0x00,0x00,0x00,0x00, + 0x00,NANA,NANA,0x00,0x00,0x00,EOT}}, + {0x5, "Keyboard", + {0x30,0x60,0x61,0x62,0x63,0x70,0x71,0xf0,EOT}, + {0x01,0x00,0x60,0x00,0x64,0x01,0x02,0x48,EOT}}, + {0x6, "Mouse", + {0x30,0x70,0x71,0xf0,EOT}, + {0x00,0x0c,0x02,0x00,EOT}}, + {0x7, "GPIO", + {0x25,0x26,0x27,0x28,0x29,0x2a,0x2c,0x2d,0x60,0x61, + 0x62,0x63,0x70,0x71,0x72,0x73,0x74,0xb0,0xb1,0xb2, + 0xb3,0xb4,0xb8,0xba,0xbb,0xbc,0xbd,0xc0,0xc1,0xc2, + 0xc3,0xc4,0xc8,0xc9,0xca,0xcb,0xcc,0xcd,0xda,0xdb, + 0xe0,0xe1,0xe2,0xe3,0xe4,0xec,0xf0,0xf1,0xf2,0xf3, + 0xf4,0xf5,0xf6,0xf7,0xf8,0xf9,0xfa,0xfb,EOT}, + {0x00,0xF3,0x00,0x00,0x00,0x01,0x01,0x00,0x00,0x00, + 0x00,0x00,0x00,0x00,0x20,0x38,0x00,0x00,0x00,0x00, + 0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x01,0x00,0x00, + 0x40,0x00,0x01,0x00,0x00,0x00,0x00,0x00,0x00,0x00, + 0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00, + 0x00,0x00,0x0e,0x00,0x00,0x00,0x00,0x00,EOT}}, + {0xa, "Consumer IR", + {0x30,0x60,0x61,0x70,0xf0,EOT}, + {0x00,0x03,0x10,0x0b,0x06,EOT}}, {EOT}}}, {0x8623, "IT8623E", { /* Defaults are not specified as no datasheet available */ @@ -1032,6 +1066,37 @@ }; static const struct superio_registers ec_table[] = { + {0x8613, "IT8613E", { + {NOLDN, NULL, + {0x00,0x01,0x02,0x03,0x04,0x05,0x06,0x07,0x08,0x09, + 0x0a,0x0b,0x0c,0x0e,0x0f,0x11,0x12,0x13,0x14,0x16, + 0x17,0x19,0x1a,0x1c,0x1d,0x1e,0x1f,0x20,0x21,0x22, + 0x24,0x25,0x27,0x28,0x29,0x2a,0x2b,0x2c,0x2d,0x2e, + 0x2f,0x30,0x31,0x32,0x33,0x34,0x35,0x38,0x39,0x3a, + 0x3b,0x40,0x41,0x42,0x43,0x44,0x45,0x46,0x47,0x50, + 0x51,0x52,0x53,0x54,0x55,0x56,0x57,0x58,0x59,0x5a, + 0x5b,0x5c,0x5d,0x5e,0x5f,0x68,0x69,0x6a,0x6b,0x6c, + 0x6d,0x6e,0x70,0x71,0x72,0x73,0x74,0x75,0x76,0x78, + 0x79,0x7a,0x7b,0x7c,0x7d,0x7e,0x80,0x81,0x82,0x83, + 0x84,0x85,0x86,0x87,0x88,0x89,0x8a,0x8b,0x8c,0x8d, + 0x8e,0x8f,0x90,0x91,0x98,0x99,0x9c,0x9d,0x9e,0x9f, + 0xa0,0xa1,0xa2,0xa3,0xa4,0xa5,0xa6,0xb4,0xb5,0xb6, + 0xb7,0xb8,0xb9,EOT}, + {0x18,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0xC0, + 0x44,0x00,0x00,MISC,MISC,NANA,NANA,0x00,0x40,0x00, + 0x00,MISC,MISC,NANA,NANA,0x00,0x00,MISC,MISC,MISC, + MISC,MISC,MISC,MISC,MISC,MISC,MISC,MISC,MISC,MISC, + MISC,NANA,NANA,NANA,NANA,NANA,NANA,NANA,NANA,NANA, + NANA,NANA,NANA,NANA,NANA,NANA,NANA,NANA,NANA,0x00, + 0x00,0x7f,0x7f,0x7f,0x40,0x00,0x00,0x90,0x00,0x00, + 0x12,0x60,0x00,0x00,0x00,0x7f,0x7f,0x7f,0x00,0x00, + 0x7f,0x0f,0x7f,0x7f,0x7f,0x00,0x00,0x7f,0x0f,0x7f, + 0x7f,0x7f,0x00,0x00,0x7f,0x0f,MISC,MISC,MISC,MISC, + NANA,NANA,NANA,NANA,0x00,0x00,0x00,0x00,0x00,0x00, + 0x00,MISC,0x00,0x00,0x00,0x00,0x00,NANA,0x00,NANA, + 0x7f,0x7f,0x7f,0x00,0x00,0x7f,0x0f,NANA,NANA,NANA, + NANA,NANA,NANA,EOT}}, + {EOT}}}, {0x8716, "IT8716F", { {NOLDN, NULL, {0x00,0x04,0x05,0x06,0x07,0x08,0x09,0x0b,0x0c,0x10, -- To view, visit https://review.coreboot.org/c/coreboot/+/31620 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iec99d4d998f645dbad9c803d6d5477580b0bccc4 Gerrit-Change-Number: 31620 Gerrit-PatchSet: 1 Gerrit-Owner: Krystian Hebel <krystian.hebel(a)3mdeb.com> Gerrit-MessageType: newchange

4 10

Change in ...coreboot[master]: qclib: Add qclib support
by Patrick Georgi (Code Review) 06 Mar '19

06 Mar '19

Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/29967 ) Change subject: qclib: Add qclib support ...................................................................... Patch Set 14: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/29967 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I534af71163d034ea04420dda6a94ce31b08c8a07 Gerrit-Change-Number: 29967 Gerrit-PatchSet: 14 Gerrit-Owner: nsekar(a)codeaurora.org Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: nsekar(a)codeaurora.org Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-CC: Sricharan Ramabadhran <srichara(a)qualcomm.corp-partner.google.com> Gerrit-Comment-Date: Wed, 06 Mar 2019 11:26:48 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in ...coreboot[master]: qcs405: Add DRAM resources
by Patrick Georgi (Code Review) 06 Mar '19

06 Mar '19

Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/29954 ) Change subject: qcs405: Add DRAM resources ...................................................................... Patch Set 13: Code-Review+2 (1 comment) https://review.coreboot.org/#/c/29954/13/src/soc/qualcomm/qcs405/include/so… File src/soc/qualcomm/qcs405/include/soc/memlayout.ld: https://review.coreboot.org/#/c/29954/13/src/soc/qualcomm/qcs405/include/so… PS13, Line 46: Just curious, but is there any particular reason for moving them away from here? The new reserved region is from 0x8500_0000 to 0x8A10_0000, so no conflict. If it doesn't matter, we can leave the new addresses in, because they're as good as any, but some explanation why these were chosen would be nice. -- To view, visit https://review.coreboot.org/c/coreboot/+/29954 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iea79a942c297400c88aa205da713bcfcb8c51185 Gerrit-Change-Number: 29954 Gerrit-PatchSet: 13 Gerrit-Owner: nsekar(a)codeaurora.org Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: nsekar(a)codeaurora.org Gerrit-Comment-Date: Wed, 06 Mar 2019 11:21:21 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in ...coreboot[master]: libpayload: qcs405: Add new Configs
by Patrick Georgi (Code Review) 06 Mar '19

06 Mar '19

Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/29953 ) Change subject: libpayload: qcs405: Add new Configs ...................................................................... Patch Set 13: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/29953 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I15273fdacab0a23e05e821c433cf939be35fab97 Gerrit-Change-Number: 29953 Gerrit-PatchSet: 13 Gerrit-Owner: nsekar(a)codeaurora.org Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Sricharan Ramabadhran <srichara(a)qualcomm.corp-partner.google.com> Gerrit-Comment-Date: Wed, 06 Mar 2019 11:17:09 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in ...coreboot[master]: qcs405: Add Timer support
by Patrick Georgi (Code Review) 06 Mar '19

06 Mar '19

Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/29952 ) Change subject: qcs405: Add Timer support ...................................................................... Patch Set 13: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/29952 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I566c7ff2b7085c9dd89ea74a08f3ba862feab2ab Gerrit-Change-Number: 29952 Gerrit-PatchSet: 13 Gerrit-Owner: nsekar(a)codeaurora.org Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: nsekar(a)codeaurora.org Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-CC: Sricharan Ramabadhran <srichara(a)qualcomm.corp-partner.google.com> Gerrit-Comment-Date: Wed, 06 Mar 2019 11:16:44 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in ...coreboot[master]: soc/qualcomm/qcs405: Add MMU support
by Patrick Georgi (Code Review) 06 Mar '19

06 Mar '19

Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/29950 ) Change subject: soc/qualcomm/qcs405: Add MMU support ...................................................................... Patch Set 13: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/29950 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I8c6353be2c0379ec94f91223805762a2286de06d Gerrit-Change-Number: 29950 Gerrit-PatchSet: 13 Gerrit-Owner: nsekar(a)codeaurora.org Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: nsekar(a)codeaurora.org Gerrit-CC: Julius Werner <jwerner(a)chromium.org> Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-CC: Sricharan Ramabadhran <srichara(a)qualcomm.corp-partner.google.com> Gerrit-Comment-Date: Wed, 06 Mar 2019 11:16:13 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in ...coreboot[master]: mainboard/google/mistral: Add support for Mistral
by Patrick Georgi (Code Review) 06 Mar '19

06 Mar '19

Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/29949 ) Change subject: mainboard/google/mistral: Add support for Mistral ...................................................................... Patch Set 12: Code-Review+1 (1 comment) https://review.coreboot.org/#/c/29949/12/src/mainboard/google/mistral/chrom… File src/mainboard/google/mistral/chromeos.fmd: https://review.coreboot.org/#/c/29949/12/src/mainboard/google/mistral/chrom… PS12, Line 21: TODO: Move FMAP to 2M or 3M once FSG can be smaller From the fmap that seems to be possible now: GBB + RO_FRID + RO_VPD + RO_PRESERVE are 152K, so there's no conflict when putting fmap at 2 or 3 MB and the others after that -- To view, visit https://review.coreboot.org/c/coreboot/+/29949 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I7ecfad68bb50f42acf36f51bc3433add56597c3d Gerrit-Change-Number: 29949 Gerrit-PatchSet: 12 Gerrit-Owner: nsekar(a)codeaurora.org Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: nsekar(a)codeaurora.org Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-CC: Sricharan Ramabadhran <srichara(a)qualcomm.corp-partner.google.com> Gerrit-Comment-Date: Wed, 06 Mar 2019 11:12:45 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit March 2019