coreboot-gerrit October 2019

coreboot-gerrit@coreboot.org

1 participants
1921 discussions

Change in coreboot[master]: [TESTME]soc/intel/icelake: Properly select PCIEX_LENGTH_64MB
by Subrata Banik (Code Review) 31 Oct '19

31 Oct '19

Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35886 ) Change subject: [TESTME]soc/intel/icelake: Properly select PCIEX_LENGTH_64MB ...................................................................... Patch Set 2: Arthur, In ICL and CNL we are having CONFIG_SA_PCIEX_LENGTH=0x10000000 (256MB) this is as per CNL programming guide we need to set PCIEX to 256MB -- To view, visit https://review.coreboot.org/c/coreboot/+/35886 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I203059ed606fb56b069a382bed449abf311b81c1 Gerrit-Change-Number: 35886 Gerrit-PatchSet: 2 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 31 Oct 2019 05:28:47 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: arch/arm64: Pass cbmem_top to ramstage via calling argument
by Aaron Durbin (Code Review) 31 Oct '19

31 Oct '19

Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36275 ) Change subject: arch/arm64: Pass cbmem_top to ramstage via calling argument ...................................................................... Patch Set 20: (1 comment) https://review.coreboot.org/c/coreboot/+/36275/20/src/arch/arm64/Kconfig File src/arch/arm64/Kconfig: https://review.coreboot.org/c/coreboot/+/36275/20/src/arch/arm64/Kconfig@20 PS20, Line 20: select RAMSTAGE_CBMEM_TOP_ARG if !SOC_NVIDIA_TEGRA210 > Yeah, hmm, looks like it is. […] That seems like a doable approach. -- To view, visit https://review.coreboot.org/c/coreboot/+/36275 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I86cdc5c2fac76797732a3a3398f50c4d1ff6647a Gerrit-Change-Number: 36275 Gerrit-PatchSet: 20 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 31 Oct 2019 03:01:33 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Aaron Durbin <adurbin(a)chromium.org> Comment-In-Reply-To: Julius Werner <jwerner(a)chromium.org> Comment-In-Reply-To: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: util/ifdtool: Add Tigerlake platform support under IFDv2
by Subrata Banik (Code Review) 31 Oct '19

31 Oct '19

Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36242 ) Change subject: util/ifdtool: Add Tigerlake platform support under IFDv2 ...................................................................... Patch Set 4: HI Ravi, Can you please just rebase this patch alone, i guess we can let this CL merge without any trouble ? -- To view, visit https://review.coreboot.org/c/coreboot/+/36242 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I3f9672053dcf0a4462ef6ab718af4f18fcfa7e14 Gerrit-Change-Number: 36242 Gerrit-PatchSet: 4 Gerrit-Owner: Ravishankar Sarawadi <ravishankar.sarawadi(a)intel.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: John Zhao <john.zhao(a)intel.com> Gerrit-Reviewer: Raj Astekar <raj.astekar(a)intel.com> Gerrit-Reviewer: Ravishankar Sarawadi <ravishankar.sarawadi(a)intel.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 31 Oct 2019 01:59:50 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: soc/intel/icelake: Remove redundent dependency check in cpu.c
by Subrata Banik (Code Review) 31 Oct '19

31 Oct '19

Subrata Banik has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/36431 ) Change subject: soc/intel/icelake: Remove redundent dependency check in cpu.c ...................................................................... soc/intel/icelake: Remove redundent dependency check in cpu.c This patch removes redundent dependency check related to CONFIG_BOOT_DEVICE_SPI_FLASH kconfig inside bootblock/cpu.c. CONFIG_BOOT_DEVICE_MEMORY_MAPPED is enable if CONFIG_BOOT_DEVICE_SPI_FLASH is selected. TEST=Able to build and boot ICL DE board. Change-Id: I46d9ec054c4804ca756f2101085a55e91b5cc6f0 Signed-off-by: Subrata Banik <subrata.banik(a)intel.com> --- M src/soc/intel/icelake/bootblock/cpu.c 1 file changed, 1 insertion(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/31/36431/1 diff --git a/src/soc/intel/icelake/bootblock/cpu.c b/src/soc/intel/icelake/bootblock/cpu.c index e23286c..4b092e2 100644 --- a/src/soc/intel/icelake/bootblock/cpu.c +++ b/src/soc/intel/icelake/bootblock/cpu.c @@ -20,7 +20,6 @@ void bootblock_cpu_init(void) { /* Temporarily cache the memory-mapped boot media. */ - if (CONFIG(BOOT_DEVICE_MEMORY_MAPPED) && - CONFIG(BOOT_DEVICE_SPI_FLASH)) + if (CONFIG(BOOT_DEVICE_MEMORY_MAPPED)) fast_spi_cache_bios_region(); } -- To view, visit https://review.coreboot.org/c/coreboot/+/36431 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I46d9ec054c4804ca756f2101085a55e91b5cc6f0 Gerrit-Change-Number: 36431 Gerrit-PatchSet: 1 Gerrit-Owner: Subrata Banik <subrata.banik(a)intel.com> Gerrit-MessageType: newchange

4 18

Change in coreboot[master]: soc/intel/broadwell_de: Define and use MMCONF_BUS_NUMBER
by build bot (Jenkins) (Code Review) 31 Oct '19

31 Oct '19

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35878 ) Change subject: soc/intel/broadwell_de: Define and use MMCONF_BUS_NUMBER ...................................................................... Patch Set 5: (1 comment) https://review.coreboot.org/c/coreboot/+/35878/5/src/soc/intel/fsp_broadwel… File src/soc/intel/fsp_broadwell_de/acpi.c: https://review.coreboot.org/c/coreboot/+/35878/5/src/soc/intel/fsp_broadwel… PS5, Line 150: MCFG_BASE_ADDRESS, 0, 0, code indent should use tabs where possible -- To view, visit https://review.coreboot.org/c/coreboot/+/35878 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I43f08f3ecb97793b5ee150ca246b80f3503f4cfa Gerrit-Change-Number: 35878 Gerrit-PatchSet: 5 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Comment-Date: Thu, 31 Oct 2019 01:47:52 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: soc/intel: Use common Kconfig symbols for PCIE config space size
by Arthur Heymans (Code Review) 31 Oct '19

31 Oct '19

Hello Patrick Rudolph, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/35877 to look at the new patch set (#5). Change subject: soc/intel: Use common Kconfig symbols for PCIE config space size ...................................................................... soc/intel: Use common Kconfig symbols for PCIE config space size PCIe mmconf is not INTEL_SA specific, therefore use the common CONFIG_MMCONF_BUS_NUMBER. Change-Id: I179e6c4e84664c7a7581e6103cfc079eb5c449f5 Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz> --- M src/soc/intel/apollolake/Kconfig M src/soc/intel/apollolake/systemagent.c M src/soc/intel/cannonlake/Kconfig M src/soc/intel/cannonlake/systemagent.c M src/soc/intel/common/block/acpi/acpi.c M src/soc/intel/common/block/systemagent/Kconfig M src/soc/intel/common/block/systemagent/systemagent_early.c M src/soc/intel/icelake/Kconfig M src/soc/intel/icelake/systemagent.c M src/soc/intel/skylake/Kconfig M src/soc/intel/skylake/acpi.c M src/soc/intel/skylake/systemagent.c 12 files changed, 32 insertions(+), 32 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/77/35877/5 -- To view, visit https://review.coreboot.org/c/coreboot/+/35877 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I179e6c4e84664c7a7581e6103cfc079eb5c449f5 Gerrit-Change-Number: 35877 Gerrit-PatchSet: 5 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: arch/arm64: Pass cbmem_top to ramstage via calling argument
by Julius Werner (Code Review) 30 Oct '19

30 Oct '19

Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36275 ) Change subject: arch/arm64: Pass cbmem_top to ramstage via calling argument ...................................................................... Patch Set 20: (1 comment) https://review.coreboot.org/c/coreboot/+/36275/20/src/arch/arm64/Kconfig File src/arch/arm64/Kconfig: https://review.coreboot.org/c/coreboot/+/36275/20/src/arch/arm64/Kconfig@20 PS20, Line 20: select RAMSTAGE_CBMEM_TOP_ARG if !SOC_NVIDIA_TEGRA210 > Is this the only chipset that cannot switch to the new scheme? Otherwise (if we need to have excepti […] Yeah, hmm, looks like it is. Another really simple solution would be to just call _cbmem_top_ptr = cbmem_top_chipset(); near the end of ramstage_entry(). That's not parameter passing, but the platform doesn't really need that to work because its cbmem_top_chipset() works fine in both stages. -- To view, visit https://review.coreboot.org/c/coreboot/+/36275 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I86cdc5c2fac76797732a3a3398f50c4d1ff6647a Gerrit-Change-Number: 36275 Gerrit-PatchSet: 20 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 30 Oct 2019 23:01:41 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Aaron Durbin <adurbin(a)chromium.org> Comment-In-Reply-To: Julius Werner <jwerner(a)chromium.org> Comment-In-Reply-To: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: arch/arm64: Pass cbmem_top to ramstage via calling argument
by Julius Werner (Code Review) 30 Oct '19

30 Oct '19

Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36275 ) Change subject: arch/arm64: Pass cbmem_top to ramstage via calling argument ...................................................................... Patch Set 20: Code-Review+2 (1 comment) https://review.coreboot.org/c/coreboot/+/36275/20/src/arch/arm64/Kconfig File src/arch/arm64/Kconfig: https://review.coreboot.org/c/coreboot/+/36275/20/src/arch/arm64/Kconfig@20 PS20, Line 20: select RAMSTAGE_CBMEM_TOP_ARG if !SOC_NVIDIA_TEGRA210 > > We need a way to pass arguments to this one. Otherwise it'll be a constant sore thumb. […] Is this the only chipset that cannot switch to the new scheme? Otherwise (if we need to have exceptions anyway), I don't think this is really worth solving. -- To view, visit https://review.coreboot.org/c/coreboot/+/36275 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I86cdc5c2fac76797732a3a3398f50c4d1ff6647a Gerrit-Change-Number: 36275 Gerrit-PatchSet: 20 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 30 Oct 2019 22:55:23 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Aaron Durbin <adurbin(a)chromium.org> Comment-In-Reply-To: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: device/Kconfig: hide display menu when NO_GFX_INIT is selected
by Michael Niewöhner (Code Review) 30 Oct '19

30 Oct '19

Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36444 ) Change subject: device/Kconfig: hide display menu when NO_GFX_INIT is selected ...................................................................... Patch Set 1: (1 comment) https://review.coreboot.org/c/coreboot/+/36444/1/src/device/Kconfig File src/device/Kconfig: https://review.coreboot.org/c/coreboot/+/36444/1/src/device/Kconfig@a255 PS1, Line 255: depends on HAVE_VGA_TEXT_FRAMEBUFFER || HAVE_LINEAR_FRAMEBUFFER > These should already imply !NO_GFX_INIT. I guess you could move the […] Huh? HAVE_* are selected by the drivers, not by the user -- To view, visit https://review.coreboot.org/c/coreboot/+/36444 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iec5a47f84b8c776a45edc6f4b31a03b9ac714b4e Gerrit-Change-Number: 36444 Gerrit-PatchSet: 1 Gerrit-Owner: Michael Niewöhner Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Michael Niewöhner Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 30 Oct 2019 22:47:06 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: Makefile.inc: Consolidate submodule comments
by Marshall Dawson (Code Review) 30 Oct '19

30 Oct '19

Marshall Dawson has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/36440 ) Change subject: Makefile.inc: Consolidate submodule comments ...................................................................... Makefile.inc: Consolidate submodule comments Reduce duplicated comments explaining that submodules' settings in .gitmodules are update=none, and that --checkout is required. This prepares for another submodule, and makes adding a third set of comments unnecessary. Change-Id: I7721333a61122284ed9975ecd2adc3271a879728 Signed-off-by: Marshall Dawson <marshalldawson3rd(a)gmail.com> --- M Makefile.inc 1 file changed, 2 insertions(+), 4 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/40/36440/1 diff --git a/Makefile.inc b/Makefile.inc index f7f3708..79fc256 100644 --- a/Makefile.inc +++ b/Makefile.inc @@ -193,13 +193,11 @@ # try to fetch non-optional submodules if the source is under git forgetthis:=$(if $(GIT),$(shell git submodule update --init)) ifeq ($(CONFIG_USE_BLOBS),y) -# this is necessary because 3rdparty/{blobs,intel-microcode} is update=none, and so is ignored -# unless explicitly requested and enabled through --checkout +# These items are necessary because each has update=none in .gitmodules. They are ignored +# until expressly requested and enabled with --checkout forgetthis:=$(if $(GIT),$(shell git submodule update --init --checkout 3rdparty/blobs)) forgetthis:=$(if $(GIT),$(shell git submodule update --init --checkout 3rdparty/intel-microcode)) ifeq ($(CONFIG_PLATFORM_USES_FSP1_0)$(CONFIG_PLATFORM_USES_FSP1_1)$(CONFIG_PLATFORM_USES_FSP2_0),y) -# this is necessary because 3rdparty/fsp is update=none, and so is ignored -# unless explicitly requested and enabled through --checkout forgetthis:=$(if $(GIT),$(shell git submodule update --init --checkout 3rdparty/fsp)) endif endif -- To view, visit https://review.coreboot.org/c/coreboot/+/36440 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I7721333a61122284ed9975ecd2adc3271a879728 Gerrit-Change-Number: 36440 Gerrit-PatchSet: 1 Gerrit-Owner: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-MessageType: newchange

3 2

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit October 2019