mail.coreboot.org
Sign In
Sign Up
Sign In
Sign Up
Manage this list
×
Keyboard Shortcuts
Thread View
j
: Next unread message
k
: Previous unread message
j a
: Jump to all threads
j l
: Jump to MailingList overview
2024
November
October
September
August
July
June
May
April
March
February
January
2023
December
November
October
September
August
July
June
May
April
March
February
January
2022
December
November
October
September
August
July
June
May
April
March
February
January
2021
December
November
October
September
August
July
June
May
April
March
February
January
2020
December
November
October
September
August
July
June
May
April
March
February
January
2019
December
November
October
September
August
July
June
May
April
March
February
January
2018
December
November
October
September
August
July
June
May
April
March
February
January
2017
December
November
October
September
August
July
June
May
April
March
February
January
2016
December
November
October
September
August
July
June
May
April
March
February
January
2015
December
November
October
September
August
July
June
May
April
March
February
January
2014
December
November
October
September
August
July
June
May
April
March
February
January
2013
December
November
October
September
August
July
June
May
April
March
List overview
Download
coreboot-gerrit
June 2018
----- 2024 -----
November 2024
October 2024
September 2024
August 2024
July 2024
June 2024
May 2024
April 2024
March 2024
February 2024
January 2024
----- 2023 -----
December 2023
November 2023
October 2023
September 2023
August 2023
July 2023
June 2023
May 2023
April 2023
March 2023
February 2023
January 2023
----- 2022 -----
December 2022
November 2022
October 2022
September 2022
August 2022
July 2022
June 2022
May 2022
April 2022
March 2022
February 2022
January 2022
----- 2021 -----
December 2021
November 2021
October 2021
September 2021
August 2021
July 2021
June 2021
May 2021
April 2021
March 2021
February 2021
January 2021
----- 2020 -----
December 2020
November 2020
October 2020
September 2020
August 2020
July 2020
June 2020
May 2020
April 2020
March 2020
February 2020
January 2020
----- 2019 -----
December 2019
November 2019
October 2019
September 2019
August 2019
July 2019
June 2019
May 2019
April 2019
March 2019
February 2019
January 2019
----- 2018 -----
December 2018
November 2018
October 2018
September 2018
August 2018
July 2018
June 2018
May 2018
April 2018
March 2018
February 2018
January 2018
----- 2017 -----
December 2017
November 2017
October 2017
September 2017
August 2017
July 2017
June 2017
May 2017
April 2017
March 2017
February 2017
January 2017
----- 2016 -----
December 2016
November 2016
October 2016
September 2016
August 2016
July 2016
June 2016
May 2016
April 2016
March 2016
February 2016
January 2016
----- 2015 -----
December 2015
November 2015
October 2015
September 2015
August 2015
July 2015
June 2015
May 2015
April 2015
March 2015
February 2015
January 2015
----- 2014 -----
December 2014
November 2014
October 2014
September 2014
August 2014
July 2014
June 2014
May 2014
April 2014
March 2014
February 2014
January 2014
----- 2013 -----
December 2013
November 2013
October 2013
September 2013
August 2013
July 2013
June 2013
May 2013
April 2013
March 2013
coreboot-gerrit@coreboot.org
1 participants
2751 discussions
Start a n
N
ew thread
Change in coreboot[master]: ec/google/chromeec: Remove keyboard initialization
by build bot (Jenkins) (Code Review)
30 Jun '18
30 Jun '18
build bot (Jenkins) has posted comments on this change. (
https://review.coreboot.org/27293
) Change subject: ec/google/chromeec: Remove keyboard initialization ...................................................................... Patch Set 2: No Builds Executed -- To view, visit
https://review.coreboot.org/27293
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia0b56abe0a5990e527277eaf3397e00dccda3e50 Gerrit-Change-Number: 27293 Gerrit-PatchSet: 2 Gerrit-Owner: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Duncan Laurie <dlaurie(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sat, 30 Jun 2018 00:53:59 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No
1
0
0
0
Change in coreboot[master]: mb/intel/glkrvp: Get rid of DRIVERS_PS2_KEYBOARD selection
by build bot (Jenkins) (Code Review)
30 Jun '18
30 Jun '18
build bot (Jenkins) has posted comments on this change. (
https://review.coreboot.org/27292
) Change subject: mb/intel/glkrvp: Get rid of DRIVERS_PS2_KEYBOARD selection ...................................................................... Patch Set 2: No Builds Executed -- To view, visit
https://review.coreboot.org/27292
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9af48e648231c18f98d0cc1ddd178b8d00082b0a Gerrit-Change-Number: 27292 Gerrit-PatchSet: 2 Gerrit-Owner: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Duncan Laurie <dlaurie(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sat, 30 Jun 2018 00:53:58 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No
1
0
0
0
Change in coreboot[master]: intel/wifi: Add WGDS ACPI method for Geo Aware SAR
by build bot (Jenkins) (Code Review)
29 Jun '18
29 Jun '18
build bot (Jenkins) has posted comments on this change. (
https://review.coreboot.org/21098
) Change subject: intel/wifi: Add WGDS ACPI method for Geo Aware SAR ...................................................................... Patch Set 7: Verified+1 Build Successful
https://qa.coreboot.org/job/coreboot-checkpatch/29671/
: SUCCESS
https://qa.coreboot.org/job/coreboot-gerrit/75614/
: SUCCESS -- To view, visit
https://review.coreboot.org/21098
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4f602e3f95ff3545db6cc6e428beb9a36abd9296 Gerrit-Change-Number: 21098 Gerrit-PatchSet: 7 Gerrit-Owner: Pratikkumar V Prajapati <pratikkumar.v.prajapati(a)intel.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Duncan Laurie <dlaurie(a)chromium.org> Gerrit-Reviewer: Hannah Williams <hannah.williams(a)intel.com> Gerrit-Reviewer: Hima B Chilmakuru <hima.b.chilmakuru(a)intel.com> Gerrit-Reviewer: Lijian Zhao <lijian.zhao(a)intel.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Pratikkumar V Prajapati <pratikkumar.v.prajapati(a)intel.com> Gerrit-Reviewer: Todd Broch <tbroch(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Furquan Shaikh <furquan(a)google.com> Gerrit-Comment-Date: Fri, 29 Jun 2018 21:48:31 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes
1
0
0
0
Change in coreboot[master]: eve: Select WIFI_SAR_CBFS and add SAR default settings to CBFS
by build bot (Jenkins) (Code Review)
29 Jun '18
29 Jun '18
build bot (Jenkins) has posted comments on this change. (
https://review.coreboot.org/26223
) Change subject: eve: Select WIFI_SAR_CBFS and add SAR default settings to CBFS ...................................................................... Patch Set 5: Verified+1 Build Successful
https://qa.coreboot.org/job/coreboot-checkpatch/29672/
: SUCCESS
https://qa.coreboot.org/job/coreboot-gerrit/75615/
: SUCCESS -- To view, visit
https://review.coreboot.org/26223
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I851478731ad5aff58a0ca098ebd7b216a56751e0 Gerrit-Change-Number: 26223 Gerrit-PatchSet: 5 Gerrit-Owner: Pratikkumar V Prajapati <pratikkumar.v.prajapati(a)intel.com> Gerrit-Reviewer: Luca Coelho <luciano.coelho(a)intel.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Pratikkumar V Prajapati <pratikkumar.v.prajapati(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Furquan Shaikh <furquan(a)google.com> Gerrit-Comment-Date: Fri, 29 Jun 2018 21:48:05 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes
1
0
0
0
Change in coreboot[master]: [Do Not Merge] add i945G based mainboard
by build bot (Jenkins) (Code Review)
29 Jun '18
29 Jun '18
build bot (Jenkins) has posted comments on this change. (
https://review.coreboot.org/25509
) Change subject: [Do Not Merge] add i945G based mainboard ...................................................................... Patch Set 13: Verified-1 Build Failed
https://qa.coreboot.org/job/coreboot-gerrit/75613/
: FAILURE
https://qa.coreboot.org/job/coreboot-checkpatch/29670/
: SUCCESS -- To view, visit
https://review.coreboot.org/25509
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5398b990c26d087afb20e4b1028a7a1cad4b3ee3 Gerrit-Change-Number: 25509 Gerrit-PatchSet: 13 Gerrit-Owner: Elyes HAOUAS <ehaouas(a)noos.fr> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Elyes HAOUAS <ehaouas(a)noos.fr> Gerrit-Reviewer: Idwer Vollering <vidwer(a)gmail.com> Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 29 Jun 2018 21:30:07 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes
1
0
0
0
Change in coreboot[master]: [Do Not Merge] add i945G based mainboard
by build bot (Jenkins) (Code Review)
29 Jun '18
29 Jun '18
build bot (Jenkins) has posted comments on this change. (
https://review.coreboot.org/25509
) Change subject: [Do Not Merge] add i945G based mainboard ...................................................................... Patch Set 13: (46 comments)
https://review.coreboot.org/#/c/25509/13/src/mainboard/nec/945g-m4/cstates.c
File src/mainboard/nec/945g-m4/cstates.c:
https://review.coreboot.org/#/c/25509/13/src/mainboard/nec/945g-m4/cstates.…
PS13, Line 20: } adding a line without newline at end of file
https://review.coreboot.org/#/c/25509/13/src/mainboard/nec/945g-m4/romstage…
File src/mainboard/nec/945g-m4/romstage.c:
https://review.coreboot.org/#/c/25509/13/src/mainboard/nec/945g-m4/romstage…
PS13, Line 59: FDD_LPC_EN | KBC_LPC_EN |CNF1_LPC_EN |CNF2_LPC_EN); need consistent spacing around '|' (ctx:WxV)
https://review.coreboot.org/#/c/25509/13/src/mainboard/nec/945g-m4/romstage…
PS13, Line 59: FDD_LPC_EN | KBC_LPC_EN |CNF1_LPC_EN |CNF2_LPC_EN); need consistent spacing around '|' (ctx:WxV)
https://review.coreboot.org/#/c/25509/13/src/mainboard/nec/945g-m4/romstage…
PS13, Line 92: pnp_write_config(GPIO_MIDI_DEV, 0x60, 0x00); code indent should use tabs where possible
https://review.coreboot.org/#/c/25509/13/src/mainboard/nec/945g-m4/romstage…
PS13, Line 92: pnp_write_config(GPIO_MIDI_DEV, 0x60, 0x00); please, no spaces at the start of a line
https://review.coreboot.org/#/c/25509/13/src/mainboard/nec/945g-m4/romstage…
PS13, Line 93: pnp_write_config(GPIO_MIDI_DEV, 0x61, 0x00); code indent should use tabs where possible
https://review.coreboot.org/#/c/25509/13/src/mainboard/nec/945g-m4/romstage…
PS13, Line 93: pnp_write_config(GPIO_MIDI_DEV, 0x61, 0x00); please, no spaces at the start of a line
https://review.coreboot.org/#/c/25509/13/src/mainboard/nec/945g-m4/romstage…
PS13, Line 94: pnp_write_config(GPIO_MIDI_DEV, 0x62, 0x00); code indent should use tabs where possible
https://review.coreboot.org/#/c/25509/13/src/mainboard/nec/945g-m4/romstage…
PS13, Line 94: pnp_write_config(GPIO_MIDI_DEV, 0x62, 0x00); please, no spaces at the start of a line
https://review.coreboot.org/#/c/25509/13/src/mainboard/nec/945g-m4/romstage…
PS13, Line 95: pnp_write_config(GPIO_MIDI_DEV, 0x63, 0x00); code indent should use tabs where possible
https://review.coreboot.org/#/c/25509/13/src/mainboard/nec/945g-m4/romstage…
PS13, Line 95: pnp_write_config(GPIO_MIDI_DEV, 0x63, 0x00); please, no spaces at the start of a line
https://review.coreboot.org/#/c/25509/13/src/mainboard/nec/945g-m4/romstage…
PS13, Line 96: pnp_write_config(GPIO_MIDI_DEV, 0x70, 0x00); code indent should use tabs where possible
https://review.coreboot.org/#/c/25509/13/src/mainboard/nec/945g-m4/romstage…
PS13, Line 96: pnp_write_config(GPIO_MIDI_DEV, 0x70, 0x00); please, no spaces at the start of a line
https://review.coreboot.org/#/c/25509/13/src/mainboard/nec/945g-m4/romstage…
PS13, Line 97: pnp_write_config(GPIO_MIDI_DEV, 0xf0, 0x5f); code indent should use tabs where possible
https://review.coreboot.org/#/c/25509/13/src/mainboard/nec/945g-m4/romstage…
PS13, Line 97: pnp_write_config(GPIO_MIDI_DEV, 0xf0, 0x5f); please, no spaces at the start of a line
https://review.coreboot.org/#/c/25509/13/src/mainboard/nec/945g-m4/romstage…
PS13, Line 98: pnp_write_config(GPIO_MIDI_DEV, 0xf1, 0x5f); code indent should use tabs where possible
https://review.coreboot.org/#/c/25509/13/src/mainboard/nec/945g-m4/romstage…
PS13, Line 98: pnp_write_config(GPIO_MIDI_DEV, 0xf1, 0x5f); please, no spaces at the start of a line
https://review.coreboot.org/#/c/25509/13/src/mainboard/nec/945g-m4/romstage…
PS13, Line 127: pnp_enter_conf_state(HWM_DEV); code indent should use tabs where possible
https://review.coreboot.org/#/c/25509/13/src/mainboard/nec/945g-m4/romstage…
PS13, Line 127: pnp_enter_conf_state(HWM_DEV); please, no spaces at the start of a line
https://review.coreboot.org/#/c/25509/13/src/mainboard/nec/945g-m4/romstage…
PS13, Line 128: pnp_set_logical_device(HWM_DEV); code indent should use tabs where possible
https://review.coreboot.org/#/c/25509/13/src/mainboard/nec/945g-m4/romstage…
PS13, Line 128: pnp_set_logical_device(HWM_DEV); please, no spaces at the start of a line
https://review.coreboot.org/#/c/25509/13/src/mainboard/nec/945g-m4/romstage…
PS13, Line 129: pnp_set_iobase(HWM_DEV, PNP_IDX_IO0, 0x290); code indent should use tabs where possible
https://review.coreboot.org/#/c/25509/13/src/mainboard/nec/945g-m4/romstage…
PS13, Line 129: pnp_set_iobase(HWM_DEV, PNP_IDX_IO0, 0x290); please, no spaces at the start of a line
https://review.coreboot.org/#/c/25509/13/src/mainboard/nec/945g-m4/romstage…
PS13, Line 149: } code indent should use tabs where possible
https://review.coreboot.org/#/c/25509/13/src/mainboard/nec/945g-m4/romstage…
PS13, Line 149: } please, no spaces at the start of a line
https://review.coreboot.org/#/c/25509/13/src/mainboard/nec/945g-m4/romstage…
PS13, Line 171: printk(BIOS_DEBUG, "program secondary mlt XXX byte \n"); unnecessary whitespace before a quoted newline
https://review.coreboot.org/#/c/25509/13/src/mainboard/nec/945g-m4/romstage…
PS13, Line 173: printk(BIOS_DEBUG, "reset rtc power status \n"); unnecessary whitespace before a quoted newline
https://review.coreboot.org/#/c/25509/13/src/mainboard/nec/945g-m4/romstage…
PS13, Line 177: printk(BIOS_DEBUG, "usb transient disconnect \n"); unnecessary whitespace before a quoted newline
https://review.coreboot.org/#/c/25509/13/src/mainboard/nec/945g-m4/romstage…
PS13, Line 263: printk(BIOS_DEBUG, "Enable SPD ROMs and DDR-II DRAM \n"); unnecessary whitespace before a quoted newline
https://review.coreboot.org/#/c/25509/13/src/mainboard/nec/945g-m4/romstage…
PS13, Line 272: printk(BIOS_DEBUG, "Perform some initialization that must run before stage2 \n"); unnecessary whitespace before a quoted newline
https://review.coreboot.org/#/c/25509/13/src/mainboard/nec/945g-m4/romstage…
PS13, Line 276: printk(BIOS_DEBUG, "Chipset Errata! \n"); unnecessary whitespace before a quoted newline
https://review.coreboot.org/#/c/25509/13/src/mainboard/nec/945g-m4/romstage…
PS13, Line 279: printk(BIOS_DEBUG, "Initialize the internal PCIe links before we go into stage2 \n"); unnecessary whitespace before a quoted newline
https://review.coreboot.org/#/c/25509/13/src/mainboard/nec/945g-m4/romstage…
PS13, Line 285: init_tpm(s3resume); code indent should use tabs where possible
https://review.coreboot.org/#/c/25509/13/src/mainboard/nec/945g-m4/romstage…
PS13, Line 285: init_tpm(s3resume); please, no spaces at the start of a line
https://review.coreboot.org/#/c/25509/13/src/mainboard/nec/945g-m4/superio_…
File src/mainboard/nec/945g-m4/superio_hwm.c:
https://review.coreboot.org/#/c/25509/13/src/mainboard/nec/945g-m4/superio_…
PS13, Line 83: //if (get_option(&cpufan_temperature, "cpufan_temperature") != CB_SUCCESS) line over 80 characters
https://review.coreboot.org/#/c/25509/13/src/mainboard/nec/945g-m4/superio_…
PS13, Line 90: //if (get_option(&sysfan_temperature, "sysfan_temperature") != CB_SUCCESS) line over 80 characters
https://review.coreboot.org/#/c/25509/13/src/mainboard/nec/945g-m4/superio_…
PS13, Line 116: case FAN_CRUISE_CONTROL_SPEED: fan_config |= (2 << 4); break; trailing statements should be on next line
https://review.coreboot.org/#/c/25509/13/src/mainboard/nec/945g-m4/superio_…
PS13, Line 117: case FAN_CRUISE_CONTROL_THERMAL: fan_config |= (1 << 4); break; trailing statements should be on next line
https://review.coreboot.org/#/c/25509/13/src/mainboard/nec/945g-m4/superio_…
PS13, Line 120: case FAN_CRUISE_CONTROL_SPEED: fan_config |= (2 << 2); break; trailing statements should be on next line
https://review.coreboot.org/#/c/25509/13/src/mainboard/nec/945g-m4/superio_…
PS13, Line 121: case FAN_CRUISE_CONTROL_THERMAL: fan_config |= (1 << 2); break; trailing statements should be on next line
https://review.coreboot.org/#/c/25509/13/src/mainboard/nec/945g-m4/superio_…
PS13, Line 130: hwm_write(0x06, fan_speeds[cpufan_speed].fan_in); // CPUFANIN target speed line over 80 characters
https://review.coreboot.org/#/c/25509/13/src/mainboard/nec/945g-m4/superio_…
PS13, Line 135: temperatures[cpufan_temperature].deg_fahrenheit); line over 80 characters
https://review.coreboot.org/#/c/25509/13/src/mainboard/nec/945g-m4/superio_…
PS13, Line 136: hwm_write(0x06, temperatures[cpufan_temperature].deg_celsius); // CPUFANIN target temperature line over 80 characters
https://review.coreboot.org/#/c/25509/13/src/mainboard/nec/945g-m4/superio_…
PS13, Line 144: hwm_write(0x05, fan_speeds[sysfan_speed].fan_in); // SYSFANIN target speed line over 80 characters
https://review.coreboot.org/#/c/25509/13/src/mainboard/nec/945g-m4/superio_…
PS13, Line 149: temperatures[sysfan_temperature].deg_fahrenheit); line over 80 characters
https://review.coreboot.org/#/c/25509/13/src/mainboard/nec/945g-m4/superio_…
PS13, Line 150: hwm_write(0x05, temperatures[sysfan_temperature].deg_celsius); // SYSFANIN target temperature line over 80 characters -- To view, visit
https://review.coreboot.org/25509
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5398b990c26d087afb20e4b1028a7a1cad4b3ee3 Gerrit-Change-Number: 25509 Gerrit-PatchSet: 13 Gerrit-Owner: Elyes HAOUAS <ehaouas(a)noos.fr> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Elyes HAOUAS <ehaouas(a)noos.fr> Gerrit-Reviewer: Idwer Vollering <vidwer(a)gmail.com> Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 29 Jun 2018 21:30:05 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No
1
0
0
0
Change in coreboot[master]: src/cpu/intel: Add model_f6x
by build bot (Jenkins) (Code Review)
29 Jun '18
29 Jun '18
build bot (Jenkins) has posted comments on this change. (
https://review.coreboot.org/25565
) Change subject: src/cpu/intel: Add model_f6x ...................................................................... Patch Set 9: Build Successful
https://qa.coreboot.org/job/coreboot-checkpatch/29669/
: SUCCESS
https://qa.coreboot.org/job/coreboot-gerrit/75612/
: SUCCESS -- To view, visit
https://review.coreboot.org/25565
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6003ec0f4d4245ce5fc9c1f38e555bfcfa1c22b5 Gerrit-Change-Number: 25565 Gerrit-PatchSet: 9 Gerrit-Owner: Elyes HAOUAS <ehaouas(a)noos.fr> Gerrit-Reviewer: Elyes HAOUAS <ehaouas(a)noos.fr> Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Comment-Date: Fri, 29 Jun 2018 21:19:25 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No
1
0
0
0
Change in coreboot[master]: cpu/intel/speedstep/acpi.c: Add Netburst CPUs
by build bot (Jenkins) (Code Review)
29 Jun '18
29 Jun '18
build bot (Jenkins) has posted comments on this change. (
https://review.coreboot.org/22604
) Change subject: cpu/intel/speedstep/acpi.c: Add Netburst CPUs ...................................................................... Patch Set 12: Build Successful
https://qa.coreboot.org/job/coreboot-checkpatch/29668/
: SUCCESS
https://qa.coreboot.org/job/coreboot-gerrit/75611/
: SUCCESS -- To view, visit
https://review.coreboot.org/22604
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I06e162d3260dedeb3b16583460633507fbcbd52a Gerrit-Change-Number: 22604 Gerrit-PatchSet: 12 Gerrit-Owner: Elyes HAOUAS <ehaouas(a)noos.fr> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Elyes HAOUAS <ehaouas(a)noos.fr> Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 29 Jun 2018 21:12:45 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No
1
0
0
0
Change in coreboot[master]: cpu/intel/speedstep/acpi.c: Add Netburst CPUs
by build bot (Jenkins) (Code Review)
29 Jun '18
29 Jun '18
build bot (Jenkins) has posted comments on this change. (
https://review.coreboot.org/22604
) Change subject: cpu/intel/speedstep/acpi.c: Add Netburst CPUs ...................................................................... Patch Set 12: (13 comments)
https://review.coreboot.org/#/c/22604/12/src/cpu/intel/speedstep/acpi.c
File src/cpu/intel/speedstep/acpi.c:
https://review.coreboot.org/#/c/22604/12/src/cpu/intel/speedstep/acpi.c@68
PS12, Line 68: if ( c.x86_model ==2) spaces required around that '==' (ctx:WxV)
https://review.coreboot.org/#/c/22604/12/src/cpu/intel/speedstep/acpi.c@68
PS12, Line 68: if ( c.x86_model ==2) space prohibited after that open parenthesis '('
https://review.coreboot.org/#/c/22604/12/src/cpu/intel/speedstep/acpi.c@92
PS12, Line 92: else else is not generally useful after a break or return
https://review.coreboot.org/#/c/22604/12/src/cpu/intel/speedstep/speedstep.c
File src/cpu/intel/speedstep/speedstep.c:
https://review.coreboot.org/#/c/22604/12/src/cpu/intel/speedstep/speedstep.…
PS12, Line 45: if (((rdmsr(MSR_EXTENDED_CONFIG).lo >> 27) & 3) == 3) {/*supported and line over 80 characters
https://review.coreboot.org/#/c/22604/12/src/cpu/intel/speedstep/speedstep.…
PS12, Line 46: enabled bits */ line over 80 characters
https://review.coreboot.org/#/c/22604/12/src/cpu/intel/speedstep/speedstep.…
PS12, Line 48: params->slfm = SPEEDSTEP_STATE_FROM_MSR(msr.lo, state_mask); line over 80 characters
https://review.coreboot.org/#/c/22604/12/src/cpu/intel/speedstep/speedstep.…
PS12, Line 52: } code indent should use tabs where possible
https://review.coreboot.org/#/c/22604/12/src/cpu/intel/speedstep/speedstep.…
PS12, Line 52: } please, no spaces at the start of a line
https://review.coreboot.org/#/c/22604/12/src/cpu/intel/speedstep/speedstep.…
PS12, Line 73: if (!(((cpuid_eax(1) >> 8) & 0xf) == 0xf)) { suspect code indent for conditional statements (8, 8)
https://review.coreboot.org/#/c/22604/12/src/cpu/intel/speedstep/speedstep.…
PS12, Line 77: !(rdmsr(IA32_MISC_ENABLES).hi & (1 << (38 - 32)))) { line over 80 characters
https://review.coreboot.org/#/c/22604/12/src/cpu/intel/speedstep/speedstep.…
PS12, Line 79: params->turbo = SPEEDSTEP_STATE_FROM_MSR(msr.hi, state_mask); line over 80 characters
https://review.coreboot.org/#/c/22604/12/src/cpu/intel/speedstep/speedstep.…
PS12, Line 82: } code indent should use tabs where possible
https://review.coreboot.org/#/c/22604/12/src/cpu/intel/speedstep/speedstep.…
PS12, Line 82: } please, no spaces at the start of a line -- To view, visit
https://review.coreboot.org/22604
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I06e162d3260dedeb3b16583460633507fbcbd52a Gerrit-Change-Number: 22604 Gerrit-PatchSet: 12 Gerrit-Owner: Elyes HAOUAS <ehaouas(a)noos.fr> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Elyes HAOUAS <ehaouas(a)noos.fr> Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 29 Jun 2018 21:12:43 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No
1
0
0
0
Change in coreboot[master]: eve: Select WIFI_SAR_CBFS and add SAR default settings to CBFS
by build bot (Jenkins) (Code Review)
29 Jun '18
29 Jun '18
build bot (Jenkins) has posted comments on this change. (
https://review.coreboot.org/26223
) Change subject: eve: Select WIFI_SAR_CBFS and add SAR default settings to CBFS ...................................................................... Patch Set 4: Verified-1 Build Unstable
https://qa.coreboot.org/job/coreboot-gerrit/75610/
: UNSTABLE
https://qa.coreboot.org/job/coreboot-checkpatch/29667/
: SUCCESS -- To view, visit
https://review.coreboot.org/26223
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I851478731ad5aff58a0ca098ebd7b216a56751e0 Gerrit-Change-Number: 26223 Gerrit-PatchSet: 4 Gerrit-Owner: Pratikkumar V Prajapati <pratikkumar.v.prajapati(a)intel.com> Gerrit-Reviewer: Luca Coelho <luciano.coelho(a)intel.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Pratikkumar V Prajapati <pratikkumar.v.prajapati(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Furquan Shaikh <furquan(a)google.com> Gerrit-Comment-Date: Fri, 29 Jun 2018 21:08:15 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes
1
0
0
0
← Newer
1
2
3
4
5
6
7
...
276
Older →
Jump to page:
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
Results per page:
10
25
50
100
200