coreboot-gerrit June 2018

coreboot-gerrit@coreboot.org

1 participants
2751 discussions

Change in libgfxinit[master]: gma config: Introduce Has_Tertiary_Pipe
by Nico Huber (Code Review) 13 Jun '18

13 Jun '18

Nico Huber has uploaded this change for review. ( https://review.coreboot.org/27048 Change subject: gma config: Introduce Has_Tertiary_Pipe ...................................................................... gma config: Introduce Has_Tertiary_Pipe And use it instead of `Supported_Pipe`. Change-Id: Id3c4bdaf0d6b6c6126692b00cbabaf7d3f85b4bf Signed-off-by: Nico Huber <nico.h(a)gmx.de> --- M common/hw-gfx-gma-config.ads.template M common/hw-gfx-gma-config_helpers.adb 2 files changed, 3 insertions(+), 10 deletions(-) git pull ssh://review.coreboot.org:29418/libgfxinit refs/changes/48/27048/1 diff --git a/common/hw-gfx-gma-config.ads.template b/common/hw-gfx-gma-config.ads.template index f498921..20ef5c0 100644 --- a/common/hw-gfx-gma-config.ads.template +++ b/common/hw-gfx-gma-config.ads.template @@ -44,6 +44,7 @@ Has_Presence_Straps : constant Boolean := CPU /= Broxton; ----- CPU pipe: -------- + Has_Tertiary_Pipe : constant Boolean := CPU >= Ivybridge; Disable_Trickle_Feed : constant Boolean := not (CPU in Haswell .. Broadwell); Pipe_Enabled_Workaround : constant Boolean := CPU = Broadwell; @@ -134,15 +135,7 @@ ---------------------------------------------------------------------------- Max_Pipe : constant Pipe_Index := - (if CPU <= Sandybridge - then Secondary - else Tertiary); - - type Supported_Pipe_Array is array (Pipe_Index) of Boolean; - Supported_Pipe : constant Supported_Pipe_Array := - (Primary => Primary <= Max_Pipe, - Secondary => Secondary <= Max_Pipe, - Tertiary => Tertiary <= Max_Pipe); + (if Has_Tertiary_Pipe then Tertiary else Secondary); Valid_Port : array (Port_Type) of Boolean := (others => False) with diff --git a/common/hw-gfx-gma-config_helpers.adb b/common/hw-gfx-gma-config_helpers.adb index b7f4833..57163a6 100644 --- a/common/hw-gfx-gma-config_helpers.adb +++ b/common/hw-gfx-gma-config_helpers.adb @@ -131,7 +131,7 @@ is begin Success := - Config.Supported_Pipe (Pipe) and then + (Config.Has_Tertiary_Pipe or Pipe <= Secondary) and then Config.Valid_Port (Port) and then Port /= Disabled; -- Valid_Port should already cover this, but the -- array is writeable, so it's hard to prove this. -- To view, visit https://review.coreboot.org/27048 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: libgfxinit Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Id3c4bdaf0d6b6c6126692b00cbabaf7d3f85b4bf Gerrit-Change-Number: 27048 Gerrit-PatchSet: 1 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de>

1 0

Change in libgfxinit[master]: gma config, port detection: Scatter Valid_Port initialization
by Nico Huber (Code Review) 13 Jun '18

13 Jun '18

Nico Huber has uploaded this change for review. ( https://review.coreboot.org/27047 Change subject: gma config, port detection: Scatter Valid_Port initialization ...................................................................... gma config, port detection: Scatter Valid_Port initialization We did overwrite most the default values for `Config.Valid_Port` anyway. So move the few remaining defaults where they are visible together with the other runtime settings. Change-Id: I17df08de0aa1ffb303646ea564c100bb702407f5 Signed-off-by: Nico Huber <nico.h(a)gmx.de> --- M common/g45/hw-gfx-gma-port_detect.adb M common/hw-gfx-gma-config.ads.template M common/hw-gfx-gma-display_probing.adb M common/hw-gfx-gma.adb M common/ironlake/hw-gfx-gma-port_detect.adb 5 files changed, 11 insertions(+), 52 deletions(-) git pull ssh://review.coreboot.org:29418/libgfxinit refs/changes/47/27047/1 diff --git a/common/g45/hw-gfx-gma-port_detect.adb b/common/g45/hw-gfx-gma-port_detect.adb index c865079..479b626 100644 --- a/common/g45/hw-gfx-gma-port_detect.adb +++ b/common/g45/hw-gfx-gma-port_detect.adb @@ -73,6 +73,8 @@ DIGI_D => DP3); begin + Config.Valid_Port (Analog) := True; + Config.Valid_Port (Internal) := Config.Internal_Is_LVDS; for HDMI_Port in GMCH_HDMI_Port loop Registers.Is_Set_Mask (Register => GMCH_HDMI (HDMI_Port), diff --git a/common/hw-gfx-gma-config.ads.template b/common/hw-gfx-gma-config.ads.template index 90500ab..f498921 100644 --- a/common/hw-gfx-gma-config.ads.template +++ b/common/hw-gfx-gma-config.ads.template @@ -14,7 +14,7 @@ private package HW.GFX.GMA.Config with - Initializes => (Valid_Port_GPU, Raw_Clock) + Initializes => (Valid_Port, Raw_Clock) is CPU : constant CPU_Type := <<CPU>>; @@ -38,6 +38,7 @@ Default_MMIO_Base_Set : constant Boolean := Default_MMIO_Base /= 0; Has_Internal_Display : constant Boolean := Internal_Display /= None; + Internal_Is_LVDS : constant Boolean := Internal_Display = LVDS; Internal_Is_EDP : constant Boolean := Internal_Display = DP; Have_DVI_I : constant Boolean := Analog_I2C_Port /= PCH_DAC; Has_Presence_Straps : constant Boolean := CPU /= Broxton; @@ -143,55 +144,9 @@ Secondary => Secondary <= Max_Pipe, Tertiary => Tertiary <= Max_Pipe); - type Valid_Per_Port is array (Port_Type) of Boolean; - type Valid_Per_GPU is array (CPU_Type) of Valid_Per_Port; - Valid_Port_GPU : Valid_Per_GPU := - (G45 => - (Disabled => False, - Internal => Config.Internal_Display = LVDS, - HDMI3 => False, - others => True), - Ironlake => - (Disabled => False, - Internal => Config.Internal_Display = LVDS, - others => True), - Sandybridge => - (Disabled => False, - Internal => Config.Internal_Display = LVDS, - others => True), - Ivybridge => - (Disabled => False, - Internal => Config.Internal_Display /= None, - others => True), - Haswell => - (Disabled => False, - Internal => Config.Internal_Display = DP, - HDMI3 => CPU_Var = Normal, - DP3 => CPU_Var = Normal, - Analog => CPU_Var = Normal, - others => True), - Broadwell => - (Disabled => False, - Internal => Config.Internal_Display = DP, - HDMI3 => CPU_Var = Normal, - DP3 => CPU_Var = Normal, - Analog => CPU_Var = Normal, - others => True), - Broxton => - (Internal => Config.Internal_Display = DP, - DP1 => True, - DP2 => True, - HDMI1 => True, - HDMI2 => True, - others => False), - Skylake => - (Disabled => False, - Internal => Config.Internal_Display = DP, - Analog => False, - others => True)) + Valid_Port : array (Port_Type) of Boolean := (others => False) with Part_Of => GMA.Config_State; - Valid_Port : Valid_Per_Port renames Valid_Port_GPU (CPU); Last_Digital_Port : constant Digital_Port := (if Has_DDI_E then DIGI_E else DIGI_C); @@ -202,7 +157,7 @@ Is_FDI_Port : constant FDI_Per_Port := (case CPU is when Ironlake .. Ivybridge => FDI_Per_Port' - (Internal => Internal_Display = LVDS, + (Internal => Internal_Is_LVDS, others => True), when Haswell .. Broadwell => FDI_Per_Port' (Analog => Has_PCH_DAC, diff --git a/common/hw-gfx-gma-display_probing.adb b/common/hw-gfx-gma-display_probing.adb index d02d0e0..50f9322 100644 --- a/common/hw-gfx-gma-display_probing.adb +++ b/common/hw-gfx-gma-display_probing.adb @@ -166,7 +166,7 @@ Refined_Global => (Input => (GMA.Cur_Configs, - Config.Raw_Clock, Config.Valid_Port_GPU, + Config.Raw_Clock, Config.Valid_Port, Time.State), In_Out => (Panel.Panel_State, Registers.Register_State), Proof_In => (Init_State)) diff --git a/common/hw-gfx-gma.adb b/common/hw-gfx-gma.adb index c9da0f2..f9ca13f 100644 --- a/common/hw-gfx-gma.adb +++ b/common/hw-gfx-gma.adb @@ -44,7 +44,7 @@ HPD_Delay, Wait_For_HPD, Linear_FB_Base), Init_State => Initialized, - Config_State => (Config.Valid_Port_GPU, Config.Raw_Clock), + Config_State => (Config.Valid_Port, Config.Raw_Clock), Device_State => (Dev.PCI_State, Registers.Register_State, Registers.GTT_State)) is @@ -371,7 +371,7 @@ with Refined_Global => (In_Out => - (Config.Valid_Port_GPU, Dev.PCI_State, + (Config.Valid_Port, Dev.PCI_State, Registers.Register_State, Port_IO.State, Config.Raw_Clock), Input => diff --git a/common/ironlake/hw-gfx-gma-port_detect.adb b/common/ironlake/hw-gfx-gma-port_detect.adb index 900c505..5af2e84 100644 --- a/common/ironlake/hw-gfx-gma-port_detect.adb +++ b/common/ironlake/hw-gfx-gma-port_detect.adb @@ -69,6 +69,8 @@ PCH_HDMI_C => DP2, PCH_HDMI_D => DP3); begin + Config.Valid_Port (Analog) := True; + case Config.Internal_Display is when LVDS => -- PCH_LVDS -- To view, visit https://review.coreboot.org/27047 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: libgfxinit Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I17df08de0aa1ffb303646ea564c100bb702407f5 Gerrit-Change-Number: 27047 Gerrit-PatchSet: 1 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de>

1 0

Change in libgfxinit[master]: gma config: Fix CPU range for Has_PCH_DAC
by Nico Huber (Code Review) 13 Jun '18

13 Jun '18

Nico Huber has uploaded this change for review. ( https://review.coreboot.org/27046 Change subject: gma config: Fix CPU range for Has_PCH_DAC ...................................................................... gma config: Fix CPU range for Has_PCH_DAC Looks like this hasn't been tested for a while or maybe never. The range `Broadwell .. Haswell` was reversed and thus empty. Change-Id: I1f6f8e3897c55aa5978e9403d14f103458c89cac Signed-off-by: Nico Huber <nico.h(a)gmx.de> --- M common/hw-gfx-gma-config.ads.template 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/libgfxinit refs/changes/46/27046/1 diff --git a/common/hw-gfx-gma-config.ads.template b/common/hw-gfx-gma-config.ads.template index 8a61d81..90500ab 100644 --- a/common/hw-gfx-gma-config.ads.template +++ b/common/hw-gfx-gma-config.ads.template @@ -71,7 +71,7 @@ ----- PCH/FDI: --------- Has_PCH : constant Boolean := CPU /= Broxton and CPU /= G45; Has_PCH_DAC : constant Boolean := CPU in Ironlake .. Ivybridge or - (CPU in Broadwell .. Haswell + (CPU in Haswell .. Broadwell and CPU_Var = Normal); Has_PCH_Aux_Channels : constant Boolean := CPU in Ironlake .. Broadwell; -- To view, visit https://review.coreboot.org/27046 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: libgfxinit Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I1f6f8e3897c55aa5978e9403d14f103458c89cac Gerrit-Change-Number: 27046 Gerrit-PatchSet: 1 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de>

1 0

Change in coreboot[master]: Documentation: Add Gigabyte to list of mainboards
by Angel Pons (Code Review) 13 Jun '18

13 Jun '18

Angel Pons has uploaded this change for review. ( https://review.coreboot.org/27045 Change subject: Documentation: Add Gigabyte to list of mainboards ...................................................................... Documentation: Add Gigabyte to list of mainboards Gigabyte was not in the list of vendors in the mainboard-specific documentation. This made a newly added mainboard page difficult to locate. This commit adds Gigabyte and links said mainboard in the mainboard-specific documentation main page. Change-Id: I8839e1c1176fbdc3dd9da616f68c58e8e1cf1b16 Signed-off-by: Angel Pons <th3fanbus(a)gmail.com> --- M Documentation/mainboard/index.md 1 file changed, 6 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/45/27045/1 diff --git a/Documentation/mainboard/index.md b/Documentation/mainboard/index.md index 23e1ed2..efc6b02 100644 --- a/Documentation/mainboard/index.md +++ b/Documentation/mainboard/index.md @@ -2,10 +2,14 @@ This section contains documentation about coreboot on specific mainboards. -## SiFive +## Gigabyte -- [SiFive HiFive Unleashed](sifive/hifive-unleashed.md) +- [GA-H61M-S2PV](gigabyte/ga-h61m-s2pv.md) ## HP - [Compaq 8200 Elite SFF](hp/compaq_8200_sff.md) + +## SiFive + +- [SiFive HiFive Unleashed](sifive/hifive-unleashed.md) -- To view, visit https://review.coreboot.org/27045 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I8839e1c1176fbdc3dd9da616f68c58e8e1cf1b16 Gerrit-Change-Number: 27045 Gerrit-PatchSet: 1 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com>

1 0

Change in coreboot[master]: driver/spi/macronix.c: Add MX25L8005
by Angel Pons (Code Review) 13 Jun '18

13 Jun '18

Angel Pons has posted comments on this change. ( https://review.coreboot.org/27040 ) Change subject: driver/spi/macronix.c: Add MX25L8005 ...................................................................... Patch Set 1: Code-Review+1 Tested with MX25L8005PC and works as intended. -- To view, visit https://review.coreboot.org/27040 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I595198d66193c63f6c80c39371fbec10065d2165 Gerrit-Change-Number: 27040 Gerrit-PatchSet: 1 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 12 Jun 2018 23:00:36 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: soc/amd/stoneyridge/acpi.c: Create GPIO acpigen procedures
by build bot (Jenkins) (Code Review) 13 Jun '18

13 Jun '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/26335 ) Change subject: soc/amd/stoneyridge/acpi.c: Create GPIO acpigen procedures ...................................................................... Patch Set 7: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/74823/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/28928/ : SUCCESS -- To view, visit https://review.coreboot.org/26335 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9062d889f828a3175b89e6f4a3659ebbf90eac68 Gerrit-Change-Number: 26335 Gerrit-PatchSet: 7 Gerrit-Owner: Richard Spiegel <richard.spiegel(a)silverbackltd.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Richard Spiegel <richard.spiegel(a)silverbackltd.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 12 Jun 2018 22:55:12 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: sb/intel/i82801{g, j}x: Automatically generate ACPI PIRQ tables
by build bot (Jenkins) (Code Review) 13 Jun '18

13 Jun '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/22981 ) Change subject: sb/intel/i82801{g,j}x: Automatically generate ACPI PIRQ tables ...................................................................... Patch Set 18: Build Successful https://qa.coreboot.org/job/coreboot-gerrit/74822/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/28927/ : SUCCESS -- To view, visit https://review.coreboot.org/22981 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I286d251ddf8fcae27dd07011a1cd62d8f4847683 Gerrit-Change-Number: 22981 Gerrit-PatchSet: 18 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Elyes HAOUAS <ehaouas(a)noos.fr> Gerrit-Comment-Date: Tue, 12 Jun 2018 22:50:12 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No

1 0

Change in coreboot[master]: sb/intel/i82801ix: Use the common ACPI pirq generator
by build bot (Jenkins) (Code Review) 13 Jun '18

13 Jun '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/22980 ) Change subject: sb/intel/i82801ix: Use the common ACPI pirq generator ...................................................................... Patch Set 26: Build Successful https://qa.coreboot.org/job/coreboot-gerrit/74821/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/28926/ : SUCCESS -- To view, visit https://review.coreboot.org/22980 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I62e520f53fa3f928a8e6f3b3cf33af2acdd53ed9 Gerrit-Change-Number: 22980 Gerrit-PatchSet: 26 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 12 Jun 2018 22:50:12 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No

1 0

Change in coreboot[master]: sb/intel/i82801xx: Use common RCBA MACROs
by build bot (Jenkins) (Code Review) 13 Jun '18

13 Jun '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/27043 ) Change subject: sb/intel/i82801xx: Use common RCBA MACROs ...................................................................... Patch Set 3: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/74820/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/28925/ : SUCCESS -- To view, visit https://review.coreboot.org/27043 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I61fb3b01ff15ba2da2ee938addfa630c282c9870 Gerrit-Change-Number: 27043 Gerrit-PatchSet: 3 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 12 Jun 2018 22:45:12 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: sb/intel/common/rcba_pirq.c: Use common RCBA acces MACROs
by build bot (Jenkins) (Code Review) 13 Jun '18

13 Jun '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/27042 ) Change subject: sb/intel/common/rcba_pirq.c: Use common RCBA acces MACROs ...................................................................... Patch Set 2: Build Successful https://qa.coreboot.org/job/coreboot-gerrit/74818/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/28921/ : SUCCESS -- To view, visit https://review.coreboot.org/27042 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2fe8d8388cb96e42af4f9be251a41cceeb2e4710 Gerrit-Change-Number: 27042 Gerrit-PatchSet: 2 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 12 Jun 2018 22:45:11 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit June 2018