coreboot-gerrit April 2018

coreboot-gerrit@coreboot.org

1 participants
2168 discussions

Change in coreboot[master]: pci: Add dummy file for ARM64
by build bot (Jenkins) (Code Review) 19 Apr '18

19 Apr '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/25722 ) Change subject: pci: Add dummy file for ARM64 ...................................................................... Patch Set 12: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/70388/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/24610/ : SUCCESS -- To view, visit https://review.coreboot.org/25722 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iaff20463375d1e3ec573d9486a859a0514b0b390 Gerrit-Change-Number: 25722 Gerrit-PatchSet: 12 Gerrit-Owner: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Comment-Date: Thu, 19 Apr 2018 07:34:23 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: pci: Move inline PCI functions to pci_ops.h
by build bot (Jenkins) (Code Review) 19 Apr '18

19 Apr '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/25720 ) Change subject: pci: Move inline PCI functions to pci_ops.h ...................................................................... Patch Set 11: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/70387/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/24609/ : SUCCESS -- To view, visit https://review.coreboot.org/25720 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia05391c43b8d501bd68df5654bcfb587f8786f71 Gerrit-Change-Number: 25720 Gerrit-PatchSet: 11 Gerrit-Owner: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Comment-Date: Thu, 19 Apr 2018 07:29:54 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: soc/intel/cannonlake: Force LPC IO decode settings
by build bot (Jenkins) (Code Review) 19 Apr '18

19 Apr '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/25668 ) Change subject: soc/intel/cannonlake: Force LPC IO decode settings ...................................................................... Patch Set 4: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/70386/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/24608/ : SUCCESS -- To view, visit https://review.coreboot.org/25668 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I72a40360ba67f443f24468f10504d8cfd0b099ca Gerrit-Change-Number: 25668 Gerrit-PatchSet: 4 Gerrit-Owner: Lijian Zhao <lijian.zhao(a)intel.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-Reviewer: Hannah Williams <hannah.williams(a)intel.com> Gerrit-Reviewer: Krzysztof M Sywula <krzysztof.m.sywula(a)intel.com> Gerrit-Reviewer: Lijian Zhao <lijian.zhao(a)intel.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Furquan Shaikh <furquan(a)google.com> Gerrit-Comment-Date: Thu, 19 Apr 2018 06:51:00 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: device/oprom/yabel: Modify vbe-buffer index in vbe.c
by build bot (Jenkins) (Code Review) 19 Apr '18

19 Apr '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/25736 ) Change subject: device/oprom/yabel: Modify vbe-buffer index in vbe.c ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/70385/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/24607/ : SUCCESS -- To view, visit https://review.coreboot.org/25736 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8ec85df60076162518aa55a94fa7b66c0c2391ab Gerrit-Change-Number: 25736 Gerrit-PatchSet: 1 Gerrit-Owner: Hal Tsai <hal_tsai(a)compal.corp-partner.google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 19 Apr 2018 06:34:09 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: device/oprom/yabel: Modify vbe-buffer index in vbe.c
by Hal Tsai (Code Review) 19 Apr '18

19 Apr '18

Hal Tsai has removed Furquan Shaikh from this change. ( https://review.coreboot.org/25736 ) Change subject: device/oprom/yabel: Modify vbe-buffer index in vbe.c ...................................................................... Removed reviewer Furquan Shaikh. -- To view, visit https://review.coreboot.org/25736 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: deleteReviewer Gerrit-Change-Id: I8ec85df60076162518aa55a94fa7b66c0c2391ab Gerrit-Change-Number: 25736 Gerrit-PatchSet: 1 Gerrit-Owner: Hal Tsai <hal_tsai(a)compal.corp-partner.google.com>

1 0

Change in coreboot[master]: device/oprom/yabel: Modify vbe-buffer index in vbe.c
by Hal Tsai (Code Review) 19 Apr '18

19 Apr '18

Hal Tsai has uploaded this change for review. ( https://review.coreboot.org/25736 Change subject: device/oprom/yabel: Modify vbe-buffer index in vbe.c ...................................................................... device/oprom/yabel: Modify vbe-buffer index in vbe.c There's a issue about {VbeSignature to "VBE2" to indicate VBE 2.0+ request}, these indexes are counted mistake. Change-Id: I8ec85df60076162518aa55a94fa7b66c0c2391ab Signed-off-by: Hal Tsai <hal_tsai(a)compal.corp-partner.google.com> --- M src/device/oprom/yabel/vbe.c 1 file changed, 3 insertions(+), 3 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/36/25736/1 diff --git a/src/device/oprom/yabel/vbe.c b/src/device/oprom/yabel/vbe.c index 876df23..4995a02 100644 --- a/src/device/oprom/yabel/vbe.c +++ b/src/device/oprom/yabel/vbe.c @@ -75,9 +75,9 @@ memset(vbe_info_buffer, 0, 512); //set VbeSignature to "VBE2" to indicate VBE 2.0+ request vbe_info_buffer[0] = 'V'; - vbe_info_buffer[0] = 'B'; - vbe_info_buffer[0] = 'E'; - vbe_info_buffer[0] = '2'; + vbe_info_buffer[1] = 'B'; + vbe_info_buffer[2] = 'E'; + vbe_info_buffer[3] = '2'; // ES:DI store pointer to buffer in virtual mem see vbe_info_buffer above... M.x86.R_EDI = 0x0; M.x86.R_ES = VBE_SEGMENT; -- To view, visit https://review.coreboot.org/25736 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I8ec85df60076162518aa55a94fa7b66c0c2391ab Gerrit-Change-Number: 25736 Gerrit-PatchSet: 1 Gerrit-Owner: Hal Tsai <hal_tsai(a)compal.corp-partner.google.com>

1 0

Change in coreboot[master]: soc/intel/common: Add bootblock common stage file [WIP]
by build bot (Jenkins) (Code Review) 19 Apr '18

19 Apr '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/18457 ) Change subject: soc/intel/common: Add bootblock common stage file [WIP] ...................................................................... Patch Set 5: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/70384/ : SUCCESS -- To view, visit https://review.coreboot.org/18457 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If84c08d33f6f8fd3cd9722ee893653f1d1ae90c1 Gerrit-Change-Number: 18457 Gerrit-PatchSet: 5 Gerrit-Owner: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: Aamir Bohra <aamir.bohra(a)intel.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Balaji Manigandan <balaji.manigandan(a)intel.com> Gerrit-Reviewer: Barnali Sarkar <barnali.sarkar(a)intel.com> Gerrit-Reviewer: Hannah Williams <hannah.williams(a)intel.com> Gerrit-Reviewer: Maulik V Vaghela <maulik.v.vaghela(a)intel.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: dhaval v sharma <dhaval.v.sharma(a)intel.com> Gerrit-Comment-Date: Thu, 19 Apr 2018 06:23:24 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: soc/intel/cannonlake: Move SOC dependent functions to common file
by build bot (Jenkins) (Code Review) 19 Apr '18

19 Apr '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/25656 ) Change subject: soc/intel/cannonlake: Move SOC dependent functions to common file ...................................................................... Patch Set 21: Build Successful https://qa.coreboot.org/job/coreboot-gerrit/70383/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/24606/ : SUCCESS -- To view, visit https://review.coreboot.org/25656 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I17c69e3b1840c30b856b9a3a077302923b31681f Gerrit-Change-Number: 25656 Gerrit-PatchSet: 21 Gerrit-Owner: Maulik V Vaghela <maulik.v.vaghela(a)intel.com> Gerrit-Reviewer: Aamir Bohra <aamir.bohra(a)intel.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Balaji Manigandan <balaji.manigandan(a)intel.com> Gerrit-Reviewer: Hannah Williams <hannah.williams(a)intel.com> Gerrit-Reviewer: Maulik V Vaghela <maulik.v.vaghela(a)intel.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: V Sowmya <v.sowmya(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 19 Apr 2018 06:13:23 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No

1 0

Change in coreboot[master]: soc/intel/common: create lockdown folder for common lockdown file
by build bot (Jenkins) (Code Review) 19 Apr '18

19 Apr '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/25688 ) Change subject: soc/intel/common: create lockdown folder for common lockdown file ...................................................................... Patch Set 21: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/70381/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/24604/ : SUCCESS -- To view, visit https://review.coreboot.org/25688 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0b81bbc54f737cb4e7120f44bbe705039b45ccb3 Gerrit-Change-Number: 25688 Gerrit-PatchSet: 21 Gerrit-Owner: Maulik V Vaghela <maulik.v.vaghela(a)intel.com> Gerrit-Reviewer: Aamir Bohra <aamir.bohra(a)intel.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Hannah Williams <hannah.williams(a)intel.com> Gerrit-Reviewer: Maulik V Vaghela <maulik.v.vaghela(a)intel.com> Gerrit-Reviewer: Naresh Solanki <naresh.solanki(a)intel.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: V Sowmya <v.sowmya(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 19 Apr 2018 06:12:52 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: soc/intel/common: Add bootblock common stage file [WIP]
by build bot (Jenkins) (Code Review) 19 Apr '18

19 Apr '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/18457 ) Change subject: soc/intel/common: Add bootblock common stage file [WIP] ...................................................................... Patch Set 4: Verified-1 Build Failed https://qa.coreboot.org/job/coreboot-gerrit/70382/ : ABORTED https://qa.coreboot.org/job/coreboot-checkpatch/24605/ : SUCCESS -- To view, visit https://review.coreboot.org/18457 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If84c08d33f6f8fd3cd9722ee893653f1d1ae90c1 Gerrit-Change-Number: 18457 Gerrit-PatchSet: 4 Gerrit-Owner: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: Aamir Bohra <aamir.bohra(a)intel.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Balaji Manigandan <balaji.manigandan(a)intel.com> Gerrit-Reviewer: Barnali Sarkar <barnali.sarkar(a)intel.com> Gerrit-Reviewer: Hannah Williams <hannah.williams(a)intel.com> Gerrit-Reviewer: Maulik V Vaghela <maulik.v.vaghela(a)intel.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: dhaval v sharma <dhaval.v.sharma(a)intel.com> Gerrit-Comment-Date: Thu, 19 Apr 2018 06:09:02 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit April 2018