coreboot-gerrit April 2018

coreboot-gerrit@coreboot.org

1 participants
2168 discussions

Change in coreboot[master]: lib/cbfs: Remove cbfs_boot_map_optionrom from cbfs impl
by build bot (Jenkins) (Code Review) 20 Apr '18

20 Apr '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/24994 ) Change subject: lib/cbfs: Remove cbfs_boot_map_optionrom from cbfs impl ...................................................................... Patch Set 5: Build Unstable https://qa.coreboot.org/job/coreboot-gerrit/70406/ : UNSTABLE https://qa.coreboot.org/job/coreboot-checkpatch/24626/ : SUCCESS -- To view, visit https://review.coreboot.org/24994 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I57a35d3ce95850d22f79a1045a30b7c6b011bb68 Gerrit-Change-Number: 24994 Gerrit-PatchSet: 5 Gerrit-Owner: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 19 Apr 2018 16:28:18 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No

1 0

Change in coreboot[master]: security/vboot: Extend measurements for all execution flows
by build bot (Jenkins) (Code Review) 20 Apr '18

20 Apr '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/24993 ) Change subject: security/vboot: Extend measurements for all execution flows ...................................................................... Patch Set 5: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/70405/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/24625/ : SUCCESS -- To view, visit https://review.coreboot.org/24993 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3ddfeabd63aefec152a9bc439a415c37b814f94f Gerrit-Change-Number: 24993 Gerrit-PatchSet: 5 Gerrit-Owner: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 19 Apr 2018 16:24:00 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: soc/amd/common/block/include/amdblocks/psp.h: Define mailbox buffers
by Richard Spiegel (Code Review) 20 Apr '18

20 Apr '18

Richard Spiegel has uploaded this change for review. ( https://review.coreboot.org/25740 Change subject: soc/amd/common/block/include/amdblocks/psp.h: Define mailbox buffers ...................................................................... soc/amd/common/block/include/amdblocks/psp.h: Define mailbox buffers The Platform Security Processor use predefined buffers to some of the commands, though not all (some commands are just command and status, which forms the header of any command). This buffer is placed in a memory area called the mailbox, and its address is passed to the psp through special registers. Commands that don't need a special buffer use the default buffer, which only contains the header. Define the special buffers, and create a union of them, including the default buffer. BUG=b:77940747 TEST=None. Change-Id: I6143d7e85476061395962b95ad8864ac32a1d4a3 Signed-off-by: Richard Spiegel <richard.spiegel(a)silverbackltd.com> --- M src/soc/amd/common/block/include/amdblocks/psp.h 1 file changed, 64 insertions(+), 5 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/40/25740/1 diff --git a/src/soc/amd/common/block/include/amdblocks/psp.h b/src/soc/amd/common/block/include/amdblocks/psp.h index 4c9878a..ad76990 100644 --- a/src/soc/amd/common/block/include/amdblocks/psp.h +++ b/src/soc/amd/common/block/include/amdblocks/psp.h @@ -29,7 +29,7 @@ #define MBOX_BIOS_CMD_PSP_QUERY 0x05 #define MBOX_BIOS_CMD_BOOT_DONE 0x06 #define MBOX_BIOS_CMD_CLEAR_S3_STS 0x07 -#define MBOX_BIOS_CMD_C3_DATA_INFO 0x08 +#define MBOX_BIOS_CMD_S3_DATA_INFO 0x08 #define MBOX_BIOS_CMD_NOP 0x09 #define MBOX_BIOS_CMD_SMU_FW 0x19 #define MBOX_BIOS_CMD_SMU_FW2 0x1a @@ -64,13 +64,72 @@ u32 status; /* command status, filled by PSP if applicable */ } __packed; -/* command-specific buffer definitions: see NDA document #54267 - * todo: create new definitions here for additional c2p_mbox_command commands - */ +/* command-specific buffer definitions: see NDA document #54267 */ struct mbox_default_buffer { /* command-response buffer unused by command */ struct mbox_buffer_header header; -} __attribute__((packed,aligned(32))); +} __attribute__((packed, aligned(32))); + +struct smm_trigger_buffer { + u64 address; + u32 address_type; + u32 value_width; + u32 value_and_mask; + u32 value_or_mask; +} __packed; + +struct smm_req_buffer { + u64 smm_base; + u64 smm_length; + u64 psp_data_region; + u64 psp_data_length; + struct smm_trigger_buffer trigger; +} __packed; + +/* command-response buffer used by command MBOX_BIOS_CMD_SMM_INFO */ +struct mbox_smm_buffer { + struct mbox_buffer_header header; + struct smm_req_buffer buffer; +} __attribute__((packed, aligned(32))); + +/* command-response buffer used by command MBOX_BIOS_CMD_SX_INFO */ +struct mbox_sx_buffer { + struct mbox_buffer_header header; + u8 SleepType; +} __attribute__((packed, aligned(32))); + +/* command-response buffer used by command MBOX_BIOS_CMD_RSM_INFO */ +struct mbox_rsm_buffer { + struct mbox_buffer_header header; + u64 vector_address; + u64 vector_length; +} __attribute__((packed, aligned(32))); + +/* command-response buffer used by command MBOX_BIOS_CMD_PSP_QUERY */ +struct mbox_psp_query_buffer { + struct mbox_buffer_header header; + u32 capabilities; +} __attribute__((packed, aligned(32))); + +struct s3_data_req_buffer { + u64 s3_restore_buffer_base; + u64 s3_restore_buffer_size; +} __packed; + +/* command-response buffer used by command MBOX_BIOS_CMD_S3_DATA_INFO */ +struct mbox_s3_data_buffer { + struct mbox_buffer_header header; + s3_data_req_buffer request; +} __attribute__((packed, aligned(32))); + +union mbox_buffer { + mbox_default_buffer default; + mbox_smm_buffer smm; + mbox_sx_buffer sx; + mbox_rsm_buffer resume; + mbox_psp_query_buffer query; + mbox_s3_data_buffer s3_data; +}; /* send_psp_command() error codes */ #define PSPSTS_SUCCESS 0 -- To view, visit https://review.coreboot.org/25740 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I6143d7e85476061395962b95ad8864ac32a1d4a3 Gerrit-Change-Number: 25740 Gerrit-PatchSet: 1 Gerrit-Owner: Richard Spiegel <richard.spiegel(a)silverbackltd.com>

1 0

Change in coreboot[master]: soc/amd/common/block/pi/heapmanager.c: Simplify code
by build bot (Jenkins) (Code Review) 20 Apr '18

20 Apr '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/25703 ) Change subject: soc/amd/common/block/pi/heapmanager.c: Simplify code ...................................................................... Patch Set 3: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/24577/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/70403/ : SUCCESS -- To view, visit https://review.coreboot.org/25703 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib4c69981eab7452228ccae9ed9bc288c8baceffe Gerrit-Change-Number: 25703 Gerrit-PatchSet: 3 Gerrit-Owner: Richard Spiegel <richard.spiegel(a)silverbackltd.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Garrett Kirkendall <garrett.kirkendall(a)amd.corp-partner.google.com> Gerrit-Reviewer: Marc Jones <marc(a)marcjonesconsulting.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Richard Spiegel <richard.spiegel(a)silverbackltd.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 19 Apr 2018 14:29:53 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: lib: Add FIT payload support
by build bot (Jenkins) (Code Review) 19 Apr '18

19 Apr '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/25019 ) Change subject: lib: Add FIT payload support ...................................................................... Patch Set 21: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/70402/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/24623/ : SUCCESS -- To view, visit https://review.coreboot.org/25019 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0f27b92a5e074966f893399eb401eb97d784850d Gerrit-Change-Number: 25019 Gerrit-PatchSet: 21 Gerrit-Owner: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 19 Apr 2018 13:29:18 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: lib: Raw import FIT parser
by build bot (Jenkins) (Code Review) 19 Apr '18

19 Apr '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/25739 ) Change subject: lib: Raw import FIT parser ...................................................................... Patch Set 2: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/70401/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/24622/ : SUCCESS -- To view, visit https://review.coreboot.org/25739 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iee56db328d7eeffb0eaf829841243b0b9195c199 Gerrit-Change-Number: 25739 Gerrit-PatchSet: 2 Gerrit-Owner: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 19 Apr 2018 13:27:04 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: lib: Raw import FIT parser
by Patrick Rudolph (Code Review) 19 Apr '18

19 Apr '18

Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/25739 to look at the new patch set (#2). Change subject: lib: Raw import FIT parser ...................................................................... lib: Raw import FIT parser Import from https://chromium.googlesource.com/chromiumos/platform/depthcharge Coding style and coreboot integration will be done in a separate commit. Change-Id: Iee56db328d7eeffb0eaf829841243b0b9195c199 Signed-off-by: Patrick Rudolph <patrick.rudolph(a)9elements.com> --- A src/include/fit.h A src/lib/fit.c 2 files changed, 565 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/39/25739/2 -- To view, visit https://review.coreboot.org/25739 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Iee56db328d7eeffb0eaf829841243b0b9195c199 Gerrit-Change-Number: 25739 Gerrit-PatchSet: 2 Gerrit-Owner: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in coreboot[master]: lib: Add FIT payload support
by build bot (Jenkins) (Code Review) 19 Apr '18

19 Apr '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/25019 ) Change subject: lib: Add FIT payload support ...................................................................... Patch Set 20: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/70399/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/24619/ : SUCCESS -- To view, visit https://review.coreboot.org/25019 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0f27b92a5e074966f893399eb401eb97d784850d Gerrit-Change-Number: 25019 Gerrit-PatchSet: 20 Gerrit-Owner: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 19 Apr 2018 13:15:21 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: lib: Raw import FIT parser
by build bot (Jenkins) (Code Review) 19 Apr '18

19 Apr '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/25739 ) Change subject: lib: Raw import FIT parser ...................................................................... Patch Set 1: Verified-1 Build Failed https://qa.coreboot.org/job/coreboot-gerrit/70400/ : FAILURE https://qa.coreboot.org/job/coreboot-checkpatch/24621/ : SUCCESS -- To view, visit https://review.coreboot.org/25739 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iee56db328d7eeffb0eaf829841243b0b9195c199 Gerrit-Change-Number: 25739 Gerrit-PatchSet: 1 Gerrit-Owner: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 19 Apr 2018 13:06:23 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: lib/bootmem: Add method to walk memory tables
by build bot (Jenkins) (Code Review) 19 Apr '18

19 Apr '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/25583 ) Change subject: lib/bootmem: Add method to walk memory tables ...................................................................... Patch Set 5: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/70398/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/24620/ : SUCCESS -- To view, visit https://review.coreboot.org/25583 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0004e5ad5fe2289827f370f0d0f9979d3cbd3926 Gerrit-Change-Number: 25583 Gerrit-PatchSet: 5 Gerrit-Owner: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Aaron Durbin <adurbin(a)chromium.org> Gerrit-CC: Julius Werner <jwerner(a)chromium.org> Gerrit-Comment-Date: Thu, 19 Apr 2018 13:06:10 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit April 2018