coreboot-gerrit April 2018

coreboot-gerrit@coreboot.org

1 participants
2168 discussions

Change in coreboot[master]: lib: Add FIT payload support
by build bot (Jenkins) (Code Review) 20 Apr '18

20 Apr '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/25019 ) Change subject: lib: Add FIT payload support ...................................................................... Patch Set 22: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/70447/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/24667/ : SUCCESS -- To view, visit https://review.coreboot.org/25019 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0f27b92a5e074966f893399eb401eb97d784850d Gerrit-Change-Number: 25019 Gerrit-PatchSet: 22 Gerrit-Owner: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Comment-Date: Fri, 20 Apr 2018 10:13:10 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: lib/bootmem: Add method to walk OS POV memory tables
by build bot (Jenkins) (Code Review) 20 Apr '18

20 Apr '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/25747 ) Change subject: lib/bootmem: Add method to walk OS POV memory tables ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/70448/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/24668/ : SUCCESS -- To view, visit https://review.coreboot.org/25747 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iee332a9821d12a7d9a684063b77b0502febd8d7d Gerrit-Change-Number: 25747 Gerrit-PatchSet: 1 Gerrit-Owner: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 20 Apr 2018 10:12:27 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: lib/bootmem: Add more bootmem tags
by build bot (Jenkins) (Code Review) 20 Apr '18

20 Apr '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/25383 ) Change subject: lib/bootmem: Add more bootmem tags ...................................................................... Patch Set 14: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/70444/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/24664/ : SUCCESS -- To view, visit https://review.coreboot.org/25383 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0c983ce43616147c519a43edee3b61d54eadbb9a Gerrit-Change-Number: 25383 Gerrit-PatchSet: 14 Gerrit-Owner: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Julius Werner <jwerner(a)chromium.org> Gerrit-CC: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Comment-Date: Fri, 20 Apr 2018 10:06:00 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: lib/bootmem: Introduce custom bootmem tags
by build bot (Jenkins) (Code Review) 20 Apr '18

20 Apr '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/25633 ) Change subject: lib/bootmem: Introduce custom bootmem tags ...................................................................... Patch Set 3: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/70442/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/24663/ : SUCCESS -- To view, visit https://review.coreboot.org/25633 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7be8fa792fc7933ca218ecd43d250d3a9c55caa6 Gerrit-Change-Number: 25633 Gerrit-PatchSet: 3 Gerrit-Owner: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 20 Apr 2018 10:06:00 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: lib: Raw import FIT parser
by build bot (Jenkins) (Code Review) 20 Apr '18

20 Apr '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/25739 ) Change subject: lib: Raw import FIT parser ...................................................................... Patch Set 3: Build Successful https://qa.coreboot.org/job/coreboot-gerrit/70446/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/24666/ : SUCCESS -- To view, visit https://review.coreboot.org/25739 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iee56db328d7eeffb0eaf829841243b0b9195c199 Gerrit-Change-Number: 25739 Gerrit-PatchSet: 3 Gerrit-Owner: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 20 Apr 2018 10:05:10 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No

1 0

Change in coreboot[master]: lib/bootmem: Add method to walk memory tables
by build bot (Jenkins) (Code Review) 20 Apr '18

20 Apr '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/25583 ) Change subject: lib/bootmem: Add method to walk memory tables ...................................................................... Patch Set 6: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/70445/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/24665/ : SUCCESS -- To view, visit https://review.coreboot.org/25583 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0004e5ad5fe2289827f370f0d0f9979d3cbd3926 Gerrit-Change-Number: 25583 Gerrit-PatchSet: 6 Gerrit-Owner: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Aaron Durbin <adurbin(a)chromium.org> Gerrit-CC: Julius Werner <jwerner(a)chromium.org> Gerrit-Comment-Date: Fri, 20 Apr 2018 10:00:53 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: lib: Raw import FDT devicetree from depthcharge
by build bot (Jenkins) (Code Review) 20 Apr '18

20 Apr '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/25632 ) Change subject: lib: Raw import FDT devicetree from depthcharge ...................................................................... Patch Set 2: Build Successful https://qa.coreboot.org/job/coreboot-gerrit/70443/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/24661/ : SUCCESS -- To view, visit https://review.coreboot.org/25632 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ida75d4786eae38d84bfc71bf53573dafca8eda40 Gerrit-Change-Number: 25632 Gerrit-PatchSet: 2 Gerrit-Owner: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 20 Apr 2018 09:56:36 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No

1 0

Change in coreboot[master]: lib/devicetree: Integrate flattened devicetree support
by build bot (Jenkins) (Code Review) 20 Apr '18

20 Apr '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/25523 ) Change subject: lib/devicetree: Integrate flattened devicetree support ...................................................................... Patch Set 8: Build Successful https://qa.coreboot.org/job/coreboot-gerrit/70441/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/24662/ : SUCCESS -- To view, visit https://review.coreboot.org/25523 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6e6cd9f78fb402bd54d684097326d26eb78d552a Gerrit-Change-Number: 25523 Gerrit-PatchSet: 8 Gerrit-Owner: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Jonathan Neuschäfer <j.neuschaefer(a)gmx.net> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 20 Apr 2018 09:52:41 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No

1 0

Change in coreboot[master]: lib/bootmem: Add method to walk OS POV memory tables
by Patrick Rudolph (Code Review) 20 Apr '18

20 Apr '18

Patrick Rudolph has uploaded this change for review. ( https://review.coreboot.org/25747 Change subject: lib/bootmem: Add method to walk OS POV memory tables ...................................................................... lib/bootmem: Add method to walk OS POV memory tables Add method to walk memory tables from OS point of view. The tables don't change when modifiying bootmem entries and doesn't contain bootmem specific tags. Change-Id: Iee332a9821d12a7d9a684063b77b0502febd8d7d Signed-off-by: Patrick Rudolph <patrick.rudolph(a)9elements.com> --- M src/include/bootmem.h M src/lib/bootmem.c 2 files changed, 40 insertions(+), 12 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/47/25747/1 diff --git a/src/include/bootmem.h b/src/include/bootmem.h index b95e383..4026c5c 100644 --- a/src/include/bootmem.h +++ b/src/include/bootmem.h @@ -71,6 +71,16 @@ typedef bool (*range_action_t)(const struct range_entry *r, void *arg); /** + * Walk memory tables from OS point of view and call the provided function, + * for every region. The caller has to return false to break out of the loop any + * time, or return true to continue. + * + * @param action The function to call for each memory range. + * @param Pointer passed to function @action. Set to NULL if unused. + */ +void bootmem_walk_os_mem(range_action_t action, void *arg); + +/** * Walk memory tables and call the provided function, for every region. * The caller has to return false to break out of the loop any time, or * return true to continue. diff --git a/src/lib/bootmem.c b/src/lib/bootmem.c index daad9a8..efb8c82 100644 --- a/src/lib/bootmem.c +++ b/src/lib/bootmem.c @@ -25,6 +25,7 @@ static int initialized; static int table_written; static struct memranges bootmem; +static struct memranges bootmem_os; static int bootmem_is_initialized(void) { @@ -65,6 +66,17 @@ } } +static void bootmem_convert_ranges(void) +{ + /** + * Convert BM_MEM_RAMSTAGE and BM_MEM_PAYLOAD to BM_MEM_RAM and + * merge ranges. The payload doesn't care about memory used by firmware. + */ + memranges_clone(&bootmem_os, &bootmem); + memranges_update_tag(&bootmem_os, BM_MEM_RAMSTAGE, BM_MEM_RAM); + memranges_update_tag(&bootmem_os, BM_MEM_PAYLOAD, BM_MEM_RAM); +} + static void bootmem_init(void) { const unsigned long cacheable = IORESOURCE_CACHEABLE; @@ -90,6 +102,8 @@ bootmem_arch_add_ranges(); bootmem_platform_add_ranges(); + + bootmem_convert_ranges(); } void bootmem_add_range(uint64_t start, uint64_t size, @@ -118,22 +132,13 @@ { const struct range_entry *r; struct lb_memory_range *lb_r; - struct memranges bm; lb_r = &mem->map[0]; bootmem_init(); bootmem_dump_ranges(); - /** - * Convert BM_MEM_RAMSTAGE and BM_MEM_PAYLOAD to BM_MEM_RAM and - * merge ranges. The payload doesn't care about memory used by firmware. - */ - memranges_clone(&bm, &bootmem); - memranges_update_tag(&bm, BM_MEM_RAMSTAGE, BM_MEM_RAM); - memranges_update_tag(&bm, BM_MEM_PAYLOAD, BM_MEM_RAM); - - memranges_each_entry(r, &bm) { + memranges_each_entry(r, &bootmem_os) { lb_r->start = pack_lb64(range_entry_base(r)); lb_r->size = pack_lb64(range_entry_size(r)); lb_r->type = bootmem_to_lb_tag(range_entry_tag(r)); @@ -142,8 +147,6 @@ mem->size += sizeof(struct lb_memory_range); } - memranges_teardown(&bm); - table_written = 1; } @@ -190,6 +193,21 @@ } } +void bootmem_walk_os_mem(range_action_t action, void *arg) +{ + const struct range_entry *r; + + if (!bootmem_is_initialized()) { + printk(BIOS_ERR, "%s: lib unitialized!\n", __func__); + return; + } + + memranges_each_entry(r, &bootmem_os) { + if (!action(r, arg)) + return; + } +} + void bootmem_walk(range_action_t action, void *arg) { const struct range_entry *r; -- To view, visit https://review.coreboot.org/25747 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Iee332a9821d12a7d9a684063b77b0502febd8d7d Gerrit-Change-Number: 25747 Gerrit-PatchSet: 1 Gerrit-Owner: Patrick Rudolph <patrick.rudolph(a)9elements.com>

1 0

Change in coreboot[master]: soc/intel/common: Add bootblock common stage file [WIP]
by build bot (Jenkins) (Code Review) 20 Apr '18

20 Apr '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/18457 ) Change subject: soc/intel/common: Add bootblock common stage file [WIP] ...................................................................... Patch Set 7: Build Successful https://qa.coreboot.org/job/coreboot-gerrit/70440/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/24660/ : SUCCESS -- To view, visit https://review.coreboot.org/18457 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If84c08d33f6f8fd3cd9722ee893653f1d1ae90c1 Gerrit-Change-Number: 18457 Gerrit-PatchSet: 7 Gerrit-Owner: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: Aamir Bohra <aamir.bohra(a)intel.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Balaji Manigandan <balaji.manigandan(a)intel.com> Gerrit-Reviewer: Barnali Sarkar <barnali.sarkar(a)intel.com> Gerrit-Reviewer: Hannah Williams <hannah.williams(a)intel.com> Gerrit-Reviewer: Maulik V Vaghela <maulik.v.vaghela(a)intel.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: dhaval v sharma <dhaval.v.sharma(a)intel.com> Gerrit-Comment-Date: Fri, 20 Apr 2018 09:00:43 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit April 2018