Subrata Banik has posted comments on this change. ( https://review.coreboot.org/25802 )
Change subject: [WIP] soc/intel/apollolake: Use bootblock common stage
......................................................................
Patch Set 3:
(2 comments)
https://review.coreboot.org/#/c/25802/3/src/soc/intel/apollolake/bootblock/…
File src/soc/intel/apollolake/bootblock/pch.c:
https://review.coreboot.org/#/c/25802/3/src/soc/intel/apollolake/bootblock/…
PS3, Line 89: if (IS_ENABLED(CONFIG_SOC_UART_DEBUG))
: pch_uart_init();
> this should be removed
yes, as we are calling this from stage file.
https://review.coreboot.org/#/c/25802/3/src/soc/intel/apollolake/include/so…
File src/soc/intel/apollolake/include/soc/pch.h:
https://review.coreboot.org/#/c/25802/3/src/soc/intel/apollolake/include/so…
PS3, Line 4: * Copyright (C) 2008-2009 coresystems GmbH
: * Copyright (C) 2014 Google Inc.
: * Copyright (C) 2017 Intel Corporation.
its new file, only 1 copyright?
--
To view, visit https://review.coreboot.org/25802
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I319453c902632f26eec63ab9c1e9bb6956b466fb
Gerrit-Change-Number: 25802
Gerrit-PatchSet: 3
Gerrit-Owner: Bora Guvendik <bora.guvendik(a)intel.com>
Gerrit-Reviewer: Bora Guvendik <bora.guvendik(a)intel.com>
Gerrit-Reviewer: Hannah Williams <hannah.williams(a)intel.com>
Gerrit-Reviewer: Lijian Zhao <lijian.zhao(a)intel.com>
Gerrit-Reviewer: Maulik V Vaghela <maulik.v.vaghela(a)intel.com>
Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Comment-Date: Tue, 24 Apr 2018 03:34:02 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No