Mario Scheithauer has posted comments on this change. ( https://review.coreboot.org/25585 )
Change subject: siemens/mc_apl1: Fix for using IDT PMIC
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/#/c/25585/1/src/mainboard/siemens/mc_apl1/mainb…
File src/mainboard/siemens/mc_apl1/mainboard.c:
https://review.coreboot.org/#/c/25585/1/src/mainboard/siemens/mc_apl1/mainb…
PS1, Line 146: printk(BIOS_ERR, "PMIC: Mailbox interface busy!\n");
> is this delay required here? if not, you might be better off by using the stopwatch API from src/inc […]
Hello Patrick, thanks for the review!
I'm using stopwatch API now, not quite as you suggested, but that should also work.
--
To view, visit https://review.coreboot.org/25585
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I77faf95951d03ac6ce97a6721dba6e8466122a25
Gerrit-Change-Number: 25585
Gerrit-PatchSet: 2
Gerrit-Owner: Mario Scheithauer <mario.scheithauer(a)siemens.com>
Gerrit-Reviewer: Mario Scheithauer <mario.scheithauer(a)siemens.com>
Gerrit-Reviewer: Werner Zeh <werner.zeh(a)siemens.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Patrick Georgi <pgeorgi(a)google.com>
Gerrit-Comment-Date: Tue, 10 Apr 2018 15:33:05 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/25606 )
Change subject: nb/intel/x4x: Put stage cache in TSEG
......................................................................
Patch Set 3:
No Builds Executed
--
To view, visit https://review.coreboot.org/25606
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie46c1416f8042d5571339b36e1253c0cae0684b8
Gerrit-Change-Number: 25606
Gerrit-PatchSet: 3
Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Comment-Date: Tue, 10 Apr 2018 15:27:18 +0000
Gerrit-HasComments: No
Gerrit-HasLabels: No
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/25605 )
Change subject: nb/intel/pineview: Put stage cache in TSEG
......................................................................
Patch Set 3:
No Builds Executed
--
To view, visit https://review.coreboot.org/25605
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3d163e8ff328ba01425b524a673f34a96fb93ea7
Gerrit-Change-Number: 25605
Gerrit-PatchSet: 3
Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Comment-Date: Tue, 10 Apr 2018 15:27:18 +0000
Gerrit-HasComments: No
Gerrit-HasLabels: No